Acked-by: Fam Zheng
From: "zhenwei pi"
Date: 2025年5月28日 (周三) 04:32
Subject: [PATCH] MAINTAINERS: update email of zhenwei pi
To:
Cc: , "zhenwei pi"
I will leave ByteDance in the next days. Update email to stay reachable.
Signed-off-by: zhenwei pi
---
MAINTAINERS | 2 +
From: Fam Zheng
If the text description file is larger than DESC_SIZE, we force the last
byte in the buffer to be 0 and write it out.
This results in a corruption.
Try to allocate a big buffer in this case.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1923
Signed-off-by: Fam Zheng
This adds a memset to clear the backing memory. This is useful in the
case of PMEM DAX to drop dirty data, if the backing memory is handed
over from a previous application or firmware which didn't clean up
before exiting.
Signed-off-by: Fam Zheng
---
backends/hostmem-file.c
ld be interesting since these new approaches seem to be replacing
> qemu-nbd.
In addition, there was also qemu-tcmu, (more PoC compared to other options):
https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg04408.html
Fam
>
> Can you share more about your use cases for the dm-qcow2 target? It
> could be useful for everyone I've CCed to be aware of various efforts in
> this area.
>
> Thanks,
> Stefan
On 2022-05-11 13:13, Philippe Mathieu-Daudé via wrote:
> +Fam
> On Wed, May 11, 2022 at 1:03 PM Thomas Huth wrote:
> > On 11/05/2022 12.46, Philippe Mathieu-Daudé wrote:
> > > +Robert
> > >
> > > On Wed, May 11, 2022 at 11:30 AM Daniel P. Berrangé
>
On 2022-04-22 09:52, Daniel P. Berrangé wrote:
> On Fri, Apr 22, 2022 at 09:34:28AM +0100, Fam Zheng wrote:
> > On 2022-04-22 00:36, Sam Li wrote:
> > > Linux recently added a new io_uring(7) optimization API that QEMU
> > > doesn't take advantage of yet. The
_reportf_err(*errp,
> + "failed to register linux io_uring ring file
> descriptor");
IIUC errp can be NULL, so let's not dereference it without checking. So, just
use error_report?
Fam
> +}
>
> +return s;
> }
>
> void luring_cleanup(LuringState *s)
> --
> Use error_reportf_err to avoid memory leak due to not freeing error
> object.
> --
> 2.35.1
>
>
_errno(errp, errno,
> + "failed to register linux io_uring ring file
> descriptor");
> +}
>
> +return s;
As a general convention, I don't think the errp is going to get proper handling
by the callers, if non-NULL is returned like here. I
@
> #define MODE_PAGE_FAULT_FAIL 0x1c
> #define MODE_PAGE_TO_PROTECT 0x1d
> #define MODE_PAGE_CAPABILITIES0x2a
> +#define MODE_PAGE_APPLE 0x30
> #define MODE_PAGE_ALLS0x3f
> /* Not in Mt. Fuji, but in ATAPI 2.6 -- deprecated now in favor
> * of MODE_PAGE_SENSE_POWER */
> --
> 2.20.1
>
>
Fam
On 2022-04-11 12:23, Steven Sistare wrote:
> On 3/29/2022 7:03 AM, Fam Zheng wrote:
> > On 2021-08-06 14:43, Steve Sistare wrote:
> >> Preserve vfio INTX state across cpr restart. Preserve VFIOINTx fields as
> >> follows:
> >> pin : Recover this
ext is close: it looks
like this series only takes care of exec restart mode of vfio-pci, have you had
any thoughts on kexec reboot mode with vfio-pci?
The general idea is if DMAR context is not lost during kexec, we should be able
to set up irqfds again and things will just work?
Fam
--
PS s
refore, I am asking permission from the current authors of this
> tool to loosen the license. At present, those people are:
>
> - John Snow (me!), 411/609
> - Luiz Capitulino, Author, 97/609
> - Daniel Berrangé, 81/609
> - Eduardo Habkost, 10/609
> - Marc-André Lureau, 6/60
> On 22 Jun 2021, at 13:42, Philippe Mathieu-Daudé wrote:
>
> On 6/22/21 10:06 AM, Philippe Mathieu-Daudé wrote:
>> On 6/22/21 9:29 AM, Philippe Mathieu-Daudé wrote:
>>> On 6/21/21 5:36 PM, Fam Zheng wrote:
>>>>> On 21 Jun 2021, at 16:13, Philippe Mathie
> On 21 Jun 2021, at 16:13, Philippe Mathieu-Daudé wrote:
>
> On 6/21/21 3:18 PM, Fam Zheng wrote:
>>
>>
>>> On 21 Jun 2021, at 10:32, Philippe Mathieu-Daudé wrote:
>>>
>>> When the NVMe block driver was introduced (see commit bdd6a90a9e5,
&
: blk_get_aio_context:
> Assertion `ctx == blk->ctx' failed.
Hi Phil,
The diff looks good to me, but I’m not sure what exactly caused the assertion
failure. There is `if (r) { goto fail; }` that handles -ENOSPC before, so it
should be treated as a general case. What am I missing?
Revie
nc.c | 25 +
> util/main-loop.c | 4 ++--
> 5 files changed, 55 insertions(+), 11 deletions(-)
>
> --
> 2.30.2
>
Reviewed-by: Fam Zheng
My time on QEMU is rather limited and I could hardly look at testing
patches for long. So it makes sense to drop me.
Acked-by: Fam Zheng
Thanks!
Fam
On Mon, 8 Mar 2021 at 15:50, Thomas Huth wrote:
> The status of the gitlab-CI files is currently somewhat confusing, and
> it is oft
On Wed, 10 Mar 2021 at 15:02, Max Reitz wrote:
> On 10.03.21 15:17, f...@euphon.net wrote:
> > From: Fam Zheng
> >
> > null-co:// has a read-zeroes=off default, when used to in security
> > analysis, this can cause false positives because the driver doesn
On Wed, 10 Mar 2021 at 14:41, Vladimir Sementsov-Ogievskiy <
vsement...@virtuozzo.com> wrote:
> 10.03.2021 17:17, f...@euphon.net wrote:
> > From: Fam Zheng
> >
> > null-co:// has a read-zeroes=off default, when used to in security
> > analysis, this can cause f
On Wed, 10 Mar 2021 at 14:51, Philippe Mathieu-Daudé
wrote:
> On 3/10/21 3:28 PM, Fam Zheng wrote:
> > On Wed, 10 Mar 2021 at 14:24, Philippe Mathieu-Daudé > <mailto:phi...@redhat.com>> wrote:
> >
> > On 3/10/21 3:17 PM, f...@euphon.net <mailto:f...@eu
On Wed, 10 Mar 2021 at 14:24, Philippe Mathieu-Daudé
wrote:
> On 3/10/21 3:17 PM, f...@euphon.net wrote:
> > From: Fam Zheng
> >
> > null-co:// has a read-zeroes=off default, when used to in security
> > analysis, this can cause false positives because the driver do
On Wed, 10 Mar 2021 at 12:38, Philippe Mathieu-Daudé
wrote:
> On 3/10/21 1:32 PM, Fam Zheng wrote:
> > On Wed, 10 Mar 2021 at 11:44, Philippe Mathieu-Daudé > <mailto:phi...@redhat.com>> wrote:
> >
> > Hi,
> >
> > This is an alternative approa
From: Fam Zheng
null-co:// has a read-zeroes=off default, when used to in security
analysis, this can cause false positives because the driver doesn't
write to the read buffer.
null-co:// has the highest possible performance as a block driver, so
let's keep it that way. This patch
> docs/secure-coding-practices: Describe null-co/zeroes-co block drivers
>
> docs/devel/secure-coding-practices.rst | 7 +
> block/zeroes.c | 306 +
>
Why not add another BlockDriver struct to block/null.c and set the
read_ze
On 2021-02-23 17:01, Max Reitz wrote:
> On 23.02.21 10:21, Fam Zheng wrote:
> > On 2021-02-22 18:55, Philippe Mathieu-Daudé wrote:
> > > On 2/22/21 6:35 PM, Fam Zheng wrote:
> > > > On 2021-02-19 15:09, Philippe Mathieu-Daudé wrote:
> > > > > On 2/19
On 2021-02-22 18:55, Philippe Mathieu-Daudé wrote:
> On 2/22/21 6:35 PM, Fam Zheng wrote:
> > On 2021-02-19 15:09, Philippe Mathieu-Daudé wrote:
> >> On 2/19/21 12:07 PM, Max Reitz wrote:
> >>> On 13.02.21 22:54, Fam Zheng wrote:
> >>>> On 2
On 2021-02-19 15:09, Philippe Mathieu-Daudé wrote:
> On 2/19/21 12:07 PM, Max Reitz wrote:
> > On 13.02.21 22:54, Fam Zheng wrote:
> >> On 2021-02-11 15:26, Philippe Mathieu-Daudé wrote:
> >>> The null-co driver doesn't zeroize buffer in its default config,
>
just somehow annotate it in a way that the checker can
understand (akin to how we provide coverity models) and be done?
Thanks,
Fam
>
> A one-line patch supposed which became a painful one, because
> there is so many different syntax to express the same usage:
>
> opt = qdict_new()
}
Accepting the report sounds sane to me, it matches what we actually
(always) do. Is the idea to allow users to spell it out explicitly in
the command line?
Reviewed-by: Fam Zheng
On Fri, 2020-10-30 at 05:01 -0400, Michael S. Tsirkin wrote:
> On Wed, Sep 30, 2020 at 10:32:42AM +0530, P J P wrote:
> >
> > [+Paolo, +Fam Zheng - for scsi]
> >
> > +-- On Mon, 28 Sep 2020, P J P wrote --+
> > > +-- On Wed, 16 Sep 2020, Peter Maydell wrote -
b'io_submit_one'
> > > b'__x64_sys_io_submit'
> > > b'do_syscall_64'
> > > b'entry_SYSCALL_64_after_hwframe'
> > > -fio (1464)
> > > 40031912
> > >
> &g
On Wed, 2020-10-14 at 14:42 +0200, Philippe Mathieu-Daudé wrote:
> On 10/14/20 2:34 PM, Fam Zheng wrote:
> > On Wed, 2020-10-14 at 13:52 +0200, Philippe Mathieu-Daudé wrote:
> > > A bunch of boring patches that have been proven helpful
> > > while debugging.
> > &
++
>
> util/trace-events | 10 --
> 4 files changed, 54 insertions(+), 38 deletions(-)
>
> --
> 2.26.2
>
>
>
Modular the g_strdup_printf() memleak I pointed out:
Reviewed-by: Fam Zheng
@ static int qemu_vfio_pci_init_bar(QEMUVFIOState
> *s, int index, Error **errp)
> error_setg_errno(errp, errno, "Failed to get BAR region
> info");
> return -errno;
> }
> +barname = g_strdup_printf("bar[%d]", index);
ing stuff to gitlab we might as well move there and
> bump the timeout.
>
> Signed-off-by: Alex Bennée
Hi Alex,
Unrelated to the patch: do we have custom runners on gitlab? I'm
exploring ideas to run vm based tests there.
Fam
VMDK4Header header;
> -VmdkExtent *extent;
> +VmdkExtent *extent = NULL;
> BDRVVmdkState *s = bs->opaque;
> int64_t l1_backup_offset = 0;
> bool compressed;
> @@ -1088,7 +1088,7 @@ static int vmdk_parse_extents(const char *desc,
> BlockDriverState *bs,
> BdrvChild *extent_file;
> BdrvChildRole extent_role;
> BDRVVmdkState *s = bs->opaque;
> -VmdkExtent *extent;
> +VmdkExtent *extent = NULL;
> char extent_opt_prefix[32];
> Error *local_err = NULL;
>
Looks trivial, and correct.
Reviewed-by: Fam Zheng
);
> > > return 0;
> > > fail:
> > > +g_free(s->usable_iova_ranges);
> >
> > Set s->usable_iova_ranges to NULL to avoid double free?
>
> I think I did at the beginning of qemu_vfio_init_pci()
Yes, but I mean clearing the pointer wi
_DEVICE_FD, device);
>
> if (s->device < 0) {
> @@ -365,8 +430,12 @@ static int qemu_vfio_init_pci(QEMUVFIOState *s, const
> char *device,
> if (ret) {
> goto fail;
> }
> +g_free(iommu_info);
> return 0;
> fail:
> + g_free(s->usable_iova_ranges);
Set s->usable_iova_ranges to NULL to avoid double free?
> +s->nb_iova_ranges = 0;
> +g_free(iommu_info);
> close(s->group);
> fail_container:
> close(s->container);
> @@ -716,6 +785,8 @@ void qemu_vfio_close(QEMUVFIOState *s)
> qemu_vfio_undo_mapping(s, &s->mappings[i], NULL);
> }
> ram_block_notifier_remove(&s->ram_notifier);
> +g_free(s->usable_iova_ranges);
> +s->nb_iova_ranges = 0;
> qemu_vfio_reset(s);
> close(s->device);
> close(s->group);
> --
> 2.21.3
>
>
Fam
-
>
> util/vfio-helpers.c | 4 +-
> 3 files changed, 44 insertions(+), 35 deletions(-)
>
Reviewed-by: Fam Zheng
On Tue, 2020-09-22 at 10:41 +0200, Philippe Mathieu-Daudé wrote:
> Hi Fam,
>
> +Paolo?
>
> On 9/22/20 10:18 AM, Fam Zheng wrote:
> > On Mon, 2020-09-21 at 18:29 +0200, Philippe Mathieu-Daudé wrote:
> > > Per the datasheet sections 3.1.13/3.1.14:
> > >
to this mapped address in the
> BDRVNVMeState structure.
Besides looking more correct in access mode, is there any side effect
of WO mapping?
Fam
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/nvme.c | 29 +++--
> 1 file changed, 19 insert
On 2020-09-19 10:22, Zhenyu Ye wrote:
> On 2020/9/18 22:06, Fam Zheng wrote:
> >
> > I can see how blocking in a slow io_submit can cause trouble for main
> > thread. I think one way to fix it (until it's made truly async in new
> > kernels) is moving the io
ot sure qmp timeout is a complete solution because we would still
suffer from a blocked state for a period, in this exact situation before
the timeout.
Fam
virtio_queue_notify_aio_vq
virtio_blk_data_plane_handle_output
virtio_blk_handle_vq
blk_io_unplug
bdrv_io_unplug
bdrv_io_unplug
raw_aio_unplug
laio_io_unplug
syscall
So the iothread is blocked by a slow io_submit holding the AioContext
lock.
It would be interesting to know what in kernel is blocking io_submit
from returning.
Fam
ff95f00a7c in g_main_context_dispatch ()
> from target:/usr/lib64/libglib-2.0.so.0
> #20 0xbb2128e8 in glib_pollfds_poll ()
> #21 0xbb212970 in os_host_main_loop_wait (timeout=64805420)
> #22 0xbb212a90 in main_loop_wait (nonblocking=0)
> #23 0xbaad63d0 in qemu_main_loop ()
> #24 0xbb188b54 in main (argc=117, argv=0xca669a68,
> envp=0xca669e18)
>
> And the QEMU process backtrace in kernel is:
> [<0>] __switch_to+0xdc/0x140
> [<0>] futex_wait_queue_me+0xd4/0x158
> [<0>] futex_wait+0xf4/0x230
> [<0>] do_futex+0x46c/0x608
> [<0>] __arm64_sys_futex+0x13c/0x188
> [<0>] el0_svc_common+0x80/0x1b8
> [<0>] el0_svc_handler+0x38/0x78
> [<0>] el0_svc+0x10/0x14
> [<0>] 0x
Hi Zhenyu,
Did you by any chance capture the kernel stack where io_submit is stuck?
Thanks,
Fam
> Signed-off-by: Philippe Mathieu-Daudé
Fam
s
> function to initialize multiple MSIX IRQs and attach eventfd to
> them.
>
> Since RFC v4:
> - addressed Alex review comment:
> check ioctl(VFIO_DEVICE_SET_IRQS) return value
Reviewed-by: Fam Zheng
error_setg(errp, "Unsupported IOMMU page size: %s", host_page_size);
> +error_append_hint(errp, "Available page size:\n");
> +for (int i = 0; i < 64; i++) {
> +if (extract64(iommu_info.iova_pgsizes, i, 1)) {
> + g_
On 2020-09-07 12:16, Stefan Hajnoczi wrote:
> Development of the userspace NVMe block driver picked up again recently.
> After talking with Fam I am stepping up as block/nvme.c maintainer.
> Patches will be merged through my 'block' tree.
>
> Cc: Kevin Wolf
> Cc: K
hieu-Daudé (3):
> block/nvme: Group controller registers in NVMeRegs structure
> block/nvme: Use generic NvmeBar structure
> block/nvme: Pair doorbell registers
>
> block/nvme.c | 43 +++
> 1 file changed, 15 insertions(+), 28 deletions(-)
>
> --
> 2.26.2
>
>
Reviewed-by: Fam Zheng
On Tue, 10/15 12:38, Klaus Jensen wrote:
> Hi,
>
> (Quick note to Fam): most of this series is irrelevant to you as the
> maintainer of the nvme block driver, but patch "nvme: add support for
> scatter gather lists" touches block/nvme.c due to changes in the shared
>
git where I'm going to work
> through some test cases for setting profile variables and try to fix this.
>
> In the meantime:
>
> Signed-off-by: John Snow
Isn't this because you inserted a '---' line in the middle of the commit
message so the part after it is ditched by 'git am'?
This feels a bit hard to catch, wondering what is in the works. :)
Fam
which the build fails.
>
> Is this possible to add this in the mail (or in the logs)?
I've moved the env/rpm/uname commands before the actual testing commands, so
the information can be collected even upon failures.
Fam
>
> ...
> > CC microblaze-linu
quot; flags %d ret %"PRId64
>
> +#io_uring.c
> +luring_init_state(void *s, size_t size) "s %p size %zu"
> +luring_cleanup_state(void) "s freed"
> +disable luring_io_plug(void) "plug"
> +disable luring_io_unplug(int blocked, int plugged, int queued, int inflight)
> "blocked %d plugged %d queued %d inflight %d"
> +disable luring_do_submit(int blocked, int plugged, int queued, int inflight)
> "blocked %d plugged %d queued %d inflight %d"
> +disable luring_do_submit_done(int ret) "submitted to kernel %d"
> +
> # qcow2.c
> qcow2_writev_start_req(void *co, int64_t offset, int bytes) "co %p offset
> 0x%" PRIx64 " bytes %d"
> qcow2_writev_done_req(void *co, int ret) "co %p ret %d"
> --
> 2.17.1
>
Fam
case 'k':
> flags |= BDRV_O_NATIVE_AIO;
> break;
> +#ifdef CONFIG_LINUX_IO_URING
> + case 'i':
Maybe printing an error message saying the feature is not compiled in is
slightly better than just saying the argument is un
On Mon, 06/10 19:18, Aarushi Mehta wrote:
> Aborts when sqe fails to be set as sqes cannot be returned to the ring.
>
> Signed-off-by: Aarushi Mehta
> ---
> MAINTAINERS | 7 +
> block/Makefile.objs | 3 +
> block/io_uring.c| 314 +++
On Mon, 06/10 19:18, Aarushi Mehta wrote:
> Option only enumerates for hosts that support it.
>
> Signed-off-by: Aarushi Mehta
> Reviewed-by: Stefan Hajnoczi
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/blo
On Wed, 04/17 22:53, Maxim Levitsky wrote:
> Signed-off-by: Maxim Levitsky
> ---
> block/nvme.c | 80 ++
> block/trace-events | 2 ++
> 2 files changed, 82 insertions(+)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 35b925899f..b83912c627
On Wed, 04/17 22:53, Maxim Levitsky wrote:
> Signed-off-by: Maxim Levitsky
> ---
> block/nvme.c | 69 +++-
> block/trace-events | 1 +
> include/block/nvme.h | 19 +++-
> 3 files changed, 87 insertions(+), 2 deletions(-)
>
> diff --git a
}
> ret = raw_apply_lock_bytes(s, s->fd, s->perm | new_perm,
> ~s->shared_perm | ~new_shared,
> false, errp);
> --
> 2.18.0
>
>
Reviewed-by: Fam Zheng
@echo ' "IMAGE" is one of the listed container
> name.'
> @echo 'docker-image:Build all images.'
> @echo 'docker-image-IMAGE: Build image "IMAGE".'
> - @echo 'docker-run: For manually running a "TEST" with
> "IMAGE"'
> + @echo 'docker-run: For manually running a "TEST" with
> "IMAGE".'
> @echo
> @echo 'Available container images:'
> @echo '$(DOCKER_IMAGES)'
> --
> 2.20.1
>
>
Reviewed-by: Fam Zheng
> On Mar 15, 2019, at 01:31, Sergio Lopez wrote:
>
> Hi,
>
> Our current AIO path does a great job at unloading the work from the VM,
> and combined with IOThreads provides a good performance in most
> scenarios. But it also comes with its costs, in both a longer execution
> path and the need
ow
testing more subjects.
Tesing private branches are much more costly depending on test set size and
developer numbers. Maybe it’ll be have to limited to maintainer branches first.
Fam
>
> Stefan
nabled: false
> + requirements: ppcle
> + script: |
> +#!/bin/bash
> +INSTALL=$PWD/install
> +BUILD=$PWD/build
> +mkdir -p $BUILD $INSTALL
> +SRC=$PWD
> +cd $BUILD
> +$SRC/configure --prefix=$INSTALL
> +make -j14
> +
> +ppcbe:
> + enabled: false
> + requirements: ppcbe
> + script: |
> +#!/bin/bash
> +INSTALL=$PWD/install
> +BUILD=$PWD/build
> +mkdir -p $BUILD $INSTALL
> +SRC=$PWD
> +cd $BUILD
> +$SRC/configure --prefix=$INSTALL
> +make -j14
> +
> +s390x:
> + enabled: false
> + requirements: ppcle
> + script: |
> +#!/bin/bash
> +INSTALL=$PWD/install
> +BUILD=$PWD/build
> +mkdir -p $BUILD $INSTALL
> +SRC=$PWD
> +cd $BUILD
> +$SRC/configure --prefix=$INSTALL
> +make -j14
> --
> 2.20.1
>
>
Reviewed-by: Fam Zheng
> On Mar 15, 2019, at 17:58, Alex Bennée wrote:
>
>
> Fam Zheng writes:
>
>>> On Mar 15, 2019, at 16:57, Alex Bennée wrote:
>>>
>>> I had installed the gitlab-runner from the Debian repo but it was out
>>> of date and didn't seem
-runner, the test script (in .gitlab-ci.yml)
can then sshs into the actual env to run test commands.
Fam
environments and I expect tweakings will be needed to get the automation
smooth, but it is fairly straigtforward and managable:
https://docs.gitlab.com/runner/
Fam
>
> thanks
> -- PMM
>
> On Mar 12, 2019, at 18:03, Kevin Wolf wrote:
>
> Am 12.03.2019 um 03:18 hat Fam Zheng geschrieben:
>>> On Mar 11, 2019, at 19:06, Kevin Wolf wrote:
>>> Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben:
>>>> Thanks for explaining the backgroun
> On Mar 11, 2019, at 19:06, Kevin Wolf wrote:
>
> Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben:
>> Thanks for explaining the background. It comes to my mind that actually we
>> talked about these two cases with Fam a bit long time ago and decided to
>> suppor
e
> not blocked on the SDL 1 removal anymore.
Oops. I was seriously distracted from the external mail folders recently..
Updated the image, please test it.
Fam
e
> not blocked on the SDL 1 removal anymore.
Oops. I was seriously distracted from the external mail folders recently..
Updated the image, please test it.
Fam
> On Jan 9, 2019, at 21:59, Daniel P. Berrangé wrote:
>
> On Wed, Jan 09, 2019 at 01:55:04PM +, Daniel P. Berrangé wrote:
>> On Wed, Nov 14, 2018 at 05:58:07PM +0800, Fam Zheng wrote:
>>> On Sun, 11/11 18:20, Brad Smith wrote:
>>>> ping.
>>&g
20181101103807.25862-1-lifeng1...@gmail.com>
Signed-off-by: Fam Zheng
---
block/nvme.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 29294038fc..982097b5b1 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -837,7 +837,7 @@ try_m
it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20181101183705.5422-1-phi...@redhat.com>
Signed-off-by: Fam Zheng
---
tests/docker/dockerfiles/debian-sid.docker | 4
1 file changed,
The following changes since commit 147923b1a901a0370f83a0f4c58ec1baffef22f0:
Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190108-pull-request'
into staging (2019-01-08 16:07:32 +)
are available in the git repository at:
https://github.com/famz/qemu.git tags/staging-pull-reque
From: Fam Zheng
Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1,
include SDL2.
Also do the build in $HOME since both /var/tmp and /tmp are tmpfs with
limited capacities.
Signed-off-by: Fam Zheng
Message-Id: <20181031025712.18602-1-f...@redhat.com>
Signed-off-by: Fam
20181101103807.25862-1-lifeng1...@gmail.com>
Signed-off-by: Fam Zheng
---
block/nvme.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 29294038fc..982097b5b1 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -837,7 +837,7 @@ try_m
it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20181101183705.5422-1-phi...@redhat.com>
Signed-off-by: Fam Zheng
---
tests/docker/dockerfiles/debian-sid.docker | 4
1 file changed,
sting-pull-request
for you to fetch changes up to 3baa6942169cce0f58b88484ad010742c382480a:
tests: vm: auto_install OpenBSD (2019-01-02 20:51:15 +0800)
Pull request
----
> On Dec 20, 2018, at 19:20, Philippe Mathieu-Daudé wrote:
>
> Hi Fam,
>
> On 11/2/18 8:24 AM, Fam Zheng wrote:
>> On Fri, Nov 2, 2018 at 3:20 PM Philippe Mathieu-Daudé
>> wrote:
>>>
>>> Hi Fam,
>>>
>>> Thanks for picking
http. Now it’s back to work.
Fam
>
> Regards,
>
> Phil.
the same fd, how can this happen?
I think in this case BQL is used to synchronize them so when v9fs_reset runs,
the main loop doesn't.
Thanks,
Fam
>
> Thanks,
> Li Qiang
>
>
> 发件人: Paolo Bonzini
> 发送时间: 2018年12月20日 4:42
> 收件人: Li Qiang; stefa...@redhat.com; f...
icate expired on 19 November 2017, 00:27:00 GMT.
>> # The current time is 14 December 2018, 09:52.
>> # Error code: SEC_ERROR_EXPIRED_CERTIFICATE
>>
>> which is a bit odd, given I don't think this has been
>> broken since 2017. Did a cert-renewal script go wrong
;> + static void kvmppc_xive_sync_all(sPAPRXive *xive, Error **errp)
>> ^
>>
>> total: 1 errors, 0 warnings, 135 lines checked
>
> This looks like a false positive.
Right. Without looking at the checkpatch code, I suspect this is due to
sPAPRXive starts with a lower case letter which is not standard.
Fam
>
> C.
>
earch and replace.
Signed-off-by: Fam Zheng
Signed-off-by: Fam Zheng
---
MAINTAINERS | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1032406c56..906d40d06d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1252,7 +1252,7 @@ T
le of is_external == true. It means the events
handler on this fd may initiate more I/O, such as read/write on virtual storage
backend, so are specially taken care of at certain points when we won't want
more I/O requests to be processed, such as when a block job is completing, or in
the middle of a QMP transaction.
Fam
On Sun, 11/11 18:20, Brad Smith wrote:
> ping.
Queued. Will send a pull request soon.
Fam
>
> On 10/30/2018 10:57 PM, Fam Zheng wrote:
> > Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1,
> > include SDL2.
> >
> > Also do the build in $HOME
On Thu, 10/11 15:21, Fam Zheng wrote:
> v5: Address Max's comments (Thanks for reviewing):
> - Clean up after test done.
> - Add rev-by to patch 1 and 2.
Ping?
Fam
On Tue, 11/06 01:50, no-re...@patchew.org wrote:
> ERROR: unknown option --with-gtkabi=3.0
Patchew is testing old series branches of which are heavily lagging behind. This
configure option in the mingw docker testing is recently dropped, so it's a
false positive.
Fam
> Try '/t
On Fri, Nov 2, 2018 at 3:20 PM Philippe Mathieu-Daudé wrote:
>
> Hi Fam,
>
> Thanks for picking this.
>
> On Fri, Nov 2, 2018 at 7:48 AM Fam Zheng wrote:
> > On Thu, 11/01 19:37, Philippe Mathieu-Daudé wrote:
> > > The Debian Sid repository is not garanteed to
lid-until=no]
> \1snapshot.debian.org/archive/debian/${DEBIAN_SNAPSHOT_DATE} \2%"
> /etc/apt/sources.list
> +
> # Duplicate deb line as deb-src
> RUN cat /etc/apt/sources.list | sed "s/^deb\ /deb-src /" >>
> /etc/apt/sources.list
>
> --
> 2.17.2
>
Queued, thanks!
Fam
i) {
> -pagelist[i] = cpu_to_le64(pagelist[i + 1]);
> - }
> -pagelist[entries - 1] = 0;
> +cmd->prp1 = pagelist[0];
> +cmd->prp2 = cpu_to_le64(req->prp_list_iova + sizeof(uint64_t));
> break;
> }
> trace_nvme_cmd_map_qiov(s, cmd, req, qiov, entries);
> --
> 2.11.0
>
Nice! Thanks. I've queued the patch.
Fam
_tmp = img + ".tmp"
> -subprocess.check_call(["cp", "-f", cimg, img_tmp_xz])
> -subprocess.check_call(["xz", "-df", img_tmp_xz])
> -if os.path.exists(img):
> -os.remove(img)
> -os.rename(img_tm
llers.
Suggested-by: Markus Armbruster
Signed-off-by: Fam Zheng
---
v3: Use error_setg_errno. [Eric]
v2: Add Error ** to raw_normalize_devicepath. [Markus]
Use error_printf for splitting multi-sentence message. [Markus]
---
block/file-posix.c | 39 ---
1
On Wed, 10/31 15:51, Markus Armbruster wrote:
> Fam Zheng writes:
>
> > Use error_report for situations that affect user operation (i.e. we're
> > actually returning error), and warn_report/warn_report_err when some
> > less critical error happened but the user
On Wed, 10/31 16:04, Fam Zheng wrote:
> Commit 9cbef9d68e (qemu-option: improve qemu_opts_print_help() output)
> affected qemu-img help output, and broke this test case.
>
> Update the output reference to fix it.
>
> Signed-off-by: Fam Zheng
>
> ---
>
> I&#x
Commit 9cbef9d68e (qemu-option: improve qemu_opts_print_help() output)
affected qemu-img help output, and broke this test case.
Update the output reference to fix it.
Signed-off-by: Fam Zheng
---
I'm once again looking at enabling iotests on patchew (via vm based
tests), but immediatel
llers.
Suggested-by: Markus Armbruster
Signed-off-by: Fam Zheng
---
v2: Add Error ** to raw_normalize_devicepath. [Markus]
Use error_printf for splitting multi-sentence message. [Markus]
---
block/file-posix.c | 39 ---
1 file changed, 16 insertions(+), 23 dele
Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1,
include SDL2.
Also do the build in $HOME since both /var/tmp and /tmp are tmpfs with
limited capacities.
Signed-off-by: Fam Zheng
---
v4: Use 6.4. [Brad]
---
tests/vm/basevm.py | 6 ++--
tests/vm/openbsd | 85
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20181013004034.6968-7-f4...@amsat.org>
Reviewed-by: Richard Henderson
Signed-off-by: Fam Zheng
---
scripts/qemu.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
1 - 100 of 9220 matches
Mail list logo
