[Qemu-devel] [PATCH v1 1/1] (for-2.5) virtio-scsi: don't crash without a valid device

2015-11-26 Thread Eugene (jno) Dvurechenski
Make sure that we actually have a device when checking the aio context. Otherwise guests could trigger QEMU crashes. Signed-off-by: "Eugene (jno) Dvurechenski" Reviewed-by: David Hildenbrand --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 0/1] (for-2.5) Don't allow a guest to crash QEMU

2015-11-26 Thread Eugene (jno) Dvurechenski
I've found the case where erratic guest was able to crash QEMU. This patch prevents dereferencing of a NULL pointer (empty 'd' in the assertion, no valid LUN was specified). Eugene (jno) Dvurechenski (1): virtio-scsi: don't crash without a valid device hw/scsi/virtio-s

Re: [Qemu-devel] [PULL 03/10] pc-bios/s390-ccw: handle different sector sizes

2014-06-27 Thread Eugene "jno" Dvurechenski
Yes, this patch doesn't make the code worse. On 06/27/2014 05:11 PM, Christian Borntraeger wrote: > On 27/06/14 15:04, Eugene "jno" Dvurechenski wrote: >> >> >> On 06/27/2014 03:55 PM, Christian Borntraeger wrote: >>>>> -const i

Re: [Qemu-devel] [PULL 03/10] pc-bios/s390-ccw: handle different sector sizes

2014-06-27 Thread Eugene "jno" Dvurechenski
d preserve both checks. In theory, we may catch a table that consumes all scratch space and leave no unused entry. Plus, this check for zero counter and last entry is for "continuation" pointer, not for end-of-table by itself. I think now, this code may need even few more checks to co

Re: [Qemu-devel] [PULL 03/10] pc-bios/s390-ccw: handle different sector sizes

2014-06-27 Thread Eugene "jno" Dvurechenski
the real > sector size? This is the top limit for a table that takes entire block. Real end-of-table is being handled by the code. -- Best Regards, Eugene "jno" Dvurechenski zLinux (KVM) Development - Software Engineer IBM Russia - Science & Technology Center phone: +7 (495) 66

Re: [Qemu-devel] [PATCH 03/10] pc-bios/s390-ccw: handle different sector sizes

2014-06-26 Thread Eugene "jno" Dvurechenski
torage allocation (and similar static calculations) now. -- Best Regards, Eugene "jno" Dvurechenski zLinux (KVM) Development - Software Engineer IBM Russia - Science & Technology Center phone: +7 (495) 660 8940 ext. 1021 <> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 3/4] pc-bios/s390-ccw: fix for fragmented SCSI bootmap

2014-06-18 Thread Eugene &quot;jno" Dvurechenski
unused_space(const void *p, size_t size) +{ +size_t i; -- Best Regards, Eugene "jno" Dvurechenski zLinux (KVM) Development - Software Engineer IBM Russia - Science & Technology Center phone: +7 (495) 660 8940 ext. 1021 <> signature.asc Description: OpenPGP digital signature