Re: [PATCH] target/i386/kvm: call kvm_put_vcpu_events() before kvm_put_nested_state()

2024-01-15 Thread Eiichi Tsukata
Ping. > On Nov 8, 2023, at 10:12, Eiichi Tsukata wrote: > > Hi all, appreciate any comments or feedbacks on the patch. > > Thanks, > Eiichi > >> On Nov 1, 2023, at 23:04, Vitaly Kuznetsov wrote: >> >> Eiichi Tsukata writes: >> >>> FYI:

Re: [PATCH] target/i386/kvm: call kvm_put_vcpu_events() before kvm_put_nested_state()

2023-11-07 Thread Eiichi Tsukata
Hi all, appreciate any comments or feedbacks on the patch. Thanks, Eiichi > On Nov 1, 2023, at 23:04, Vitaly Kuznetsov wrote: > > Eiichi Tsukata writes: > >> FYI: The EINVAL in vmx_set_nested_state() is caused by the following >> condition: >> * vcpu-&g

Re: [PATCH] target/i386/kvm: call kvm_put_vcpu_events() before kvm_put_nested_state()

2023-10-31 Thread Eiichi Tsukata
sted_state, >>> struct kvm_nested_state *kvm_state) >>> { >>> .. /* * SMM temporarily disables VMX, so we cannot >>> be in guest mode, >>> * nor can VMLAUNCH/VMRESUME be pending. Out

Re: [PATCH] target/i386/kvm: call kvm_put_vcpu_events() before kvm_put_nested_state()

2023-10-25 Thread Eiichi Tsukata
mm(vcpu) && (kvm_state->flags & KVM_STATE_NESTED_GUEST_MODE)) return -EINVAL; .. Thanks, Eiichi > On Oct 26, 2023, at 14:42, Eiichi Tsukata wrote: > > kvm_put_vcpu_events() needs to be called before kvm_put_nested_state() > because vCPU's hflag is r

[PATCH] target/i386/kvm: call kvm_put_vcpu_events() before kvm_put_nested_state()

2023-10-25 Thread Eiichi Tsukata
ilure. Signed-off-by: Eiichi Tsukata --- target/i386/kvm/kvm.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index e7c054cc16..cd635c9142 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -4741,6 +4741,15 @

[PATCH] physmem: use PR_SET_VMA_ANON_NAME to set ram block name

2023-04-10 Thread Eiichi Tsukata
00:00 0 [anon:e1000.rom] ... Signed-off-by: Eiichi Tsukata --- meson.build | 2 ++ softmmu/physmem.c | 9 + 2 files changed, 11 insertions(+) diff --git a/meson.build b/meson.build index 29f8644d6d..aca889f5f0 100644 --- a/meson.build +++ b/meson.build @@ -2040,6

Bug report: QEMU/KVM: INIT-SIPI-SIPI while CPU is in SMM fails smp boot

2022-11-15 Thread Eiichi Tsukata
Hello QEMU/KVM folks I’m hitting a racy SMP boot issue with edk2/OVMF secure boot. It is caused by the race when SIPI is issued while CPU is in SMM. For details, please refer to the edk2/OVMF bugzilla ticket: https://bugzilla.tianocore.org/show_bug.cgi?id=4132 I’d like to know whether there is

Re: PING: [PATCH] KVM: HWPoison: Fix memory address&size during remap

2022-08-04 Thread Eiichi Tsukata
Hi We’ve also hit this case. > On May 5, 2022, at 9:32, zhenwei pi wrote: > > Hi, Paolo > > I would appreciate it if you could review patch. > > On 4/20/22 14:45, zhenwei pi wrote: >> qemu exits during reset with log: >> qemu-system-x86_64: Could not remap addr: 1000@22001000 >> Currently, a

Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2020-01-18 Thread Eiichi Tsukata
ping On 2019/12/23 18:06, Eiichi Tsukata wrote: > bdrv_open_driver() allocates bs->opaque according to drv->instance_size. > There is no need to allocate it and overwrite opaque in > bdrv_backup_top_append(). > > Reproducer: > > $ QTEST_QEMU_BINARY=./x86_64-softmmu/

Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2019-12-23 Thread Eiichi Tsukata
On 2019/12/23 21:40, Vladimir Sementsov-Ogievskiy wrote: > 23.12.2019 12:06, Eiichi Tsukata wrote: >> bdrv_open_driver() allocates bs->opaque according to drv->instance_size. >> There is no need to allocate it and overwrite opaque in >> bdrv_backup_top

[PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2019-12-23 Thread Eiichi Tsukata
1401B9: replication_start_all (replication.c:52) ==29792==by 0x128B50: test_secondary_start (test-replication.c:427) ... Fixes: 7df7868b9640 ("block: introduce backup-top filter driver") Signed-off-by: Eiichi Tsukata --- block/backup-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] target/i386: remove unused pci-assign codes

2019-12-09 Thread Eiichi Tsukata
Legacy PCI device assignment has been already removed in commit ab37bfc7d641 ("pci-assign: Remove"), but some codes remain unused. CC: qemu-triv...@nongnu.org Signed-off-by: Eiichi Tsukata --- target/i386/kvm.c | 140 - target/i386/kvm_i3

[Qemu-devel] [PATCH v2 1/2] trace: Add ftrace tracing backend

2013-04-11 Thread Eiichi Tsukata
-backend=ftrace $ make if you use KVM, enable kvm events in ftrace: # sudo echo 1 > /sys/kernel/debug/tracing/events/kvm/enable After running qemu by root user, you can get the trace: # cat /sys/kernel/debug/tracing/trace Signed-off-by: Eiichi Tsukata --- config

[Qemu-devel] [PATCH v2 0/2] New trace backend: ftrace

2013-04-11 Thread Eiichi Tsukata
an uprobe-based event tracer or SystemTap. My microbenchmark shows that ftrace tracing backend overhead is about 0.8us per tracepoint, whereas uprobe-based event tracer or SystemTap overhead is about 2.0us. Changes in v2: * fix Stefan's mail address. * use snprintf return value not to waste trac

[Qemu-devel] [PATCH v2 2/2] trace: document ftrace backend

2013-04-11 Thread Eiichi Tsukata
Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -175,6 +175,22

Re: [Qemu-devel] [PATCH 1/2] trace: Add ftrace tracing backend

2013-04-09 Thread Eiichi Tsukata
Hello Stefan, Thank you for reviewing my patch. (2013/04/08 23:10), Stefan Hajnoczi wrote: On Wed, Apr 03, 2013 at 03:30:58PM +0900, Eiichi Tsukata wrote: diff --git a/scripts/tracetool/backend/ftrace.py b/scripts/tracetool/backend/ftrace.py new file mode 100644 index 000..e02f0ca

[Qemu-devel] [PATCH 2/2] trace: document frace backend

2013-04-03 Thread Eiichi Tsukata
Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -175,6 +175,22

[Qemu-devel] [PATCH 1/2] trace: Add ftrace tracing backend

2013-04-03 Thread Eiichi Tsukata
-backend=ftrace $ make if you use KVM, enable kvm events in ftrace: # sudo echo 1 > /sys/kernel/debug/tracing/events/kvm/enable After running qemu by root user, you can get the trace: # cat /sys/kernel/debug/tracing/trace Signed-off-by: Eiichi Tsukata --- config

[Qemu-devel] [PATCH 0/2] New trace backend: ftrace

2013-04-03 Thread Eiichi Tsukata
an uprobe-based event tracer or SystemTap. My microbenchmark shows that ftrace tracing backend overhead is about 0.8us per tracepoint, whereas uprobe-based event tracer or SystemTap overhead is about 2.0us. Eiichi Tsukata (2): trace: Add ftrace tracing backend trace: document frace backen

[Qemu-devel] [PATCH 2/2] trace: document frace backend

2013-04-02 Thread Eiichi Tsukata
Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -175,6 +175,22

[Qemu-devel] [PATCH 1/2] trace: Add ftrace tracing backend

2013-04-02 Thread Eiichi Tsukata
-backend=ftrace $ make if you use KVM, enable kvm events in ftrace: # sudo echo 1 > /sys/kernel/debug/tracing/events/kvm/enable After running qemu by root user, you can get the trace: # cat /sys/kernel/debug/tracing/trace Signed-off-by: Eiichi Tsukata --- config

[Qemu-devel] [PATCH 0/2] New trace backend: ftrace

2013-04-02 Thread Eiichi Tsukata
an uprobe-based event tracer or SystemTap. My microbenchmark shows that ftrace tracing backend overhead is about 0.8us per tracepoint, whereas uprobe-based event tracer or SystemTap overhead is about 2.0us. Eiichi Tsukata (2): trace: Add ftrace tracing backend trace: document frace backen