Re: [PATCH v1 01/11] configure: don't override the selected host test compiler if defined

2021-09-20 Thread Ed Maste
On Fri, 17 Sept 2021 at 12:27, Alex Bennée wrote: > > There are not many cases you would want to do this but one is if you > want to use a test friendly compiler like gcc instead of a system > compiler like clang. Either way we should honour the users choice if > they have made it. A little bit o

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-20 Thread Ed Maste
On Mon, 20 Sept 2021 at 01:14, David Gibson wrote: > > I've updated my table entry to N/A on that basis. Thanks for the > clarification, this wasn't obvious to me from > https://www.freebsd.org/platforms/ (it says "Tier 4", without > explaining what that means). That is indeed a bit confusing. I

Re: [PATCH v0] kvm: unsigned datatype in ioctl wrapper

2021-08-30 Thread Ed Maste
On Mon, 30 Aug 2021 at 13:34, Peter Maydell wrote: > > # As noted, this does not actually cause problems on Linux, because > # unlike FreeBSD, Linux knows what the f*ck it is doing, and just > # ignores the upper bits exactly because of possible sign confusion. > > Whether that's still true a deca

Re: [PATCH v1 21/22] cirrus: use V=1 when running tests on FreeBSD and macOS

2020-10-07 Thread Ed Maste
ff-by: Paolo Bonzini > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > Message-Id: <20201007140103.711142-1-pbonz...@redhat.com> Reviewed-by: Ed Maste

Re: [PATCH v2 6/8] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD

2020-09-28 Thread Ed Maste
fdef'ry. > > This reverts commit de03c3164accc21311c39327601fcdd95da301f3 > ("bswap: Fix build on FreeBSD 10.0"). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Ed Maste Aside, to test building with this change on Clang 11 (default compiler in FreeBSD-CURRE

Re: [PATCH v2 0/7] hw/char/serial: Housekeeping

2020-09-12 Thread Ed Maste
On Sat, 12 Sep 2020 at 07:46, wrote: > > Patchew URL: https://patchew.org/QEMU/20200912114040.918464-1-f4...@amsat.org/ > > Hi, > > This series failed build test on FreeBSD host. Please find the details below. > > The full log is available at > http://patchew.org/logs/20200912114040.918464-1-f4...

Re: [PATCH v2 14/21] cirrus: Building freebsd in a single short

2020-09-09 Thread Ed Maste
On Wed, 9 Sep 2020 at 05:47, Yonggang Luo wrote: > > freebsd 1 hour limit not hit anymore > > Signed-off-by: Yonggang Luo Reviewed-by: Ed Maste > When its running properly, the consumed time are little, but when tests > running too long, > look at the cpu usage, the

Re: [PATCH 3/3] cirrus.yml: Update the macOS jobs to Catalina

2020-07-26 Thread Ed Maste
te our YML script > accordingly to avoid confusion. > > Signed-off-by: Thomas Huth Reviewed-by: Ed Maste

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-26 Thread Ed Maste
On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. Reviewed-by: Ed Maste for the Fr

Re: [PATCH v3 00/19] mailmap: Add more entries to sanitize 'git log' output

2020-07-06 Thread Ed Maste
On Thu, 2 Jul 2020 at 14:12, wrote: > > Patchew URL: https://patchew.org/QEMU/20200702173818.14651-1-f4...@amsat.org/ > > Hi, > > This series failed build test on FreeBSD host. Please find the details below. I had a look at this (because it's a FreeBSD report); it appears to have been a temporary

Re: [Qemu-devel] [PULL 11/13] tests/qemu-iotests: Do not hard-code the path to bash

2019-05-24 Thread Ed Maste
> Reviewed-by: Alex Bennée > Acked-by: Christian Borntraeger > Message-Id: <20190502084506.8009-4-th...@redhat.com> > Signed-off-by: Thomas Huth Reviewed-by: Ed Maste

Re: [Qemu-devel] [PATCH v3 05/14] tests/vm: run test builds on snapshot

2019-05-24 Thread Ed Maste
the VM doesn't corrupt the base image. > > Signed-off-by: Gerd Hoffmann > Tested-by: Thomas Huth Acked-by: Ed Maste

Re: [Qemu-devel] [PATCH v6 1/4] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-24 Thread Ed Maste
to >/dev/urandom" > > Signed-off-by: Kashyap Chamarthy > Reviewed-by: Daniel P. Berrangé > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Markus Armbruster > Signed-off-by: Laurent Vivier Acked-by: Ed Maste

Re: [Qemu-devel] [PULL 13/13] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests

2019-05-24 Thread Ed Maste
r CI pipelines on FreeBSD and macOS. > > Reviewed-by: Alex Bennée > Tested-by: Alex Bennée > Acked-by: Christian Borntraeger > Message-Id: <20190502084506.8009-6-th...@redhat.com> > Signed-off-by: Thomas Huth Acked-by: Ed Maste

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

2019-03-07 Thread Ed Maste
ine for this operating system here, too. > > > Signed-off-by: Thomas Huth > Reviewed-by: Philippe Mathieu-Daudé Acked-by: Ed Maste

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

2019-03-07 Thread Ed Maste
On Mon, 4 Mar 2019 at 06:39, Thomas Huth wrote: > > > > Can we get report of failures? (IRC, mail to ML, patchew icon) > > Honestly, I've got no clue ... this is the only help text that I've > found so far: > > https://cirrus-ci.org/guide/notifications/ I asked on twitter and was pointed at that

Re: [Qemu-devel] [PATCH v3] .cirrus.yml: basic compile and test for FreeBSD

2019-01-22 Thread Ed Maste
On Tue, 22 Jan 2019 at 04:40, Thomas Huth wrote: > > Then I finally increased the CPUs back to 8 again, but stick with 8G of > RAM, and that indeed finished in time successfully: > > https://cirrus-ci.com/build/6218565876187136 > > So yes, looks like 8 CPUs should work indeed, but I think you sho

Re: [Qemu-devel] [PATCH v3] .cirrus.yml: basic compile and test for FreeBSD

2019-01-21 Thread Ed Maste
On Mon, 21 Jan 2019 at 10:16, Ed Maste wrote: > > To confirm, I have another build running now with > echo "Running with hw.ncpu=$(sysctl -n hw.ncpu)" > added. Confirmed - https://cirrus-ci.com/build/5768962257190912: Running with hw.ncpu=8 If there is some sort of hang

Re: [Qemu-devel] [PATCH v3] .cirrus.yml: basic compile and test for FreeBSD

2019-01-21 Thread Ed Maste
On Mon, 21 Jan 2019 at 06:03, Alex Bennée wrote: > > I should be able to add CirrusCI to the QEMU project github when we > merge. I see there is another revision coming in so I''ll wait for that > before I queue it up. Do you mean my eadd119 commit "cirrus: tail dmesg to see if this is due to OOM

Re: [Qemu-devel] [PATCH v3] .cirrus.yml: basic compile and test for FreeBSD

2019-01-21 Thread Ed Maste
On Mon, 21 Jan 2019 at 05:18, Thomas Huth wrote: > > Actually, scratch that Tested-by: My build timed out after 1 hour: > > https://cirrus-ci.com/task/5113243459649536 Interesting. My build reports successful completion after a bit under 1/2 hr: https://cirrus-ci.com/build/5717787416723456 I no

Re: [Qemu-devel] [PATCH v2] .cirrus.yml: basic compile and test for FreeBSD

2019-01-18 Thread Ed Maste
On Thu, 17 Jan 2019 at 01:28, Thomas Huth wrote: > > > +bison curl cyrus-sasl fontconfig freetype2 git glib gmake gnutls > > I'm still wondering why you need fontconfig and freetype2 here? They must have crept in from previous experimentation; confirmed still builds and tests pass on FreeBSD

[Qemu-devel] [PATCH v2] .cirrus.yml: basic compile and test for FreeBSD

2019-01-16 Thread Ed Maste
From: Ed Maste Signed-off-by: Ed Maste Reviewed-by: Alex Bennée --- .cirrus.yml | 16 MAINTAINERS | 8 2 files changed, 24 insertions(+) create mode 100644 .cirrus.yml diff --git a/.cirrus.yml b/.cirrus.yml new file mode 100644 index 00..df39d8e573

Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-16 Thread Ed Maste
On Wed, 16 Jan 2019 at 09:40, Alex Bennée wrote: > > While debugging I ended up adding V=1 to the two gmake invocations > because it wasn't quite clear why it had failed last time. With that: > > Reviewed-by: Alex Bennée > > Does this patch come with an offer to be maintainer for FreeBSD/Cirrus >

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2019-01-15 Thread Ed Maste
On Tue, 15 Jan 2019 at 13:58, Ed Maste wrote: > > From the log[1] it looks like it's building the libfdt from dtc/. > Unfortunately I'm unable to dig in deeper into the hosted build (I > have only the logs), and my local build attempts are currently failing > due

Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-15 Thread Ed Maste
On Tue, 15 Jan 2019 at 13:59, Marc-André Lureau wrote: > > Hi > > On Tue, Jan 15, 2019 at 10:42 PM Ed Maste wrote: > > > > From: Ed Maste > > > > Cirrus-CI (https://cirrus-ci.org) is a hosted CI service which supports > > several platforms, including F

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2019-01-15 Thread Ed Maste
On Tue, 15 Jan 2019 at 13:47, Peter Maydell wrote: > > > > It looks like this was introduced between > > 9b2e891ec5ccdb4a7d583b77988848282606fdea (works) and > > 44ba6010635641a538c9b9b1f377dfa288751906 (fails). The .cirrus.yml file > > in my branch is at least good enough to catch this sort of th

Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-15 Thread Ed Maste
On Tue, 15 Jan 2019 at 13:42, Ed Maste wrote: > > From: Ed Maste I'm not sure what part of the path between `git send-email` and the list moved this From: into the message body, but it's not intentional. If someone's going to pick up this patch please edit the commit

[Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-15 Thread Ed Maste
From: Ed Maste Cirrus-CI (https://cirrus-ci.org) is a hosted CI service which supports several platforms, including FreeBSD. Later on we could build for other hosts in Cirrus-CI, but I'm starting with only FreeBSD as it is not supported by other CI services. Signed-off-by: Ed

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2019-01-15 Thread Ed Maste
On Fri, 14 Dec 2018 at 09:57, Ed Maste wrote: > > Indeed - having a hosted CI service to build on FreeBSD is something > I've wanted for a long time; so much better if one service can support > most or all platforms of interest. My most recent test build with cirrus-ci (http

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2018-12-14 Thread Ed Maste
On Fri, 7 Dec 2018 at 04:54, Daniel P. Berrangé wrote: > > Looking at this more generally I see they support Linux containers, > native Windows containers, macOS and FreeBSD. IOW, they offer more > platforms than our current Travis setup does and aren't stuck on an > amcient Ubuntu version. Indee

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2018-12-06 Thread Ed Maste
On Thu, 6 Dec 2018 at 05:23, Daniel P. Berrangé wrote: > > I'd encourage you to loook at installing as many deps as possible to > maximise the coverage. eg gnutls, nettle, spice, and anything else that > is relevant I've now added: bison curl cyrus-sasl fontconfig freetype2 gnutls nettle png usbr

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2018-12-05 Thread Ed Maste
On Wed, 5 Dec 2018 at 15:59, Kamil Rytarowski wrote: > > There are already FreeBSD, OpenBSD and NetBSD test scripts in the qemu > project. I see scripts under tests/vm/ for FreeBSD, NetBSD, and OpenBSD, but they're for testing BSD guests on QEMU, while I'm interested in building and testing QEMU

[Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2018-12-05 Thread Ed Maste
I'd very much like to have CI coverage for QEMU on FreeBSD, and as of yesterday there's a hosted CI service that supports FreeBSD: Cirrus CI. They also offer free service for OSS projects. I created a .cirrus.yml (shown below) in a QEMU GitHub fork and successfully executed a build test. I can sub

Re: [Qemu-devel] [PATCH for-2.9? v4] ipmi: Fix macro issues

2017-03-31 Thread Ed Maste
y Minyard > Reviewed-by: Eric Blake Reviewed-by: Ed Maste

Re: [Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation

2017-03-30 Thread Ed Maste
On 30 March 2017 at 12:12, Corey Minyard wrote: > This isn't quite right, a lot of these need parenthesis around the whole > thing, and some of the macros are unused and need to be removed. > I had submitted something for this a while ago, but it hadn't been > taken. I will re-submit. Ok, thanks

[Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation

2017-03-30 Thread Ed Maste
cro 'IPMI_BT_SET_HBUSY' (((v & 1) << IPMI_BT_HBUSY_BIT))) ^ ~ Signed-off-by: Ed Maste --- hw/ipmi/isa_ipmi_bt.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/ipmi/

[Qemu-devel] [PATCH] Fix FreeBSD (10.x) build after 7dc9ae43

2016-11-21 Thread Ed Maste
Include sys/user.h for declaration of 'struct kinfo_proc'. Add -lutil to qemu-ga link for kinfo_getproc. Signed-off-by: Ed Maste --- configure | 2 ++ util/oslib-posix.c | 1 + 2 files changed, 3 insertions(+) diff --git a/configure b/configure index 7d2a34e..5e66828 10

[Qemu-devel] [PATCH] bsd-user: fix FreeBSD build after d148d90e

2016-10-04 Thread Ed Maste
Signed-off-by: Ed Maste --- bsd-user/main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index d803d3e..d8367bd 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -695,6 +695,16 @@ static void usage(void) THREAD CPUState *thread_cpu

Re: [Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Ed Maste
On 22 August 2016 at 12:20, Peter Maydell wrote: > > Awkward that this missed rc4 by an hour or two :-( Indeed, and I'm sorry that's the case. It wasn't even in the context of the upcoming release that I tried building and stumbled across this - I'm just back after some time away. This is a good

[Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Ed Maste
Must include "qemu-version.h" for the QEMU_PKGVERSION definition. Signed-off-by: Ed Maste --- bsd-user/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index b4a0a00..0fb08e4 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Ed Maste
On 29 June 2016 at 16:35, Ed Maste wrote: > > I agree with a large code drop being undesirable. Here's a little more information for reference. Sean's qemu-bsd-user branch is here: https://github.com/seanbruno/qemu-bsd-user The last upstream merge was from commit d6550e9e a

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Ed Maste
On 29 June 2016 at 14:03, Peter Maydell wrote: > > I think from an upstream-maintainer viewpoint the question is > whether a code drop would be just a code drop, or whether > it gets us to a position where we have an active upstream > maintainer for the bsd-user code. I think the latter would > be

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Ed Maste
On 20 June 2016 at 10:19, Markus Armbruster wrote: > > As per Paolo's recommendation, downgrade status of "BSD user" from > Maintained to Orphan since the FreeBSD guys effectively forked it, and > "SPARC target" from Maintained to Odd Fixes, since we still have the > overall TCG maintainer looking

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-23 Thread Ed Maste
On 23 June 2016 at 07:36, Laszlo Ersek wrote: > On 06/22/16 22:53, Peter Maydell wrote: >> On 22 June 2016 at 19:09, Ed Maste wrote: >>> On 15 June 2016 at 06:10, Peter Maydell wrote: >>>> >>>> A quick scan through http://fxr.watson.org/fxr/source/arm6

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-22 Thread Ed Maste
On 22 June 2016 at 16:53, Peter Maydell wrote: > > Yeah, it looks like the same bug is also present in UEFI itself > (it's super popular!). Laszlo, Ard, do you have a prebuilt > UEFI binary with Ard's fix? > > Probably you'll find that if UEFI is configuring the GIC interrupt > groups FreeBSD will

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-22 Thread Ed Maste
On 15 June 2016 at 06:10, Peter Maydell wrote: > > A quick scan through http://fxr.watson.org/fxr/source/arm64/arm64/gic_v3.c > doesn't seem to show it setting the IGROUPR registers anywhere, > so it probably is a guest bug. (You can use "-d 'trace:gicv3*'" to > enable the tracepoints for the GIC

Re: [Qemu-devel] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning

2016-04-05 Thread Ed Maste
On 5 April 2016 at 10:54, Peter Maydell wrote: > On 5 April 2016 at 15:46, Ed Maste wrote: >> This is the same change as b55266b5 in linux-user. >> >> Signed-off-by: Ed Maste > > Do you have many more of these bsd related patches to come? > It might be easie

[Qemu-devel] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning

2016-04-05 Thread Ed Maste
This is the same change as b55266b5 in linux-user. Signed-off-by: Ed Maste --- bsd-user/uaccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c index b7b3a06..91e2067 100644 --- a/bsd-user/uaccess.c +++ b/bsd-user/uaccess.c @@ -51,7

[Qemu-devel] [PATCH] bsd-user: add qemu/cutils.h include after f348b6d

2016-04-05 Thread Ed Maste
Signed-off-by: Ed Maste --- bsd-user/uaccess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c index 7cb6d17..b7b3a06 100644 --- a/bsd-user/uaccess.c +++ b/bsd-user/uaccess.c @@ -1,5 +1,6 @@ /* User memory access */ #include "qemu/osdep.h"

Re: [Qemu-devel] [PATCH v2] util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED

2016-04-04 Thread Ed Maste
V4MAPPED > - Don't disable AI_V4MAPPED at build time, detect it >at runtime, so we catch any platform with broken impl This fixes the remaining two of three failures I reported earlier today in 'gmake check' on FreeBSD. Tested-by: Ed Maste

Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test

2016-04-04 Thread Ed Maste
fine for me. > Thanks! > > Bruce > > Tested-by: Bruce Rogers This fixes one of the three FreeBSD test failures I reported earlier in the thread "[PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)". Tested-by: Ed Maste

Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)

2016-04-04 Thread Ed Maste
On 4 April 2016 at 10:35, Alex Bennée wrote: > Only the first patch has actually changed. Instead of moving the read > inside the write seqlock it is now done using the seqlock_read_* > primitives. > > Build tested on a FreeBSB/i386 VM with these applied: > > https://github.com/berrange/qemu/tre

[Qemu-devel] [PATCH] bsd-user: add necessary includes to fix warnings

2016-04-04 Thread Ed Maste
Signed-off-by: Ed Maste --- bsd-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 35f784c..47cf865 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -17,6 +17,8 @@ * along with this program; if not, see <h

Re: [Qemu-devel] [PATCH] io: fix build on FreeBSD

2016-02-26 Thread Ed Maste
On 25 February 2016 at 11:41, Daniel P. Berrange wrote: > On Thu, Feb 25, 2016 at 09:37:18AM -0700, Eric Blake wrote: >> >> Oh, right. That's annoying. What about: >> >> #ifndef EAI_ADDRFAMILY >> #define EAI_ADDRFAMILY 0 >> #endif >> >> if ((EAI_ADDRFAMILY && gaierr == EAIADDRFAMILY) || >> ga

[Qemu-devel] [PATCH] io: fix build on FreeBSD

2016-02-25 Thread Ed Maste
EAI_ADDRFAMILY is obsolete and FreeBSD/s netdb.h does not provide a definition. Signed-off-by: Ed Maste --- tests/test-io-channel-socket.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c index 0697363

[Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

2015-10-23 Thread Ed Maste
Acked-by: Roger Pau Monné Signed-off-by: Ed Maste --- As an aside this was reviewed on FreeBSD's Phabricator here: https://reviews.freebsd.org/D3969 Resend with Signed-off-by. net/tap-bsd.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

2015-10-23 Thread Ed Maste
--- As an aside this was reviewed on FreeBSD's Phabricator here: https://reviews.freebsd.org/D3969 net/tap-bsd.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 7028d9b..0103a97 100644 --- a/net/tap-bs

Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-02 Thread Ed Maste
On 1 April 2015 at 18:45, Peter Maydell wrote: > On 1 April 2015 at 22:14, Paolo Bonzini wrote: >> On 01/04/2015 23:06, John Snow wrote: >>> >>> if (qemu == NULL) { >>> fprintf(stderr, "..."); >>> g_assert_not_reached(); >>> } >>> >>> Though that does read a little strangely. ("Here's a nice

[Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-01 Thread Ed Maste
Signed-off-by: Ed Maste --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 12d65bd..54550a8 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -453,6 +453,7 @@ void qtest_qmp_discard_response(QTestState *s, const char *fmt

[Qemu-devel] [PATCH] Use $(MAKE) for recursive make

2015-04-01 Thread Ed Maste
On BSDs "make" is typically BSD make, while "gmake" is GNU make. Signed-off-by: Ed Maste --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 88bce56..ee40397 100644 --- a/Makefile +++ b/Makefile @@ -331,8 +331,8

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:55, Ed Maste wrote: > > feynman% ./tests/ahci-test > /i386/ahci/sanity: OK > /i386/ahci/pci_spec: OK > /i386/ahci/pci_enable: OK > /i386/ahci/hba_spec: OK > /i386/ahci/hba_enable: OK > /i386/ahci/identify: OK > /i386/ahci/io/pio/lba28/simple: *

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:44, John Snow wrote: > > My apologies; Not at all, thanks for your help! > Head into your build directory and try this: > >> make tests/ahci-test >> export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 >> export QTEST_QEMU_IMG=./qemu-img >> ./tests/ahci-test > > This sho

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 16:58, John Snow wrote: > > which test case does it fail under? io_rw_simple is shared by a number of > different tests. I'm not sure off hand how to run an individual test to confirm, but the testrun output up to the failure is: LINK tests/spapr-phb-test GTESTER check-qte

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 23 March 2015 at 12:56, John Snow wrote: > My pattern was cyclical every 256 bytes, so it missed a fairly obvious > failure case. Add some rand() pepper into the test pattern, and for large > patterns that exceed 256 sectors, start writing an ID per-sector so that > we never generate identical

Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD

2014-06-20 Thread Ed Maste
On 18 June 2014 11:22, Andreas Färber wrote: > Am 18.06.2014 16:41, schrieb Paolo Bonzini: >> Il 18/06/2014 14:58, Ed Maste ha scritto: >>> Signed-off-by: Ed Maste >>> --- >>> libcacard/vscclient.c | 2 ++ >>> 1 file changed, 2 insertions(+)

Re: [Qemu-devel] [PATCH] vscclient: Restore sockets.h include to fix build on FreeBBSD

2014-06-18 Thread Ed Maste
On 17 June 2014 15:23, Ed Maste wrote: > Commit 2a0c46d ("vscclient: use glib thread primitives not qemu") > removed #include "qemu/sockets.h", required for socket-related function > declarations and constants. Disregard this patch; a replacement has been sent to add the two required headers.

[Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD

2014-06-18 Thread Ed Maste
Signed-off-by: Ed Maste --- libcacard/vscclient.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ab9b2b8..80111df 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -11,6 +11,8 @@ */ #ifndef _WIN32 +#include

[Qemu-devel] [PATCH] vscclient: Restore sockets.h include to fix build on FreeBBSD

2014-06-17 Thread Ed Maste
Commit 2a0c46d ("vscclient: use glib thread primitives not qemu") removed #include "qemu/sockets.h", required for socket-related function declarations and constants. Signed-off-by: Ed Maste --- libcacard/vscclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu

2014-06-17 Thread Ed Maste
On 17 June 2014 13:15, Paolo Bonzini wrote: > Il 17/06/2014 19:10, Ed Maste ha scritto: > >> This change breaks the build on FreeBSD: >> >> libcacard/vscclient.c: In function 'send_msg': >> libcacard/vscclient.c:111: warning: implicit declaration of functi

Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu

2014-06-17 Thread Ed Maste
On 10 June 2014 01:56, Paolo Bonzini wrote: > From: Michael Tokarev > > Use glib-provided thread primitives in vscclient instead of > qemu ones, and do not use qemu sockets in there (open-code > call to WSAStartup() for windows to initialize things). > > This way, vscclient becomes more stand-alo

Re: [Qemu-devel] [PATCH] bsd-user/mmap.c: Don't try to override g_malloc/g_free

2014-06-04 Thread Ed Maste
seem to have > further issues. > > Signed-off-by: Peter Maydell Reviewed-by: Ed Maste

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Put tempfiles in subdir so we can clean up libtool files

2014-05-28 Thread Ed Maste
On 6 May 2014 10:36, Eric Blake wrote: > > mktemp is not POSIX. BSD mktemp lacks -t: > > http://www.freebsd.org/cgi/man.cgi?query=mktemp&apropos=0&sektion=1&manpath=Red+Hat+Linux%2Fi386+9&format=html You managed to link to a mktemp man page for some old Red Hat version there (note the URL); Free

Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0

2014-04-02 Thread Ed Maste
On 2 April 2014 14:52, Richard Henderson wrote: > On 04/02/2014 07:06 AM, Andreas Färber wrote: >> FreeBSD 10.0-RELEASE has bswap16() etc. macros defined in sys/endian.h, >> which leads to a conflict with our static inline definitions. >> >> Force using the system version of the macros. >> >> Sign

Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version

2014-04-02 Thread Ed Maste
On 11 March 2014 12:13, Dr. David Alan Gilbert wrote: > Except pthread_setname_np is not portable and was previously > ifdef'd _GNU_SOURCE anyway, and the parameters on other OSs > maybe different (freebsd has got a 3rd parameter for no > apparent reason). No, glibc's arguments are identical to

Re: [Qemu-devel] [PATCH v3 01/19] bsd-user: refresh freebsd system call numbers

2014-02-01 Thread Ed Maste
On 27 January 2014 14:30, Peter Maydell wrote: > > though this patch would look much nicer if you hadn't > changed every single line in the file including the > ones for syscalls we already had the #defines for. The new version of this file was generated from the canonical FreeBSD syscall numberi

[Qemu-devel] Request for volunteer to commit bsd-user patch set

2013-12-29 Thread Ed Maste
On 13 December 2013 07:44, Paolo Bonzini wrote: > > Post the patches. I'll review the non-bsd-user parts again. And then > the next step is to find someone who commits them... shouldn't be hard > since you probably know much more about this code than anyone else. Is someone willing to shepherd

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-12-12 Thread Ed Maste
On 27 November 2013 06:29, Paolo Bonzini wrote: > Il 26/11/2013 22:01, Ed Maste ha scritto: >> On 8 November 2013 11:33, Stacey Son wrote: >>> [v2] >>> >>> - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to >>> build: see >

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-11-26 Thread Ed Maste
On 8 November 2013 11:33, Stacey Son wrote: > [v2] > > - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to > build: see > http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg0.html) > - Fixes deadlock in the _umtx_op() system call handler. > - Fixes race condition

Re: [Qemu-devel] [PATCH 01/18] bsd-user: refresh freebsd system call numbers

2013-10-23 Thread Ed Maste
On 16 October 2013 10:36, Stacey Son wrote: > Update FreeBSD system call numbers in freebsd/syscall_nr.h. > > Signed-off-by: Stacey Son Reviewed-by: Ed Maste

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-09-18 Thread Ed Maste
amd64)? On 10 September 2013 03:44, Stefan Hajnoczi wrote: > On Mon, Sep 09, 2013 at 02:15:57PM -0400, Ed Maste wrote: >> On 17 July 2013 20:07, Ed Maste wrote: >> >> > On 8 July 2013 11:15, Ed Maste wrote: >> > > >> > > Ok, as soon as I c

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-09-09 Thread Ed Maste
On 17 July 2013 20:07, Ed Maste wrote: > On 8 July 2013 11:15, Ed Maste wrote: > > > > Ok, as soon as I can get a password (after the buildbot disk space > > issues are sorted out) I'll contribute a FreeBSD 9 amd64 builder. > > It seems the disk space / i

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Ed Maste
On 24 July 2013 09:32, Anthony Liguori wrote: > Ed Maste writes: > >> On 19 July 2013 05:11, Michael Tokarev wrote: >>> This is another trivial-patches pull request. This time >>> we have just 5 patches accumulated in two (!) weeks period. >>> Please con

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 2/5] slirp: remove mbuf(m_hdr, m_dat) indirection

2013-07-24 Thread Ed Maste
On 19 July 2013 05:11, Michael Tokarev wrote: > --- > slirp/mbuf.h | 51 ++- > slirp/tcp_subr.c | 12 ++-- > 2 files changed, 24 insertions(+), 39 deletions(-) Tested-by: Ed Maste

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Ed Maste
On 19 July 2013 05:11, Michael Tokarev wrote: > This is another trivial-patches pull request. This time > we have just 5 patches accumulated in two (!) weeks period. > Please consider apply. ... > Michael Tokarev (2): > slirp: remove mbuf(m_hdr,m_dat) indirection Any idea when this might g

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-17 Thread Ed Maste
On 8 July 2013 11:15, Ed Maste wrote: > > Ok, as soon as I can get a password (after the buildbot disk space > issues are sorted out) I'll contribute a FreeBSD 9 amd64 builder. It seems the disk space / inode issue is resolved; is there anything further still in the way of ad

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-17 Thread Ed Maste
On 17 July 2013 04:54, Michael Tokarev wrote: > 17.07.2013 12:32, Jan Kiszka wrote: >> No problem, as Peter already said. Please provide an according patch. > > http://thread.gmane.org/gmane.comp.emulators.qemu/221949/focus=221975 > (an attachtment there) > http://git.corpit.ru/?p=qemu.git;a=comm

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-13 Thread Ed Maste
On 13 July 2013 05:12, Michael Tokarev wrote: > Remaining: > > struct mbuf { > union M_dat { > charm_dat_[1]; /* ANSI don't like 0 sized arrays */ > char*m_ext_; > } M_dat; > }; > > #define m_dat M_dat.m_dat_ > #define m_ext

[Qemu-devel] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-12 Thread Ed Maste
Signed-off-by: Ed Maste --- The issue comes from slirp/mbuf.h #defining m_flags, which conflicts with a header included via on FreeBSD. I'm not sure exactly when this broke; I assume that it used to work because something previously caused the conflicting header to be included earlier

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-08 Thread Ed Maste
On 3 July 2013 04:57, Stefan Hajnoczi wrote: > On Tue, Jul 02, 2013 at 09:35:41AM +0200, Christian Berendt wrote: >> On 07/02/2013 09:31 AM, Stefan Hajnoczi wrote: >> >I think the solution is to add another buildmaster administrator. I >> >believe Christian offered that in the past. >> >> Sure. I

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers

2013-07-01 Thread Ed Maste
On 1 July 2013 15:25, Peter Maydell wrote: > Does any OS have a __thread which compiles but is broken, or can > we just have a configure test for this? That would let MacOSX+clang > use __thread. I believe this was recently the case on NetBSD - code with __thread would build, but fail at run time

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers

2013-07-01 Thread Ed Maste
On 1 July 2013 05:35, Stefan Hajnoczi wrote: > From: Paolo Bonzini > > Fast TLS is not available on some platforms, but it is always nice to > use it. This wrapper implementation falls back to pthread_get/setspecific > on POSIX systems that lack __thread, but uses the dynamic linker's TLS > sup

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-01 Thread Ed Maste
On 1 July 2013 07:47, Stefan Hajnoczi wrote: > Yes, Christian Berendt admins the buildmaster. How much time has passed > since you emailed? June 7; perhaps the email was lost. I would like to start with a FreeBSD 9.x x86_64 instance, potentially adding i386 and FreeBSD 10-CURRENT to the mix la

Re: [Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h

2013-06-28 Thread Ed Maste
On 28 June 2013 14:26, Paolo Bonzini wrote: > > +/* This is thread-local depending on __linux__ because: Is the comment perhaps unchanged from an earlier revision that used a different test? It seems odd to me to reference __linux__ here. > + * - the only -user mode supporting multiple VCPU th

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-28 Thread Ed Maste
On 28 June 2013 11:11, Paolo Bonzini wrote: > And of course if bsd-user supported 1:1 mapping between guest and host > threads on FreeBSD, cpu_single_env would have to be thread-local. This is the case for the bsd-user work that Stacey posted at the beginning of the week and is currently being re

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-28 Thread Ed Maste
On 28 June 2013 09:05, Peter Maydell wrote: > On 28 June 2013 14:03, Paolo Bonzini wrote: >> Il 28/06/2013 14:54, Ed Maste ha scritto: >>> An objection seemed to be that it is not really needed yet, but as >>> pointed out by Peter this isn't really the case. T

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-28 Thread Ed Maste
On 28 June 2013 06:34, Michael Tokarev wrote: > 24.06.2013 23:21, Ed Maste wrote: >> Signed-off-by: Ed Maste >> --- >> I have had this in a local tree for some time, and it is needed by the >> BSD-user work that is now being proposed. > > So I'm not applyi

[Qemu-devel] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-24 Thread Ed Maste
Signed-off-by: Ed Maste --- I have had this in a local tree for some time, and it is needed by the BSD-user work that is now being proposed. As an aside, an abstraction was recently proposed for Open vSwtich that can use any of _Thread_local, __thread, or pthread_getspecific() which may make a

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-06-24 Thread Ed Maste
t set the address with -Ttext-segment if supported, or by using sed to > edit the default linker script. > > Cc: Ed Maste > Signed-off-by: Richard Henderson > --- > configure | 48 +++- > 2 files changed, 31 insertions(+),

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-06-20 Thread Ed Maste
On 5 June 2013 10:04, Anthony Liguori wrote: > > Hi, > > Below is the coverage we currently have in buildbot. It's not terribly > complete but I suspect it does reflect what people are actually testing > and care about. > > In terms of policy, we should consider buildbot coverage as a > requireme

[Qemu-devel] [RFT PATCH v2] configure: Simplify alternate .text segment

2013-06-20 Thread Ed Maste
ed to edit the default linker script. Note that ldscripts/alpha.ld was already unused prior to this change, as it was handled by the "default placement of the application is fine" case. Signed-off-by: Ed Maste --- Changes from v1: - Drop removal of ldscripts from the patch for now. The

  1   2   >