Lockup with --accel tcg,thread=single

2019-09-30 Thread Doug Gale
I found a lockup in single threaded TCG, with OVMF bios, 16 CPUs. qemu-system-x86_64 --accel tcg,thread=single -smp cpus=16 -bios /usr/share/ovmf/OVMF.fd Using Ubuntu 18.04 LTS, default gnome desktop. There is no guest OS, there is no hard drive, just the OVMF firmware locks it up. (I narrowed it

Lockup with --accel tcg,thread=single

2019-09-30 Thread Doug Gale
I found a lockup in single threaded TCG, with OVMF bios, 16 CPUs. qemu-system-x86_64 --accel tcg,thread=single -smp cpus=16 -bios /usr/share/ovmf/OVMF.fd Using Ubuntu 18.04 LTS, default gnome desktop. There is no guest OS, there is no hard drive, just the OVMF firmware locks it up. (I narrowed it

Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers

2019-01-25 Thread Doug Gale
On Fri, Jan 25, 2019 at 6:22 AM Peter Maydell wrote: > > Thanks for this explanation -- the patch makes a lot more sense with it. > I'm confused though -- the XML we ship is basically what gdb itself > ships and uses internally: > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;

Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers

2019-01-24 Thread Doug Gale
PM Doug Gale wrote: > The machine description we send is being (silently) thrown on the floor by > GDB and GDB silently uses the default machine description. > > With current QEMU, if you debug gdb, and set debug_xml=1 and continue, > then attach to qemu gdbstub from the debugge

Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers

2019-01-24 Thread Doug Gale
ml file. I added fs_base, gs_base, k_gs_base, cr0/2/3/4/6, efer. Removing the nesting into xml includes fixes it because the xml parse fails on wrote: > On Thu, 24 Jan 2019 at 04:08, Doug Gale wrote: > > > > Signed-off-by: Doug Gale > > --- > > configure

[Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers

2019-01-23 Thread Doug Gale
Signed-off-by: Doug Gale --- configure | 4 +- gdb-xml/i386-32bit-core.xml | 65 --- gdb-xml/i386-32bit-sse.xml | 52 - gdb-xml/i386-32bit.xml | 184 ++- gdb-xml/i386-64bit-core.xml | 73 - gdb-xml/i386-64bit

Re: [Qemu-devel] [PATCH] i386/monitor.c: make addresses canonical for "info mem" and "info tlb"

2018-07-01 Thread Doug Gale
On Sun, Jun 17, 2018 at 4:40 AM, Doug Gale wrote: > Correct the output of the "info mem" and "info tlb" monitor commands to > correctly show canonical addresses. > > In 48-bit addressing mode, the upper 16 bits of linear addresses are > equal to bit 47. In

[Qemu-devel] [PATCH] i386/monitor.c: make addresses canonical for "info mem" and "info tlb"

2018-06-17 Thread Doug Gale
bit 56. Signed-off-by: Doug Gale --- target/i386/monitor.c | 76 +-- 1 file changed, 44 insertions(+), 32 deletions(-) diff --git a/target/i386/monitor.c b/target/i386/monitor.c index a890b3c2ab..99c97a63e2 100644 --- a/target/i386/monitor.c +++ b/t

[Qemu-devel] [Bug 1748296] Re: TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2018-02-08 Thread Doug Gale
** Description changed: I am unable to use BMI in my project when running under TCG. I narrowed the problem down to incorrect instruction decoding for BMI instructions (which have a 2 byte VEX prefix). The gen_sse function in translate.c reaches the goto label do_0f_38_fx, but b does not e

[Qemu-devel] [Bug 1748296] [NEW] TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2018-02-08 Thread Doug Gale
Public bug reported: I am unable to use BMI in my project when running under TCG. I narrowed the problem down to incorrect instruction decoding for BMI instructions (which have a 2 byte VEX prefix). The gen_sse function in translate.c reaches the goto label do_0f_38_fx, but b does not equal 0x1f7,

Re: [Qemu-devel] [PATCH v2] Add AVX, AVX-512, MPX support to x86_cpu_dump_state

2017-12-07 Thread Doug Gale
On Thu, Dec 7, 2017 at 5:37 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 12/02/2017 10:35 PM, Doug Gale wrote: > > Signed-off-by: Doug Gale > > --- > > Fix MSB LSB showing when SSE is disabled >

[Qemu-devel] [PATCH v2] Add AVX, AVX-512, MPX support to x86_cpu_dump_state

2017-12-02 Thread Doug Gale
Signed-off-by: Doug Gale --- Fix MSB LSB showing when SSE is disabled target/i386/helper.c | 95 +--- 1 file changed, 83 insertions(+), 12 deletions(-) diff --git a/target/i386/helper.c b/target/i386/helper.c index f63eb3d3f4..03812b6e87 100644

[Qemu-devel] [PATCH] Add AVX, AVX-512, MPX support to x86_cpu_dump_state

2017-12-02 Thread Doug Gale
Signed-off-by: Doug Gale --- target/i386/helper.c | 94 +--- 1 file changed, 82 insertions(+), 12 deletions(-) diff --git a/target/i386/helper.c b/target/i386/helper.c index f63eb3d3f4..708fe13f2f 100644 --- a/target/i386/helper.c +++ b/target

[Qemu-devel] [PATCH v4] gdbstub: add tracing

2017-12-02 Thread Doug Gale
Signed-off-by: Doug Gale --- Fix usage of %c in trace output, now uses 0x%02x Fix possible sign extended char that could cause 0xfc to say 0xfffc Add missing traces for hitting breakpoints, continuing, stepping Fix incorrect dynamic check for tracing being enabled in hexdump Fix missing

Re: [Qemu-devel] [PATCH] gdbstub: add tracing

2017-11-29 Thread Doug Gale
On Mon, Nov 27, 2017 at 5:00 AM, Markus Armbruster wrote: > Drive-by question... > > Doug Gale writes: > >> Signed-off-by: Doug Gale >> --- >> gdbstub.c| 100 >> ++- >> trace-events |

[Qemu-devel] [PATCH v3] gdbstub: add tracing

2017-11-26 Thread Doug Gale
Signed-off-by: Doug Gale --- gdbstub.c| 101 ++- trace-events | 21 + 2 files changed, 87 insertions(+), 35 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2a94030d3b..86482fa009 100644 --- a/gdbstub.c +++ b

[Qemu-devel] [PATCH v2] gdbstub: add tracing

2017-11-26 Thread Doug Gale
Signed-off-by: Doug Gale --- gdbstub.c| 101 ++- trace-events | 21 + 2 files changed, 87 insertions(+), 35 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2a94030d3b..86482fa009 100644 --- a/gdbstub.c +++ b

[Qemu-devel] [PATCH] gdbstub: add tracing

2017-11-26 Thread Doug Gale
Signed-off-by: Doug Gale --- gdbstub.c| 100 ++- trace-events | 21 + 2 files changed, 86 insertions(+), 35 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2a94030d3b..a75f319bd0 100644 --- a/gdbstub.c +++ b

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-24 Thread Doug Gale
Ping On Thu, Nov 16, 2017 at 6:16 AM, Doug Gale wrote: > I submitted it with git Nov 3 - the long lines issue with git-am > should be resolved. Please let me know if there's still a problem. > > Thanks. > > > On Fri, Nov 3, 2017 at 11:58 AM, Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-16 Thread Doug Gale
I submitted it with git Nov 3 - the long lines issue with git-am should be resolved. Please let me know if there's still a problem. Thanks. On Fri, Nov 3, 2017 at 11:58 AM, Philippe Mathieu-Daudé wrote: > Cc'ing Trivial ;) > > On 11/03/2017 10:37 AM, Doug Gale wrote: >

[Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-03 Thread Doug Gale
Add trace output for commands, errors, and undefined behavior. Add guest error log output for undefined behavior. Report invalid undefined accesses to MMIO. Annotate unlikely error checks with unlikely. Signed-off-by: Doug Gale Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH] nvme: Add tracing

2017-11-03 Thread Doug Gale
Add trace output for commands, errors, and undefined behavior. Add guest error log output for undefined behavior. Report invalid undefined accesses to MMIO. Annotate unlikely error checks with unlikely. Signed-off-by: Doug Gale --- hw/block/nvme.c | 349

[Qemu-devel] [PATCH v4] nvme: Add tracing

2017-10-30 Thread Doug Gale
>From 0e27b5dca8f4f32a1b194e1b3544be77dd4f45d9 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Mon, 30 Oct 2017 09:28:43 -0400 Subject: [PATCH] nvme: Add tracing Add trace output for commands, errors, and undefined behavior. Add guest error log output for undefined behavior. Report inva

Re: [Qemu-devel] nvme: Add tracing v3

2017-10-30 Thread Doug Gale
On Fri, Oct 20, 2017 at 4:11 PM, Doug Gale wrote: > On Thu, Oct 12, 2017 at 3:07 PM, Doug Gale wrote: > >> From c7f12a5949458fdd195b5e0b52f158e8f114f203 Mon Sep 17 00:00:00 2001 >> From: Doug Gale >> Date: Thu, 12 Oct 2017 14:29:07 -0400 >> Subject: [PATCH] nvm

Re: [Qemu-devel] nvme: Add tracing v3

2017-10-20 Thread Doug Gale
On Thu, Oct 12, 2017 at 3:07 PM, Doug Gale wrote: > From c7f12a5949458fdd195b5e0b52f158e8f114f203 Mon Sep 17 00:00:00 2001 > From: Doug Gale > Date: Thu, 12 Oct 2017 14:29:07 -0400 > Subject: [PATCH] nvme: Add tracing > > Add trace output for commands, errors, and undefin

[Qemu-devel] nvme: Add tracing v3

2017-10-12 Thread Doug Gale
>From c7f12a5949458fdd195b5e0b52f158e8f114f203 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Thu, 12 Oct 2017 14:29:07 -0400 Subject: [PATCH] nvme: Add tracing Add trace output for commands, errors, and undefined behavior. Add guest error log output for undefined behavior. Report and ign

Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-11 Thread Doug Gale
On Tue, Oct 10, 2017 at 4:02 AM, Kevin Wolf wrote: > Am 10.10.2017 um 08:58 hat Markus Armbruster geschrieben: >> Doug Gale writes: >> >> > I used exclamations as a concise way of indicating that the driver did >> > something nonsensical, or horribly invalid, li

Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-09 Thread Doug Gale
those messages with exclamations should ever happen. If any of them are possible when the driver is correct, then I have made a mistake. On Mon, Oct 9, 2017 at 11:52 AM, Eric Blake wrote: > On 10/07/2017 02:51 AM, Doug Gale wrote: >> Completely re-implemented patch, with significant imp

Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-07 Thread Doug Gale
rom 166f57458d60d363a10a0933c3e860985531ac96 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Thu, 5 Oct 2017 19:02:03 -0400 Subject: [PATCH] Add tracing output to NVMe emulation to help driver authors. This uses the tracing infrastructure using nvme_ as the prefix. Signed-off-by: Doug Gale --- hw/block/nvm

Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-06 Thread Doug Gale
; On Fri, Oct 06, 2017 at 08:50:31AM -0500, Eric Blake wrote: >> On 10/05/2017 06:18 PM, Doug Gale wrote: >> > I added the tracing output in this patch to assist me in implementing >> > an NVMe driver. It helped tremendously. >> > >> >>From 1d19086cdef8

[Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-05 Thread Doug Gale
I added the tracing output in this patch to assist me in implementing an NVMe driver. It helped tremendously. >From 1d19086cdef8d492929852d582cb41dcc5026f71 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Thu, 5 Oct 2017 19:02:03 -0400 Subject: [PATCH] Add tracing output to NVMe emulation to h

Re: [Qemu-devel] [PATCH] gdbstub: implement remote debugging protocol escapes for command receive

2017-05-08 Thread Doug Gale
Right, only GETLINE_* states write to the linebuf, so line_buf_index < 1 is correct. Updated patch: >From 2e6c45260cae60bbae446bffe43f948ab002c529 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Mon, 1 May 2017 12:22:10 -0400 Subject: [PATCH] gdbstub: implement remote debugging protocol e

Re: [Qemu-devel] [PATCH] gdbstub: implement remote debugging protocol escapes for command receive

2017-05-07 Thread Doug Gale
Updated patch with comments addressed: >From 6bce4e5c87c255f10b22d2bf6fc951dde2bbf457 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Mon, 1 May 2017 12:22:10 -0400 Subject: [PATCH] gdbstub: implement remote debugging protocol escapes for command receive - decode escape sequences - decompr

Re: [Qemu-devel] [PATCH] gdbstub: implement remote debugging protocol escapes for command receive

2017-05-07 Thread Doug Gale
rtly... On Fri, May 5, 2017 at 10:45 AM, Stefan Hajnoczi wrote: > On Tue, May 02, 2017 at 10:32:40AM -0400, Doug Gale wrote: >> +} else { >> +/* decode repeat length */ >> +int repeat = (unsigned char)ch - ' ' + 3;

Re: [Qemu-devel] [PATCH] gdbstub: implement remote debugging protocol escapes for command receive

2017-05-02 Thread Doug Gale
Oops. Thanks, here's the patch inline. >From c238752f10434970af8ef620ce3bf6c0e18a20b5 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Mon, 1 May 2017 12:22:10 -0400 Subject: [PATCH] gdbstub: implement remote debugging protocol escapes for command receive - decode escape sequences - de

[Qemu-devel] [PATCH] gdbstub: implement remote debugging protocol escapes for command receive

2017-05-01 Thread Doug Gale
The attached patch implements the GDB Remote Serial Protocol for command receive as per the documentation provided at https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html#Remote-Protocol and from inspection of remote.c in the gdb source (the documentation didn't clearly document whether t