table
with this persistent UUID key to ensure that the key stored in
the hash table remains valid as long as the hash table entry
exists.
Fixes: faefdba847 ("hw/display: introduce virtio-dmabuf")
Signed-off-by: Dorinda Bassey
---
hw/display/virtio-dmabuf.c | 6 --
1 file
Stefano Garzarella
wrote:
> On Thu, Nov 7, 2024 at 2:43 PM Stefano Garzarella
> wrote:
> >
> > On Thu, Nov 07, 2024 at 01:52:01PM +0100, Dorinda Bassey wrote:
> > >In `virtio_add_resource` function, the UUID used as a key for
> > >`g_hash_table_insert` was tem
inserted into
the hash table with this persistent UUID key to ensure that the
key stored in the hash table remains valid as long as the hash
table entry exists.
Signed-off-by: Dorinda Bassey
---
hw/display/virtio-dmabuf.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw
Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment
of resources UUIDs for export to other virtio devices.
Signed-off-by: Dorinda Bassey
---
hw/display/vhost-user-gpu.c| 4
hw/display/virtio-gpu-base.c | 3 +++
include/hw/virtio/virtio-gpu.h | 3 +++
3 files changed
Hi Manos,
Thanks, for spotting that!
On Sat, Oct 5, 2024 at 7:43 AM Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> wrote:
> Hello Dorinda,
>
> On Fri, 04 Oct 2024 19:41, Dorinda Bassey wrote:
> >Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment
Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment
of resources UUIDs for export to other virtio devices.
Signed-off-by: Dorinda Bassey
---
hw/display/vhost-user-gpu.c| 4
hw/display/virtio-gpu-base.c | 3 +++
include/hw/virtio/virtio-gpu.h | 3 +++
3 files changed
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v12:
ha
e methods that implement playback and recording will create streams
> > for playback and capture that will start processing and will result in
> > the on_process callbacks to be called.
> > Built a connection to the Pipewire sound system server in the
> > qpw_audio_init
,
Dorinda.
On Wed, Apr 12, 2023 at 3:57 PM Dorinda Bassey wrote:
> This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> both an audio sink and source. This backend is available on most systems
>
> Add Pipewire entry points for QEMU Pipewire audio backend
> Add wr
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v11:
ha
hrough the revision process.
However I would appreciate any information you can provide on the expected
timeline for merging the patches. Let me know if there's anything else I
can do to help move this process forward.
Regards,
Dorinda.
On Mon, Apr 3, 2023 at 10:21 PM Dorinda Bassey wrote:
>
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v10:
imp
orinda
On Mon, Apr 3, 2023 at 8:51 AM Volker Rümelin wrote:
> Am 28.03.23 um 13:56 schrieb Dorinda Bassey:
>
> Hi Dorinda,
>
> > Hi Volker,
> >
> > Thanks for the feedback.
> >
> > This term is constant for the lifetime of the playback stream. It
>
tually.
No lock needed?
>
yes, no lock needed.
Are you sure stopping the loop before ending the core and the context
> associated with it here is fine?
>
yes, It's fine, however I would improve it.
Thanks,
Dorinda.
On Wed, Mar 29, 2023 at 10:19 AM Marc-André Lureau <
marc
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v9:
add cod
Hi Volker,
Thanks for the feedback.
This term is constant for the lifetime of the playback stream. It could
> be precalculated in qpw_init_out().
>
It's still constant even when precalculated in qpw_init_out().
The if (!v->enabled) block isn't needed. When the guest stops the
> playback stream,
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v8:
Imp
n Mon, Mar 13, 2023 at 9:06 PM Volker Rümelin wrote:
> Am 13.03.23 um 13:28 schrieb Dorinda Bassey:
> > Hi Volker,
> >
> > Thanks for the patch, I've tested the patch and it works. I don't hear
> > the choppy audio with this option "qemu-system-x86_64 -devi
t) n_bytes);
CMIIW
Thanks,
Dorinda.
On Mon, Mar 13, 2023 at 2:37 PM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Monday, March 13, 2023 2:11:11 PM CET Dorinda Bassey wrote:
> > Hi Volker,
> >
> >
> > > To hear this,
> > > start QEMU wit
Hi Volker,
> To hear this,
> start QEMU with qemu-system-x86_64 -machine pcspk-audiodev=audio0
> -device ich9-intel-hda -device hda-duplex,audiodev=audio0 -audiodev
> pipewire,id=audio0,out.mixing-engine=off ...
>
I hear the clipped audio stream with these options. IMO, I don't think
memset is re
Hi Volker,
Thanks for the patch, I've tested the patch and it works. I don't hear the
choppy audio with this option "qemu-system-x86_64 -device ich9-intel-hda
-device hda-duplex,audiodev=audio0 -audiodev
pipewire,id=audio0,out.frequency=96000,in.frequency=96000 "
I don't understand how the re
t. It seems you should set the
> stream PW_KEY_NODE_LATENCY, which must be a fraction as a string. You
> can either convert the microseconds latency to a fraction
> ("delay/100"), or change the argument to use fractions instead
> (although this would be different from
a.
On Tue, Mar 7, 2023 at 2:49 PM Marc-André Lureau
wrote:
> Hi
>
> On Fri, Mar 3, 2023 at 8:06 PM Dorinda Bassey
> >> What are those thread_loop_signal() for? Maybe leave a comment?
> >
> > the explanation of the function is in the reference header file.
> >
&g
Hi Dorinda
>
> On Mon, Mar 6, 2023 at 9:11 PM Dorinda Bassey wrote:
> >
> > This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> > both an audio sink and source. This backend is available on most systems
> >
> > Add Pipewire entry points
I see what you mean, thanks!
On Sat, Mar 4, 2023 at 2:51 PM Marc-André Lureau
wrote:
> Hi
>
> On Fri, Mar 3, 2023 at 8:00 PM Dorinda Bassey wrote:
> >
> > This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> > both an audio sink and source. T
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v7:
use
<
marcandre.lur...@gmail.com> wrote:
> Hi Dorinda
>
> On Tue, Feb 28, 2023 at 2:01 AM Dorinda Bassey wrote:
> >
> > This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> > both an audio sink and source. This backend is available on most systems
>
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v6:
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v5:
sil
>
> Should be 8.0
Wait, 8.0? The latest I can see so far is 7.2 or is there a specific page
for tracking the QEMU releases?
On Sun, Feb 26, 2023 at 2:32 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Fri, Feb 17, 2023 at 9:08 PM Dorinda Bassey wrote
x27;s supposed to be 15000
Should be 8.0
>
Yes, Thanks.
On Sun, Feb 26, 2023 at 2:32 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Fri, Feb 17, 2023 at 9:08 PM Dorinda Bassey wrote:
> >
> > This commit adds a new audiodev backend to allow QE
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
fix typo
r
that implement playback and recording will create streams
for playback and capture that will start processing and will result in
the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the
qpw_audio_init() method.
Signed-off-by: Dorinda Bassey
---
v3:
Wrap co
ameter
to set the latency to desired value.
On Thu, Feb 16, 2023 at 12:41 PM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Thursday, February 16, 2023 9:25:44 AM CET Dorinda Bassey wrote:
> > This commit adds a new audiodev backend to allow QEMU to use Pipewire as
&
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both
an audio sink and source.
Signed-off-by: Dorinda Bassey
---
v2:
* Shorten commit message
* fix copyright ownership and authour
* use QEMU standard of 4 space indentation
* verbose use of pipewire instead pf pw
audio
>
> Are there any additional features available when using the pipewire
> protocol instead of pulseaudio or jack?
yes, Pipewire supports both use cases, It is more or less a hybrid between
pulseaudio and jack.
Pipewire uses a much more accurate timing model for timer based scheduling.
Pipewire pr
On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck
> wrote:
> >
> > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey
> wrote:
> > > >
> > &
de of work
context I would use copyright ownership for Red Hat and author: Dorinda
Bassey
As a style point, QEMU standard is for 4-space indents in
> C code.
>
noted
I appreciate you probably just followed the example of pulseaudio,
> abbreviated
> to 'pa', but I'm not
hese methods that implement playback
and recording will create streams for playback and capture that will start
processing and will result in the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the qpw_audio_init()
method.
Signed-off-by: Dorinda Ba
hese methods that implement playback
and recording will create streams for playback and capture that will start
processing and will result in the on_process callbacks to be called.
Built a connection to the Pipewire sound system server in the qpw_audio_init()
method.
Signed-off-by: Dorinda Ba
40 matches
Mail list logo