Re: [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

2018-12-05 Thread Dominik Csapak
On 12/5/18 1:21 PM, Markus Armbruster wrote: Dominik Csapak writes: This series improves the QMP SHUTDOWN and RESET events by adding the ShutdownCause as additional parameter and splitting the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET to be able to detect the difference

[Qemu-devel] [PATCH v3 3/3] qapi: Split host-qmp into quit and system-reset

2018-12-05 Thread Dominik Csapak
the iotests from 'host-qmp' to 'host-qmp-quit'. This does not break compatibility because the field was introduced in the same version. Signed-off-by: Dominik Csapak --- qapi/run-state.json| 10 ++ qmp.c | 4 ++-- tests/qemu-iotests/

[Qemu-devel] [PATCH v3 1/3] qapi: Turn ShutdownCause into QAPI enum

2018-12-05 Thread Dominik Csapak
Needed so the patch after next can add ShutdownCause to QMP events SHUTDOWN and RESET. Signed-off-by: Dominik Csapak --- include/sysemu/sysemu.h | 20 qapi/run-state.json | 34 ++ 2 files changed, 34 insertions(+), 20 deletions(-) diff

[Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

2018-12-05 Thread Dominik Csapak
* added documentation for 'reason' in the SHUTDOWN/RESET events (this was missing in v1) Dominik Csapak (3): qapi: Turn ShutdownCause into QAPI enum qapi: Add reason to SHUTDOWN and RESET events qapi: Split host-qmp into quit and system-reset include/sysemu/sysemu.h| 2

[Qemu-devel] [PATCH v3 2/3] qapi: Add reason to SHUTDOWN and RESET events

2018-12-05 Thread Dominik Csapak
reason. Signed-off-by: Dominik Csapak --- qapi/run-state.json| 8 ++-- tests/qemu-iotests/060.out | 4 ++-- tests/qemu-iotests/071.out | 4 ++-- tests/qemu-iotests/081.out | 14 +++--- tests/qemu-iotests/087.out | 12 ++-- tests/qemu-iotests/094.out | 2 +- tests

Re: [Qemu-devel] [PATCH v2 1/3] qapi: Turn ShutdownCause into QAPI enum

2018-12-03 Thread Dominik Csapak
On 12/3/18 10:34 PM, Eric Blake wrote: On 12/3/18 3:26 AM, Dominik Csapak wrote: Needed so the patch after next can add ShutdownCause to QMP events SHUTDOWN and RESET. Signed-off-by: Dominik Csapak ---   include/sysemu/sysemu.h | 20   qapi/run-state.json | 34

Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add reason to SHUTDOWN and RESET events

2018-12-03 Thread Dominik Csapak
On 12/3/18 10:36 PM, Eric Blake wrote: On 12/3/18 3:26 AM, Dominik Csapak wrote: This makes it possible to determine what the exact reason was for a RESET or a SHUTDOWN. A management layer might need the specific reason of those events to determine which cleanups or other actions it needs to

Re: [Qemu-devel] [PATCH v2 3/3] qapi: Split host-qmp into quit and system-reset

2018-12-03 Thread Dominik Csapak
On 12/3/18 10:38 PM, Eric Blake wrote: On 12/3/18 3:26 AM, Dominik Csapak wrote: It is interesting to know whether the shutdown cause was 'quit' or 'reset', especially when using "--no-reboot". In that case, a management layer can now determine if the guest wanted

[Qemu-devel] [PATCH v2 2/3] qapi: Add reason to SHUTDOWN and RESET events

2018-12-03 Thread Dominik Csapak
-off-by: Dominik Csapak --- qapi/run-state.json| 8 ++-- tests/qemu-iotests/060.out | 4 ++-- tests/qemu-iotests/071.out | 4 ++-- tests/qemu-iotests/081.out | 14 +++--- tests/qemu-iotests/087.out | 12 ++-- tests/qemu-iotests/094.out | 2 +- tests/qemu-iotests/109

[Qemu-devel] [PATCH v2 0/3] qapi: return ShutdownCause for events

2018-12-03 Thread Dominik Csapak
es in more detail in commit messages * better punctuation and wording in commit messages * switched patch 2 and 3 * fix iotests after both 2 and 3 * added documentation for 'reason' in the SHUTDOWN/RESET events (this was missing in v1) Dominik Csapak (3): qapi: Turn ShutdownCause into Q

[Qemu-devel] [PATCH v2 3/3] qapi: Split host-qmp into quit and system-reset

2018-12-03 Thread Dominik Csapak
the iotests from 'host-qmp' to 'host-qmp-quit'. Signed-off-by: Dominik Csapak --- qapi/run-state.json| 10 ++ qmp.c | 4 ++-- tests/qemu-iotests/060.out | 4 ++-- tests/qemu-iotests/071.out | 4 ++-- tests/qemu-iotests/081.out |

[Qemu-devel] [PATCH v2 1/3] qapi: Turn ShutdownCause into QAPI enum

2018-12-03 Thread Dominik Csapak
Needed so the patch after next can add ShutdownCause to QMP events SHUTDOWN and RESET. Signed-off-by: Dominik Csapak --- include/sysemu/sysemu.h | 20 qapi/run-state.json | 34 ++ 2 files changed, 34 insertions(+), 20 deletions(-) diff

Re: [Qemu-devel] [PATCH 2/3] qapi: split host-qmp into quit and system-reset

2018-11-30 Thread Dominik Csapak
On 11/30/18 10:41 AM, Markus Armbruster wrote: Cc: Pavel to assess possible impact on replay. Cc: Eric to give him a chance to correct misunderstandings of ShutdownCause. Dominik Csapak writes: it is interesting to know whether the shutdown cause was 'quit' or 'reset', e

Re: [Qemu-devel] [PATCH 0/3] qapi: return ShutdownCause for events

2018-11-19 Thread Dominik Csapak
Hi, i guess many of you are occupied with 3.1, but had anyone time to look at this? kind regards On 10/31/18 12:52 PM, Dominik Csapak wrote: This series improves the QMP SHUTDOWN and RESET events by adding the ShutdownCause as additional parameter and splitting the HOST_QMP reason into

[Qemu-devel] [PATCH 0/3] qapi: return ShutdownCause for events

2018-10-31 Thread Dominik Csapak
y previous patches[1][2] which added an exit-script/added a 'reset' argument to the events 1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00697.html 2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01271.html Dominik Csapak (3): qapi: move ShutdownCause to

[Qemu-devel] [PATCH 3/3] qapi: add reason to SHUTDOWN and RESET events

2018-10-31 Thread Dominik Csapak
this makes it possible to determine what the exact reason was for a RESET or a SHUTDOWN this patch also fixes the iotests Signed-off-by: Dominik Csapak --- qapi/run-state.json| 4 ++-- tests/qemu-iotests/060.out | 4 ++-- tests/qemu-iotests/071.out | 4 ++-- tests/qemu-iotests/081

[Qemu-devel] [PATCH 2/3] qapi: split host-qmp into quit and system-reset

2018-10-31 Thread Dominik Csapak
it is interesting to know whether the shutdown cause was 'quit' or 'reset', especially when using --no-reboot Signed-off-by: Dominik Csapak --- qapi/run-state.json | 10 ++ qmp.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH 1/3] qapi: move ShutdownCause to qapi/run-state.json

2018-10-31 Thread Dominik Csapak
this makes it possible to use the reason as return value in a QMP event, such as SHUTDOWN Signed-off-by: Dominik Csapak --- include/sysemu/sysemu.h | 20 qapi/run-state.json | 33 + 2 files changed, 33 insertions(+), 20 deletions(-) diff

Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

2018-10-23 Thread Dominik Csapak
On 10/17/18 4:43 PM, Paolo Bonzini wrote: On 17/10/2018 15:54, Eric Blake wrote: So the problem with shutdown_caused_by_guest is that you get the same value for both guest reset and guest shutdown.  Could we instead just pass the ShutdownCause in the event (similar to what was proposed even whe

Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

2018-10-17 Thread Dominik Csapak
On 10/17/18 3:51 PM, Eric Blake wrote: On 10/17/18 2:17 AM, Dominik Csapak wrote: On 10/8/18 3:19 PM, Dominik Csapak wrote: when '-no-reboot' is set, it is interesting if the guest was originally shutdown or reset, so save and return that info Signed-off-by: Dominik Csapak ---

Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

2018-10-17 Thread Dominik Csapak
On 10/17/18 12:58 PM, Paolo Bonzini wrote: On 17/10/2018 09:17, Dominik Csapak wrote: On 10/8/18 3:19 PM, Dominik Csapak wrote: when '-no-reboot' is set, it is interesting if the guest was originally shutdown or reset, so save and return that info   {   if (no_reboot

Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

2018-10-17 Thread Dominik Csapak
On 10/8/18 3:19 PM, Dominik Csapak wrote: when '-no-reboot' is set, it is interesting if the guest was originally shutdown or reset, so save and return that info Signed-off-by: Dominik Csapak --- qapi/run-state.json | 5 - vl.c| 5 - 2 files changed, 8

[Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

2018-10-08 Thread Dominik Csapak
when '-no-reboot' is set, it is interesting if the guest was originally shutdown or reset, so save and return that info Signed-off-by: Dominik Csapak --- qapi/run-state.json | 5 - vl.c| 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 0/3] add exit-script option to qemu

2018-10-08 Thread Dominik Csapak
On 10/8/18 5:28 AM, Jason Wang wrote: On 2018年10月04日 19:43, Dominik Csapak wrote: this patch series aims to execute a script when qemu exits so that one can do cleanups when using --daemonize without having to use the qmp monitor Hi: Can you give a example of why it must be done through

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-05 Thread Dominik Csapak
On 10/5/18 10:38 AM, Daniel P. Berrangé wrote: On Fri, Oct 05, 2018 at 08:56:27AM +0200, Dominik Csapak wrote: On 10/4/18 3:51 PM, Daniel P. Berrangé wrote: On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: this patch aims to execute a script when qemu exits so that one can do

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-05 Thread Dominik Csapak
On 10/4/18 3:51 PM, Daniel P. Berrangé wrote: On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: this patch aims to execute a script when qemu exits so that one can do cleanups when using --daemonize without having to use the qmp monitor IMHO the idea of cleanup scripts run by

[Qemu-devel] [PATCH v2 2/3] tap: use qemu_launch_script instead of launch_script

2018-10-04 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes since v1: * new in v2 net/tap.c | 56 ++-- 1 file changed, 10 insertions(+), 46 deletions(-) diff --git a/net/tap.c b/net/tap.c index cc8525f154..15a0dd65b8 100644 --- a/net/tap.c +++ b/net/tap.c

[Qemu-devel] [PATCH v2 1/3] osdep: add qemu_launch_script for executing scripts

2018-10-04 Thread Dominik Csapak
this adds a small function for launching an external script via fork/exec (not available for windows) and is intended for replacing 'launch_script' in net/tap.c and to provide a general way to launch scripts Signed-off-by: Dominik Csapak --- i modeled the windows error after the

[Qemu-devel] [PATCH v2 0/3] add exit-script option to qemu

2018-10-04 Thread Dominik Csapak
launch_script * fixed a small error in the option description Dominik Csapak (3): osdep: add qemu_launch_script for executing scripts tap: use qemu_launch_script instead of launch_script vl.c: call optional script when exiting include/qemu/osdep.h | 12 +++ net/tap.c| 56

[Qemu-devel] [PATCH v2 3/3] vl.c: call optional script when exiting

2018-10-04 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes since v1: * only for non WIN32 * use qemu_launch_script * fix error in option description (@var{file} instead of $var{file}) qemu-options.hx | 20 vl.c| 29 + 2 files changed, 49 insertions(+) diff

[Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-03 Thread Dominik Csapak
and if it does, where to put such a function Dominik Csapak (1): vl.c: call optional script when exiting qemu-options.hx | 18 ++ vl.c| 45 + 2 files changed, 63 insertions(+) -- 2.11.0

[Qemu-devel] [PATCH 1/1] vl.c: call optional script when exiting

2018-10-03 Thread Dominik Csapak
some users might want to call a script when qemu exits, without listening to a qmp monitor for events when running with --daemonize this can be used for things like external cleanups Signed-off-by: Dominik Csapak --- qemu-options.hx | 18 ++ vl.c| 45

[Qemu-devel] qemu-img convert corruption (raw to raw)

2016-03-23 Thread Dominik Csapak
es me, since it would seem that the source cache is the culprit, not the target) i apologize for the long message and hope someone can explain this to me with kind regards Dominik Csapak