[PATCH v4 4/5] ui/sdl2: pass horizontal scroll information to the device code

2022-01-08 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/sdl2.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 0bd30504cf..46a252d7d9 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -33,6 +33,7 @@ #include "sysemu/runstate-action.h" #include "sysemu/sysemu.h" #i

Re: [PATCH v2 1/5] ps2: Initial horizontal scroll support

2022-01-08 Thread Dmitry Petrov
Hi Daniel, Thanks for the link! I've sent a v4 patch with a cover letter that includes it as well as the latest comments by Marc-André to v2 of the patch. Kind regards, Dmitry On Tue, 4 Jan 2022 at 13:30, Daniel P. Berrangé wrote: > On Wed, Dec 22, 2021 at 02:06:43AM +0100, Dmitr

[PATCH v4 5/5] ui/input-legacy: pass horizontal scroll information

2022-01-08 Thread Dmitry Petrov
This code seems to be used by vmport hack, passing these values allows to implement horizontal scroll support even when using vmport. In case it's not supported horizontal scroll will act as a vertical one. Signed-off-by: Dmitry Petrov --- ui/input-legacy.c | 15 +++ 1 file ch

[PATCH v4 2/5] ui/cocoa: pass horizontal scroll information to the device code

2022-01-08 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/cocoa.m | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 69745c483b..ac18e14ce0 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -970,21 +970,27 @@ QemuCocoaView *cocoaView

[PATCH v4 0/5] Add horizontal mouse scroll support

2022-01-08 Thread Dmitry Petrov
- Value is clamped to 31 for horizontal scroll in the device code Changes from V2 to V3: - Cover letter - Removed unnecessary log line Changes from V3 to V4: - Added a link to the original submission by Brad Dmitry Petrov (5): ps2: Initial horizontal scroll support ui/cocoa: pass horizontal

[PATCH v4 3/5] ui/gtk: pass horizontal scroll information to the device code

2022-01-08 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/gtk.c | 54 ++ 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6a1f65d518..a8567b9ddc 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -968,33 +968,63 @@ static gboolean

[PATCH v4 1/5] ps2: Initial horizontal scroll support

2022-01-08 Thread Dmitry Petrov
This change adds support for horizontal scroll to ps/2 mouse device code. The code is implemented to match the logic of linux kernel which is used as a reference. Signed-off-by: Dmitry Petrov --- hw/input/ps2.c | 57 +++--- qapi/ui.json | 2 +- 2

[PATCH v3 0/5] Add horizontal mouse scroll support

2021-12-22 Thread Dmitry Petrov
This patchset adds implements passing horizontal scroll events from the host system to guest systems via ps/2 mouse device. This is useful during testing horizontal scroll behaviour in guest operating systems as well as using it in case it provides any benefits for a particular application. The p

[PATCH v3 2/5] ui/cocoa: pass horizontal scroll information to the device code

2021-12-22 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/cocoa.m | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 69745c483b..ac18e14ce0 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -970,21 +970,27 @@ QemuCocoaView *cocoaView

[PATCH v3 5/5] ui/input-legacy: pass horizontal scroll information

2021-12-22 Thread Dmitry Petrov
This code seems to be used by vmport hack, passing these values allows to implement horizontal scroll support even when using vmport. In case it's not supported horizontal scroll will act as a vertical one. Signed-off-by: Dmitry Petrov --- ui/input-legacy.c | 15 +++ 1 file ch

[PATCH v3 4/5] ui/sdl2: pass horizontal scroll information to the device code

2021-12-22 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/sdl2.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 0bd30504cf..46a252d7d9 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -33,6 +33,7 @@ #include "sysemu/runstate-action.h" #include "sysemu/sysemu.h" #i

[PATCH v3 3/5] ui/gtk: pass horizontal scroll information to the device code

2021-12-22 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/gtk.c | 54 ++ 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6a1f65d518..a8567b9ddc 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -968,33 +968,63 @@ static gboolean

[PATCH v3 1/5] ps2: Initial horizontal scroll support

2021-12-22 Thread Dmitry Petrov
This change adds support for horizontal scroll to ps/2 mouse device code. The code is implemented to match the logic of linux kernel which is used as a reference. Signed-off-by: Dmitry Petrov --- hw/input/ps2.c | 57 +++--- qapi/ui.json | 2 +- 2

Re: [PATCH v2 1/5] ps2: Initial horizontal scroll support

2021-12-22 Thread Dmitry Petrov
submission, still trying to get used to the tooling and requirements. Thanks! Dmitry Petrov On Wed, 22 Dec 2021 at 14:59, Marc-André Lureau wrote: > Hi > > On Wed, Dec 22, 2021 at 5:27 AM Dmitry Petrov wrote: > >> v2: >> - Patch is split into a sequence >> - valu

[PATCH v2 4/5] ui/sdl2: pass horizontal scroll information to the device code

2021-12-21 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/sdl2.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 17c0ec30eb..19bbc1fdd4 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -33,6 +33,7 @@ #include "sysemu/runstate-action.h" #include "sysemu/sysemu.h" #i

[PATCH v2 3/5] ui/gtk: pass horizontal scroll information to the device code

2021-12-21 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/gtk.c | 54 ++ 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 428f02f2df..b52eec6fe9 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -963,33 +963,63 @@ static gboolean

[PATCH v2 5/5] ui/input-legacy: pass horizontal scroll information

2021-12-21 Thread Dmitry Petrov
This code seems to be used by vmport hack, passing these values allows to implement horizontal scroll support even when using vmport. In case it's not supported horizontal scroll will act as a vertical one. Signed-off-by: Dmitry Petrov --- ui/input-legacy.c | 16 1 file ch

[PATCH v2 2/5] ui/cocoa: pass horizontal scroll information to the device code

2021-12-21 Thread Dmitry Petrov
Signed-off-by: Dmitry Petrov --- ui/cocoa.m | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 68a6302184..22a1f6776e 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -970,21 +970,27 @@ QemuCocoaView *cocoaView

Re: [PATCH] ps2: Initial horizontal scroll support

2021-12-21 Thread Dmitry Petrov
at do not exist. After all the investigation I decided to simply mimic the linux kernel behaviour and keep the comment from the original patch regarding the buttons. I will rephrase comments a bit, split the patch into a sequence and resubmit. Thanks a lot! Dmitry Petrov On Tue, 21 Dec 2021 at

[PATCH v2 1/5] ps2: Initial horizontal scroll support

2021-12-21 Thread Dmitry Petrov
=579968 This change adds support for horizontal scroll to ps/2 mouse device code. The code is implemented to match the logic of linux kernel which is used as a reference. Signed-off-by: Dmitry Petrov --- hw/input/ps2.c | 57 +++--- qapi/ui.json | 2

[PATCH] ps2: Initial horizontal scroll support

2021-12-20 Thread Dmitry Petrov
Jorsch done in 2010 but never merge, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579968 Signed-off-by: Dmitry Petrov --- hw/input/ps2.c| 54 --- qapi/ui.json | 2 +- ui/cocoa.m| 18 ++-- ui/gtk.c | 54