Re: [PATCH] target/i386: Fix decoding of certain BMI instructions

2021-01-27 Thread David Greenaway
On 14 Jan 2021, David Greenaway wrote: > This patch fixes a translation bug for a subset of x86 BMI instructions > such as the following: [...] Gentle ping. The patch is up at: https://patchwork.kernel.org/project/qemu-devel/patch/20210114063958.1508050-1-dgreena...@google.com/ if that

[PATCH] target/i386: Fix decoding of certain BMI instructions

2021-01-14 Thread David Greenaway via
This patch removes the incorrect check in "gen_sse" that causes the exception to be generated. For the non-BMI cases, the check is redundant: prefixes are already checked at line 3696. Buglink: https://bugs.launchpad.net/qemu/+bug/1748296 Signed-off-by: David Greenaway --- I'm

[Bug 1748296] Re: TCG throws Invalid Opcode when executing x86 BMI shlx instruction

2021-01-13 Thread David Greenaway
I hit this today on QEMU head. The problem appears to crop up when: 1. Decoding a VEX instruction (see [1]) that uses the 0x66 mandatory prefix; and 2. The OSFXSR bit in CR4 is clear (that is, SSE is disabled) This means that x86_64 instructions such as: c4 e2 f9 f7 c0