On Thu, Sep 29, 2022, at 1:03 PM, Vivek Goyal wrote:
>
> So rust version of virtiofsd, already supports running unprivileged
> (inside a user namespace).
I know, but as I already said, the use case here is running inside an OpenShift
unprivileged pod where *we are already in a container*.
>
On Thu, Sep 29, 2022, at 10:10 AM, Vivek Goyal wrote:
> What's your use case. How do you plan to use virtiofs.
At the current time, the Kubernetes that we run does not support user
namespaces. We want to do the production builds of our operating system
(Fedora CoreOS and RHEL CoreOS) today
On Wed, Sep 28, 2022, at 3:28 PM, Vivek Goyal wrote:
> Sounds reasonable. In fact, we could probably do someting similar
> for "landlock" as well.
Thanks for the discussion all! Can someone (vaguely) commit to look into this
in say the next few months? It's not *urgent*, we can live with the
On Tue, Sep 27, 2022, at 1:27 PM, German Maglione wrote:
>
>> > Now all the development has moved to rust virtiofsd.
Oh, awesome!! The code there looks great.
> I could work on this for the next major version and see if anything breaks.
> But I prefer to add this as a compilation feature, ins
We previously had a chat here
https://lore.kernel.org/all/348d4774-bd5f-4832-bd7e-a21491fda...@www.fastmail.com/T/
around virtiofsd and privileges and the case of trying to run virtiofsd inside
an unprivileged (Kubernetes) container.
Right now we're still using 9p, and it has bugs (basically it
If object-del input-linux object on-the-fly, instance finalize will
close evdev fd without resetting it. However the main thread is still
trying to lock_acquire/lock_release during ppoll, which leads to a very
high CPU utilization.
Signed-off-by: Colin Xu
---
ui/input-linux.c | 1 +
1 file
On Wed, Jun 17, 2020, at 8:50 AM, Stefan Hajnoczi wrote:
> Something along these lines should work. Hopefully seccomp can be
> retained. It would also be necessary to check how not having the shared
> directory as / in the mount namespace affects functionality. For one,
> I'm pretty sure symlin
On Tue, Jun 2, 2020, at 5:55 AM, Stefan Hajnoczi wrote:
>
> Ping Colin. It would be great if you have time to share your thoughts on
> this discussion and explain how you are using this patch.
Yeah sorry about not replying in this thread earlier, this was just a quick
Friday side pr
Bowen is no longer working on the project so continue the revising.
Sorry for the delayed reply.
On 2020-05-09 11:59, Colin Xu wrote:
From: WangBowen
Dynamic allocating vcpu state structure according to smp value to be
more precise and safe. Previously it will alloccate array of fixed size
, the process will terminate,
otherwise it will allocate array of size smp to store the status.
V2: Check max_cpus before open vm. (Philippe)
Signed-off-by: WangBowen
Signed-off-by: Colin Xu
---
target/i386/hax-all.c | 25 +++--
target/i386/hax-i386.h | 5 +++--
2 files
On Mon, May 4, 2020, at 10:07 AM, Marc-André Lureau wrote:
> Now that systemd-nspawn works without privileges, isn't that also a
> solution? One that would fit both system and session level
> permissions, and integration with other services?
This is a complex topic and one I should probably wr
mplementing the containerization
itself)
Signed-off-by: Colin Walters
---
tools/virtiofsd/passthrough_ll.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 4c35c95b25..46
And this one. 3 patches for HAX.
Thanks in advance.
--
Best Regards,
Colin Xu
On Mon, 20 Apr 2020, Colin Xu wrote:
Looks good to me.
Reviewed-by: Colin Xu
--
Best Regards,
Colin Xu
On Mon, 6 Apr 2020, WangBowen wrote:
Dynamic allocating vcpu state structure according to smp value to
Hi Paolo,
Would you also help queue this one for PULL?
--
Best Regards,
Colin Xu
On Mon, 20 Apr 2020, Colin Xu wrote:
Looks good to me.
Reviewed-by: Colin Xu
--
Best Regards,
Colin Xu
On Fri, 10 Apr 2020, WangBowen wrote:
This commit tried to obtain max vcpu of haxm driver by calling
Hi Paolo,
Would you please queue this one?
--
Best Regards,
Colin Xu
On Mon, 30 Mar 2020, Colin Xu wrote:
Looks good to me.
Reviewed-by: Colin Xu
On 2020-03-30 11:25, hang.y...@linux.intel.com wrote:
From: Hang Yuan
Add ROM and ROM device memory region support in HAX. Their memory
Looks good to me.
Reviewed-by: Colin Xu
--
Best Regards,
Colin Xu
On Tue, 21 Apr 2020, Eric Blake wrote:
Blindly setting FD_CLOEXEC without a read-modify-write will
inadvertently clear any other intentionally-set bits, such as a
proposed new bit for designating a fd that must behave in 32
Looks good to me.
Reviewed-by: Colin Xu
--
Best Regards,
Colin Xu
On Fri, 10 Apr 2020, WangBowen wrote:
This commit tried to obtain max vcpu of haxm driver by calling
HAX_IOCTL_CAP_MAX_VCPU before creating the vm so that if using hax as
the accelerator and the smp value is larger than the
Looks good to me.
Reviewed-by: Colin Xu
--
Best Regards,
Colin Xu
On Mon, 6 Apr 2020, WangBowen wrote:
Dynamic allocating vcpu state structure according to smp value to be
more precise and safe. Previously it will alloccate array of fixed size
HAX_MAX_VCPU.
This is achieved by using
ruct vcpu_state_t {
uint32_t _activity_state;
uint32_t pad;
interruptibility_state_t _interruptibility_state;
+
+ uint64_t _cr8;
};
/* HAX exit status */
--
2.15.0.windows.1
--
Best Regards,
Colin Xu
Looks good to me.
Reviewed-by: Colin Xu
On 2020-03-30 11:25, hang.y...@linux.intel.com wrote:
From: Hang Yuan
Add ROM and ROM device memory region support in HAX. Their memory region is
read only and write access will generate EPT violation. The violation will be
handled in the HAX kernel
On 2020-03-17 18:27, Paolo Bonzini wrote:
On 17/03/20 09:55, Colin Xu wrote:
On 2020-03-17 16:26, Paolo Bonzini wrote:
On 17/03/20 08:46, Colin Xu wrote:
Hi Paolo,
For future HAX patch, once it's "Reviewed-by" haxm maintainers and other
reviewers, do we need "SubmitAPul
On 2020-03-17 16:26, Paolo Bonzini wrote:
On 17/03/20 08:46, Colin Xu wrote:
Hi Paolo,
For future HAX patch, once it's "Reviewed-by" haxm maintainers and other
reviewers, do we need "SubmitAPullRequest" separately or you will do it
together with other patches?
A
Hi Paolo,
For future HAX patch, once it's "Reviewed-by" haxm maintainers and other
reviewers, do we need "SubmitAPullRequest" separately or you will do it
together with other patches?
Colin
On 2020-03-17 05:26, Paolo Bonzini wrote:
From: Colin Xu
HAXM covers be
On 2020-02-28 19:00, Paolo Bonzini wrote:
On 28/02/20 02:20, Colin Xu wrote:
HAXM covers below files:
include/sysemu/hax.h
target/i386/hax-*
V2: Add HAXM github page for wiki and issue tracking.
Cc: Wenchao Wang
Cc: Hang Yuan
Reviewed-by: Hang Yuan
Signed-off-by: Colin Xu
HAXM covers below files:
include/sysemu/hax.h
target/i386/hax-*
V2: Add HAXM github page for wiki and issue tracking.
Cc: Wenchao Wang
Cc: Hang Yuan
Reviewed-by: Hang Yuan
Signed-off-by: Colin Xu
---
MAINTAINERS | 11 +++
1 file changed, 11 insertions(+)
diff --git a/MAINTAINERS b
On 2020-02-27 16:00, Philippe Mathieu-Daudé wrote:
On 2/27/20 8:56 AM, Philippe Mathieu-Daudé wrote:
Cc'ing qemu-trivial@
On 2/26/20 5:32 AM, Colin Xu wrote:
HAXM covers below files:
include/sysemu/hax.h
target/i386/hax-*
Cc: Wenchao Wang
Cc: Hang Yuan
Signed-off-by: Colin Xu
P
HAXM covers below files:
include/sysemu/hax.h
target/i386/hax-*
Cc: Wenchao Wang
Cc: Hang Yuan
Signed-off-by: Colin Xu
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36d94c17a654..27727e2fac13 100644
--- a/MAINTAINERS
+++ b
ps is showing QEMU is running as follows:
/usr/bin/qemu-system-s390x -name guest=ubuntu20.04-focal-s390x,debug-
threads=on -S -object
secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain-10-ubuntu20.04-focal-s3
/master-key.aes -machine s390-ccw-virtio-eoan,accel=tcg,usb=off,dump-
gues
I've also seen in the dmesg log:
[ 287.624414] User process fault: interruption code 0007 ilc:3 in
libstdc++.so.6.0.28[3ffb3e0+21d000]
[ 288.991706] User process fault: interruption code 0007 ilc:3 in
libstdc++.so.6.0.28[3ff9008+21d000]
--
You received this bug notification because y
Public bug reported:
Running qemu-system-s390x (1:4.0+dfsg-0ubuntu10) on an x86-64 Focal host
with an upgrade of a Eoan s390x VM to a Focal s390x is triggering random
breakage, for example:
sudo apt-get update && sudo apt-get dist-upgrade
...
...
Unpacking debianutils (4.9) over (4.8.6.3) ...
S
On 2019-06-25 21:40, Eric Blake wrote:
On 6/25/19 5:42 AM, Daniel P. Berrangé wrote:
On Tue, Jun 25, 2019 at 11:21:42AM +0800, Colin Xu wrote:
The double slash in path will fail the installation on MINGW/MSYS.
Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons)
Signed-off-by
On 2019-06-25 18:43, Philippe Mathieu-Daudé wrote:
Hi Colin,
On 6/25/19 5:21 AM, Colin Xu wrote:
The double slash in path will fail the installation on MINGW/MSYS.
Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons)
Signed-off-by: Colin Xu
---
Makefile | 16
The double slash in path will fail the installation on MINGW/MSYS.
Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons)
Signed-off-by: Colin Xu
---
Makefile | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index
HAXM covers below files:
include/sysemu/hax.h
target/i386/hax-*
Cc: Wenchao Wang
Cc: Hang Yuan
Signed-off-by: Colin Xu
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 588c8d947a08..fccae4e7de48 100644
--- a/MAINTAINERS
+++ b
android emulator with Change-Id:
I9c5752cc737fd305d7eace1768ea12a07309d716
Cc: Yu Ning
Cc: Chuanxiao Dong
Signed-off-by: Colin Xu
---
cpus.c| 1 -
target/i386/hax-all.c | 36 ++--
2 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/cpus.c b/cpus.c
index ffc57119ca5e..
cc more.
On 2019-06-10 10:19, Colin Xu wrote:
QEMU tracks whether a vcpu is halted using CPUState::halted. E.g.,
after initialization or reset, halted is 0 for the BSP (vcpu 0)
and 1 for the APs (vcpu 1, 2, ...). A halted vcpu should not be
handed to the hypervisor to run (e.g. hax_vcpu_run
Doesn't happen when adding another UHCI controller and explicitly
connecting the keyboard to it, like: -device vt82c686b-usb-uhci,id=myusb
-device usb-host,bus=myusb.0,hostbus=3,hostaddr=2
Is QEMU just incorrectly connecting my full-speed USB keyboard to USB 2.0 EHCI
instead of USB 1.x UHCI?
Or i
Same problem with qemu 2.8 from Ubuntu Cloud Archive.
Is that enough to consider the bug highly likely in latest upstream version
too? I don't have a QEMU build system at hand right now..
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are
Public bug reported:
Using qemu-kvm as shipped with Ubuntu 16.04, I cannot get a passed-
through USB Host Keyboard to work at boot-up using the Q35 platform.
My minimal example to verify this bug is the following:
qemu-system-x86_64 -M q35 -m 128 -cdrom mini.iso -usb -usbdevice
host:04ca:005a
This seems to only affect fullscreen mode, so if that's the case, I
don't see it as resolved.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1274170
Title:
qemu window hides in the background on osx
Updates the help messages to remove misleading information about SDL
being the normal display used.
Signed-off-by: Colin Lord
---
v3: Try to make help more general to cover all cases nicely.
qemu-options.hx | 38 +-
1 file changed, 21 insertions(+), 17
no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (2):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Modularize
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c | 36
On 08/11/2016 09:29 PM, Fam Zheng wrote:
> On Thu, 08/11 12:03, Colin Lord wrote:
>> On 08/10/2016 11:23 PM, Fam Zheng wrote:
>>> On Wed, 08/10 21:06, Max Reitz wrote:
>>>> On 10.08.2016 21:04, Colin Lord wrote:
>>>>> On 08/10/2016 02:37 PM, Max Reitz
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: S
ibbz2, while the
main QEMU package needn't to. With this patch, we (temporarily) change
the case so that the main QEMU depends on libbz2 again.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
Makefile | 3 ---
block.c
On 08/10/2016 11:23 PM, Fam Zheng wrote:
> On Wed, 08/10 21:06, Max Reitz wrote:
>> On 10.08.2016 21:04, Colin Lord wrote:
>>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>>> On 08.08.2016 20:07, Colin Lord wrote:
>>>>> From: Marc Mari
>>>>
On 08/10/2016 03:24 PM, Colin Lord wrote:
> On 08/10/2016 03:04 PM, Colin Lord wrote:
>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>> On 08.08.2016 20:07, Colin Lord wrote:
>>>> From: Marc Mari
>>>>
>>>> Extend the current module interface to
On 08/10/2016 03:04 PM, Colin Lord wrote:
> On 08/10/2016 02:37 PM, Max Reitz wrote:
>> On 08.08.2016 20:07, Colin Lord wrote:
>>> From: Marc Mari
>>>
>>> Extend the current module interface to allow for block drivers to be
>>> loaded dynamically o
On 08/10/2016 03:04 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> Modularizes the nfs block driver so that it gets dynamically loaded.
>>
>> Signed-off-by: Colin Lord
>> Reviewed-by: Stefan Hajnoczi
>> ---
>> block/Makefile.objs | 1 +
On 08/10/2016 02:37 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> From: Marc Mari
>>
>> Extend the current module interface to allow for block drivers to be
>> loaded dynamically on request. The only block drivers that can be
>> converted into m
a new structure found
in module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
Makefile | 3 ---
block.c | 62 +--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: S
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 40
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (2):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Modularize nfs block driver
On 08/08/2016 11:18 AM, Stefan Hajnoczi wrote:
> On Tue, Aug 02, 2016 at 10:12:14AM -0400, Colin Lord wrote:
>> diff --git a/vl.c b/vl.c
>> index e7c2c62..1a5f807 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -506,6 +506,41 @@ static QemuOptsList qemu_fw_cfg_opts = {
Updates the help messages to reflect that GTK is the default display (if
enabled), not SDL.
Signed-off-by: Colin Lord
---
v2: Update to try to implement Paolo's suggested wordings. It looks to
me like the subsections get wrapped at 72 lines, which mean there was a
bit of a ripple effec
link command incorrectly,
spoiling the purpose of modularization.
Currently we don't have any .mo-libs usage, but it will be used soon
when we modularize more multi-source objects, like sdl and gtk.
Reported-by: Colin Lord
Signed-off-by: Fam Zheng
---
rules.mak | 2 +-
1 file chang
None.
This should give improvements in terms of performance, since much less
libraries will be loaded at startup if GTK is not being used, and in
terms of packaging, since GTK should be able to be packaged separately
in binary package managers now.
Signed-off-by: Colin Lord
---
Makefile.objs
le loading for
block drivers'.
Colin Lord (1):
gtk: Modularize GTK display
Fam Zheng (1):
rules.mak: Don't extract libs from .mo-libs in link command
Makefile.objs| 1 +
configure| 5 ++--
include/ui/console.h | 6 +
rules.mak| 2
ey follow the naming
pattern of format-probe.c
- Renamed crypto probe file to be crypto-probe.c, luks is no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_pro
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
On 08/02/2016 10:12 AM, Colin Lord wrote:
> I'm sending one more version of this series. v5 didn't seem to need any
> huge makeovers, but I found a small bug in it so I'm hoping it hasn't
> been committed yet. In v5, if a user explicitly specified the driver to
>
Modularizes the nfs block driver so that it gets dynamically loaded.
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
--- a/block/Makefile.objs
+++ b/b
nd
in module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Makefile | 3 ---
block.c | 62 +--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
util/module.c
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Mak
har *dirs[3];
> int i = 0;
> @@ -181,6 +184,9 @@ static void module_load(module_init_type type)
> case MODULE_INIT_BLOCK:
> mp = block_modules;
> break;
> +case MODULE_INIT_SDL:
> +mp = sdl_modules;
> + break;
> default:
> /* no other types have dynamic modules for now*/
> return;
> diff --git a/vl.c b/vl.c
> index a455947..fdbbe47 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4221,7 +4221,10 @@ int main(int argc, char **argv, char **envp)
> }
>
> if (display_type == DT_SDL) {
> -sdl_display_early_init(request_opengl);
> +if (!sdl_display_early_init(request_opengl)) {
> +error_report("Failed to initialize SDL");
> +exit(1);
> +}
> }
>
> if (request_opengl == 1 && display_opengl == 0) {
>
Maybe I'm doing something wrong, but when I apply this third patch
(along with the first two) to master it doesn't seem to build when
modules are enabled in the configuration:
LINK x86_64-softmmu/qemu-system-x86_64
../backends/baum.o: In function `chr_baum_init':
/home/bos/clord/Documents/qemu/backends/baum.c:616: undefined reference
to `SDL_GetWMInfo'
collect2: error: ld returned 1 exit status
Makefile:197: recipe for target 'qemu-system-x86_64' failed
make[1]: *** [qemu-system-x86_64] Error 1
Makefile:204: recipe for target 'subdir-x86_64-softmmu' failed
make: *** [subdir-x86_64-softmmu] Error 2
Colin
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
protocol block driver that links to external libraries that
has not been modularized (once my last patch set is applied).
Colin Lord (2):
blockdev: Remove unnecessary lines from Makefile
blockdev: Modularize nfs block driver
Makefile| 3 ---
block/Makefile.objs | 1 +
configure
Removes some superfluous lines from the Makefile which should have been
removed as part of the patch series to add dynamic loading for block
driver modules.
Signed-off-by: Colin Lord
---
Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Makefile b/Makefile
index 4b9384e..c7aa8cd
Updates the messages displayed in the help option to reflect that GTK is
the default display, not SDL.
---
qemu-options.hx | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 8e0d9a5..5bec1d3 100644
--- a/qemu-options.hx
+++
On 07/23/2016 02:21 PM, Max Reitz wrote:
> On 20.07.2016 16:30, Colin Lord wrote:
>> Here's v5 of the modularization series. Since it seems the concensus is
>> that modularizing the format drivers is unnecessary, this series no
>> longer modularizes those and is thu
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Mak
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (1):
blockdev: prepare iSCSI block driver for dynamic loading
Marc Mari (2):
blockdev: Add dy
a new structure found in
module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
block.c | 37 +++--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
util/module.c | 38 +++---
4 files ch
On 07/19/2016 06:54 AM, Paolo Bonzini wrote:
>
>
> On 14/07/2016 21:02, Colin Lord wrote:
>> Here's v4 of the modularization series. Things that have changed since
>> v3 include:
>>
>> - Fix indentation of the generated header file module_block.h
>&g
On 07/18/2016 12:28 PM, Max Reitz wrote:
> On 14.07.2016 21:03, Colin Lord wrote:
>> Modifies the bochs probe to return the format name as well as the
>> score as the final step of separating the probe function from the
>> driver. This keeps the probe completely inde
This puts the bdrv_probe_device functions into their own files to
facilitate the modularization of the block drivers.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/host_cdrom-probe.c | 40 +
block/host_device
This commit finalizes the separation of the BlockDriver from its
device probing function. Now the accesses to these functions in block.c
occur through the protocol_probes array, and each function returns a
score and protocol name with which to find the corresponding driver.
Signed-off-by: Colin
Completes the separation of the vdi probe from the vdi driver. The
vdi probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the qcow probe from the qcow driver. The
qcow probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the vmdk probe from the vmdk driver. The
vmdk probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the qed probe from the qed driver. The
qed probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the vpc probe from the vpc driver. The
vpc probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the cloop probe from the cloop driver. The
cloop probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Isolates vhdx probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vhdx-probe.c| 21 +
block/vhdx.c | 20 +---
include/block/probe.h | 1 +
4 files changed, 24
Isolates vpc probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vpc-probe.c | 9 +
block/vpc.c | 8 +---
include/block/probe.h | 1 +
4 files changed, 12 insertions(+), 8 deletions
Completes the separation of the qcow2 probe from the qcow2 driver. The
qcow2 probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Isolates vdi probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vdi-probe.c | 26 +++
block/vdi.c | 69 ++-
block/vdi.h
allows the score to be correlated to the
driver without the probe function needing to be part of the driver.
Signed-off-by: Colin Lord
---
block.c | 20
block/bochs-probe.c | 25 -
block/bochs.c | 1 -
include/block/probe.h | 3
Completes the separation of the parallels probe from the parallels
driver. The parallels probe now returns the format in addition to the
score, allowing correlation of the score and driver without the probe
function being part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max
This commit finalizes the separation of the block driver and probe
function by removing the .bdrv_probe field from all BlockDrivers.
Probing is now accomplished solely by iterating over the array of probe
function pointers in the format_probes array.
Signed-off-by: Colin Lord
Reviewed-by: Max
Isolates vmdk probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vmdk-probe.c| 60 +++
block/vmdk.c | 60
Completes the separation of the luks probe from the crypto driver. The
luks probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Isolate dmg probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/dmg-probe.c | 17 +
block/dmg.c | 16 +---
include/block/probe.h | 1 +
4 files changed, 20 insertions
Isolate raw probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/raw-probe.c | 10 ++
block/raw_bsd.c | 9 +
include/block/probe.h | 1 +
4 files changed, 13 insertions(+), 8 deletions
Isolates qcow probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qcow-probe.c| 16
block/qcow.c | 31 ++-
block/qcow.h | 21
1 - 100 of 196 matches
Mail list logo
