[PATCH] roms: re-remove execute bit from hppa-firmware*

2025-05-18 Thread Cole Robinson
This was fixed in c9d77526bddba0803a1fa982fb59ec98057150f9 for 9.2.0 but regressed in db34be329162cf6b06192703065e6c1010dbe3c5 in 10.0.0 When the bit is present, rpmbuild complains about missing ELF build-id Signed-off-by: Cole Robinson --- pc-bios/hppa-firmware.img | Bin pc-bios/hppa

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Cole Robinson
On 4/23/24 10:11 AM, Cole Robinson wrote: > Hi, > > hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF > build-id annotations. rpm builds on Fedora will error if an ELF binary > doesn't have build-id: > > RPM build errors: > Missing build-id

hppa-firmware.img missing build-id

2024-04-23 Thread Cole Robinson
Hi, hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF build-id annotations. rpm builds on Fedora will error if an ELF binary doesn't have build-id: RPM build errors: Missing build-id in /tmp/rpmbuild/BUILDROOT/qemu-9.0.0-1.rc2.fc41.x86_64/usr/share/qemu/hppa-firmware.img

Re: [Stable-8.2.3 00/87] Patch Round-up for stable 8.2.3, freeze on 2024-04-20

2024-04-16 Thread Cole Robinson
On 4/10/24 3:21 AM, Michael Tokarev wrote: > The following patches are queued for QEMU stable v8.2.3: > > https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 > > Patch freeze is 2024-04-20, and the release is planned for 2024-04-22: > > https://wiki.qemu.org/Planning/8.2 > > Please r

Re: [PATCH v2] pc-bios/optionrom: Fix pvh.img ld build failure on fedora rawhide

2024-04-06 Thread Cole Robinson
It doesn't appear this patch is neccessary to build on fedora rawhide anymore, qemu 9.0.0-rc2 is building fine there Thanks, Cole On 2/1/24 2:36 PM, Cole Robinson wrote: > binutils 2.39 shows some warnings when building pvh.img > > /usr/bin/ld: warning: pvh.o: missing .note.GNU

Re: [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02

2024-03-01 Thread Cole Robinson
On 2/28/24 3:35 PM, Michael Tokarev wrote: > The following patches are queued for QEMU stable v7.2.10: > > https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 > > Patch freeze is 2024-03-02, and the release is planned for > 2024-03-04: > > https://wiki.qemu.org/Planning/7.2 > > Please r

[PATCH v2] pc-bios/optionrom: Fix pvh.img ld build failure on fedora rawhide

2024-02-01 Thread Cole Robinson
with RWX permissions The latter of which is fatal on Fedora rawhide for some reason. This adds linker options to suppress the errors, if ld supports the new options. Signed-off-by: Cole Robinson --- v2: - Check if ld supports the options, they are fairly new. Uses the same `ld -v

Re: [PATCH] pc-bios/optionrom: Fix pvh.img ld build failure on fedora rawhide

2024-01-21 Thread Cole Robinson
On 1/3/24 10:44 AM, Gerd Hoffmann wrote: > On Wed, Jan 03, 2024 at 12:44:39PM +, Daniel P. Berrangé wrote: >> On Tue, Nov 28, 2023 at 09:36:47AM -0500, Cole Robinson wrote: >>> binutils 2.39 shows some warnings when building pvh.img >>> >>> /usr/bin/ld: war

Re: [Stable-7.2.8 00/24] Patch Round-up for stable 7.2.8, freeze on 2023-12-23

2023-12-13 Thread Cole Robinson
On 12/13/23 8:00 AM, Michael Tokarev wrote: > The following patches are queued for QEMU stable v7.2.8: > > https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 > > Patch freeze is 2023-12-23, and the release is planned for 2023-12-25: > > https://wiki.qemu.org/Planning/7.2 > > Please

[PATCH] pc-bios/optionrom: Fix pvh.img ld build failure on fedora rawhide

2023-11-28 Thread Cole Robinson
with RWX permissions The latter of which is fatal on Fedora rawhide for some reason. Add linker options to suppress the errors Signed-off-by: Cole Robinson --- pc-bios/optionrom/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/optionrom/Makefile b/pc-bios

Re: [PATCH] dbus-display: fix test race when initializing p2p connection

2022-06-11 Thread Cole Robinson
uation. > > (the bus connection doesn't need a fix, as the initialization is done > synchronously) > > Reported-by: Robinson, Cole > Signed-off-by: Marc-André Lureau > --- > ui/dbus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Fedora test build passed for me. Thanks Marc-André! Tested-by: Cole Robinson - Cole

Re: dbus-display-test is flakey

2022-06-08 Thread Cole Robinson
On 6/7/22 4:57 PM, Marc-André Lureau wrote: > Hi Cole, > > > On Sun, Jun 5, 2022 at 6:46 PM Cole Robinson wrote: >> >> Hi Marc-André, >> >> dbus-display-test seems flakey. I'm occasionally seeing: >> >> ▶ 692/746 >> ERROR:../tests/qtes

[PATCH] qemu-iotests: Discard stderr when probing devices

2022-06-05 Thread Cole Robinson
: Cole Robinson --- tests/qemu-iotests/common.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 165b54a61e..db757025cb 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -982,7

dbus-display-test is flakey

2022-06-05 Thread Cole Robinson
Hi Marc-André, dbus-display-test seems flakey. I'm occasionally seeing: ▶ 692/746 ERROR:../tests/qtest/dbus-display-test.c:68:test_dbus_display_vm: assertion failed (qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)) == "dbus-test"): (NULL == "dbus-test") ERROR Examples: fedora rawhide x

Re: adding 'official' way to dump SEV VMSA

2022-04-19 Thread Cole Robinson
On 4/14/22 4:25 AM, Dr. David Alan Gilbert wrote: > * Dov Murik (dovmu...@linux.ibm.com) wrote: >> Hi Cole, >> >> On 13/04/2022 16:36, Cole Robinson wrote: >>> Hi all, >>> >>> SEV-ES and SEV-SNP attestation require a copy of the initial VMSA to >

adding 'official' way to dump SEV VMSA

2022-04-13 Thread Cole Robinson
Hi all, SEV-ES and SEV-SNP attestation require a copy of the initial VMSA to validate the launch measurement. For developers dipping their toe into SEV-* work, the easiest way to get sample VMSA data for their machine is to grab it from a running VM. There's two techniques I've seen for that: pat

Re: [PATCH v3] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

2022-04-06 Thread Cole Robinson
On 2/28/22 4:39 AM, Dov Murik wrote: > > > On 28/02/2022 11:31, Daniel P. Berrangé wrote: >> On Mon, Feb 28, 2022 at 09:30:14AM +, Dov Murik wrote: >>> Add a new field 'cpu0-id' to the response of query-sev-capabilities QMP >>> command. The value of the field is the base64-encoded unique ID

[PATCH] tests: tcg: Fix PVH test with binutils 2.36+

2021-10-08 Thread Cole Robinson
the related comment. Signed-off-by: Cole Robinson --- tests/tcg/x86_64/system/kernel.ld | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/tcg/x86_64/system/kernel.ld b/tests/tcg/x86_64/system/kernel.ld index 49c12b04ae..ca5d6bd850 100644 --- a/tests/tcg/x86_64/system

Re: [PATCH v3 00/10] Atomic cleanup + clang-12 build fix

2021-07-18 Thread Cole Robinson
per.c | 19 +-- > target/ppc/mem_helper.c | 16 +-- > target/s390x/tcg/mem_helper.c | 19 +-- > tcg/tcg-op.c | 47 ++- > util/qsp.c| 4 +- > accel/tcg/atomic_common.c.inc | 107 +-- > 21 files changed, 321 insertion

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-15 Thread Cole Robinson
On 7/13/21 12:56 PM, Richard Henderson wrote: > On 7/13/21 8:18 AM, Cole Robinson wrote: >>>    https://bugs.llvm.org/show_bug.cgi?id=51076 > ... >> Richard can you clarify, do you think the errors are a clang bug as >> well, or strictly a qemu issue? If it's clang

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-13 Thread Cole Robinson
On 7/13/21 10:43 AM, Richard Henderson wrote: > On 7/12/21 5:37 PM, Richard Henderson wrote: >> On 7/12/21 2:30 PM, Cole Robinson wrote: >>> On 7/12/21 11:59 AM, Richard Henderson wrote: >>>> The first two patches are not strictly required, but they >>>

Re: [PATCH 0/4] Fixes for the --without-default-features configure switch

2021-07-13 Thread Cole Robinson
On 7/13/21 5:31 AM, Thomas Huth wrote: > Many features do not get properly disabled when the user runs the > configure script with --without-default-features. Let's fix that now. > > Thomas Huth (4): > configure: Fix --without-default-features propagation to meson > configure: Allow vnc to get

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-12 Thread Cole Robinson
On 7/12/21 11:59 AM, Richard Henderson wrote: > The first two patches are not strictly required, but they > were useful in tracking down the root problem here. > > I understand the logic behind the clang-12 warning, but I think > it's a clear mistake that it should be enabled by default for a > ta

Re: [PATCH] Move qemu.sasl to contrib/

2021-07-08 Thread Cole Robinson
On 7/8/21 3:18 PM, Peter Maydell wrote: > On Thu, 8 Jul 2021 at 20:14, Daniel P. Berrangé wrote: >> >> On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote: >>> It's not installed in any way, so seems like contrib/ material >> >> Not really. >

configure --without-default-features confusion

2021-07-08 Thread Cole Robinson
Hi all, I'm a bit confused about the intended scope of ./configure --without-default-features. When I try it here there's still lots of stuff enabled: $ ./configure --without-default-features ... VNC support : YES VNC SASL support : YES VNC JPEG suppor

[PATCH] contrib: add stub bridge.conf for qemu-bridge-helper

2021-07-08 Thread Cole Robinson
The comment comes from OpenSUSE's bridge.conf, with some minor tweaks Signed-off-by: Cole Robinson --- Or should this be installed? If so where in git should it live? contrib/bridge.conf | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 contrib/bridge.conf diff --

Re: [PATCH] contrib: add stub bridge.conf for qemu-bridge-helper

2021-07-08 Thread Cole Robinson
On 7/8/21 2:42 PM, Cole Robinson wrote: > The comment comes from OpenSUSE's bridge.conf, with some minor tweaks > > Signed-off-by: Cole Robinson > --- > Or should this be installed? If so where in git should it live? > > contrib/bridge.conf | 14 ++ >

[PATCH] Move qemu.sasl to contrib/

2021-07-08 Thread Cole Robinson
It's not installed in any way, so seems like contrib/ material Signed-off-by: Cole Robinson --- Or should this be installed to /etc/sasl2 ? MAINTAINERS| 2 +- qemu.sasl => contrib/qemu.sasl | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename qemu.sasl =&

[PATCH 3/4] contrib: qemu-guest-agent.service: Don't ignore failure

2021-07-08 Thread Cole Robinson
RHEL7+ and Fedora don't ignore errors, nor Arch. Debian and OpenSUSE do but I think that's because their service files are based on this / what Fedora used to ship. Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 +- 1 file changed, 1 insertion(+),

[PATCH 4/4] contrib: qemu-guest-agent.service: Use IgnoreOnIsolate=True

2021-07-08 Thread Cole Robinson
e expected behavior IMO. This has been in RHEL since 7.2ish timeframe: https://bugzilla.redhat.com/show_bug.cgi?id=1165176 Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/systemd/qemu-guest-agent.service b/contr

[PATCH 2/4] contrib: qemu-guest-agent.service: Add Documentation= link

2021-07-08 Thread Cole Robinson
OpenSUSE adds this to their service file Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service index 59f7ecb1b8..7e1c50577b 100644 --- a

[PATCH 0/4] contrib: qemu-guest-agent.service updates

2021-07-08 Thread Cole Robinson
This series extends qemu-guest-agent.service with some bits that distros are adding, mostly changes from RHEL that have bubbled up to Fedora. Cole Robinson (4): contrib: qemu-guest-agent.service: s/BindTo/BindsTo/g contrib: qemu-guest-agent.service: Add Documentation= link contrib: qemu

[PATCH 1/4] contrib: qemu-guest-agent.service: s/BindTo/BindsTo/g

2021-07-08 Thread Cole Robinson
BindsTo is the documented name for this option, added in systemd 187 released in July 2012 Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd

[PATCH] contrib: add udev qemu-guest-agent.rules

2021-07-08 Thread Cole Robinson
Fedora/RHEL and Debian have shipped an identical file for years. This pairs with contrib/systemd/qemu-guest-agent.service Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.rules | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 contrib/systemd/qemu-guest-agent.rules

clang build error on i686

2021-07-03 Thread Cole Robinson
Hi, I'm hitting build errors with clang on i686 userspace on x86_64 kernel. Affects both qemu 6.0.0 and qemu.git, tested with fedora clang-12.0.1~rc3-1.fc35.i686. Full build log from the 6.0.0 build: https://gist.githubusercontent.com/crobinso/7b1206044eac7326490b2adce829e861/raw/9dddef968051fd638

Re: [PATCH-for-6.0] net: tap: fix crash on hotplug

2021-04-22 Thread Cole Robinson
On 4/22/21 5:42 AM, Bin Meng wrote: > On Thu, Apr 22, 2021 at 5:36 PM Peter Maydell > wrote: >> >> On Thu, 22 Apr 2021 at 05:29, Bin Meng wrote: >>> >>> On Thu, Apr 22, 2021 at 12:36 AM Philippe Mathieu-Daudé >>> wrote: >>>> >>&

Re: [PATCH-for-6.0] net: tap: fix crash on hotplug

2021-04-21 Thread Cole Robinson
On 4/21/21 3:54 PM, Peter Maydell wrote: > On Wed, 21 Apr 2021 at 16:24, Cole Robinson wrote: >> >> Attempting to hotplug a tap nic with libvirt will crash qemu: >> >> $ sudo virsh attach-interface f32 network default >> error: Failed to attach interface >

[PATCH-for-6.0] net: tap: fix crash on hotplug

2021-04-21 Thread Cole Robinson
is not set. https://bugzilla.redhat.com/show_bug.cgi?id=1949786 Fixes: 969e50b61a2 Signed-off-by: Cole Robinson --- * Or should we skip padding if nc.peer is unset? I didn't dig into it * tap-win3.c and slirp.c may need a similar fix, but the slirp case didn't crash in a simple test. net/tap.c | 2 +-

Re: virtio-9p-test.c:300:v9fs_req_recv: assertion failed (hdr.id == id): (7 == 73)

2020-11-24 Thread Cole Robinson
>>> On Sat, 21 Nov 2020 17:03:14 -0500 >>> >>> Cole Robinson wrote: >>>> Hi, I'm consistently seeing this assertion running the qemu-5.2.0 test >>>> suite. rc0, rc1, rc2 have been consistently affected, it reproduces >>>> consist

virtio-9p-test.c:300:v9fs_req_recv: assertion failed (hdr.id == id): (7 == 73)

2020-11-21 Thread Cole Robinson
Hi, I'm consistently seeing this assertion running the qemu-5.2.0 test suite. rc0, rc1, rc2 have been consistently affected, it reproduces consistently in parts of Fedora's build system. Here's an example build log for rc2 x86 against Fedora 32 https://download.copr.fedorainfracloud.org/results/@

[PATCH] configure: Fix gio detection

2020-11-05 Thread Cole Robinson
Signed-off-by: Cole Robinson --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 2c3c69f118..bc06aa81e5 100755 --- a/configure +++ b/configure @@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then # with

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-17 Thread Cole Robinson
On 8/17/20 1:39 AM, Gerd Hoffmann wrote: > Hi, > >> FWIW I'm still hitting issues with qemu-5.1.0 GA but maybe it's >> unrelated to that specific fix. Issues reproduce on fedora 33+, not >> fedora 32. > >> +Failed to open module: >> /builddir/build/BUILD/qemu-5.1.0-rc3/build-dynamic/x86_64-soft

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-12 Thread Cole Robinson
On 7/29/20 8:50 AM, Stefan Hajnoczi wrote: > On Thu, Jul 16, 2020 at 05:10:26PM -0400, Cole Robinson wrote: >> I'm trying to build qemu 5.1.0-rc0 in Fedora. I'm hitting some issues. > > For anyone else reading this email thread, this was fixed in QEMU &

hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-07-16 Thread Cole Robinson
Hi Gerd, I'm trying to build qemu 5.1.0-rc0 in Fedora. I'm hitting some issues. Using this configure line: ./configure --prefix=/usr --libdir=/usr/lib64 --sysconfdir=/etc --localstatedir=/var --libexecdir=/usr/libexec --interp-prefix=/usr/qemu-%M --with-pkgversion=qemu-5.1.0-0.1.rc0.fc33 '--extr

Re: [PATCH 00/78] Patch Round-up for stable 4.2.1, freeze on 2020-06-22

2020-06-17 Thread Cole Robinson
; > Thanks! A few bug fixes we are carrying in Fedora 32: commit eca3a945234a5f0a499860dd11df64b5f1a2e0a5 Author: Cole Robinson Date: Wed Nov 13 16:09:35 2019 -0500 tests: fix modules-test 'duplicate test case' error commit 8deb8019d696c75e6ecaee7545026b62aba2f1bb Author: Da

Re: [PATCH for-5.0] aio-posix: fix test-aio /aio/event/wait with fdmon-io_uring

2020-04-02 Thread Cole Robinson
io.c:374:test_flush_event_notifier: assertion failed: > (aio_poll(ctx, false)) > > Reported-by: Cole Robinson > Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf >("aio-posix: add io_uring fd monitoring implementation") > Signed-off-by: Stefan Hajnoczi Fixes the crash for me, thanks! Tested-by: Cole Robinson - Cole

[PATCH] tests: fix modules-test 'duplicate test case' error

2019-11-13 Thread Cole Robinson
the name as well, so instead we get: /$arch/module/load/audio-sdl /$arch/module/load/ui-sdl Signed-off-by: Cole Robinson --- tests/modules-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/modules-test.c b/tests/modules-test.c index d1a6ace218..88217686e1 100644

Re: [PATCH] linux-user: remove host stime() syscall

2019-11-12 Thread Cole Robinson
t = 1573571460; > ret = stime(&t); > printf("ret %d\n", ret); > return 0; > } > > # date; ./stime; date > Tue Nov 12 14:18:32 UTC 2019 > ret 0 > Tue Nov 12 15:11:00 UTC

[Bug 1852115] [NEW] qemu --static user build fails with fedora rawhide glibc-2.30.9000

2019-11-11 Thread Cole Robinson
Public bug reported: Building qemu latest git 654efcb511d on fedora rawhide fails with this configure line: ./configure \ --static \ --disable-system \ --enable-linux-user \ --disable-werror \ --disable-tools \ --disable-capstone make fails with:

Re: [PATCH 00/55] Patch Round-up for stable 4.1.1, freeze on 2019-11-12

2019-11-11 Thread Cole Robinson
On 11/11/19 9:03 AM, Cole Robinson wrote: > On 11/5/19 3:51 PM, Michael Roth wrote: >> Hi everyone, >> >> The following new patches are queued for QEMU stable v4.1.1: >> >> https://github.com/mdroth/qemu/commits/stable-4.1-staging >> >> The

Re: [PATCH 00/55] Patch Round-up for stable 4.1.1, freeze on 2019-11-12

2019-11-11 Thread Cole Robinson
On 11/5/19 3:51 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v4.1.1: > > https://github.com/mdroth/qemu/commits/stable-4.1-staging > > The release is tentatively planned for 2019-11-14: > > https://wiki.qemu.org/Planning/4.1 > > Please not

[PATCH] vhost-user-gpu: Drop trailing json comma

2019-09-19 Thread Cole Robinson
Trailing comma is not valid json: $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq parse error: Expected another key-value pair at line 5, column 1 Signed-off-by: Cole Robinson --- contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC

2019-09-09 Thread Cole Robinson
similar to what is done for the arm 'virt' machine type and CONFIG_ACPI_PCI Signed-off-by: Cole Robinson --- default-configs/i386-softmmu.mak | 1 - hw/i386/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/i386-softmmu.m

[Qemu-devel] [Bug 1837909] [NEW] test-char fails if host has no network interfaces

2019-07-25 Thread Cole Robinson
Public bug reported: # ./tests/test-char # random seed: R02S8602535bf831a74bca571d8c416d8161 1..34 # Start of char tests ... ok 12 /char/websocket # Start of stdio tests # End of stdio tests # Start of socket tests # Start of server tests # Start of mainloop tests Unexpected error in inet_parse_c

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/36] Patch Round-up for stable 3.1.1, freeze on 2019-07-29

2019-07-24 Thread Cole Robinson
On 7/23/19 1:00 PM, Michael Roth wrote: > Hi everyone, > > > The following new patches are queued for QEMU stable v3.1.1: > > https://github.com/mdroth/qemu/commits/stable-3.1-staging > > The release

[Qemu-devel] [PATCH v2] hmp: delvm: use hmp_handle_error

2019-04-24 Thread Cole Robinson
This gives us the consistent 'Error:' prefix added in 66363e9a43f, which helps users like libvirt who still need to scrape hmp error messages to detect failure. Reviewed-by: Eric Blake Signed-off-by: Cole Robinson --- v2: Drop now redundant "Error while" string prefix

Re: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker

2019-04-12 Thread Cole Robinson
On 4/12/19 3:47 AM, Paolo Bonzini wrote: > On 10/04/19 20:26, Cole Robinson wrote: >> On 11/20/18 6:44 AM, Dr. David Alan Gilbert wrote: >>> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>>> Nested VMX does not support live migration yet. Add a blocker

Re: [Qemu-devel] [PATCH for-4.0?] hmp: delvm: use hmp_handle_error

2019-04-12 Thread Cole Robinson
On 4/12/19 10:55 AM, Eric Blake wrote: > On 4/12/19 7:21 AM, Kevin Wolf wrote: >> Am 10.04.2019 um 20:27 hat Eric Blake geschrieben: >>> On 4/10/19 1:03 PM, Cole Robinson wrote: >>>> This gives us the consistent 'Error:' prefix added in 66363e9a43f, >&

Re: [Qemu-devel] [PATCH for-4.0?] hmp: delvm: use hmp_handle_error

2019-04-10 Thread Cole Robinson
On 4/10/19 2:27 PM, Eric Blake wrote: > On 4/10/19 1:03 PM, Cole Robinson wrote: >> This gives us the consistent 'Error:' prefix added in 66363e9a43f, >> which helps users like libvirt who still need to scrape hmp error >> messages to detect failure. >

Re: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker

2019-04-10 Thread Cole Robinson
On 11/20/18 6:44 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Nested VMX does not support live migration yet. Add a blocker >> until that is worked out. >> >> Nested SVM only does not support it, but unfortunately it is >> enabled by default for -cpu host so

[Qemu-devel] [PATCH] hmp: delvm: use hmp_handle_error

2019-04-10 Thread Cole Robinson
This gives us the consistent 'Error:' prefix added in 66363e9a43f, which helps users like libvirt who still need to scrape hmp error messages to detect failure. Signed-off-by: Cole Robinson --- hmp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hmp.c b/h

[Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers

2019-04-09 Thread Cole Robinson
The only caller that checks the error code is looking for != 0, so returning false is incorrect. Fixes: 5aaac467938 "migration: savevm: consult migration blockers" Signed-off-by: Cole Robinson --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-02 Thread Cole Robinson
On 4/1/19 4:58 PM, Michael Roth wrote: > Hi everyone, > > > The following new patches are queued for QEMU stable v3.0.1: > > https://github.com/mdroth/qemu/commits/stable-3.0-staging > > The release

Re: [Qemu-devel] building rst docs with sphinx

2019-01-29 Thread Cole Robinson
On 1/28/19 9:18 PM, Stefan Hajnoczi wrote: On Thu, Jan 24, 2019 at 06:56:09PM +, Peter Maydell wrote: (1) configure: My thought is that we should just make sphinx-build a requirement for the existing --enable-docs switch (as texinfo and pod2man are currently). The disadvantage is that we won

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread Cole Robinson
On 11/19/2018 01:35 PM, Dr. David Alan Gilbert wrote: * baldu...@units.it (baldu...@units.it) wrote: hi thanks for taking the time to reply Dr. David Alan Gilbert writes: I suspect that this might be some problem on my side, as I couldn't find any similar report (apart some old (qemu-2.8.50)

Re: [Qemu-devel] [libvirt] [PATCH 3/3] cirrus: mark as deprecated

2018-10-26 Thread Cole Robinson
On 10/25/2018 09:37 PM, Daniel P. Berrangé wrote: On Thu, Oct 25, 2018 at 10:52:56AM +0200, Gerd Hoffmann wrote: While being at it deprecate cirrus too. Reason (short version): use stdvga instead. Verbose version: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful E

[Qemu-devel] [Bug 1133769] Re: qtest failures leave orphaned qemu processes hanging around

2018-09-25 Thread Cole Robinson
It appears this is fixed, I haven't seen it in a while ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1133769 Title: qtest failures lea

Re: [Qemu-devel] [PATCH sgabios] Makefile: Add HOSTCC

2018-07-03 Thread Cole Robinson
I probably should have added more context here... We carry this patch to sgabios in Fedora to enable cross compilation. It would be nice to get it into the qemu sgabios git repo so we don't have to track it downstream anymore Thanks, Cole On 03/25/2018 03:03 PM, Cole Robinson wrote: &

Re: [Qemu-devel] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-19 Thread Cole Robinson
On 06/18/2018 09:41 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.11.2: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The release is planned for 2018-06-22: > > https://wiki.qemu.org/Planning/2.11 > > Please respond

Re: [Qemu-devel] [PATCH 0/3] block: Remove deprecated -drive options

2018-06-13 Thread Cole Robinson
On 06/13/2018 08:34 AM, Kevin Wolf wrote: > We deprecated a bunch of -drive options in 2.10, so let's remove them > for 3.0. > > Kevin Wolf (3): > block: Remove deprecated -drive geometry options > block: Remove deprecated -drive option addr > block: Remove deprecated -drive option serial >

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Cole Robinson
On 04/17/2018 05:11 PM, Eduardo Habkost wrote: > On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: > [...] >> Reviving this... did any follow up changes happen? >> >> Marc-André patched virt-manager a few months back to enable -device >> vmcor

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Cole Robinson
On 10/20/2017 02:48 PM, Eduardo Habkost wrote: > On Sun, Oct 15, 2017 at 04:56:28AM +0300, Michael S. Tsirkin wrote: >> On Tue, Oct 10, 2017 at 03:01:10PM -0300, Eduardo Habkost wrote: >>> On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: On Tue, Oct 10, 2017 at 05:00:18PM +0

[Qemu-devel] [PATCH sgabios] Makefile: Add HOSTCC

2018-03-25 Thread Cole Robinson
From: Paolo Bonzini Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 970b0ff..c8cb92b 100644 --- a/Makefile +++ b/Makefile @@ -30,6 +30,7 @@ ASFLAGS += -DBUILD_USER="$(BUILD_USER)" LDSCRIPT := rom16.ld LDFLAGS := -T $(LDSCRIPT) -nostdlib

[Qemu-devel] [Bug 1738283] Re: 'Less than' (<), 'more than' (>), and 'pipe' (|) can't be typed via VNC

2018-02-28 Thread Cole Robinson
FYI this seems to be fixed with qemu.git master, I didn't track down the specific commit but there were several keymap related changes. so qemu 2.12 will be fixed ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel

[Qemu-devel] [PATCH v3] scripts/make-release: Don't archive .git files

2018-01-30 Thread Cole Robinson
As was last done in 379e21c25, we don't want .git files for submodules here, which we aren't presently doing for capstone and keycodemapdb. Rather than delete the offending files before archiving, ask tar to --exclude=.git Signed-off-by: Cole Robinson --- v2: Use armbru&#

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

2018-01-06 Thread Cole Robinson
On 12/19/2017 08:13 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> As was last done in 379e21c25, we want to remove .git files for >> submodules here, which we aren't presently doing for capstone and >> keycodemapdb. >> >> Rather than a

[Qemu-devel] [PATCH v2] scripts/make-release: Don't archive .git files

2018-01-06 Thread Cole Robinson
As was last done in 379e21c25, we don't want .git files for submodules here, which we aren't presently doing for capstone and keycodemapdb. Rather than delete the offending files before archiving, ask tar to --exclude=.git Signed-off-by: Cole Robinson --- v2: Use armbru&#

[Qemu-devel] [PATCH] scripts/make-release: More .git removal

2017-12-18 Thread Cole Robinson
As was last done in 379e21c25, we want to remove .git files for submodules here, which we aren't presently doing for capstone and keycodemapdb. Rather than a whitelist use 'find' to future proof this Signed-off-by: Cole Robinson --- scripts/make-release | 2 +- 1 file chang

Re: [Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window

2017-11-05 Thread Cole Robinson
On 11/02/2017 01:12 PM, Jindřich Makovička wrote: > This fixes the following case: > > 1) Ctrl-Alt-2 for console is pressed > 2) console pops up and gets focus > 3) console receives the Ctrl-Alt-2 keypress event > 4) console closes > 5) focus returns to the main window > 6) main window gets the ke

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-29 Thread Cole Robinson
On 08/28/2017 08:13 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.9.1: > > https://github.com/mdroth/qemu/commits/stable-2.9-staging > > The release is planned for 2017-09-07: > > http://wiki.qemu.org/Planning/2.9 > > Please respond here

Re: [Qemu-devel] slirp + ipxe + ipv6 dns issue

2017-03-27 Thread Cole Robinson
On 03/26/2017 02:39 PM, Samuel Thibault wrote: > Hello, > > Cole Robinson, on ven. 24 mars 2017 21:17:43 -0400, wrote: >> I bisected to this commit: >> >> slirp: Add RDNSS advertisement > > Mmm, I see. Could you try the attached patch to confirm that it fix

[Qemu-devel] slirp + ipxe + ipv6 dns issue

2017-03-24 Thread Cole Robinson
Hi Samuel, A Fedora user reported a regression for his ipxe setup (Jan, CCd). He has a public PXE server and config. You can see details about his config here: http://boot.salstar.sk/ipxe/ Reproducer: wget http://boot.salstar.sk/ipxe/ipxe.lkrn qemu-system-x86_64 -kernel ipxe.lkrn Non-workin

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2017-03-14 Thread Cole Robinson
On 11/16/2016 12:50 AM, Hervé Poussineau wrote: > Hi, > > Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : >> >> >> On 10/11/2016 06:56, Gonglei (Arei) wrote: >>> Any ideas about this fix? >> >> It seems sensible, but perhaps the field is even smaller. Let's CC >> Hervé and Aurelien as I don't have

Re: [Qemu-devel] [PATCH] egl-helpers: Change file licensing to LGPL2

2016-12-07 Thread Cole Robinson
On 12/07/2016 07:51 AM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > ui/egl-helpers.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c > index 79cee05..cd24568 100644 > --- a/ui/egl-helpers.c > +++ b/ui/egl-helpers.

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-04 Thread Cole Robinson
On 12/01/2016 06:26 AM, Stefan Hajnoczi wrote: > On Thu, Dec 1, 2016 at 11:25 AM, Stefan Hajnoczi wrote: >> On Thu, Dec 1, 2016 at 11:20 AM, Stefan Hajnoczi wrote: >>> On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange >>> wrote: Wayland always uses evdev as its input source, so QEMU

[Qemu-devel] [Bug 1615212] Re: SDL UI switching to monitor half-broken and scrolling broken

2016-08-23 Thread Cole Robinson
This is described a bit more here: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00946.html But basically it's a libsdl bug: https://bugzilla.libsdl.org/show_bug.cgi?id=3287 ** Bug watch added: bugzilla.libsdl.org/ #3287 http://bugzilla.libsdl.org/show_bug.cgi?id=3287 -- You

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/56] Patch Round-up for stable 2.6.1, freeze on 2016-08-12

2016-08-08 Thread Cole Robinson
://github.com/crobinso/qemu/tree/fedora-24 commit 4fd811a6bd0b8f24f4761fc281454494c336d310 Author: Cole Robinson Date: Fri May 6 14:03:05 2016 -0400 ui: gtk: fix crash when terminal inner-border is NULL commit 56f289f383a871e871f944c7226920b35794efe6 Author: Cole Robinson Date: Fri May 6 14:03:06 201

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-06-28 Thread Cole Robinson
This seems to be a minimal reproducer: qemu-system-aarch64 \ -machine virt-2.6,accel=tcg \ -nodefaults \ -no-user-config \ -nographic -monitor stdio \ -device virtio-scsi-device,id=scsi0 \ -device virtio-scsi-device,id=scsi1 \ -drive file=foo.img,format=raw,if=none,id=d0 \ -device

Re: [Qemu-devel] Question about a qemu Aarch64 error when adding several SCSI disks

2016-06-27 Thread Cole Robinson
On 06/27/2016 09:05 AM, Kevin Zhao wrote: > Hi Cole, > > On 24 June 2016 at 19:35, Cole Robinson wrote: > >> On 06/24/2016 12:58 AM, Kevin Zhao wrote: >>> Hi Peter, >>> Follow your advice, I have complied the Qemu v2.6. >>> stack@u202158:~$ k

Re: [Qemu-devel] Question about a qemu Aarch64 error when adding several SCSI disks

2016-06-24 Thread Cole Robinson
On 06/24/2016 12:58 AM, Kevin Zhao wrote: > Hi Peter, > Follow your advice, I have complied the Qemu v2.6. > stack@u202158:~$ kvm --version > QEMU emulator version 2.6.50 (v2.6.0-1280-g6f1d2d1-dirty), Copyright (c) > 2003-2008 Fabrice Bellard > With this newest version, I use virt-manager

Re: [Qemu-devel] [PATCH] sdl2: skip init without outputs

2016-06-02 Thread Cole Robinson
= 0; i < sdl2_num_outputs; i++) { > QemuConsole *con = qemu_console_lookup_by_index(i); > Tested-by: Cole Robinson Thanks, Cole

Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl

2016-06-01 Thread Cole Robinson
On 06/01/2016 02:38 AM, Gerd Hoffmann wrote: > On Di, 2016-05-31 at 16:56 -0400, Cole Robinson wrote: >> $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl >> Segmentation fault (core dumped) >> >> 0 0x559631af in sdl_display_init (ds=, >> full_scre

[Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl

2016-05-31 Thread Cole Robinson
$ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl Segmentation fault (core dumped) 0 0x559631af in sdl_display_init (ds=, full_screen=0, no_frame=) at ui/sdl2.c:822 1 0x556c8a9a in main (argc=, argv=, envp=) at vl.c:4527 Setting the window icon assumes there's always an S

[Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM

2016-05-26 Thread Cole Robinson
If you try to gic-version=host with TCG on a KVM aarch64 host, qemu segfaults, since host requires KVM APIs. Explicitly reject gic-version=host if KVM is not enabled https://bugzilla.redhat.com/show_bug.cgi?id=1339977 Signed-off-by: Cole Robinson --- hw/arm/virt.c | 6 +- 1 file changed, 5

Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-20 Thread Cole Robinson
On 05/20/2016 01:53 AM, Gerd Hoffmann wrote: > On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote: >> Give users a hint if their config is wrong. >> >> Signed-off-by: Cole Robinson >> --- >> If virgl support is built into qemu, virgl=on is the default, so this

[Qemu-devel] [PATCH 2/3] ui: spice: Exit if gl=on EGL init fails

2016-05-18 Thread Cole Robinson
The user explicitly requested spice GL, so if we know it isn't going to work we should exit Signed-off-by: Cole Robinson --- For example, trying to use spice GL with libvirt qemu:///system will fail here, since the the VM will lack permissions to access /dev/dir/renderD* ui/spice-core.

[Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-18 Thread Cole Robinson
Give users a hint if their config is wrong. Signed-off-by: Cole Robinson --- If virgl support is built into qemu, virgl=on is the default, so this could be noisy in cases where people don't even care about virgl. So I won't object if this is dropped. The message also pops up once via

[Qemu-devel] [PATCH 1/3] ui: egl: Replace fprintf with error_report

2016-05-18 Thread Cole Robinson
Signed-off-by: Cole Robinson --- ui/egl-helpers.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 558edfd..6555f5f 100644 --- a/ui/egl-helpers.c +++ b/ui/egl-helpers.c @@ -2,6 +2,7 @@ #include #include

[Qemu-devel] [PATCH 0/3] ui: improve feedback if gl setup fails

2016-05-18 Thread Cole Robinson
patch 1 is just a cleanup, patch 2-3 improves feedback for invalid gl configs (which would have saved me an hour of head scratching) Cole Robinson (3): ui: egl: Replace fprintf with error_report ui: spice: Exit if gl=on EGL init fails virtio-gpu: Warn if UI config will disable virgl hw

Re: [Qemu-devel] [PATCH] [untested] gtk: update grab code for gtk 3.20

2016-05-11 Thread Cole Robinson
t; --- > ui/gtk.c | 49 +++-- > 1 file changed, 43 insertions(+), 6 deletions(-) Reviewed-by: Cole Robinson Tested-by: Cole Robinson Thanks, Cole

  1   2   3   4   >