Re: [v2] hw: misc: edu: fix 2 off-by-one errors

2022-11-01 Thread Christopher Friedt
Hi Jiri, Peter, Are you able to review the more recent version of this change? Look for the subject "[PATCH v4 x/3] hw: misc: edu: ..." I believe I addressed all concerns. Cheers, C On Mon, Oct 17, 2022 at 12:36 PM Christopher Friedt wrote: > > On Mon, Oct 17, 2022 at 2:

Re: [v2] hw: misc: edu: fix 2 off-by-one errors

2022-10-17 Thread Christopher Friedt
On Mon, Oct 17, 2022 at 2:23 AM Jiri Slaby wrote: > On 15. 10. 22, 23:10, Chris Friedt wrote: > > From: Christopher Friedt > This should be split into two patches. This way, it's hard to review. I can do that :-) Thanks for the review

[PATCH v2] hw: misc: edu: fix 2 off-by-one errors

2022-01-08 Thread Christopher Friedt
x4-0x40fff)! The solution is to use non-inclusive ranges e.g. [begin,end). Signed-off-by: Christopher Friedt --- hw/misc/edu.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index e935c418d4..73e97a54e7 100644 --- a/hw

[PATCH] hw: misc: edu: fix 2 off-by-one errors

2022-01-08 Thread Christopher Friedt
x4-0x40fff)! The solution is to use non-inclusive ranges e.g. [begin,end). Signed-off-by: Christopher Friedt --- hw/misc/edu.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index e935c418d4..73e97a54e7 100644 --- a/hw

Re: [Qemu-devel] [PATCH] Fix ARM v7m gen_intermediate_code()

2018-08-26 Thread Christopher Friedt
In the end it was just incorrect alignment for my vector table

Re: [Qemu-devel] [PATCH] Fix ARM v7m gen_intermediate_code()

2018-08-23 Thread Christopher Friedt
On Thu, Aug 23, 2018 at 4:01 PM Christopher Friedt wrote: > On Thu., Aug. 23, 2018, 3:50 p.m. Christopher Friedt, > wrote: >> On Thu., Aug. 23, 2018, 2:20 p.m. Peter Maydell, >> wrote: >>> On 23 August 2018 at 17:36, Christopher Friedt >>> wrote: >&g

Re: [Qemu-devel] [PATCH] Fix ARM v7m gen_intermediate_code()

2018-08-23 Thread Christopher Friedt
On Thu., Aug. 23, 2018, 3:50 p.m. Christopher Friedt, wrote: > > > On Thu., Aug. 23, 2018, 2:20 p.m. Peter Maydell, > wrote: > >> On 23 August 2018 at 17:36, Christopher Friedt >> wrote: >> >> happen to have a copy on your lake, but the short answe

Re: [Qemu-devel] [PATCH] Fix ARM v7m gen_intermediate_code()

2018-08-23 Thread Christopher Friedt
On Thu., Aug. 23, 2018, 2:20 p.m. Peter Maydell, wrote: > On 23 August 2018 at 17:36, Christopher Friedt > wrote: > > Hi; thanks for your patch, but I don't think it is correct. > What it does is to make QEMU ignore the T bit in the xPSR. > The architecture says that wha

[Qemu-devel] [PATCH] Fix ARM v7m gen_intermediate_code()

2018-08-23 Thread Christopher Friedt
Hi list, I hope this message finds you well, as I'm currently on a lake in the middle of nowhere relying on my flaky cellular connection. Roaming sucks. In any case, I found a bug while trying to execute the "svc 0" instruction for cortex-m3. A UsageFault (EXCP_INVSTATE) is injected at target/arm

Re: [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

2016-05-03 Thread Christopher Friedt
On May 3, 2016 9:50 AM, "Christopher Friedt" wrote: > > On Tue, May 3, 2016 at 3:06 AM, Richard Henderson wrote: > > On 05/02/2016 03:10 PM, Christopher Friedt wrote: > >> > >> %.a: > >> +ifdef CONFIG_DARWIN > >> + $(call quiet-c

Re: [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

2016-05-03 Thread Christopher Friedt
On Tue, May 3, 2016 at 3:06 AM, Richard Henderson wrote: > On 05/02/2016 03:10 PM, Christopher Friedt wrote: >> >> %.a: >> +ifdef CONFIG_DARWIN >> + $(call quiet-command,rm -f $@ && libtool -static -o $@ $^," >> libtool$(TARGET_DIR)$@&qu

[Qemu-devel] [PATCH 2/2] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link

2016-05-02 Thread Christopher Friedt
link fails. That applies to Mac OS X, but possibly other BSD-based distros. Note: there is nothing specific to eventfd inside and event_notifier_init() also fails unconditionally if CONFIG_EVENTFD is not defined. Signed-off-by: Christopher Friedt --- util/event_notifier-posix.c | 2 -- 1 file

[Qemu-devel] [PATCH 1/2] Use libtool instead of ar to create static libraries on Darwin.

2016-05-02 Thread Christopher Friedt
S X El Capitan. Signed-off-by: Christopher Friedt --- rules.mak | 4 1 file changed, 4 insertions(+) diff --git a/rules.mak b/rules.mak index d1ff311..44421af 100644 --- a/rules.mak +++ b/rules.mak @@ -105,7 +105,11 @@ modules: $(call LINK,$(filter %.o %.a %.mo, $^)) %.a: +ifeq ($(shell uname),

Re: [Qemu-devel] [PATCH 2/2] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link

2016-05-02 Thread Christopher Friedt
On Mon, May 2, 2016 at 9:18 PM, Peter Maydell wrote: > On 3 May 2016 at 02:14, Christopher Friedt wrote: >> On Mon, May 2, 2016 at 9:01 PM, Peter Maydell >> wrote: >>> [ccing somebody else who ran into this, since I've figured out why.] >>> >>> On

[Qemu-devel] [PATCH 0/2] Resolve link errors on Mac OS X

2016-05-02 Thread Christopher Friedt
not (such as under Mac OS X). There is more information in each of the commits that follows. Please feel free to comment. Cheers, C Christopher Friedt (2): Use libtool instead of ar to create static libraries on Darwin. Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satis

Re: [Qemu-devel] [PATCH 2/2] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link

2016-05-02 Thread Christopher Friedt
On Mon, May 2, 2016 at 9:01 PM, Peter Maydell wrote: > [ccing somebody else who ran into this, since I've figured out why.] > > On 3 May 2016 at 01:47, Christopher Friedt wrote: >> The file ivshmem.c unconditionally references event_notifier_init_fd() >> in util/event

[Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

2016-05-02 Thread Christopher Friedt
S X El Capitan. Signed-off-by: Christopher Friedt --- rules.mak | 4 1 file changed, 4 insertions(+) diff --git a/rules.mak b/rules.mak index d1ff311..44421af 100644 --- a/rules.mak +++ b/rules.mak @@ -105,7 +105,11 @@ modules: $(call LINK,$(filter %.o %.a %.mo, $^)) %.a: +ifdef CONFIG_DARWI

Re: [Qemu-devel] [PATCH 1/2] Use libtool instead of ar to create static libraries on Darwin.

2016-05-02 Thread Christopher Friedt
On Mon, May 2, 2016 at 9:04 PM, Fam Zheng wrote: > Cc'ing Peter Maydell, who must have better ideas than me on building on Mac. > > On Mon, 05/02 20:47, Christopher Friedt wrote: >> >> Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails to build >>

Re: [Qemu-devel] [PATCH 1/2] Use libtool instead of ar to create static libraries on Darwin.

2016-05-02 Thread Christopher Friedt
On Mon, May 2, 2016 at 8:53 PM, Peter Maydell wrote: > On 3 May 2016 at 01:47, Christopher Friedt wrote: >> >> Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails >> to build for a few reasons. > > I guess this is a new-in-ElCapitan thing? I run Yosemite

[Qemu-devel] [PATCH 1/2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

2016-05-02 Thread Christopher Friedt
S X El Capitan. Signed-off-by: Christopher Friedt --- rules.mak | 4 1 file changed, 4 insertions(+) diff --git a/rules.mak b/rules.mak index d1ff311..44421af 100644 --- a/rules.mak +++ b/rules.mak @@ -105,7 +105,11 @@ modules: $(call LINK,$(filter %.o %.a %.mo, $^)) %.a: +ifeq ($(shell

[Qemu-devel] [PATCH 2/2] [RESENT-INLINE] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link

2016-05-02 Thread Christopher Friedt
fails. That applies to Mac OS X, but possibly other BSD-based distros. Note: there is nothing specific to eventfd inside and event_notifier_init() also fails unconditionally if CONFIG_EVENTFD is not defined. Signed-off-by: Christopher Friedt --- util/event_notifier-posix.c | 2 -- 1 file

[Qemu-devel] [PATCH 0/2][RESENT-INLINE] Resolve link errors on Mac OS X

2016-05-02 Thread Christopher Friedt
not (such as under Mac OS X). There is more information in each of the commits that follows. Please feel free to comment. Cheers, C Christopher Friedt (2): Use libtool instead of ar to create static libraries on Darwin. Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satis

[Qemu-devel] mac development? cannot step with gdb

2016-03-19 Thread Christopher Friedt
Hi list, I'm trying to implement some features in vmware_vga.c, so that I can use a more recent vgabios-vmware.bin. My environment is Mac El Capitan using clang and gdb. Perhaps using clang & gdb is my fatal flaw, but I'm just not accustomed to using lldb yet. Are there any others who primarily d

Re: [Qemu-devel] [PATCH v2 08/26] armv7m: rewrite NVIC

2015-12-19 Thread Christopher Friedt
On Sat, Dec 19, 2015 at 2:08 PM, Christopher Friedt wrote: > On Wed, Dec 2, 2015 at 7:18 PM, Michael Davidsaver > wrote: >> Expand the NVIC to fully support -M priorities and masking. > > Wow - this whole patch series is quite impressive. I was just about to > st

Re: [Qemu-devel] [PATCH v2 08/26] armv7m: rewrite NVIC

2015-12-19 Thread Christopher Friedt
On Wed, Dec 2, 2015 at 7:18 PM, Michael Davidsaver wrote: > Expand the NVIC to fully support -M priorities and masking. Wow - this whole patch series is quite impressive. I was just about to start doing a MemManage implementation when I saw this and some previous posts on the topic. Michael, I'v

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-15 Thread Christopher Friedt
Just to update everyone, there is a thread on gdb-patches here [1] that is awaiting consensus before a patch is submitted that we may pull into qemu. [1] https://goo.gl/FyUvQu

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-14 Thread Christopher Friedt
On Mon, Dec 14, 2015 at 10:56 AM, Alex Bennée wrote: > IIRC last time I played with this when adding aarch64 system registers > for debugging is the number is irrelevant to gdb, its all dependant on > what the stub sends. As long as the coprocessor get/set functions agree > on the order with the x

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-14 Thread Christopher Friedt
On Mon, Dec 14, 2015 at 8:16 AM, Christopher Friedt wrote: > On Mon, Dec 14, 2015 at 8:14 AM, Peter Maydell > wrote: >> Note that our XML files are from gdb itself, so you should start >> by checking whether gdb has a suitable Cortex-M xml file. > > They do indeed. Thank

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-14 Thread Christopher Friedt
On Mon, Dec 14, 2015 at 8:14 AM, Peter Maydell wrote: > Note that our XML files are from gdb itself, so you should start > by checking whether gdb has a suitable Cortex-M xml file. They do indeed. Thanks for the tip.

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-14 Thread Christopher Friedt
On Mon, Dec 14, 2015 at 3:31 AM, Peter Maydell wrote: > This patch seems to be creating a completely new method of > constructing the XML to send to gdb. Is it really not possible > to do this using the existing mechanisms we have for selecting > XML to send to gdb and handling the registers it im

[Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-13 Thread Christopher Friedt
* allow overriding the default xml descriptor with gdb_xml_descriptor() * read cortex-m registers using arm_cortexm_gdb_read_register() * write cortex-m registers using arm_cortexm_gdb_write_register() * correct the number of cortex-m core regs to 23 Signed-off-by: Christopher Friedt

[Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-13 Thread Christopher Friedt
msp0xbffef7fc 0xbffef7fc psp0x0 0x0 <_start> primask0x0 0 basepri0x0 0 faultmask 0x1 1 control0x0 0 The changes have been tested with other firmware images and also via Eclipse Mars. Christopher Friedt (1): qemu-sy

Re: [Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Christopher Friedt
Hi Peter, On Fri, Feb 1, 2013 at 1:01 PM, Peter Maydell wrote: > OSX generally works for me, with some caveats: > * current master doesn't compile because of a recent patch >related to ffsl; this should be fixed soon I hope. I'll have to check out master again. Currently I'm using 1.3.0, bu

Re: [Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Christopher Friedt
Actually, disabling assertions, qemu appears to enter an infinite loop where the above assertion fails. Boo. On Fri, Feb 1, 2013 at 7:14 AM, Christopher Friedt wrote: > Hi folks, > > I've been digging through a bunch of runtime errors in OS X. One of > them was an EXC_BAD

[Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Christopher Friedt
Hi folks, I've been digging through a bunch of runtime errors in OS X. One of them was an EXC_BAD_ACCESS (segfault) caused by some code in main-loop.c that accessed uninitialized stack variables. Please see the attached patch. The problem still exists in the master branch of the git repository. I

Re: [Qemu-devel] disk images & driver geometry

2007-08-31 Thread Christopher Friedt
Anthony Liguori wrote: I have no idea what you're talking about. QEMU doesn't care whether you use a physical disk or a file. It handles geometry the same way. Is there a concrete example that doesn't work that you think should? Yes, a simple example is running CentOS after a typical instal

Re: [Qemu-devel] disk images & driver geometry

2007-08-09 Thread Christopher Friedt
sorry, that subject should have read 'drive geometry' Christopher Friedt wrote: Hi everyone, has there been any work done in the last few months towards hard disk geometry, so that partition tables / mbr's in raw hard disk files can be stored for later use? That's som

[Qemu-devel] disk images & driver geometry

2007-08-09 Thread Christopher Friedt
Hi everyone, has there been any work done in the last few months towards hard disk geometry, so that partition tables / mbr's in raw hard disk files can be stored for later use? That's something that would be tremendously useful with the -hda option, so that one could use a file for a virtua

Re: [Qemu-devel] usb_host: only one interface supported

2007-06-25 Thread Christopher Friedt
I just applied the patch located in this thread: http://lists.gnu.org/archive/html/qemu-devel/2007-06/msg00331.html and it worked! Thanks Arnaud Christopher Friedt wrote: Hi everyone, I'm trying to plug in a usb device (Motorola L2 phone, with micro usb connector). When I try to a

[Qemu-devel] usb_host: only one interface supported

2007-06-25 Thread Christopher Friedt
Hi everyone, I'm trying to plug in a usb device (Motorola L2 phone, with micro usb connector). When I try to add it using the qemu console, usb_add host:22b8:4902 I get the response "usb_host: only one interface supported" in the standard output / error. What does this mean exactly? Is th

[Qemu-devel] root userid remapping? ... no UID / GID variables set in NFS root?

2007-05-31 Thread Christopher Friedt
Hi everyone, I've just gotten qemu emulating an arm system on my laptop, which I'm hoping to use for cross-compilation. I don't have a disk image to use (is there any way to create a disk image from a directory tree??), so I'm using NFS instead. The strange thing is, is that although I speci