[Qemu-devel] Kemari status?

2011-06-23 Thread Christian Brunner
Does anyone know what happened to kemari? Back in March it was on the list for a possible merge in qemu 0.15. In April the last update was sent to this list. After that everything remained silent. I think it's a really interesting project and I wonder why it isn't picked up. Thanks, Christian

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-27 Thread Christian Brunner
2011/5/27 Stefan Weil : > Am 23.05.2011 12:26, schrieb Kevin Wolf: >> >> Am 23.05.2011 11:01, schrieb Christian Brunner: >>> >>> 2011/5/22 Stefan Weil : >>>> >>>> Am 07.05.2011 22:15, schrieb Stefan Weil: >>>>> >>>>

Re: [Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate implementation

2011-05-25 Thread Christian Brunner
Looks good to me: Reviewed-by: Christian Brunner 2011/5/24 Josh Durgin : > Signed-off-by: Josh Durgin > --- >  block/rbd.c |   15 +++ >  1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index c9f32e4..015ae8e 10064

Re: [Qemu-devel] [PATCH v4 3/4] rbd: check return values when scheduling aio

2011-05-25 Thread Christian Brunner
We should not leave this out: Reviewed-by: Christian Brunner 2011/5/24 Josh Durgin : > If scheduling fails, the number of outstanding I/Os must be correct, > or there will be a hang when waiting for everything to be flushed. > > Reported-by: Stefan Hajnoczi > Signed-off-

Re: [Qemu-devel] [PATCH v4 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-25 Thread Christian Brunner
Looks good to me: Reviewed-by: Christian Brunner 2011/5/24 Josh Durgin : > The new format is > rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] > Each option is used to configure rados, and may be any Ceph option, or "conf". > The "conf" option spe

Re: [Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados

2011-05-25 Thread Christian Brunner
Apart from two cosmetic issues (see below), I think this patch is ready to replace the old rbd driver. You can add: Reviewed-by: Christian Brunner Regards Christian 2011/5/24 Josh Durgin : > librbd stacks on top of librados to provide access > to rbd images. > > Using librbd si

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-23 Thread Christian Brunner
2011/5/22 Stefan Weil : > Am 07.05.2011 22:15, schrieb Stefan Weil: >> >> cppcheck report: >> rbd.c:246: style: Variable 'snap' is assigned a value that is never used >> >> Remove snap and the related code. >> >> Cc: Christian

Re: [Qemu-devel] Help compiling QEMU with RBD support

2011-05-04 Thread Christian Brunner
I almost forgot: If you are already using ceph 0.27, then you will need the pathes. Configure is checking for a function that isn't existing any longer in librados. Sorry, Christian 2011/5/4 Christian Brunner : > Hi Dyweni, > > are you sure that you have installed ceph (especiall

Re: [Qemu-devel] Help compiling QEMU with RBD support

2011-05-04 Thread Christian Brunner
Hi Dyweni, are you sure that you have installed ceph (especially librados and the header files)? Josh's patches use the newer librbd from ceph 0.27. With this library the qemu driver gets a lot simpler and avoids code duplication in ceph and qemu. - It's the future, but I don't think it will solv

Re: [Qemu-devel] [PATCH] rbd: don't link with -lcrypto

2011-03-13 Thread Christian Brunner
You are right, libcrypto can be omitted. (Recent versions of ceph use crypto++ anyway.) Thanks, Christian Reviewed-by: Christian Brunner 2011/3/7 Aurelien Jarno : > rbd support tries to both link with -lrados and -lcrypto. While the > first one is of course necessary, the second

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-12-06 Thread Christian Brunner
2010/12/6 Kevin Wolf : Hi Kevin, > This lacks a Signed-off-by. Please merge Yehuda's fix for configure when > you resend the patch. I've sent an updated patch. > What's the easiest way to try it out? I tried to use vstart.sh and copy > the generated ceph.conf to /etc/ceph/ceph.conf so that qemu

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v9)

2010-12-06 Thread Christian Brunner
: Christian Brunner --- Makefile.objs |1 + block/rbd.c | 1059 + block/rbd_types.h | 71 configure | 52 +++ 4 files changed, 1183 insertions(+), 0 deletions(-) create mode 100644 block/rbd.c create mode 100644

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-26 Thread Christian Brunner
Thanks for the review. What am I supposed to do now? Christian 2010/11/18 Stefan Hajnoczi : > Reviewed-by: Stefan Hajnoczi > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at  http://vger.ke

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-17 Thread Christian Brunner
000..249a590 --- /dev/null +++ b/block/rbd.c @@ -0,0 +1,1059 @@ +/* + * QEMU Block driver for RADOS (Ceph) + * + * Copyright (C) 2010 Christian Brunner + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-11-15 Thread Christian Brunner
know librados a lot better than me. I pretty sure, that they will give some feedback about this remaining issue. After that we will send an updated patch. Regards, Christian 2010/11/11 Stefan Hajnoczi : > On Fri, Oct 15, 2010 at 8:54 PM, Christian Brunner wrote: >> [...] >&

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-10-15 Thread Christian Brunner
evice). Kind Regards, Christian Signed-off-by: Christian Brunner Signed-off-by: Yehuda Sadeh --- Makefile.objs |1 + block/rbd.c | 1059 + block/rbd_types.h | 71 configure | 31 ++ 4 files changed, 1162 insertions(

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v6)

2010-10-12 Thread Christian Brunner
. Thanks, Christian Signed-off-by: Christian Brunner Signed-off-by: Yehuda Sadeh --- Makefile.objs |1 + block/rbd.c | 982 + block/rbd_types.h | 71 configure | 31 ++ 4 files changed, 1085 insertions(+), 0

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-08-03 Thread Christian Brunner
ion is available on the Ceph-Wiki: http://ceph.newdream.net/wiki/Kvm-rbd The patch is based on git://repo.or.cz/qemu/kevin.git block Signed-off-by: Christian Brunner --- Makefile.objs |1 + block/rbd.c | 907 + block/rbd_types.h

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-08-02 Thread Christian Brunner
://repo.or.cz/qemu/kevin.git block Signed-off-by: Christian Brunner --- Makefile.objs |1 + block/rbd.c | 907 + block/rbd_types.h | 71 + configure | 31 ++ 4 files changed, 1010 insertions(+), 0 deletions(-) create

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-07-13 Thread Christian Brunner
that these large I/O requests only happen with qemu-io. I've never seen this happen inside a virtual machine. So do we really have to fix this, as it is only a warning message (laggy). Regards, Christian >From fcef3d897e0357b252a189ed59e43bfd5c24d229 Mon Sep 17 00:00:00 2001 From: Christia

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-06-19 Thread Christian Brunner
> > Are you going to send a final version which includes Simone's patch or > should I apply them as two patches and just accept that rbd is broken > after the first one? Or were there any other problems that need to be > solved first? I'll send a final version, when I've tested everything. There

[Qemu-devel] Re: [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-17 Thread Christian Brunner
c hack for the rbd driver and not a generic patch for protocol support. If you want, I can try to make it a bit more versatile. hristian >From 17031ac88d05b4796dc1f231317d843f26f1a331 Mon Sep 17 00:00:00 2001 From: Christian Brunner Date: Thu, 3 Jun 2010 21:05:24 +0200 Subject: [PATCH] a sm

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-06-17 Thread Christian Brunner
cb->bh); >     acb->bh = NULL; > + > +    uint64_t buf = 1; > +    write(acb->s->efd, &buf, sizeof(buf)); > + >     qemu_aio_release(acb); >  } > > @@ -473,6 +521,7 @@ static BlockDriverAIOCB > *rbd_aio_rw_vector(BlockDriverState *bs, >     acb->aiocnt = 0; &

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-06-02 Thread Christian Brunner
Hi Kevin, 2010/6/1 Kevin Wolf : > Do you have some specific tests for the driver or should we extend > qemu-iotests to work with protocols and use only that? Right now I don't have any specific tests, but I'll take a look at qemu-iotests soon. Christian

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-05-31 Thread Christian Brunner
iki: http://ceph.newdream.net/wiki/Kvm-rbd The patch is based on git://repo.or.cz/qemu/kevin.git block Signed-off-by: Christian Brunner --- Makefile.objs |1 + block/rbd.c | 600 + block/rbd_types.h | 64 ++ configure | 31 ++

Re: [Qemu-devel] [PATCH 1/1] ceph/rbd block driver for qemu-kvm (v2)

2010-05-28 Thread Christian Brunner
Hi Kevin, thanks for your review notes. Yehuda and I have already worked this into the git tree on the ceph site. I'll do some testing on Monday. After that I'll send an updated patch. Regards, Christian 2010/5/28 Kevin Wolf : > Am 27.05.2010 21:11, schrieb Christian Brunner:

[Qemu-devel] [PATCH 1/1] ceph/rbd block driver for qemu-kvm (v2)

2010-05-27 Thread Christian Brunner
rbd.c @@ -0,0 +1,584 @@ +/* + * QEMU Block driver for RADOS (Ceph) + * + * Copyright (C) 2010 Christian Brunner + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + */ + +#include "qemu-common.h" +#include +#inc

[Qemu-devel] [PATCH 0/1] ceph/rbd block driver for qemu-kvm (v2)

2010-05-27 Thread Christian Brunner
Hi, Based on the review notes Blue Swirl sent us after my last mail, Yehuda cleaned up the header files. The patch is much smaller now and I hope that you accept it for inclusion. To build it, you will need the testing (or unstable) git head of ceph now. The required header files will be part of

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-24 Thread Christian Brunner
2010/5/24 MORITA Kazutaka : >> However, I don't think nbd would be a good protocol.  My preference >> would be for a plugin API, or for a new local protocol that uses >> splice() to avoid copies. >> > > Both would be okay for Sheepdog.  I want to take a suitable approach > for qemu. I think both

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Christian Brunner
2010/5/20 Anthony Liguori : >> With new approaches like Sheepdog or Ceph, things are getting a lot >> cheaper and you can scale your system without disrupting your service. >> The concepts are quite similar to what Amazon is doing in their EC2 >> environment, but they certainly won't publish it as

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Christian Brunner
2010/5/20 Blue Swirl : > On Wed, May 19, 2010 at 7:22 PM, Christian Brunner wrote: >> The attached patch is a block driver for the distributed file system >> Ceph (http://ceph.newdream.net/). This driver uses librados (which >> is part of the Ceph server) for direct acce

[Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-19 Thread Christian Brunner
+ __le32 num_ops; + struct ceph_osd_op ops[0]; /* ops[], object */ +} __attribute__ ((packed)); + + +#endif diff --git a/block/rbd.c b/block/rbd.c new file mode 100644 index 000..eedae50 --- /dev/null +++ b/block/rbd.c @@ -0,0 +1,585 @@ +/* + * QEMU Block driver for RADOS (Ceph) + * +

[Qemu-devel] [RFC PATCH 0/1] ceph/rbd block driver for qemu-kvm

2010-05-19 Thread Christian Brunner
Hi, this patch is a block driver for the distributed file system Ceph (http://ceph.newdream.net/). Ceph was included in the Linux v2.6.34 kernel. However, this driver uses librados (which is part of the Ceph server) for direct access to the Ceph object store and is running entirely in userspace. T