Re: [Qemu-devel] [PATCH v5] target-tilegx: Support iret instruction and related special registers

2015-10-06 Thread Chris Metcalf
ser mode, or it will cause target SEGV (and the patch doesn't implement system mode). You correctly modified the change to raise SIGILL, so you should also update the commit message the same way. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH v3] target-tilegx: Support iret instruction and related special registers

2015-10-02 Thread Chris Metcalf
On 10/1/2015 10:26 PM, Richard Henderson wrote: On 10/02/2015 11:31 AM, Chris Metcalf wrote: It disables interrupts from being delivered. This means asynchronous interrupts get deferred until ICS is set back to zero, and synchronous interrupts (page fault, etc) cause a double-fault instead

Re: [Qemu-devel] [PATCH v3] target-tilegx: Support iret instruction and related special registers

2015-10-01 Thread Chris Metcalf
o do something like adjust the interrupt mask prior to returning. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-26 Thread Chris Metcalf
= 31, MM_BF_OPCODE_X0 = 7, -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

[Qemu-devel] [PATCH] tile: correct some typos in opcode type names

2015-08-26 Thread Chris Metcalf
These particular opcode names are not used in the kernel directly, so updating them just has the effect of making downstream consumers more like to end up using better names; this was reported from the qemu community. Reported-by: Richard Henderson Signed-off-by: Chris Metcalf --- arch/tile

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-07-08 Thread Chris Metcalf
rs to provide related pdf documents, if possible. I worked with our internal folks to get a few more tilegx hardware docs on the web site: http://www.ezchip.com/scm/docs/ -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-07-06 Thread Chris Metcalf
I will be posting more hardware documents on Wednesday when I'm back in the office. > On Jun 4, 2015, at 5:33 AM, Chen Gang wrote: > >> On 06/03/2015 11:47 PM, Richard Henderson wrote: >>> On 06/03/2015 05:34 AM, Peter Maydell wrote: >>> You must do something. You can't allow guest code (even

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-06-03 Thread Chris Metcalf
On 06/03/2015 11:19 AM, Peter Maydell wrote: On 3 June 2015 at 16:10, Chris Metcalf wrote: On 06/03/2015 08:47 AM, Chen Gang wrote: On 06/03/2015 08:34 PM, Peter Maydell wrote: You must do something. You can't allow guest code (even broken guest code) to make QEMU assert. You need to

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-06-03 Thread Chris Metcalf
n0/idn1 internally, and userspace applications can use udn0..udn3 after setting up a suitable hardwall with the kernel (see arch/tile/kernel/hardwall.c), but you almost certainly don't want to care about any of that. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-21 Thread Chris Metcalf
Congratulations! > On May 21, 2015, at 4:58 PM, Chen Gang wrote: > > > After fix additional 3 bugs (one for mnz, one for mz, one for v1cmpeqi), > at present, tilegx linux user can print "Hello World"! :-) > > I shall reconstruct/prepare the code and send patch v11 for review > within this mont

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Chris Metcalf
, it's just a way of describing the TILE-Gx chip series. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Chris Metcalf
t that's out of scope for this project. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-26 Thread Chris Metcalf
but yes, jal/jalr etc are not memory ops. There is only one memory op possible per bundle. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Chris Metcalf
read and review. Then later when you use them they are self-documenting. And if you are going to use opcode_tilegx.h anyway, you get the names "for free". -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Chris Metcalf
those names. This is helpful to people who are already familiar with the naming, and reduces the amount of code needed to review qemu in any case. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Chris Metcalf
of the rest of the code, and I only skimmed it quickly, but generally: good work getting as far as you have! -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chris Metcalf
fault from an illegal mfspr, etc) then no pipeline completes its action. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx

2015-02-20 Thread Chris Metcalf
On 2/19/2015 7:07 PM, Chen Gang S wrote: +#ifdef TARGET_NR_chown /* not on tilegx */ I would omit all these comments. The same will be true for arm64, microblaze, or any other kernel architecture submitted after the tile architecture went in. -- Chris Metcalf, EZChip Semiconductor http

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
PR related documents, too. Thanks. On 2/14/15 23:53, Chen Gang S wrote: On 2/14/15 13:47, Peter Maydell wrote: On 14 February 2015 at 03:37, Chris Metcalf wrote: I'm not sure whether Tilera can simply re-release the tilegx-specific stuff from binutils as a separate tarball with GPL v2 lic

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
t PC. You can issue a "lnk REG" instruction to load the address of the following register into register REG. And if you have interrupted the machine execution with an interrupt or fault, you will find the interrupted address in an SPR. But the current PC is not otherwise accessible. -- C

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
at Chen Gang is looking at is basically just an instruction recognizer; it doesn't even include text strings for opcodes, for example. But my guess is that it is exactly the right starting building block for decoding target binary instructions. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
/14/15 23:53, Chen Gang S wrote: On 2/14/15 13:47, Peter Maydell wrote: On 14 February 2015 at 03:37, Chris Metcalf wrote: I'm not sure whether Tilera can simply re-release the tilegx-specific stuff from binutils as a separate tarball with GPL v2 licensing. Hopefully we can avoid having

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-13 Thread Chris Metcalf
nd, there is disassembly code in the kernel that we released under the kernel's GPL v2; see arch/tile/kernel/tile-desc_64.c and the matching include file. So maybe there is enough there for you to use to implement the disassembly code. I'm not sure whether Tilera can simply re-release th

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chris Metcalf
he wild. >> > >> >Also, 191 is EM_TILEGX in , so you really should use the same name here, not EM_TILE. >> > Oh, I can not fine EM_TILEGX in "elf.h" in master branch. I guess, I need to define it, too. It is in glibc's /usr/include/elf.h since version 2.16. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chris Metcalf
is is against a much older version of qemu, though. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-11 Thread Chris Metcalf
tile uses that are just asm-generic versions. It probably makes sense to have a qemu framework for asm-generic as well. Tilera did some work on a qemu port only intended to be used with KVM for virtualization, so it probably doesn't do you much good. If you're interested, I can send you the diffs. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com

Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

2012-03-07 Thread Chris Metcalf
o concerned with how it's handled going forward, since I expect the 32-bit platform to become less popular over time. I'd vote for generic code cleanliness. -- Chris Metcalf, Tilera Corp. http://www.tilera.com