Re: [PATCH] vfio: Support P2P access in confidential VM

2025-01-16 Thread Cédric Le Goater
--- a/linux-headers/linux/vfio.h +++ b/linux-headers/linux/vfio.h @@ -1560,6 +1560,7 @@ struct vfio_iommu_type1_dma_map { #define VFIO_DMA_MAP_FLAG_READ (1 << 0) /* readable from device */ #define VFIO_DMA_MAP_FLAG_WRITE (1 << 1)/* writable from device */ #define VFIO_DMA_MAP

Re: [PATCH] vfio/iommufd: Fix SIGSEV in iommufd_cdev_attach()

2025-01-16 Thread Cédric Le Goater
On 1/16/25 11:23, Zhenzhong Duan wrote: When iommufd_cdev_ram_block_discard_disable() fails for whatever reason, errp should be set or else SIGSEV is triggered in vfio_realize() when error_prepend() is called. By this chance, use the same error message for both legacy and iommufd backend. Fixes

Re: [PATCH v2] Add a b4 configuration file

2025-01-16 Thread Cédric Le Goater
On 1/2/25 23:53, Jiaxun Yang wrote: b4 [1] is a convenient tool to manage patch series with mailing list working flow. Add a project default config file to match QEMU's mailing list conventions as well as adopting differences on scripting. Examples of b4: ``` $ b4 prep --check Checking patches

Re: [PATCH] vfio/igd: Fix potential overflow in igd_gtt_memory_size()

2025-01-16 Thread Cédric Le Goater
On 1/7/25 14:06, Cédric Le Goater wrote: The risk is mainly theoretical since the applied bit mask will keep the 'ggms' shift value below 3. Nevertheless, let's use a 64 bit integer type and resolve the coverity issue. Resolves: Coverity CID 1585908 Fixes: 1e1eac5f3dcd ("vf

Re: [PATCH v2 0/3] vfio/igd: VFIOConfigMirrorQuirk for igd mirrored registers

2025-01-16 Thread Cédric Le Goater
On 1/4/25 16:42, Tomita Moeko wrote: In commit 1a2623b5c9e7 ("vfio/igd: add macro for declaring mirrored registers"), I introduced a macro to handle mirrored registers in igd bar0. However, using the existing VFIOConfigMirrorQuirk should be a better approach I think after going through the vfio c

Re: [PATCH 3/9] ppc/ppc405: Remove CPU

2025-01-13 Thread Cédric Le Goater
On 1/14/25 08:11, Nicholas Piggin wrote: On Sat Jan 11, 2025 at 2:25 AM AEST, Richard Henderson wrote: On 1/10/25 08:15, Philippe Mathieu-Daudé wrote: Hi Cédric, Cc'ing Laurent & Richard for user emulation. ... The deprecation message (see previous patch) was about the "ppc ``ref405ep`` mac

Re: [PATCH 7/9] ppc/ppc405: Remove cache handling instructions

2025-01-10 Thread Cédric Le Goater
On 1/10/25 17:09, Philippe Mathieu-Daudé wrote: On 10/1/25 15:17, Cédric Le Goater wrote: Since the 405 CPU family was phased out, these instructions have no users anymore. Signed-off-by: Cédric Le Goater ---   target/ppc/cpu.h   |  6 +-   target/ppc/translate.c | 11 ---   2

[PATCH 5/9] ppc/ppc405: Remove 40x exception model

2025-01-10 Thread Cédric Le Goater
This exception model was only used by the 405 CPU family which was removed. The rest of the PPC 4xx CPUs use the BookE exception model. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h | 8 +-- target/ppc/helper.h | 1 - target/ppc/cpu_init.c| 11 target/ppc

[PATCH 6/9] ppc/ppc405: Remove timer support

2025-01-10 Thread Cédric Le Goater
Since the 405 CPU family was phased out, these timer models have no users anymore. Signed-off-by: Cédric Le Goater --- include/hw/ppc/ppc.h | 15 --- target/ppc/cpu.h | 7 - target/ppc/helper.h | 4 - target/ppc/spr_common.h | 4 - hw/ppc/ppc.c

[PATCH 9/9] ppc/ppc405: Remove POWERPC_MMU_SOFT_4xx MMU model

2025-01-10 Thread Cédric Le Goater
Since the 405 CPU family was phased out, this MMU model has no users anymore. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h | 6 target/ppc/mmu-booke.h | 3 -- target/ppc/excp_helper.c | 3 -- target/ppc/mmu-booke.c | 63 --- target/ppc

[PATCH 4/9] ppc/ppc405: Remove storage control (SLER) SPR

2025-01-10 Thread Cédric Le Goater
Since the 405 CPU family was phased out, the SLER SPR has no users anymore. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h | 2 -- target/ppc/helper.h | 1 - target/ppc/spr_common.h | 1 - target/ppc/helper_regs.c | 10 -- target/ppc/misc_helper.c | 5

[PATCH 8/9] ppc/ppc405: Remove TLB instructions

2025-01-10 Thread Cédric Le Goater
Since the 405 CPU family was phased out, these instructions have no users anymore. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h| 4 +- target/ppc/helper.h | 1 - target/ppc/spr_common.h | 1 - target/ppc/mmu_helper.c | 2 +- target/ppc/translate.c | 81

[PATCH 2/9] ppc/ppc405: Remove boards

2025-01-10 Thread Cédric Le Goater
The ref405ep machine is the only PPC 405 machine. Drop all support by removing the SoC and associated devices as-well as the machine. Signed-off-by: Cédric Le Goater --- MAINTAINERS |6 - docs/about/deprecated.rst |8 - docs/about/removed-features.rst |7

[PATCH 1/9] ppc/ppc405: Remove tests

2025-01-10 Thread Cédric Le Goater
Since we are about to remove all support for PPC 405, start by removing the tests referring to the ref405ep machine. Signed-off-by: Cédric Le Goater --- tests/qtest/m48t59-test.c| 5 - tests/functional/meson.build | 1 - tests/functional/test_ppc_405.py | 37

[PATCH 0/9] ppc: Remove 405 CPU family

2025-01-10 Thread Cédric Le Goater
models. Thanks, C. Cédric Le Goater (9): ppc/ppc405: Remove tests ppc/ppc405: Remove boards ppc/ppc405: Remove CPU ppc/ppc405: Remove storage control (SLER) SPR ppc/ppc405: Remove 40x exception model ppc/ppc405: Remove timer support ppc/ppc405: Remove cache handling instructions

[PATCH 3/9] ppc/ppc405: Remove CPU

2025-01-10 Thread Cédric Le Goater
Remove the 405 CPU family and all SPR definitions that don't have specific read/write handlers. Signed-off-by: Cédric Le Goater --- target/ppc/cpu-models.h | 30 - target/ppc/cpu.h| 9 -- target/ppc/cpu-models.c | 57 -- target/ppc/cpu_init.c

[PATCH 7/9] ppc/ppc405: Remove cache handling instructions

2025-01-10 Thread Cédric Le Goater
Since the 405 CPU family was phased out, these instructions have no users anymore. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h | 6 +- target/ppc/translate.c | 11 --- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h

Re: [PATCH] hw/sd/sdcard: Remove sd_set_cb()

2025-01-09 Thread Cédric Le Goater
On 1/9/25 11:22, Bernhard Beschow wrote: Am 8. Januar 2025 10:43:07 UTC schrieb "Philippe Mathieu-Daudé" : On 8/1/25 11:02, Cédric Le Goater wrote: Last user of sd_set_cb() was removed in commit ce5dd27534b0 ("hw/sd: Remove omap2_mmc device"). https://lore.k

Re: [PATCH v1 1/3] hw/timer/aspeed: Support different memory region ops

2025-01-08 Thread Cédric Le Goater
On 1/9/25 03:26, Jamin Lin wrote: Hi Andrew, From: Andrew Jeffery Sent: Thursday, January 9, 2025 9:59 AM To: Jamin Lin ; Cédric Le Goater ; Peter Maydell ; Steven Lee ; Troy Lee ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee ; Yunlin Tang Subject: Re

Re: [PATCH] hw/sd/sdcard: Remove sd_set_cb()

2025-01-08 Thread Cédric Le Goater
On 1/8/25 11:43, Philippe Mathieu-Daudé wrote: On 8/1/25 11:02, Cédric Le Goater wrote: Last user of sd_set_cb() was removed in commit ce5dd27534b0 ("hw/sd: Remove omap2_mmc device"). https://lore.kernel.org/qemu-devel/20240903200446.25921-2-phi...@linaro.org/ ;) Ah ! good. I was

[PATCH] hw/sd/sdcard: Remove sd_set_cb()

2025-01-08 Thread Cédric Le Goater
Last user of sd_set_cb() was removed in commit ce5dd27534b0 ("hw/sd: Remove omap2_mmc device"). Signed-off-by: Cédric Le Goater --- include/hw/sd/sdcard_legacy.h | 1 - hw/sd/sd.c| 8 2 files changed, 9 deletions(-) diff --git a/include/hw/sd/sdcard_

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-08 Thread Cédric Le Goater
On 1/7/25 23:36, Peter Maydell wrote: On Tue, 7 Jan 2025 at 17:55, Cédric Le Goater wrote: Hello, I would not recommend using qemu_irq_invert() in new code. I guess in an ideal world we'd implement a QOM object that encapsulated the the "not gate" logic, similar to TYPE_OR_I

Re: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-01-07 Thread Cédric Le Goater
On 1/7/25 19:43, Rorie Reyes wrote: Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak

Re: [PATCH v1 1/5] linux-headers: NOTFORMERGE - placeholder uapi updates for AP config change

2025-01-07 Thread Cédric Le Goater
Hello Rorie, On 1/7/25 19:43, Rorie Reyes wrote: This patch adds enumeration constant VFIO_AP_CFG_CHG_IRQ_INDEX to specify an IRQ index for signaling that a change has been made to the guest's AP configuration. This is a placeholder for QEMU patches that use this value since it is a linux-header

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-07 Thread Cédric Le Goater
On 11/27/24 12:23, Philippe Mathieu-Daudé wrote: On 27/11/24 10:44, Cédric Le Goater wrote: On 11/14/24 10:48, Jamin Lin wrote: change from v1: 1. Support RTC for AST2700. 2. Support SDHCI write protected pin inverted for AST2500 and AST2600. 3. Introduce Capabilities Register 2 for SD slot 0

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-07 Thread Cédric Le Goater
Hello, I would not recommend using qemu_irq_invert() in new code. I guess in an ideal world we'd implement a QOM object that encapsulated the the "not gate" logic, similar to TYPE_OR_IRQ. (Though for TYPE_OR_IRQ we made the mistake of making it inherit from TYPE_DEVICE, not TYPE_SYSBUS_DEVICE,

Re: [PATCH 0/5] Introduce AST27x0 multi-SoC machine

2025-01-07 Thread Cédric Le Goater
Steven, When you resend, could you please rebase on top of : https://lore.kernel.org/qemu-devel/20241216075353.1308043-1-jamin_...@aspeedtech.com/ Thanks, C. On 12/25/24 03:03, Steven Lee wrote: This patch series introduces full cores support for the AST27x0 SoC, along with necessary upda

[PATCH] vfio/igd: Fix potential overflow in igd_gtt_memory_size()

2025-01-07 Thread Cédric Le Goater
ions") Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 0740a5dd8cc9346a92c4613194faa8dea42e1d98..b5303ea565d6a344d0a43273f288bbb4a7f48327 100644 --- a/hw/vfio/igd.c +++ b/hw/vfio/igd.c @

Re: [PATCH 0/9] ppc/pnv: HOMER and OCC fixes and improvements

2025-01-06 Thread Cédric Le Goater
Hello, On 12/10/24 04:04, Nicholas Piggin wrote: This series makes a bunch of fixes and improvements to the HOMER and OCC unit models for powernv. It gets OPAL OCC code happier again, Nice. I had similar changes exposing pstates and sensors for QEMU. I am glad this is now possible. but requi

Re: [PATCH 3/5] aspeed: Introduce AST27x0 SoC with Cortex-M4 support

2025-01-03 Thread Cédric Le Goater
Hello Steven, [ ... ] +struct Aspeed27x0CM4SoCState { +AspeedSoCState parent; + +ARMv7MState armv7m; Why not use Aspeed10x0SoCState instead ? The AST2700's CM4 is not part of the AST10x0 series SoC. ok. These are different HW designs. However, since the structure is identical, I

Re: [PATCH 2/5] aspeed: ast27x0: Map unimplemented devices in SoC memory

2025-01-03 Thread Cédric Le Goater
On 1/3/25 10:57, Steven Lee wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Sent: Friday, January 3, 2025 5:44 PM To: Steven Lee ; Peter Maydell ; Troy Lee ; Jamin Lin ; Andrew Jeffery ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee

Re: [PATCH 2/5] aspeed: ast27x0: Map unimplemented devices in SoC memory

2025-01-03 Thread Cédric Le Goater
On 1/3/25 09:14, Steven Lee wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Sent: Friday, December 27, 2024 5:53 PM To: Steven Lee ; Peter Maydell ; Troy Lee ; Jamin Lin ; Andrew Jeffery ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee

Re: [PATCH 5/5] docs: aspeed: Add ast2700-fc machine section

2025-01-02 Thread Cédric Le Goater
On 12/25/24 03:03, Steven Lee wrote: This commit adds a section describing the ast2700-fc multi-SoC machine. Signed-off-by: Steven Lee --- docs/system/arm/aspeed.rst | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/docs/system/arm/as

Re: [PATCH 4/5] aspeed: Introduce ast2700-fc machine

2025-01-02 Thread Cédric Le Goater
On 12/25/24 03:03, Steven Lee wrote: This patch introduces a new machine, ast2700-fc, which supports all cores available in the AST27x0 SoC. In this machine - The first 4 cores are Cortex-A35 cores. - CPU 4 is designated as the SSP core. - CPU 5 is designated as the TSP core. Test Step: wge

Re: [PATCH 3/5] aspeed: Introduce AST27x0 SoC with Cortex-M4 support

2025-01-02 Thread Cédric Le Goater
Hello Steven, On 12/25/24 03:03, Steven Lee wrote: This initial module adds support for the AST27x0 SoC, which features four Cortex-A35 cores and two Cortex-M4 cores. The patch enables emulation of the Cortex-M4 cores, laying the groundwork for co-processor support. These changes introduce imp

Re: [PATCH 2/5] aspeed: ast27x0: Map unimplemented devices in SoC memory

2024-12-27 Thread Cédric Le Goater
Hello, On 12/25/24 03:03, Steven Lee wrote: Maps following unimplemented devices in SoC memory - dpmcu - iomem0 - iomem1 - ltpi - io Could you please add a sentence about what these devices are ? Thanks, C. Signed-off-by: Steven Lee --- hw/arm/aspeed_ast27x0.c | 45

Re: [PATCH 1/5] aspeed: Make sdhci_attach_drive and write_boot_rom public

2024-12-27 Thread Cédric Le Goater
On 12/25/24 03:03, Steven Lee wrote: sdhci_attach_drive and write_boot_rom functions may be used by the aspeed machine supporting co-processors. I would move these routines to aspeed_soc_common.c file and rename them with an aspeed_ prefix. Thanks, C. Signed-off-by: Steven Lee --- hw/

[PULL v2 00/17] vfio queue

2024-12-26 Thread Cédric Le Goater
The following changes since commit a7f77545d401266a6415e6e03c7738c95314f0e6: Merge tag 'pull-tcg-20241224' of https://gitlab.com/rth7680/qemu into staging (2024-12-25 08:33:33 -0500) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-vfio-20241226 for you t

Re: [PULL 00/17] vfio queue

2024-12-25 Thread Cédric Le Goater
Hello Stefan, On 12/25/24 14:31, Stefan Hajnoczi wrote: Hi Cédric, Please take a look at the following 32-bit CI failure: Drat. I didn't check 32-bit ... Sorry about that. I will resend. Thanks, C.

[PULL 09/17] vfio/igd: emulate BDSM in mmio bar0 for gen 6-10 devices

2024-12-24 Thread Cédric Le Goater
/20240202224340.30647-7-ville.syrj...@linux.intel.com Reviewed-by: Corvin Köhne Signed-off-by: Tomita Moeko Reviewed-by: Alex Williamson Link: https://lore.kernel.org/r/20241206122749.9893-10-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 26 ++ 1 file

[PULL 10/17] vfio/igd: add x-igd-gms option back to set DSM region size for guest

2024-12-24 Thread Cédric Le Goater
https://lore.kernel.org/r/20241206122749.9893-11-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 73c06bbf64d85b8dbf1575dac34ef8b7e64a3490..b0fef90240ca6dcc0ead7ed536202d61

[PULL 16/17] migration: Drop migration_is_device()

2024-12-24 Thread Cédric Le Goater
From: Avihai Horon After being removed from VFIO, migration_is_device() no longer has any users. Drop it. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater Acked-by: Peter Xu Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-7-avih...@nvidia.com Signed-off

[PULL 12/17] vfio/migration: Refactor vfio_devices_all_dirty_tracking() logic

2024-12-24 Thread Cédric Le Goater
ct dirty tracking status, add a comment that states how it's protected. Signed-off-by: Avihai Horon Reviewed-by: Joao Martins Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-3-avih...@nvidia.com Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-common.

[PULL 03/17] vfio/igd: align generation with i915 kernel driver

2024-12-24 Thread Cédric Le Goater
multiple of 2 starting from gen 8. Reviewed-by: Corvin Köhne Signed-off-by: Tomita Moeko Reviewed-by: Alex Williamson Link: https://lore.kernel.org/r/20241206122749.9893-4-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 45 +++-- 1

[PULL 17/17] migration: Unexport migration_is_active()

2024-12-24 Thread Cédric Le Goater
ed-by: Cédric Le Goater Acked-by: Peter Xu Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-8-avih...@nvidia.com Signed-off-by: Cédric Le Goater --- include/migration/misc.h | 1 - migration/migration.c| 16 2 files changed, 8 insertions(+), 9 dele

[PULL 08/17] vfio/igd: emulate GGC register in mmio bar0

2024-12-24 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 18d159aa8ecde3bb384dd6d3bd90e2110434335b..12e0553e830aab31980586ebf572070186ac38ad 100644 --- a/hw/vfio/igd.c +++ b/hw/vfio

[PULL 06/17] vfio/igd: add Alder/Raptor/Rocket/Ice/Jasper Lake device ids

2024-12-24 Thread Cédric Le Goater
AlderLake-S GT1 (8086:4680). Reviewed-by: Corvin Köhne Signed-off-by: Tomita Moeko Reviewed-by: Alex Williamson Link: https://lore.kernel.org/r/20241206122749.9893-7-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 5 + 1 file changed, 5 insertions(+) diff --git a

[PULL 13/17] vfio/migration: Refactor vfio_devices_all_running_and_mig_active() logic

2024-12-24 Thread Cédric Le Goater
y_tracking(). Signed-off-by: Avihai Horon Reviewed-by: Joao Martins Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-4-avih...@nvidia.com Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 4 ++-- hw/vfio/common.c

[PULL 07/17] vfio/igd: add macro for declaring mirrored registers

2024-12-24 Thread Cédric Le Goater
Reviewed-by: Alex Williamson Link: https://lore.kernel.org/r/20241206122749.9893-8-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 60 ++- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/hw/vfio/igd.c b/hw/vfio

[PULL 05/17] vfio/igd: add Gemini Lake and Comet Lake device ids

2024-12-24 Thread Cédric Le Goater
by: Corvin Köhne Signed-off-by: Tomita Moeko Reviewed-by: Alex Williamson Link: https://lore.kernel.org/r/20241206122749.9893-6-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/igd.c b/hw/vfio/i

[PULL 14/17] vfio/migration: Rename vfio_devices_all_dirty_tracking()

2024-12-24 Thread Cédric Le Goater
accurately and makes the code clearer as there are already several helpers with similar names. Signed-off-by: Avihai Horon Reviewed-by: Joao Martins Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-5-avih...@nvidia.com Signed-off-by: Cédric Le Goater --- hw/vfio

[PULL 15/17] system/dirtylimit: Don't use migration_is_active()

2024-12-24 Thread Cédric Le Goater
-avih...@nvidia.com Signed-off-by: Cédric Le Goater --- system/dirtylimit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/system/dirtylimit.c b/system/dirtylimit.c index d94b994bd81bd44b95f120a53ce83b6809e60297..7c071248bbf92389977dab8b7d4808c9f57af630 100644 --- a/system

[PULL 04/17] vfio/igd: canonicalize memory size calculations

2024-12-24 Thread Cédric Le Goater
Williamson Link: https://lore.kernel.org/r/20241206122749.9893-5-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 101 -- 1 file changed, 57 insertions(+), 44 deletions(-) diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index

[PULL 11/17] vfio/container: Add dirty tracking started flag

2024-12-24 Thread Cédric Le Goater
Martins Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-2-avih...@nvidia.com Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 1 + hw/vfio/container-base.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff

[PULL 02/17] vfio/igd: remove unsupported device ids

2024-12-24 Thread Cédric Le Goater
ned-off-by: Tomita Moeko Link: https://lore.kernel.org/r/20241206122749.9893-3-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 73ed1ec8e6af60ed58fe6546f750d0

[PULL 01/17] vfio/igd: fix GTT stolen memory size calculation for gen 8+

2024-12-24 Thread Cédric Le Goater
: c4c45e943e51 ("vfio/pci: Intel graphics legacy mode assignment") Reported-By: Alex Williamson Signed-off-by: Tomita Moeko Reviewed-by: Alex Williamson Link: https://lore.kernel.org/r/20241206122749.9893-2-tomitamo...@gmail.com Signed-off-by: Cédric Le Goater --- hw/vfio/igd.c | 4 ++

[PULL 00/17] vfio queue

2024-12-24 Thread Cédric Le Goater
The following changes since commit aa3a285b5bc56a4208b3b57d4a55291e9c260107: Merge tag 'mem-2024-12-21' of https://github.com/davidhildenbrand/qemu into staging (2024-12-22 14:33:27 -0500) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-vfio-20241224 for

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-24 Thread Cédric Le Goater
On 12/24/24 16:12, Peter Xu wrote: On Tue, Dec 24, 2024 at 09:20:08AM +0100, Cédric Le Goater wrote: Fabiano, Peter, On 12/18/24 14:40, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() function. Pe

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-24 Thread Cédric Le Goater
Fabiano, Peter, On 12/18/24 14:40, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() function. Peter's series tried to drop migration_is_device() and migration_is_active(), however VFIO used them to check if dir

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-23 Thread Cédric Le Goater
On 12/23/24 19:43, Joao Martins wrote: On 23/12/2024 18:31, Cédric Le Goater wrote: On 12/23/24 18:55, Joao Martins wrote: On 18/12/2024 13:40, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() fun

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-23 Thread Cédric Le Goater
On 12/23/24 18:55, Joao Martins wrote: On 18/12/2024 13:40, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() function. Peter's series tried to drop migration_is_device() and migration_is_active(), however VFIO

Re: [PATCH v3 22/24] vfio/migration: Multifd device state transfer support - receive side

2024-12-19 Thread Cédric Le Goater
On 12/11/24 00:04, Maciej S. Szmigiero wrote: Hi Cédric, On 2.12.2024 18:56, Cédric Le Goater wrote: Hello Maciej, On 11/17/24 20:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" The multifd received data needs to be reassembled since device state packets sent via

Re: [PATCH v3 24/24] vfio/migration: Multifd device state transfer support - send side

2024-12-19 Thread Cédric Le Goater
On 12/16/24 18:33, Peter Xu wrote: On Thu, Dec 12, 2024 at 11:53:05PM +0100, Maciej S. Szmigiero wrote: On 12.12.2024 15:54, Avihai Horon wrote: On 11/12/2024 1:06, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments On 9.12.2024 10:28, Avihai Horon wrote:

Re: [PATCH v3 19/24] vfio/migration: Add x-migration-multifd-transfer VFIO property

2024-12-19 Thread Cédric Le Goater
On 11/29/24 18:15, Maciej S. Szmigiero wrote: On 29.11.2024 15:11, Cédric Le Goater wrote: On 11/17/24 20:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This property allows configuring at runtime whether to transfer the particular device state via multifd channels

Re: [PATCH v3 18/24] vfio/migration: Don't run load cleanup if load setup didn't run

2024-12-19 Thread Cédric Le Goater
email: Use caution opening links or attachments On 29.11.2024 15:08, Cédric Le Goater wrote: On 11/17/24 20:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" It's possible for load_cleanup SaveVMHandler to get called without load_setup handler being called first. Sinc

Re: [PATCH v3 00/24] Multifd 🔀 device state transfer support with VFIO consumer

2024-12-19 Thread Cédric Le Goater
Hello Yanghang On 12/19/24 08:55, Yanghang Liu wrote: FYI. The following data comes from the first ping-pong mlx VF migration after rebooting the host. 1. Test for multifd=0: 1.1 Outgoing migration: VF number: 1 VF 4 VF Time elapsed:

Re: [PATCH 8/9] migration: Drop migration_is_device()

2024-12-17 Thread Cédric Le Goater
On 12/16/24 10:46, Avihai Horon wrote: After being removed from VFIO, migration_is_device() no longer has any users. Drop it. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater Thanks, C. --- include/migration/misc.h | 1 - migration/migration.c| 7 --- 2 files

Re: [PATCH 9/9] migration: Unexport migration_is_active()

2024-12-17 Thread Cédric Le Goater
vihai Horon Reviewed-by: Cédric Le Goater Thanks, C. --- include/migration/misc.h | 1 - migration/migration.c| 16 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/include/migration/misc.h b/include/migration/misc.h index ad1e25826a..c0e23fdac9 100644

Re: [PATCH 0/9] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-16 Thread Cédric Le Goater
On 12/16/24 10:46, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() function. Peter's series tried to drop migration_is_device() and migration_is_active(), however VFIO used them to check if dirty page tracking

Re: [PATCH 0/9] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-16 Thread Cédric Le Goater
Hello Joao, On 12/16/24 16:37, Joao Martins wrote: On 16/12/2024 14:45, Avihai Horon wrote: On 16/12/2024 14:00, Joao Martins wrote: On 16/12/2024 09:46, Avihai Horon wrote: I also have a much smaller series for that sort of unblockage that I can give you a pointer. Yes, if you have it at ha

Re: [PATCH 65/71] hw/vfio: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:29, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- hw/vfio/pci.c | 4 ++-- hw/vfio/platform.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions

Re: [PATCH 67/71] hw/watchdog: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:30, Richard Henderson wrote: Signed-off-by: Richard Henderson For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C. --- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_imx2.c | 2 +- 3 files changed, 3 insertions(+), 3

Re: [PATCH 59/71] hw/ssi: Constify all Property

2024-12-14 Thread Cédric Le Goater
+- hw/ssi/xilinx_spi.c | 2 +- hw/ssi/xilinx_spips.c | 4 ++-- hw/ssi/xlnx-versal-ospi.c | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C. diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 033cbbb59b

Re: [PATCH 41/71] hw/net: Constify all Property

2024-12-14 Thread Cédric Le Goater
/vmxnet3.c | 2 +- hw/net/xen_nic.c | 2 +- hw/net/xgmac.c | 2 +- hw/net/xilinx_axienet.c| 2 +- hw/net/xilinx_ethlite.c| 2 +- 40 files changed, 41 insertions(+), 41 deletions(-) For the ftgmac100, Reviewed-by: Cédric Le Goater

Re: [PATCH 60/71] hw/timer: Constify all Property

2024-12-14 Thread Cédric Le Goater
(-) For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C. diff --git a/hw/timer/a9gtimer.c b/hw/timer/a9gtimer.c index 8091ec18c7..c0a91bab0c 100644 --- a/hw/timer/a9gtimer.c +++ b/hw/timer/a9gtimer.c @@ -373,7 +373,7 @@ static const VMStateDescription vmstate_a9_gtimer

Re: [PATCH 56/71] hw/sd: Constify all Property

2024-12-14 Thread Cédric Le Goater
deletions(-) For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C. diff --git a/hw/sd/allwinner-sdhost.c b/hw/sd/allwinner-sdhost.c index bcfb4c1322..be39ec2e71 100644 --- a/hw/sd/allwinner-sdhost.c +++ b/hw/sd/allwinner-sdhost.c @@ -808,7 +808,7 @@ static const VMStateDescription

Re: [PATCH 40/71] hw/misc: Constify all Property

2024-12-14 Thread Cédric Le Goater
| 2 +- hw/misc/xlnx-versal-cframe-reg.c | 4 ++-- hw/misc/xlnx-versal-cfu.c| 4 ++-- hw/misc/xlnx-versal-xramc.c | 2 +- hw/misc/zynq_slcr.c | 2 +- 52 files changed, 56 insertions(+), 56 deletions(-) For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C

Re: [PATCH 28/71] hw/i2c: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/i2c/aspeed_i2c.c | 4 ++-- hw/i2c/core.c| 2 +- hw/i2c/i2c_mux_pca954x.c | 2 +- hw/i2c/omap_i2c.c| 2 +- 4 files changed, 5

Re: [PATCH 15/71] hw/arm: Constify all Property

2024-12-14 Thread Cédric Le Goater
+- hw/arm/stellaris.c | 2 +- hw/arm/strongarm.c | 2 +- hw/arm/xlnx-versal.c | 2 +- hw/arm/xlnx-zynqmp.c | 2 +- 18 files changed, 22 insertions(+), 22 deletions(-) For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C. diff --git a/hw/arm/armsse.c b

Re: [PATCH 14/71] hw/adc: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:06, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/adc/aspeed_adc.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/adc/aspeed_adc.c b/hw/adc

Re: [PATCH v3 24/24] vfio/migration: Multifd device state transfer support - send side

2024-12-13 Thread Cédric Le Goater
By the way, this kind of an implicit dependency in VMState between devices is really hard to manage, there should be a way to specify it in code somehow.. vmstate has a MigrationPriority field to order loading between devices. Maybe we could extend but I think it is better to handle ordering at

Re: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-13 Thread Cédric Le Goater
On 12/12/24 14:31, Kenneth Jia(贾纪东_华硕上海) wrote: From 24d3badbbb9dcc0d220609a7dd30f8da5002cba7 Mon Sep 17 00:00:00 2001 From: Kenneth Jia Date: Thu, 12 Dec 2024 20:42:04 +0800 Subject: [PATCH]    hw/arm/aspeed: fix connect_serial_hds_to_uarts    In the loop, we need ignore the index increas

Re: 答复: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-13 Thread Cédric Le Goater
On 12/13/24 10:48, Kenneth Jia(贾纪东_华硕上海) wrote: We plans to use a relatively large number of UART connections, and currently test all UARTs that can be used. When we use qumu for simulation, the problem was discovered. Which QEMU machine are you using ? Thanks, C.

Re: [PATCH 0/2] s390x/pci: relax I/O address translation requirement

2024-12-13 Thread Cédric Le Goater
On 12/12/24 15:42, Matthew Rosato wrote: On 12/12/24 4:10 AM, Thomas Huth wrote: On 09/12/2024 20.29, Matthew Rosato wrote: This series introduces the concept of the relaxed translation requirement for s390x guests in order to allow bypass of the guest IOMMU for more efficient PCI passthrough.

Re: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-12 Thread Cédric Le Goater
nd patches. Anyhow, Fixes: d2b3eaefb4d7 ("aspeed: Refactor UART init for multi-SoC machines") Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 556498f2a

Re: [PATCH v3 24/24] vfio/migration: Multifd device state transfer support - send side

2024-12-12 Thread Cédric Le Goater
On 12/11/24 00:06, Maciej S. Szmigiero wrote: On 9.12.2024 10:28, Avihai Horon wrote: On 17/11/2024 21:20, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" Implement the multifd device state transfer via additional per-device t

Re: [PATCH 1/2] s390x/pci: add support for guests that request direct mapping

2024-12-11 Thread Cédric Le Goater
On 12/9/24 20:29, Matthew Rosato wrote: When receiving a guest mpcifc(4) or mpcifc(6) instruction without the T bit set, treat this as a request to perform direct mapping instead of address translation. In order to facilitiate this, pin the entirety of guest memory into the host iommu. Subseque

[PULL 24/24] test/qtest/ast2700-smc-test: Support to test AST2700

2024-12-10 Thread Cédric Le Goater
se size is 128MB, so set jedec_id 0xef4021. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241127091543.1243114-11-jamin_...@aspeedtech.com Signed-off-by: Cédric Le Goater --- tests/qtest/ast2700-smc-test.c | 71 ++ t

[PULL 00/24] aspeed queue

2024-12-10 Thread Cédric Le Goater
qtest to all Aspeed SoCs Cédric Le Goater (8): arm: Remove tacoma-bmc machine tests/functional: Introduce a specific test for ast1030 SoC tests/functional: Introduce a specific test for palmetto-bmc machine

[PULL 01/24] arm: Remove tacoma-bmc machine

2024-12-10 Thread Cédric Le Goater
Removal was scheduled for 10.0. Use the rainier-bmc machine or the ast2600-evb as a replacement. Reviewed-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/r/20241119071352.515790-1-...@redhat.com Signed-off-by: Cédric Le Goater --- docs/about/deprecated.rst | 8 docs

[PULL 23/24] test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases

2024-12-10 Thread Cédric Le Goater
from aspeed_smc-test.c to aspeed-smc-utils.c. Finally, users are able to re-used these testcase for AST2700 and future ASPEED SOCs testing. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241127091543.1243114-10-jamin_...@aspeedtech.com Signed-off-by

[PULL 18/24] test/qtest/aspeed_smc-test: Introducing a "page_addr" data field

2024-12-10 Thread Cédric Le Goater
ash models, introduces a new page_addr member in TestData structure, so users can set the offset for flash page read/write command testing. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241127091543.1243114-5-jamin_...@aspeedtech.com Signed-off-by: Cédric

[PULL 06/24] aspeed/soc: Support SDHCI for AST2700

2024-12-10 Thread Cédric Le Goater
From: Jamin Lin Add SDHCI model for AST2700 SDHCI support. The SDHCI controller only support 1 slot and registers base address is start at 0x1408_ and its interrupt is connected to GICINT133_INTC at bit 1. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https

[PULL 15/24] test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function

2024-12-10 Thread Cédric Le Goater
: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241127091543.1243114-2-jamin_...@aspeedtech.com Signed-off-by: Cédric Le Goater --- tests/qtest/aspeed_smc-test.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/qtest/aspeed_smc

[PULL 14/24] tests/functional: Move debian boot test from avocado

2024-12-10 Thread Cédric Le Goater
This simply moves the debian boot test from the avocado testsuite to the new functional testsuite. No changes in the test. Reviewed-by: Thomas Huth Link: https://lore.kernel.org/r/20241206131132.520911-8-...@redhat.com Signed-off-by: Cédric Le Goater --- tests/avocado/boot_linux_console.py

[PULL 19/24] test/qtest/aspeed_smc-test: Support to test AST2500

2024-12-10 Thread Cédric Le Goater
t jedec_id 0xc22019. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241127091543.1243114-6-jamin_...@aspeedtech.com Signed-off-by: Cédric Le Goater --- tests/qtest/aspeed_smc-test.c | 40 +++ 1 file changed, 40 insertions(+) di

[PULL 21/24] test/qtest/aspeed_smc-test: Support to test AST1030

2024-12-10 Thread Cédric Le Goater
d 0xef4014. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241127091543.1243114-8-jamin_...@aspeedtech.com Signed-off-by: Cédric Le Goater --- tests/qtest/aspeed_smc-test.c | 42 +++ 1 file changed, 42 insertions(+) diff --g

[PULL 09/24] tests/functional: Introduce a specific test for palmetto-bmc machine

2024-12-10 Thread Cédric Le Goater
This introduces a new aspeed module for sharing code between tests and moves the palmetto test to a new test file. No changes in the test. Reviewed-by: Thomas Huth Link: https://lore.kernel.org/r/20241206131132.520911-3-...@redhat.com Signed-off-by: Cédric Le Goater --- tests/functional

[PULL 13/24] tests/functional: Introduce a specific test for rainier-bmc machine

2024-12-10 Thread Cédric Le Goater
This simply moves the rainier-bmc test to a new test file. No changes in the test. The test_arm_aspeed.py is deleted. Reviewed-by: Thomas Huth Link: https://lore.kernel.org/r/20241206131132.520911-7-...@redhat.com Signed-off-by: Cédric Le Goater --- tests/functional/meson.build

[PULL 04/24] hw:sdhci: Introduce a new "capareg" class member to set the different Capability Registers

2024-12-10 Thread Cédric Le Goater
600. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/r/20241204084453.610660-4-jamin_...@aspeedtech.com Signed-off-by: Cédric Le Goater --- include/hw/sd/aspeed_sdhci.h | 12 +++-- hw/arm/aspeed_ast2400.c | 3 ++- hw/arm/aspeed_ast2600.c |

  1   2   3   4   5   6   7   8   9   10   >