Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Busch, Keith
> Thanks for the fix! Minor comment below, no need to fix. > > Acked-by: Keith Busch I accidently deleted my comment. Here's what it said: +list = g_malloc(data_len); +for (i = 0; i < n->num_namespaces; i++) { +if (i <= min_nsid) { +continue; +} +list

Re: [Qemu-devel] [edk2] NVMe question

2015-06-03 Thread Busch, Keith
alues, I assume you're leaving it as 0, which is most definitely below the "required" value. > -Original Message- > From: Tian, Feng > Sent: Tuesday, June 02, 2015 6:21 PM > To: Busch, Keith; Laszlo Ersek > Cc: edk2-de...@lists.sourceforge.net; Anbazhagan,

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-12 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. There seems to be an issu

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. > > Take a look at hw/vi