Re: [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR

2012-08-20 Thread Brendan Fennell
On Mon, 20 Aug 2012, Peter Maydell wrote: On 20 August 2012 18:59, Brendan Fennell wrote: Signed-off-by: Brendan Fennell Reviewed-by: Peter Maydell The () inside the [] aren't actually necessary, but I'm just going to fix those as I take this patch into the arm-devs queu

[Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR

2012-08-20 Thread Brendan Fennell
Signed-off-by: Brendan Fennell --- hw/pl190.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..b372da8 100644 --- a/hw/pl190.c +++ b/hw/pl190.c @@ -117,12 +117,18 @@ static uint64_t pl190_read(void *opaque

Re: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR

2012-08-20 Thread Brendan Fennell
On Mon, 20 Aug 2012, Peter Maydell wrote: On 19 August 2012 11:59, Brendan Fennell wrote: Signed-off-by: Brendan Fennell --- hw/pl190.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..eddb531 100644 --- a/hw/pl190.c +++ b

[Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR

2012-08-19 Thread Brendan Fennell
Signed-off-by: Brendan Fennell --- hw/pl190.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..eddb531 100644 --- a/hw/pl190.c +++ b/hw/pl190.c @@ -120,7 +120,8 @@ static uint64_t pl190_read(void *opaque, target_phys_addr_t

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Brendan Fennell
On Sat, 18 Aug 2012, Peter Maydell wrote: On 18 August 2012 11:41, Brendan Fennell wrote: On Sat, 18 Aug 2012, Peter Maydell wrote: On 18 August 2012 03:55, Brendan Fennell wrote: Signed-off-by: Brendan Fennell --- hw/pl190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Brendan Fennell
On Sat, 18 Aug 2012, Peter Maydell wrote: On 18 August 2012 03:55, Brendan Fennell wrote: Signed-off-by: Brendan Fennell --- hw/pl190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..d69d5be 100644 --- a/hw/pl190.c +++ b/hw

[Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Brendan Fennell
Signed-off-by: Brendan Fennell --- hw/pl190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..d69d5be 100644 --- a/hw/pl190.c +++ b/hw/pl190.c @@ -133,7 +133,7 @@ static uint64_t pl190_read(void *opaque, target_phys_addr_t offset