Re: [PATCH] dbus: Properly dispose touch/mouse dbus objects

e > > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line > >Your patches must include a Signed-off-by: line. This is a >hard requirement because it’s how you say “I’m legally okay >to contribute this and h

[PATCH v2] dbus: Properly dispose touch/mouse dbus objects

Signed-off-by: Bilal Elmoussaoui --- ui/dbus-console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index e19774f985..36f7349585 100644 --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object

[PATCH] dbus: Properly dispose touch/mouse dbus objects

--- ui/dbus-console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index e19774f985..36f7349585 100644 --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object) DBusDisplayConsole *ddc = DBU

Re: [PATCH v2] ui/dbus: implement damage regions for GL

marcandre.lur...@redhat.com> wrote: > Hi > > On Mon, Aug 14, 2023 at 4:58 PM Bilal Elmoussaoui > wrote: > > > > Currently, when using `-display dbus,gl=on` all updates to the client > > become "full scanout" updates, meaning there is no way for the

Re: [PATCH] ui/dbus: implement damage regions for GL

Thanks for the quick review! I have sent a v2 with the requested changes. On Mon, Aug 14, 2023 at 2:41 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Mon, Aug 14, 2023 at 4:10 PM Bilal Elmoussaoui > wrote: > > > > Currently, when using `-disp

[PATCH v2] ui/dbus: implement damage regions for GL

to the client. This was less of an issue when clients were using GtkGLArea for rendering, as you'd be doing full-surface redraw. To be efficient, the client needs both a DMA-BUF and the damage region to be updated. Co-authored-by: Christian Hergert Signed-off-by: Bilal Elmoussaoui ---

[PATCH] ui/dbus: implement damage regions for GL

to the client. This was less of an issue when clients were using GtkGLArea for rendering, as you'd be doing full-surface redraw. To be efficient, the client needs both a DMA-BUF and the damage region to be updated. Co-authored-by: Christian Hergert Signed-off-by: Bilal Elmoussaoui ---

[PATCH v4 0/2] dbus/ui: Expose a multi touch interface

*** Expose a multi touch device interface for the UI DBus backend *** Bilal Elmoussaoui (2): ui/touch: Move event handling to a common helper ui/dbus: Expose a touch device interface include/ui/console.h | 15 ++ ui/console.c | 65

[PATCH v4 2/2] ui/dbus: Expose a touch device interface

So that clients making use of the DBus backend could send touch events through the new org.qemu.Display1.Touch interface Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau Signed-off-by: Bilal Elmoussaoui --- ui/dbus-console.c| 59

[PATCH v4 1/2] ui/touch: Move event handling to a common helper

To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau --- include/ui/console.h | 15 ++ ui/console.c | 65 ui/gtk.c | 61

[PATCH v3 1/2] ui/touch: Move event handling to a common helper

To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau --- include/ui/console.h | 15 ++ ui/console.c | 65 ui/gtk.c | 61

[no subject]

Expose the recently added multi touch support on the UI DBus backend Bilal Elmoussaoui (2): ui/touch: Move event handling to a common helper ui/dbus: Expose a touch device interface include/ui/console.h | 15 ++ ui/console.c | 65

[PATCH v3 2/2] ui/dbus: Expose a touch device interface

So that clients making use of the DBus backend could send touch events through the new org.qemu.Display1.Touch interface Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau --- ui/dbus-console.c| 59 +++- ui/dbus-display1.xml | 45

[no subject]

Expose the recently added multi touch support on the UI DBus backend Bilal Elmoussaoui (2): ui/touch: Move event handling to a common helper ui/dbus: Expose a touch device interface include/ui/console.h | 15 ++ ui/console.c | 65

[PATCH v2 1/2] ui/touch: Move event handling to a common helper

To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui --- include/ui/console.h | 15 ++ ui/console.c | 65 ui/gtk.c | 61

[PATCH v2 2/2] ui/dbus: Expose a touch device interface

So that clients making use of the DBus backend could send touch events through the new org.qemu.Display1.Touch interface Signed-off-by: Bilal Elmoussaoui --- ui/dbus-console.c| 59 +++- ui/dbus-display1.xml | 45 +++-- ui

[PATCH 2/2] ui/dbus: Expose a touch device interface

So that clients making use of the DBus backend could send touch events through the new org.qemu.Display1.Touch interface Signed-off-by: Bilal Elmoussaoui --- ui/dbus-console.c| 56 +++- ui/dbus-display1.xml | 38 -- ui

[PATCH 1/2] ui/touch: Move event handling to a common helper

To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui --- include/ui/console.h | 14 ++ ui/console.c | 65 ui/gtk.c | 62

[PATCH 1/2] ui/touch: Move event handling to a common helper

To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui --- include/ui/console.h | 14 ++ ui/console.c | 65 ui/gtk.c | 62

Re: [PATCH] ui/dbus: Implement damage regions for GL

> > cairo declared as optional dep, ... > I don't see where cairo is marked as an optional dependency, the `cairo = not_found` part could probably be dropped to make it clearer. On Tue, May 9, 2023 at 4:34 PM Philippe Mathieu-Daudé wrote: > Hi, > > On 9/5/23 13:59,

[PATCH] ui/dbus: Implement damage regions for GL

l be sending full or near-full surface damages. https://lists.freedesktop.org/archives/dri-devel/2023-March/395164.html contains a patch to fix that too. Signed-off-by: Bilal Elmoussaoui --- meson.build| 8 ui/dbus-listener.c | 25 +++-- ui/meson.build |