Re: [RFC PATCH v0 1/2] spapr: Add H_REG_SNS hcall

2021-08-11 Thread Bharata B Rao
On Mon, Aug 09, 2021 at 01:49:54PM +1000, David Gibson wrote: > On Thu, Aug 05, 2021 at 01:02:27PM +0530, Bharata B Rao wrote: > > Add support for H_REG_SNS hcall so that asynchronous page > > fault mechanism can be supported on PowerKVM guests. > > > > Th

Re: [RFC PATCH v0 2/2] ppc,spapr: Handle KVM_EXIT_ESN

2021-08-05 Thread Bharata B Rao
On Thu, Aug 05, 2021 at 09:48:04AM +0200, Laurent Vivier wrote: > On 05/08/2021 09:32, Bharata B Rao wrote: > > Handle KVM_EXIT_ESN exit by issuing subvention notification > > interrupt to the guest. Guests supporting async-pf feature > > will need this interrupt to wake up t

[RFC PATCH v0 0/2] Support for H_REG_SNS hcall

2021-08-05 Thread Bharata B Rao
Bharata B Rao (2): spapr: Add H_REG_SNS hcall ppc,spapr: Handle KVM_EXIT_ESN hw/ppc/spapr.c | 3 ++ hw/ppc/spapr_hcall.c| 56 + include/hw/ppc/spapr.h | 3 ++ include/hw/ppc/spapr_irq.h | 1 + linux-headers/asm

[RFC PATCH v0 1/2] spapr: Add H_REG_SNS hcall

2021-08-05 Thread Bharata B Rao
subvention notification interrupt. Note: Updates to linux-headers/linux/kvm.h are temporary pending headers update. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 3 ++ hw/ppc/spapr_hcall.c| 56 + include/hw/ppc/spapr.h | 3

[RFC PATCH v0 2/2] ppc,spapr: Handle KVM_EXIT_ESN

2021-08-05 Thread Bharata B Rao
update. Signed-off-by: Bharata B Rao --- linux-headers/linux/kvm.h | 1 + target/ppc/kvm.c | 16 2 files changed, 17 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index a76945fcbc..105c8b069a 100644 --- a/linux-headers/linux/kvm.h +++ b

[PATCH v1 2/2] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-07-06 Thread Bharata B Rao
: Bharata B Rao --- hw/ppc/spapr.c | 6 ++ hw/ppc/spapr_caps.c| 41 + include/hw/ppc/spapr.h | 8 ++-- target/ppc/kvm.c | 12 target/ppc/kvm_ppc.h | 12 5 files changed, 77 insertions(+), 2 deletions(-) diff

[PATCH v1 1/2] linux-headers: Update

2021-07-06 Thread Bharata B Rao
Update to mainline commit: 79160a603bdb ("Merge tag 'usb-5.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb" Signed-off-by: Bharata B Rao --- include/standard-headers/asm-x86/kvm_para.h | 13 +++ include/standard-headers/drm/drm_fourcc.h | 7

[PATCH v1 0/2] Enable support for H_RPT_INVALIDATE hcall

2021-07-06 Thread Bharata B Rao
KVM capability) and enables the same. Headers update is needed for KVM_CAP_PPC_RPT_INVALIDATE. v0: https://lore.kernel.org/qemu-devel/20210106085910.2200795-1-bhar...@linux.ibm.com/ Bharata B Rao (2): linux-headers: Update target/ppc: Support for H_RPT_INVALIDATE hcall hw/ppc/spapr.c

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-18 Thread Bharata B Rao
On Fri, Jan 15, 2021 at 06:30:05PM +0100, Greg Kurz wrote: > On Fri, 15 Jan 2021 14:01:28 +0530 > Bharata B Rao wrote: > > > On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote: > > > Hi Bharata, > > > > > > On Wed, 6 Jan 2021 14:29:10 +0530 >

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-15 Thread Bharata B Rao
On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote: > Hi Bharata, > > On Wed, 6 Jan 2021 14:29:10 +0530 > Bharata B Rao wrote: > > > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then > > > > - indicate the availability of H_RPT_INVALIDATE

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-13 Thread Bharata B Rao
On Tue, Jan 12, 2021 at 10:16:30AM -0300, Daniel Henrique Barboza wrote: > > > On 1/6/21 5:59 AM, Bharata B Rao wrote: > > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then > > > > - indicate the availability of H_RPT_INVALIDATE hcall to the guest via &g

[RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-06 Thread Bharata B Rao
: Bharata B Rao --- hw/ppc/spapr.c| 7 ++ hw/ppc/spapr_caps.c | 49 +++ include/hw/ppc/spapr.h| 8 +-- linux-headers/linux/kvm.h | 1 + target/ppc/kvm.c | 12 ++ target/ppc/kvm_ppc.h | 11 + 6 files

Re: [RFC PATCH 1/2] spapr: drc: Add support for async hcalls at the drc level

2020-11-26 Thread Bharata B Rao
On Thu, Nov 26, 2020 at 01:54:55AM -0600, Shivaprasad G Bhat wrote: > The patch adds support for async hcalls at the DRC level for the > spapr devices. To be used by spapr-scm devices in the patch/es to follow. > > Signed-off-by: Shivaprasad G Bhat > --- > hw/ppc/spapr_drc.c | 146 > ++

Re: [Qemu-devel] [PATCH] target-ppc: Add quad precision muladd instructions

2020-09-22 Thread Bharata B Rao
On Tue, Sep 22, 2020 at 10:04:53AM +0200, David Hildenbrand wrote: > Hi guys, > > I just stumbled over > > https://lore.kernel.org/qemu-devel/1487140636-19955-1-git-send-email-bhar...@linux.vnet.ibm.com/ > > while looking for the state of float128_muladd(), as I need that for > s390x as well. >

Re: [RFC PATCH 1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2

2020-04-02 Thread Bharata B Rao
- at the very least it doesn't look like > it could do much harm. Looks good to me, also tested with PowerKVM guests. Reviewed-by: Bharata B Rao Regards, Bharata. -- http://raobharata.wordpress.com/

[PATCH ppc-for-5.0 1/1] ppc/spapr: Don't call KVM_SVM_OFF ioctl on TCG

2020-01-01 Thread Bharata B Rao
Invoking KVM_SVM_OFF ioctl for TCG guests will lead to a QEMU crash. Fix this by ensuring that we don't call KVM_SVM_OFF ioctl on TCG. Reported-by: Alexey Kardashevskiy Fixes: 4930c1966249 ("ppc/spapr: Support reboot of secure pseries guest") Signed-off-by: Bharata B Rao --- t

[PATCH v4 ppc-for-5.0 1/2] linux-headers: Update

2019-12-18 Thread Bharata B Rao
Update to mainline commit: d1eef1c61974 ("Linux 5.5-rc2") Signed-off-by: Bharata B Rao --- include/standard-headers/asm-x86/bootparam.h | 7 +- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +++- include/standard-headers/drm/drm_fourcc.h | 28 ++- .../linux/input-eve

[PATCH v4 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-18 Thread Bharata B Rao
of this ioctl, the secure guest is essentially transitioned back to normal mode so that it can reboot like a regular guest and become secure again. This ioctl has no effect when invoked for a normal guest. If this ioctl fails for a secure guest, the guest is terminated. Signed-off-by: Bharata B

[PATCH v4 ppc-for-5.0 0/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-18 Thread Bharata B Rao
/error_setg_errno (Greg Kurz) Bharata B Rao (2): linux-headers: Update ppc/spapr: Support reboot of secure pseries guest hw/ppc/spapr.c| 1 + include/standard-headers/asm-x86/bootparam.h | 7 +- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +++- include/standard

[PATCH v3 ppc-for-5.0 1/2] linux-headers: Update

2019-12-17 Thread Bharata B Rao
Update to mainline commit: d1eef1c61974 ("Linux 5.5-rc2") Signed-off-by: Bharata B Rao --- include/standard-headers/asm-x86/bootparam.h | 7 +- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +++- include/standard-headers/drm/drm_fourcc.h | 28 ++- .../linux/input-eve

[PATCH v3 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-17 Thread Bharata B Rao
of this ioctl, the secure guest is essentially transitioned back to normal mode so that it can reboot like a regular guest and become secure again. This ioctl has no effect when invoked for a normal guest. If this ioctl fails for a secure guest, the guest is terminated. Signed-off-by: Bharata B

[PATCH v3 ppc-for-5.0 0/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-17 Thread Bharata B Rao
David Gibson suggested. - Updated linux-headers to 5.5.0-rc2 Bharata B Rao (2): linux-headers: Update ppc/spapr: Support reboot of secure pseries guest hw/ppc/spapr.c| 1 + include/standard-headers/asm-x86/bootparam.h | 7 +- .../infiniband/hw/vmw_pvrdma

Re: [PATCH v2 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-12 Thread Bharata B Rao
On Thu, Dec 12, 2019 at 01:27:23PM +0100, Greg Kurz wrote: > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index f11422fc41..25e1a3446e 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -1597,6 +1597,21 @@ static void spapr_machine_reset(MachineState > > *machine) > > void

Re: [PATCH v2 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-12 Thread Bharata B Rao
On Thu, Dec 12, 2019 at 08:34:57AM +0100, Cédric Le Goater wrote: > Hello Bharata, > > > On 12/12/2019 06:50, Bharata B Rao wrote: > > A pseries guest can be run as a secure guest on Ultravisor-enabled > > POWER platforms. When such a secure guest is reset, we need to

[PATCH v2 ppc-for-5.0 1/2] linux-headers: Update

2019-12-11 Thread Bharata B Rao
Update to mainline commit: e42617b825f8 ("Linux 5.5-rc1") Signed-off-by: Bharata B Rao --- include/standard-headers/asm-x86/bootparam.h | 7 +- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +++- include/standard-headers/drm/drm_fourcc.h | 28 ++- .../linux/input-eve

[PATCH v2 ppc-for-5.0 0/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-11 Thread Bharata B Rao
This patchset adds KVM_PPC_SVM_OFF ioctl which is required to support reset of secure guest. This includes linux-headers update so that we get the newly introduced ioctl. v1: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg01489.html Bharata B Rao (2): linux-headers: Update ppc

[PATCH v2 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-11 Thread Bharata B Rao
of this ioctl, the secure guest is essentially transitioned back to normal mode so that it can reboot like a regular guest and become secure again. This ioctl has no effect when invoked for a normal guest. If this ioctl fails for a secure guest, the guest is terminated. Signed-off-by: Bharata B

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-11 Thread Bharata B Rao
On Wed, Dec 11, 2019 at 04:27:42PM +1100, David Gibson wrote: > Ah, right. We'll need to check for -ENOTTY specifically and ignore > it, then. We don't want this spewing warnings on every non-secure > guest. I am posting v2 with explicit check for -ENOTTY. > > > It looks like we may need a new

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-10 Thread Bharata B Rao
On Wed, Dec 11, 2019 at 10:41:32AM +1100, David Gibson wrote: > On Tue, Dec 10, 2019 at 12:20:07PM +0530, Bharata B Rao wrote: > > On Tue, Dec 10, 2019 at 04:05:36PM +1100, David Gibson wrote: > > > On Tue, Dec 10, 2019 at 03:03:01PM +1100, Alexey Kardashevskiy wrote: > >

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-09 Thread Bharata B Rao
On Tue, Dec 10, 2019 at 04:05:36PM +1100, David Gibson wrote: > On Tue, Dec 10, 2019 at 03:03:01PM +1100, Alexey Kardashevskiy wrote: > > > > > > On 10/12/2019 14:50, Bharata B Rao wrote: > > > On Tue, Dec 10, 2019 at 02:28:51PM +1100, David Gibson wrote: > &

Re: [PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-09 Thread Bharata B Rao
On Tue, Dec 10, 2019 at 02:28:51PM +1100, David Gibson wrote: > On Mon, Dec 09, 2019 at 12:30:12PM +0530, Bharata B Rao wrote: > > A pseries guest can be run as a secure guest on Ultravisor-enabled > > POWER platforms. When such a secure guest is reset, we need to > > release/

[PATCH v1 ppc-for-5.0 2/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-08 Thread Bharata B Rao
of this ioctl, the secure guest is essentially transitioned back to normal mode so that it can reboot like a regular guest and become secure again. This ioctl has no effect when invoked for a normal guest. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 1 + target/ppc/kvm.c | 7

[PATCH v1 ppc-for-5.0 0/2] ppc/spapr: Support reboot of secure pseries guest

2019-12-08 Thread Bharata B Rao
This patchset adds KVM_PPC_SVM_OFF ioctl which is required to support reset of secure guest. This includes linux-headers update so that we get the newly introduced ioctl. v0: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg02408.html Bharata B Rao (2): linux-headers: Update ppc

[PATCH v1 ppc-for-5.0 1/2] linux-headers: Update

2019-12-08 Thread Bharata B Rao
Update to mainline commit: e42617b825f8 ("Linux 5.5-rc1") Signed-off-by: Bharata B Rao --- include/standard-headers/asm-x86/bootparam.h | 7 +- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +++- include/standard-headers/drm/drm_fourcc.h | 28 ++- .../linux/input-eve

Re: [PATCH v3 2/3] spapr: Add NVDIMM device support

2019-11-26 Thread Bharata B Rao
On Fri, Nov 22, 2019 at 10:42 AM David Gibson wrote: > > Ok. A number of queries about this. > > 1) The PAPR spec for ibm,dynamic-memory-v2 says that the first word in > each entry is the number of LMBs, but for NVDIMMs you use the > not-necessarily-equal scm_block_size instead. Does the NVDIMM

Re: [Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest

2019-07-10 Thread Bharata B Rao
On Thu, Jul 11, 2019 at 11:31:00AM +1000, David Gibson wrote: > On Wed, Jul 10, 2019 at 11:36:21AM +0530, Bharata B Rao wrote: > > A pseries guest can be run as a secure guest on Ultravisor-enabled > > POWER platforms. When such a secure guest is reset, we need to > > release/

[Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest

2019-07-09 Thread Bharata B Rao
of this ioctl, the secure guest is essentially transitioned back to normal mode so that it can reboot like a regular guest and become secure again. This ioctl has no effect when invoked for a normal guest. Signed-off-by: Bharata B Rao --- * The ioctl implementation in the kernel can be found as

[Qemu-devel] [PATCH] spapr_cpu_core: vmstate_[un]register per-CPU data from (un)realizefn

2018-08-08 Thread Bharata B Rao
unregister happens during CPU removal. Fixing this becomes easier when vmstate (un)registration calls are moved to vcpu (un)realize functions which is what this patch does. Fixes: https://bugs.launchpad.net/qemu/+bug/1785972 Reported-by: Satheesh Rajendran Signed-off-by: Bharata B Rao -

[Qemu-devel] [Bug 1785972] Re: v3.0.0-rc4: VM fails to start after vcpuhotunplug, managedsave sequence

2018-08-08 Thread Bharata B Rao
The first commit that causes this issue is: b94020268e0b6659499e250d25346baaa9888fed (spapr_cpu_core: migrate per- CPU data) Simpler way to reproduce: 1. Hotplug a CPU 2. Hot unplug it 3. Migrate the VM (will fail) -- You received this bug notification because you are a member of qemu- devel-ml

Re: [Qemu-devel] VCPU hotplug on KVM/ARM

2018-08-01 Thread Bharata B Rao
On Tue, Jul 31, 2018 at 3:57 PM, Igor Mammedov wrote: > On Wed, 25 Jul 2018 14:07:12 +0100 > Marc Zyngier wrote: > > > On 25/07/18 13:28, Andrew Jones wrote: > > > On Wed, Jul 25, 2018 at 11:40:54AM +0100, Marc Zyngier wrote: > > >> On 24/07/18 19:35, Maran Wilson wrote: > > >>> It's been a few

[Qemu-devel] [Bug 1780928] Re: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-07-10 Thread Bharata B Rao
Reverting the below comment makes CPU hotplug work again: commit a028dd423ee6dfd091a8c63028240832bf10f671 ppc/xics: introduce ICP DeviceRealize and DeviceReset handlers This changes the ICP realize and reset handlers in DeviceRealize and DeviceReset handlers. parent handlers are

[Qemu-devel] [RFC PATCH v4] spapr: Support ibm, dynamic-memory-v2 property

2018-04-18 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v3: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg02159.html Changes in v4: (Addresses all David Gibson's comments) - Use of QEMU_PACKE

Re: [Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

2018-04-17 Thread Bharata B Rao
On Tue, Apr 17, 2018 at 11:14:27AM +1000, David Gibson wrote: > > static void spapr_machine_2_12_class_options(MachineClass *mc) > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > > index d60b7c6d7a..5e044c44af 100644 > > --- a/include/hw/ppc/spapr.h > > +++ b/include/hw/ppc/spapr.

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-16 Thread Bharata B Rao
On Mon, Apr 16, 2018 at 07:47:29PM +0300, Serhii Popovych wrote: > Bharata B Rao wrote: > > On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: > >> Now recent kernels (i.e. since linux-stable commit a346137e9142 > >> ("powerpc/numa: Use ibm,max-a

[Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

2018-04-16 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v2 - https://lists.nongnu.org/archive/html/qemu-ppc/2018-04/msg00052.html Changes in v3: - Addressed David Gibson's review comments: use of Came

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-13 Thread Bharata B Rao
On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: > Now recent kernels (i.e. since linux-stable commit a346137e9142 > ("powerpc/numa: Use ibm,max-associativity-domains to discover possible nodes") > support this property to mark initially memory-less NUMA nodes as "possible" > to all

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread Bharata B Rao
On Wed, Apr 11, 2018 at 02:45:58PM +1000, David Gibson wrote: > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: > > The new property ibm,dynamic-memory-v2 allows memory to be represented > > in a more compact manner in device tree. > > > > S

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-09 Thread Bharata B Rao
On Tue, Apr 10, 2018 at 01:02:45PM +1000, David Gibson wrote: > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: > > The new property ibm,dynamic-memory-v2 allows memory to be represented > > in a more compact manner in device tree. > > I still need to look a

[Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-08 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v1: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01788.html Changes in v1: - Minor cleanups in the error paths - Rebased on top of ppc

Re: [Qemu-devel] [PATCH for 2.13 1/2] Revert "spapr: Don't allow memory hotplug to memory less nodes"

2018-04-05 Thread Bharata B Rao
On Thu, Apr 05, 2018 at 10:35:22AM -0400, Serhii Popovych wrote: > This reverts commit b556854bd8524c26b8be98ab1bfdf0826831e793. > > Leave change @node type from uint32_t to to int from reverted commit > because node < 0 is always false. > > Signed-off-by: Serhii Popovych > --- > hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH v4 1/5] pc-dimm: make qmp_pc_dimm_device_list() sort devices by address

2018-03-07 Thread Bharata B Rao
off-by: Haozhong Zhang > Reviewed-by: Igor Mammedov > --- > hw/mem/pc-dimm.c | 83 > +--- > hw/ppc/spapr.c | 3 +- I have used this patch with SPAPR to implement the new device tree property ibm,dynamic-memory-v2 at http://patchwork.ozlabs.org/patch/882387/ Reviewed-by: Bharata B Rao

[Qemu-devel] [RFC PATCH v1] spapr: Support ibm, dynamic-memory-v2 property

2018-03-06 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v0: http://lists.gnu.org/archive/html/qemu-ppc/2018-02/msg00236.html Changes in v1: - Rebased on top of Haozhong Zhang's qmp_pc_dimm_device

Re: [Qemu-devel] [RFC PATCH v0 1/2] pc-dimm: Make pc_dimm_built_list() global

2018-02-21 Thread Bharata B Rao
On Tue, Feb 20, 2018 at 03:35:10PM +0100, Igor Mammedov wrote: > On Mon, 19 Feb 2018 12:12:53 +0530 > Bharata B Rao wrote: > > > Making pc_dimm_built_list() global allows other parts of QEMU code > > to build and walk through the DIMM list in address-sorted order. > >

[Qemu-devel] [RFC PATCH v0 1/2] pc-dimm: Make pc_dimm_built_list() global

2018-02-18 Thread Bharata B Rao
hotpluggable areas. CHECK: List of DIMMs is already available via qmp_pc_dimm_device_list(), but that doesn't provide a sorted list. Signed-off-by: Bharata B Rao --- hw/mem/pc-dimm.c | 2 +- include/hw/mem/pc-dimm.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [RFC PATCH v0 2/2] spapr: Support ibm, dynamic-memory-v2 property

2018-02-18 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- docs/specs/ppc-spapr-hotplug.txt | 19 +++ hw/ppc/spapr.c | 254 +-- include/hw/ppc/spapr.h

[Qemu-devel] [RFC PATCH v0 0/2] Support for ibm,dynamic-memory-v2

2018-02-18 Thread Bharata B Rao
to figure out the reason. Bharata B Rao (2): pc-dimm: Make pc_dimm_built_list() global spapr: Support ibm,dynamic-memory-v2 property docs/specs/ppc-spapr-hotplug.txt | 19 +++ hw/mem/pc-dimm.c | 2 +- hw/ppc/spapr.c | 254

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] pseries: fix TCG migration

2017-11-28 Thread Bharata B Rao
On Wed, Nov 29, 2017 at 10:58:29AM +1100, Suraj Jitindar Singh wrote: > On Tue, 2017-11-28 at 18:43 +0100, Laurent Vivier wrote: > > Migration of pseries is broken with TCG because > > QEMU tries to restore KVM MMU state unconditionally. > > > > The result is a SIGSEGV in kvm_vm_ioctl(): > > > >

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-10-16 Thread Bharata B Rao
On Thu, Sep 14, 2017 at 10:59:05AM +0200, Igor Mammedov wrote: > On Thu, 14 Sep 2017 13:48:26 +0530 > Bharata B Rao wrote: > > > On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > > > On Thu, 14 Sep 2017 12:31:18 +0530 > > > Bharata

[Qemu-devel] [FIX PATCH] monitor: Don't return CPU marked for unplug as monitor CPU

2017-10-16 Thread Bharata B Rao
eported-by: Satheesh Rajendran Signed-off-by: Bharata B Rao --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index fe0d1bd..8d60e57 100644 --- a/monitor.c +++ b/monitor.c @@ -1053,7 +1053,7 @@ int monitor_set_cpu(int cpu_index) CPUState *mon_get_

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

2017-09-25 Thread Bharata B Rao
On Fri, Sep 22, 2017 at 11:16:34AM +0200, Thomas Huth wrote: > Historically we've marked all devices as hotpluggable by default. However, > most devices are not hotpluggable, and you also need a HotplugHandler to > support these devices. So if the user tries to "device_add" or "device_del" > such a

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-09-14 Thread Bharata B Rao
On Thu, Sep 14, 2017 at 10:59:05AM +0200, Igor Mammedov wrote: > On Thu, 14 Sep 2017 13:48:26 +0530 > Bharata B Rao wrote: > > > On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > > > On Thu, 14 Sep 2017 12:31:18 +0530 > > > Bharata

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-09-14 Thread Bharata B Rao
On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > On Thu, 14 Sep 2017 12:31:18 +0530 > Bharata B Rao wrote: > > > Hi, > > > > QEMU hits the below assert > > > > qemu-system-ppc64: used ring relocated for ring 2 > > qemu-system-pp

[Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-09-14 Thread Bharata B Rao
Hi, QEMU hits the below assert qemu-system-ppc64: used ring relocated for ring 2 qemu-system-ppc64: qemu/hw/virtio/vhost.c:649: vhost_commit: Assertion `r >= 0' failed. in the following scenario: 1. Boot guest with vhost=on -netdev tap,id=mynet0,script=qemu-ifup,downscript=qemu-ifdown,vhost=

Re: [Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Bharata B Rao
p > > Reported-by: R.Nageswara Sastry > Signed-off-by: Seeteena Thoufeek > Reviewed-by: Bharata B Rao > In the bugzilla, I was only suggesting to post the fix upstream and it doesn't mean a Reviewed-by. You might want to remove this in your next version. Regards, Bharata.

[Qemu-devel] [FIX PATCH v1] spapr: Allow configure-connector to be called multiple times

2017-08-16 Thread Bharata B Rao
nnector to be called multiple times for all types of DR connectors. Signed-off-by: Bharata B Rao --- v0: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02942.html Changes in v1: - Allow configure-connector to be called multiple times for all types of DR connectors and not just LMB

[Qemu-devel] [FIX PATCH v0] spapr: Allow configure-connector to be called multiple times for LMBs

2017-08-16 Thread Bharata B Rao
nnector to be called multiple times for LMBs. Signed-off-by: Bharata B Rao --- hw/ppc/spapr_drc.c | 37 +++-- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 5260b5d..2dd9635 100644 --- a/hw/ppc/spap

[Qemu-devel] [FIX PATCH v2] spapr: Fix QEMU abort during memory unplug

2017-07-20 Thread Bharata B Rao
plugs list only when it is not already present. Fixes: 0cffce56ae3501c5783d779f97993ce478acf856 Signed-off-by: Bharata B Rao --- Changes in v2: - sPAPRDIMMState is now allocated within spapr_pending_dimm_unplugs_add() itself (David Gibson) - spapr_recover_pending_dimm_state() should never return a

[Qemu-devel] [FIX PATCH v1] spapr: Fix QEMU abort during memory unplug

2017-07-19 Thread Bharata B Rao
plugs list only when it is not already present. Fixes: 0cffce56ae3501c5783d779f97993ce478acf856 Signed-off-by: Bharata B Rao --- Changes in v1: - Added comment (David Gibson) - Ensured we free sPAPRDIMMState when corresonding entry already exists (Daniel Henrique Barboza) Daniel had shown an

[Qemu-devel] [FIX PATCH] spapr: Fix QEMU abort during memory unplug

2017-07-19 Thread Bharata B Rao
plugs list only when it is not already present. Fixes: 0cffce56ae3501c5783d779f97993ce478acf856 Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 1cb09e7..990bb2d 100644 --- a/hw/ppc/sp

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread Bharata B Rao
On Wed, Jul 12, 2017 at 01:11:30PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 15:52:37 +0530 > Bharata B Rao wrote: > > > On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > > > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between >

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread Bharata B Rao
types, that > don't support CPU hotplug and don't allocate DRCs for CPUs. > > Reported-by: Bharata B Rao > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr.c |9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr.c b/

Re: [Qemu-devel] [PULL 09/17] spapr: Remove unnecessary differences between hotplug and coldplug paths

2017-07-12 Thread Bharata B Rao
On Tue, Jul 11, 2017 at 02:39:09PM +1000, David Gibson wrote: > spapr_drc_attach() has a 'coldplug' parameter which sets the DRC into > configured state initially, instead of the usual ISOLATED/UNUSABLE state. > It turns out this is unnecessary: although coldplugged devices do need to > be in CONFI

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-04 Thread Bharata B Rao
On Tue, Jul 04, 2017 at 10:02:46AM +0200, Greg Kurz wrote: > > > There is some history to this. I was doing error recovery and propagation > > > here similarly during memory hotplug development phase until Igor > > > suggested that we shoudn't try to recover after we have done guest > > > visible c

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Bharata B Rao
On Tue, Jul 04, 2017 at 09:01:43AM +0530, Bharata B Rao wrote: > On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > > Let's propagate the error instead, like it is done everywhere else >

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Bharata B Rao
On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > Let's propagate the error instead, like it is done everywhere else > where spapr_drc_attach() is called. > > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr.c | 10 +

Re: [Qemu-devel] [PATCH 4/6] spapr: Make DRC reset force DRC into known state

2017-06-20 Thread Bharata B Rao
On Thu, Jun 08, 2017 at 03:09:28PM +1000, David Gibson wrote: > The reset handler for DRCs attempts several state transitions which are > subject to various checks and restrictions. But at reset time we know > there is no guest, so we can ignore most of the usual sequencing rules and > just set th

Re: [Qemu-devel] [FIX PATCH] spapr: prevent QEMU crash when CPU realization fails

2017-06-15 Thread Bharata B Rao
On Thu, Jun 15, 2017 at 09:32:38AM +0200, Greg Kurz wrote: > On Thu, 15 Jun 2017 08:22:44 +0530 > Bharata B Rao wrote: > > > ICPState objects were being allocated before CPU thread realization. > > However commit 9ed656631d73 (xics: setup cpu at realize time) reversed

[Qemu-devel] [FIX PATCH] target/ppc: Proper cleanup when ppc_cpu_realizefn fails

2017-06-14 Thread Bharata B Rao
the cpus list causing SIGSEGV later (for eg when running "info cpus"). Signed-off-by: Bharata B Rao --- target/ppc/translate_init.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c index e837cd

[Qemu-devel] [FIX PATCH] spapr: prevent QEMU crash when CPU realization fails

2017-06-14 Thread Bharata B Rao
n CPU thread realization fails during cold/hotplug. Fix this by ensuring that we do object_unparent() of ICPState object only in case when is was created earlier. Signed-off-by: Bharata B Rao --- NOTE: There is another SIGSEGV failure that I am investigating which happens when CPU realization fail

Re: [Qemu-devel] [PATCH v6 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-06-12 Thread Bharata B Rao
On Mon, Jun 12, 2017 at 05:10:44PM +0800, David Gibson wrote: > On Mon, Jun 12, 2017 at 11:02:34AM +0530, Bharata B Rao wrote: > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > stream (in the place of HPT size) when the guest doesn't allocate HPT.

[Qemu-devel] [PATCH v6 0/2] ppc/spapr: Fix migration of radix guests

2017-06-11 Thread Bharata B Rao
with TCG and TCG reboot is being fixed. Changes in v6: -- - Ensure any allocated HPT is free by the target when the source doesn't send HPT. v5: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01637.html Bharata B Rao (2): spapr: Add a "no HPT" encoding to H

[Qemu-devel] [PATCH v6 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-06-11 Thread Bharata B Rao
Add a "no HPT" encoding (using value -1) to the HTAB migration stream (in the place of HPT size) when the guest doesn't allocate HPT. This will help the target side to match target HPT with the source HPT and thus enable successful migration. Suggested-by: David Gibson Signed-of

[Qemu-devel] [PATCH v6 2/2] spapr: Fix migration of Radix guests

2017-06-11 Thread Bharata B Rao
Fix migration of radix guests by ensuring that we issue KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. Reported-by: Nageswara R Sastry Signed-off-by: Bharata B Rao Reviewed-by: Suraj Jitindar Singh --- hw/ppc/spapr.c | 12 1 file changed, 12 insertions(+) diff --git a

[Qemu-devel] [PATCH v5 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-06-07 Thread Bharata B Rao
Add a "no HPT" encoding (using value -1) to the HTAB migration stream (in the place of HPT size) when the guest doesn't allocate HPT. This will help the target side to match target HPT with the source HPT and thus enable successful migration. Suggested-by: David Gibson Signed-of

[Qemu-devel] [PATCH v5 2/2] spapr: Fix migration of Radix guests

2017-06-07 Thread Bharata B Rao
Fix migration of radix guests by ensuring that we issue KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. Reported-by: Nageswara R Sastry Signed-off-by: Bharata B Rao Reviewed-by: Suraj Jitindar Singh --- hw/ppc/spapr.c | 12 1 file changed, 12 insertions(+) diff --git a

[Qemu-devel] [PATCH v5 0/2] ppc/spapr: Fix migration of radix guests

2017-06-07 Thread Bharata B Rao
/2017-05/msg07058.html Bharata B Rao (2): spapr: Add a "no HPT" encoding to HTAB migration stream spapr: Fix migration of Radix guests hw/ppc/spapr.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) -- 2.7.4

Re: [Qemu-devel] [PATCH v4 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-06-07 Thread Bharata B Rao
On Thu, Jun 01, 2017 at 02:54:48PM +1000, David Gibson wrote: > On Wed, May 31, 2017 at 04:56:44PM +0530, Bharata B Rao wrote: > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > stream (in the place of HPT size) when the guest doesn't allocate HPT.

Re: [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I)

2017-05-31 Thread Bharata B Rao
On Thu, Jun 01, 2017 at 11:52:14AM +1000, David Gibson wrote: > The code managing DRCs[0] has quite a few things that are more > complicated than they need to be. In particular the object > representing a DRC has a bunch of method pointers, despite the fact > that there are currently no subclasses

[Qemu-devel] [PATCH v4 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

2017-05-31 Thread Bharata B Rao
n spapr->htab != 0. Remove this as we can't assert this for TCG radix guests. Suggested-by: David Gibson [no HPT encoding suggestion] Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff -

[Qemu-devel] [PATCH v4 2/2] spapr: Fix migration of Radix guests

2017-05-31 Thread Bharata B Rao
Fix migration of radix guests by ensuring that we issue KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. Reported-by: Nageswara R Sastry Signed-off-by: Bharata B Rao Reviewed-by: Suraj Jitindar Singh --- hw/ppc/spapr.c | 12 1 file changed, 12 insertions(+) diff --git a

[Qemu-devel] [PATCH v4 0/2] ppc/spapr: Fix migration of radix guests

2017-05-31 Thread Bharata B Rao
radix TCG guests. Fix this assumption. These changes enable TCG migration to work. However guest kernel failures are observed post migration which need to be fixed separately. This changes could acutally go into a separate patch. v3: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05

Re: [Qemu-devel] [PATCH v3 2/3] spapr: Unregister HPT savevm handlers for radix guests

2017-05-25 Thread Bharata B Rao
On Wed, May 24, 2017 at 10:23:33AM +0530, Bharata B Rao wrote: > HPT gets created by default for TCG guests and later when the guest turns > out to be a radix guest, the HPT is destroyed when guest does > H_REGISTER_PROC_TBL hcall. Let HTAB savevm handlers registration and > unregistr

[Qemu-devel] [PATCH v3 3/3] spapr: Fix migration of Radix guests

2017-05-23 Thread Bharata B Rao
Fix migration of radix guests by ensuring that we issue KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. Reported-by: Nageswara R Sastry Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c

[Qemu-devel] [PATCH v3 1/3] migration: Introduce unregister_savevm_live()

2017-05-23 Thread Bharata B Rao
case but not free in the latter case. Hence this new API is needed to differentiate this. This new API will be needed by PowerPC to unregister the HTAB savevm handlers. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Cc: Juan Quintela Cc: Dr. David Alan Gilbert --- include/migration

[Qemu-devel] [PATCH v3 0/3] ppc/spapr: Fix migration of radix guests

2017-05-23 Thread Bharata B Rao
that radix and future v3 hash migration post load is treated similarly. - Ensure TCG Radix guest migration isn't broken. v2: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg04491.html Bharata B Rao (3): migration: Introduce unregister_savevm_live() spapr: Unregister HPT savevm han

[Qemu-devel] [PATCH v3 2/3] spapr: Unregister HPT savevm handlers for radix guests

2017-05-23 Thread Bharata B Rao
f the savevm_htab_handlers.htab_load(). To cater to this circular dependency spapr_reallocate_hpt() is made global. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/ppc/spapr.c | 99 +- include/hw/ppc/spapr.h | 2 + 2 files changed, 52 inser

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

2017-05-23 Thread Bharata B Rao
On Tue, May 23, 2017 at 06:42:28PM +1000, Suraj Jitindar Singh wrote: > On Tue, 2017-05-23 at 10:18 +0530, Bharata B Rao wrote: > > On Mon, May 22, 2017 at 04:30:50PM +1000, Suraj Jitindar Singh wrote: > > > On Fri, 2017-05-19 at 11:10 +0530, Bharata B Rao wrote: > > &g

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

2017-05-22 Thread Bharata B Rao
On Mon, May 22, 2017 at 04:30:50PM +1000, Suraj Jitindar Singh wrote: > On Fri, 2017-05-19 at 11:10 +0530, Bharata B Rao wrote: > > Fix migration of radix guests by ensuring that we issue > > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > > > Repo

Re: [Qemu-devel] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

2017-05-21 Thread Bharata B Rao
On Mon, May 22, 2017 at 12:44:48PM +1000, David Gibson wrote: > On Fri, May 19, 2017 at 12:06:14PM +0530, Bharata B Rao wrote: > > On Fri, May 19, 2017 at 11:10:39AM +0530, Bharata B Rao wrote: > > > Fix migration of radix guests by ensuring that we issue > > > KVM_PPC

Re: [Qemu-devel] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

2017-05-18 Thread Bharata B Rao
On Fri, May 19, 2017 at 11:10:39AM +0530, Bharata B Rao wrote: > Fix migration of radix guests by ensuring that we issue > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > Reported-by: Nageswara R Sastry > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c |

  1   2   3   4   5   6   7   8   9   10   >