Hi Michael,
> On Dec 19, 2017, at 8:27 PM, Michael S. Tsirkin wrote:
>
> On Wed, Dec 13, 2017 at 12:26:44AM -0800, b...@skyportsystems.com wrote:
>> From: Ben Warren
>>
>> Now that virtio-win guest drivers provided by non-Redhat vendors need to
>> use a diffe
> On Dec 14, 2017, at 7:29 PM, Philippe Mathieu-Daudé wrote:
>
> applied using ./scripts/clean-includes
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Peter Maydell
> Reviewed-by: Stefan Hajnoczi
Reviewed-by: Ben Warren
> ---
> hw/audio/fmopl.h
From: Ben Warren
Now that virtio-win guest drivers provided by non-Redhat vendors need to
use a different Subsystem Vendor ID value, a way is needed to set this
parameter on the host. This works with all of the PCI-based devices,
such as NetKVM, viostor, vioscsi, vioserial and balloon.
Signed
It looks like you dropped Marc-André and my Reviewed-by lines. Please put them
back.
> On Nov 27, 2017, at 5:05 AM, Roman Kagan wrote:
>
> Switch vmgenid device to use the UUID property type introduced in the
> previous patch for its 'guid' property.
>
> One semantic change it introduces is t
> On Nov 24, 2017, at 7:36 AM, Roman Kagan wrote:
>
> UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated
> property type becomes helpful.
>
> Signed-off-by: Roman Kagan
Reviewed-by: Ben Warren
> ---
> include/hw/qdev-properties.h | 3 +++
> hw/cor
t;
> One semantic change it introduces is that post-realize modification of
> 'guid' via HMP or QMP will now be rejected with an error; however,
> according to docs/specs/vmgenid.txt this is actually desirable.
>
> Signed-off-by: Roman Kagan
Revie
> On Oct 6, 2017, at 4:50 PM, Philippe Mathieu-Daudé wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Ben Warren
> ---
> hw/acpi/vmgenid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> i
t.
>
> To fix, switch to common boot sector infrastructure.
>
> Cc: Laszlo Ersek
> Cc: Peter Maydell
> Cc: Ben Warren
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Ben Warren mailto:b...@skyportsystems.com>>
> ---
>
> Changes from v1
>fix coding st
Hi,
> On Jul 13, 2017, at 4:51 AM, Marc-André Lureau
> wrote:
>
> Hi
>
> On Thu, Jul 13, 2017 at 1:32 PM Laszlo Ersek <mailto:ler...@redhat.com>> wrote:
> On 07/13/17 12:47, Peter Maydell wrote:
> > On 12 July 2017 at 00:43, Ben Warren > <mailto
Hi Laszlo,
> On Jul 11, 2017, at 3:13 PM, Laszlo Ersek wrote:
>
> On 07/11/17 22:42, Peter Maydell wrote:
>> On 11 July 2017 at 20:10, Michael S. Tsirkin wrote:
>>> On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote:
The good news is it's not aarch64-specific. I just hit this on
Hi Peter,
> On Jul 11, 2017, at 6:32 AM, Peter Maydell wrote:
>
> On 3 July 2017 at 20:45, Michael S. Tsirkin wrote:
>> From: Ben Warren
>>
>> The following tests are implemented:
>> * test that a GUID passed in by command line is propagated to the guest.
&g
From: Ben Warren
The following tests are implemented:
* test that a GUID passed in by command line is propagated to the guest.
Read the GUID from guest memory
* test that the "auto" argument to the GUID generates a valid GUID, as
seen by the guest.
* test that a GUID passed in can
> [boots normally]
>
> Suggested-by: Eduardo Habkost
> Signed-off-by: Marc-André Lureau
Reviewed-by: Ben Warren mailto:m...@redhat.com>>
> ---
> include/hw/acpi/bios-linker-loader.h | 2 ++
> include/hw/compat.h | 4
> hw/acpi/bios-linker-loader
> On Jun 1, 2017, at 7:52 AM, Michael S. Tsirkin wrote:
>
> On Thu, Jun 01, 2017 at 07:46:24AM -0700, Ben Warren wrote:
>>
>>> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin wrote:
>>>
>>> On Thu, Jun 01, 2017 at 08:10:27AM +, Marc-André Lurea
> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin wrote:
>
> On Thu, Jun 01, 2017 at 08:10:27AM +, Marc-André Lureau wrote:
>> Hi
>>
>> On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel <
>> qemu-devel@nongnu.org> wrote:
>>
>>
From: Ben Warren
The following tests are implemented:
* test that a GUID passed in by command line is propagated to the guest.
Read the GUID from guest memory
* test that the "auto" argument to the GUID generates a valid GUID, as
seen by the guest.
* test that a GUID passed in can
Hi,
> On Apr 21, 2017, at 3:14 AM, Marc-André Lureau
> wrote:
>
> Hi,
>
> Was this patch intentionally dropped from the series?
>
Good question. I thought the whole patch series was pulled in, but it looks
like this one was not. I guess we’ll see what Michael has to say.
—Ben
>
>
> --
> On Apr 12, 2017, at 1:47 PM, Marc-André Lureau
> wrote:
>
> Hi
>
> On Thu, Apr 13, 2017 at 12:25 AM Ben Warren <mailto:b...@skyportsystems.com>> wrote:
>> On Apr 12, 2017, at 1:22 PM, Marc-André Lureau > <mailto:marcandre.lur...@gmail.com>> wr
> On Apr 12, 2017, at 1:22 PM, Marc-André Lureau
> wrote:
>
> Hi
>
> On Thu, Apr 13, 2017 at 12:17 AM Ben Warren <mailto:b...@skyportsystems.com>> wrote:
>> On Apr 12, 2017, at 1:06 PM, Marc-André Lureau > <mailto:marcandre.lur...@
> On Apr 12, 2017, at 1:06 PM, Marc-André Lureau
> wrote:
>
> Hi
>
> On Thu, Mar 2, 2017 at 10:22 AM Michael S. Tsirkin <mailto:m...@redhat.com>> wrote:
> From: Ben Warren mailto:b...@skyportsystems.com>>
>
> This patch is based off an earlier v
s enabled in 2.5+ machine types only (see commit
> e6915b5f3a87, "fw_cfg: unbreak migration compatibility for 2.4 and earlier
> machines", 2016-02-18).
>
> Cc: "Michael S. Tsirkin"
> Cc: Ben Warren
> Cc: Igor Mammedov
> Cc: Paolo Bonzini
> Signed-o
Thanks Laszlo!
> On Mar 20, 2017, at 10:05 AM, Laszlo Ersek wrote:
>
> A system with multiple VMGENID devices is undefined in the VMGENID spec by
> omission.
>
> Cc: "Michael S. Tsirkin"
> Cc: Ben Warren
> Cc: Igor Mammedov
> Cc: Paolo Bonzini
> Si
": "query-vm-generation-id" }
>>>>>
>>>>> HMP command example:
>>>>>info vm-generation-id
>>>>>
>>>>> Signed-off-by: Igor Mammedov
>>>>> Reviewed-by: Eric Blake
>>>
> On Feb 20, 2017, at 7:41 AM, Laszlo Ersek wrote:
>
> On 02/20/17 15:57, Igor Mammedov wrote:
>> On Thu, 16 Feb 2017 15:15:32 -0800
>> b...@skyportsystems.com wrote:
>>
>>> From: Ben Warren
>>>
>>> This patch set adds support
> On Feb 17, 2017, at 12:07 PM, Laszlo Ersek wrote:
>
> On 02/17/17 17:03, Laszlo Ersek wrote:
>> On 02/17/17 16:33, Ben Warren wrote:
>>>
>>>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >>> <mailto:imamm...@redhat.com>> wrote
> On Feb 17, 2017, at 8:03 AM, Laszlo Ersek wrote:
>
> On 02/17/17 16:33, Ben Warren wrote:
>>
>>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >> <mailto:imamm...@redhat.com>
>>> <mailto:imamm...@redhat.com <mailto:imamm...@redhat.com>>&
> On Feb 17, 2017, at 2:43 AM, Igor Mammedov wrote:
>
> On Thu, 16 Feb 2017 15:15:36 -0800
> b...@skyportsystems.com wrote:
>
>> From: Ben Warren
>>
>> This implements the VM Generation ID feature by passing a 128-bit
>> GUID to the guest via a fw_cfg
> On Feb 16, 2017, at 11:03 AM, Laszlo Ersek wrote:
>
> On 02/16/17 19:32, Ben Warren wrote:
>>
>>> On Feb 16, 2017, at 1:56 AM, Igor Mammedov wrote:
>>>
>>> On Wed, 15 Feb 2017 22:18:14 -0800
>>> b...@skyportsystems.com wrote:
>>&g
> On Feb 16, 2017, at 1:56 AM, Igor Mammedov wrote:
>
> On Wed, 15 Feb 2017 22:18:14 -0800
> b...@skyportsystems.com wrote:
>
>> From: Ben Warren
>>
>> This implements the VM Generation ID feature by passing a 128-bit
>> GUID to the guest via a fw_cfg
> On Feb 16, 2017, at 2:36 AM, Igor Mammedov wrote:
>
> On Wed, 15 Feb 2017 22:18:17 -0800
> b...@skyportsystems.com <mailto:b...@skyportsystems.com> wrote:
>
>> From: Ben Warren
>>
>> The following tests are implemented:
>> * test that a GUID p
> On Feb 16, 2017, at 9:01 AM, Laszlo Ersek wrote:
>
> On 02/16/17 07:18, b...@skyportsystems.com <mailto:b...@skyportsystems.com>
> wrote:
>> From: Ben Warren
>>
>> This is similar to the existing 'add pointer' functionality, but instead
>&
> On Feb 16, 2017, at 6:29 AM, Igor Mammedov wrote:
>
> On Wed, 15 Feb 2017 22:18:10 -0800
> b...@skyportsystems.com wrote:
>
>> From: Ben Warren
>>
>> This patch set adds support for passing a GUID to Windows guests. It is a
>> re-implementation
> On Feb 15, 2017, at 5:13 AM, Igor Mammedov wrote:
>
> On Tue, 14 Feb 2017 22:15:49 -0800
> b...@skyportsystems.com <mailto:b...@skyportsystems.com> wrote:
>
>> From: Ben Warren
>>
>> The following tests are implemented:
>> * test that a GUID p
ion ID counter.
>>
>> QMP command example:
>>{ "execute": "query-vm-generation-id" }
>>
>> HMP command example:
>>info vm-generation-id
>>
>> Signed-off-by: Igor Mammedov
>> Reviewed-by: Eric Blake
>> Signed-off-by: Ben War
> On Feb 15, 2017, at 7:24 AM, Laszlo Ersek wrote:
>
> On 02/15/17 13:19, Igor Mammedov wrote:
>> On Tue, 14 Feb 2017 22:15:46 -0800
>> b...@skyportsystems.com wrote:
>>
>>> From: Ben Warren
>>>
>>> This implements the VM Generation ID fe
> On Feb 15, 2017, at 6:30 AM, Laszlo Ersek wrote:
>
> On 02/15/17 07:15, b...@skyportsystems.com wrote:
>> From: Ben Warren
>>
>> This allows them to be centrally initialized and destroyed
>>
>> The "AcpiBuildTables.vmgenid" array will be u
> On Feb 15, 2017, at 12:52 PM, Laszlo Ersek wrote:
>
> On 02/15/17 21:09, Michael S. Tsirkin wrote:
>> On Wed, Feb 15, 2017 at 08:47:48PM +0100, Laszlo Ersek wrote:
>
> [snip]
>
>>> For patches #1, #3, #4 and #5:
>>>
>>> Tested-by: Laszlo Ersek
>>>
>>> I'll soon post the OVMF patches.
>>>
> On Feb 15, 2017, at 2:56 PM, Eric Blake wrote:
>
> On 02/15/2017 03:58 PM, Ben Warren wrote:
>
>>>
>>> ---
>>> tests/acpi-utils.h | 75
>>>
>>> tests/bios-tables-test.c | 72 +
> On Feb 15, 2017, at 1:35 PM, Eric Blake wrote:
>
> On 02/15/2017 12:15 AM, b...@skyportsystems.com
> <mailto:b...@skyportsystems.com> wrote:
>> From: Ben Warren
>>
>> Also usable by upcoming VM Generation ID tests
>>
>> Signed-off-by: Ben
> On Feb 15, 2017, at 12:09 PM, Michael S. Tsirkin wrote:
>
> On Wed, Feb 15, 2017 at 08:47:48PM +0100, Laszlo Ersek wrote:
>> On 02/15/17 07:15, b...@skyportsystems.com wrote:
>>> From: Ben Warren
>>>
>>> This patch set adds support for passing
> On Feb 15, 2017, at 11:14 AM, Ben Warren wrote:
>
>>
>> On Feb 15, 2017, at 10:24 AM, Igor Mammedov > <mailto:imamm...@redhat.com>> wrote:
>>
>> On Wed, 15 Feb 2017 20:04:40 +0200
>> "Michael S. Tsirkin" mailto:m...@redhat.com>&g
;>>>>> On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote:
>>>>>>> On Wed, 15 Feb 2017 15:13:20 +0100
>>>>>>> Laszlo Ersek wrote:
>>>>>>>
>>>>>>>> Commenting under Igor's reply
> On Feb 15, 2017, at 10:35 AM, Igor Mammedov wrote:
>
> On Wed, 15 Feb 2017 10:14:55 -0800
> Ben Warren mailto:b...@skyportsystems.com>> wrote:
>
>>> On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Feb 15, 2017 at 09:54
> On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin wrote:
>
> On Wed, Feb 15, 2017 at 09:54:08AM -0800, Ben Warren wrote:
>>
>>On Feb 15, 2017, at 9:43 AM, Igor Mammedov wrote:
>>
>>On Wed, 15 Feb 2017 18:39:06 +0200
>>"Michael S. Tsirk
t; Commenting under Igor's reply for simplicity
>>>>>>
>>>>>> On 02/15/17 11:57, Igor Mammedov wrote:
>>>>>>> On Tue, 14 Feb 2017 22:15:43 -0800
>>>>>>> b...@skyportsystems.com wrote:
>>>>>>>
&g
> On Feb 15, 2017, at 8:40 AM, Michael S. Tsirkin wrote:
>
> On Wed, Feb 15, 2017 at 05:07:57PM +0100, Igor Mammedov wrote:
>>> Those improvements can be added later, IMO -- but please do work out
>>> with Igor whether he really wants a v7 for those.
>> since it's minor fixes not influencing oth
Hi Igor. Thanks for the review!
> On Feb 15, 2017, at 4:19 AM, Igor Mammedov wrote:
>
> On Tue, 14 Feb 2017 22:15:46 -0800
> b...@skyportsystems.com <mailto:b...@skyportsystems.com> wrote:
>
>> From: Ben Warren
>>
>> This implements the VM Generation
Hi
> On Feb 12, 2017, at 11:55 AM, Marcel Apfelbaum
> wrote:
>
> On 02/06/2017 06:31 PM, Michael S. Tsirkin wrote:
>> On Sun, Feb 05, 2017 at 01:12:03AM -0800, b...@skyportsystems.com wrote:
>>> From: Ben Warren
>>>
>>> This allows pc_i440fx-bas
> On Feb 9, 2017, at 12:24 PM, Laszlo Ersek wrote:
>
> On 02/09/17 21:02, Ben Warren wrote:
>>
>>> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek >> <mailto:ler...@redhat.com>> wrote:
>>>
>>> On 02/09/17 18:23, Igor Mammedov wrote:
> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek wrote:
>
> On 02/09/17 18:23, Igor Mammedov wrote:
>> On Wed, 8 Feb 2017 01:48:42 +0100
>> Laszlo Ersek wrote:
>>
>>> On 02/05/17 10:12, b...@skyportsystems.com wrote:
>>>> From: Ben Warren
>>
> On Feb 7, 2017, at 4:48 PM, Laszlo Ersek wrote:
>
> On 02/05/17 10:12, b...@skyportsystems.com <mailto:b...@skyportsystems.com>
> wrote:
>> From: Ben Warren
>>
>> This implements the VM Generation ID feature by passing a 128-bit
>> GUID to the gue
>>> b...@skyportsystems.com wrote:
>>>>
>>>>> From: Ben Warren
>>>>>
>>>>> This is initially used to patch a 64-bit address into
>>>>> the VM Generation ID SSDT
>>>>>
>>>>> Signed-off
Thanks for reviewing Igor.
> On Feb 7, 2017, at 5:48 AM, Igor Mammedov wrote:
>
> On Sun, 5 Feb 2017 01:12:00 -0800
> b...@skyportsystems.com <mailto:b...@skyportsystems.com> wrote:
>
>> From: Ben Warren
>>
>> This implements the VM Generation ID feat
> On Feb 6, 2017, at 11:04 AM, Michael S. Tsirkin wrote:
>
> On Mon, Feb 06, 2017 at 10:48:05AM -0800, Ben Warren wrote:
>>
>>> On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin wrote:
>>>
>>> On Mon, Feb 06, 2017 at 09:59:55AM -0800,
> On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin wrote:
>
> On Mon, Feb 06, 2017 at 09:59:55AM -0800, Ben Warren wrote:
>> +void vmgenid_add_fw_cfg(FWCfgState *s, GArray *guid)
>> +{
>> +Object *
> On Feb 6, 2017, at 9:41 AM, Michael S. Tsirkin wrote:
>
> On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote:
>>
>>On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin wrote:
>>
>>On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.c
> On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin wrote:
>
> On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com
> <mailto:b...@skyportsystems.com> wrote:
>> From: Ben Warren mailto:b...@skyportsystems.com>>
>>
>> This implements the VM
> On Feb 6, 2017, at 6:56 AM, Michael S. Tsirkin wrote:
>
> On Sun, Feb 05, 2017 at 01:11:57AM -0800, b...@skyportsystems.com wrote:
>> From: Ben Warren
>>
>> This adds to the existing 'add pointer' functionality in that it
>> instructs the gues
> On Jan 27, 2017, at 8:12 AM, Laszlo Ersek wrote:
>
> On 01/27/17 16:43, Kevin O'Connor wrote:
>> On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote:
>>> On 01/27/17 15:18, Kevin O'Connor wrote:
If an offset is going to be added, shouldn't both a source offset and
destinatio
> On Jan 25, 2017, at 4:48 PM, Laszlo Ersek wrote:
>
> On 01/25/17 19:35, Michael S. Tsirkin wrote:
>> On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote:
>>> Hi Laszlo,
>>>
>>>
>>>On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote
the next version will be merged at once.
>
> With all that said:
>
> On 01/25/17 02:43, b...@skyportsystems.com <mailto:b...@skyportsystems.com>
> wrote:
>> From: Ben Warren mailto:b...@skyportsystems.com>>
>>
>> This is initially used to patch a 64-b
Thanks Laszlo!
> On Jan 19, 2017, at 1:25 AM, Laszlo Ersek wrote:
>
> On 01/19/17 08:09, Ben Warren wrote:
>>
>>> On Jan 18, 2017, at 4:02 PM, Ben Warren
>>> wrote:
>>>
>>> Hi Michael,
>>>> On Jan 17, 2017, at 9:45 AM, Michael S
> On Jan 18, 2017, at 4:02 PM, Ben Warren wrote:
>
> Hi Michael,
>> On Jan 17, 2017, at 9:45 AM, Michael S. Tsirkin wrote:
>>
>> On Mon, Jan 16, 2017 at 10:57:42AM -0800, Ben Warren wrote:
>>> I think we have a misunderstanding here. I’m storing the VM
&g
Hi Michael,
> On Jan 17, 2017, at 9:45 AM, Michael S. Tsirkin wrote:
>
> On Mon, Jan 16, 2017 at 10:57:42AM -0800, Ben Warren wrote:
>> I think we have a misunderstanding here. I’m storing the VM
>> Generation ID __data__ (a GUID) in a fw_cfg blob, not the address.
>
&
gt; Generation ID counter.
>>
>> QMP command example:
>>{ "execute": "set-vm-generation-id",
>> "arguments": {
>> "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"
>> }
>>}
Hi Igor,
> On Jan 17, 2017, at 5:00 AM, Igor Mammedov wrote:
>
> On Mon, 16 Jan 2017 11:20:55 -0800
> b...@skyportsystems.com wrote:
>
>> From: Ben Warren
>>
>> This implements the VM Generation ID feature by passing a 128-bit
>> GUID to the guest
> On Jan 17, 2017, at 7:21 AM, Michael S. Tsirkin wrote:
>
> Let's not top-post anymore pls.
>
> On Tue, Jan 17, 2017 at 07:01:27AM -0800, Ed Swierk wrote:
>> You mean what causes the guest to re-read the vmgenid guid? The
>> vmgenid ACPI table defines a notify method, and when the guest
>> rec
> On Jan 16, 2017, at 11:51 AM, Eric Blake wrote:
>
> On 01/16/2017 01:20 PM, b...@skyportsystems.com
> <mailto:b...@skyportsystems.com> wrote:
>> From: Ben Warren mailto:b...@skyportsystems.com>>
>
> meta-comment: This message
> On Jan 16, 2017, at 6:21 AM, Michael S. Tsirkin wrote:
>
> On Sat, Jan 14, 2017 at 10:17:53PM -0800, Ben Warren wrote:
>> Hi Michael,
>>
>>
>>On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin wrote:
>>
>> On Tue, Dec 06, 2016 at 06:15:3
Hi Michael,
> On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin wrote:
>
> On Tue, Dec 06, 2016 at 06:15:34PM -0800, Ben Warren wrote:
>> Hi Michael,
>>
>> I’m well on my way to implementing this, but I am really new to the QEMU
>> code base and am strugglin
Hi,
I’m trying to write a unit test to access a fw_cfg device via ACPI memory.
When I access the memory from qtest using the readx() functions, I get the
right values. If I change the contents on the host side, though, then access
from the guest, the contents are unchanged. If I register a r
t;
>> }
>> }
>>
>> HMP command example:
>>set-vm-generation-id changed=true
>> guid=324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87
>>
>> Signed-off-by: Ben Warren
>> Cc: Igor Mammedov
>> Cc: Eric Blake
>> ---
>
>
Hi Michael,
I’m well on my way to implementing this, but I am really new to the QEMU code
base and am struggling with some concepts. Please see below:
> On Oct 5, 2016, at 6:29 PM, Michael S. Tsirkin wrote:
>
> On Tue, Oct 04, 2016 at 03:51:40PM -0700, Ed Swierk wrote:
>> On Thu, Sep 15, 2016
73 matches
Mail list logo
