Re: [Qemu-devel] Building QEMU for WebAssembly

2019-01-07 Thread Anatoly Trosinenko
Hello, Stefan, > Multi-threading is not yet available in WebAssembly. Hopefully this > will change soon because multi-threading and related infrastructure > like atomics are used at the core of several areas in QEMU. Technically, I have managed to serialize the QEMU code to the extent that it wa

Re: [Qemu-devel] [PATCH] sdl: Move use of surface pointer below check for whether it is NULL

2018-05-18 Thread Anatoly Trosinenko
Please excuse me and thank you very much for the fix! 2018-05-18 10:04 GMT+03:00 Gerd Hoffmann : > On Tue, May 15, 2018 at 07:58:14PM +0100, Peter Maydell wrote: > > In commit 2ab858c6c38ee1 we added a use of the 'surf' variable > > in sdl2_2d_update() that was unfortunately placed above the > >

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-03-03 Thread Anatoly Trosinenko
2018-03-03 18:41 GMT+03:00 Stefan Weil : > Am 03.03.2018 um 15:07 schrieb Anatoly Trosinenko: > > Can rewriting TCI in such a way that every operation is aligned at 4- or > > even 8-byte boundary fix the situation or are there some more serious > > problems? > > That&#

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-03-03 Thread Anatoly Trosinenko
018-03-03 17:13 GMT+03:00 Richard Henderson : > On 03/03/2018 06:07 AM, Anatoly Trosinenko wrote: > > Can rewriting TCI in such a way that every operation is aligned at 4- or > even > > 8-byte boundary fix the situation or are there some more serious > problems? > > With t

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-03-03 Thread Anatoly Trosinenko
Can rewriting TCI in such a way that every operation is aligned at 4- or even 8-byte boundary fix the situation or are there some more serious problems? 2018-03-03 16:57 GMT+03:00 Richard Henderson : > On 03/03/2018 12:54 AM, Anatoly Trosinenko wrote: > > Ping. > > Patch

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-03-03 Thread Anatoly Trosinenko
ists.nongnu.org/archive/html/qemu-devel/2018-01/msg06516.html 2018-01-28 9:42 GMT+03:00 Anatoly Trosinenko : > My patch is kind of trivial quick fix that just eliminates these unaligned > reads and doesn't seem to require complicated testing supposing my code > properly handles intege

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-02-19 Thread Anatoly Trosinenko
right about it. http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg06516.html 2018-01-28 9:42 GMT+03:00 Anatoly Trosinenko : > My patch is kind of trivial quick fix that just eliminates these unaligned > reads and doesn't seem to require complicated testing supposing my code

Re: [Qemu-devel] [PATCH] sdl: restore optimized redraw

2018-02-14 Thread Anatoly Trosinenko
Ping. Patchwork link: http://patchwork.ozlabs.org/patch/869283/ 2018-02-05 16:32 GMT+03:00 Anatoly Trosinenko : > The documentation on SDL_RenderPresent function states that > "the backbuffer should be considered invalidated after each present", > so copy the entire tex

Re: [Qemu-devel] [PATCH 0/1] Fix unaligned reads in the tcg/tci.c

2018-02-05 Thread Anatoly Trosinenko
Ping. Patchwork link: http://patchwork.ozlabs.org/patch/866732/ Patchew link: http://patchew.org/QEMU/20180127134908.24095-1-anatoly.trosine...@gmail.com/ (Initially forgot to add Richard Henderson to CC.) 2018-01-27 16:49 GMT+03:00 Anatoly Trosinenko : > The code in tcg/tci.c reads some d

[Qemu-devel] [PATCH] sdl: restore optimized redraw

2018-02-05 Thread Anatoly Trosinenko
to just the changed pixels. Also added SDL_RenderClear call, as suggested in the documentation page on SDL_RenderPresent. Signed-off-by: Anatoly Trosinenko --- I managed to reproduce some flicker when using SDL 2D UI (and #if 1) and it disappeared after this patch. I don't know the original

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-29 Thread Anatoly Trosinenko
Got it, thank you! 29 янв. 2018 г. 11:27 ДП пользователь "Gerd Hoffmann" написал: > On Sun, Jan 28, 2018 at 06:43:44PM +0300, Anatoly Trosinenko wrote: > > When QEMU is run with GTK UI, it changes what is drawn on its single > window > > when I press Ctrl-Alt-{1,2,

[Qemu-devel] SDL2 UI behavior of switching views

2018-01-28 Thread Anatoly Trosinenko
When QEMU is run with GTK UI, it changes what is drawn on its single window when I press Ctrl-Alt-{1,2,3,4}. But when I use SDL2 UI, it opens multiple windows: a separate window per each view (display, monitor, serial, parallel). Is it by design or is it a bug? -- Best regards, Anatoly

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-01-27 Thread Anatoly Trosinenko
ve this issue for me on "host with special alignment requirement". 2018-01-27 19:38 GMT+03:00 Stefan Weil : > Am 27.01.2018 um 14:49 schrieb Anatoly Trosinenko: > > Use ldl_he_p / ldq_he_p functions instead of a plain memory access > > through pointer. > > >

[Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-01-27 Thread Anatoly Trosinenko
Use ldl_he_p / ldq_he_p functions instead of a plain memory access through pointer. Signed-off-by: Anatoly Trosinenko --- tcg/tci.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tcg/tci.c b/tcg/tci.c index 33edca1903..410817cf6a 100644 --- a/tcg/tci.c

[Qemu-devel] [PATCH 0/1] Fix unaligned reads in the tcg/tci.c

2018-01-27 Thread Anatoly Trosinenko
wap.h already arranged everything so integer promotions don't mess things up. I can add casts in case I'm not right about it. Anatoly Trosinenko (1): tci: eliminate UB due to unaligned reads tcg/tci.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) -- 2.14.1