Re: [Qemu-devel] [PATCH 0/3] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-08-25 Thread An-Cheng Huang
On Wed, Aug 17, 2011 at 02:30:53PM -0700, An-Cheng Huang wrote: > On Tue, Aug 09, 2011 at 12:30:52PM -0700, An-Cheng Huang wrote: > > These patches implement the setxattr, getxattr, and removexattr syscalls. > > Since libattr uses indirect syscalls for these, the fix for the indir

Re: [Qemu-devel] [PATCH 0/3] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-08-17 Thread An-Cheng Huang
On Tue, Aug 09, 2011 at 12:30:52PM -0700, An-Cheng Huang wrote: > These patches implement the setxattr, getxattr, and removexattr syscalls. > Since libattr uses indirect syscalls for these, the fix for the indirect > syscall handling on MIPS is needed for these to work. > > An

[Qemu-devel] [PATCH 3/3] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-08-09 Thread An-Cheng Huang
This patch implements the setxattr, getxattr, and removexattr syscalls if CONFIG_ATTR is enabled. Note that since libattr uses indirect syscalls for these, this change depends on the fix for indirect syscall handling on MIPS. Signed-off-by: An-Cheng Huang --- linux-user/syscall.c | 54

[Qemu-devel] [PATCH 2/3] linux-user: Verify MIPS syscall arguments

2011-08-09 Thread An-Cheng Huang
On MIPS, some syscall arguments are taken from the stack. This patch adds verification such that do_syscall() is only invoked if all arguments have been successfully taken from the stack. Signed-off-by: An-Cheng Huang --- linux-user/main.c | 22 +- 1 files changed, 17

[Qemu-devel] [PATCH 1/3] linux-user: Fix MIPS indirect syscall handling

2011-08-09 Thread An-Cheng Huang
Change the number of argument for MIPS sys_syscall from 0 to 8. This allows arguments for indirect syscalls to be processed correctly. Signed-off-by: An-Cheng Huang --- linux-user/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/main.c b/linux-user

[Qemu-devel] [PATCH 0/3] linux-user: Implement setxattr/getxattr/removexattr syscalls

2011-08-09 Thread An-Cheng Huang
These patches implement the setxattr, getxattr, and removexattr syscalls. Since libattr uses indirect syscalls for these, the fix for the indirect syscall handling on MIPS is needed for these to work. An-Cheng Huang (3): linux-user: Fix MIPS indirect syscall handling linux-user: Verify MIPS

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix indirect syscall handling for MIPS

2011-08-05 Thread An-Cheng Huang
On Fri, Aug 05, 2011 at 10:27:21AM +0100, Peter Maydell wrote: > On 5 August 2011 01:05, An-Cheng Huang wrote: > > Ok the following patch changes the number of arguments for sys_syscall > > to 8 in mips_syscall_args and also skips the do_syscall() call if any > > of the get_u

Re: [Qemu-devel] [PATCH 1/2] linux-user: Fix indirect syscall handling for MIPS

2011-08-05 Thread An-Cheng Huang
On Fri, Aug 05, 2011 at 10:27:21AM +0100, Peter Maydell wrote: > On 5 August 2011 01:05, An-Cheng Huang wrote: > > Ok the following patch changes the number of arguments for sys_syscall > > to 8 in mips_syscall_args and also skips the do_syscall() call if any > > of the get_u

Re: [Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread An-Cheng Huang
On Thu, Aug 04, 2011 at 11:43:31PM +0100, Peter Maydell wrote: > On 4 August 2011 23:16, An-Cheng Huang wrote: > > A simpler approach would be to just change the number of arguments for > > sys_syscall to 8 in the mips_syscall_args table so that for indirect > > syscalls t

[Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread An-Cheng Huang
t_user() fails", I don't know if this may cause breakage when the arguments are not actually there? If someone can confirm that this is harmless, the simple approach is probably better? Thanks. Signed-off-by: An-Cheng Huang --- linux-user/main.c | 21 ++--- 1