gt;
> v2:
> - added Richard W.M. Jones Tested-by tag
> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)
>
> Regards,
>
> Phil.
>
> PD: I missed Amarnath Valluri in my first series, you might want to add
> yourself
> a R: tag in MAINTAINTERS.
>
&g
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused methods:
- tpm_backend_get_desc()
- TPMDriverOps->handle_startup_error
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lur
tem-x86_64 \
[...] \
-chardev socket,id=chrtpm,path=/tmp/swtpm-sock \
-tpmdev emulator,id=tpm0,chardev=chrtpm \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 13 +-
hmp.c | 5 +
hw/tpm/Mak
removed it.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 62 +---
hw/tpm/tpm_passthrough.c | 58 ++---
include/sysemu/tpm_backend.
buffer reallocation is very unlikely to be backend specific. Hence move inside
the tis.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
hw/tpm/tpm_tis.c
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 15 +++--
hw/tpm/tpm_passthrough.c | 51
ter
- Address review comments maded by Stefan Berger
** Changes in v7:
- rebased agianst latest master
- Rewritten emulater backend using chardev backend
** Changes in v[89]:
- Address review comments maded by Stefan Berger and Marc-Andre
- Removed unneeded had_startup_error() method from TPMDriverO
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André
e the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 16 ++--
hw/tpm/tpm_passthrough.c | 31 ---
include/s
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused methods:
- tpm_backend_get_desc()
- TPMDriverOps->handle_startup_error
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lur
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 15 +++--
hw/tpm/tpm_passthrough.c | 51
tem-x86_64 \
[...] \
-chardev socket,id=chrtpm,path=/tmp/swtpm-sock \
-tpmdev emulator,id=tpm0,chardev=chrtpm \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 13 +-
hmp.c | 5 +
hw/tpm/Mak
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions
86_64 \
[...] \
-chardev socket,id=chrtpm,path=/tmp/swtpm-sock \
-tpmdev emulator,id=tpm0,chardev=chrtpm \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 5 +
hw/tpm/Makefile.objs | 1
removed it.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 62 +---
hw/tpm/tpm_passthrough.c | 58 ++---
include/sysemu/tpm_backend.
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 22 +--
hmp.c| 7 ++---
hw/tpm
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused tpm_backend_get_desc() method
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c
buffer reallocation is very unlikely to be backend specific. Hence move inside
the tis.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
hw/tpm/tpm_tis.c
ter
- Address review comments maded by Stefan Berger
** Changes in v7:
- rebased agianst latest master
- Rewritten emulater backend using chardev backend
Amarnath Valluri (8):
tpm-backend: Remove unneeded member variable from backend class
tpm-backend: Move thread handling inside TPMBackend
tpm
e the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 16 ++--
hw/tpm/tpm_passthrough.c | 31 ---
include/s
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André
On Tue, 2017-07-25 at 20:18 -0400, Stefan Berger wrote:
> On 07/18/2017 04:49 AM, Amarnath Valluri wrote:
> > diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs
> > index 64cecc3..41f0b7a 100644
> > --- a/hw/tpm/Makefile.objs
> > +++ b/hw/tpm/Makefile.objs
>
On Tue, 2017-07-18 at 05:08 -0700, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jul 18, 2017 at 1:49 AM, Amarnath Valluri
> wrote:
> > This change introduces a new TPM backend driver that can communicate with
> > swtpm(software TPM emulator) using unix domain socket inter
On Tue, 2017-07-18 at 10:15 +, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jul 18, 2017 at 10:48 AM Amarnath Valluri
> wrote:
>
> This allows backend implementations left optional interface
> methods.
> For mandatory method
On Tue, 2017-07-18 at 09:28 -0500, Eric Blake wrote:
> On 07/18/2017 05:39 AM, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Jul 18, 2017 at 1:49 AM, Amarnath Valluri
> > wrote:
> >> TPM configuration options are backend implementation details and
igned-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 21 ++
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c | 973 ++
hw/tpm/tpm_ioctl.h| 243 +
qapi-schema.json | 41 ++-
qemu-optio
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions(+), 59 deletions(-)
diff --git a
buffer reallocation is very unlikely to be backend specific. Hence move inside
the tis.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
hw/tpm/tpm_tis.c | 14
Thank Stefan for your comments, i sent the newer version of the patchset
by addressing all your comments.
- Amarnath
On Wed, 2017-07-12 at 14:24 -0400, Stefan Berger wrote:
> On 06/05/2017 08:45 AM, Amarnath Valluri wrote:
> > This change introduces a new TPM backend driver that can co
gianst latest master
- Address review comments maded by Stefan Berger
Amarnath Valluri (8):
tpm-backend: Remove unneeded member variable from backend class
tpm-backend: Move thread handling inside TPMBackend
tpm-backend: Initialize and free data members in it's own methods
tpm-ba
removed it.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 62 +---
hw/tpm/tpm_passthrough.c | 58 ++---
include/sysemu/tpm_backend.
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 22 +--
hmp.c| 6 ++---
hw/tpm
e the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 16 ++--
hw/tpm/tpm_passthrough.c | 31 ---
include/s
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused methods:
tpm_backend_get_type()
tpm_backend_get_desc()
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André
buffer reallocation is very unlikely to be backend specific. Hence move inside
the tis.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
hw/tpm/tpm_tis.c | 14
iew comments made by Stefan Berger and Deniel P Berrange
** Changes in v4:
- Moved realloc_buffer() to TIS model
- Made TpmInfo related change backwards compatible.
** Changes in v5:
- updated Reviewed-By: tag to git commits
- added migration blocker to TPM emulator backend
Amarnath Valluri (8):
e the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 16 ++--
hw/tpm/tpm_passthrough.c | 31 ---
include/s
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions(+), 59 deletions(-)
diff --git a
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused methods:
tpm_backend_get_type()
tpm_backend_get_desc()
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan
igned-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 21 ++
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c | 973 ++
hw/tpm/tpm_ioctl.h| 243 +
qapi-schema.json | 41 ++-
qemu-optio
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
Reviewed-by: Stefan Berger
---
backends/tpm.c | 22 +--
hmp.c| 6 ++---
hw/tpm
removed it.
Signed-off-by: Amarnath Valluri
Reviewed-by: Marc-André Lureau
Reviewed-by: Stefan Berger
---
backends/tpm.c | 62 +---
hw/tpm/tpm_passthrough.c | 58 ++---
include/sysemu/tpm_backend.
igned-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 21 ++
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c | 950 ++
hw/tpm/tpm_ioctl.h| 243 +
qapi-schema.json | 41 ++-
qemu-optio
iew comments made by Stefan Berger and Deniel P Berrange
** Changes in v4:
- Moved realloc_buffer() to TIS model
- Made TpmInfo related change backwards compatible.
Amarnath Valluri (8):
tpm-backend: Remove unneeded member variable from backend class
tpm-backend: Move thread handling inside TPMB
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused methods:
tpm_backend_get_type()
tpm_backend_get_desc()
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 36
removed it.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 62 +---
hw/tpm/tpm_passthrough.c | 58 ++---
include/sysemu/tpm_backend.h | 32 +
include/sysemu/tpm_backend_
buffer reallocation is very unlikely to be backend specific. Hence move inside
the tis.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
hw/tpm/tpm_tis.c | 14 --
include/sysemu/tpm_backend.h
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 22 +--
hmp.c| 6 ++---
hw/tpm/tpm_passthrough.c | 64
e the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 16 ++--
hw/tpm/tpm_passthrough.c | 31 ---
include/sysemu/tpm_backend.h | 7 ---
tpm.c
Signed-off-by: Amarnath Valluri
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions(+), 59 deletions(-)
diff --git a/hw/tpm/tpm_passthrough.c b/hw
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
---
hw/tpm
On 05/04/2017 03:28 PM, Stefan Berger wrote:
On 05/02/2017 07:52 AM, Amarnath Valluri wrote:
Briefly, Theses set of patches introduces:
- new TPM backend driver to support software TPM emulators(swtpm(1)).
- and few supported fixes/enhancements/cleanup to existing tpm
backend code
igned-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 21 ++
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c | 950 ++
hw/tpm/tpm_ioctl.h| 243 +
qapi-schema.json | 41 ++-
qemu-optio
buffer reallocation is very unlikely to be backend specific. Hence move inside
the tis.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
hw/tpm/tpm_tis.c | 14 --
include/sysemu/tpm_backend.h
return
configured tpm options.
A new tpm backend api - tpm_backend_query_tpm() which uses _get_tpm_options() to
prepare TpmInfo.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 22 +--
hmp.c| 6 ++---
hw/tpm/tpm_passthrough.c | 64
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Took the opportunity to remove unused methods:
tpm_backend_get_type()
tpm_backend_get_desc()
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 36
On 05/02/2017 06:54 PM, Marc-André Lureau wrote:
Hi
On Tue, May 2, 2017 at 3:53 PM Amarnath Valluri
mailto:amarnath.vall...@intel.com>> wrote:
Provide base implementation of realloc_buffer(), so that backend
implementations
can resue.
I doubt that base class facility he
On 05/02/2017 04:35 PM, Eric Blake wrote:
On 05/02/2017 06:52 AM, Amarnath Valluri wrote:
TPM configuration options are backend implementation details and shall not be
part of base TPMBackend object, and these shall not be accessed directly outside
of the class, hence added a new interface
On 05/02/2017 03:29 PM, Marc-André Lureau wrote:
On Tue, May 2, 2017 at 3:52 PM Amarnath Valluri
mailto:amarnath.vall...@intel.com>> wrote:
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Signed-
Signed-off-by: Amarnath Valluri
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions(+), 59 deletions(-)
diff --git a/hw/tpm/tpm_passthrough.c b/hw
\
[...] \
-tpmdev emulator,id=tpm0,tpmstatedir=/tmp/mytpm,logfile=/tmp/swtpm.log \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 21 ++
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c
all backend implementations to define their tpm configuration
options.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 24 ++--
hmp.c| 10
hw/tpm/tpm_passthrough.c | 54 +++-
include
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 24 ++--
hw/tpm/tpm_passthrough.c | 16
2 files changed, 18 insertions(+), 22
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
---
hw/tpm
Provide base implementation of realloc_buffer(), so that backend implementations
can resue.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
2 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/backends/tpm.c b
e the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 16 ++--
hw/tpm/tpm_passthrough.c | 31 ---
include/sysemu/tpm_backend.h | 7 ---
tpm.c
iew comments made by Stefan Berger and Deniel P Berrange
Amarnath Valluri (8):
tpm-backend: Remove unneeded member variable from backend class
tpm-backend: Move thread handling inside TPMBackend
tpm-backend: Initialize and free data members in it's own methods
tpm-backend: Made few interfa
removed it.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 62 +---
hw/tpm/tpm_passthrough.c | 58 ++---
include/sysemu/tpm_backend.h | 32 +
include/sysemu/tpm_backend_
On 04/25/2017 09:59 PM, Stefan Berger wrote:
On 04/07/2017 10:30 AM, Amarnath Valluri wrote:
As TPMBackend is a Qemu Object, we can use object_unref() inplace of
tpm_backend_destroy() to free the backend object, hence removed
destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath
On 04/25/2017 09:59 PM, Eric Blake wrote:
On 04/25/2017 01:51 PM, Stefan Berger wrote:
+++ b/qapi-schema.json
@@ -5140,6 +5140,16 @@
{ 'command': 'query-tpm-types', 'returns': ['TpmType'] }
##
+# @TPMOptions:
+#
+# Base type for TPM options
+#
+# Since: 2.10
+##
+{ 'struct': 'TPMOption
On 04/25/2017 09:27 PM, Stefan Berger wrote:
On 04/07/2017 10:30 AM, Amarnath Valluri wrote:
Initialize and free TPMBackend data members in it's own
instance_init() and
instance_finalize methods.
Took the opportunity to fix object cleanup in
tpm_backend_{create,destroy}
methods
S
On 07.04.2017 18:11, Marc-André Lureau wrote:
Hi
On Fri, Apr 7, 2017 at 4:41 PM Daniel P. Berrange
> +.name = "data-path",
> +.type = QEMU_OPT_STRING,
> +.help = "Socket path to use for data exhange",
> +},
> +{
> +.name = "ctrl-
On 07.04.2017 17:41, Daniel P. Berrange wrote:
On Fri, Apr 07, 2017 at 05:30:31PM +0300, Amarnath Valluri wrote:
This change introduces a new TPM backend driver that can communicate with
swtpm(software TPM emulator) using unix domain socket interface.
Swtpm uses two unix sockets, one for
Signed-off-by: Amarnath Valluri
---
hw/tpm/tpm_passthrough.c | 64
hw/tpm/tpm_util.c| 25 +++
hw/tpm/tpm_util.h| 4 +++
3 files changed, 34 insertions(+), 59 deletions(-)
diff --git a/hw/tpm/tpm_passthrough.c b/hw
all backend implementations to define their tpm configuration
options.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 24 +--
hmp.c| 10
hw/tpm/tpm_passthrough.c | 57 +++-
include
As TPMBackend is a Qemu Object, we can use object_unref() inplace of
tpm_backend_destroy() to free the backend object, hence removed destroy() from
TPMDriverOps interface.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 11 ---
hw/tpm/tpm_passthrough.c | 14
Provide base implementation of realloc_buffer(), so that backend implementations
can resue.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 9 -
hw/tpm/tpm_passthrough.c | 12
2 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/backends/tpm.c b
\
[...] \
-tpmdev emulator,id=tpm0,tpmstatedir=/tmp/mytpm,logfile=/tmp/swtpm.log \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 15 +-
hmp.c | 21 ++
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c
removed it.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 63 +---
hw/tpm/tpm_passthrough.c | 58 +---
include/sysemu/tpm_backend.h | 32
include/sysemu/tpm_backend_
This allows backend implementations left optional interface methods.
For mandatory methods assertion checks added.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 28 +---
hw/tpm/tpm_passthrough.c | 16
2 files changed, 21 insertions
Initialize and free TPMBackend data members in it's own instance_init() and
instance_finalize methods.
Took the opportunity to fix object cleanup in tpm_backend_{create,destroy}
methods
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 8 ++--
hw/tpm/tpm_passthrough.c
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
---
hw/tpm
) https://github.com/stefanberger/swtpm
2) https://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg00089.html
** Changes in V2:
- Made spawnning swtpm optional
- used QIOChannel instead of plain unix sockets
- incorporated other fixes pointed in v1 review
Amarnath Valluri (9):
tpm-back
On 03.04.2017 20:07, Daniel P. Berrange wrote:
On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote:
Briefly, Theses set of patches introduces:
- new TPM backend driver to support software TPM emulators(swtpm(1)).
- and few supported fixes/enhancements/cleanup to existing tpm
On 04.04.2017 13:56, Marc-André Lureau wrote:
Hi
On Fri, Mar 31, 2017 at 5:04 PM Amarnath Valluri
mailto:amarnath.vall...@intel.com>> wrote:
Move thread handling inside TPMBackend, this way backend
implementations need
not to maintain their own thread life cycle, instea
implementations to define their tpm configuration
options.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 12 ++
hw/tpm/tpm_passthrough.c | 55 +++-
include/sysemu/tpm_backend.h | 15 ++--
qapi-schema.json
inition to
tpm_backend_int.h. As handle_request() method is internal to TPMBackend and its
derived classes, and shall not be visible for others.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 66 ++--
hw/tpm/tpm_passthrough.c
\
[...] \
-tpmdev emulator,id=tpm0,tpmstatedir=/tmp/mytpm,logfile=/tmp/swtpm.log \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 6 +
hmp.c | 14 +
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c
\
[...] \
-tpmdev emulator,id=tpm0,tpmstatedir=/tmp/mytpm,logfile=/tmp/swtpm.log \
-device tpm-tis,tpmdev=tpm0 \
[...]
Signed-off-by: Amarnath Valluri
---
configure | 6 +
hmp.c | 14 +
hw/tpm/Makefile.objs | 1 +
hw/tpm/tpm_emulator.c
m/stefanberger/swtpm
2) https://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg00089.html
Amarnath Valluri (7):
tpm-backend: Remove unneeded member variable from backend class
tpm-backend: Move thread handling inside TPMBackend
tpm-backend: Initialize and free data members in it's
Initialize and free TPMBackend data members in it's own instance_init() and
instance_finalize methods.
Took the opportunity to fix object cleanup in tpm_backend_destroy() method
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 14 +-
hw/tpm/tpm_passthrough.c
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend was, to get the
backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is
present.
Signed-off-by: Amarnath Valluri
---
hw/tpm
, get_tpm_options() to TPMDriverOps., which shall be implemented
by the derived classes to return configured tpm options.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 12 ++
hw/tpm/tpm_passthrough.c | 55 +++-
include/sysemu
This allows backend implementations left optional interface methods.
Signed-off-by: Amarnath Valluri
---
backends/tpm.c | 22 ++
hw/tpm/tpm_passthrough.c | 16
2 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/backends/tpm.c b
Signed-off-by: Amarnath Valluri
---
hw/tpm/tpm_passthrough.c | 77
hw/tpm/tpm_util.c| 60 +
hw/tpm/tpm_util.h| 8 +
3 files changed, 73 insertions(+), 72 deletions(-)
diff --git a/hw/tpm
98 matches
Mail list logo
