Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-30 Thread Alison Schofield
On Wed, Apr 17, 2024 at 03:50:52PM +0800, Shiyang Ruan wrote: > The length of Physical Address in General Media Event Record/DRAM Event > Record is 64-bit, so the field mask should be defined as such length. > Otherwise, this causes cxl_general_media and cxl_dram tracepoints to > mask off the upper

Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-23 Thread Alison Schofield
On Wed, Apr 17, 2024 at 03:50:52PM +0800, Shiyang Ruan wrote: > The length of Physical Address in General Media Event Record/DRAM Event > Record is 64-bit, so the field mask should be defined as such length. > Otherwise, this causes cxl_general_media and cxl_dram tracepoints to > mask off the upper

Re: [RFC PATCH v2 0/6] cxl: add poison event handler

2024-03-29 Thread Alison Schofield
On Fri, Mar 29, 2024 at 11:22:32AM -0700, Dan Williams wrote: > Alison Schofield wrote: > [..] > > Upon receipt of that new poison list, call memory_failture_queue() > > on *any* poison in a mapped space. Is that OK? Can we call > > memory_failure_queue() on any and every

Re: [RFC PATCH v2 6/6] cxl/core: add poison injection event handler

2024-03-29 Thread Alison Schofield
On Fri, Mar 29, 2024 at 02:36:14PM +0800, Shiyang Ruan wrote: > Currently driver only traces cxl events, poison injection (for both vmem > and pmem type) on cxl memdev is silent. OS needs to be notified then it > could handle poison range in time. Per CXL spec, the device error event > could be s

Re: [RFC PATCH v2 4/6] cxl/core: report poison when injecting from debugfs

2024-03-29 Thread Alison Schofield
On Fri, Mar 29, 2024 at 02:36:12PM +0800, Shiyang Ruan wrote: > Poison injection from debugfs is silent too. Add calling > cxl_mem_report_poison() to make it able to do memory_failure(). Curious as to why it is silent? Will a GMER poison event occur and trigger the path to report it via memory_fa

Re: [RFC PATCH v2 0/6] cxl: add poison event handler

2024-03-29 Thread Alison Schofield
On Fri, Mar 29, 2024 at 02:36:08PM +0800, Shiyang Ruan wrote: > Changes: > RFCv1 -> RFCv2: > 1. update commit message of PATCH 1 > 2. use memory_failure_queue() instead of MCE > 3. also report poison in debugfs when injecting poison > 4. correct DPA->HPA logic: > find memdev's endpoint decoder

Re: [PATCH v2 0/6] hw/cxl: Poison get, inject, clear

2023-03-01 Thread Alison Schofield
On Mon, Feb 27, 2023 at 05:03:05PM +, Jonathan Cameron wrote: Hi Jonathan, Can you share your repo with this support? How about your qemu cmdline? I'm more of a 'try it out' type of a reviewer for qemu changes. Thanks, Alison > v2: Thanks to Ira for review and also to Philippe as some of the

Re: [PATCH] docs/cxl: Fix some typos

2022-11-07 Thread Alison Schofield
On Mon, Nov 07, 2022 at 10:09:23AM -0800, Davidlohr Bueso wrote: > Found while reading the doc. > > Signed-off-by: Davidlohr Bueso > --- > docs/system/devices/cxl.rst | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/docs/system/devices/cxl.rst b/docs/system/

Re: [PATCH v8 19/46] hw/cxl/device: Add some trivial commands

2022-03-18 Thread Alison Schofield
On Fri, Mar 18, 2022 at 03:06:08PM +, Jonathan Cameron wrote: > From: Ben Widawsky > > GET_FW_INFO and GET_PARTITION_INFO, for this emulation, is equivalent to > info already returned in the IDENTIFY command. To have a more robust > implementation, add those. > > Signed-off-by: Ben Widawsky