Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-21 Thread Alessandro Di Federico via
current_cpu->stop = true; softmmu/memory.c:return current_cpu->cpu_index; softmmu/runstate.c:current_cpu->crash_occurred = true; Maybe you envision more stuff in cpu-exec-softmmu.c. Reviewed-by: Alessandro Di Federico -- Alessandro Di Federico rev.ng Labs

Re: [PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alessandro Di Federico via
On Wed, 15 Mar 2023 17:43:29 + Alex Bennée wrote: > +rev.ng revng Can we have "rev.ng Labs"? I suggested this in my previous e-mail too, but maybe it slipped away. -- Alessandro Di Federico rev.ng Labs

Re: [PATCH v2 08/10] contrib/gitdm: add revng to domain map

2023-03-10 Thread Alessandro Di Federico via
On Fri, 10 Mar 2023 18:03:30 + Alex Bennée wrote: > +rev.ng revng Please use "rev.ng Labs". Thanks! Reviewed-by: Alessandro Di Federico -- Alessandro Di Federico rev.ng Labs

Re: [RFC] Reducing NEED_CPU_H usage

2023-01-12 Thread Alessandro Di Federico via
accel/tcg/user-exec.c accel/tcg/user-exec-stub.c accel/tcg/plugin-gen.c plugins/loader.c plugins/core.c plugins/api.c They are subset of `arch_srcs` from `meson.build`. Making them target agnostic for *-user too should be easy and could save some build time. But yeah, we'll now focus on system-mode. We'll now try to sort out things from the easiest to the most complex and start send out patches. Thanks a lot for your valuable insights! -- Alessandro Di Federico rev.ng Labs

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
a reason why this is not viable that I'm not seeing. -- Alessandro Di Federico rev.ng Labs

Re: [RFC PATCH] docs: add some details about compilation units to coding style

2023-01-03 Thread Alessandro Di Federico via
Makes sense to me. Reviewed-by: Alessandro Di Federico On Tue, 3 Jan 2023 10:47:58 + Alex Bennée wrote: > +"Templates" and generated code > +== > + > +We make heavy use of C's macro facilities combined with multiple > +inclusion t

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
other hand an actual invocation of configure can take significantly longer (`./configure` takes 29.150s on my machine). To avoid re-running it every time we could invoke `make update-buildoptions` in `configure` but keep `scripts/meson-buildoptions.sh` in the build directory. -- Alessandro Di Federico rev.ng Labs

[PATCH] Update scripts/meson-buildoptions.sh

2023-01-02 Thread Alessandro Di Federico via
ildoptions Signed-off-by: Alessandro Di Federico --- scripts/meson-buildoptions.sh | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh index aa6e30ea911..0f71e92dcba 100644 --- a/scripts/meson-build

Re: [PULL 17/21] target/hexagon: prepare input for the idef-parser

2022-12-31 Thread Alessandro Di Federico via
on_options.txt make update-buildoptions # Actually makes changes Also, AFAIU the `update-buildoptions` target is not available in ninja. However maybe this is not a bug since the doc says to use make. Anyway, patch coming soon! -- Alessandro Di Federico rev.ng Labs

Re: [PATCH 1/1] target/hexagon: work around unused variable in yyparser

2022-12-31 Thread Alessandro Di Federico via
looking into this though. -- Alessandro Di Federico rev.ng Labs

[RFC] Reducing NEED_CPU_H usage

2022-12-28 Thread Alessandro Di Federico via
ut fail linking qemu-x86_64 This process required commenting a lot of code, it's not supposed to work at all and it's quite ugly. However, it has been very useful since it enabled us to use the compiler to discover what is problematic. Sorry for the wall of text. Enjoy the last few days of 2022! -- Alessandro Di Federico rev.ng Labs

Re: [PATCH] target/hexagon/idef-parser: fix two typos in README

2022-12-28 Thread Alessandro Di Federico via
On Tue, 27 Dec 2022 17:49:04 -0300 Matheus Tavares Bernardino wrote: > Signed-off-by: Matheus Tavares Bernardino > --- > target/hexagon/idef-parser/README.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Alessandro Di Federico Thanks f

[PATCH v2] target/hexagon: suppress unused variable warning

2022-12-21 Thread Alessandro Di Federico via
absence of `-Wextra`. Signed-off-by: Alessandro Di Federico Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Taylor Simpson Tested-by: Taylor Simpson --- target/hexagon/idef-parser/idef-parser.y | 2 ++ target/hexagon/meson.build | 1 - 2 files

[PATCH] target/hexagon: suppress unused variable warning

2022-12-21 Thread Alessandro Di Federico via
absence of `-Wextra`. Signed-off-by: Alessandro Di Federico --- target/hexagon/idef-parser/idef-parser.y | 2 ++ target/hexagon/meson.build | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef-parser

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
t wanted to be overly zealous. Flags typically used by QEMU are fine. Shall I send a patch to drop -Wextra? -- Alessandro Di Federico rev.ng Labs

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Mon, 19 Dec 2022 18:54:22 + Taylor Simpson wrote: > > Applied, thanks. > > Thanks!! Thanks from our side too! :) We started this project back in 2015, I'm really happy we finally got it in! -- Alessandro Di Federico rev.ng Labs

Re: Any interest in a QEMU emulation BoF at KVM Forum?

2022-09-01 Thread Alessandro Di Federico via
h you in Dublin and thanks again for setting this up. -- Alessandro Di Federico rev.ng Labs

Re: [PATCH v6 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-30 Thread Alessandro Di Federico via
ng we can do to improve the situation (other than adding gmail.com to our SPF record), let me know. -- Alessandro Di Federico rev.ng Labs

CI for qemu-hexagon

2022-01-05 Thread Alessandro Di Federico via
t despite the failure and then it will be taken care of, or should I make a separate (preliminary) pull request just for that patch? -- Alessandro Di Federico rev.ng commit 14e90d55b368b4a56fde668b66311bab6e1a4518 Author: Paolo Montesel Date: Thu Dec 9 13:23:06 2021 +0100 target/hexagon: im

Re: QEMU CI failure of cross-i386-* targets (meson picks wrong glib for native target)

2021-12-29 Thread Alessandro Di Federico via
ockerfiles/fedora-i386-cross.docker:ENV QEMU_CONFIGURE_OPTS --cpu=i386 --disable-vhost-user I can try to set `--cross-prefix=x86_64-redhat-linux-` but I guess this will prevent certain tests to run (given the cross-compile environment). I'll give it a shot. -- Alessandro Di Federico rev.ng Labs Srl

QEMU CI failure of cross-i386-* targets (meson picks wrong glib for native target)

2021-12-24 Thread Alessandro Di Federico via
f7e933a58b1bb1c3668ff4cff#8145a41027f26ff426d5a2c8b00c56f227943165_198_202 Happy holidays! -- Alessandro Di Federico rev.ng Labs Srl

[PATCH v6 12/12] gitlab-ci: do not use qemu-project Docker registry

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit is necessary in order to use container built by the current run of the CI. If we don't do this, we use official containers which are not affected by the additional dependencies we're introducing. This should be considered as a temporary solutio

[PATCH v6 08/12] target/hexagon: import lexer for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 258 +++ target/hexagon/idef-parser/idef-parser.lex| 642 ++ target/hexagon/meson.build| 4 + tests/docker

[PATCH v6 00/12] target/hexagon: introduce idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the sixth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the

[PATCH v6 07/12] target/hexagon: prepare input for the idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 153

[PATCH v6 10/12] target/hexagon: call idef-parser functions

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico Reviewed-by: Taylor Simpson --- target/hexagon/gen_helper_funcs.py | 5 +- target/hexagon/gen_helper_protos.py | 5

[PATCH v6 02/12] target/hexagon: import README for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/idef-parser/README.rst | 447 ++ target/hexagon/README | 5 + 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v6 09/12] target/hexagon: import parser for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/parser-helpers.h | 346 +++ target/hexagon/idef-parser/parser-helpers.c | 2396 + target/hexagon/idef-parser/idef-parser.y | 975 +++ target

[PATCH v6 11/12] target/hexagon: import additional tests

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 30 +- tests/tcg/hexagon/crt.S| 26 tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_bitcnt.S| 42

[PATCH v6 04/12] target/hexagon: make helper functions non-static

2021-07-20 Thread Alessandro Di Federico via
generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/genptr.h| 30 +++ target/hexagon/op_helper.h | 37 target/hexagon/genptr.c| 59

[PATCH v6 03/12] target/hexagon: make slot number an unsigned

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson --- target/hexagon/macros.h | 2 +- target/hexagon/genptr.c | 24 +--- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/target/hexagon

[PATCH v6 06/12] target/hexagon: expose next PC in DisasContext

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/translate.h | 1 + target/hexagon/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target

[PATCH v6 05/12] target/hexagon: introduce new helper functions

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.h | 15 +- target/hexagon/macros.h | 9 target/hexagon/genptr.c | 113

[PATCH v6 01/12] target/hexagon: update MAINTAINERS for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Reviewed-by: Richard Henderson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4256ad1adb..6c825a9eb4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,6 +194,8

Re: [PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-07-08 Thread Alessandro Di Federico via
main QEMU > registry, which almost always has suitable cached content. I understand. This patch was aimed at pointing out a problem more than offering a proper solution. I'll try and take a look at how to do this right, but I think this outside the scope of this patchset (and my area of expertise). -- Alessandro Di Federico rev.ng

Re: [PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-07-05 Thread Alessandro Di Federico via
t; > + > > +HexValue gen_extract_op(Context *c, > > +YYLTYPE *locp, > > +HexValue *source, > > +HexValue *index, > > + HexExtract *extract) { > > What's the difference between this ant the gen_rextract_op above? As before. -- Alessandro Di Federico rev.ng

Re: [PATCH v5 13/14] target/hexagon: import additional tests

2021-07-05 Thread Alessandro Di Federico via
directives I can probably make a single executable out of them, but it's not superelegant. For the rest, I've dropped several outdated comments and superflous tests. Thanks for looking into this. -- Alessandro Di Federico rev.ng

Re: [PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-06-29 Thread Alessandro Di Federico via
On Sat, 19 Jun 2021 11:37:13 +0200 Alessandro Di Federico wrote: > From: Alessandro Di Federico > > This commit is necessary in order to use container built by the > current run of the CI. If we don't do this, we use official > containers which are not affected by the add

Re: [PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-06-29 Thread Alessandro Di Federico via
est); > > +OUT(c, locp, ", ", &width_orig, ", ", &zero, ", ", &res, ", ", > > dest, > > +");\n"); > > + > > +rvalue_free(c, locp, &zero); > > +rvalue_free(c, locp, width); > > +rvalu

Re: [PATCH v5 03/14] target/hexagon: import README for idef-parser

2021-06-24 Thread Alessandro Di Federico via
force the parser not to emit a particular > instruction (i.e., fall back on the reference implementation)? Yes, see `gen_idef_parser_funcs.py`. -- Alessandro Di Federico rev.ng

[PATCH v5 13/14] target/hexagon: import additional tests

2021-06-19 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 36 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S

[PATCH v5 03/14] target/hexagon: import README for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v5 12/14] target/hexagon: remove unused macros and functions

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/gen_tcg.h | 528 - target/hexagon/genptr.c| 98 --- target/hexagon/macros.h| 200 +- target/hexagon/op_helper.c | 119

[PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit is necessary in order to use container built by the current run of the CI. If we don't do this, we use official containers which are not affected by the additional dependencies we're introducing. Signed-off-by: Alessandro Di Federico --- .g

[PATCH v5 02/14] target/hexagon: update MAINTAINERS for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Reviewed-by: Richard Henderson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7d9cd29042..7fd32062be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -192,6 +192,8

[PATCH v5 11/14] target/hexagon: call idef-parser functions

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_helper_funcs.py | 5 ++- target/hexagon/gen_helper_protos.py | 5 ++- target/hexagon

[PATCH v5 05/14] target/hexagon: make helper functions non-static

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson --- target/hexagon

[PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 961 +++ target/hexagon/idef-parser/parser-helpers.c | 2396 + target/hexagon/idef-parser/parser-helpers.h | 347 +++ target

[PATCH v5 04/14] target/hexagon: make slot number an unsigned

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon

[PATCH v5 09/14] target/hexagon: import lexer for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 262 target/hexagon/idef-parser/idef-parser.lex| 597 ++ target/hexagon/meson.build| 4 + tests

[PATCH v5 00/14] target/hexagon: introduce idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the fifth iteration of the patchset and includes fixes suggested in previous iterations. This patchset also drops some macro overrides that are no longer necessary, since the instructions they

[PATCH v5 08/14] target/hexagon: prepare input for the idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 153

[PATCH v5 07/14] target/hexagon: expose next PC in DisasContext

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target

[PATCH v5 06/14] target/hexagon: introduce new helper functions

2021-06-19 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 163 target/hexagon/genptr.h | 23 ++ target/hexagon/macros.h

[PATCH v5 01/14] tcg: expose TCGCond manipulation routines

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101

Re: [PATCH v4 06/12] target/hexagon: introduce new helper functions

2021-04-19 Thread Alessandro Di Federico via
rchive/html/qemu-devel/2021-04/msg01353.html > > - load into shifted register > https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01359.html > > Alessandro, what do you think? If, for an instruction, all idef-parse does is calling an helper, yeah, it make

[PATCH v4 07/12] target/hexagon: expose next PC in DisasContext

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index

[PATCH v4 01/12] tcg: expose TCGCond manipulation routines

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101

[PATCH v4 04/12] target/hexagon: make slot number an unsigned

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 7481f4c1dd

[PATCH v4 02/12] target/hexagon: update MAINTAINERS for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36055f14c5..158badbd18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -193,11 +193,19 @@ Hexagon TCG CPUs M: Taylor

[PATCH v4 11/12] target/hexagon: call idef-parser functions

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10

[PATCH v4 10/12] target/hexagon: import parser for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 947 +++ target/hexagon/idef-parser/parser-helpers.c | 2374 + target/hexagon/idef-parser/parser-helpers.h | 347 +++ target

[PATCH v4 09/12] target/hexagon: import lexer for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 254 target/hexagon/idef-parser/idef-parser.lex| 611 ++ target/hexagon/meson.build| 4 + tests

[PATCH v4 12/12] target/hexagon: import additional tests

2021-04-15 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 36 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S

[PATCH v4 06/12] target/hexagon: introduce new helper functions

2021-04-15 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 188 target/hexagon/genptr.h | 22 + target/hexagon/macros.h

[PATCH v4 08/12] target/hexagon: prepare input for the idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 150

[PATCH v4 05/12] target/hexagon: make helper functions non-static

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 7 --- target

[PATCH v4 00/12] target/hexagon: introduce idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the fourth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part o

[PATCH v4 03/12] target/hexagon: import README for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v3 10/12] target/hexagon: import parser for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 940 +++ target/hexagon/idef-parser/parser-helpers.c | 2230 + target/hexagon/idef-parser/parser-helpers.h | 344 +++ target

[PATCH v3 11/12] target/hexagon: call idef-parser functions

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10

[PATCH v3 06/12] target/hexagon: introduce new helper functions

2021-03-30 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 173 target/hexagon/genptr.h | 17 target/hexagon/macros.h | 9

[PATCH v3 12/12] target/hexagon: import additional tests

2021-03-30 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 35 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S

[PATCH v3 08/12] target/hexagon: prepare input for the idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 150

[PATCH v3 02/12] target/hexagon: update MAINTAINERS for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 554be84b32..13de7ecc36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,11 +194,19 @@ Hexagon TCG CPUs M: Taylor

[PATCH v3 00/12] target/hexagon: introduce idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the third iteration of the patchset and includes fixes suggested in the previous iteration. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part o

[PATCH v3 04/12] target/hexagon: make slot number an unsigned

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 7481f4c1dd

[PATCH v3 09/12] target/hexagon: import lexer for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 240 +++ target/hexagon/idef-parser/idef-parser.lex| 611 ++ target/hexagon/meson.build| 4 + tests/docker

[PATCH v3 07/12] target/hexagon: expose next PC in DisasContext

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index

[PATCH v3 03/12] target/hexagon: import README for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v3 01/12] tcg: expose TCGCond manipulation routines

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101

[PATCH v3 05/12] target/hexagon: make helper functions non-static

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 7 --- target

Re: [PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-03-18 Thread Alessandro Di Federico via
the CPU state in the commit phase. -- Alessandro Di Federico rev.ng

Re: [PATCH v2 08/10] target/hexagon: import parser for idef-parser

2021-03-01 Thread Alessandro Di Federico via
nother reason to *not* preprocess with macros.inc, nor > sed the output as a workaround for your parsing troubles. Yes, `sed` is a workaround I really don't like too. But preprocessing with `cpp` saves us from having to handle a larger, redundant language. After all, the input language is designed to be expanded through the preprocessor, although with a different set of macros. I'd keep that part. -- Alessandro Di Federico rev.ng

Re: [PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-03-01 Thread Alessandro Di Federico via
neficial, but overall we deem it would increase the complexity of the parser with limited return. -- Alessandro Di Federico rev.ng

Re: [PATCH v2 09/10] target/hexagon: call idef-parser functions

2021-03-01 Thread Alessandro Di Federico via
On Thu, 25 Feb 2021 19:47:04 -0800 Richard Henderson wrote: > On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > > +elif hex_common.is_new_val(regtype, regid, tag): > > +declared.append("%s%sN" % (regtype,regid)) > > +else:

Re: [PATCH 0/4] hexagon: Add Docker image & testing to gitlab-ci

2021-03-01 Thread Alessandro Di Federico via
On Sun, 28 Feb 2021 23:23:10 +0100 Philippe Mathieu-Daudé wrote: > This series is a rework of the 'Add Dockerfile for hexagon' patch > from Alessandro/Brian that Taylor sent in v8: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html > but adapted to mainstre

[PATCH v2 10/10] target/hexagon: import additional tests

2021-02-25 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 35 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/first.S | 24 ++-- tests/tcg/hexagon/test_abs.S

[PATCH v2 07/10] target/hexagon: import lexer for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 245 +++ target/hexagon/idef-parser/idef-parser.lex| 647 ++ target/hexagon/meson.build| 4 + tests/docker

Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread Alessandro Di Federico via
. > > (5) There's an odd mismatch in file naming, in which you have > idef-lexer.lex.yy.c but idef-parser.yy.h. Not a bug, really, but it > looks odd when fixing 3 & 4. We've integrated the suggested changes and tested the v2 on the Gitlab CI. It should now work properly. -- Alessandro Di Federico rev.ng

Re: [RFC PATCH 08/10] target/hexagon: import parser for idef-parser

2021-02-25 Thread Alessandro Di Federico via
On Sun, 14 Feb 2021 08:56:11 -0800 Richard Henderson wrote: > What version of bison are you using? We were using a rather recent version of bison (3.7.5), but it's not strictly required. Fixed in v2. -- Alessandro Di Federico rev.ng

[PATCH v2 08/10] target/hexagon: import parser for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 1250 +++ target/hexagon/idef-parser/parser-helpers.c | 1925 + target/hexagon/idef-parser/parser-helpers.h | 293

[PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v2 09/10] target/hexagon: call idef-parser functions

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10

[PATCH v2 05/10] target/hexagon: expose next PC in DisasContext

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 4 +++- target/hexagon/translate.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index

[PATCH v2 04/10] target/hexagon: introduce new helper functions

2021-02-25 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 227 +++- target/hexagon/genptr.h | 19 target/hexagon/macros.h | 2

[PATCH v2 06/10] target/hexagon: prepare input for the idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 target/hexagon/idef-parser/macros.inc | 166

[PATCH v2 01/10] target/hexagon: update MAINTAINERS for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..9a6878b970 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -192,11 +192,19 @@ Hexagon TCG CPUs M: Taylor

[PATCH v2 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the second iteration of the patchset and includes fixes suggested in the previous iteration. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part o

[PATCH v2 03/10] target/hexagon: make helper functions non-static

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 13 ++--- target

  1   2   >