Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

Hi Gerd, On Thu, Sep 6, 2012 at 12:15 PM, Gerd Hoffmann wrote: > Hi, > >> usb-next will fail to compile using -Werror with: >> hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’: >> hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used >> [-Werror=unused-but-set-variable] > > Fixed. > >

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

Gerd, On Tue, Sep 4, 2012 at 3:30 PM, Gerd Hoffmann wrote: > On 08/30/12 14:49, Alejandro Martinez Ruiz wrote: >> Some xHC drivers (most notably on Windows and BSD systems) read >> the first capability registers using 1 and 2 bytes accesses, since >> this is how they are d

[Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

controller. As this is an exception to the general 4-byte aligned accesses rule, we special-case the code path for capability reading and implement checks to guard against wrong size/alignment combinations. Signed-off-by: Alejandro Martinez Ruiz --- hw/usb/hcd-xhci.c | 75

[Qemu-devel] [PATCH] ehci: fix assertion typo

Signed-off-by: Alejandro Martinez Ruiz --- hw/usb/hcd-ehci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index b043e7c..104c21d 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2010,7 +2010,7 @@ static void ehci_fill_queue