Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-28 Thread Adrian Moreno
On 3/1/21 2:36 AM, Cindy Lu wrote: > On Mon, Mar 1, 2021 at 4:40 AM Michael S. Tsirkin wrote: >> >> On Thu, Feb 25, 2021 at 02:14:39PM -0500, Michael S. Tsirkin wrote: >>> On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: While peer is vdpa, sometime qemu get an all zero mac addres

Re: [PATCH] vhost-user: save features of multiqueues if chardev is closed

2020-09-23 Thread Adrian Moreno
Thanks Haibin, On 9/22/20 5:27 AM, haibinzhang(张海斌) wrote: > Fore-commit(c6beefd674) only saves features of queue0, > this makes wrong features of other queues in multiqueues > situation. > For examples: > qemu-system-aarch64 ... \ > -chardev socket,id=charnet0,path=/var/run/vhost_sock \ >

[PATCH] vhost-user: only set slave channel for first vq

2020-01-21 Thread Adrian Moreno
When multiqueue is enabled, a vhost_dev is created for each queue pair. However, only one slave channel is needed. Fixes: 4bbeeba023f2 (vhost-user: add slave-req-fd support) Cc: marcandre.lur...@redhat.com Signed-off-by: Adrian Moreno --- hw/virtio/vhost-user.c | 8 +--- 1 file changed, 5

[PATCH v3] vhost-user: save features if the char dev is closed

2019-09-24 Thread Adrian Moreno
event) Cc: ddstr...@canonical.com Cc: Michael S. Tsirkin Signed-off-by: Adrian Moreno --- net/vhost-user.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index 51921de443..014199d600 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -235,6 +235,10

[Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed

2019-09-18 Thread Adrian Moreno
event) Cc: ddstr...@canonical.com Cc: Michael S. Tsirkin Signed-off-by: Adrian Moreno --- net/vhost-user.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index 51921de443..014199d600 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -235,6 +235,10

Re: [Qemu-devel] [PATCH] vhost-user: save features if the char dev is closed

2019-09-18 Thread Adrian Moreno
On 9/17/19 11:40 PM, Michael S. Tsirkin wrote: > On Tue, Sep 17, 2019 at 09:19:01PM +0200, Adrian Moreno wrote: >> That way the state can be correctly restored when the device is opened >> again. This might happen if the backend is restarted. >> >> Buglink: https://bugzi

[Qemu-devel] [PATCH] vhost-user: save features if the char dev is closed

2019-09-17 Thread Adrian Moreno
event) Cc: ddstr...@canonical.com Cc: Michael S. Tsirkin Signed-off-by: Adrian Moreno --- net/vhost-user.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index 51921de443..acf20cb9e0 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -235,6