Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add brackets to `if` statements

2018-02-24 Thread
Hi, when I try to change `while (cond) ;` to `while (cond) { }` checkpatch.pl complains about this: ''' ERROR: suspect code indent for conditional statements (8, 8) #1506: FILE: uri.c:1506: +while ((*tmp++ = *segp++) != 0) { [...] +} ERROR: suspect code indent for conditional sta

Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add brackets to `if` statements

2018-02-24 Thread
Thanks for your comments :) I will pay more attention to what you point out. "Eric Blake" wrote: > On 02/23/2018 03:34 AM, Thomas Huth wrote: > > On 23.02.2018 08:51, Su Hang wrote: > >> Add brackets that wrap `if`, `else`, `while` that hold single > >> statements. > >> > >> In order to do this, I

Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add brackets to `if` statements

2018-02-23 Thread
Thanks for your reply. ^_^ I will apply all your suggestion in my next patch. > -Original Messages- > From: "Thomas Huth" > Sent Time: 2018-02-23 17:34:12 (Friday) > To: "Su Hang" , stefa...@redhat.com > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add