Re: [Qemu-devel] [PATCH v3 4/6] target/s390x: Implement LOAD PAIR DISJOINT

2017-05-10 Thread Éric Bischoff
ll is not necessary. That said, it doesn't hurt > either. Merci pour la relecture Aurélien. Richard, what do we do? We remove the potential_page_fault(s); or not? -- Éric Bischoff

Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

2017-02-28 Thread Éric Bischoff
Le mardi 28 février 2017, 06:10:45 CET Richard Henderson a écrit : > On 02/27/2017 10:22 PM, Eric Bischoff wrote: > > From: Eric Bischoff > > > > LPD = LOAD PAIR DISJOINT > > --- > > > > target/s390x/insn-data.def | 4 +++- > > target/s390x/translate.c | 21 + > > 2 files

Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

2017-02-27 Thread Éric Bischoff
Le samedi 25 février 2017, 10:42:43 CET Richard Henderson a écrit : > On 02/23/2017 10:58 PM, Eric Bischoff wrote: > > +/* LOAD PAIR DISJOINT */ > > +C(0xc804, LPD, SSF, ILA, m1_32s, m2_32s, 0, r3_P32, movx, 0) > > +C(0xc805, LPDG,SSF, ILA, m1_64, m2_64, 0, r3_P64, movx, 0) > >

Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

2017-02-26 Thread Éric Bischoff
the alter- nate path. Therefore I think that setting CC = 0 is the correct emulation. I assumed that putting 0 in last column of C() macro was the way to set CC = 0. I apologize if that was wrong, and if so, please tell me, and I'll correct. Best, -- Éric Bischoff