Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-10 Thread Eric Auger
Hi Gustavo, Alex, On 5/28/25 12:33 PM, Igor Mammedov wrote: > On Tue, 27 May 2025 15:54:15 +0200 > Eric Auger wrote: > >> Hi Igor, >> >> On 5/27/25 1:58 PM, Igor Mammedov wrote: >>> On Tue, 27 May 2025 09:40:04 +0200 >>> Eric Auger wrote: >>> acpi_pcihp VirtMachineClass state flag will al

Re: [PULL 16/31] i386/kvm: Prefault memory on page state change

2025-06-10 Thread Xiaoyao Li
On 6/11/2025 2:12 PM, Paolo Bonzini wrote: On Wed, Jun 11, 2025 at 4:56 AM Xiaoyao Li wrote: Paolo, This one is not supposed to be pulled until we fix KVM as you said: https://lore.kernel.org/qemu-devel/d0983ba3-383b-4c81-9cfd-b5b0d26a5...@redhat.com/ The bug was understood and fix just a f

Re: [PATCH 02/10] loongarch: add virt feature avecintc support

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: LoongArchVirtMachinState add avecintc features, and it use to check whether virt machine support advance interrupt controller and default is on. Signed-off-by: Song Gao --- hw/loongarch/virt.c | 31 +++ include/hw/lo

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-10 Thread Eric Auger
Hi Igor, On 5/27/25 1:58 PM, Igor Mammedov wrote: > On Tue, 27 May 2025 09:40:04 +0200 > Eric Auger wrote: > >> acpi_pcihp VirtMachineClass state flag will allow >> to opt in for acpi pci hotplug. This is guarded by a >> class no_acpi_pcihp flag to manage compats (<= 10.0 >> machine types will no

Re: [PATCH 06/10] hw/loongarch: Implement avec controller imput and output pins

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: the AVEC controller supports 256*256 irqs, all the irqs connect CPU INT_AVEC irq Signed-off-by: Song Gao --- hw/intc/loongarch_avec.c | 28 hw/loongarch/virt.c | 11 +-- target/loongarch/cpu.h | 3 ++- 3 fi

Re: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

2025-06-10 Thread Yi Liu
On 2025/6/11 10:42, Zhenzhong Duan wrote: Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). For the people who has a doubt how the size is sizeof(PCIDevice). :) * @instance_size: The size of the object (derivative of #Object). If * @instance_size is 0, then the si

Re: [PATCH 07/10] hw/loongarch: connect pch_msi controller to avec controller

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: Signed-off-by: Song Gao --- hw/loongarch/virt.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 718b5b4f92..6b670e7936 100644 --- a/hw/loongarch/virt.c +++ b/hw/loong

Re: [PATCH v5 7/7] vhost-user-devive: Add shmem BAR

2025-06-10 Thread Alyssa Ross
Subject should say vhost-user-devi*c*e signature.asc Description: PGP signature

Re: [PATCH v5 3/7] vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec

2025-06-10 Thread Alyssa Ross
Albert Esteve writes: > Add SHMEM_MAP/_UNMAP request to the vhost-user > spec documentation. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Albert Esteve > --- > docs/interop/vhost-user.rst | 55 + > 1 file changed, 55 insertions(+) > > diff --git a/docs/

Re: [PATCH 08/10] hw/loongarch: Implement avec set_irq

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: Signed-off-by: Song Gao --- hw/intc/loongarch_avec.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/hw/intc/loongarch_avec.c b/hw/intc/loongarch_avec.c index c692fef43c..f609ed9aaa 100644 --- a/

Re: [PATCH v2 00/11] migration: Some enhancements and cleanups for 10.1

2025-06-10 Thread Mario Casquero
This series has been successfully tested. The information displayed from the HMP info migrate command is more user-friendly, with the possibility of displaying the globals with info migrate -a. (qemu) info migrate -a Status: active Sockets: [ tcp ] Globals: store-global-state: on only-m

Re: [PULL 16/31] i386/kvm: Prefault memory on page state change

2025-06-10 Thread Paolo Bonzini
On Wed, Jun 11, 2025 at 4:56 AM Xiaoyao Li wrote: > > Paolo, > > This one is not supposed to be pulled until we fix KVM as you said: > https://lore.kernel.org/qemu-devel/d0983ba3-383b-4c81-9cfd-b5b0d26a5...@redhat.com/ The bug was understood and fix just a few days away, so I included it. I'll se

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Sertonix
On Wed Jun 11, 2025 at 6:07 AM CEST, Michael Tokarev wrote: > On 10.06.2025 23:36, Sertonix wrote: >> On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: >>> On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. >>> >>> Why

RE: [PATCH v5 2/7] ui/spice: Add an option for users to provide a preferred codec

2025-06-10 Thread Kasireddy, Vivek
Hi Daniel, > Subject: Re: [PATCH v5 2/7] ui/spice: Add an option for users to provide a > preferred codec > > On Tue, Jun 10, 2025 at 03:30:24PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Fri, Jun 6, 2025 at 11:16 AM Daniel P. Berrangé > > wrote: > > > > > On Fri, Jun 06, 2025 at 06:10:31

Re: [PATCH qemu v7 1/1] target/riscv: Add Zilsd and Zclsd extension support

2025-06-10 Thread Alistair Francis
On Thu, May 15, 2025 at 2:07 PM ~liuxu wrote: > > From: lxx <1733205...@qq.com> > > This patch adds support for the Zilsd and Zclsd extension, > which is documented at https://github.com/riscv/riscv-zilsd/releases/tag/v1.0 > > Co-developed-by: SUN Dongya > Co-developed-by: LIU Xu > Co-developed-

Re: [PATCH v2 0/1] Add RISCV ZALASR Extension

2025-06-10 Thread Alistair Francis
On Tue, Jun 10, 2025 at 6:33 PM Roan Richmond wrote: > > Ping, resending as no responses in over week. > > V2: > - rebased patch onto master branch > - added check for RV64() for Load Double, as pointed out by Alistair Palmer. > > In response to Alistair Palmer > (https://lists.gnu.org/archiv

Re: [PATCH v2 1/1] Add RISCV ZALASR extension

2025-06-10 Thread Alistair Francis
On Tue, Jun 10, 2025 at 6:33 PM Roan Richmond wrote: > > This is based on version v0.8.3 of the ZALASR specification [1]. > The specification is listed as in Frozen state [2]. > > [1]: https://github.com/riscv/riscv-zalasr/tree/v0.8.3 > [2]: > https://lf-riscv.atlassian.net/wiki/spaces/HOME/pages

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Michael Tokarev
On 10.06.2025 23:36, Sertonix wrote: On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. Why do you think -pie causes it to become dynamically linked? /mjt The documentat

Re: [PATCH 09/10] target/loongarch: loongarch CPU supoort avec irqs

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: Signed-off-by: Song Gao --- target/loongarch/cpu-csr.h | 1 + target/loongarch/cpu.c | 17 + 2 files changed, 18 insertions(+) diff --git a/target/loongarch/cpu-csr.h b/target/loongarch/cpu-csr.h index 0834e91f30..83f6cb081a 100644

Re: [PATCH] MAINTAINERS: Drop the defunct mail address from Yoshinori Sato

2025-06-10 Thread Yoshinori Sato
My email is becoming a black hole. This email address cannot be used to send patches, so we will prepare a different email address and update it. 2025年6月10日(火) 21:01 Thomas Huth : > From: Thomas Huth > > The OSDN / sourceforge.jp site ceased to work (according to > https://en.wikipedia.org/wiki/

Re: [PATCH 10/10] target/loongarch: cpu do interrupt support msg interrupt.

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: we use CSR_ESTAT and CSR_ECFG bit 15 for msg interrupt. and loongarch_cpu_do_interrupt support msg interrupts. Signed-off-by: Song Gao --- target/loongarch/cpu-csr.h | 3 ++- target/loongarch/cpu.c | 35 ++- 2 files

Re: [PULL 16/31] i386/kvm: Prefault memory on page state change

2025-06-10 Thread Xiaoyao Li
Paolo, This one is not supposed to be pulled until we fix KVM as you said: https://lore.kernel.org/qemu-devel/d0983ba3-383b-4c81-9cfd-b5b0d26a5...@redhat.com/ BTW, I have sent the KVM fix: https://lore.kernel.org/all/20250611001018.2179964-1-xiaoyao...@intel.com/ On 6/6/2025 8:34 PM, Paolo Bonz

[PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

2025-06-10 Thread Zhenzhong Duan
Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same structure as base class VFIO_PCI_BASE, so no need to set its instance_size explicitly. This isn't catastrophic only because VFIO_PCI_BASE is an abstract class. Fixes: d4

Re: [PATCH 4/5] configure: Add dtc option

2025-06-10 Thread BALATON Zoltan
On Tue, 10 Jun 2025, Bernhard Beschow wrote: The next patch will make dtc mandatory for boards with a bundled DTB, causing these boards to be omitted when dtc is missing. Allow packagers to force the build of those boards by providing an option. I don't like this. This might result in some mach

Re: [PATCH 3/5] scripts/meson-buildoptions: Sort coroutine_backend choices lexicographically

2025-06-10 Thread BALATON Zoltan
On Tue, 10 Jun 2025, Bernhard Beschow wrote: When changing meson_options.txt, this script gets updated automatically by QEMU tooling which sorts the choices lexicographically. Fix this in preparation of the ext patch. Typo: next patch Fixes: ccc403ed5844 ("meson: Add wasm build in build scrip

Re: [PATCH v2 21/21] fuse: Increase MAX_WRITE_SIZE with a second buffer

2025-06-10 Thread Brian
Hi all, I'm currently working on the fuse over io_uring feature for QEMU FUSE export. When I submit SQEs to the /dev/fuse file descriptor during the register phase, the kernel returns an error (in the fuse_uring_create_ring_ent()). It seems this is because the payload size (i.e. spillover_buf siz

[PATCH v3 2/2] migration: Support fd-based socket address in cpr_transfer_input

2025-06-10 Thread Jaehoon Kim
Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened socket file descriptors for cpr migration channels. This change is particularly useful in qtest environments, where the socket may be created externally and p

[PATCH v3 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread Jaehoon Kim
When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection failures when running tests. This patch creates and listens on the socket in advance, and p

Fixing my email inbox

2025-06-10 Thread John Snow
My employer, er, switched to a certain mail host some number of years ago and I never really actually acclimated properly. As a result of that and, uh, my laziness, I've accumulated ... quite a backlog of mail I have not really read or dealt with. It's become unmanageable. I'm trying to fix that.

Re: [PATCH v3 02/23] vfio: enable per-IRQ MSI-X masking

2025-06-10 Thread John Levon
On Fri, Jun 06, 2025 at 05:10:34PM -0700, John Levon wrote: > If VFIO_IRQ_INFO_MASKABLE is set for VFIO_PCI_MSIX_IRQ_INDEX, record > this in ->can_mask_msix, and use it to individually mask MSI-X > interrupts as needed. I'm just going to drop this patch. Neither vfio nor libvfio-user (including q

Re: Controlling time in QEMU

2025-06-10 Thread Pierrick Bouvier
On 6/6/25 12:03 PM, Pierrick Bouvier wrote: Hi, I recently needed to slow down time within a virtual machine, due to a timeout being hit because my QEMU binary which was not fast enough (gcov debug build if you're curious about the use case). Currently, people tend to use -icount shift=X with l

[PATCH 1/2] qemu/timer: introduce time dilation factor

2025-06-10 Thread Pierrick Bouvier
This factor is applied to time spent since we read clock for the first time. It impacts value returned by get_clock() and get_clock_realtime(). Signed-off-by: Pierrick Bouvier --- include/qemu/timer.h | 22 -- util/qemu-timer-common.c | 1 + 2 files changed, 17 insertion

[PATCH 2/2] system/rtc: introduce -rtc time-dilation option

2025-06-10 Thread Pierrick Bouvier
This option sets a factor on time spent for QEMU clocks since the beginning of execution. It can be used to slow or accelerate time for a guest, without impacting QEMU speed. Signed-off-by: Pierrick Bouvier --- system/rtc.c| 11 +++ system/vl.c | 3 +++ qemu-options.hx | 7

[PATCH 0/2] control guest time using a dilation factor

2025-06-10 Thread Pierrick Bouvier
Depending on host cpu speed, and QEMU optimization level, it may sometimes be needed to slow or accelerate time guest is perceiving. A common scenario is hitting a timeout during a boot process, because some operations were not finished on time. An existing solution for that is -icount shift=X, wi

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-10 Thread Peter Xu
On Tue, Jun 10, 2025 at 05:55:31PM -0300, Fabiano Rosas wrote: > I think I caused some confusion here. I wrote migrate_params_override() > last thing on a friday and forgot it did the right thing from the > beginning: > > migrate_params_apply(&s->defaults); > qmp_migrate_set_parameters(new

Re: Embed QEMU terminal into GUI application (Cubic - Custom Ubuntu ISO Creator)

2025-06-10 Thread Bernhard Beschow
Am 9. Juni 2025 17:22:32 UTC schrieb PJ Singh : >Hello Everyone, > >I want to embed a QEMU window directly in my GUI application. Are Python >APIs available to embed QEMU into a GNOME GUI application? > >I am the developer of Cubic (Custom Ubuntu ISO Creator), a tool which >allows users to custo

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-10 Thread Bernhard Beschow
Am 12. Mai 2025 15:32:08 UTC schrieb Paolo Bonzini : >Hi, now that GSoC selection is over I'm back. Sorry for the delay; >Tanish Desai will work mostly on tracing, so logging can remain yours. > >On Tue, Apr 8, 2025 at 10:59 PM Bernhard Beschow wrote: >> >Currently the #defines contain some hol

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-10 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 09, 2025 at 04:41:06PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Jun 09, 2025 at 03:02:06PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Mon, Jun 09, 2025 at 11:37:02AM -0300, Fabiano Rosas wrote: >> >> >> Peter Xu w

Re: [PULL 36/58] pc-bios: Move device tree files in their own subdir

2025-06-10 Thread Bernhard Beschow
Am 4. Juni 2025 09:59:44 UTC schrieb Bernhard Beschow : > > >Am 3. Juni 2025 11:38:59 UTC schrieb Thomas Huth : >>On 03/06/2025 08.39, Bernhard Beschow wrote: >>> >>> >>> Am 2. Juni 2025 08:12:39 UTC schrieb "Philippe Mathieu-Daudé" >>> : On 30/5/25 02:54, BALATON Zoltan wrote: > On

[PATCH 2/5] pc-bios/dtb/meson: Prefer target name to be outfile, not infile

2025-06-10 Thread Bernhard Beschow
Makes this custom_target() usage consistent with other ones in QEMU. Fixes: 6e0dc9d2a88a ("meson: compile bundled device trees") Signed-off-by: Bernhard Beschow --- pc-bios/dtb/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/dtb/meson.build b/pc-bios/dtb/m

[PATCH 0/5] DTB build housekeeping

2025-06-10 Thread Bernhard Beschow
This series removes the bundled device tree blobs from the repository which are redundant to the bundled device tree sources. To make this work, the device tree compiler 'dtc' is now required for the boards which rely on these device trees. Building these board can be enforced with a 'dtc' build op

[PATCH 1/5] hw: Fix type constant for DTB files

2025-06-10 Thread Bernhard Beschow
Commit fcb1ad456c58 ("system/datadir: Add new type constant for DTB files") introduced a new type constant for DTB files and converted the boards with bundled device trees to use it. Convert the other boards for consistency. Fixes: fcb1ad456c58 ("system/datadir: Add new type constant for DTB files

[PATCH 4/5] configure: Add dtc option

2025-06-10 Thread Bernhard Beschow
The next patch will make dtc mandatory for boards with a bundled DTB, causing these boards to be omitted when dtc is missing. Allow packagers to force the build of those boards by providing an option. Signed-off-by: Bernhard Beschow --- meson.build | 12 Kconfig.ho

[PATCH 3/5] scripts/meson-buildoptions: Sort coroutine_backend choices lexicographically

2025-06-10 Thread Bernhard Beschow
When changing meson_options.txt, this script gets updated automatically by QEMU tooling which sorts the choices lexicographically. Fix this in preparation of the ext patch. Fixes: ccc403ed5844 ("meson: Add wasm build in build scripts") Signed-off-by: Bernhard Beschow --- scripts/meson-buildoptio

[PATCH 5/5] configure: Require dtc for boards with bundled device trees

2025-06-10 Thread Bernhard Beschow
Avoid having generated DTBs checked in which can become inconsistent with their sources. Note that when dtc is not found, the boards with bundled DTBs will be omitted from the build. Finding dtc, and thus building these boards, can be enforced with the `dtc` build option. Signed-off-by: Bernhard

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Michael Tokarev
On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. Why do you think -pie causes it to become dynamically linked? /mjt

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Sertonix
On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: > On 10.06.2025 20:58, Sertonix wrote: >> >> Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. > > Why do you think -pie causes it to become dynamically linked? > > /mjt The documentation (at least for gcc) states

[PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-10 Thread Bernhard Beschow
A log_mask!() macro is provided which expects similar arguments as the C version. However, the formatting works as one would expect from Rust. To maximize code reuse the macro is just a thin wrapper around qemu_log(). Also, just the bare minimum of logging masks is provided which should suffice fo

[PATCH v2 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-06-10 Thread Bernhard Beschow
Now that there is logging support in Rust for QEMU, use it in the pl011 device. Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.r

[PATCH v2 0/2] Initial logging support for Rust

2025-06-10 Thread Bernhard Beschow
This series introduces a log_mask! macro which is inspired by the C version and is just a thin wrapper around qemu_log(). It caters to Rust expectations by accepting an enum for logging categories and working like the format! macro. The macro then gets used in the pl011 device which either had its

Re: [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing

2025-06-10 Thread John Snow
On Tue, Jun 10, 2025 at 8:40 AM Peter Krempa wrote: > On Wed, Mar 19, 2025 at 17:28:06 +0100, Peter Krempa wrote: > > New python doesn't like '\l' escapes from the 'dot' language. > > > > While at it improve usability of the script by employing proper argument > > parsing. > > > > v2: > > - use

[PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Sertonix
Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. By using -static-pie it will be linked statically like other bios. This ensures that the build output doesn't change depending on the default dynamic loader path of the toolchain. Ref d884c86dcd3b s390/bios: Make the s390-

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Steven Sistare
On 6/10/2025 12:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 04, 2025 at 03:48:40PM +0200, Cédric Le Goater wrote: I don't see any advantage to making this a class attribute.  I looked for examples of using such attributes for vfio to configure pci, and found very little.  It sounds like overki

[ANNOUNCE] SeaBIOS 1.17.0

2025-06-10 Thread Kevin O'Connor via
The 1.17.0 version of SeaBIOS has now been released. For more information on the release, please see: https://seabios.org/Releases New in this release: * Prefer PCI IO allocations above 4Gig on 64bit capable machines. * Multiple simultaneous USB keyboard and mouse support. * Legacy support for

Re: [QEMU PATCH v3 6/9] cxl-mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-06-10 Thread Jonathan Cameron via
On Fri, 6 Jun 2025 09:27:05 -0700 Fan Ni wrote: > On Thu, Jun 05, 2025 at 11:42:20PM +, anisa.su...@gmail.com wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section > > 7.6.7.6.3 > > > > Signed-off-by: Anisa Su > > --- > > One minor co

Re: [PATCH v3 03/23] vfio: add per-region fd support

2025-06-10 Thread John Levon
On Tue, Jun 10, 2025 at 09:42:41AM +0200, Cédric Le Goater wrote: > > @@ -478,9 +491,14 @@ void vfio_device_unprepare(VFIODevice *vbasedev) > > for (i = 0; i < vbasedev->num_regions; i++) { > > g_free(vbasedev->reginfo[i]); > > +if (vbasedev->region_fds != NULL && vbasedev-

Re: [PATCH V5.1] pci: skip reset during cpr

2025-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2025 at 10:26:43AM -0700, Steve Sistare wrote: > Do not reset a vfio-pci device during CPR. > > Signed-off-by: Steve Sistare Acked-by: Michael S. Tsirkin > --- > hw/pci/pci.c | 5 + > hw/vfio/pci.c| 7 +++ > include/hw/pci/pci.h | 2 ++ > 3 files chang

Re: [PATCH] migration/postcopy: Add latency distribution report for blocktime

2025-06-10 Thread Fabiano Rosas
Peter Xu writes: > Add the latency distribution too for blocktime, using order-of-two buckets. > It accounts for all the faults, from either vCPU or non-vCPU threads. With > prior rework, it's very easy to achieve by adding an array to account for > faults in each buckets. > > Sample output for

Re: [RFC PATCH v13 0/4] Report vfio-ap configuration changes

2025-06-10 Thread Cédric Le Goater
On 6/9/25 18:44, Rorie Reyes wrote: Changelog: v13: - added lock to 'vfio_ap_cfg_chg_notifier_handler' in patch 2 - added RBs for patch 2 and 3 from Tony v12: - adding locks to 'ap_chsc_sei_nt0_have_event' and 'ap_chsc_sei_nt0_get_event' v11: - reverted return type to int for 'ap_chsc_sei_nt0_g

Re: [PATCH V5 00/38] Live update: vfio and iommufd

2025-06-10 Thread Cédric Le Goater
Steve, For the next vfio PR, I plan to take patches 1-17 when patch 10 is updated. The rest is for later in this cycle Applied 1-17 to vfio-next. Waiting for an Ack from Michael. Thanks, C.

Re: [PATCH v3 01/23] vfio: export PCI helpers needed for vfio-user

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: The vfio-user code will need to re-use various parts of the vfio PCI code. Export them in hw/vfio/pci.h, and rename them to the vfio_pci_* namespace. Signed-off-by: John Levon --- hw/vfio/pci.h| 11 ++ hw/vfio/pci.c| 48 +

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread JAEHOON KIM
On 6/10/2025 12:05 PM, Daniel P. Berrangé wrote: On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote: When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This c

[PATCH V5.1] pci: skip reset during cpr

2025-06-10 Thread Steve Sistare
Do not reset a vfio-pci device during CPR. Signed-off-by: Steve Sistare --- hw/pci/pci.c | 5 + hw/vfio/pci.c| 7 +++ include/hw/pci/pci.h | 2 ++ 3 files changed, 14 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 9b4bf48..c70b5ce 100644 --- a/hw/pci/pci.c

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread JAEHOON KIM
On 6/10/2025 11:02 AM, Peter Xu wrote: On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote: When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread JAEHOON KIM
On 6/10/2025 12:09 PM, Daniel P. Berrangé wrote: On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote: When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote: > When the source VM attempts to connect to the destination VM's Unix > domain socket (cpr.sock) during a cpr-transfer test, race conditions can > occur if the socket file isn't ready. This can lead to connection > failures when running t

[PATCH V5 17/38] vfio/pci: export MSI functions

2025-06-10 Thread Steve Sistare
Export various MSI functions, renamed with a vfio_pci prefix, for use by CPR in subsequent patches. No functional change. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater --- hw/vfio/pci.h | 8 hw/vfio/pci.c | 29 + 2 files changed, 25 insertions

[PATCH V5 03/38] vfio/container: register container for cpr

2025-06-10 Thread Steve Sistare
Register a legacy container for cpr-transfer, replacing the generic CPR register call with a more specific legacy container register call. Add a blocker if the kernel does not support VFIO_UPDATE_VADDR or VFIO_UNMAP_ALL. This is mostly boiler plate. The fields to to saved and restored are added

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Cédric Le Goater
On 6/10/25 19:14, Steven Sistare wrote: On 6/10/2025 1:11 PM, Cédric Le Goater wrote: On 6/10/25 19:05, Steven Sistare wrote: On 6/10/2025 12:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 04, 2025 at 03:48:40PM +0200, Cédric Le Goater wrote: I don't see any advantage to making this a class att

Re: [PATCH V5 00/38] Live update: vfio and iommufd

2025-06-10 Thread Cédric Le Goater
On 6/10/25 17:39, Steve Sistare wrote: Support vfio and iommufd devices with the cpr-transfer live migration mode. Devices that do not support live migration can still support cpr-transfer, allowing live update to a new version of QEMU on the same host, with no loss of guest connectivity. No use

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Steven Sistare
On 6/10/2025 1:11 PM, Cédric Le Goater wrote: On 6/10/25 19:05, Steven Sistare wrote: On 6/10/2025 12:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 04, 2025 at 03:48:40PM +0200, Cédric Le Goater wrote: I don't see any advantage to making this a class attribute.  I looked for examples of using

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-10 Thread Pierrick Bouvier
On 6/8/25 1:23 AM, Oleg Tolmatcev wrote: Am So., 8. Juni 2025 um 02:43 Uhr schrieb Pierrick Bouvier : On 6/7/25 2:45 AM, oltolm wrote: Sorry, I forgot to cc the maintainers. The build failed when run on Windows. I replaced calls to Unix programs like ´cat´, ´sed´ and ´true´ with calls to ´pyt

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread JAEHOON KIM
On 6/10/2025 11:57 AM, Steven Sistare wrote: On 6/10/2025 11:08 AM, Jaehoon Kim wrote: When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection f

Re: [PATCH 2/2] watchdog: generic name for i6300esb

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 04:32:59PM +0200, Cornelia Huck wrote: > The Intel 6300 Enterprise SouthBridge is a south bridge for a more or > less obscure embedded Intel system; however, the i6300esb watchdog > device we implement in QEMU is a virtual watchdog device that should > work well on any PCI-b

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Cédric Le Goater
On 6/10/25 19:05, Steven Sistare wrote: On 6/10/2025 12:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 04, 2025 at 03:48:40PM +0200, Cédric Le Goater wrote: I don't see any advantage to making this a class attribute.  I looked for examples of using such attributes for vfio to configure pci, and

Re: [PATCH 1/2] watchdog: CONFIG_WDT_IB6300ESB -> CONFIG_WDT_I6300ESB

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 04:32:58PM +0200, Cornelia Huck wrote: > There's no ib6300esb device; let's correct the typo in the config option. > > Signed-off-by: Cornelia Huck > --- > hw/watchdog/Kconfig | 2 +- > hw/watchdog/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH V5 21/38] migration: cpr_get_fd_param helper

2025-06-10 Thread Steve Sistare
Add the helper function cpr_get_fd_param, to use when preserving a file descriptor that is opened externally and passed to QEMU. cpr_get_fd_param returns a descriptor number either from a QEMU command-line parameter, from a getfd command, or from CPR state. When a descriptor is passed to new QEMU

[PATCH 1/2] watchdog: CONFIG_WDT_IB6300ESB -> CONFIG_WDT_I6300ESB

2025-06-10 Thread Cornelia Huck
There's no ib6300esb device; let's correct the typo in the config option. Signed-off-by: Cornelia Huck --- hw/watchdog/Kconfig | 2 +- hw/watchdog/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/watchdog/Kconfig b/hw/watchdog/Kconfig index 861fd003341d..

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Cédric Le Goater
On 6/10/25 18:31, Michael S. Tsirkin wrote: On Wed, Jun 04, 2025 at 03:48:40PM +0200, Cédric Le Goater wrote: I don't see any advantage to making this a class attribute.  I looked for examples of using such attributes for vfio to configure pci, and found very little.  It sounds like overkill si

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote: > When the source VM attempts to connect to the destination VM's Unix > domain socket (cpr.sock) during a cpr-transfer test, race conditions can > occur if the socket file isn't ready. This can lead to connection > failures when running t

Re: [PATCH 00/31] Skip automatic zero-init of large arrays / structs in I/O paths

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 05:00:43PM +0200, Philippe Mathieu-Daudé wrote: > On 10/6/25 14:56, Daniel P. Berrangé wrote: > > On Tue, Jun 10, 2025 at 02:49:02PM +0200, Philippe Mathieu-Daudé wrote: > > > On 10/6/25 14:36, Daniel P. Berrangé wrote: > > > > This series is an extension of Stefan's proposa

[PATCH V5 32/38] vfio/iommufd: preserve descriptors

2025-06-10 Thread Steve Sistare
Save the iommu and vfio device fd in CPR state when it is created. After CPR, the fd number is found in CPR state and reused. Signed-off-by: Steve Sistare --- backends/iommufd.c| 25 - hw/vfio/cpr-iommufd.c | 10 ++ hw/vfio/device.c | 9 + 3 file

[PATCH V5 18/38] vfio-pci: preserve MSI

2025-06-10 Thread Steve Sistare
Save the MSI message area as part of vfio-pci vmstate, and preserve the interrupt and notifier eventfd's. migrate_incoming loads the MSI data, then the vfio-pci post_load handler finds the eventfds in CPR state, rebuilds vector data structures, and attaches the interrupts to the new KVM instance.

Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread Steven Sistare
On 6/10/2025 11:08 AM, Jaehoon Kim wrote: When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection failures when running tests. This patch creates

[PATCH V5 28/38] vfio/iommufd: device name blocker

2025-06-10 Thread Steve Sistare
If an invariant device name cannot be created, block CPR. Signed-off-by: Steve Sistare --- include/hw/vfio/vfio-cpr.h | 1 + hw/vfio/device.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/hw/vfio/vfio-cpr.h b/include/hw/vfio/vfio-cpr.h index 25e74ee..170a11

[PATCH V5 26/38] vfio/iommufd: invariant device name

2025-06-10 Thread Steve Sistare
cpr-transfer will use the device name as a key to find the value of the device descriptor in new QEMU. However, if the descriptor number is specified by a command-line fd parameter, then vfio_device_get_name creates a name that includes the fd number. This causes a chicken-and-egg problem: new QEM

[PATCH V5 25/38] vfio/iommufd: use IOMMU_IOAS_MAP_FILE

2025-06-10 Thread Steve Sistare
Use IOMMU_IOAS_MAP_FILE when the mapped region is backed by a file. Such a mapping can be preserved without modification during CPR, because it depends on the file's address space, which does not change, rather than on the process's address space, which does change. Signed-off-by: Steve Sistare R

Re: [PATCH 00/31] Skip automatic zero-init of large arrays / structs in I/O paths

2025-06-10 Thread Philippe Mathieu-Daudé
On 10/6/25 14:56, Daniel P. Berrangé wrote: On Tue, Jun 10, 2025 at 02:49:02PM +0200, Philippe Mathieu-Daudé wrote: On 10/6/25 14:36, Daniel P. Berrangé wrote: This series is an extension of Stefan's proposal: https://lists.nongnu.org/archive/html/qemu-devel/2025-06/msg00736.html It used

[PATCH V5 09/38] pci: export msix_is_pending

2025-06-10 Thread Steve Sistare
Export msix_is_pending for use by cpr. No functional change. Signed-off-by: Steve Sistare Acked-by: Michael S. Tsirkin --- include/hw/pci/msix.h | 1 + hw/pci/msix.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h inde

[PATCH V5 14/38] vfio/pci: pass vector to virq functions

2025-06-10 Thread Steve Sistare
Pass the vector number to vfio_connect_kvm_msi_virq and vfio_remove_kvm_msi_virq, so it can be passed to their subroutines in a subsequent patch. No functional change. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater --- hw/vfio/pci.c | 13 +++-- 1 file changed, 7 insertions(

Re: [PATCH v2 08/13] migration/postcopy: Report fault latencies in blocktime

2025-06-10 Thread Peter Xu
On Tue, Jun 10, 2025 at 01:53:40PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Jun 10, 2025 at 12:08:23AM +, Dr. David Alan Gilbert wrote: > > > > diff --git a/qapi/migration.json b/qapi/migration.json > > > > index 4963f6ca12..e95b7402cb 100644 > >

Re: [PATCH 3/3] hw/cxl: Add Physical Port Control (Opcode 5102h)

2025-06-10 Thread Jonathan Cameron via
On Mon, 2 Jun 2025 19:29:42 +0530 Arpit Kumar wrote: Very interesting to see support for this. It will enable a load of additional test cases. > added assert-deassert PERST implementation, reset PPB > for physical port. Added Please also include some details of testing done and what happens.

Re: [PATCH v3 03/23] vfio: add per-region fd support

2025-06-10 Thread John Levon
On Tue, Jun 10, 2025 at 09:42:41AM +0200, Cédric Le Goater wrote: > > @@ -478,9 +491,14 @@ void vfio_device_unprepare(VFIODevice *vbasedev) > > for (i = 0; i < vbasedev->num_regions; i++) { > > g_free(vbasedev->reginfo[i]); > > +if (vbasedev->region_fds != NULL && vbasedev-

[PATCH V5 29/38] vfio/iommufd: register container for cpr

2025-06-10 Thread Steve Sistare
Register a vfio iommufd container and device for CPR, replacing the generic CPR register call with a more specific iommufd register call. Add a blocker if the kernel does not support IOMMU_IOAS_CHANGE_PROCESS. This is mostly boiler plate. The fields to to saved and restored are added in subseque

Re: [QEMU PATCH v3 8/9] cxl-mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-06-10 Thread Jonathan Cameron via
> > > +/* CXL r3.2 Section 7.6.7.6.5 Initiate Dynamic Capacity Add (Opcode > > > 5604h) */ > > > +static CXLRetCode cmd_fm_initiate_dc_add(const struct cxl_cmd *cmd, > > > + uint8_t *payload_in, > > > + size_t len_in

Re: [PATCH 2/3] scripts/qapi: add QAPISchemaIfCond.rsgen()

2025-06-10 Thread Marc-André Lureau
Hi On Thu, Jun 5, 2025 at 2:11 PM Paolo Bonzini wrote: > From: Marc-André Lureau > > Generate Rust #[cfg(...)] guards from QAPI 'if' conditions. > > Signed-off-by: Marc-André Lureau > Link: > https://lore.kernel.org/r/20210907121943.3498701-15-marcandre.lur...@redhat.com > Signed-off-by: Paolo

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread John Levon
On Tue, Jun 10, 2025 at 11:57:00AM +0200, Cédric Le Goater wrote: > > @@ -529,6 +531,8 @@ _meson_option_parse() { > > --disable-vdi) printf "%s" -Dvdi=disabled ;; > > --enable-vduse-blk-export) printf "%s" -Dvduse_blk_export=enabled ;; > > --disable-vduse-blk-export) printf "%s"

[PATCH V5 13/38] vfio/pci: vfio_notifier_init

2025-06-10 Thread Steve Sistare
Move event_notifier_init calls to a helper vfio_notifier_init. This version is trivial, but it will be expanded to support CPR in subsequent patches. No functional change. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater --- hw/vfio/pci.c | 40 +---

Re: [PATCH 1/3] hw/cxl: Storing physical ports info during enumeration

2025-06-10 Thread Jonathan Cameron via
On Mon, 2 Jun 2025 19:29:40 +0530 Arpit Kumar wrote: > Physical ports info is stored for both mailbox cci & > mctp based cci type as per spec CXL r3.2 Table 8-230: Physical Switch > > Signed-off-by: Arpit Kumar Hi Arpit, Sorry for slow response. I got behind on reviews in general and missed t

[PATCH V5 36/38] iommufd: preserve DMA mappings

2025-06-10 Thread Steve Sistare
During cpr-transfer load in new QEMU, the vfio_memory_listener causes spurious calls to map and unmap DMA regions, as devices are created and the address space is built. This memory was already already mapped by the device in old QEMU, so suppress the map and unmap callbacks during incoming CPR.

  1   2   3   >