Re: [PATCH v4 5/7] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-05-24 Thread Dmitry Osipenko
On 5/15/25 05:45, Vivek Kasireddy wrote: > +bool surface_gl_create_texture_from_fd(DisplaySurface *surface, > + int fd, GLuint *texture) > +{ > +unsigned long size = surface_stride(surface) * surface_height(surface); > +GLenum err = glGetError(); > +

Re: [PATCH 0/3] target/hppa: Fix FP exception handling

2025-05-24 Thread Helge Deller
On 5/24/25 12:26, Michael Tokarev wrote: On 17.05.2025 15:00, del...@kernel.org wrote: From: Helge Deller This series fixes and improves the floating point exception handling in the hppa system and user emulation. A testcase is included in patch #3. Please review. Thanks! Helge Helge Deller

Re: [PATCH] roms: re-remove execute bit from hppa-firmware*

2025-05-24 Thread Helge Deller
On 5/19/25 15:45, Daniel P. Berrangé wrote: On Sun, May 18, 2025 at 01:54:20PM -0400, Cole Robinson wrote: This was fixed in c9d77526bddba0803a1fa982fb59ec98057150f9 for 9.2.0 but regressed in db34be329162cf6b06192703065e6c1010dbe3c5 in 10.0.0 When the bit is present, rpmbuild complains about m

[PULL 12/19] ui/gtk: Use consistent naming for variables in different coordinates

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu Now that we've documented definitions and presentation of various coordinates, let's enforce the rules. Signed-off-by: Weifeng Liu Message-ID: <20250511073337.876650-3-weifeng.li...@gmail.com> Acked-by: Gerd Hoffmann Acked-by: Marc-André Lureau --- ui/gtk-egl.c | 12 ++

Re: Using parallel port on the Pegasos 2

2025-05-24 Thread BALATON Zoltan
On Sun, 28 Jul 2024, BALATON Zoltan wrote: On Sun, 28 Jul 2024, quan wrote: I am playing around with the parallel port on the pegasos 2 and I noticed the following issue: The parallel port on startup is set to iobase 0x378, then later it gets remapped to iobase 0x3bc. When I tried writing to the

Re: [PATCH v5 08/25] target/hppa: call plugin trap callbacks

2025-05-24 Thread Julian Ganz
Hi Richard, thanks for the feedback. For some reason only three of your replies made it to my inbox, but I've seen them (on lore.kernel.org) and I will incorporate it. May 24, 2025 at 7:07 PM, Richard Henderson wrote: > On 5/19/25 16:19, Julian Ganz wrote: > > diff --git a/target/hppa/int_helper

Re: [PATCH v5 10/25] target/loongarch: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for loongarch

Re: [PATCH] vfio/pci: Introduce x-pci-class-code option

2025-05-24 Thread Tomita Moeko
On 5/24/25 23:31, Tomita Moeko wrote: > Introduce x-pci-class-code option to allow users to override PCI class > code of a device, similar to the existing x-pci-vendor-id option. Only > the lower 24 bits of this option are used, though a uint32 is used here > for determining whether the value is va

Re: [PATCH v5 20/25] target/sparc: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:20, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for SPARC (32b

Re: [PATCH 0/4] chardev: Fix issues found by vhost-user-test

2025-05-24 Thread Marc-André Lureau
Hi On Fri, May 16, 2025 at 12:21 AM Fabiano Rosas wrote: > > Running vhost-user-test with ASAN on a loaded machine reveals several > intermittent issues. These show up every time I test the qtest tree so > I'm trying to get rid of them. > > 1- UAF of IOWatchPoll. >This one is self explanatory

Re: [PATCH v5 14/25] target/openrisc: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for OpenRISC t

[PULL 13/19] gtk/ui: Introduce helper gd_update_scale

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu The code snippet updating scale_x/scale_y is general and will be used in next patch. Make it a function. Signed-off-by: Weifeng Liu Message-ID: <20250511073337.876650-4-weifeng.li...@gmail.com> Acked-by: Gerd Hoffmann Acked-by: Marc-André Lureau --- include/ui/gtk.h | 2 ++

[PULL 03/19] ui/clipboard: split out QemuClipboardContent

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau Allows to use VMSTATE STRUCT in following migration support patch. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/clipboard.h | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/include/ui/cli

Re: [PATCH v5 21/25] target/tricore: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:20, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places an exception hook fo

Re: [PATCH v5 19/25] target/sh4: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for SuperH tar

[PULL 10/19] ui/vdagent: remove migration blocker

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau Fixes: https://issues.redhat.com/browse/RHEL-81894 Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/vdagent.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index adc8755bd9..c0746fe5b1 100644 --- a/ui/

[PULL 11/19] ui/gtk: Document scale and coordinate handling

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu The existence of multiple scaling factors forces us to deal with various coordinate systems and this would be confusing. It would be beneficial to define the concepts clearly and use consistent representation for variables in different coordinates. Signed-off-by: Weifeng Liu M

[PULL 05/19] ui/clipboard: delay clipboard update when not running

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau When VM is paused, we shouldn't notify of clipboard changes, similar to how input are being treated. On unsuspend, notify of the current state. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/clipboard.c | 40 +++

[PULL 19/19] ui/gtk-egl: Render guest content with padding in fixed-scale mode

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu Scaling was not respected when rendering frames in gtk-egl.c (used if gl=on and X11 mode). To fix this, add fields x and y to struct egl_fb for x offset and y offset so we can add padding to window. Signed-off-by: Weifeng Liu Message-ID: <20250511073337.876650-10-weifeng.li...

[PULL 15/19] ui/sdl: Consider scaling in mouse event handling

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu When using sdl display backend, if the window is scaled, incorrect mouse positions will be reported since scaling is not properly handled. Fix it by transforming the positions from window coordinate to guest buffer coordinate. Signed-off-by: Weifeng Liu Message-ID: <2025051107

[PULL 14/19] ui/gtk: Update scales in fixed-scale mode when rendering GL area

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu When gl=on, scale_x and scale_y were set to 1 on startup that didn't reflect the real situation of the scan-out in free scale mode, resulting in incorrect cursor coordinates to be sent when moving the mouse pointer. Simply updating the scales before rendering the image fixes thi

[PULL 17/19] ui/gtk: Consider scaling when propagating ui info

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu The ui width and height sent to guest is supposed to be in buffer coordinate. Hence conversion is required. If scaling (global window scale and zooming scale) is not respected in non-free-scale mode, window size could keep changing because of the existence of the iteration of t

Re: [PATCH v5 18/25] target/s390x: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for IBM System

[PULL 07/19] ui/vdagent: keep "connected" state

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau During post-load of migration, virtio will notify of fe_open state. However vdagent code will handle this as a reconnection. This will trigger a connection reset/caps with the agent. Check if the state actually changed before resetting the connection. Signed-off-by: Marc

[PULL 04/19] ui/clipboard: add vmstate_cbinfo

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau Add a VMStateDescriptor for QemuClipboardInfo. Each clipboard owner will have to save its QemuClipboardInfo and reregister its owned clipboard after loading. (the global cbinfo has only pointers to owners, so it can't restore the relation with its owner if it was to handl

[PULL 08/19] ui/vdagent: factor out clipboard peer registration

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau This allows common code reuse during migration. Note that resetting the serial is now done regardless if the clipboard peer was registered or not. This should still be correct. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/vdagent.c | 20

[PULL 18/19] ui/gtk-gl-area: Render guest content with padding in fixed-scale mode

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu In fixed-scale mode (zoom-to-fit=false), we expect that scale should not change, meaning that if window size is larger than guest surface, padding is supposed to be added to preserve the scale. However, in OpenGL mode (gl=on), guest surface is always painted to the whole canvas

[PULL 16/19] ui/gtk: Don't update scale in fixed scale mode in gtk-egl.c

2025-05-24 Thread marcandre . lureau
From: Weifeng Liu Scale shouldn't be changed until user explicitly requests it in fixed scale mode (full-screen=false and free-scale=false). Use function gd_update_scale to complete scale updating instead. Signed-off-by: Weifeng Liu Message-ID: <20250511073337.876650-7-weifeng.li...@gmail.com>

[PULL 00/19] Ui patches

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 668df86ee8076152320345d8e36be7c95ec0a09a: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2025-05-23 09:26:29 -0400) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.git tags

[PULL 06/19] ui/vdagent: replace Buffer with GByteArray

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau Buffer is slightly more advanced than GByteArray, since it has a cursor/position. But vdagent code doesn't need it. This simplify a bit the code, and migration state. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/vdagent.c | 25 ---

[PULL 09/19] ui/vdagent: add migration support

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/vdagent.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/ui/vdagent.c b/ui/vdagent.c index fcbd7b167b..adc8755bd9 100644 --- a/ui/vdagent.

[PULL 02/19] ui/clipboard: use int for selection field

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau This allows to use a VMSTATE_INT32 field for migration purposes. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/clipboard.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/ui/clipboard.h b/include/ui/clipboar

[PULL 01/19] ui/gtk: warn if setting the clipboard failed

2025-05-24 Thread marcandre . lureau
From: Marc-André Lureau Just in case. Reviewed-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- ui/gtk-clipboard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c index 8d8a636fd1..65d89ec601 100644 --- a/ui/g

Re: [PATCH v5 17/25] target/rx: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for Renesas Xt

Re: [PATCH v5 15/25] target/ppc: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for Power PC t

Re: [PATCH v5 03/25] plugins: add hooks for new discontinuity related callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: The plugin API allows registration of callbacks for a variety of VCPU related events, such as VCPU reset, idle and resume. In addition, we recently introduced API for registering callbacks for discontinuity events, specifically for interrupts, exceptions and h

Re: [PATCH v5 13/25] target/mips: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for MIPS targe

Re: [PATCH v5 12/25] target/microblaze: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places the hook for MicroBl

Re: [PATCH v5 11/25] target/m68k: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for Motorola 6

Re: [PATCH v5 08/25] target/hppa: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We identified a number of exceptions as interrupts, and we assume any unknown exception is also an interrupt. HPPA appears to not have any form of host-call. This change places the hook for PA-RISC targets. Signed-off-by: Julian Ganz --- target/hppa/int_h

Re: [PATCH v5 07/25] target/avr: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places the hook for AVR tar

Re: [PATCH v5 06/25] target/arm: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: @@ -10880,6 +10899,7 @@ void arm_cpu_do_interrupt(CPUState *cs) ARMCPU *cpu = ARM_CPU(cs); CPUARMState *env = &cpu->env; unsigned int new_el = env->exception.target_el; +uint64_t last_pc = env->pc; Incorrect. env->pc is for aarch64 onl

Re: [PATCH v5 05/25] target/alpha: call plugin trap callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for Alpha targ

Re: [PATCH v5 03/25] plugins: add hooks for new discontinuity related callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: +QEMU_DISABLE_CFI +static void plugin_vcpu_cb__discon(CPUState *cpu, + enum qemu_plugin_discon_type type, + uint64_t from) +{ +struct qemu_plugin_cb *cb, *next; +enum qemu_plugin_event

Re: [PATCH v5 02/25] plugins: add API for registering discontinuity callbacks

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: The plugin API allows registration of callbacks for a variety of VCPU related events, such as VCPU reset, idle and resume. In addition to those events, we recently defined discontinuity events, which include traps. This change introduces a function to registe

Re: [PATCH v5 01/25] plugins: add types for callbacks related to certain discontinuities

2025-05-24 Thread Richard Henderson
On 5/19/25 16:19, Julian Ganz wrote: The plugin API allows registration of callbacks for a variety of VCPU related events, such as VCPU reset, idle and resume. However, traps of any kind, i.e. interrupts or exceptions, were previously not covered. These kinds of events are arguably quite signific

Re: [PATCH] target/arm: Ignore SCTLR_EL2.EnSCXT when !ELIsInHost()

2025-05-24 Thread Richard Henderson
On 5/21/25 20:02, Oliver Upton wrote: Using an EL2 that enables SCXTNUM_ELx for guests while disabling the feature for the host generates erroneous traps to EL2 when running under TCG. Fix the issue by only evaluating SCTLR_EL2.EnSCXT when ELIsInHost(). Signed-off-by: Oliver Upton --- target

Re: [PATCH] hw/block: Drop unused nand.c

2025-05-24 Thread Richard Henderson
On 5/22/25 15:28, Peter Maydell wrote: The nand.c device (TYPE_NAND) is an emulation of a NAND flash memory chip which was used by the old OMAP boards. No current QEMU board uses it, and although techically "-device nand,chip-id=0x6b" doesn't error out, it's not possible to usefully use it from

Re: [PATCH v4] tests/functional: Add PCI hotplug test for aarch64

2025-05-24 Thread Alex Bennée
Gustavo Romero writes: > Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and > hot-unplug on arm64. > > Signed-off-by: Gustavo Romero > Reviewed-by: Daniel P. Berrangé > --- > MAINTAINERS | 5 ++ > tests/functional/meson.build

[PATCH] vfio/pci: Introduce x-pci-class-code option

2025-05-24 Thread Tomita Moeko
Introduce x-pci-class-code option to allow users to override PCI class code of a device, similar to the existing x-pci-vendor-id option. Only the lower 24 bits of this option are used, though a uint32 is used here for determining whether the value is valid and set by user. This is mainly intended

Re: [PATCH v4 4/7] ui/spice: Add an option to submit gl_draw requests at fixed rate

2025-05-24 Thread Marc-André Lureau
Hi On Thu, May 15, 2025 at 4:49 AM Vivek Kasireddy wrote: > In the specific case where the display layer (virtio-gpu) is using > dmabuf, and if remote clients are enabled (-spice gl=on,port=), > it makes sense to limit the maximum (streaming) rate (refresh rate) > to a fixed value using the

Re: [PATCH v4 4/7] ui/spice: Add an option to submit gl_draw requests at fixed rate

2025-05-24 Thread Marc-André Lureau
On Thu, May 15, 2025 at 4:49 AM Vivek Kasireddy wrote: > In the specific case where the display layer (virtio-gpu) is using > dmabuf, and if remote clients are enabled (-spice gl=on,port=), > it makes sense to limit the maximum (streaming) rate (refresh rate) > to a fixed value using the GUI

Re: [PATCH] tests/functional/test_mem_addr_space: Use set_machine() to select the machine

2025-05-24 Thread Richard Henderson
On 5/21/25 15:37, Thomas Huth wrote: From: Thomas Huth By using self.set_machine() the tests get properly skipped in case the machine has not been compiled into the QEMU binary, e.g. when "configure" has been run with "--without-default-devices". Signed-off-by: Thomas Huth --- tests/functiona

Re: [PATCH v4 3/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-05-24 Thread Marc-André Lureau
Hi On Thu, May 15, 2025 at 4:49 AM Vivek Kasireddy wrote: > Newer versions of Spice server should be able to accept dmabuf > fds from Qemu for clients that are connected via the network. > In other words, when this option is enabled, Qemu would share > a dmabuf fd with Spice which would encode a

Re: [PATCH v4 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-05-24 Thread Marc-André Lureau
Hi On Thu, May 15, 2025 at 4:49 AM Vivek Kasireddy wrote: > To address the limitation that this option is incompatible with > remote clients, this patch series adds an option to select a > preferred codec and also enable gl=on option for clients that > are connected via the network. In other wor

Re: [PATCH 066/147] include/exec: Move TLB_MMIO, TLB_DISCARD_WRITE to slow flags

2025-05-24 Thread Richard Henderson
On 5/20/25 18:01, Jonathan Cameron wrote: On Thu, 8 May 2025 14:29:18 +0100 Jonathan Cameron wrote: On Tue, 29 Apr 2025 19:43:05 -0700 Richard Henderson wrote: On 4/29/25 14:35, Alistair Francis wrote: On Sat, Apr 26, 2025 at 3:36 AM Jonathan Cameron via wrote: On Tue, 22 Apr 2025 12:26

[PATCH] accel/tcg: Fix atomic_mmu_lookup vs TLB_FORCE_SLOW

2025-05-24 Thread Richard Henderson
When we moved TLB_MMIO and TLB_DISCARD_WRITE to TLB_SLOW_FLAGS_MASK, we failed to update atomic_mmu_lookup to properly reconstruct flags. Fixes: 24b5e0fdb543 ("include/exec: Move TLB_MMIO, TLB_DISCARD_WRITE to slow flags") Reported-by: Jonathan Cameron Signed-off-by: Richard Henderson --- acce

Re: [PATCH] linux-user: implement pgid field of /proc/self/stat

2025-05-24 Thread Richard Henderson
On 5/20/25 15:07, Andreas Schwab wrote: Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8820ca4dfd..5536e364dc 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8235,

Re: [PATCH] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

2025-05-24 Thread Richard Henderson
On 5/19/25 22:48, Ilya Leoshkevich wrote: diff --git a/tcg/perf.c b/tcg/perf.c index 4e8d2c1bee7..f30c5b489d1 100644 --- a/tcg/perf.c +++ b/tcg/perf.c @@ -154,7 +154,7 @@ struct debug_entry { uint64_t addr; int lineno; int discrim; -const char name[]; +char name[]; };

Re: [PATCH 4/4] docs: Deprecate the qemu-system-microblazeel binary

2025-05-24 Thread Richard Henderson
On 5/15/25 14:20, Thomas Huth wrote: From: Thomas Huth The (former big-endian only) binary qemu-system-microblaze can handle both endiannesses nowadays, so we don't need the separate qemu-system-microblazeel binary for little endian anymore. Let's deprecate it to avoid unnecessary compilation a

Re: [PATCH 3/4] hw/microblaze: Remove the big-endian variants of ml605 and xlnx-zynqmp-pmu

2025-05-24 Thread Richard Henderson
On 5/15/25 14:20, Thomas Huth wrote: From: Thomas Huth Both machines were added with little-endian in mind only (the "endianness" CPU property was hard-wired to "true", see commits 133d23b3ad1 and a88bbb006a52), so the variants that showed up on the big endian target likely never worked. We depr

Re: [PATCH 1/4] hw/microblaze: Add endianness property to the petalogix_s3adsp1800 machine

2025-05-24 Thread Richard Henderson
On 5/15/25 14:20, Thomas Huth wrote: +static int machine_get_endianness(Object *obj, Error **errp G_GNUC_UNUSED) +{ +S3Adsp1800MachineState *ms = PETALOGIX_S3ADSP1800_MACHINE(obj); +return ms->endianness; +} + +static void machine_set_endianness(Object *obj, int endianness, Error **errp)

Re: [PATCH] system/main: comment lock rationale

2025-05-24 Thread Richard Henderson
On 5/15/25 18:46, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- system/main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/system/main.c b/system/main.c index 1c022067349..b8f7157cc34 100644 --- a/system/main.c +++ b/system/main.c @@ -69,8 +69,21 @@ int (*q

Re: [PATCH v3 10/20] MAINTAINERS: add Akihiko and Dmitry as reviewers

2025-05-24 Thread Michael S. Tsirkin
On Wed, May 21, 2025 at 05:42:40PM +0100, Alex Bennée wrote: > Thanks for volunteering to help. > > Cc: Akihiko Odaki > Cc: Dmitry Osipenko > Signed-off-by: Alex Bennée Great! Acked-by: Michael S. Tsirkin > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINT

Re: [PATCH 08/22] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-05-24 Thread Michael S. Tsirkin
On Wed, May 21, 2025 at 06:12:34PM +0200, Eric Auger wrote: > Hi Gustavo, > > On 5/20/25 4:09 PM, Gustavo Romero wrote: > > Hi Eric, > > > > On 5/14/25 14:00, Eric Auger wrote: > >> gpex build_host_bridge_osc() and x86 originated > >> build_pci_host_bridge_osc_method() are mostly identical. > >> >

Re: [PATCH v4 3/4] hw/acpi/aml-build: Build a root node in the PPTT table

2025-05-24 Thread Michael S. Tsirkin
On Mon, May 19, 2025 at 09:55:51AM +0100, Alireza Sanaee wrote: > On Sun, 11 May 2025 14:10:46 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Apr 24, 2025 at 01:24:38PM +0100, Alireza Sanaee wrote: > > > From: Yicong Yang > > > > > > Currently we build the PPTT starting from the socket node

Re: [PATCH v2 0/3] ui/vnc: fix some endian problems

2025-05-24 Thread Michael Tokarev
On 14.05.2025 14:19, Daniel P. Berrangé wrote: This fixes some edge cases in endian handling in the VNC server. These bugs are rarely going to be visible by default, since most servers will negotiate encoding formats / framebuffer formats that avoid hitting the problem scenarios. In v2: - Ren

Re: [PATCH 0/3] target/hppa: Fix FP exception handling

2025-05-24 Thread Michael Tokarev
On 17.05.2025 15:00, del...@kernel.org wrote: From: Helge Deller This series fixes and improves the floating point exception handling in the hppa system and user emulation. A testcase is included in patch #3. Please review. Thanks! Helge Helge Deller (3): target/hppa: Copy instruction cod

Re: [PATCH V3 14/42] pci: skip reset during cpr

2025-05-24 Thread Michael S. Tsirkin
On Fri, May 16, 2025 at 10:19:09AM +0200, Cédric Le Goater wrote: > On 5/12/25 17:32, Steve Sistare wrote: > > Do not reset a vfio-pci device during CPR. > > > > Signed-off-by: Steve Sistare > > --- > > hw/pci/pci.c | 13 + > > 1 file changed, 13 insertions(+) > > > > diff --git a

Re: [PATCH] meson: fix Windows build

2025-05-24 Thread Oleg Tolmatcev
Am Fr., 23. Mai 2025 um 23:28 Uhr schrieb Paolo Bonzini : > > Thanks for the patch! The Windows build configurations that we support > currently are cross-building from Linux and native build with MSYS2. > MSYS2 is sufficiently POSIX-like, and also has a nice package manager. > > Can you share how