Re: [PATCH v2 12/14] ui/gtk-gl-area: Remove extra draw call in refresh

2025-05-17 Thread Akihiko Odaki
On 2025/05/13 2:01, Kim, Dongwon wrote: Subject: Re: [PATCH v2 12/14] ui/gtk-gl-area: Remove extra draw call in refresh On 2025/05/10 21:12, Dmitry Osipenko wrote: On 5/10/25 07:52, Akihiko Odaki wrote: On 2025/05/06 21:57, Alex Bennée wrote: From: Dongwon Kim This partially reverts commit

Re: [PULL 00/27] virtio,pci,pc: fixes, features

2025-05-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/14] NBD patches for 2025-05-14

2025-05-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/1] nvme queue

2025-05-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/13] s390x obsolete machine removal & misc fixes

2025-05-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/58] target-arm queue

2025-05-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v4 2/3] nbd: Set unix socket send buffer on macOS

2025-05-17 Thread Nir Soffer
On macOS we need to increase unix socket buffers size on the client and server to get good performance. We set socket buffers on macOS after connecting or accepting a client connection. Testing shows that setting socket receive buffer size (SO_RCVBUF) has no effect on performance, so we set only t

[PATCH v4 1/3] io: Add helper for setting socket send buffer size

2025-05-17 Thread Nir Soffer
Testings reading and writing from qemu-nbd using a unix domain socket shows that the platform default send buffer size is too low, leading to poor performance and hight cpu usage. Add a helper for setting socket send buffer size to be used in NBD code. It can also be used in other context. We don

[PATCH v4 0/3] nbd: Increase unix socket buffer size

2025-05-17 Thread Nir Soffer
On both macOS and Linux, the default send buffer size is too small causing poor performance when reading and writing to qemu-nbd. A simple way to experience this is to compare TCP and unix sockets, showing that TCP socket is much faster. Programs like nbdcopy partly mitigate this by using multiple

[PATCH v4 3/3] nbd: Set unix socket send buffer on Linux

2025-05-17 Thread Nir Soffer
Like macOS we have similar issue on Linux. For TCP socket the send buffer size is 2626560 bytes (~2.5 MiB) and we get good performance. However for unix socket the default and maximum buffer size is 212992 bytes (208 KiB) and we see poor performance when using one NBD connection, up to 4 times slow

Re: [PATCH v2 09/12] qapi: make most CPU commands unconditionally available

2025-05-17 Thread Pierrick Bouvier
On 5/16/25 11:00 PM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Daniel P. Berrangé This removes the TARGET_* conditions from all the CPU commands that are conceptually target independent. Top level stubs are provided to cope with targets which do not currently implement all of t

Re: [PATCH v2 01/12] qapi: expose rtc-reset-reinjection command unconditionally

2025-05-17 Thread Pierrick Bouvier
On 5/17/25 1:21 AM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Daniel P. Berrangé This removes the TARGET_I386 condition from the rtc-reset-reinjection command. This requires providing a QMP command stub for non-i386 target. This in turn requires moving the command out of misc-t

Re: [PATCH 1/6] meson: build target libraries with common dependencies

2025-05-17 Thread Pierrick Bouvier
On 5/17/25 8:00 AM, Paolo Bonzini wrote: On 5/16/25 07:27, Pierrick Bouvier wrote: @@ -4131,12 +4137,17 @@ common_all = static_library('common', hw_common_arch_libs = {} target_common_arch_libs = {} target_common_system_arch_libs = {} -foreach target : target_dirs +foreach target_base_a

Re: [PATCH 5/6] meson: merge lib{system, user}_ss with {system, user}_ss.

2025-05-17 Thread Pierrick Bouvier
On 5/17/25 8:04 AM, Paolo Bonzini wrote: On 5/16/25 07:27, Pierrick Bouvier wrote: Now that target configuration can be applied to lib{system, user}_ss, there is no reason to keep that separate from the existing {system, user}_ss. The reason would be that previously you wouldn't have -DCOMPILI

Re: [PATCH v3 04/10] qemu-thread: Avoid futex abstraction for non-Linux

2025-05-17 Thread Akihiko Odaki
On 2025/05/17 19:24, Paolo Bonzini wrote: Il sab 17 mag 2025, 01:41 Akihiko Odaki > ha scritto: I think we only need a store-release, which is ensured even by the C11 read-modify-write operation; we only need to ensure that ev->value is set to EV_S

Re: [PATCH 5/6] meson: merge lib{system, user}_ss with {system, user}_ss.

2025-05-17 Thread Paolo Bonzini
On 5/16/25 07:27, Pierrick Bouvier wrote: Now that target configuration can be applied to lib{system, user}_ss, there is no reason to keep that separate from the existing {system, user}_ss. The reason would be that previously you wouldn't have -DCOMPILING_SYSTEM_VS_USER defined for the files i

Re: [PATCH v5 1/2] hw/pci-host/gt64120: Fix endianness handling

2025-05-17 Thread Paolo Bonzini
On 5/17/25 07:25, Rakesh Jeyasingh wrote: On Tue, Apr 29, 2025 at 10:34 PM Rakesh Jeyasingh > wrote: The GT-64120 PCI controller requires special handling where: 1. Host bridge(bus 0 ,device 0) must never be byte-swapped 2. Other devices follow MByteS

Re: [PATCH 1/6] meson: build target libraries with common dependencies

2025-05-17 Thread Paolo Bonzini
On 5/16/25 07:27, Pierrick Bouvier wrote: @@ -4131,12 +4137,17 @@ common_all = static_library('common', hw_common_arch_libs = {} target_common_arch_libs = {} target_common_system_arch_libs = {} -foreach target : target_dirs +foreach target_base_arch, config_base_arch : config_base_arch_mak

Re: [PATCH 0/2] qapi/misc-target: Rename SGX related items to follow QAPI naming style

2025-05-17 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH V4] vfio: return mr from vfio_get_xlat_addr

2025-05-17 Thread Steven Sistare
On 5/16/2025 4:50 PM, David Hildenbrand wrote: On 16.05.25 21:26, Steven Sistare wrote: On 5/16/2025 2:58 PM, David Hildenbrand wrote: On 16.05.25 19:13, Steve Sistare wrote: Modify memory_get_xlat_addr and vfio_get_xlat_addr to return the memory region that the translated address is found in.

[PATCH 1/3] target/hppa: Copy instruction code into fr1 on FPU assist fault

2025-05-17 Thread deller
From: Helge Deller The hardware stores the instruction code in the lower bits of the FP exception register #1 on FP assist traps. This fixes the FP exception handler on Linux, as the Linux kernel uses the value to decide on the correct signal which should be pushed into userspace (see decode_fpu(

[PATCH 3/3] target/hppa: Fix FPE exceptions

2025-05-17 Thread deller
From: Helge Deller Implement FP exception register #1 (lower 32-bits of 64-bit fr[0]). A proper implementation is necessary to allow the Linux kernel in system mode and the qemu linux-user to send proper si_code values on SIGFPE signal. Always set the T-bit on taken exception, and merge over- an

[PATCH 0/3] target/hppa: Fix FP exception handling

2025-05-17 Thread deller
From: Helge Deller This series fixes and improves the floating point exception handling in the hppa system and user emulation. A testcase is included in patch #3. Please review. Thanks! Helge Helge Deller (3): target/hppa: Copy instruction code into fr1 on FPU assist fault linux-user/hppa:

[PATCH 2/3] linux-user/hppa: Send proper si_code on SIGFPE exception

2025-05-17 Thread deller
From: Helge Deller Improve the linux-user emulation to send the correct si_code depending on overflow (TARGET_FPE_FLTOVF), underflow (TARGET_FPE_FLTUND), ... Note that the hardware stores the relevant flags in FP exception register #1, which is actually the lower 32-bits of the 64-bit fr[0] regis

Re: [PATCH v2] plugin: Add callback support for vCPU hardware and architecture-specific interrupts

2025-05-17 Thread Alex Bennée
Liu marko writes: > Implemented the `qemu_plugin_vcpu_int_cb` callback to allow plugins to > observe hardware and architecture-specific > interrupts. Modified `cpu-exec.c` to invoke the callback on hard interrupts, > and added a test plugin (`countint`) to > demonstrate its functionality. A sim

[PATCH v2] plugin: Add callback support for vCPU hardware and architecture-specific interrupts

2025-05-17 Thread Liu marko
Implemented the `qemu_plugin_vcpu_int_cb` callback to allow plugins to observe hardware and architecture-specific interrupts. Modified `cpu-exec.c` to invoke the callback on hard interrupts, and added a test plugin (`countint`) to demonstrate its functionality. A similar approach was previously

Re: [PATCH v3 04/10] qemu-thread: Avoid futex abstraction for non-Linux

2025-05-17 Thread Paolo Bonzini
Il sab 17 mag 2025, 01:41 Akihiko Odaki ha scritto: > I think we only need a store-release, which is ensured even by the C11 > read-modify-write operation; we only need to ensure that ev->value is > set to EV_SET after all stores specified earlier appear. > You really need a barrier to order the

[PATCH] plugin: Add callback support for vCPU hardware and architecture-specific interrupts

2025-05-17 Thread Liu marko
Implemented the `qemu_plugin_vcpu_int_cb` callback to allow plugins to observe hardware and architecture-specific interrupts. Modified `cpu-exec.c` to invoke the callback on hard interrupts, and added a test plugin (`countint`) to demonstrate its functionality. A similar approach was previously

Re: [PATCH v2 01/12] qapi: expose rtc-reset-reinjection command unconditionally

2025-05-17 Thread Markus Armbruster
Pierrick Bouvier writes: > From: Daniel P. Berrangé > > This removes the TARGET_I386 condition from the rtc-reset-reinjection > command. This requires providing a QMP command stub for non-i386 target. > This in turn requires moving the command out of misc-target.json, since > that will trigger s