Re: [PATCH 3/5] i386/kvm: Support event with select & umask format in KVM PMU filter

2025-04-26 Thread Zhao Liu
Hi Markus, > > +case KVM_PMU_EVENT_FORMAT_X86_SELECT_UMASK: { > > +if (event->u.x86_select_umask.select > UINT12_MAX) { > > +error_setg(errp, > > + "Parameter 'select' out of range (%d).", > > + UINT12_MAX); >

Re: [PATCH v3 8/9] target/riscv: widen scounteren to target_ulong

2025-04-26 Thread Andrew Jones
On Fri, Apr 25, 2025 at 01:02:02PM -0300, Daniel Henrique Barboza wrote: > We want to support scounteren as a KVM CSR. The KVM UAPI defines every > CSR size as target_ulong, and our env->scounteren is fixed at 32 bits. > > The other existing cases where the property size does not match the KVM > r

Re: [PATCH v4 10/13] memory: Change NotifyStateClear() definition to return the result

2025-04-26 Thread Chenyi Qiang
Hi David, Any thought on patch 10-12, which is to move the change attribute into a priority listener. A problem is how to handle the error handling of private_to_shared failure. Previously, we thought it would never be able to fail, but right now, it is possible in corner cases (e.g. -ENOMEM) in s

Re: [PATCH v2] virtio-net: Copy received packet to buffer

2025-04-26 Thread Lei Yang
QE tested this patch's v2 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Thu, Apr 24, 2025 at 11:49 PM Antoine Damhet wrote: > > On Thu, Apr 24, 2025 at 06:49:57PM +0900, Akihiko Odaki wrote: > > Commit e28fbd1c525d ("Revert "virtio-net: Copy received header to

Re: [PATCH v4 03/13] memory: Unify the definiton of ReplayRamPopulate() and ReplayRamDiscard()

2025-04-26 Thread Chenyi Qiang
On 4/25/2025 8:42 PM, David Hildenbrand wrote: > On 07.04.25 09:49, Chenyi Qiang wrote: >> Update ReplayRamDiscard() function to return the result and unify the >> ReplayRamPopulate() and ReplayRamDiscard() to ReplayStateChange() at >> the same time due to their identical definitions. This unifi

Re: [PATCH v4 05/13] memory: Introduce PrivateSharedManager Interface as child of GenericStateManager

2025-04-26 Thread Chenyi Qiang
On 4/25/2025 8:57 PM, David Hildenbrand wrote: > On 07.04.25 09:49, Chenyi Qiang wrote: >> To manage the private and shared RAM states in confidential VMs, >> introduce a new class of PrivateShareManager as a child of >> GenericStateManager, which inherits the six interface callbacks. With a >>

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-26 Thread Chenyi Qiang
Thanks David for your review! On 4/25/2025 8:49 PM, David Hildenbrand wrote: > On 09.04.25 11:56, Alexey Kardashevskiy wrote: >> >> >> On 7/4/25 17:49, Chenyi Qiang wrote: >>> RamDiscardManager is an interface used by virtio-mem to adjust VFIO >>> mappings in relation to VM page assignment. It man

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-26 Thread Dmitry Osipenko
On 4/14/25 17:47, Dmitry Osipenko wrote: > On 4/11/25 04:42, 刘聪 wrote: >> >> >> >>> -Original Messages- >>> From: "Dmitry Osipenko" >>> Send time:Friday, 04/11/2025 05:59:11 >>> To: "Cong Liu" >>> Cc: jiqian.c...@amd.com, akihiko.od...@daynix.com, alex.ben...@linaro.org, >>> alexander.de

Re: [PATCH alternate 2/2] target/riscv: Fix write_misa vs aligned next_pc

2025-04-26 Thread Richard Henderson
On 4/25/25 15:20, Daniel Henrique Barboza wrote: diff --git a/target/riscv/csr.c b/target/riscv/csr.c index c52c87faae..992ec8ebff 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -2111,10 +2111,13 @@ static RISCVException write_misa(CPURISCVState *env, int csrno,   val &= env->mi

Re: [PATCH alternate 0/2] target/riscv: Fix write_misa vs aligned next_pc

2025-04-26 Thread Daniel Henrique Barboza
On 4/25/25 7:35 PM, Philippe Mathieu-Daudé wrote: On 25/4/25 18:50, Richard Henderson wrote: This is an alternate, but less exact approach.  It assumes that there will never be a 16 or 48-bit csr write instruction.  This feels dirtier, but it's a fair assumption involves much less faff. I p

Re: [PATCH 0/7] target/riscv: Fix write_misa vs aligned next_pc

2025-04-26 Thread Daniel Henrique Barboza
On 4/25/25 12:23 PM, Richard Henderson wrote: As discussed, the use of GETPC() within write_misa is wrong. I've done just enough plumbing to get the helper return address piped down to write_misa, so that we can make use of unwind data. AFAIK, nothing in check-tcg or check-functional would te

Re: [PATCH v2 10/20] include/glib-compat.h: Poison g_list_sort and g_slist_sort

2025-04-26 Thread Kohei Tokunaga
Hi Thomas, > Cosmetic nit: Multiline comments in QEMU should start with "/*" on their own > line. Thank you for the feedback. I'll fix this in the next version of the series.

Re: [PATCH v2 04/20] target/arm/helper.c: Fix type conflict of GLib function pointers

2025-04-26 Thread Kohei Tokunaga
Hi Philippe, > Why not use a gpointer for @d like in other patches? Thank you for the feedback. I'll fix this to use a gpointer in the next version of the series.