A device gets automatically unrealized when being unparented.
Signed-off-by: Akihiko Odaki
---
hw/pci/pcie_sriov.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index e9b23221d713..499becd5273f 100644
--- a/hw/pci/pcie_sriov.c
+++ b/hw/pci/pcie_
pcie_sriov doesn't have code to restore its state after migration, but
igb, which uses pcie_sriov, naively claimed its migration capability.
Add code to register VFs after migration and fix igb migration.
Fixes: 3a977deebe6b ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki
---
in
pci_new() aborts when creating a VF with addr >= PCI_DEVFN_MAX.
Signed-off-by: Akihiko Odaki
---
docs/pcie_sriov.txt | 8 +---
include/hw/pci/pcie_sriov.h | 5 +++--
hw/net/igb.c| 10 +++---
hw/nvme/ctrl.c | 22 ++
hw/pci/pcie_sr
num_vfs is not migrated so use PCI_SRIOV_CTRL_VFE and PCI_SRIOV_NUM_VF
instead.
Signed-off-by: Akihiko Odaki
---
include/hw/pci/pcie_sriov.h | 1 -
hw/pci/pcie_sriov.c | 38 +++---
hw/pci/trace-events | 2 +-
3 files changed, 28 insertions(+), 13
It is no longer used.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
---
include/hw/qdev-core.h | 4
hw/core/qdev.c | 1 -
system/qdev-monitor.c | 12 +++-
3 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/i
The guest cannot use VFs due to the lack of multifunction support but
can use PFs.
Signed-off-by: Akihiko Odaki
---
hw/s390x/s390-pci-bus.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 8c5eb69f7d76..c396d55c72
vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1
by checking dev->opts, bypassing the QOM property infrastructure.
Use -1 as the default value for rombar to tell if the user explicitly
set it to 1. The property is also converted from unsigned to signed.
-1 is signed so it is
The SR-IOV PFs set the multifunction bit during device realization so
check them after that. There is no functional change because we
explicitly ignore the multifunction bit for SR-IOV devices.
Signed-off-by: Akihiko Odaki
---
hw/s390x/s390-pci-bus.c | 28 +---
1 file cha
Release VFs failed to realize just as we do in unregister_vfs().
Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization
(SR/IOV)")
Signed-off-by: Akihiko Odaki
---
hw/pci/pcie_sriov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sri
Disable SR-IOV VF devices by reusing code to power down PCI devices
instead of removing them when the guest requests to disable VFs. This
allows to realize devices and report VF realization errors at PF
realization time.
Signed-off-by: Akihiko Odaki
---
include/hw/pci/pci.h| 5 ---
incl
A PF may automatically create VFs and the PF may be function 0.
Signed-off-by: Akihiko Odaki
Reviewed-by: Shivaprasad G Bhat
Tested-by: Shivaprasad G Bhat
---
hw/ppc/spapr_pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index
VFs are automatically created by PF, and creating zpci for them will
result in unexpected usage of fids. Currently QEMU does not support
multifunction for s390x so we don't need zpci for VFs anyway.
Signed-off-by: Akihiko Odaki
---
hw/s390x/s390-pci-bus.c | 21 +++--
1 file chang
Disabled means it is a disabled SR-IOV VF and hidden from the guest.
Do not create DT when starting the system and also keep the disabled PCI
device not linked to DRC, which generates DT in case of hotplug.
Signed-off-by: Akihiko Odaki
Reviewed-by: Shivaprasad G Bhat
Tested-by: Shivaprasad G Bhat
The renamed state will not only represent powering state of PFs, but
also represent SR-IOV VF enablement in the future.
Signed-off-by: Akihiko Odaki
---
include/hw/pci/pci.h| 7 ++-
include/hw/pci/pci_device.h | 2 +-
hw/pci/pci.c| 14 +++---
hw/pci/pci_host
Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com>
("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
I submitted a RFC series[1] to add support for SR-IOV emulation to
virtio-net-pci. During the development of the series, I fixed some
trivial bugs and made improvements that I think
Some features are not always available, and virtio-net used to disable
them when not available even if the corresponding properties were
explicitly set to "on".
Convert feature properties to OnOffAuto so that the user can explicitly
tell QEMU to automatically select the value by setting them "auto
Based-on: <20250104-virtio-v3-0-63ef70e9d...@daynix.com>
("[PATCH v3 0/3] virtio: Convert feature properties to OnOffAuto")
Some features are not always available, and virtio-net used to disable
them when not available even if the corresponding properties were
explicitly set to "on".
Convert feat
Warning about RSS fallback at device realization allows the user to
notice the configuration problem early.
Signed-off-by: Akihiko Odaki
---
hw/net/virtio-net.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 6b2104
memory_region_update_container_subregions() used to call
memory_region_ref(), which creates a reference to the owner of the
subregion, on behalf of the owner of the container. This results in a
circular reference if the subregion and container have the same owner.
memory_region_ref() creates a ref
This series was spun off from:
"[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto"
(https://patchew.org/QEMU/20240714-auto-v3-0-e27401aab...@daynix.com/)
Some features are not always available with vhost. Legacy features are
not available with vp_vdpa in particular. virtio devices us
Some features are not always available with vhost. Legacy features are
not available with vp_vdpa in particular. virtio devices used to disable
them when not available even if the corresponding properties were
explicitly set to "on".
QEMU already has OnOffAuto type, which includes the "auto" value
DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO()
as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference
is that DEFINE_PROP_ON_OFF_AUTO_BIT64() exposes OnOffAuto instead of
bool.
Signed-off-by: Akihiko Odaki
---
include/hw/qdev-properties.h | 18
Accept bool literals for OnOffAuto properties for consistency with bool
properties. This enables users to set the "on" or "off" value in a
uniform syntax without knowing whether the "auto" value is accepted.
This behavior is especially useful when converting an existing bool
property to OnOffAuto o
I saw various sanitizer errors when running check-qtest-ppc64. While
I could just turn off sanitizers, I decided to tackle them this time.
Unfortunately, GLib versions older than 2.81.0 do not free test data in
some cases so some sanitizer errors remain. All sanitizer errors will be
gone with this
Do not refer to "memory region's reference count"
-
Now MemoryRegions do have their own reference counts, but they will not
be used when their owners are not themselves. However, the documentation
of memory_region_ref() says it adds "1 to a memory re
kvm-steal-time and sve properties are added for KVM even if the
corresponding features are not available. Always add pmu property for
Armv7+. Note that the property is added only for Armv7-A/R+ as QEMU
currently emulates PMU only for such versions, and a different
version may have a different defin
Commit 03fcbd9dc508 ("qdev: Check for the availability of a hotplug
controller before adding a device") says:
> The qdev_unplug() function contains a g_assert(hotplug_ctrl)
> statement, so QEMU crashes when the user tries to device_add +
> device_del a device that does not have a corresponding hotp
On 1/3/2025 5:17 PM, Philippe Mathieu-Daudé wrote:
Keep the Hexagon target in line with others.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Brian Cain
target/Kconfig | 1 +
target/hexagon/Kconfig | 2 ++
2 files changed, 3 insertions(+)
create mode 100644 target
On Sat, 4 Jan 2025, Philippe Mathieu-Daudé wrote:
While I was very enthusiast when Avocado was presented to
I think 'enthusiastic' would be correct here.
Regards,
BALATON Zoltan
the QEMU community and pushed forward to have it integrated,
time passed and I lost interest. Be honest, remove my
On 3/1/25 13:26, Fabiano Rosas wrote:
Philippe Mathieu-Daudé writes:
Hi Fabiano,
On 12/12/24 00:37, Philippe Mathieu-Daudé wrote:
Replace first_cpu->as by address_space_memory.
Philippe Mathieu-Daudé (2):
system/qtest: Remove uses of 'first_cpu'
qtest/fuzz: Remove uses of 'first_cpu
While I was very enthusiast when Avocado was presented to
the QEMU community and pushed forward to have it integrated,
time passed and I lost interest. Be honest, remove my R: tag
to not give fake expectation I'd review patches related to
Avocado anymore.
Signed-off-by: Philippe Mathieu-Daudé
---
No need to link capstone to targets which don't use it.
Signed-off-by: Philippe Mathieu-Daudé
---
disas/meson.build| 1 -
target/arm/meson.build | 1 +
target/i386/meson.build | 1 +
target/ppc/meson.build | 1 +
target/s390x/meson.build | 1 +
5 files changed, 4 insertions(+), 1 de
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 1 +
Kconfig.host | 3 +++
2 files changed, 4 insertions(+)
diff --git a/meson.build b/meson.build
index a35ef579c28..28f9120a781 100644
--- a/meson.build
+++ b/meson.build
@@ -3224,6 +3224,7 @@ host_kconfig = \
(have_ivshmem ? ['CONFIG
Keep the Hexagon target in line with others.
Signed-off-by: Philippe Mathieu-Daudé
---
target/Kconfig | 1 +
target/hexagon/Kconfig | 2 ++
2 files changed, 3 insertions(+)
create mode 100644 target/hexagon/Kconfig
diff --git a/target/Kconfig b/target/Kconfig
index d0c7b59d9c7..17cfb46
No change for host or user emulation.
For system emulation, each target explicitly selects
its disassembler.
This change allows selecting more than two (host + target)
disassemblers in a binary supporting multiple targets.
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build |
The Xtensa disassembler (selected with CONFIG_XTENSA_DIS=y)
uses methods defined in xtensa-isa.c, so this file has to be
compiled when the disassembler is linked.
Signed-off-by: Philippe Mathieu-Daudé
---
target/xtensa/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
When capstone is available, we get ARM/X86/PPC/S390X
disassemblers in common_ss[] for free.
Signed-off-by: Philippe Mathieu-Daudé
---
disas/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/disas/Kconfig b/disas/Kconfig
index 1d2c397c953..8af8ecd5c81 100644
--- a/disas/Kconfig
+++
Hi,
This series is an experiment to link multiple disassembler
in the same system binary. At least in my prototype I wanted
to get 3: x86 host and microblaze/xtensa targets.
Instead of having meson.build select one pair of host+target,
we let targets to be selected by Kconfig. By default each
tar
Fabiano Rosas writes:
> Stefan Hajnoczi writes:
>
>> On Fri, 3 Jan 2025 at 13:32, Fabiano Rosas wrote:
>>>
>>> Thomas Huth writes:
>>>
>>> > On 20/12/2024 17.28, Peter Xu wrote:
>>> >> On Thu, Dec 19, 2024 at 03:53:22PM -0300, Fabiano Rosas wrote:
>>> >>> Stefan Hajnoczi writes:
>>> >>>
>>> >
Stefan Hajnoczi writes:
> On Fri, 3 Jan 2025 at 13:32, Fabiano Rosas wrote:
>>
>> Thomas Huth writes:
>>
>> > On 20/12/2024 17.28, Peter Xu wrote:
>> >> On Thu, Dec 19, 2024 at 03:53:22PM -0300, Fabiano Rosas wrote:
>> >>> Stefan Hajnoczi writes:
>> >>>
>> Hi Fabiano,
>> Please take
Yichen Wang writes:
> From: Hao Xiang
>
> Multifd sender path gets an array of pages queued by the migration
> thread. It performs zero page checking on every page in the array.
> The pages are classfied as either a zero page or a normal page. This
> change uses Intel DSA to offload the zero pag
Yichen Wang writes:
> From: Hao Xiang
>
> * Test DSA start and stop path.
> * Test DSA configure and cleanup path.
> * Test DSA task submission and completion path.
>
> Signed-off-by: Bryan Zhang
> Signed-off-by: Hao Xiang
> Signed-off-by: Yichen Wang
Reviewed-by: Fabiano Rosas
On Fri, 3 Jan 2025 at 13:32, Fabiano Rosas wrote:
>
> Thomas Huth writes:
>
> > On 20/12/2024 17.28, Peter Xu wrote:
> >> On Thu, Dec 19, 2024 at 03:53:22PM -0300, Fabiano Rosas wrote:
> >>> Stefan Hajnoczi writes:
> >>>
> Hi Fabiano,
> Please take a look at this CI failure:
>
> >
On Tue, 31 Dec 2024 23:19:52 +0800
Tomita Moeko wrote:
> Device may only expose a specific portion of PCI config space through a
> region in a BAR, such behavior is seen in igd GGC and BDSM mirrors in
> BAR0. To handle these, config_offset is introduced to allow mirroring
> arbitrary region in PC
On Tue, 31 Dec 2024 23:19:53 +0800
Tomita Moeko wrote:
> With the introduction of config_offset field, VFIOConfigMirrorQuirk can
> now be used for those mirrored register in igd bar0. This eliminates
> the need for the macro intoduced in 1a2623b5c9e7 ("vfio/igd: add macro
> for declaring mirrored
From: Wainer dos Santos Moschetta
The time I spent contributing to QEMU was great, but I've not been active
for a long time now. So removing myself from the reviewers list of
"Integration Testing with the Avocado framework" and
"Build and test automation" subsystems.
Signed-off-by: Wainer dos Sa
Thomas Huth writes:
> On 20/12/2024 17.28, Peter Xu wrote:
>> On Thu, Dec 19, 2024 at 03:53:22PM -0300, Fabiano Rosas wrote:
>>> Stefan Hajnoczi writes:
>>>
Hi Fabiano,
Please take a look at this CI failure:
>>> MALLOC_PERTURB_=61 QTEST_QEMU_BINARY=./qemu-system-s390x
>>>
On Fri, Jan 03, 2025 at 06:16:38PM +0100, Philippe Mathieu-Daudé wrote:
> On 3/1/25 16:15, Daniel P. Berrangé wrote:
> > On Fri, Jan 03, 2025 at 04:05:58PM +0100, Philippe Mathieu-Daudé wrote:
> > > As Daniel suggested [*]:
> > >
> > > > We should consider to rank HVF above TCG, on the basis
> > >
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any
user-visible changes.
signature.asc
Description: PGP signature
Hello Steven,
[ ... ]
+struct Aspeed27x0CM4SoCState {
+AspeedSoCState parent;
+
+ARMv7MState armv7m;
Why not use Aspeed10x0SoCState instead ?
The AST2700's CM4 is not part of the AST10x0 series SoC.
ok. These are different HW designs.
However, since the structure is identical, I
On 1/3/25 10:57, Steven Lee wrote:
Hi Cédric,
-Original Message-
From: Cédric Le Goater
Sent: Friday, January 3, 2025 5:44 PM
To: Steven Lee ; Peter Maydell
; Troy Lee ; Jamin Lin
; Andrew Jeffery
; Joel Stanley ; open
list:ASPEED BMCs ; open list:All patches CC here
Cc: Troy Lee ; Yu
Since registers are not modified, we don't need
to refill their values. Directly jump to the previous
store instruction to keep filling the TXDAT register.
The equivalent C code remains:
while (true) {
*UART_DATA = 'T';
}
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Hend
Re-indent ASM comments adding the 'loop:' label.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Fabiano Rosas
---
tests/qtest/boot-serial-test.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/qtest/boot-serial-tes
On 3/1/25 18:17, Thomas Huth wrote:
On 30/12/2024 18.02, Philippe Mathieu-Daudé wrote:
ping for this single cleanup patch?
On 20/11/24 09:52, Philippe Mathieu-Daudé wrote:
"hw/s390x/ipl/qipl.h" defines loadparm[] length as LOADPARM_LEN,
use that instead of the magic '8' value. Use a char type
The tests using the PL011 UART of the virt and raspi machines
weren't properly enabling the UART and its transmitter previous
to sending characters. Follow the PL011 manual initialization
recommendation by setting the proper bits of the control register.
Update the ASM code prefixing:
*UART_CTR
(Series fully reviewed)
Since v6:
- Corrected ASM comment (Fabiano)
This series split a patch [*] which was previously posted
too compact in multiple trivial steps. The last patch
initializes the PL011 Control register, enabling the
UART and its transmit channel, before using it to send
the 'T' c
In the next commit we are going to use a different value
for the $w1 register, maintaining the same $x2 value. In
order to keep the next commit trivial to review, set $x2
before $w1.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Fabiano Rosas
---
tests/qtest
On 30/12/2024 18.02, Philippe Mathieu-Daudé wrote:
ping for this single cleanup patch?
On 20/11/24 09:52, Philippe Mathieu-Daudé wrote:
"hw/s390x/ipl/qipl.h" defines loadparm[] length as LOADPARM_LEN,
use that instead of the magic '8' value. Use a char type for
char buffer.
Signed-off-by: Phil
On 3/1/25 16:15, Daniel P. Berrangé wrote:
On Fri, Jan 03, 2025 at 04:05:58PM +0100, Philippe Mathieu-Daudé wrote:
As Daniel suggested [*]:
We should consider to rank HVF above TCG, on the basis
that HW acceleration is faster and should provide a
host<->guest security boundary that we don't cl
The CPUState structure is declared in "hw/core/cpu.h",
the EXCP_HALTED definition in "exec/cpu-common.h".
Both headers are indirectly include by "cpu.h". In
order to remove "cpu.h" from "semihosting/console.h",
explicitly include them in console.c, otherwise we'd
get:
../semihosting/console.c:88
ARM semihosting implementations in "common-semi-target.h"
must de-reference the target CPUArchState, which is declared
in each target "cpu.h" header. Include it in order to avoid
when refactoring:
In file included from ../../semihosting/arm-compat-semi.c:169:
../target/riscv/common-semi-target
TLB_INVALID_MASK is defined in "exec/cpu-all.h".
Include it in order to avoid when refactoring:
../semihosting/uaccess.c:41:21: error: use of undeclared identifier
'TLB_INVALID_MASK'
41 | if (flags & TLB_INVALID_MASK) {
| ^
Signed-off-by: Philippe Mathi
config.c and console.c don't use any target specific
headers anymore, move them from specific_ss[] to
system_ss[] so they are built once, but will also be
linked once, removing global symbol clash in a single
QEMU binary.
Signed-off-by: Philippe Mathieu-Daudé
---
semihosting/meson.build | 9
This series makes semihosting config.c and console.c
target agnostic, building them once, removing symbol
collision of the following functions in the single
binary:
- qemu_semihosting_chardev_init
- qemu_semihosting_config_options
- qemu_semihosting_config_opts
- qemu_semihosting_enable
- sem
target_ulong is defined in each target "cpu-param.h",
itself included by "exec/cpu-defs.h".
Include the latter in order to avoid when refactoring:
include/semihosting/syscalls.h:26:24: error: unknown type name 'target_ulong'
26 |target_ulong fname, target_ulong fname
On Fri, Jan 03, 2025 at 04:54:11PM +0100, Thomas Huth wrote:
> It has been marked as deprecated two releases ago, so it should
> be fine now to remove this command line option.
>
> Signed-off-by: Thomas Huth
> ---
> docs/about/deprecated.rst | 6 --
> docs/about/removed-features.rst |
Hello,
In this revision two new commits are added to address multi chip SPI issues.
Updates in V5:
1. Use of PnvXferBuffer results in a additonal process overhead due to
frequent dynamic allocations and hence use an existing Fifo8 buffer.
2. Use a local variable seq_index and use it with in while
Use a local variable seq_index instead of repeatedly calling
get_seq_index() method and open-code next_sequencer_fsm().
Signed-off-by: Chalapathi V
---
hw/ssi/pnv_spi.c | 93 +---
1 file changed, 48 insertions(+), 45 deletions(-)
diff --git a/hw/ssi/p
Create a spi buses with distict names on each socket so that responders
are attached to correct SPI controllers.
QOM tree on a 2 socket machine:
(qemu) info qom-tree
/machine (powernv10-machine)
/chip[0] (power10_v2.0-pnv-chip)
/pib_spic[0] (pnv-spi)
/chip0.pnv.spi.bus.0 (SSI)
/x
In PnvXferBuffer dynamically allocating and freeing is a
process overhead. Hence used an existing Fifo8 buffer with
capacity of 16 bytes.
Signed-off-by: Chalapathi V
---
include/hw/ssi/pnv_spi.h | 3 +
hw/ssi/pnv_spi.c | 237 +--
2 files changed, 81
There is a possibility that SPI controller can get into loop due to indefinite
RDR match failures. Hence put a limit to failures and stop the sequencer.
Signed-off-by: Chalapathi V
---
hw/ssi/pnv_spi.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv
On 16/12/2024 14.37, Ilya Leoshkevich wrote:
Compiling the s390x tests on Fedora, which has the s390x cross-compiler
installed, fails with:
In file included from qemu/tests/tcg/s390x/console.c:8:
qemu/tests/tcg/s390x/../../../pc-bios/s390-ccw/sclp.c:11:10: fatal error:
string.h: No su
It has been marked as deprecated two releases ago, so it should
be fine now to remove this command line option.
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst | 6 --
docs/about/removed-features.rst | 6 ++
system/vl.c | 9 -
qemu-options.hx
On Fri, Jan 03, 2025 at 11:13:05AM -0300, Fabiano Rosas wrote:
> The analyze-migration script was seen failing in s390x in misterious
> ways. It seems we're reaching the VMSDFieldStruct constructor without
> any fields, which would indicate an empty .subsection entry, a
> VMSTATE_STRUCT with no fie
> > > > You asked me for the opposite though, and I described how you can
> > > > share the cache. If you want a cache per thread, then you probably
> > > > want a node per thread.
> > > >
> > > > Rob
> > > >
> > >
> > > Hi Rob,
> > >
> > > That's right, I made the mistake in my prior message
On Fri, Jan 03, 2025 at 04:05:58PM +0100, Philippe Mathieu-Daudé wrote:
> As Daniel suggested [*]:
>
> > We should consider to rank HVF above TCG, on the basis
> > that HW acceleration is faster and should provide a
> > host<->guest security boundary that we don't claim for TCG
>
> [*] https://lo
On 3/1/25 16:00, Fabiano Rosas wrote:
Philippe Mathieu-Daudé writes:
The tests using the PL011 UART of the virt and raspi machines
weren't properly enabling the UART and its transmitter previous
to sending characters. Follow the PL011 manual initialization
recommendation by setting the proper
As Daniel suggested [*]:
> We should consider to rank HVF above TCG, on the basis
> that HW acceleration is faster and should provide a
> host<->guest security boundary that we don't claim for TCG
[*] https://lore.kernel.org/qemu-devel/z07yasl2pd3cp...@redhat.com/
Suggested-by: Daniel P. Berrangé
On Fri, Jan 03, 2025 at 03:57:02PM +0100, Thomas Huth wrote:
> When we introduced the deprecation rule of keeping deprecated features
> for two more releases, we had to state that we would not remove features
> by surprise that had already been marked as deprecated before. Nowadays,
> this paragrap
Philippe Mathieu-Daudé writes:
> The tests using the PL011 UART of the virt and raspi machines
> weren't properly enabling the UART and its transmitter previous
> to sending characters. Follow the PL011 manual initialization
> recommendation by setting the proper bits of the control register.
>
>
On 2/1/25 20:49, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
From: Philippe Mathieu-Daudé
AMSAT closed its email service [*] so my personal email
address is now defunct. Remove it to avoid bouncing emails.
[*]
https://forum.amsat-dl.org/index.php?thread/4581-amsat-mail-alias-service-
When we introduced the deprecation rule of keeping deprecated features
for two more releases, we had to state that we would not remove features
by surprise that had already been marked as deprecated before. Nowadays,
this paragraph is not needed anymore, so we can remove it now.
Signed-off-by: Tho
On 1/2/25 13:17, Philippe Mathieu-Daudé wrote:
From: Peter Xu
Now there's no user of container_get(), remove it.
Signed-off-by: Peter Xu
Reviewed-by: Philippe Mathieu-Daudé
Message-ID:<20241121192202.4155849-14-pet...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
include/qom/object.h
They are older than 6 years, so according to our machine support
policy, they can be removed now.
This removes the requirements for the storage keys "migration-enabled"
property which will be removed in the next patch. It also removes
the code that sets "max_revision" to 0 for some CCW devices, bu
The s390-ccw-virtio-2.8 machine is older than 6 years, so according to
our machine support policy, it can be removed now.
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-vir
Now that the last machine type that disabled cpu_model_allowed has
been removed, we can also remove the cpu_model_allowed flag itself
and all the related conditional code.
Signed-off-by: Thomas Huth
---
include/hw/s390x/s390-virtio-ccw.h | 3 ---
hw/s390x/s390-virtio-ccw.c | 9 +---
This property was only set to "off" by the old s390-ccw-virtio-2.4
machine type which has now been removed. So we can now remove the
property and the related code, too.
Signed-off-by: Thomas Huth
---
include/hw/s390x/storage-keys.h | 2 --
hw/s390x/s390-skeys.c | 10 +-
2 file
The s390-ccw-virtio-2.7 machine is older than 6 years, so according to
our machine support policy, it can be removed now.
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virti
The s390-ccw-virtio-2.6 machine is older than 6 years, so according to
our machine support policy, it can be removed now.
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 20
1 file changed, 20 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-
Now that the s390-ccw-virtio-2.8 machine has been removed, we don't
need the "adapter_routes_max_batch" property anymore and can remove it.
Signed-off-by: Thomas Huth
---
include/hw/s390x/s390_flic.h | 2 --
hw/intc/s390_flic.c | 9 -
hw/s390x/virtio-ccw.c| 5 ++---
3 fi
According to our support policy, we don't support machine types anymore
that are older than 6 years, so we can remove the very old 2.x machine
types now. Let's start by removing all s390-virtio-ccw machines up to
version 2.8. (This also helps to get rid of the problem that has been
described in: ht
On 1/2/25 13:18, Philippe Mathieu-Daudé wrote:
Only qemu_create_machine_containers() uses the
machine_containers[] array, restrict the scope
to this single user.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Peter Xu
---
system/vl.c | 16 +++-
1 file changed, 7 insertions(+),
Only s390-ccw-virtio-2.6 and older used to set this switch to "off",
for newer machine types it is always enabled. Since we removed the
old machine types now, we can also remove the switch in the code and
assume that it is always enabled now.
Signed-off-by: Thomas Huth
---
include/hw/s390x/s390-
Now that the s390-ccw-virtio-2.6 and older machine types have been
removed, the "css_dev_path" property of the css-bridge is also not
used anymore and thus can be removed.
This way we finally get rid of the problem that has been described
in: https://gitlab.com/qemu-project/qemu/-/issues/2213
Sig
Now that the old machine types that used this property have been
removed, we can remove the property and the corresponding code.
Signed-off-by: Thomas Huth
---
hw/s390x/ipl.h | 1 -
hw/s390x/ipl.c | 10 --
2 files changed, 11 deletions(-)
diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h
in
On 3/1/25 15:24, Richard Henderson wrote:
On 1/2/25 13:17, Philippe Mathieu-Daudé wrote:
When a QDev instance is realized, qdev_get_machine() ends up called.
In the next commit, qdev_get_machine() will require a "machine"
container to be always present. To satisfy this QOM containers design,
Imp
On 1/2/25 13:17, Philippe Mathieu-Daudé wrote:
From: Peter Xu
Use object_get_container() whenever applicable across the tree.
Signed-off-by: Peter Xu
Reviewed-by: Philippe Mathieu-Daudé
Message-ID:<20241121192202.4155849-13-pet...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
backends
On 1/2/25 13:17, Philippe Mathieu-Daudé wrote:
From: Peter Xu
Add a helper to fetch a root container (under object_get_root()). Sanity
check on the type of the object.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Peter Xu
Message-ID:<20241121192202.4155849
On 1/2/25 13:17, Philippe Mathieu-Daudé wrote:
From: Peter Xu
Use machine_get_container() whenever applicable across the tree.
Signed-off-by: Peter Xu
Reviewed-by: Philippe Mathieu-Daudé
Message-ID:<20241121192202.4155849-11-pet...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core
On 1/2/25 13:17, Philippe Mathieu-Daudé wrote:
From: Peter Xu
Add a helper to fetch machine containers. Add some sanity check around.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Peter Xu
Message-ID: <20241121192202.4155849-10-pet...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
1 - 100 of 131 matches
Mail list logo
