[PATCH] tests/unit: Really build pbkdf test on macOS

2024-09-16 Thread Philippe Mathieu-Daudé
Fix a typo to run the pbkdf crypto cipher tests on macOS. $ make check-unit ... 87/102 qemu:unit / test-crypto-pbkdf OK 2.35s 17 subtests passed Fixes: ebe0302ac8 ("tests/unit: build pbkdf test on macOS") Signed-off-by: Philippe Mathieu-Daudé --- tests/unit/test-crypto-pbkdf.

Re: [PATCH v1 6/7] qapi/migration: Introduce cpu-responsive-throttle parameter

2024-09-16 Thread Yong Huang
On Tue, Sep 17, 2024 at 4:55 AM Fabiano Rosas wrote: > Hyman Huang writes: > > > To enable the responsive throttle that will be implemented > > in the next commit, introduce the cpu-responsive-throttle > > parameter. > > > > Signed-off-by: Hyman Huang > > --- > > migration/migration-hmp-cmds.c

Re: [PATCH v1 3/7] qapi/migration: Introduce the iteration-count

2024-09-16 Thread Yong Huang
On Tue, Sep 17, 2024 at 4:35 AM Fabiano Rosas wrote: > Hyman Huang writes: > > > The original migration information dirty-sync-count could > > no longer reflect iteration count due to the introduction > > of background synchronization in the next commit; > > add the iteration count to compensate

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-16 Thread Yong Huang
On Tue, Sep 17, 2024 at 5:11 AM Fabiano Rosas wrote: > Hyman Huang writes: > > > shadow_bmap, iter_bmap and iter_dirty_pages are introduced > > to satisfy the need for background sync. > > > > Meanwhile, introduce enumeration of sync method. > > > > Signed-off-by: Hyman Huang > > --- > > inclu

Re: [PATCH] mac_dbdma: Remove leftover `dma_memory_unmap` calls

2024-09-16 Thread Mattias Nissler
Mark, thanks for testing and confirming that this doesn't cause any obvious breakage. For my curiosity, which path should this patch take to get into master? Peter, are you going to respin your pull request with this included? On Mon, Sep 16, 2024 at 11:06 PM Mark Cave-Ayland wrote: > > On 16/09

[PATCH] ppc/spapr: remove deprecated machines specific code

2024-09-16 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing the arch specific code for the now deprecated machine types. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c | 235 ---

Re: [PATCH] .gitlab-ci.d/crossbuilds.yml: Force 'make check' to -j2 for cross-i686-tci

2024-09-16 Thread Thomas Huth
On 16/09/2024 15.49, Peter Maydell wrote: In commit 1374ed49e1453c300 we forced the cross-i686-tci job to -j1 to see if this helped with test timeouts. It seems to help with that but on the other hand we now sometimes run into the overall 60 minute job timeout. Try -j2 instead. Signed-off-by: Pe

Re: [PATCH] target/ppc: Fix inequality check in do_lstxv_X

2024-09-16 Thread Harsh Prateek Bora
Hi Fabiano, On 9/13/24 17:02, Fabiano Rosas wrote: Harsh Prateek Bora writes: This fix was earlier introduced for do_lstxv_D form with 2cc0e449d173 however got missed for _X form. This patch fixes the same. Cc: qemu-sta...@nongnu.org Suggested-by: Fabiano Rosas Fixes: 70426b5bb738 ("target/

Re: [PATCH v3 09/10] target/ppc: simplify var usage in ppc_next_unmasked_interrupt

2024-09-16 Thread Harsh Prateek Bora
On 9/13/24 18:20, BALATON Zoltan wrote: On Fri, 13 Sep 2024, Harsh Prateek Bora wrote: As previously done for arch specific handlers, simplify var usage in ppc_next_unmasked_interrupt by caching the env->pending_interrupts and env->spr[SPR_LPCR] in local vars and using it later at multiple pl

Re: [PULL 20/49] spapr: Tag pseries-2.1 - 2.11 machines as deprecated

2024-09-16 Thread Harsh Prateek Bora
Hi Cedric, On 9/16/24 18:44, Cédric Le Goater wrote: Hello Harsh, On 2/19/24 09:29, Nicholas Piggin wrote: From: Cédric Le Goater pseries machines before version 2.11 have undergone many changes to correct issues, mostly regarding migration compatibility. This is obfuscating the code useless

[PATCH] ui/cursor: remove cursor_get_mono_image

2024-09-16 Thread dave
From: "Dr. David Alan Gilbert" cursor_get_mono_image has been unused since 2018's 0015ca5cba ("ui: remove support for SDL1.2 in favour of SDL2") Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/ui/console.h | 1 - ui/cursor.c | 24 2 files chan

[PATCH] hw/xen: Remove deadcode

2024-09-16 Thread dave
From: "Dr. David Alan Gilbert" xen_be_copy_grant_refs is unused since 2019's 19f87870ba ("xen: remove the legacy 'xen_disk' backend") xen_config_dev_console is unused since 2018's 6d7c06c213 ("Remove broken Xen PV domain builder") Remove them. Signed-off-by: Dr. David Alan Gilbert --- hw

[PATCH] block-backend: Remove deadcode

2024-09-16 Thread dave
From: "Dr. David Alan Gilbert" blk_by_public last use was removed in 2017 by c61791fc23 ("block: add aio_context field in ThrottleGroupMember") blk_activate last use was removed earlier this year by eef0bae3a7 ("migration: Remove block migration") blk_add_insert_bs_notifier, blk_op_block_al

[PATCH] block: Remove unused aio_task_pool_empty

2024-09-16 Thread dave
From: "Dr. David Alan Gilbert" aio_task_pool_empty has been unused since it was added in 6e9b225f73 ("block: introduce aio task pool") Remove it. Signed-off-by: Dr. David Alan Gilbert --- block/aio_task.c | 5 - include/block/aio_task.h | 2 -- 2 files changed, 7 deletions(-) d

Re: [PATCH v1 4/4] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-09-16 Thread Stefano Stabellini
On Mon, 16 Sep 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Enable PCI support for the ARM Xen PVH machine. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > hw/arm/xen-pvh.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --gi

Re: [PATCH v1 3/4] hw/xen: xenpvh: Add pci-intx-irq-base property

2024-09-16 Thread Stefano Stabellini
On Mon, 16 Sep 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Acked-by: Stefano Stabellini > --- > hw/xen/xen-pvh-common.c | 36 > 1 file changed, 36 insertions(+) > > diff --git a/hw/xen/xen-pvh-common.c

Re: [PATCH v1 2/4] hw/xen: xenpvh: Disable buffered IOREQs for ARM

2024-09-16 Thread Stefano Stabellini
On Mon, 16 Sep 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add a way to enable/disable buffered IOREQs for PVH machines > and disable them for ARM. ARM does not support buffered > IOREQ's nor the legacy way to map IOREQ info pages. > > See the following for more details: > htt

Re: [PATCH v1 1/4] xen: Expose handle_bufioreq in xen_register_ioreq

2024-09-16 Thread Stefano Stabellini
On Mon, 16 Sep 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Expose handle_bufioreq in xen_register_ioreq(). > This is to allow machines to enable or disable buffered ioreqs. > > No functional change since all callers still set it to > HVM_IOREQSRV_BUFIOREQ_ATOMIC. > > Signed-o

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-16 Thread Fabiano Rosas
Hyman Huang writes: > shadow_bmap, iter_bmap and iter_dirty_pages are introduced > to satisfy the need for background sync. > > Meanwhile, introduce enumeration of sync method. > > Signed-off-by: Hyman Huang > --- > include/exec/ramblock.h | 45 + > migra

Re: [PATCH] mac_dbdma: Remove leftover `dma_memory_unmap` calls

2024-09-16 Thread Mark Cave-Ayland
On 16/09/2024 18:57, Mattias Nissler wrote: These were passing a NULL buffer pointer unconditionally, which happens to behave in a mostly benign way (except for the chance of an excess memory region unref and a bounce buffer leak). Per the function comment, this was never meant to be accepted th

Re: [PATCH v1 6/7] qapi/migration: Introduce cpu-responsive-throttle parameter

2024-09-16 Thread Fabiano Rosas
Hyman Huang writes: > To enable the responsive throttle that will be implemented > in the next commit, introduce the cpu-responsive-throttle > parameter. > > Signed-off-by: Hyman Huang > --- > migration/migration-hmp-cmds.c | 8 > migration/options.c| 20 ++

Re: [PATCH v1 5/7] migration: Support background dirty bitmap sync and throttle

2024-09-16 Thread Fabiano Rosas
Hyman Huang writes: > When VM is configured with huge memory, the current throttle logic > doesn't look like to scale, because migration_trigger_throttle() > is only called for each iteration, so it won't be invoked for a long > time if one iteration can take a long time. > > The background sync

Re: [PATCH v1 3/7] qapi/migration: Introduce the iteration-count

2024-09-16 Thread Fabiano Rosas
Hyman Huang writes: > The original migration information dirty-sync-count could > no longer reflect iteration count due to the introduction > of background synchronization in the next commit; > add the iteration count to compensate. I agree with the overall idea, but I feel we're lacking some in

Re: [PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge

2024-09-16 Thread Cédric Le Goater
On 9/13/24 16:48, Thomas Huth wrote: The pci-bridge device is not usable on s390x, so introduce a Kconfig switch that allows to disable it. Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci-bridge/Kconfig | 5 + hw/pci-bridge/meson.build | 2 +-

[PULL 10/12] aspeed/soc: Support I2C for AST2700

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin Add I2C model for AST2700 I2C support. The I2C controller registers base address is start at 0x14C0_F000 and its address space is 0x2000. The AST2700 I2C controller has one source INTC per bus. I2C buses interrupt are connected to GICINT130_INTC from bit 0 to bit 15. I2C bus 0 is

[PULL 11/12] aspeed: Add tmp105 in i2c bus 0 for AST2700

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin ASPEED SDK add lm75 in i2c bus 0 for AST2700. LM75 is compatible with TMP105 driver. Introduce a new i2c init function and add tmp105 device model in i2c bus 0. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/arm/aspeed.c | 10 ++ 1 file changed, 10 inse

[PULL 03/12] hw/i2c/aspeed: Introduce a new bus pool buffer attribute in AspeedI2Cbus

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin According to the datasheet of ASPEED SOCs, each I2C bus has their own pool buffer since AST2500. Only AST2400 utilized a pool buffer share to all I2C bus. Besides, using a share pool buffer only support pool buffer memory regions are continuous for all I2C bus. To make this model

[PULL 09/12] aspeed/soc: Introduce a new API to get the device irq

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin Currently, users can set the INTC mapping table with enumerated device id and device irq to get the INTC orgate input pins. However, some devices use the continuous source numbers in the same INTC orgate. To reduce the enumerated device id definition, create a new API to get the I

[PULL 01/12] hw/gpio/aspeed_gpio: Avoid shift into sign bit

2024-09-16 Thread Cédric Le Goater
From: Peter Maydell In aspeed_gpio_update() we calculate "mask = 1 << gpio", where gpio can be between 0 and 31. Coverity complains about this because 1 << 31 won't fit in a signed integer. For QEMU this isn't an error because we enable -fwrapv, but we can keep Coverity happy by doing the shift

[PULL 02/12] hw/i2c/aspeed: Support discontinuous register memory region of I2C bus

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin It only support continuous register memory region for all I2C bus. However, the register address of all I2c bus are discontinuous for AST2700. Ex: the register address of I2C bus for ast2700 as following. 0x100 - 0x17F: Device 0 0x200 - 0x27F: Device 1 0x300 - 0x37F: Device 2 0x4

[PULL 07/12] hw/i2c/aspeed: Add support for Tx/Rx buffer 64 bit addresses

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin ASPEED AST2700 SOC is a 64 bits quad core CPUs (Cortex-a35) and the base address of dram is "0x4 " which is 64bits address. It has "Master DMA Mode Tx Buffer Base Address[39:32](0x60)" and "Master DMA Mode Rx Buffer Base Address[39:32](0x64)" registers to save the high pa

[PULL 05/12] hw/i2c/aspeed: Introduce a new dma_dram_offset attribute in AspeedI2Cbus

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin The "Current DMA Operating Address Status(0x50)" register of I2C new mode has been removed in AST2700. This register is used for debugging and it is a read only register. To support AST2700 DMA mode, introduce a new dma_dram_offset class attribute in AspeedI2Cbus to save the curr

[PULL 12/12] machine_aspeed.py: Update to test I2C for AST2700

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin Update test case to test lm75 temperature sensor. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 16 1 file changed, 16 insertions(+) diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py

[PULL 04/12] hw/i2c/aspeed: Support discontinuous poll buffer memory region of I2C bus

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin It only support continuous pool buffer memory region for all I2C bus. However, the pool buffer address of all I2c bus are discontinuous for AST2700. Ex: the pool buffer address of I2C bus for ast2700 as following. 0x1A0 - 0x1BF: Device 0 buffer 0x2A0 - 0x2BF: Device 1 buffer 0x3A

[PULL 08/12] hw/i2c/aspeed: Add support for 64 bit addresses

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin ASPEED AST2700 SOC is a 64 bits quad core CPUs (Cortex-a35) and the base address of dram is "0x4 " which is 64bits address. The AST2700 support the maximum DRAM size is 8 GB. The DRAM physical address range is from "0x4__" to "0x5__". The DRAM offset rang

[PULL 06/12] hw/i2c/aspeed: Add AST2700 support

2024-09-16 Thread Cédric Le Goater
From: Jamin Lin Introduce a new ast2700 class to support AST2700. The I2C bus register memory regions and I2C bus pool buffer memory regions are discontinuous and they do not back compatible AST2600. Add a new ast2700 i2c class init function to match the address of I2C bus register and pool buff

[PULL 00/12] aspeed queue

2024-09-16 Thread Cédric Le Goater
The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging (2024-09-15 18:27:40 +0100) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspeed-2024091

[PATCH] tests/qtest: Add XIVE tests for the powernv10 machine

2024-09-16 Thread Michael Kowal
From: Frederic Barrat These XIVE tests include: - General interrupt IRQ tests that: - enable and trigger an interrupt - acknowledge the interrupt - end of interrupt processing - Test the Pull Thread Context to Odd Thread Reporting Line - Test the different cache flush inject and queue sync

[PATCH 1/1] target/riscv: enable floating point unit

2024-09-16 Thread Heinrich Schuchardt
OpenSBI enables the floating point in mstatus. For consistency QEMU/KVM should do the same. Without this patch EDK II with TLS enabled crashes when hitting the first floating point instruction while running QEMU with --accel kvm and runs fine with --accel tcg. Additionally to this patch EDK II sh

Re: [PATCH v7 00/17] bsd-user: Comprehensive RISCV Support

2024-09-16 Thread Daniel Henrique Barboza
On 9/16/24 12:51 PM, Ajeet Singh wrote: Key Changes Compared to Version 6: Included "signal-common.h" in target_arch_cpu.h Thanks. This version is successfully compiling in a FreeBSD x86 host. Daniel Mark Corbin (15): bsd-user: Implement RISC-V CPU initialization and main loop bsd

[PATCH] mac_dbdma: Remove leftover `dma_memory_unmap` calls

2024-09-16 Thread Mattias Nissler
These were passing a NULL buffer pointer unconditionally, which happens to behave in a mostly benign way (except for the chance of an excess memory region unref and a bounce buffer leak). Per the function comment, this was never meant to be accepted though, and triggers an assertion with the "softm

Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-16 Thread Stefan Hajnoczi
This patch series could use tests. The first two patches seem broken and testing would have revealed that the memory allocation and pointers are not quite right. One testing approach is to write a test device using libvhost-user that exposes VIRTIO Shared Memory Regions, launch QEMU in qtest mode

Re: [PATCH v3 1/4] KVM: Dynamic sized kvm memslots array

2024-09-16 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> Zhiyi reported an infinite loop issue in VFIO use case. The cause of that >> was a separate discussion, however during that I found a regression of >> dirty sync slowness when profiling. >> >> Each KVMMemoryListerner maintains an array of kvm memslo

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
On Mon, Sep 16, 2024 at 3:06 PM Cédric Le Goater wrote: > > On 9/16/24 14:41, Mattias Nissler wrote: > > Thanks Cédric, I can reproduce now, and my proposed patch fixes avoids > > the crash as expected. > disk images for macos9 and macosx10 all boot. Thanks for testing, happy to hear! I will go

Re: [PATCH v3 1/4] KVM: Dynamic sized kvm memslots array

2024-09-16 Thread Fabiano Rosas
Peter Xu writes: > Zhiyi reported an infinite loop issue in VFIO use case. The cause of that > was a separate discussion, however during that I found a regression of > dirty sync slowness when profiling. > > Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's > statically

[PATCH v6 15/15] bios-tables-test: Add data for complex numa test (GI, GP etc)

2024-09-16 Thread Jonathan Cameron via
Given this is a new configuration, there are affects on APIC, CEDT and DSDT, but the key elements are in SRAT (plus related data in HMAT). The configuration has node to exercise many different combinations. 0) CPUs + Memory 1) GI only 2) GP only 3) CPUS only 4) Memory only 5) CPUs + HP memory GI

[PATCH v6 14/15] bios-tables-test: Add complex SRAT / HMAT test for GI GP

2024-09-16 Thread Jonathan Cameron via
Add a test with 6 nodes to exercise most interesting corner cases of SRAT and HMAT generation including the new Generic Initiator and Generic Port Affinity structures. More details of the set up in the following patch adding the table data. Signed-off-by: Jonathan Cameron --- tests/qtest/bios-t

[PATCH v6 13/15] bios-tables-test: Allow for new acpihmat-generic-x test data.

2024-09-16 Thread Jonathan Cameron via
The test to be added exercises many corner cases of the SRAT and HMAT table generation. Signed-off-by: Jonathan Cameron --- tests/qtest/bios-tables-test-allowed-diff.h | 5 + tests/data/acpi/x86/q35/APIC.acpihmat-generic-x | 0 tests/data/acpi/x86/q35/CEDT.acpihmat-generic-x | 0 tests/d

[PATCH v6 12/15] hw/acpi: Generic Initiator - add missing object class property descriptions.

2024-09-16 Thread Jonathan Cameron via
>From review of the Generic Ports support. These properties had no description set so add one. Signed-off-by: Jonathan Cameron --- v6: New patch based on Igor's review of Generic Ports patch. --- hw/acpi/pci.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c

[PATCH v6 11/15] hw/acpi: Make storage of node id uint32_t to reduce fragility

2024-09-16 Thread Jonathan Cameron via
>From review of generic port introduction. The value is handled as a uint32_t so store it in that type. The value cannot in reality exceed MAX_NODES which is currently 128 but if the types are matched there is no need to rely on that restriction. Signed-off-by: Jonathan Cameron --- v6: New patch

[PATCH v6 10/15] hw/acpi: Generic Port Affinity Structure support

2024-09-16 Thread Jonathan Cameron via
These are very similar to the recently added Generic Initiators but instead of representing an initiator of memory traffic they represent an edge point beyond which may lie either targets or initiators. Here we add these ports such that they may be targets of hmat_lb records to describe the latenc

[PATCH 6/6] hw/pci-bridge/cxl-upstream: Add properties to control link speed and width

2024-09-16 Thread Jonathan Cameron via
To establish performance characteristics of a CXL device when used via a particular CXL topology (root ports, switches, end points) it is necessary to set the appropriate link speed and width in the PCI Express capability structure. Provide x-speed and x-link properties for this. Signed-off-by: J

[PATCH 5/6] hw/mem/cxl-type3: Add properties to control link speed and width

2024-09-16 Thread Jonathan Cameron via
To establish performance characteristics of a CXL device when used via a particular CXL topology (root ports, switches, end points) it is necessary to set the appropriate link speed and width in the PCI Express capability structure. Provide x-speed and x-link properties for this. Signed-off-by: J

[PATCH 4/6] hw/pcie: Provide a utility function for control of EP / SW USP link

2024-09-16 Thread Jonathan Cameron via
Whilst similar to existing PCIESlot link configuration a few registers need to be set differently so that the downstream device presents a 'configured' state that is then used to 'train' the upstream port on the link. Basically that means setting the status register to reflect it succeeding in tra

[PATCH 3/6] hw/pcie: Factor out PCI Express link register filling common to EP.

2024-09-16 Thread Jonathan Cameron via
Whilst not all link related registers are common between RP / Switch DSP and EP / Switch USP many of them are. Factor that group out to save on duplication when adding EP / Swtich USP configurability. Signed-off-by: Jonathan Cameron --- hw/pci/pcie.c | 87 ---

[PATCH 2/6] hw/pci-bridge/cxl_upstream: Provide x-speed and x-width properties.

2024-09-16 Thread Jonathan Cameron via
Copied from gen_pcie_root_port.c Drop the previous code that ensured a valid value in s->width, s->speed as now a default is provided so this will always be set. Note this changes the default settings but it is unlikely to have a negative effect on software as will only affect ports with now downs

[PATCH 1/6] hw/pci-bridge/cxl_root_port: Provide x-speed and x-width properties.

2024-09-16 Thread Jonathan Cameron via
Approach copied from gen_pcie_root_port.c Previously the link defaulted to a maximum of 2.5GT/s and 1x. Enable setting it's maximum values. The actual value after 'training' will depend on the downstream device configuration. Signed-off-by: Jonathan Cameron --- hw/pci-bridge/cxl_root_port.c |

[PATCH qemu 0/6] hw/cxl: Link speed and width control

2024-09-16 Thread Jonathan Cameron via
Changes since RFC: - rebase Question: - I could enable this for all PCIe device (including ports). Does that makes sense, or is it better to limit this to my cases? It is quite easy to build broken setups (downstream device reports faster link than the port etc) because QEMU 'link' training'

Re: [PATCH v3 2/5] virtio: Track shared memory mappings

2024-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:53:32PM +0200, Albert Esteve wrote: > Update shmem_list to be able to track > active mappings on VIRTIO shared memory > regions. This allows to verify that new > mapping request received from backends > do not overlap. If they do, the request > shall fail in order to adhe

Re: [PATCH v3 1/5] vhost-user: Add VIRTIO Shared Memory map request

2024-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:53:31PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/UNMAP requests to vhost-user to > handle VIRTIO Shared Memory mappings. > > This request allows backends to dynamically map > fds into a VIRTIO Shared Memory Region indentified > by its `shmid`. Then, the fd memory is a

[PATCH v6 09/15] hw/pci-host/gpex-acpi: Use acpi_uid property.

2024-09-16 Thread Jonathan Cameron via
Reduce the direct use of PCI internals inside ACPI table creation. Suggested-by: Igor Mammedov Tested-by: "Huang, Ying" Reviewed-by: Igor Mammedov Signed-off-by: Jonathan Cameron --- hw/pci-host/gpex-acpi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/gp

[PATCH v6 08/15] hw/i386/acpi: Use TYPE_PXB_BUS property acpi_uid for DSDT

2024-09-16 Thread Jonathan Cameron via
Rather than relying on PCI internals, use the new acpi_property to obtain the ACPI _UID values. These are still the same as the PCI Bus numbers so no functional change. Suggested-by: Igor Mammedov Tested-by: "Huang, Ying" Reviewed-by: Igor Mammedov Signed-off-by: Jonathan Cameron --- hw/i386

[PATCH v6 07/15] hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS

2024-09-16 Thread Jonathan Cameron via
Enable ACPI table creation for PCI Expander Bridges to be independent of PCI internals. Note that the UID is currently the PCI bus number. This is motivated by the forthcoming ACPI Generic Port SRAT entries which can be made completely independent of PCI internals. Suggested-by: Igor Mammedov Te

[PATCH v6 06/15] acpi/pci: Move Generic Initiator object handling into acpi/pci.*

2024-09-16 Thread Jonathan Cameron via
Whilst ACPI SRAT Generic Initiator Afinity Structures are able to refer to both PCI and ACPI Device Handles, the QEMU implementation only implements the PCI Device Handle case. For now move the code into the existing hw/acpi/pci.c file and header. If support for ACPI Device Handles is added in th

[PATCH v6 05/15] hw/pci: Add a busnr property to pci_props and use for acpi/gi

2024-09-16 Thread Jonathan Cameron via
Using a property allows us to hide the internal details of the PCI device from the code to build a SRAT Generic Initiator Affinity Structure with PCI Device Handle. Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Signed-off-by: Jonathan Cameron --- hw/acpi/acpi_generic_initiator.c | 14

[PATCH v6 04/15] hw/acpi: Rename build_all_acpi_generic_initiators() to build_acpi_generic_initiator()

2024-09-16 Thread Jonathan Cameron via
Igor noted that this function only builds one instance, so was rather misleadingly named. Fix that. Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Tested-by: "Huang, Ying" Signed-off-by: Jonathan Cameron --- hw/acpi/acpi_generic_initiator.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v6 03/15] hw/acpi: Move AML building code for Generic Initiators to aml_build.c

2024-09-16 Thread Jonathan Cameron via
Rather than attempting to create a generic function with mess of the two different device handle types, use a PCI handle specific variant. If the ACPI handle form is needed then that can be introduced alongside this with little duplicated code. Drop the PCIDeviceHandle in favor of just passing th

[PATCH v6 02/15] hw/acpi/GI: Fix trivial parameter alignment issue.

2024-09-16 Thread Jonathan Cameron via
Before making additional modification, tidy up this misleading indentation. Reviewed-by: Ankit Agrawal Reviewed-by: Igor Mammedov Tested-by: "Huang, Ying" Signed-off-by: Jonathan Cameron --- hw/acpi/acpi_generic_initiator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h

[PATCH v6 01/15] hw/acpi: Fix ordering of BDF in Generic Initiator PCI Device Handle.

2024-09-16 Thread Jonathan Cameron via
The ordering in ACPI specification [1] has bus number in the lowest byte. As ACPI tables are little endian this is the reverse of the ordering used by PCI_BUILD_BDF(). As a minimal fix split the QEMU BDF up into bus and devfn and write them as single bytes in the correct order. [1] ACPI Spec 6.3,

[PATCH v6 00/15] acpi: NUMA nodes for CXL HB as GP + complex NUMA test

2024-09-16 Thread Jonathan Cameron via
v6 changes: - 2 new patches (11 and 12) to improve things in existing code after Igor pointed them out in the new code. - More detailed example provided for docs for control of Generic Ports. This has proved a difficult concept to convey. Note there is one question Igor raised for Markus: -

Re: [PATCH 0/3] Document SHMEM vhost-user requests

2024-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:44:29PM +0200, Albert Esteve wrote: > As a continuation of the > "Add SHMEM_MAP/UNMAP requests" patch [1], > I wanted to split vhost-user spec > parts into a separate patch, so that > it could be reviewed and integrated > separately. Having the specs upstreamed > would he

Re: [PATCH 1/3] vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec

2024-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:44:30PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/_UNMAP request to the vhost-user > spec documentation. > > Signed-off-by: Albert Esteve > --- > docs/interop/vhost-user.rst | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/do

Re: [PATCH 3/3] vhost_user.rst: Add GET_SHMEM_CONFIG message

2024-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:44:32PM +0200, Albert Esteve wrote: > Add GET_SHMEM_CONFIG vhost-user frontend > message to the spec documentation. > > Signed-off-by: Albert Esteve > --- > docs/interop/vhost-user.rst | 39 + > 1 file changed, 39 insertions(+) > >

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

2024-09-16 Thread Brian Cain
On 9/16/2024 11:05 AM, Brian Cain wrote: On 9/16/2024 10:47 AM, Alex Bennée wrote: Brian Cain writes: On 9/16/2024 8:12 AM, Alex Bennée wrote: Brian Cain writes: On 9/6/2024 9:39 PM, Brian Cain wrote: With newer clang builds (19.x), there's a warning for implicit function declaration

Re: [PATCH 1/3] vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec

2024-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:44:30PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/_UNMAP request to the vhost-user > spec documentation. > > Signed-off-by: Albert Esteve > --- > docs/interop/vhost-user.rst | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/do

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

2024-09-16 Thread Brian Cain
On 9/16/2024 10:47 AM, Alex Bennée wrote: Brian Cain writes: On 9/16/2024 8:12 AM, Alex Bennée wrote: Brian Cain writes: On 9/6/2024 9:39 PM, Brian Cain wrote: With newer clang builds (19.x), there's a warning for implicit function declarations and it rejects linux-test.c. glibc/musl's

[PATCH v7 16/17] bsd-user: Implement set_mcontext and get_ucontext_sigreturn for RISCV

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added implementations for 'set_mcontext' and 'get_ucontext_sigreturn' functions for RISC-V architecture, Both functions ensure that the CPU state and user context are properly managed. Signed-off-by: Mark Corbin Signed-off-by: Warner Losh Signed-off-by: Ajeet Singh Co-author

[PATCH v7 01/17] bsd-user: Implement RISC-V CPU initialization and main loop

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added the initial implementation for RISC-V CPU initialization and main loop. This includes setting up the general-purpose registers and program counter based on the provided target architecture definitions. Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Co-authored-by

[PATCH v7 00/17] bsd-user: Comprehensive RISCV Support

2024-09-16 Thread Ajeet Singh
Key Changes Compared to Version 6: Included "signal-common.h" in target_arch_cpu.h Mark Corbin (15): bsd-user: Implement RISC-V CPU initialization and main loop bsd-user: Add RISC-V CPU execution loop and syscall handling bsd-user: Implement RISC-V CPU register cloning and reset functions

[PATCH v7 10/17] bsd-user: Define RISC-V VM parameters and helper functions

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added definitions for RISC-V VM parameters, including maximum and default sizes for text, data, and stack, as well as address space limits. Implemented helper functions for retrieving and setting specific values in the CPU state, such as stack pointer and return values. Signed-

[PATCH v7 17/17] bsd-user: Add RISC-V 64-bit Target Configuration and Debug XML Files

2024-09-16 Thread Ajeet Singh
From: Warner Losh Added configuration for RISC-V 64-bit target to the build system. Signed-off-by: Warner Losh Signed-off-by: Ajeet Singh Reviewed-by: Richard Henderson --- configs/targets/riscv64-bsd-user.mak | 4 1 file changed, 4 insertions(+) create mode 100644 configs/targets/risc

[PATCH v7 12/17] bsd-user: Add generic RISC-V64 target definitions

2024-09-16 Thread Ajeet Singh
From: Warner Losh Added a generic definition for RISC-V64 target-specific details. Implemented the 'regpairs_aligned' function,which returns 'false' to indicate that register pairs are not aligned in the RISC-V64 ABI. Signed-off-by: Warner Losh Signed-off-by: Ajeet Singh Reviewed-by: Richard H

[PATCH v7 13/17] bsd-user: Define RISC-V signal handling structures and constants

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added definitions for RISC-V signal handling, including structures and constants for managing signal frames and context Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Co-authored-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/riscv/target_arch_signal.h

[PATCH v7 07/17] bsd-user: Add RISC-V signal trampoline setup function

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Implemented the 'setup_sigtramp' function for setting up the signal trampoline code in the RISC-V architecture. Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Reviewed-by: Richard Henderson --- bsd-user/riscv/target_arch_sigtramp.h | 41 +++ 1

[PATCH v7 14/17] bsd-user: Implement RISC-V signal trampoline setup functions

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added functions for setting up the RISC-V signal trampoline and signal frame: 'set_sigtramp_args()': Configures the RISC-V CPU state with arguments for the signal handler. It sets up the registers with the signal number,pointers to the signal info and user context, the signal h

[PATCH v7 08/17] bsd-user: Implement RISC-V sysarch system call emulation

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added the 'do_freebsd_arch_sysarch' function to emulate the 'sysarch' system call for the RISC-V architecture. Currently, this function returns '-TARGET_EOPNOTSUPP' to indicate that the operation is not supported. Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Reviewed

[PATCH v7 11/17] bsd-user: Define RISC-V system call structures and constants

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Introduced definitions for the RISC-V system call interface, including the 'target_pt_regs' structure that outlines the register storage layout during a system call. Added constants for hardware machine identifiers. Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Co-aut

[PATCH v7 04/17] bsd-user: Implement RISC-V TLS register setup

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Included the prototype for the 'target_cpu_set_tls' function in the 'target_arch.h' header file. This function is responsible for setting the Thread Local Storage (TLS) register for RISC-V architecture. Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Reviewed-by: Richar

[PATCH v7 15/17] bsd-user: Implement 'get_mcontext' for RISC-V

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added the 'get_mcontext' function to extract and populate the RISC-V machine context from the CPU state. This function is used to gather the current state of the general-purpose registers and store it in a 'target_mcontext_' structure. Signed-off-by: Mark Corbin Signed-off-by:

[PATCH v7 03/17] bsd-user: Implement RISC-V CPU register cloning and reset functions

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added functions for cloning CPU registers and resetting the CPU state for RISC-V architecture. Signed-off-by: Mark Corbin Signed-off-by: Ajeet Singh Reviewed-by: Richard Henderson --- bsd-user/riscv/target_arch_cpu.h | 14 ++ 1 file changed, 14 insertions(+) di

[PATCH v7 09/17] bsd-user: Add RISC-V thread setup and initialization support

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Implemented functions for setting up and initializing threads in the RISC-V architecture. The 'target_thread_set_upcall' function sets up the stack pointer, program counter, and function argument for new threads. The 'target_thread_init' function initializes thread registers bas

[PATCH v7 06/17] bsd-user: Define RISC-V register structures and register copying

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Added definitions for RISC-V register structures, including general-purpose registers and floating-point registers, in 'target_arch_reg.h'. Implemented the 'target_copy_regs' function to copy register values from the CPU state to the target register structure, ensuring proper en

[PATCH v7 02/17] bsd-user: Add RISC-V CPU execution loop and syscall handling

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Implemented the RISC-V CPU execution loop, including handling various exceptions and system calls. The loop continuously executes CPU instructions,processes exceptions, and handles system calls by invoking FreeBSD syscall handlers. Signed-off-by: Mark Corbin Signed-off-by: Aje

[PATCH v7 05/17] bsd-user: Add RISC-V ELF definitions and hardware capability detection

2024-09-16 Thread Ajeet Singh
From: Mark Corbin Introduced RISC-V specific ELF definitions and hardware capability detection. Additionally, a function to retrieve hardware capabilities ('get_elf_hwcap') is implemented, which returns the common bits set in each CPU's ISA strings. Signed-off-by: Mark Corbin Signed-off-by: Aje

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

2024-09-16 Thread Alex Bennée
Brian Cain writes: > On 9/16/2024 8:12 AM, Alex Bennée wrote: >> Brian Cain writes: >> >>> On 9/6/2024 9:39 PM, Brian Cain wrote: With newer clang builds (19.x), there's a warning for implicit function declarations and it rejects linux-test.c. glibc/musl's readdir64() declara

Re: [External] Re: [PATCH v5 08/13] migration/multifd: Add new migration option for multifd DSA offloading.

2024-09-16 Thread Fabiano Rosas
Yichen Wang writes: > On Wed, Jul 24, 2024 at 7:50 AM Markus Armbruster wrote: >> >> Fabiano Rosas writes: >> >> > Yichen Wang writes: >> > >> >> On Thu, Jul 11, 2024 at 2:53 PM Yichen Wang >> >> wrote: >> >> >> >>> diff --git a/migration/options.c b/migration/options.c >> >>> index 645f5500

[PATCH v1 3/4] hw/xen: xenpvh: Add pci-intx-irq-base property

2024-09-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-pvh-common.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c index 76a9b2b945..218ac851cf 100644 --- a/hw/xen/xen-pvh-common.c ++

[PATCH v1 4/4] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-09-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable PCI support for the ARM Xen PVH machine. Signed-off-by: Edgar E. Iglesias --- hw/arm/xen-pvh.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c index 28af3910ea..33f0dd5982 100644 --- a/hw/arm/xen-pvh.c +++

[PATCH v1 0/4] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-09-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable PCI on the ARM PVH machine. First we add a way to control the use of buffered IOREQ's since those are not supported on Xen/ARM. Finally we enable the PCI support. I've published some instructions on how to try this including the work in progress Xen side of the P

[PATCH v1 1/4] xen: Expose handle_bufioreq in xen_register_ioreq

2024-09-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Expose handle_bufioreq in xen_register_ioreq(). This is to allow machines to enable or disable buffered ioreqs. No functional change since all callers still set it to HVM_IOREQSRV_BUFIOREQ_ATOMIC. Signed-off-by: Edgar E. Iglesias --- hw/i386/xen/xen-hvm.c |

  1   2   >