Re: [PATCH v3 07/14] tcg/riscv: Add support for basic vector opcodes

2024-09-04 Thread Richard Henderson
On 9/4/24 07:27, LIU Zhiwei wrote: From: TANG Tiancheng Signed-off-by: TANG Tiancheng Reviewed-by: Liu Zhiwei --- tcg/riscv/tcg-target-con-set.h | 1 + tcg/riscv/tcg-target.c.inc | 46 ++ tcg/riscv/tcg-target.h | 2 +- 3 files changed, 48 insert

Re: [PATCH v3 06/14] tcg/riscv: Implement vector mov/dup{m/i}

2024-09-04 Thread Richard Henderson
On 9/4/24 07:27, LIU Zhiwei wrote: @@ -698,6 +704,21 @@ static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg) case TCG_TYPE_I64: tcg_out_opc_imm(s, OPC_ADDI, ret, arg, 0); break; +case TCG_TYPE_V64: +case TCG_TYPE_V128: +case TCG_TYPE_

Re: [PATCH v3 05/14] tcg/riscv: Implement vector load/store

2024-09-04 Thread Richard Henderson
On 9/4/24 07:27, LIU Zhiwei wrote: @@ -811,31 +849,52 @@ static void tcg_out_extrl_i64_i32(TCGContext *s, TCGReg ret, TCGReg arg) tcg_out_ext32s(s, ret, arg); } -static void tcg_out_ldst(TCGContext *s, RISCVInsn opc, TCGReg data, - TCGReg addr, intptr_t offset

Re: [PATCH v9 3/5] migration: Add migration parameters for QATzip

2024-09-04 Thread Prasad Pandit
On Sat, 31 Aug 2024 at 04:58, Yichen Wang wrote: > +/* > + * 1: best speed, ... 9: best compress ratio > + * There is some nuance here. Refer to QATzip documentation to understand > + * the mapping of QATzip levels to standard deflate levels. > + */ > +#define DEFAULT_MIGRATE_MULTIFD_QATZIP_LEVEL

Re: qemu direct kernel boot on LoongArch

2024-09-04 Thread maobibo
On 2024/9/5 下午1:25, Thomas Weißschuh wrote: On 2024-09-05 06:04:12+, Jason A. Donenfeld wrote: On Thu, Sep 5, 2024 at 5:45 AM maobibo wrote: Jason, With the latest qemu 9.1 version, elf format booting is supported. Thanks, I just figured this out too, about 4 minutes ago. Excellent.

Re: [PATCH v3 04/14] tcg/riscv: Add riscv vset{i}vli support

2024-09-04 Thread Richard Henderson
On 9/4/24 07:27, LIU Zhiwei wrote: From: TANG Tiancheng In RISC-V, vector operations require initial configuration using the vset{i}vl{i} instruction. This instruction: 1. Sets the vector length (vl) in bytes 2. Configures the vtype register, which includes: SEW (Single Element Widt

Re: [PATCH v2 01/19] qapi: Smarter camel_to_upper() to reduce need for 'prefix'

2024-09-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 04, 2024 at 01:18:18PM +0200, Markus Armbruster wrote: >> camel_to_upper() converts its argument from camel case to upper case >> with '_' between words. Used for generated enumeration constant >> prefixes. > > >> >> Signed-off-by: Markus Armbruster >>

Re: qemu direct kernel boot on LoongArch

2024-09-04 Thread Thomas Weißschuh
On 2024-09-05 06:04:12+, Jason A. Donenfeld wrote: > On Thu, Sep 5, 2024 at 5:45 AM maobibo wrote: > > > > Jason, > > > > With the latest qemu 9.1 version, elf format booting is supported. > > Thanks, I just figured this out too, about 4 minutes ago. Excellent. > And the 1G minimum ram limit

Re: [PATCH 4/5] target/riscv: Check memory access to meet svuket rule

2024-09-04 Thread Fea Wang
Thank you for your advice. I will take them after the spec is more finalized. Sincerely, Fea On Wed, Sep 4, 2024 at 6:18 AM Daniel Henrique Barboza < dbarb...@ventanamicro.com> wrote: > > > On 9/3/24 3:17 AM, Fea.Wang wrote: > > Follow the Svukte spec, do the memory access address checking > > >

Re: [PATCH v3 03/14] tcg/riscv: Add basic support for vector

2024-09-04 Thread Richard Henderson
On 9/4/24 07:27, LIU Zhiwei wrote: From: Swung0x48 The RISC-V vector instruction set utilizes the LMUL field to group multiple registers, enabling variable-length vector registers. This implementation uses only the first register number of each group while reserving the other register numbers w

Re: qemu direct kernel boot on LoongArch

2024-09-04 Thread Jason A. Donenfeld
On Thu, Sep 5, 2024 at 5:45 AM maobibo wrote: > > Jason, > > With the latest qemu 9.1 version, elf format booting is supported. Thanks, I just figured this out too, about 4 minutes ago. Excellent. And the 1G minimum ram limit is gone too. Now working on how to trigger resets. Jason

Re: qemu direct kernel boot on LoongArch

2024-09-04 Thread maobibo
Jason, With the latest qemu 9.1 version, elf format booting is supported. Qemu 9.0 does not support it still, here is example command line. ./qemu-system-loongarch64 -m 4G -smp 2 --cpu la464 --machine virt -serial stdio -monitor telnet:localhost:4495,server,nowait -kernel /root/linux_larc

Re: [PATCH v3 02/14] util: Add RISC-V vector extension probe in cpuinfo

2024-09-04 Thread Richard Henderson
On 9/4/24 07:27, LIU Zhiwei wrote: +if (info & CPUINFO_ZVE64X) { +/* + * Get vlenb for Vector: vsetvli rd, x0, e64. + * VLMAX = LMUL * VLEN / SEW. + * The "vsetvli rd, x0, e64" means "LMUL = 1, SEW = 64, rd = VLMAX", + * so "vlenb = VLMAX * 64 / 8". +

Re: qemu direct kernel boot on LoongArch

2024-09-04 Thread Jason A. Donenfeld
On Tue, Oct 10, 2023 at 09:12:46AM +0800, maobibo wrote: > Thomas, > > Thanks for reporting this issue. > > It is the problem of QEMU for LoongArch system, QEMU does not support > booting vmlinux with elf format without UEFI bios now. We will add > support to boot vmlinux directly on QEMU Loong

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-09-04 Thread Junjie Mao
On 9/4/2024 7:01 PM, Paolo Bonzini wrote: On Wed, Aug 28, 2024 at 6:12 AM Manos Pitsidianakis wrote: Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. The only comment I have is that I would drop

Re: [PATCH v2 13/14] tcg/riscv: Implement vector roti/v/x shi ops

2024-09-04 Thread LIU Zhiwei
On 2024/9/5 3:05, Richard Henderson wrote: On 9/4/24 08:25, LIU Zhiwei wrote: I'm trying to work out how much benefit there is here of expanding these early, as opposed to simply using TCG_REG_TMP0 when the immediate doesn't fit, We find for rotli,  it just copied code from the implementati

Re: [PATCH v2 00/15] target/cris: Remove the deprecated CRIS target

2024-09-04 Thread Richard Henderson
On 9/4/24 07:35, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (15): tests/tcg: Remove CRIS libc test files tests/tcg: Remove CRIS bare test files buildsys: Remove CRIS cross container linux-user: Remove support for CRIS target hw/cris: Remove the axis-dev88 machine hw/cr

Re: [PATCH v2 14/15] disas: Remove CRIS disassembler

2024-09-04 Thread Richard Henderson
On 9/4/24 07:36, Philippe Mathieu-Daudé wrote: --- a/include/disas/dis-asm.h +++ b/include/disas/dis-asm.h @@ -232,10 +232,6 @@ enum bfd_architecture #define bfd_mach_avrxmega5 105 #define bfd_mach_avrxmega6 106 #define bfd_mach_avrxmega7 107 - bfd_arch_cris, /* Axis CRIS */ -#def

[PATCH v2] crypto: run qcrypto_pbkdf2_count_iters in a new thread

2024-09-04 Thread Tiago Pasqualini
CPU time accounting in the kernel has been demonstrated to have a sawtooth pattern[1][2]. This can cause the getrusage system call to not be as accurate as we are expecting, which can cause this calculation to stall. The kernel discussions shows that this inaccuracy happens when CPU time gets big

Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions

2024-09-04 Thread Francisco Iglesias
On Mon, Aug 26, 2024 at 08:49:26PM -0700, Doug Brown wrote: > Use QEMU's helper functions can_dlc2len() and can_len2dlc() for > translating between the raw DLC value and the SocketCAN length value. > This also has the side effect of correctly handling received CAN FD > frames with a DLC of 0-8, whi

[ANNOUNCE] QEMU 9.1.0 is now available

2024-09-04 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 9.1.0 release. This release contains 2800+ commits from 263 authors. You can grab the tarball from our download page here: https://www.qemu.org/download/#source The full list of changes are available at: h

[PATCH v2 0/4] KVM: Dynamic sized memslots array

2024-09-04 Thread Peter Xu
v2: - Reordered patches, make the fix patch cc:stable - s/NUM/NR/ for the newly introduced macros [DavidH] - Added kvm_slots_double() wrapper [DavidH] v1: https://lore.kernel.org/r/20240904191635.3045606-1-pet...@redhat.com This series make KVM memslots to be allocated dynamically in QEMU. It fi

[PATCH v2 3/4] KVM: Rename KVMMemoryListener.nr_used_slots to nr_slots_used

2024-09-04 Thread Peter Xu
This will make all nr_slots counters to be named in the same manner. Reviewed-by: David Hildenbrand Signed-off-by: Peter Xu --- include/sysemu/kvm_int.h | 2 +- accel/kvm/kvm-all.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/sysemu/kvm_int.h b/include

[PATCH v2 4/4] KVM: Rename KVMState->nr_slots to nr_slots_max

2024-09-04 Thread Peter Xu
This value used to reflect the maximum supported memslots from KVM kernel. Rename it to be clearer. Reviewed-by: David Hildenbrand Signed-off-by: Peter Xu --- include/sysemu/kvm_int.h | 4 ++-- accel/kvm/kvm-all.c | 16 2 files changed, 10 insertions(+), 10 deletions(-)

[PATCH v2 1/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's statically allocated to be the max suppo

[PATCH v2 2/4] KVM: Define KVM_MEMSLOTS_NUM_MAX_DEFAULT

2024-09-04 Thread Peter Xu
Make the default max nr_slots a macro, it's only used when KVM reports nothing. Reviewed-by: David Hildenbrand Signed-off-by: Peter Xu --- accel/kvm/kvm-all.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f9368494a8..bc1b0

Re: [PATCH V2 00/11] Live update: cpr-exec

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 04:58:14PM -0400, Steven Sistare wrote: > On 8/21/2024 2:34 PM, Peter Xu wrote: > > On Fri, Aug 16, 2024 at 01:09:23PM -0400, Steven Sistare wrote: > > > On 8/16/2024 12:17 PM, Peter Xu wrote: > > > > On Fri, Aug 16, 2024 at 05:00:32PM +0100, Daniel P. Berrangé wrote: > > >

Re: [RFC V1 0/6] Live update: cpr-transfer

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 05:14:37PM -0400, Steven Sistare wrote: > Hi Peter, before I post V2 of this series, I would like to reach agreement on > this > interface. I cannot tell if you have gone quiet on this thread because you > agree, > disagree, or are on vacation! Hey Steve, I'm not on vaca

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 05:46:55PM -0400, Peter Xu wrote: > On Wed, Sep 04, 2024 at 11:38:28PM +0200, David Hildenbrand wrote: > > On 04.09.24 23:34, Peter Xu wrote: > > > On Wed, Sep 04, 2024 at 11:23:33PM +0200, David Hildenbrand wrote: > > > > > > > > > > > > > > > > Then, you can remove the p

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 11:38:28PM +0200, David Hildenbrand wrote: > On 04.09.24 23:34, Peter Xu wrote: > > On Wed, Sep 04, 2024 at 11:23:33PM +0200, David Hildenbrand wrote: > > > > > > > > > > > > > Then, you can remove the parameter from kvm_slots_grow() completely > > > > > and just call it

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread David Hildenbrand
On 04.09.24 23:34, Peter Xu wrote: On Wed, Sep 04, 2024 at 11:23:33PM +0200, David Hildenbrand wrote: Then, you can remove the parameter from kvm_slots_grow() completely and just call it kvm_slots_double() and simplify a bit: static bool kvm_slots_double(KVMMemoryListener *kml) { unsi

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 11:23:33PM +0200, David Hildenbrand wrote: > > > > > > > Then, you can remove the parameter from kvm_slots_grow() completely and > > > just call it > > > kvm_slots_double() and simplify a bit: > > > > > > static bool kvm_slots_double(KVMMemoryListener *kml) > > > { > > >

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread David Hildenbrand
Then, you can remove the parameter from kvm_slots_grow() completely and just call it kvm_slots_double() and simplify a bit: static bool kvm_slots_double(KVMMemoryListener *kml) { unsigned int i, nr_slots_new, cur = kml->nr_slots_allocated; KVMSlot *slots; nr_slots_new = MIN(c

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 11:07:44PM +0200, David Hildenbrand wrote: > On 04.09.24 21:16, Peter Xu wrote: > > Zhiyi reported an infinite loop issue in VFIO use case. The cause of that > > was a separate discussion, however during that I found a regression of > > dirty sync slowness when profiling. >

Re: [RFC V1 0/6] Live update: cpr-transfer

2024-09-04 Thread Steven Sistare
On 8/20/2024 12:29 PM, Steven Sistare wrote: On 8/16/2024 2:34 PM, Steven Sistare wrote: On 8/16/2024 11:59 AM, Peter Xu wrote: On Fri, Aug 16, 2024 at 04:36:58PM +0100, Daniel P. Berrangé wrote: On Fri, Aug 16, 2024 at 11:23:01AM -0400, Peter Xu wrote: On Fri, Aug 16, 2024 at 11:13:36AM -040

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread David Hildenbrand
On 04.09.24 21:16, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's sta

Re: [PATCH V2 00/11] Live update: cpr-exec

2024-09-04 Thread Steven Sistare
On 8/21/2024 2:34 PM, Peter Xu wrote: On Fri, Aug 16, 2024 at 01:09:23PM -0400, Steven Sistare wrote: On 8/16/2024 12:17 PM, Peter Xu wrote: On Fri, Aug 16, 2024 at 05:00:32PM +0100, Daniel P. Berrangé wrote: On Fri, Aug 16, 2024 at 11:34:10AM -0400, Peter Xu wrote: On Fri, Aug 16, 2024 at 04

Re: [PATCH 2/4] KVM: Define KVM_MEMSLOTS_NUM_MAX_DEFAULT

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 10:39:19PM +0200, David Hildenbrand wrote: > On 04.09.24 21:16, Peter Xu wrote: > > Make the default max nr_slots a macro, it's only used when KVM reports > > nothing. Then we put all the rest macros together later soon. > > > > Signed-off-by: Peter Xu > > --- > > accel

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 10:43:23PM +0200, David Hildenbrand wrote: > On 04.09.24 21:16, Peter Xu wrote: > > Zhiyi reported an infinite loop issue in VFIO use case. The cause of that > > was a separate discussion, however during that I found a regression of > > dirty sync slowness when profiling. >

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread David Hildenbrand
On 04.09.24 22:43, David Hildenbrand wrote: On 04.09.24 21:16, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains

Re: [PATCH v5 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-04 Thread Dorjoy Chowdhury
On Thu, Sep 5, 2024, 2:27 AM Michael S. Tsirkin wrote: > On Thu, Sep 05, 2024 at 12:30:07AM +0600, Dorjoy Chowdhury wrote: > > On Wed, Sep 4, 2024 at 2:47 AM Dorjoy Chowdhury > wrote: > > > > > > > > > > > > On Wed, Sep 4, 2024, 2:32 AM Michael S. Tsirkin > wrote: > > >> > > >> On Wed, Sep 04,

Re: [PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread David Hildenbrand
On 04.09.24 21:16, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's sta

Re: [PATCH 4/4] KVM: Rename KVMMemoryListener.nr_used_slots to nr_slots_used

2024-09-04 Thread David Hildenbrand
On 04.09.24 21:16, Peter Xu wrote: This will make all nr_slots counters to be named in the same manner. Signed-off-by: Peter Xu --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH 2/4] KVM: Define KVM_MEMSLOTS_NUM_MAX_DEFAULT

2024-09-04 Thread David Hildenbrand
On 04.09.24 21:16, Peter Xu wrote: Make the default max nr_slots a macro, it's only used when KVM reports nothing. Then we put all the rest macros together later soon. Signed-off-by: Peter Xu --- accel/kvm/kvm-all.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/acc

Re: [PATCH 1/4] KVM: Rename KVMState->nr_slots to nr_slots_max

2024-09-04 Thread David Hildenbrand
On 04.09.24 21:16, Peter Xu wrote: This value used to reflect the maximum supported memslots from KVM kernel. Rename it to be clearer, preparing for dynamic sized memslot allocations. Well, it matches "KVM_CAP_NR_MEMSLOTS" :) Reviewed-by: David Hildenbrand -for (i = 0; i < s->nr_slots;

Re: [PATCH v5 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-04 Thread Michael S. Tsirkin
On Thu, Sep 05, 2024 at 12:30:07AM +0600, Dorjoy Chowdhury wrote: > On Wed, Sep 4, 2024 at 2:47 AM Dorjoy Chowdhury > wrote: > > > > > > > > On Wed, Sep 4, 2024, 2:32 AM Michael S. Tsirkin wrote: > >> > >> On Wed, Sep 04, 2024 at 01:58:15AM +0600, Dorjoy Chowdhury wrote: > >> > On Thu, Aug 29, 2

Re: [PATCH v3] contrib/plugins: Add a plugin to generate basic block vectors

2024-09-04 Thread Alex Bennée
Akihiko Odaki writes: > SimPoint is a widely used tool to find the ideal microarchitecture > simulation points so Valgrind[2] and Pin[3] support generating basic > block vectors for use with them. Let's add a corresponding plugin to > QEMU too. > > Note that this plugin has a different goal with

[PATCH 2/4] KVM: Define KVM_MEMSLOTS_NUM_MAX_DEFAULT

2024-09-04 Thread Peter Xu
Make the default max nr_slots a macro, it's only used when KVM reports nothing. Then we put all the rest macros together later soon. Signed-off-by: Peter Xu --- accel/kvm/kvm-all.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c

[PATCH 3/4] KVM: Dynamic sized kvm memslots array

2024-09-04 Thread Peter Xu
Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's statically allocated to be the max suppo

[PATCH 1/4] KVM: Rename KVMState->nr_slots to nr_slots_max

2024-09-04 Thread Peter Xu
This value used to reflect the maximum supported memslots from KVM kernel. Rename it to be clearer, preparing for dynamic sized memslot allocations. Signed-off-by: Peter Xu --- include/sysemu/kvm_int.h | 4 ++-- accel/kvm/kvm-all.c | 26 +- 2 files changed, 15 inser

[PATCH 0/4] KVM: Dynamic sized memslots array

2024-09-04 Thread Peter Xu
This series make KVM memslots to be allocated dynamically in QEMU. It fixes a migration performance regression that I observed, reducing precopy dirty sync process from ~86ms to ~3ms each time. Patch 1,2,4 are mostly small cleanups, the major fix is in patch 3. Thanks, Peter Xu (4): KVM: Rena

[PATCH 4/4] KVM: Rename KVMMemoryListener.nr_used_slots to nr_slots_used

2024-09-04 Thread Peter Xu
This will make all nr_slots counters to be named in the same manner. Signed-off-by: Peter Xu --- include/sysemu/kvm_int.h | 2 +- accel/kvm/kvm-all.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/sysemu/kvm_int.h b/include/sysemu/kvm_int.h index e67b2e5a

Re: [PATCH v2 13/14] tcg/riscv: Implement vector roti/v/x shi ops

2024-09-04 Thread Richard Henderson
On 9/4/24 08:25, LIU Zhiwei wrote: I'm trying to work out how much benefit there is here of expanding these early, as opposed to simply using TCG_REG_TMP0 when the immediate doesn't fit, We find for rotli,  it just copied code from the implementation of INDEX_op_shli_vec and INDEX_op_shri_vec

Re: [PATCH v5 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-04 Thread Dorjoy Chowdhury
On Wed, Sep 4, 2024 at 2:47 AM Dorjoy Chowdhury wrote: > > > > On Wed, Sep 4, 2024, 2:32 AM Michael S. Tsirkin wrote: >> >> On Wed, Sep 04, 2024 at 01:58:15AM +0600, Dorjoy Chowdhury wrote: >> > On Thu, Aug 29, 2024 at 1:11 AM Michael S. Tsirkin wrote: >> > > >> > > On Thu, Aug 29, 2024 at 01:04

RE: [PATCH RFC V3 01/29] arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property

2024-09-04 Thread Salil Mehta via
Hi Zhao, > From: zhao1@intel.com > Sent: Wednesday, September 4, 2024 3:43 PM > To: Salil Mehta > > Hi Salil, > > On Mon, Aug 19, 2024 at 11:53:52AM +, Salil Mehta wrote: > > Date: Mon, 19 Aug 2024 11:53:52 + > > From: Salil Mehta > > Subject: RE: [PATCH RFC V3 01/29] ar

Re: [PATCH v9 3/5] migration: Add migration parameters for QATzip

2024-09-04 Thread Fabiano Rosas
Yichen Wang writes: > From: Bryan Zhang > > Adds support for migration parameters to control QATzip compression > level. > > Acked-by: Markus Armbruster > Signed-off-by: Bryan Zhang > Signed-off-by: Hao Xiang > Signed-off-by: Yichen Wang Reviewed-by: Fabiano Rosas

Re: [PATCH 2/2] hw/cxl/cxl_event: Fix interrupt triggering for dynamic capacity events grouped via More flag

2024-09-04 Thread Fan Ni
On Wed, Sep 04, 2024 at 11:37:33AM -0500, Ira Weiny wrote: > Jonathan Cameron wrote: > > On Tue, 27 Aug 2024 09:40:05 -0700 > > nifan@gmail.com wrote: > > > > > From: Fan Ni > > > > > > When inserting multiple dynamic capacity event records grouped via More > > > flag, > > > we should only

Re: [PATCH 2/2] hw/cxl/cxl_event: Fix interrupt triggering for dynamic capacity events grouped via More flag

2024-09-04 Thread Ira Weiny
Jonathan Cameron wrote: > On Tue, 27 Aug 2024 09:40:05 -0700 > nifan@gmail.com wrote: > > > From: Fan Ni > > > > When inserting multiple dynamic capacity event records grouped via More > > flag, > > we should only trigger interrupt after the last record is inserted into the > > event log. A

Re: [PATCH v7 6/6] tests/tcg/multiarch: add test for plugin memory access

2024-09-04 Thread Alex Bennée
Alex Bennée writes: > Pierrick Bouvier writes: > >> Add an explicit test to check expected memory values are read/written. >> 8,16,32 load/store are tested for all arch. >> 64,128 load/store are tested for aarch64/x64. >> atomic operations (8,16,32,64) are tested for x64 only. >> >> By default,

[PULL v1 03/12] hw/arm: xenpvh: Tweak machine description

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Tweak machine description to better express that this is a Xen PVH machine for ARM. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/arm/xen_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xen_arm.c b/hw/arm/xen

[PULL v1 06/12] hw/arm: xenpvh: Move stubbed functions to xen-stubs.c

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/arm/meson.build | 5 - hw/arm/xen-stubs.c | 32 hw/arm/xen_arm.c | 20 3 files changed, 36 insertions(+), 21 deletions(-) create mode

Re: [PATCH v2 15/15] seccomp: Remove check for CRIS host

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.36, Philippe Mathieu-Daudé wrote: As per the deprecation notice in commit c7bbef4023: The CRIS architecture was pulled from Linux in 4.17 and the compiler is no longer packaged in any distro [...]. It is now unlikely QEMU is build on CRIS host. Signed-off-by: Philippe Ma

[PULL v1 10/12] hw/xen: pvh-common: Add support for creating PCIe/GPEX

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for optionally creating a PCIe/GPEX controller. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/xen/xen-pvh-common.c | 76 + include/hw/xen/xen-pvh-common.h | 29 + 2 files change

[PULL v1 05/12] hw/arm: xenpvh: Remove double-negation in warning

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/arm/xen_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c index fda65d0d8d..16b3f00992 100644 --- a/hw/arm/xen_arm.c +++ b/hw/arm/xen_ar

[PULL v1 09/12] hw/arm: xenpvh: Reverse virtio-mmio creation order

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" We've been creating the virtio-mmio devices in forwards order but since the qbus lists prepend (rather than append) entries, the virtio busses end up with decreasing base address order. Xen enables virtio-mmio nodes in forwards order so there's been a missmatch. So far,

[PULL v1 07/12] hw/arm: xenpvh: Break out a common PVH machine

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break out a common Xen PVH machine in preparation for adding a x86 Xen PVH machine. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/arm/trace-events | 5 - hw/arm/xen_arm.c| 198 +++ hw/xen/mes

[PULL v1 04/12] hw/arm: xenpvh: Add support for SMP guests

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add SMP support for Xen PVH ARM guests. Create ms->smp.max_cpus ioreq servers to handle hotplug. Note that ms->smp.max_cpus will be passed to us by the user (Xen tools) set to the guests maxvcpus. The value in mc->max_cpus is an absolute maximum for the -smp option and

[PULL v1 08/12] hw/arm: xenpvh: Rename xen_arm.c -> xen-pvh.c

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Rename xen_arm.c -> xen-pvh.c to better express that this is a PVH machine and to align with x86 HVM and future PVH machine filenames: hw/i386/xen/xen-hvm.c hw/i386/xen/xen-pvh.c (in preparation) No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Ste

[PULL v1 02/12] hw/arm: xenpvh: Update file header to use SPDX

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Update file header to use SPDX and remove stray empty comment line. No functional changes. Signed-off-by: Edgar E. Iglesias Acked-by: Stefano Stabellini --- hw/arm/xen_arm.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/a

[PULL v1 11/12] hw/i386/xen: Add a Xen PVH x86 machine

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a Xen PVH x86 machine based on the abstract PVH Machine. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/i386/xen/meson.build | 1 + hw/i386/xen/xen-pvh.c | 121 2 files changed, 122 insertions(

[PULL v1 12/12] docs/system/i386: xenpvh: Add a basic description

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- MAINTAINERS | 1 + docs/system/i386/xenpvh.rst | 49 + docs/system/target-i386.rst | 1 + 3 files changed, 51 insertions(+) create mode 100644 d

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 06:41:03PM +0300, Avihai Horon wrote: > > On 04/09/2024 16:00, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > Hello, Avihai, > > > > Reviving this thread just to discuss one issue below.. > > > > On Thu, Feb 16, 2023 at 04:36:27

[PULL v1 01/12] MAINTAINERS: Add docs/system/arm/xenpvh.rst

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Acked-by: Stefano Stabellini --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3584d6a6c6..c2fb0c2f42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -559,6 +559,7 @@ F: include/hw/xen/

[PULL v1 00/12] Xen queue

2024-09-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit e638d685ec2a0700fb9529cbd1b2823ac4120c53: Open 9.2 development tree (2024-09-03 09:18:43 -0700) are available in the Git repository at: https://gitlab.com/edgar.iglesias/qemu.git tags/edgar/xen-queue-2024-09-04.for-upstream for

Re: [PATCH v2 14/15] disas: Remove CRIS disassembler

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.36, Philippe Mathieu-Daudé wrote: We just removed the CRIS target, the disassembler is now dead code. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS |5 - meson.build |1 - include/disas/dis-asm.h |6 - include/exec/poison.h |

Re: [PATCH v2 13/15] target/cris: Remove the deprecated CRIS target

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.36, Philippe Mathieu-Daudé wrote: The CRIS target is deprecated since v9.0 (commit c7bbef40234 "docs: mark CRIS support as deprecated"). Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS |1 - docs/about/deprecated.rst |8 - doc

Re: [PATCH v2 12/15] system: Remove support for CRIS target

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.36, Philippe Mathieu-Daudé wrote: We are about to remove the CRIS target, so remove the sysemu part. This remove the CRIS 'none' machine. Signed-off-by: Philippe Mathieu-Daudé --- configs/devices/cris-softmmu/default.mak | 1 - configs/targets/cris-softmmu.mak | 1 -

Re: [PATCH v2 10/15] hw/dma: Remove ETRAX_FS DMA device

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We just removed the single machine calling etraxfs_dmac_init() (the axis-dev88 machine). Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 - include/hw/cris/etraxfs_dma.h | 36 -- hw/dma/etraxfs_dma

Re: [PATCH v2 11/15] hw/timer: Remove TYPE_ETRAX_FS_TIMER device

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 8 - hw/timer/etraxfs_timer.c| 407 hw/Kconfig

Re: [PATCH v2 09/15] hw/net: Remove TYPE_ETRAX_FS_ETH device

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/cris/etraxfs.h | 36 -- hw/net/etraxfs_eth.c | 688 -- hw/net/meson.build| 1

Re: [PATCH] kvm/i386: replace identity_base variable with a constant

2024-09-04 Thread Ani Sinha
> On 4 Sep 2024, at 6:02 PM, Paolo Bonzini wrote: > > identity_base variable is first initialzied to address 0xfffbc000 and then > kvm_vm_set_identity_map_addr() overrides this value to address 0xfeffc000. > The initial address to which the variable was initialized was never used. > Clean > e

RE: [PATCH RFC V3 00/29] Support of Virtual CPU Hotplug for ARMv8 Arch

2024-09-04 Thread Salil Mehta via
Hi Alex, > From: Alex Bennée > Sent: Wednesday, September 4, 2024 4:46 PM > To: Salil Mehta > > Salil Mehta writes: > > > Hi Alex, > > > >> -Original Message- > >> From: Alex Bennée > >> Sent: Thursday, August 29, 2024 11:00 AM > >> To: Gustavo Romero > >> > >> Gu

Re: [PATCH RFC V3 00/29] Support of Virtual CPU Hotplug for ARMv8 Arch

2024-09-04 Thread Alex Bennée
Salil Mehta writes: > Hi Alex, > >> -Original Message- >> From: Alex Bennée >> Sent: Thursday, August 29, 2024 11:00 AM >> To: Gustavo Romero >> >> Gustavo Romero writes: >> >> > Hi Salil, >> > >> > On 6/13/24 8:36 PM, Salil Mehta via wrote: >> >> >> (VI) Commands Used >

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-04 Thread Avihai Horon
On 04/09/2024 16:00, Peter Xu wrote: External email: Use caution opening links or attachments Hello, Avihai, Reviving this thread just to discuss one issue below.. On Thu, Feb 16, 2023 at 04:36:27PM +0200, Avihai Horon wrote: +/* + * Migration size of VFIO devices can be as little as a few

Re: [PATCH v2 08/15] hw/char: Remove TYPE_ETRAX_FS_SERIAL device

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/cris/etraxfs.h | 18 --- hw/char/etraxfs_ser.c | 267 -- hw/char/meson.build | 1

Re: [PATCH v7 6/6] tests/tcg/multiarch: add test for plugin memory access

2024-09-04 Thread Alex Bennée
Pierrick Bouvier writes: > Add an explicit test to check expected memory values are read/written. > 8,16,32 load/store are tested for all arch. > 64,128 load/store are tested for aarch64/x64. > atomic operations (8,16,32,64) are tested for x64 only. > > By default, atomic accesses are non atomic

Re: [PATCH v2 07/15] hw/intc: Remove TYPE_ETRAX_FS_PIC device

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/etraxfs_pic.c | 172 -- hw/intc/meson.build | 1 - 2 files changed, 173 deletions(-) d

Re: [PATCH v2 06/15] hw/cris: Remove image loader helper

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: No more CRIS machine uses cris_load_image(), remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/cris/boot.h | 16 --- hw/cris/boot.c | 102 hw/cris/meson.build | 4 -- hw/m

Re: [PATCH v2 05/15] hw/cris: Remove the axis-dev88 machine

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: This machine was deprecated for the v9.0 release in commit c7bbef4023 ("docs: mark CRIS support as deprecated"). Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 +- configs/devices/cris-softmmu/defaul

Re: [PATCH v2 13/14] tcg/riscv: Implement vector roti/v/x shi ops

2024-09-04 Thread LIU Zhiwei
On 2024/9/3 23:15, Richard Henderson wrote: On 8/29/24 23:16, LIU Zhiwei wrote: @@ -2589,6 +2605,69 @@ void tcg_expand_vec_op(TCGOpcode opc, TCGType type, unsigned vece,   }   }   break; +    case INDEX_op_shli_vec: +    if (a2 > 31) { +    tcg_gen_shls_

Re: [PATCH v2 01/15] tests/tcg: Remove CRIS libc test files

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We never compiled / ran these tests. Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH v2 04/15] linux-user: Remove support for CRIS target

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: As per the deprecation notice in commit c7bbef4023: The CRIS architecture was pulled from Linux in 4.17 and the compiler is no longer packaged in any distro making it harder to run the `check-tcg` tests. Unless we can improve the tes

Re: [PATCH v2 03/15] buildsys: Remove CRIS cross container

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We removed the cross compiled CRIS tests in the previous commit. Signed-off-by: Philippe Mathieu-Daudé --- configure | 4 .gitlab-ci.d/container-cross.yml | 5 - tests/dock

Re: [PATCH v2 02/15] tests/tcg: Remove CRIS bare test files

2024-09-04 Thread Thomas Huth
On 04/09/2024 16.35, Philippe Mathieu-Daudé wrote: We are going to remove the CRIS target. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 - tests/tcg/cris/bare/sys.c | 63 --- scripts/probe-gdb-support.py | 1 - tests/tcg/

Re: [PATCH v4 0/9] target/i386: Misc cleanup on KVM PV defs, outdated comments and error handling

2024-09-04 Thread Paolo Bonzini
On 9/4/24 15:46, Zhao Liu wrote: Hi Paolo, Just a kindly ping. It's on my list now that 9.1 has been released. Paolo Thanks, Zhao On Wed, Jul 17, 2024 at 12:10:06AM +0800, Zhao Liu wrote: Date: Wed, 17 Jul 2024 00:10:06 +0800 From: Zhao Liu Subject: [PATCH v4 0/9] target/i386: Misc clea

[PATCH v2 14/15] disas: Remove CRIS disassembler

2024-09-04 Thread Philippe Mathieu-Daudé
We just removed the CRIS target, the disassembler is now dead code. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS |5 - meson.build |1 - include/disas/dis-asm.h |6 - include/exec/poison.h |1 - disas/cris.c| 2863 ---

[PATCH v2 15/15] seccomp: Remove check for CRIS host

2024-09-04 Thread Philippe Mathieu-Daudé
As per the deprecation notice in commit c7bbef4023: The CRIS architecture was pulled from Linux in 4.17 and the compiler is no longer packaged in any distro [...]. It is now unlikely QEMU is build on CRIS host. Signed-off-by: Philippe Mathieu-Daudé --- system/qemu-seccomp.c | 2 +- 1 file

[PATCH v2 12/15] system: Remove support for CRIS target

2024-09-04 Thread Philippe Mathieu-Daudé
We are about to remove the CRIS target, so remove the sysemu part. This remove the CRIS 'none' machine. Signed-off-by: Philippe Mathieu-Daudé --- configs/devices/cris-softmmu/default.mak | 1 - configs/targets/cris-softmmu.mak | 1 - qapi/machine.json| 2 +- inclu

[PATCH v2 09/15] hw/net: Remove TYPE_ETRAX_FS_ETH device

2024-09-04 Thread Philippe Mathieu-Daudé
We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/cris/etraxfs.h | 36 -- hw/net/etraxfs_eth.c | 688 -- hw/net/meson.build| 1 - hw/net/trace-events | 5 - 4 files changed, 7

[PATCH v2 10/15] hw/dma: Remove ETRAX_FS DMA device

2024-09-04 Thread Philippe Mathieu-Daudé
We just removed the single machine calling etraxfs_dmac_init() (the axis-dev88 machine). Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 - include/hw/cris/etraxfs_dma.h | 36 -- hw/dma/etraxfs_dma.c| 781 hw

  1   2   3   >