Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Akihiko Odaki
On 2024/08/14 14:41, Pierrick Bouvier wrote: On 8/13/24 21:56, Akihiko Odaki wrote: On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has been modified, and list of plugins and thei

Re: [RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-13 Thread Nicholas Piggin
On Mon Aug 12, 2024 at 11:25 AM AEST, Richard Henderson wrote: > On 8/9/24 17:47, Nicholas Piggin wrote: > > This is not a clean patch, but does fix a problem I hit with TB > > invalidation due to the target software writing to memory with TBs. > > > > Lockup messages are triggering in Linux due t

Re: [PATCH v2 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state

2024-08-13 Thread Nicholas Piggin
On Wed Aug 14, 2024 at 6:48 AM AEST, Michael S. Tsirkin wrote: > On Tue, Aug 13, 2024 at 09:23:24PM +0100, Alex Bennée wrote: > > From: Nicholas Piggin > > > > The regular qemu_bh_schedule() calls result in non-deterministic > > execution of the bh in record-replay mode, which causes replay failu

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Pierrick Bouvier
On 8/13/24 21:56, Akihiko Odaki wrote: On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has been modified, and list of plugins and their doc is now in "docs/about/emulation.rst". Yo

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Akihiko Odaki
On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has been modified, and list of plugins and their doc is now in "docs/about/emulation.rst". You may want to rebase on top of master.

Re: [PATCH] hw/misc/stm32l4x5_rcc: Add validation for MCOPRE and MCOSEL values

2024-08-13 Thread Michael Tokarev
18.06.2024 16:55, Zheyu Ma wrote: This commit adds validation checks for the MCOPRE and MCOSEL values in the rcc_update_cfgr_register function. If the MCOPRE value exceeds 0b100 or the MCOSEL value exceeds 0b111, an error is logged and the corresponding clock mux is disabled. This helps in identi

Re: [PATCH v1 03/15] tcg: Fix register allocation constraints

2024-08-13 Thread Richard Henderson
On 8/14/24 13:30, LIU Zhiwei wrote: On 2024/8/14 11:08, Richard Henderson wrote: On 8/14/24 12:27, LIU Zhiwei wrote: On 2024/8/14 10:04, Richard Henderson wrote: On 8/14/24 10:58, LIU Zhiwei wrote: Thus if we want to use all registers of vectors, we have to add a dynamic constraint on regis

Re: [PATCH v1 03/15] tcg: Fix register allocation constraints

2024-08-13 Thread LIU Zhiwei
On 2024/8/14 11:08, Richard Henderson wrote: On 8/14/24 12:27, LIU Zhiwei wrote: On 2024/8/14 10:04, Richard Henderson wrote: On 8/14/24 10:58, LIU Zhiwei wrote: Thus if we want to use all registers of vectors, we have to add a dynamic constraint on register allocation based on IR types.

Re: [PATCH v1 03/15] tcg: Fix register allocation constraints

2024-08-13 Thread Richard Henderson
On 8/14/24 12:27, LIU Zhiwei wrote: On 2024/8/14 10:04, Richard Henderson wrote: On 8/14/24 10:58, LIU Zhiwei wrote: Thus if we want to use all registers of vectors, we have to add a dynamic constraint on register allocation based on IR types. My comment vs patch 4 is that you can't do that,

RE: [PATCH v3 2/2] intel_iommu: Make PASID-cache and PIOTLB type invalid in legacy mode

2024-08-13 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Subject: Re: [PATCH v3 2/2] intel_iommu: Make PASID-cache and PIOTLB >type invalid in legacy mode > >On 2024/8/14 10:26, Zhenzhong Duan wrote: >> In vtd_process_inv_desc(), VTD_INV_DESC_PC and VTD_INV_DESC_PIOTLB >are >> bypassed without scalable mod

Re: [PATCH v3 2/2] intel_iommu: Make PASID-cache and PIOTLB type invalid in legacy mode

2024-08-13 Thread Yi Liu
On 2024/8/14 10:26, Zhenzhong Duan wrote: In vtd_process_inv_desc(), VTD_INV_DESC_PC and VTD_INV_DESC_PIOTLB are bypassed without scalable mode check. These two types are not valid in legacy mode and we should report error. Fixes: 4a4f219e8a1 ("intel_iommu: add scalable-mode option to make scala

Re: [PULL 0/4] target-arm queue

2024-08-13 Thread Richard Henderson
9eb51530c12ae645b91e308d16196c68563ea883: Merge tag 'block-pull-request' ofhttps://gitlab.com/stefanha/qemu into staging (2024-08-13 07:59:32 +1000) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20240813 for you to fetch cha

Re: [PULL for-9.1 0/6] Miscellaneous fixes for QEMU 9.1-rc

2024-08-13 Thread Richard Henderson
On 8/14/24 03:05, Paolo Bonzini wrote: The following changes since commit 9eb51530c12ae645b91e308d16196c68563ea883: Merge tag 'block-pull-request' ofhttps://gitlab.com/stefanha/qemu into staging (2024-08-13 07:59:32 +1000) are available in the Git repository at: https://gitlab.com/bonzi

RE: [PATCH v2 01/17] intel_iommu: Use the latest fault reasons defined by spec

2024-08-13 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Subject: Re: [PATCH v2 01/17] intel_iommu: Use the latest fault reasons >defined by spec > >On 2024/8/5 14:27, Zhenzhong Duan wrote: >> From: Yu Zhang >> >> Spec revision 3.0 or above defines more detailed fault reasons for >> scalable mode. So intr

[PATCH v3 2/2] intel_iommu: Make PASID-cache and PIOTLB type invalid in legacy mode

2024-08-13 Thread Zhenzhong Duan
In vtd_process_inv_desc(), VTD_INV_DESC_PC and VTD_INV_DESC_PIOTLB are bypassed without scalable mode check. These two types are not valid in legacy mode and we should report error. Fixes: 4a4f219e8a1 ("intel_iommu: add scalable-mode option to make scalable mode work") Suggested-by: Yi Liu Signe

[PATCH v3 1/2] intel_iommu: Fix invalidation descriptor type field

2024-08-13 Thread Zhenzhong Duan
According to spec, invalidation descriptor type is 7bits which is concatenation of bits[11:9] and bits[3:0] of invalidation descriptor. Currently we only pick bits[3:0] as the invalidation type and treat bits[11:9] as reserved zero. This is not a problem for now as bits[11:9] is zero for all curre

[PATCH v3 0/2] intel_iommu minor fixes

2024-08-13 Thread Zhenzhong Duan
Hi Fixes two minor issues in intel iommu. See patch for details. Tested scalable mode and legacy mode with vfio device passthrough: PASS Tested intel-iommu.flat in kvm-unit-test: PASS Thanks Zhenzhong v3: - add fix tag (Liu Yi) - collect R-B Zhenzhong Duan (2): intel_iommu: Fix invalidation

Re: [PATCH v1 03/15] tcg: Fix register allocation constraints

2024-08-13 Thread LIU Zhiwei
On 2024/8/14 10:04, Richard Henderson wrote: On 8/14/24 10:58, LIU Zhiwei wrote: Thus if we want to use all registers of vectors, we have to add a dynamic constraint on register allocation based on IR types. My comment vs patch 4 is that you can't do that, at least not without large changes

Re: [PATCH v1 03/15] tcg: Fix register allocation constraints

2024-08-13 Thread Richard Henderson
On 8/14/24 10:58, LIU Zhiwei wrote: Thus if we want to use all registers of vectors, we have to add a dynamic constraint on register allocation based on IR types. My comment vs patch 4 is that you can't do that, at least not without large changes to TCG. In addition, I said that the register

Re: [PATCH v2 07/21] target/i386: allow access_ptr to force slow path on failed probe

2024-08-13 Thread Richard Henderson
On 8/14/24 06:23, Alex Bennée wrote: When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault

Re: [PATCH] target/sparc: emulate floating point queue when raising fp traps

2024-08-13 Thread Richard Henderson
On 8/14/24 09:22, Carl Hauser wrote: I am unable to test the linux and NetBSD behavior because I've been unable to get gcc to actually generate quad precision instructions on those systems. -mhard-quad-float + +    /* single-element FPU fault queue */ +    uint32_t fsr_qne;    /*

[PATCH] target/sparc: emulate floating point queue when raising fp traps

2024-08-13 Thread Carl Hauser
From 310902d2ccd88ccb8de971d0d7ede0dbc93939f4 Mon Sep 17 00:00:00 2001 From: Carl Hauser Date: Sat, 10 Aug 2024 15:09:39 -0700 Subject: [PATCH] target/sparc: emulate floating point queue when raising fp traps Sparc 32-bit machines perform floating point operations in an asynchronous co-process

Re: [PATCH v1 03/15] tcg: Fix register allocation constraints

2024-08-13 Thread LIU Zhiwei
On 2024/8/13 19:52, Richard Henderson wrote: On 8/13/24 21:34, LIU Zhiwei wrote: From: TANG Tiancheng When allocating registers for input and output, ensure they match the available registers to avoid allocating illeagal registers. We should respect RISC-V vector extension's variable-length

Re: [PATCH for-9.2 10/10] hw: Remove device_phases_reset()

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: Currently we have transitional machinery between legacy reset and three phase reset that works in two directions: * if you invoke three phase reset on a device which has set theDeviceClass::legacy_reset method, we detect this in device_get_transiti

[RFC PATCH 2/2] rust: Specify Rust edition by rust_std=20XX

2024-08-13 Thread Junjie Mao
Signed-off-by: Junjie Mao --- rust/hw/char/pl011/meson.build | 4 +--- rust/meson.build | 4 +--- rust/qemu-api/meson.build | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/rust/hw/char/pl011/meson.build b/rust/hw/char/pl011/meson.build index 1c139d3af9..5

[RFC PATCH 1/2] meson: subprojects: Specify Rust edition by rust_std=20XX

2024-08-13 Thread Junjie Mao
Signed-off-by: Junjie Mao --- subprojects/packagefiles/arbitrary-int-1-rs/meson.build | 4 +--- subprojects/packagefiles/bilge-impl-0.2-rs/meson.build| 2 +- subprojects/packagefiles/either-1-rs/meson.build | 2 +- subprojects/packagefiles/itertools-0.11-rs/meson.build

[RFC PATCH 0/2] meson: Specify Rust edition by rust_std=20XX

2024-08-13 Thread Junjie Mao
The official way to specify Rust edition in meson is the rust_std build option [1]. It is used for generating --edition rustc options and filling rust-project.json which provides project layout information to rust-analyzer. Specifying Rust edition by rust_args instead causes meson to generate "edit

Re: [PATCH RFC/RFT] vfio/pci-quirks: Quirk for ath wireless

2024-08-13 Thread Jason Gunthorpe
On Tue, Aug 13, 2024 at 03:03:20PM -0600, Alex Williamson wrote: > How does the guest know to write a remappable vector format? How does > the guest know the host interrupt architecture? For example why would > an aarch64 guest program an MSI vector of 0xfee... if the host is x86? All excellent

Re: [PATCH v6 00/10] Add ACPI CPER firmware first error injection on ARM emulation

2024-08-13 Thread Mauro Carvalho Chehab
Em Mon, 12 Aug 2024 14:18:35 +0200 Igor Mammedov escreveu: > On Thu, 8 Aug 2024 14:57:35 +0200 > Mauro Carvalho Chehab wrote: > > > Em Thu, 8 Aug 2024 14:26:26 +0200 > > Mauro Carvalho Chehab escreveu: > > > > > v6: > > > - PNP0C33 device creation moved to aml-build.c; > > > - acpi_ghes re

[PATCH v7 02/10] arm/virt: Wire up a GED error device for ACPI / GHES

2024-08-13 Thread Mauro Carvalho Chehab
Adds support to ARM virtualization to allow handling generic error ACPI Event via GED & error source device. It is aligned with Linux Kernel patch: https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/ Co-authored-by: Mauro Carvalho Chehab Co-authored-by: Jonathan

[PATCH v7 06/10] acpi/ghes: add support for generic error injection via QAPI

2024-08-13 Thread Mauro Carvalho Chehab
Provide a generic interface for error injection via GHESv2. This patch is co-authored: - original ghes logic to inject a simple ARM record by Shiju Jose; - generic logic to handle block addresses by Jonathan Cameron; - generic GHESv2 error inject by Mauro Carvalho Chehab; Co-authored-

[PATCH v7 01/10] acpi/generic_event_device: add an APEI error device

2024-08-13 Thread Mauro Carvalho Chehab
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2: https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources using HID PNP0C33. The PNP0C33 device is used to report hardware

[PATCH v7 04/10] qapi/acpi-hest: add an interface to do generic CPER error injection

2024-08-13 Thread Mauro Carvalho Chehab
Creates a QMP command to be used for generic ACPI APEI hardware error injection (HEST) via GHESv2. The actual GHES code will be added at the followup patch. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Shiju Jose Reviewed-by: Jonathan Cameron --- MAINTAINERS | 7 +++

[PATCH v7 03/10] acpi/ghes: Add support for GED error device

2024-08-13 Thread Mauro Carvalho Chehab
From: Jonathan Cameron As a GED error device is now defined, add another type of notification. Add error notification to GHES v2 using a GED error device GED triggered via interrupt. [mchehab: do some cleanups at ACPI_HEST_SRC_ID_* checks and rename HEST event to better identify GED interrupt

[PATCH v7 08/10] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-13 Thread Mauro Carvalho Chehab
Using the QMP GHESv2 API requires preparing a raw data array containing a CPER record. Add a helper script with subcommands to prepare such data. Currently, only ARM Processor error CPER record is supported. Signed-off-by: Mauro Carvalho Chehab --- MAINTAINERS| 3 + scrip

[PATCH v7 00/10] Add ACPI CPER firmware first error injection on ARM emulation

2024-08-13 Thread Mauro Carvalho Chehab
Testing OS kernel ACPI APEI CPER support is tricky, as one depends on having hardware with special-purpose BIOS and/or hardware. With QEMU, it becomes a lot easier, as it can be done via QMP. This series add support for injecting CPER records on ARM emulation. The QEMU side changes add a QAPI ab

[PATCH v7 05/10] acpi/ghes: rework the logic to handle HEST source ID

2024-08-13 Thread Mauro Carvalho Chehab
The current logic is based on a lot of duct tape, with offsets calculated based on one define with the number of source IDs and an enum. Rewrite the logic in a way that it would be more resilient of code changes, by moving the source ID count to an enum and make the offset calculus more explicit.

[PATCH v7 07/10] docs: acpi_hest_ghes: fix documentation for CPER size

2024-08-13 Thread Mauro Carvalho Chehab
While the spec defines a CPER size of 4KiB for each record, currently it is set to 1KiB. Fix the documentation and add a pointer to the macro name there, as this may help to keep it updated. Signed-off-by: Mauro Carvalho Chehab Acked-by: Igor Mammedov --- docs/specs/acpi_hest_ghes.rst | 6 -

[PATCH v7 10/10] scripts/arm_processor_error.py: retrieve mpidr if not filled

2024-08-13 Thread Mauro Carvalho Chehab
Add support to retrieve mpidr value via qom-get. Signed-off-by: Mauro Carvalho Chehab --- scripts/arm_processor_error.py | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/scripts/arm_processor_error.py b/scripts/arm_processor_error.py index 2643e4dd

[PATCH v7 09/10] target/arm: add an experimental mpidr arm cpu property object

2024-08-13 Thread Mauro Carvalho Chehab
Accurately injecting an ARM Processor error ACPI/APEI GHES error record requires the value of the ARM Multiprocessor Affinity Register (mpidr). While ARM implements it, this is currently not visible. Add a field at CPU storing it, and place it at arm_cpu_properties as experimental, thus allowing

Re: [PATCH for-9.2 09/10] hw: Rename DeviceClass::reset field to legacy_reset

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: Rename theDeviceClass::reset field to legacy_reset; this is helpful both in flagging up that it's best not used in new code and in making it easy to search for where it's being used still. Signed-off-by: Peter Maydell --- include/hw/qdev-core.h | 4 ++--

Re: [PATCH for-9.2 08/10] hw: Use device_class_set_legacy_reset() instead of opencoding

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: Use device_class_set_legacy_reset() instead of opencoding an assignment toDeviceClass::reset. This change was produced with: spatch --macro-file scripts/cocci-macro-file.h \ --sp-file scripts/coccinelle/device-reset.cocci \ --keep-comments --smpl

Re: [PATCH for-9.2 07/10] hw: Define new device_class_set_legacy_reset()

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: Define a device_class_set_legacy_reset() function which sets theDeviceClass::reset field. This serves two purposes: * it makes it clearer to the person writing code that DeviceClass::reset is now legacy and they should look for the new alternative

Re: [PATCH for-9.2 02/10] target/s390: Convert CPU to Resettable interface

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: static void sigp_cpu_reset(CPUState *cs, run_on_cpu_data arg) { -S390CPU *cpu = S390_CPU(cs); -S390CPUClass *scc = S390_CPU_GET_CLASS(cpu); SigpInfo *si = arg.host_ptr; cpu_synchronize_state(cs); -scc->reset(cs, S390_CPU_RESET

Re: [PATCH for-9.2 06/10] hw/remote/message.c: Don't directly invoke DeviceClass:reset

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: Directly invoking theDeviceClass::reset method is a bad idea, because if the device is using three-phase reset then it relies on transitional reset machinery which is likely to disappear at some point. Reset the device in the standard way, by calling device

Re: [PATCH for-9.2 05/10] hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: In axidma_class_init() we accidentally used a comma at the end of a statement rather than a semicolon. This has no ill effects, but it's obviously not intended and it means that Coccinelle scripts for instance will fail to match on the two statements. Use a

Re: [PATCH for-9.2 04/10] target/alpha, hppa: Remove unused parent_reset fields

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: The Alpha and HPPA CPU class structs include a 'parent_reset' field which is never used; delete them. (These targets don't seem to implement reset at all; if they did they should do it using the three-phase reset mechanism, which uses a 'ResettablePhases pa

Re: [PATCH for-9.2 03/10] hw: Remove device_class_set_parent_reset()

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: There are no callers of device_class_set_parent_reset() left in the tree, as they've all been converted to use three-phase reset and the corresponding resettable_class_set_parent_phases() function. Remove device_class_set_parent_reset(). Signed-off-by: Pete

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-13 Thread Stefano Stabellini
On Tue, 13 Aug 2024, Edgar E. Iglesias wrote: > On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote: > > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" > > > > > > Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq > > > servers to handle h

Re: [PATCH v6 04/10] qapi/ghes-cper: add an interface to do generic CPER error injection

2024-08-13 Thread Mauro Carvalho Chehab
Em Mon, 12 Aug 2024 13:57:44 +0200 Igor Mammedov escreveu: > n Platform Error Record - CPER - as defined at the UEFI > > +# specification. See > > +# > > https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.html#record-header > > +# for more details. > > +# > > +# @notification-t

Re: [PATCH for-9.2 01/10] hw/s390/virtio-ccw: Convert to three-phase reset

2024-08-13 Thread Richard Henderson
On 8/14/24 02:52, Peter Maydell wrote: Convert the virtio-ccw code to three-phase reset. This allows us to remove a call to device_class_set_parent_reset(), replacing it with the three-phase equivalent resettable_class_set_parent_phases(). Removing all the device_class_set_parent_reset() uses wi

Re: [PATCH v2 1/1] plugins: fix race condition with scoreboards

2024-08-13 Thread Richard Henderson
On 8/13/24 08:07, Pierrick Bouvier wrote: A deadlock can be created if a new vcpu (a) triggers a scoreboard reallocation, and another vcpu (b) wants to create a new scoreboard at the same time. In this case, (a) holds the plugin lock, and starts an exclusive section, waiting for (b). But at the

Re: [PATCH-for-9.1?] target/mips: Load PTE as DATA

2024-08-13 Thread Richard Henderson
On 8/14/24 01:26, Philippe Mathieu-Daudé wrote: PTE is not CODE so load it as normal DATA access. Fixes: 074cfcb4da ("Implement hardware page table walker for MIPS32") Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Based-on:<20240813135313.96519-1-phi...@linaro.org> --

Re: [PATCH-for-9.1 v3 1/2] target/mips: Pass page table entry size as MemOp to get_pte()

2024-08-13 Thread Richard Henderson
On 8/13/24 23:53, Philippe Mathieu-Daudé wrote: @@ -607,11 +607,11 @@ static bool get_pte(CPUMIPSState *env, uint64_t vaddr, int entry_size, } static uint64_t get_tlb_entry_layout(CPUMIPSState *env, uint64_t entry, -int entry_size, int ptei) +

Re: [PATCH v4 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table

2024-08-13 Thread Richard Henderson
On 8/13/24 23:39, Ricardo Ribalda wrote: +const char link_name[][5] = {"LNKD", "LNKA", "LNKB", "LNKC"}; static Otherwise, Reviewed-by: Richard Henderson r~

Re: [RFC V1 6/6] migration: cpr-transfer mode

2024-08-13 Thread Steven Sistare
On 6/30/2024 3:44 PM, Steve Sistare wrote: Add the cpr-transfer migration mode. Usage: [...] @@ -2144,6 +2158,29 @@ void qmp_migrate(const char *uri, bool has_channels, goto out; } +/* + * For cpr-transfer mode, the target first reads CPR state, which cannot + *

Re: [PATCH RFC/RFT] vfio/pci-quirks: Quirk for ath wireless

2024-08-13 Thread Alex Williamson
On Tue, 13 Aug 2024 13:43:41 -0300 Jason Gunthorpe wrote: > On Mon, Aug 12, 2024 at 11:00:40AM -0600, Alex Williamson wrote: > > These devices have an embedded interrupt controller which is programmed > > with guest physical MSI address/data, which doesn't work. We need > > vfio-pci kernel suppo

Re: [PATCH v2 17/21] virtio-net: Use virtual time for RSC timers

2024-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2024 at 09:23:25PM +0100, Alex Bennée wrote: > From: Nicholas Piggin > > Receive coalescing is visible to the target machine, so its timers > should use virtual time like other timers in virtio-net, to be > compatible with record-replay. > > Signed-off-by: Nicholas Piggin > Mess

Re: [PATCH v2 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state

2024-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2024 at 09:23:24PM +0100, Alex Bennée wrote: > From: Nicholas Piggin > > The regular qemu_bh_schedule() calls result in non-deterministic > execution of the bh in record-replay mode, which causes replay failure. > > Reviewed-by: Alex Bennée > Reviewed-by: Pavel Dovgalyuk > Sign

Re: [PATCH V2 06/11] migration: fix mismatched GPAs during cpr

2024-08-13 Thread Peter Xu
On Wed, Aug 07, 2024 at 05:04:26PM -0400, Steven Sistare wrote: > On 7/19/2024 12:28 PM, Peter Xu wrote: > > On Sun, Jun 30, 2024 at 12:40:29PM -0700, Steve Sistare wrote: > > > For new cpr modes, ramblock_is_ignored will always be true, because the > > > memory is preserved in place rather than co

[PATCH v2 18/21] savevm: Fix load_snapshot error path crash

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin An error path missed setting *errp, which can cause a NULL deref. Reviewed-by: Alex Bennée Signed-off-by: Nicholas Piggin Message-Id: <20240813050638.446172-11-npig...@gmail.com> Signed-off-by: Alex Bennée --- migration/savevm.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH v2 17/21] virtio-net: Use virtual time for RSC timers

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin Receive coalescing is visible to the target machine, so its timers should use virtual time like other timers in virtio-net, to be compatible with record-replay. Signed-off-by: Nicholas Piggin Message-Id: <20240813050638.446172-10-npig...@gmail.com> Signed-off-by: Alex Benn

[PATCH v2 20/21] docs/devel: update tcg-plugins page

2024-08-13 Thread Alex Bennée
From: Pierrick Bouvier Reflect recent changes on API (inline ops) and new plugins. Signed-off-by: Pierrick Bouvier Message-Id: <20240812231945.169310-1-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 49 -- docs/deve

[PATCH v2 19/21] docs: Fix some typos (found by typos) and grammar issues

2024-08-13 Thread Alex Bennée
From: Stefan Weil via Fix the misspellings of "overriden" also in code comments. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Message-Id: <20240813125638.395461-1...@weilnetz.de> Signed-off-by: Alex Bennée Reviewed-by: Peter Xu Reviewed-by: Eric Auger --- docs/devel/migration/uadk

[PATCH v2 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin The regular qemu_bh_schedule() calls result in non-deterministic execution of the bh in record-replay mode, which causes replay failure. Reviewed-by: Alex Bennée Reviewed-by: Pavel Dovgalyuk Signed-off-by: Nicholas Piggin Message-Id: <20240813050638.446172-9-npig...@gmai

[PATCH v2 10/21] scripts/replay-dump.py: rejig decoders in event number order

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin Sort decoder functions to be ascending in order of event number, same as the decoder tables. Reviewed-by: Alex Bennée Signed-off-by: Nicholas Piggin Message-Id: <20240813050638.446172-3-npig...@gmail.com> Signed-off-by: Alex Bennée --- scripts/replay-dump.py | 56 ++

[PATCH v2 04/21] configure: Avoid use of param. expansion when using gdb_version

2024-08-13 Thread Alex Bennée
From: Gustavo Romero $gdb_version is now used in more than one conditional case and its usage in such cases may increase in the future. Therefore, avoid using shell parameter expansion when using it by setting gdb_version to its final form. Signed-off-by: Gustavo Romero Message-Id: <20240804161

[PATCH v2 11/21] tests/avocado: excercise scripts/replay-dump.py in replay tests

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin This runs replay-dump.py after recording a trace, and fails the test if the script fails. replay-dump.py is modified to exit with non-zero if an error is encountered while parsing, to support this. Reviewed-by: Alex Bennée Reviewed-by: Pavel Dovgalyuk Signed-off-by: Nich

[PATCH v2 13/21] Revert "replay: stop us hanging in rr_wait_io_event"

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin This reverts commit 1f881ea4a444ef36a8b6907b0b82be4b3af253a2. That commit causes reverse_debugging.py test failures, and does not seem to solve the root cause of the problem x86-64 still hangs in record/replay tests. The problem with short-cutting the iowait that was taken

[PATCH v2 14/21] tests/avocado: replay_kernel.py add x86-64 q35 machine test

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin The x86-64 pc machine is flaky with record/replay, but q35 is more stable. Add a q35 test to replay_kernel.py. Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Nicholas Piggin Message-Id: <20240813050638.446172-7-npig...@gmail.com> Signed-off-by: Alex Benné

[PATCH v2 00/21] Various fixes and tweaks for 9.1-rc2/3

2024-08-13 Thread Alex Bennée
As usual during soft freeze I switch to cleaning up the various niggles and bugs which have accumulated over the years. New for this iteration are some late breaking plugin updates, fixes for record/replay and a few documentation updates. Everything is reviewed so I will roll a pull request later

[PATCH v2 07/21] target/i386: allow access_ptr to force slow path on failed probe

2024-08-13 Thread Alex Bennée
When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault hilarity. Check for an empty haddr to

[PATCH v2 12/21] replay: allow runstate shutdown->running when replaying trace

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin When replaying a trace, it is possible to go from shutdown to running with a reverse-debugging step. This can be useful if the problem being debugged triggers a reset or shutdown. This can be tested by making a recording of a machine that shuts down, then using -action shut

[PATCH v2 15/21] chardev: set record/replay on the base device of a muxed device

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin chardev events to a muxed device don't get recorded because e.g., qemu_chr_be_write() checks whether the base device has the record flag set. This can be seen when replaying a trace that has characters typed into the console, an examination of the log shows they are not rec

[PATCH v2 03/21] configure: Fix arch detection for GDB_HAS_MTE

2024-08-13 Thread Alex Bennée
From: Gustavo Romero GDB_HAS_MTE must only be set if GDB supports the aarch64 arch, so the test if "aarch64" string is present must be against GDB-related '$gdb_arches' variable and not against '$arch' variable. Signed-off-by: Gustavo Romero Message-Id: <20240804161850.2646299-2-gustavo.rom...@

[PATCH v2 05/21] configure: Fix GDB version detection for GDB_HAS_MTE

2024-08-13 Thread Alex Bennée
From: Gustavo Romero The test gdbstub/test-mte.py requires a GDB version that supports the qIsAddressTagged packet. According to GDB NEWS [0], this packet was first made available in the GDB 15.1 release, not in 15.0, so this commit fixes it in configure. [0] https://www.sourceware.org/gdb/news/

[PATCH v2 02/21] Makefile: trigger re-configure on updated pythondeps

2024-08-13 Thread Alex Bennée
If we add additional deps for meson we need to ensure we trigger a reconfigure to make sure everything is set up. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240731140232.22193-1-alex.ben...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240807114059

[PATCH v2 21/21] plugins: fix race condition with scoreboards

2024-08-13 Thread Alex Bennée
From: Pierrick Bouvier A deadlock can be created if a new vcpu (a) triggers a scoreboard reallocation, and another vcpu (b) wants to create a new scoreboard at the same time. In this case, (a) holds the plugin lock, and starts an exclusive section, waiting for (b). But at the same time, (b) is w

[PATCH v2 01/21] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

2024-08-13 Thread Alex Bennée
From: Philippe Mathieu-Daudé We disabled all RX tests on commit 9b45cc9931 ("docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm run

[PATCH v2 09/21] scripts/replay-dump.py: Update to current rr record format

2024-08-13 Thread Alex Bennée
From: Nicholas Piggin The v12 format support for replay-dump has a few issues still. This fixes async decoding; adds event, shutdown, and end decoding; fixes audio in / out events, fixes checkpoint checking of following async events. Reviewed-by: Alex Bennée Signed-off-by: Nicholas Piggin Mess

[PATCH v2 06/21] scripts/checkpatch: more checks on files imported from Linux

2024-08-13 Thread Alex Bennée
From: Stefano Garzarella If a file imported from Linux is touched, emit a warning and suggest using scripts/update-linux-headers.sh. Also check that updating imported files from Linux are not mixed with other changes, in which case emit an error. Signed-off-by: Stefano Garzarella Reviewed-by:

[PATCH v2 08/21] buildsys: Fix building without plugins on Darwin

2024-08-13 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit 0082475e26 the plugin symbol list is unconditionally added to the linker flags, leading to a build failure: Undefined symbols for architecture arm64: "_qemu_plugin_entry_code", referenced from: ... ld: symbol(s) not found for architect

Re: [PATCH V2 00/11] Live update: cpr-exec

2024-08-13 Thread Peter Xu
On Wed, Aug 07, 2024 at 03:47:47PM -0400, Steven Sistare wrote: > On 8/4/2024 12:10 PM, Peter Xu wrote: > > On Sat, Jul 20, 2024 at 05:26:07PM -0400, Steven Sistare wrote: > > > On 7/18/2024 11:56 AM, Peter Xu wrote: > > > > Steve, > > > > > > > > On Sun, Jun 30, 2024 at 12:40:23PM -0700, Steve Si

Re: [PATCH V2 00/11] Live update: cpr-exec

2024-08-13 Thread Peter Xu
On Tue, Aug 06, 2024 at 04:56:18PM -0400, Steven Sistare wrote: > > The flipside, however, is that localhost migration via 2 separate QEMU > > processes has issues where both QEMUs want to be opening the very same > > file, and only 1 of them can ever have them open. I thought we used to have simi

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Pierrick Bouvier
Hi Akihiko, and thanks for contributing this new plugin. Recently, plugins documentation has been modified, and list of plugins and their doc is now in "docs/about/emulation.rst". You may want to rebase on top of master. Globally, I'm ok with this plugin and the implementation. Just a few fi

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-13 Thread Peter Xu
On Tue, Aug 13, 2024 at 01:34:42PM -0400, Steven Sistare wrote: > > > > Non memory-backend-objects (ramblocks not described on the qemu command > > > > line) will always > > > > be allocated using memfd_create (on Linux only).  The alloc-anon option > > > > is deleted. > > > > The logic in ram_bl

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-13 Thread Mauro Carvalho Chehab
Em Mon, 12 Aug 2024 11:39:00 +0200 Igor Mammedov escreveu: > > We may also store cper_offset there via bios_linker_loader_add_pointer() > > and/or use bios_linker_loader_write_pointer(), but I can't see how the > > data stored there can be retrieved, nor any advantage of using it instead > > of t

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-13 Thread Steven Sistare
On 8/13/2024 2:45 PM, Peter Xu wrote: On Tue, Aug 13, 2024 at 11:00:37AM -0600, Alex Williamson wrote: Note that the old-QEMU contents of all ramblocks must be preserved, just like in live migration. Live migration copies the contents in the stream. Live update preserves the contents in place

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-13 Thread Steven Sistare
On 8/13/2024 2:46 PM, Steven Sistare wrote: On 8/13/2024 1:00 PM, Alex Williamson wrote: On Tue, 13 Aug 2024 11:35:15 -0400 Peter Xu wrote: On Mon, Aug 12, 2024 at 02:37:59PM -0400, Steven Sistare wrote: On 8/8/2024 2:32 PM, Steven Sistare wrote: On 7/29/2024 8:29 AM, Igor Mammedov wrote:

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-13 Thread Steven Sistare
On 8/13/2024 1:00 PM, Alex Williamson wrote: On Tue, 13 Aug 2024 11:35:15 -0400 Peter Xu wrote: On Mon, Aug 12, 2024 at 02:37:59PM -0400, Steven Sistare wrote: On 8/8/2024 2:32 PM, Steven Sistare wrote: On 7/29/2024 8:29 AM, Igor Mammedov wrote: On Sat, 20 Jul 2024 16:28:25 -0400 Steven Sis

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-13 Thread Peter Xu
On Tue, Aug 13, 2024 at 11:00:37AM -0600, Alex Williamson wrote: > > > Note that the old-QEMU contents of all ramblocks must be preserved, just > > > like > > > in live migration. Live migration copies the contents in the stream. > > > Live update > > > preserves the contents in place by preser

Re: [PATCH v3 2/5] machine/nitro-enclave: Add vhost-user-vsock device

2024-08-13 Thread Dorjoy Chowdhury
On Mon, Aug 12, 2024 at 8:24 PM Daniel P. Berrangé wrote: > > On Sat, Aug 10, 2024 at 10:44:59PM +0600, Dorjoy Chowdhury wrote: > > AWS Nitro Enclaves have built-in vhost-vsock device support which > > enables applications in enclave VMs to communicate with the parent > > EC2 VM over vsock. The en

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-08-13 Thread Steven Sistare
On 8/13/2024 11:35 AM, Peter Xu wrote: On Mon, Aug 12, 2024 at 02:37:59PM -0400, Steven Sistare wrote: On 8/8/2024 2:32 PM, Steven Sistare wrote: On 7/29/2024 8:29 AM, Igor Mammedov wrote: On Sat, 20 Jul 2024 16:28:25 -0400 Steven Sistare wrote: On 7/16/2024 5:19 AM, Igor Mammedov wrote: O

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-13 Thread Andrew Cooper
On 13/08/2024 6:02 pm, Edgar E. Iglesias wrote: > On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote: >> On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: >>> From: "Edgar E. Iglesias" >>> >>> Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq >>> servers to handle hotplug.

[PULL 1/6] target/hexagon: don't look for static glib

2024-08-13 Thread Paolo Bonzini
From: Alyssa Ross When cross compiling QEMU configured with --static, I've been getting configure errors like the following: Build-time dependency glib-2.0 found: NO ../target/hexagon/meson.build:303:15: ERROR: Dependency lookup for glib-2.0 with method 'pkgconfig' failed: Could not ge

[PULL 4/6] target/i386: Assert MMX and XMM registers in range

2024-08-13 Thread Paolo Bonzini
From: Richard Henderson The mmx assert would fire without the fix for #2495. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/r/20240812025844.58956-4-richard.hender...@linaro.org Signed-off-by: Paolo Bonzini --- target/i386/tcg/emit.c.inc |

[PULL 5/6] module: Prevent crash by resetting local_err in module_load_qom_all()

2024-08-13 Thread Paolo Bonzini
From: Alexander Ivanov Set local_err to NULL after it has been freed in error_report_err(). This avoids triggering assert(*errp == NULL) failure in error_setv() when local_err is reused in the loop. Signed-off-by: Alexander Ivanov Reviewed-by: Claudio Fontana Reviewed-by: Denis V. Lunev Link:

[PULL 6/6] po: update Italian translation

2024-08-13 Thread Paolo Bonzini
Reported-by: bovirus Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2451 Signed-off-by: Paolo Bonzini --- po/it.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/it.po b/po/it.po index c6d95172070..363b9bddf2f 100644 --- a/po/it.po +++

[PULL for-9.1 0/6] Miscellaneous fixes for QEMU 9.1-rc

2024-08-13 Thread Paolo Bonzini
The following changes since commit 9eb51530c12ae645b91e308d16196c68563ea883: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2024-08-13 07:59:32 +1000) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to

[PULL 3/6] target/i386: Use unit not type in decode_modrm

2024-08-13 Thread Paolo Bonzini
From: Richard Henderson Rather that enumerating the types that can produce MMX operands, examine the unit. No functional change. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/r/20240812025844.58956-3-richard.hender...@linaro.org Signed-off

  1   2   3   >