[PATCH] qapi: Refill doc comments to conform to conventions

2024-07-28 Thread Markus Armbruster
Sweep the entire documentation again. Last done in commit 209e64d9edf (qapi: Refill doc comments to conform to current conventions). To check the generated documentation does not change, I compared the generated HTML before and after this commit with "wdiff -3". Finds no differences. Comparing

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-28 Thread Manish
Hi Igor, Anything further on this? Thanks Manish Mishra On 24/07/24 8:30 pm, Zhao Liu wrote: !---| CAUTION: External Email |---! Hi Igor, On Wed, Jul 24, 2024

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread David Woodhouse
On 28 July 2024 16:23:49 BST, "Michael S. Tsirkin" wrote: >On Sun, Jul 28, 2024 at 02:07:01PM +0100, David Woodhouse wrote: >> On 28 July 2024 11:37:04 BST, "Michael S. Tsirkin" wrote: >> >Glad you asked :) >> >> Heh, I'm not sure I'm so glad. Did I mention I hate ACPI? Perhaps it's still >> no

[PULL 0/2] QAPI patches patches for 2024-07-29

2024-07-28 Thread Markus Armbruster
The following changes since commit 93b799fafd9170da3a79a533ea6f73a18de82e22: Merge tag 'pull-ppc-for-9.1-2-20240726-1' of https://gitlab.com/npiggin/qemu into staging (2024-07-26 15:10:45 +1000) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2024-0

[PULL 2/2] qapi/machine: Belatedly document target loongarch64 is since 7.1

2024-07-28 Thread Markus Armbruster
Fixes: a8a506c39070 (hw/loongarch: Add support loongson3 virt machine type.) Signed-off-by: Markus Armbruster Message-ID: <20240718141001.3077709-1-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Song Gao --- qapi/machine.json | 2 ++ 1 file changed, 2 insertions(+) diff --

[PULL 1/2] qapi/qom: make some QOM properties depend on the build settings

2024-07-28 Thread Markus Armbruster
From: Stefano Garzarella Some QOM properties are associated with ObjectTypes that already depend on CONFIG_* switches. So to avoid generating dead code, let's also make the definition of those properties dependent on the corresponding CONFIG_*. Suggested-by: Markus Armbruster Signed-off-by: Ste

QEMU unexpectedly closed the monitor

2024-07-28 Thread Itaru Kitayama
Hi, Executing virt-install with the following options: sudo virt-install --machine=virt --arch=aarch64 --name=test8 --disk path=/var/lib/libvirt/images/jammy.qcow2,format=qcow2,device=disk,bus=virtio,cache=none --memory=2048 --vcpu=1 --nographic --check all=off --features acpi=off --import --o

RE: [PATCH] RISC-V: Remove riscv_cpu_claim_interrupts()

2024-07-28 Thread 張哲嘉
Hi Zhiwei, > -Original Message- > From: LIU Zhiwei > Sent: Monday, July 29, 2024 1:47 PM > To: Alvin Che-Chia Chang(張哲嘉) ; > qemu-ri...@nongnu.org; qemu-devel@nongnu.org > Cc: alistair.fran...@wdc.com; bin.m...@windriver.com; > liwei1...@gmail.com; dbarb...@ventanamicro.com > Subject: Re:

Re: [PATCH] RISC-V: Remove riscv_cpu_claim_interrupts()

2024-07-28 Thread LIU Zhiwei
On 2024/7/27 12:27, Alvin Chang wrote: The function of riscv_cpu_claim_interrupts() was introduced in commit e3e7039 ("RISC-V: Allow interrupt controllers to claim interrupts") to enforce hardware controlled of SEIP signal when there is an attached external interrupt controller. In later RISC-

[PATCH for-9.1] tests/vm/openbsd: Install tomli

2024-07-28 Thread Richard Henderson
Tomli is now required by configure. Signed-off-by: Richard Henderson --- tests/vm/openbsd | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 5e646f7c51..49cab08782 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -32,6 +32,7 @@ class OpenBSDVM(ba

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Akihiko Odaki
On 2024/07/29 12:50, Jason Wang wrote: On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: On 2024/07/27 5:47, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 09:48:02AM +

Re: [PATCH 5/5] target/loongarch/tcg: Add hardware page table walker support

2024-07-28 Thread Richard Henderson
On 7/29/24 11:39, Song Gao wrote: /* Mapped address */ -return loongarch_map_address(env, physical, prot, address, - access_type, mmu_idx); +ret = loongarch_map_address(env, physical, prot, address, +access_type, mmu_id

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Jason Wang
On Fri, Jul 26, 2024 at 2:08 PM Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > > USO features of virtio-net device depend on kernel ability > > > to support them, for backward compati

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Jason Wang
On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: > > On 2024/07/27 5:47, Peter Xu wrote: > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > >> On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: > >>> On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wr

Re: [PATCH] plugins: fix race condition with scoreboards

2024-07-28 Thread Richard Henderson
On 7/23/24 09:23, Pierrick Bouvier wrote: A deadlock can be created if a new vcpu (a) triggers a scoreboard reallocation, and another vcpu (b) wants to create a new scoreboard at the same time. In this case, (a) holds the plugin lock, and starts an exclusive section, waiting for (b). But at the

[PATCH 5/5] target/loongarch/tcg: Add hardware page table walker support

2024-07-28 Thread Song Gao
Add hardware page table walker (HPTW) feature for la664. Set CPUCFG2.HPTW = 1 to indicate that HPTW is implemented on this CPU. Set PWCH.HPTW_EN = 1 to enable HPTW. Signed-off-by: Song Gao --- target/loongarch/cpu-csr.h| 3 + target/loongarch/cpu.c| 1 + target/loongarch/

[PATCH 1/5] target/loongarch: Add a new cpu_type la664

2024-07-28 Thread Song Gao
Add a new LoongArch cpu type la664. The la664 has many new features, such as new atomic instructions, hardware page table walk, etc. We will implement them later. Signed-off-by: Song Gao --- target/loongarch/cpu.c | 48 +++--- 1 file changed, 36 insertions(+),

[PATCH 4/5] target/loongarch: Add get_random_tlb_index()

2024-07-28 Thread Song Gao
get_random_tlb_index() is used to get a random tlb index. Signed-off-by: Song Gao --- target/loongarch/tcg/tlb_helper.c | 34 +-- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/target/loongarch/tcg/tlb_helper.c b/target/loongarch/tcg/tlb_helper.c ind

[PATCH 3/5] target/loongarch: Add do_fill_tlb_entry()

2024-07-28 Thread Song Gao
do_fill_tlb_entry is used to fill a tlb entry. Signed-off-by: Song Gao --- target/loongarch/tcg/tlb_helper.c | 43 ++- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/target/loongarch/tcg/tlb_helper.c b/target/loongarch/tcg/tlb_helper.c index 3c3452b3

[PATCH 2/5] target/loongarch: Add do_lddir/ldpte()

2024-07-28 Thread Song Gao
do_lddir is used for accessing directory entries during page table walking, do_ldpte is used for page table entry accesses during page table walking. Signed-off-by: Song Gao --- target/loongarch/tcg/tlb_helper.c | 53 --- 1 file changed, 34 insertions(+), 19 deletions

[PATCH 0/5] LoongArch/tcg: Add hardware page table walker support

2024-07-28 Thread Song Gao
Loongson-3A6000 and newer processors have hardware page table walker (PTW) support. PTW can handle all fastpaths of PIL/PIS/PIF/PIE exceptions by hardware, Song Gao (5): target/loongarch: Add a new cpu_type la664 target/loongarch: Add do_lddir/ldpte() target/loongarch: Add do_fill_tlb_entry(

Re: [PATCH] Hexagon: fix F2_conv_* instructions for negative zero

2024-07-28 Thread Brian Cain
On 7/28/2024 12:15 PM, Matheus Tavares Bernardino wrote: The implementation for these instructions handles -0 as an invalid float point value, whereas the Hexagon hardware considers it the same as +0 (which is valid). Let's fix that and add a regression test. Signed-off-by: Matheus Tavares Ber

Re: [PATCH] util/cpuinfo: Make use of elf_aux_info(3) on OpenBSD

2024-07-28 Thread Richard Henderson
On 7/28/24 13:58, Brad Smith wrote: util/cpuinfo: Make use of elf_aux_info(3) on OpenBSD Signed-off-by: Brad Smith --- meson.build| 8 util/cpuinfo-aarch64.c | 9 ++--- util/cpuinfo-ppc.c | 5 +++-- util/getauxval.c | 2 +- 4 files changed, 18 insertions

Re: [PATCH v2 0/2] linux-user: Fix handling when AT_EXECFD is 0

2024-07-28 Thread Richard Henderson
On 7/23/24 20:05, Vivian Wang wrote: Found when trying to build coreutils under linux-user as binfmt_misc interpreter with "open-binary" flag. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2448 Changes since v1 [1]: - Removed old glibc check in patch 1 - Added Reviewed-by [1]: https:

Re: [PATCH v2] meson: Use -fno-sanitize=function when available

2024-07-28 Thread Richard Henderson
On 7/29/24 01:44, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in the other context. Add it to meson.build for such. It is not removed from .gitlab-ci.d/b

Re: Using parallel port on the Pegasos 2

2024-07-28 Thread quan
Ah I did not know about the relocation. Using 0x378 as the address works in 8.2.0. I do get the parallel_ioport_write messages now parallel_ioport_write write [SW] addr 0x00 val 0x00 Quan On Sun, Jul 28, 2024 at 5:33 PM BALATON Zoltan wrote: > On Sun, 28 Jul 2024, quan wrote: > > I have tried

Re: Using parallel port on the Pegasos 2

2024-07-28 Thread BALATON Zoltan
On Sun, 28 Jul 2024, quan wrote: I have tried this on qemu 8.2.0 (I downloaded it and compiled with --enable-debug), this build does not seem to hit the breakpoint portio_write function when writing to 0x3bc while it does on the latest qemu git version. Using the trace:memory_region_ops_write o

Re: Using parallel port on the Pegasos 2

2024-07-28 Thread quan
I have tried this on qemu 8.2.0 (I downloaded it and compiled with --enable-debug), this build does not seem to hit the breakpoint portio_write function when writing to 0x3bc while it does on the latest qemu git version. Using the trace:memory_region_ops_write option for 8.2.0, the other devices

Re: Using parallel port on the Pegasos 2

2024-07-28 Thread BALATON Zoltan
On Sun, 28 Jul 2024, quan wrote: I am playing around with the parallel port on the pegasos 2 and I noticed the following issue: The parallel port on startup is set to iobase 0x378, then later it gets remapped to iobase 0x3bc. When I tried writing to the 0x3bc location with trace:memory_region_ops

Re: [RFC v2 1/3] vhost: Introduce packed vq and add buffer elements

2024-07-28 Thread Sahil
Hi, On Friday, July 26, 2024 7:18:28 PM GMT+5:30 Eugenio Perez Martin wrote: > On Fri, Jul 26, 2024 at 11:58 AM Sahil Siddiq wrote: > > This is the first patch in a series to add support for packed > > virtqueues in vhost_shadow_virtqueue. This patch implements the > > insertion of available buff

[PATCH] Hexagon: fix F2_conv_* instructions for negative zero

2024-07-28 Thread Matheus Tavares Bernardino
The implementation for these instructions handles -0 as an invalid float point value, whereas the Hexagon hardware considers it the same as +0 (which is valid). Let's fix that and add a regression test. Signed-off-by: Matheus Tavares Bernardino --- target/hexagon/op_helper.c | 16 ---

Re: [RFC v2 0/3] Add packed virtqueue to shadow virtqueue

2024-07-28 Thread Sahil
Hi, On Friday, July 26, 2024 11:55:14 PM GMT+5:30 Eugenio Perez Martin wrote: > On Fri, Jul 26, 2024 at 7:11 PM Sahil wrote: > > [...] > > > > Q2. > > > > I see that parts of the "vhost-vdpa" implementation is based on > > > > the assumption that SVQ uses the split vq format. For example, > > > >

[PATCH v2] meson: Use -fno-sanitize=function when available

2024-07-28 Thread Akihiko Odaki
Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in the other context. Add it to meson.build for such. It is not removed from .gitlab-ci.d/buildtest.yml because -fno-sanitize=functi

Re: [PATCH 00/13] Bump Avocado to 103.0 LTS and update tests for compatibility and new features

2024-07-28 Thread Akihiko Odaki
On 2024/07/26 22:44, Cleber Rosa wrote: This is a *long* overdue update of the Avocado version used in QEMU. It comes a time where the role of the runner and the libraries are being discussed and questioned. These exact commits have been staging on my side for over 30 days now, and I was exceedi

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2024 at 02:07:01PM +0100, David Woodhouse wrote: > On 28 July 2024 11:37:04 BST, "Michael S. Tsirkin" wrote: > >Glad you asked :) > > Heh, I'm not sure I'm so glad. Did I mention I hate ACPI? Perhaps it's still > not too late for me just to define a DT binding and use PRP0001 for

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Akihiko Odaki
On 2024/07/27 5:47, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: On

Using parallel port on the Pegasos 2

2024-07-28 Thread quan
I am playing around with the parallel port on the pegasos 2 and I noticed the following issue: The parallel port on startup is set to iobase 0x378, then later it gets remapped to iobase 0x3bc. When I tried writing to the 0x3bc location with trace:memory_region_ops_write on, I get logs about writing

Re: [RFC v2 3/3] vhost: Allocate memory for packed vring.

2024-07-28 Thread Sahil
Hi, On Friday, July 26, 2024 7:58:49 PM GMT+5:30 Eugenio Perez Martin wrote: > On Fri, Jul 26, 2024 at 11:59 AM Sahil Siddiq wrote: > > [...] > > @@ -759,19 +780,34 @@ void vhost_svq_start(VhostShadowVirtqueue *svq, > > VirtIODevice *vdev,> > > svq->vq = vq; > > svq->iova_tree = iova_t

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread David Woodhouse
On 28 July 2024 11:37:04 BST, "Michael S. Tsirkin" wrote: >Glad you asked :) Heh, I'm not sure I'm so glad. Did I mention I hate ACPI? Perhaps it's still not too late for me just to define a DT binding and use PRP0001 for it :) >Long story short, QEMUVGID is indeed out of spec, but it works >bo

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread Michael S. Tsirkin
On Fri, Jul 26, 2024 at 07:28:28PM +0100, David Woodhouse wrote: > On 26 July 2024 17:49:58 BST, Jonathan Cameron > wrote: > >On Thu, 25 Jul 2024 14:50:50 +0100 > >David Woodhouse wrote: > > > >> On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > >> > On Thu, Jul 25, 2024 at 01:31:19

Re: [PATCH v12 04/10] hvf: Add Apple Silicon support

2024-07-28 Thread Zenghui Yu
Hi Alexander, On 2021/9/16 23:53, Alexander Graf wrote: +int hvf_arch_init_vcpu(CPUState *cpu) +{ +ARMCPU *arm_cpu = ARM_CPU(cpu); +CPUARMState *env = &arm_cpu->env; +uint32_t sregs_match_len = ARRAY_SIZE(hvf_sreg_match); +uint32_t sregs_cnt = 0; +uint64_t pfr; +hv_retur