Re: [PATCH 0/3] S3 and S4 sleep for loongarch/virt & microvm

On 2024/6/14 下午10:03, Daniel P. Berrangé wrote: On Fri, Jun 14, 2024 at 01:17:39PM +0800, maobibo wrote: On 2024/6/14 下午12:27, Jiaxun Yang wrote: 在2024年6月14日六月 上午4:32，maobibo写道： It is interesting. How to wakeup VM if it sleeps in S3/S4, from emulated keyboard or ethernet magic packet o

Re: [PATCH 1/3] virtio-gpu: rutabaga: Properly set stride when copying resources

On Mon, Jun 10, 2024 at 12:44 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Wed, Jun 5, 2024 at 7:30 PM Weifeng Liu > wrote: > >> The stride is not correctly assigned when copying pixel data, causing >> images being displayed incomplete when using 2d component of rutabaga.

Re: [PULL 0/5] virtio-grants-v8-tag

On Thu, 13 Jun 2024, Richard Henderson wrote: > On 6/12/24 14:29, Stefano Stabellini wrote: > > The following changes since commit 80e8f0602168f451a93e71cbb1d59e93d745e62e: > > > >Merge tag 'virtio-grants-v8-tag' into staging (2024-06-09 11:21:55 -0700) > > > > are available in the Git reposi

Re: [PATCH 9/9] contrib/plugins: add ips plugin example for cost modeling

* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote: > Hi Dave, > > On 6/12/24 14:02, Dr. David Alan Gilbert wrote: > > * Alex Bennée (alex.ben...@linaro.org) wrote: > > > From: Pierrick Bouvier > > > > > > This plugin uses the new time control interface to make decisions > > > about the stat

Re: [PATCH v3 1/6] Add an "info pg" command that prints the current page tables

On 6/7/24 1:43 PM, Richard Henderson wrote: On 6/6/24 07:02, Don Porter wrote: +/** + * get_pte - Copy the contents of the page table entry at node[i] into pt_entry. + *   Optionally, add the relevant bits to the virtual address in + *   vaddr_pte. + * + * @cs - CPU state + *

[PATCH v2] os-posix: Expand setrlimit() syscall compatibility

Darwin uses a subtly different version of the setrlimit() syscall as described in the COMPATIBILITY section of the macOS man page. The value of the rlim_cur member has been adjusted accordingly for Darwin-based systems. Signed-off-by: Trent Huber --- The previous version assumed OPEN_MAX was a co

Re: [PATCH] os-posix: Expand setrlimit() syscall compatibility

> On Jun 14, 2024, at 9:30 AM, Daniel P. Berrangé wrote: > > On Fri, Jun 14, 2024 at 01:14:22AM -0400, Trent Huber wrote: >> Darwin (I'm running version 19.6.0) uses a subtly different version >> of the setrlimit() syscall as described in the COMPATIBILITY section >> of the macOS man page. I adju

[PATCH] Make TARGET_PAGE_MASK typed as target_ulong

this fixes the build warnings like accel/tcg/cputlb.c:416:13: warning: shifting a negative signed value is undefined [-Wshift-negative-value] mask &= TARGET_PAGE_MASK | TLB_INVALID_MASK; ^~~~ include/exec/cpu-all.h:169:45: note: expanded from macro 'TARGET_PAGE_MASK'

Re: [PATCH v3 1/6] Add an "info pg" command that prints the current page tables

Hi Richard, Thank you for all of the helpful comments!  v4 will be much cleaner as a result. A few follow-ups inline. On 6/7/24 12:57 PM, Richard Henderson wrote: On 6/6/24 07:02, Don Porter wrote: + +    /** + * @mon_init_page_table_iterator: Callback to configure a page table +

Re: [RFC PATCH v2 3/5] rust: add PL011 device model

On Fri, Jun 14, 2024 at 9:04 AM Manos Pitsidianakis wrote: > > On Thu, 13 Jun 2024 23:57, Paolo Bonzini wrote: > >On Thu, Jun 13, 2024 at 11:16 AM Daniel P. Berrangé > >wrote: > >> I guess there's a balance to be had somewhere on the spectrum between doing > >> everything against the raw C bind

Re: [PATCH] cpu: fix memleak of 'halt_cond' and 'thread'

On 6/12/24 10:04, Matheus Tavares Bernardino wrote: Since a4c2735f35 (cpu: move Qemu[Thread|Cond] setup into common code, 2024-05-30) these fields are now allocated at cpu_common_initfn(). So let's make sure we also free them at cpu_common_finalize(). Furthermore, the code also frees these on ro

Re: [PATCH 9/9] contrib/plugins: add ips plugin example for cost modeling

Hi Dave, On 6/12/24 14:02, Dr. David Alan Gilbert wrote: * Alex Bennée (alex.ben...@linaro.org) wrote: From: Pierrick Bouvier This plugin uses the new time control interface to make decisions about the state of time during the emulation. The algorithm is currently very simple. The user specif

Re: [RFC PATCH v2 0/2] ui/gtk: Introduce new param - Connectors

Hi Marc-André, Ok, it is good to know dmabuf is used for sharing the scanout between processes when using dbus or virt-viewer. BTW, I have some more comments on your previous answers. I just copied ans pasted your previous comments. Sorry about any inconvenience caused by this delayed respo

Re: [PATCH 9/9] contrib/plugins: add ips plugin example for cost modeling

On 6/13/24 01:54, Philippe Mathieu-Daudé wrote: On 12/6/24 17:35, Alex Bennée wrote: From: Pierrick Bouvier This plugin uses the new time control interface to make decisions about the state of time during the emulation. The algorithm is currently very simple. The user specifies an ips rate whi

Re: [PATCH 8/9] plugins: add time control API

On 6/13/24 08:56, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 12/6/24 17:35, Alex Bennée wrote: Expose the ability to control time through the plugin API. Only one plugin can control time so it has to request control when loaded. There are probably more corner cases to catch here. Fr

[PULL 03/18] tests/qtest/migration-test: Enable on ppc64 TCG

From: Nicholas Piggin ppc64 with TCG seems to no longer be failing this test, perhaps since commit 03bfc2188f061 ("physmem: Fix migration dirty bitmap coherency with TCG memory access") which is not ppc specific but was seen to hit ppc64 quite easily. Let's enable it again. The s390x problem ha

[PULL 15/18] migration/multifd: Add UADK initialization

From: Shameer Kolothum Initialize UADK session and allocate buffers required. The actual compression/decompression will only be done in a subsequent patch. Signed-off-by: Shameer Kolothum Reviewed-by: Fabiano Rosas Reviewed-by: Zhangfei Gao Signed-off-by: Fabiano Rosas --- migration/multifd

[PULL 06/18] migration/multifd: put IOV initialization into compression method

From: Yuan Liu Different compression methods may require different numbers of IOVs. Based on streaming compression of zlib and zstd, all pages will be compressed to a data block, so two IOVs are needed for packet header and compressed data block. Signed-off-by: Yuan Liu Reviewed-by: Nanhai Zou

[PULL 01/18] tests/qtest: Move common define from libqos-spapr.h to new ppc-util.h

From: Nicholas Piggin The spapr QEMU machine defaults is useful outside libqos, so create a new header for ppc specific qtests and move it there. Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin Signed-off-by: Fabiano Rosas --- tests/qtest/boot-serial-test.c| 2 +- tests/qtest/li

[PULL 14/18] migration/multifd: add uadk compression framework

From: Shameer Kolothum Adds the skeleton to support uadk compression method. Complete functionality will be added in subsequent patches. Acked-by: Markus Armbruster Reviewed-by: Fabiano Rosas Signed-off-by: Shameer Kolothum Reviewed-by: Zhangfei Gao Signed-off-by: Fabiano Rosas --- hw/core

[PULL 09/18] migration/multifd: implement initialization of qpl compression

From: Yuan Liu during initialization, a software job is allocated to each channel for software path fallabck when the IAA hardware is unavailable or the hardware job submission fails. If the IAA hardware is available, multiple hardware jobs are allocated for batch processing. Signed-off-by: Yuan

[PULL 17/18] migration/multifd: Switch to no compression when no hardware support

From: Shameer Kolothum Send raw packets over if UADK hardware support is not available. This is to satisfy  Qemu qtest CI which may run on platforms that don't have UADK hardware support. Subsequent patch will add support for uadk migration qtest. Reviewed-by: Fabiano Rosas Signed-off-by: Shame

[PULL 12/18] docs/migration: add uadk compression feature

From: Shameer Kolothum Document UADK(User Space Accelerator Development Kit) library details and how to use that for migration. Signed-off-by: Shameer Kolothum Reviewed-by: Zhangfei Gao [s/Qemu/QEMU in docs] Signed-off-by: Fabiano Rosas --- docs/devel/migration/features.rst | 1 +

[PULL 16/18] migration/multifd: Add UADK based compression and decompression

From: Shameer Kolothum Uses UADK wd_do_comp_sync() API to (de)compress a normal page using hardware accelerator. Reviewed-by: Fabiano Rosas Signed-off-by: Shameer Kolothum Reviewed-by: Zhangfei Gao Signed-off-by: Fabiano Rosas --- migration/multifd-uadk.c | 132 +

[PULL 13/18] configure: Add uadk option

From: Shameer Kolothum Add --enable-uadk and --disable-uadk options to enable and disable UADK compression accelerator. This is for using UADK based hardware accelerators for live migration. Reviewed-by: Fabiano Rosas Signed-off-by: Shameer Kolothum Reviewed-by: Zhangfei Gao Signed-off-by: Fa

[PULL 18/18] tests/migration-test: add uadk compression test

From: Shameer Kolothum Reviewed-by: Fabiano Rosas Signed-off-by: Shameer Kolothum Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 887cd9

[PULL 00/18] Migration patches for 2024-06-14

The following changes since commit 046a64b9801343e2e89eef10c7a48eec8d8c0d4f: Merge tag 'pull-request-2024-06-12' of https://gitlab.com/thuth/qemu into staging (2024-06-13 07:51:58 -0700) are available in the Git repository at: https://gitlab.com/farosas/qemu.git tags/migratio

[PULL 07/18] configure: add --enable-qpl build option

From: Yuan Liu add --enable-qpl and --disable-qpl options to enable and disable the QPL compression method for multifd migration. The Query Processing Library (QPL) is an open-source library that supports data compression and decompression features. It is based on the deflate compression algorit

[PULL 08/18] migration/multifd: add qpl compression method

From: Yuan Liu add the Query Processing Library (QPL) compression method Introduce the qpl as a new multifd migration compression method, it can use In-Memory Analytics Accelerator(IAA) to accelerate compression and decompression, which can not only reduce network bandwidth requirement but also

[PULL 05/18] docs/migration: add qpl compression feature

From: Yuan Liu add Intel Query Processing Library (QPL) compression method introduction Signed-off-by: Yuan Liu Reviewed-by: Nanhai Zou Reviewed-by: Fabiano Rosas Acked-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/devel/migration/features.rst| 1 + docs/devel/migration/qpl-

[PULL 11/18] tests/migration-test: add qpl compression test

From: Yuan Liu add qpl to compression method test for multifd migration the qpl compression supports software path and hardware path(IAA device), and the hardware path is used first by default. If the hardware path is unavailable, it will automatically fallback to the software path for testing.

[PULL 10/18] migration/multifd: implement qpl compression and decompression

From: Yuan Liu QPL compression and decompression will use IAA hardware path if the IAA hardware is available. Otherwise the QPL library software path is used. The hardware path will automatically fall back to QPL software path if the IAA queues are busy. In some scenarios, this may happen freque

[PULL 04/18] tests/qtest/migration-test: Use custom asm bios for ppc64

From: Nicholas Piggin Similar to other archs, build a custom bios memory updater. Running the test with OF code is a cool trick, but SLOF takes a long time to boot. This reduces test time by around 3x (150s to 50s). Reviewed-by: Fabiano Rosas Signed-off-by: Nicholas Piggin Signed-off-by: Fabia

[PULL 02/18] tests/qtest/migration-test: Quieten ppc64 QEMU warnings

From: Nicholas Piggin Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index b7e3406471..48f5

Re: [PATCH v2 8/9] gdbstub: Add support for MTE in user mode

Hi Alex, On 6/14/24 7:51 AM, Alex Bennée wrote: Gustavo Romero writes: This commit implements the stubs to handle the qIsAddressTagged, qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag' subcommands to work with QEMU gdbstub on aarch64 user mode. It also implements the get/set fu

Re: [PATCH v2 0/9] Add MTE stubs for aarch64 user mode

On 6/14/24 12:49 PM, Alex Bennée wrote: Gustavo Romero writes: This patchset adds the stubs necessary to support GDB memory tagging commands on QEMU aarch64 user mode. These new stubs handle the qIsAddressTagged, qMemTag, and QMemTag packets, which allow GDB memory tagging subcommands 'che

Re: [PATCH v2 9/9] tests/tcg/aarch64: Add MTE gdbstub tests

Hi Alex! On 6/14/24 8:42 AM, Alex Bennée wrote: Gustavo Romero writes: Add tests to exercise the MTE stubs. Signed-off-by: Gustavo Romero --- tests/tcg/aarch64/Makefile.target | 11 ++- tests/tcg/aarch64/gdbstub/test-mte.py | 86 ++ tests/tcg/aarch64/mte-8.c

Re: [PATCH v2 0/9] Add MTE stubs for aarch64 user mode

Gustavo Romero writes: > This patchset adds the stubs necessary to support GDB memory tagging > commands on QEMU aarch64 user mode. > > These new stubs handle the qIsAddressTagged, qMemTag, and QMemTag > packets, which allow GDB memory tagging subcommands 'check', > 'print-allocation-tag', and 's

[PATCH v2] linux-user: Make TARGET_NR_setgroups affect only the current thread

Like TARGET_NR_setuid, TARGET_NR_setgroups should affect only the calling thread, and not the entire process. Therefore, implement it using a syscall, and not a libc call. Cc: qemu-sta...@nongnu.org Fixes: 19b84f3c35d7 ("added setgroups and getgroups syscalls") Signed-off-by: Ilya Leoshkevich Rev

RE: [PATCH 2/2] hw/arm/xilinx_zynq: Add boot-mode property

Hi Edgar, From: Edgar E. Iglesias Sent: Friday, June 14, 2024 4:38 PM To: Boddu, Sai Pavan Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Alistair Francis ; Peter Maydell ; Iglesias, Francisco Subject: Re: [PATCH 2/2] hw/arm/xilinx_zynq: Add boot-mode property On Thu, Jun 13, 2024 at 5:36 P

Re: [PATCH 20/20] qapi: convert "Example" sections to rST

John Snow writes: > Eliminate the "Example" sections in QAPI doc blocks, converting them > into QMP example code blocks. This is generally done by converting > "Example:" or "Examples:" lines into ".. code-block:: QMP" lines. > > This patch does also allow for the use of the rST syntax "Example::

Re: [PATCH 0/3] S3 and S4 sleep for loongarch/virt & microvm

On Fri, Jun 14, 2024 at 01:17:39PM +0800, maobibo wrote: > > > On 2024/6/14 下午12:27, Jiaxun Yang wrote: > > > > > > 在2024年6月14日六月 上午4:32，maobibo写道： > > > It is interesting. > > > > > > How to wakeup VM if it sleeps in S3/S4, from emulated keyboard or > > > ethernet magic packet or qemu monitor

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

On Fri, 14 Jun 2024 12:57:25 +0200 Igor Mammedov wrote: > On Thu, 6 Jun 2024 18:47:16 +0100 > Jonathan Cameron wrote: > > > On Thu, 6 Jun 2024 16:06:53 +0200 > > Igor Mammedov wrote: > > > > > On Wed, 5 Jun 2024 19:04:55 +0100 > > > Jonathan Cameron wrote: > > > > > > > Treating the HID

Re: [PATCH 0/3] S3 and S4 sleep for loongarch/virt & microvm

在2024年6月14日六月 上午6:17，maobibo写道： > On 2024/6/14 下午12:27, Jiaxun Yang wrote: >> >> >> 在2024年6月14日六月 上午4:32，maobibo写道： >>> It is interesting. >>> >>> How to wakeup VM if it sleeps in S3/S4, from emulated keyboard or >>> ethernet magic packet or qemu monitor command in background? >> >> Hi Bibo,

Re: [PATCH 19/20] qapi: convert "Note" sections to plain rST

John Snow writes: > We do not need a dedicated section for notes. By eliminating a specially > parsed section, these notes can be treated as normal rST paragraphs in > the new QMP reference manual, and can be placed and styled much more > flexibly. > > Update the QAPI parser to now prohibit speci

Re: [RFC PATCH 01/16] accel/tcg: Store section pointer in CPUTLBEntryFull

On 2024/6/13 18:37, Jim Shu wrote: Hi Zhiwei, Common IOMMU devices will not have IOMMUMemoryRegion in the path of CPU access since It only affects DMA access. In QEMU, it usually places this IOMMU MR as the parent of "system_memory", and changes the target_mr of DMA from "system_memory" to IOM

Re: [PATCH v3 00/13] riscv: QEMU RISC-V IOMMU Support

On 2024/6/12 20:10, Daniel Henrique Barboza wrote: On 6/12/24 4:50 AM, LIU Zhiwei wrote: On 2024/6/11 18:13, Daniel Henrique Barboza wrote: Hi Zhiwei, On 6/10/24 10:51 PM, LIU Zhiwei wrote: Hi Daniel, I want to know if we can use the IOMMU and IOPMP at the same time. AFAIK we can. The

Re: [PATCH] os-posix: Expand setrlimit() syscall compatibility

On Fri, Jun 14, 2024 at 01:14:22AM -0400, Trent Huber wrote: > Darwin (I'm running version 19.6.0) uses a subtly different version > of the setrlimit() syscall as described in the COMPATIBILITY section > of the macOS man page. I adjusted the way the rlim_cur member is set > to accommodate and which

Re: [PATCH v7 1/2] hw/misc/riscv_iopmp: Add RISC-V IOPMP device

On 2024/6/14 9:46, Ethan Chen wrote: On Thu, Jun 13, 2024 at 05:26:03PM +0800, LIU Zhiwei wrote: Hi Ethan, On 2024/6/12 11:17, Ethan Chen wrote: Support basic functions of IOPMP specification v0.9.1 rapid-k model. The specification url: https://github.com/riscv-non-isa/iopmp-spec/releases/ta

Re: [PATCH v2 0/7] Live migration acceleration with UADK

On Fri, 07 Jun 2024 14:53:03 +0100, Shameer Kolothum via wrote: > v1 --> v2 > (v1: > https://lore.kernel.org/qemu-devel/20240529094435.11140-1-shameerali.kolothum.th...@huawei.com/) > > -Rebased on top of Intel IAA v7 series[0]. > -Addressed comments from Fabiano. Thanks. > -Gathered tags receive

Re: [PATCH v8 0/7] Live Migration With IAA

On Mon, 10 Jun 2024 18:21:03 +0800, Yuan Liu wrote: > I am writing to submit a code change aimed at enhancing live migration > acceleration by leveraging the compression capability of the Intel > In-Memory Analytics Accelerator (IAA). > > The implementation of the IAA (de)compression code is based

[PATCH] os-posix: Expand setrlimit() syscall compatibility

Darwin (I'm running version 19.6.0) uses a subtly different version of the setrlimit() syscall as described in the COMPATIBILITY section of the macOS man page. I adjusted the way the rlim_cur member is set to accommodate and which shouldn't affect any non-Darwin systems. Signed-off-by: Trent Huber

[PATCH v2] target/s390x: Add a CONFIG switch to disable legacy CPUs

The oldest model that IBM still supports is the z13. Considering that each generation can "emulate" the previous two generations in hardware (via the "IBC" feature of the CPUs), this means that everything that is older than z114/196 is not an officially supported CPU model anymore. The Linux kernel

Re: [PATCH v2 5/9] target/arm: Make some MTE helpers widely available

On 13/6/24 20:13, Gustavo Romero wrote: Hi Phil! On 6/13/24 2:32 PM, Philippe Mathieu-Daudé wrote: Hi Gustavo, On 13/6/24 19:20, Gustavo Romero wrote: Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1 available to other subsystems by moving them from mte_helper.c to a n

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

On 14-06-2024 16:57, Cédric Le Goater wrote: On 6/13/24 3:45 PM, Chalapathi V wrote: On 20-05-2024 11:19, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flas

Re: [PATCH v2 9/9] tests/tcg/aarch64: Add MTE gdbstub tests

Gustavo Romero writes: > Add tests to exercise the MTE stubs. > > Signed-off-by: Gustavo Romero > --- > tests/tcg/aarch64/Makefile.target | 11 ++- > tests/tcg/aarch64/gdbstub/test-mte.py | 86 ++ > tests/tcg/aarch64/mte-8.c | 102 ++

Re: [PATCH v2 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

Gustavo Romero writes: > Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they > are not confined to use only in gdbstub.c. so they can be used by architecture extensions to the gdbstub? we don't want everyone using these functions, or if we do maybe we should consider moving th

Re: [PATCH v2 4/9] target/arm: Fix exception case in allocation_tag_mem_probe

Gustavo Romero writes: > If page in 'ptr_access' is inaccessible and probe is 'true' > allocation_tag_mem_probe should not throw an exception, but currently it > does, so fix it. > > Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

On 6/13/24 3:45 PM, Chalapathi V wrote: On 20-05-2024 11:19, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and an ADC controller. All SPI functio

Re: [PATCH v2 3/9] gdbstub: Add support for target-specific stubs

Gustavo Romero writes: > Currently, it's not possible to have stubs specific to a given target, > even though there are GDB features which are target-specific, like, for > instance, memory tagging. > > This commit introduces gdb_extend_qsupported_features, > gdb_extend_query_table, and gdb_extend

Re: [PATCH v2 2/9] gdbstub: Move GdbCmdParseEntry into a new header file

Gustavo Romero writes: > Move GdbCmdParseEntry and its associated types into a separate header > file to allow the use of GdbCmdParseEntry and other gdbstub command > functions outside of gdbstub.c. > > Since GdbCmdParseEntry and get_param are now public, kdoc > GdbCmdParseEntry and rename get_pa

Re: [PATCH 18/20] qapi: ensure all errors sections are uniformly typset

John Snow writes: > Transactions have the only instance of an Errors section that isn't a > rST list; turn it into one. Just for consistency? Or do you have other shenanigans up your sleeve? If we want the Errors sections to remain all rST lists, we should update docs/devel/qapi-code-gen.rst t

Re: [PATCH v2 1/9] gdbstub: Clean up process_string_cmd

Gustavo Romero writes: > Change 'process_string_cmd' to return true on success and false on > failure, instead of 0 and -1. > > Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 6/9] target/arm: Factor out code for setting MTE TCF0 field

Gustavo Romero writes: > Factor out the code used for setting the MTE TCF0 field from the prctl > code into a convenient function. Other subsystems, like gdbstub, need to > set this field as well, so keep it as a separate function to avoid > duplication and ensure consistency in how this field is

Re: [PATCH 2/2] hw/arm/xilinx_zynq: Add boot-mode property

On Thu, Jun 13, 2024 at 5:36 PM Sai Pavan Boddu wrote: > Read boot-mode value as machine property and propagate that to > SLCR.BOOT_MODE register. > > Hi Sai, Directly exposing the register field to the user to set on the command-line probably makes usability a little too rough (user has to chec

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

On Thu, 6 Jun 2024 18:47:16 +0100 Jonathan Cameron wrote: > On Thu, 6 Jun 2024 16:06:53 +0200 > Igor Mammedov wrote: > > > On Wed, 5 Jun 2024 19:04:55 +0100 > > Jonathan Cameron wrote: > > > > > Treating the HID as an integer caused it to get bit reversed > > > on big endian hosts running lit

Re: [PATCH 14/20] qapi: fix non-compliant JSON examples

John Snow writes: > If we parse all examples as QMP, we need them to conform to a standard > so that they render correctly. Once the QMP lexer is active for > examples, these will produce warning messages and fail the build. > > The QMP lexer still supports elisions, but they must be represented

Re: [PATCH v2 8/9] gdbstub: Add support for MTE in user mode

Gustavo Romero writes: > This commit implements the stubs to handle the qIsAddressTagged, > qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag' > subcommands to work with QEMU gdbstub on aarch64 user mode. It also > implements the get/set functions for the special GDB MTE register > '

Re: [PATCH v5 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine

W dniu 7.06.2024 o 12:38, Xiong Yining pisze: Enable CPU cluster support on SbsaQemu platform, so that users can specify a 4-level CPU hierarchy sockets/clusters/cores/threads. And this topology can be passed to the firmware through /cpus/topology Device Tree. Signed-off-by: Xiong Yining tested

[PATCH] i386: revert defaults to 'legacy-vm-type=true' for SEV(-ES) guests

The KVM_SEV_INIT2 ioctl was only introduced in Linux 6.10, which will only have been released for a bit over a month when QEMU 9.1 is released. The SEV(-ES) support in QEMU has been present since 2.12 dating back to 2018. With this in mind, the overwhealming majority of users of SEV(-ES) are unlik

Re: [PATCH v3 1/7] HostIOMMUDevice: Store the VFIO/VDPA agent

Talking of which, why are we passing a 'VFIODevice *' parameter to HostIOMMUDeviceClass::realize ? I don't see a good reason I think a 'VFIOContainerBase *' would be more appropriate since 'HostIOMMUDevice' represents a device on the host which is common to all VFIO devices. In that case, H

Re: [PATCH v4 27/31] hw/i386/sev: Use guest_memfd for legacy ROMs

On 6/14/2024 10:58 AM, Xiaoyao Li wrote: On 5/30/2024 7:16 PM, Pankaj Gupta wrote: From: Michael Roth Current SNP guest kernels will attempt to access these regions with with C-bit set, so guest_memfd is needed to handle that. Otherwise, kvm_convert_memory() will fail when the guest kernel tri

Re: [PATCH v3 1/7] HostIOMMUDevice: Store the VFIO/VDPA agent

Hi Cédric, On 6/14/24 11:13, Cédric Le Goater wrote: > On 6/13/24 11:20 AM, Eric Auger wrote: >> Store the agent device (VFIO or VDPA) in the host IOMMU device. >> This will allow easy access to some of its resources. >> >> Signed-off-by: Eric Auger >> Reviewed-by: Zhenzhong Duan >> --- >>   inc

[PATCH v4 5/8] virtio-iommu: Compute host reserved regions

Compute the host reserved regions in virtio_iommu_set_iommu_device(). The usable IOVA regions are retrieved from the HostIOMMUDevice. The virtio_iommu_set_host_iova_ranges() helper turns usable regions into complementary reserved regions while testing the inclusion into existing ones. virtio_iommu_

[PATCH v4 3/8] HostIOMMUDevice: Introduce get_iova_ranges callback

Introduce a new HostIOMMUDevice callback that allows to retrieve the usable IOVA ranges. Implement this callback in the legacy VFIO and IOMMUFD VFIO host iommu devices. This relies on the VFIODevice agent's base container iova_ranges resource. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Dua

[PATCH v4 0/8] VIRTIO-IOMMU/VFIO: Fix host iommu geometry handling for hotplugged devices

This series is based on Zhenzhong HostIOMMUDevice: [PATCH v7 00/17] Add a host IOMMU device abstraction to check with vIOMMU https://lore.kernel.org/all/20240605083043.317831-1-zhenzhong.d...@intel.com/ It allows to convey host IOVA reserved regions to the virtio-iommu and uses the HostIOMMUDevi

[PATCH v4 7/8] hw/vfio: Remove memory_region_iommu_set_iova_ranges() call

As we have just removed the only implementation of iommu_set_iova_ranges IOMMU MR callback in the virtio-iommu, let's remove the call to the memory wrapper. Usable IOVA ranges are now conveyed through the PCIIOMMUOps in VFIO-PCI. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan --- hw/vfio

[PATCH v4 2/8] virtio-iommu: Implement set|unset]_iommu_device() callbacks

Implement PCIIOMMUOPs [set|unset]_iommu_device() callbacks. In set(), the HostIOMMUDevice handle is stored in a hash table indexed by PCI BDF. The object will allow to retrieve information related to the physical IOMMU. Signed-off-by: Eric Auger --- v3 -> v4: - Simply use native HostIOMMUDevice

[PATCH v4 8/8] memory: Remove IOMMU MR iommu_set_iova_range API

Since the host IOVA ranges are now passed through the PCIIOMMUOps set_host_resv_regions and we have removed the only implementation of iommu_set_iova_range() in the virtio-iommu and the only call site in vfio/common, let's retire the IOMMU MR API and its memory wrapper. Signed-off-by: Eric Auger

[PATCH v4 6/8] virtio-iommu: Remove the implementation of iommu_set_iova_range

Now that we use PCIIOMMUOps to convey information about usable IOVA ranges we do not to implement the iommu_set_iova_ranges IOMMU MR callback. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan --- hw/virtio/virtio-iommu.c | 67 1 file changed, 67 del

[PATCH v4 4/8] HostIOMMUDevice: Store the aliased bus and devfn

Store the aliased bus and devfn in the HostIOMMUDevice. This will be useful to handle info that are iommu group specific and not device specific (such as reserved iova ranges). Signed-off-by: Eric Auger --- include/sysemu/host_iommu_device.h | 2 ++ hw/pci/pci.c | 8 ++-

[PATCH v4 1/8] HostIOMMUDevice: Store the VFIO/VDPA agent

Store the agent device (VFIO or VDPA) in the host IOMMU device. This will allow easy access to some of its resources. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan --- include/sysemu/host_iommu_device.h | 1 + hw/vfio/container.c| 1 + hw/vfio/iommufd.c

Re: [PATCH 13/20] docs/qapidoc: fix nested parsing under untagged sections

John Snow writes: > Sphinx does not like sections without titles, because it wants to > convert every section into a reference. When there is no title, it > struggles to do this and transforms the tree inproperly. > > Depending on the rST used, this may result in an assertion error deep in > the

Re: [PATCH] tests/qtest/fuzz/virtio_net_fuzz.c: fix virtio_net_fuzz_multi

On 13.06.2024 19:50, Thomas Huth wrote: On 13/06/2024 13.59, Дмитрий Фролов wrote: On 13.06.2024 13:08, Thomas Huth wrote: On 23/05/2024 12.28, Dmitry Frolov wrote: If QTestState was already CLOSED due to error, calling qtest_clock_step() afterwards makes no sense and only raises false-cras

Re: [PATCH 11/20] qapi/schema: add doc_visible property to QAPISchemaDefinition

John Snow writes: > The intent here is to mark only certain definitions as visible in the > end-user docs. > > All commands and events are inherently visible. Everything else is > visible only if it is a member (or a branch member) of a type that is > visible, or if it is named as a return type f

Re: [PATCH v3] target/loongarch/kvm: Add software breakpoint support

在 2024/6/7 上午11:50, Bibo Mao 写道: With KVM virtualization, debug exception is injected to guest kernel rather than host for normal break intruction. Here hypercall instruction with special code is used for sw breakpoint usage, and detailed instruction comes from kvm kernel with user API KVM_REG_LO

Re: *** MAY_BE_SPAM !!! *** Re: [PATCH] tests/qtest/fuzz/virtio_net_fuzz.c: fix virtio_net_fuzz_multi

On 13.06.2024 18:54, Alexander Bulekov wrote: This fixes the almost-immediate timeout issue for me on the virtio_net_fuzz target, but I'm not sure why this works or if it is fixing the right problem: qtest_probe_child is designed to run from a libqtest process which uses waitpid on the PID of th

[PATCH RFC 1/3] target/arm: Add dcc uart support

DCC is a debug port to transfer some data between debugger and processor, we are using this feature to connect a chardev device. Chardev frontends should be named as "dcc" inorder to connect to this interface. Signed-off-by: Sai Pavan Boddu --- target/arm/cpu.h | 11 + target/arm/inter

[PATCH RFC 2/3] target/arm: Enable dcc console for a53 and R5

This enabled DCC support. Signed-off-by: Sai Pavan Boddu --- target/arm/cpu64.c | 1 + target/arm/tcg/cpu32.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 262a1d6c0b..e39740303b 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@

[PATCH RFC 3/3] target/arm/debug_helper: Add fieldoffset for MDCCSR_EL0 reg

MDCCSR_EL0 is aarch64 varient of DBGDSCRint, so utilize the same cpreg offset. Signed-off-by: Sai Pavan Boddu --- target/arm/debug_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index 7d856acddf..5deafa4d1f 10064

[PATCH RFC 0/3] Add DCC uart console support

This patch series attaches a chardev to arm Debug Communication channel registers, As each cpu has it own DBGDTRTX/RX register just tried to hook each cpu with chardev iff we find a chardev with id "dcc". ex: Below chardev switch would be connected to A53-0. ./qemu-system-aarch64 -M xln

Re: [RFC PATCH] migration/savevm: do not schedule snapshot_save_job_bh in qemu_aio_context

Am 12.06.24 um 17:34 schrieb Stefan Hajnoczi: > > Thank you for investigating! It looks like we would be trading one > issue (the assertion failures you mentioned) for another (a rare, but > possible, hang). > > I'm not sure what the best solution is. It seems like vm_stop() is the > first place

Re: [PATCH] ui/gtk: Wait until the current guest frame is rendered before switching to RUN_STATE_SAVE_VM

Hi On Thu, Jun 13, 2024 at 9:27 PM Kim, Dongwon wrote: > Hi Marc-André, > > On 6/13/2024 6:16 AM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jun 12, 2024 at 10:50 PM Kim, Dongwon > > wrote: > > > > On 6/11/2024 10:44 PM, Marc-André Lureau wrote: > > >

Re: [PATCH v2 00/22] qga: clean up command source locations and conditionals

On Fri, Jun 14, 2024 at 12:34:52PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Jun 13, 2024 at 7:02 PM Daniel P. Berrangé > wrote: > > > This series is a side effect of other work I started, to attempt to > > make the QGA safe to use in confidential VMs by automatically > > restricting the

Re: [PATCH v3 1/7] HostIOMMUDevice: Store the VFIO/VDPA agent

On 6/13/24 11:20 AM, Eric Auger wrote: Store the agent device (VFIO or VDPA) in the host IOMMU device. This will allow easy access to some of its resources. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan --- include/sysemu/host_iommu_device.h | 1 + hw/vfio/container.c

Re: [PATCH v2 0/2] AWS Nitro Enclave emulation

On 01.06.24 18:26, Dorjoy Chowdhury wrote: This is v2 submission for AWS Nitro Enclave emulation in QEMU. v1 is at: https://mail.gnu.org/archive/html/qemu-devel/2024-05/msg03524.html Changes in v2: - moved eif.c and eif.h files from hw/i386 to hw/core Hi, Hope everyone is doing well. I a

Re: [PATCH v4 28/31] hw/i386: Add support for loading BIOS using guest_memfd

On 6/14/2024 4:48 PM, Gupta, Pankaj wrote: On 6/14/2024 10:34 AM, Xiaoyao Li wrote: On 5/30/2024 7:16 PM, Pankaj Gupta wrote: From: Michael Roth When guest_memfd is enabled, the BIOS is generally part of the initial encrypted guest image and will be accessed as private guest memory. Add the n

Re: [PATCH v2 6/9] target/arm: Factor out code for setting MTE TCF0 field

On 13/6/24 20:15, Gustavo Romero wrote: Hi Phil, On 6/13/24 2:35 PM, Philippe Mathieu-Daudé wrote: On 13/6/24 19:21, Gustavo Romero wrote: Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this fi

Re: [PATCH v3 4/7] virtio-iommu: Compute host reserved regions

Hi Zhenzhong, On 6/14/24 05:05, Duan, Zhenzhong wrote: > >> -Original Message- >> From: Eric Auger >> Subject: Re: [PATCH v3 4/7] virtio-iommu: Compute host reserved regions >> >> >> >> On 6/13/24 12:00, Duan, Zhenzhong wrote: >>> Hi Eric, >>> -Original Message- From: Er

Re: [PATCH v4 27/31] hw/i386/sev: Use guest_memfd for legacy ROMs

On 5/30/2024 7:16 PM, Pankaj Gupta wrote: From: Michael Roth Current SNP guest kernels will attempt to access these regions with with C-bit set, so guest_memfd is needed to handle that. Otherwise, kvm_convert_memory() will fail when the guest kernel tries to access it and QEMU attempts to call

  1   2   >