RE: [PATCH 3/7] migration/multifd: add uadk compression framework

2024-05-29 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, May 29, 2024 12:11 PM > To: Shameer Kolothum via > Cc: pet...@redhat.com; faro...@suse.de; yuan1@intel.com; Shameerali > Kolothum Thodi ; Linuxarm > ; linwenkai (C) ; > zhangfei@linaro.org; huangchenghai > Subje

Re: [RFC PATCH 09/10] ppc/pnv: Implement POWER10 PC xscom registers for direct controls

2024-05-29 Thread Nicholas Piggin
On Wed May 29, 2024 at 5:00 PM AEST, Cédric Le Goater wrote: > On 5/26/24 14:26, Nicholas Piggin wrote: > > The PC unit in the processor core contains xscom registers that provide > > low level status and control of the CPU. > > > > This implements "direct controls" sufficient for OPAL (skiboot) f

Re: [RFC PATCH 08/10] ppc/pnv: Invert the design for big-core machine modelling

2024-05-29 Thread Nicholas Piggin
On Wed May 29, 2024 at 4:57 PM AEST, Cédric Le Goater wrote: > On 5/26/24 14:26, Nicholas Piggin wrote: > > POWER9 and POWER10 machines come in two variants, "big-core" and > > "small-core". > > > > Big core machines are SMT8 from the software point of view, but in the > > low level platform topol

[RFC v3 1/2] target/loongarch: Add loongson binary translation feature

2024-05-29 Thread Bibo Mao
Loongson Binary Translation (LBT) is used to accelerate binary translation, which contains 4 scratch registers (scr0 to scr3), x86/ARM eflags (eflags) and x87 fpu stack pointer (ftop). Now LBT feature is added in kvm mode, not supported in TCG mode since it is not emulated. Feature variable lbt is

[RFC v3 0/2] target/loongarch: Add loongson binary translation feature

2024-05-29 Thread Bibo Mao
Loongson Binary Translation (LBT) is used to accelerate binary translation. LBT feature is added in kvm mode, not supported in TCG mode since it is not emulated. Here lbt=on/off property is added to parse command line to enable/disable lbt feature. Also fix registers relative lbt are saved and res

[RFC v3 2/2] target/loongarch: Implement lbt registers save/restore function

2024-05-29 Thread Bibo Mao
Six registers scr0 - scr3, eflags and ftop are added in percpu vmstate. And two functions kvm_loongarch_get_lbt/kvm_loongarch_put_lbt are added to save/restore lbt registers. Signed-off-by: Bibo Mao --- target/loongarch/cpu.h | 12 + target/loongarch/kvm/kvm.c | 52 ++

Re: [PATCH v4 01/11] ppc: Add Power11 DD2.0 processor

2024-05-29 Thread Aditya Gupta
Hello Harsh, On Thu, May 30, 2024 at 10:57:31AM GMT, Harsh Prateek Bora wrote: > Hi Aditya, > > On 5/28/24 12:35, Aditya Gupta wrote: > > Add CPU target code to add support for new Power11 Processor. > > > > Power11 core is same as Power10, hence reuse functions defined for > > Power10. > > > >

Re: [PATCH v4 05/11] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine

2024-05-29 Thread Aditya Gupta
Hello Cedric, Thanks for your reviews. On Tue, May 28, 2024 at 09:40:12AM GMT, Cédric Le Goater wrote: > Hello Aditya > > On 5/28/24 09:05, Aditya Gupta wrote: > > Power11 core is same as Power10, use the existing functionalities to > > introduce a Power11 chip and machine, with Power10 chip as

Re: [PATCH v4 11/11] ppc/pnv: Update skiboot.lid to support Power11

2024-05-29 Thread Aditya Gupta
Hello Cedric, On Tue, May 28, 2024 at 09:15:29AM GMT, Cédric Le Goater wrote: > On 5/28/24 09:05, Aditya Gupta wrote: > > Skiboot/OPAL patches are in discussion upstream [1], with corresponding > > commits in github repository [2]. > > > > Update skiboot.lid, with binary built from 'upstream_powe

Re: [RFC PATCH 05/10] ppc/pnv: Extend chip_pir class method to TIR as well

2024-05-29 Thread Cédric Le Goater
On 5/30/24 08:38, Nicholas Piggin wrote: On Wed May 29, 2024 at 4:30 PM AEST, Cédric Le Goater wrote: On 5/29/24 02:24, Nicholas Piggin wrote: On Tue May 28, 2024 at 6:32 PM AEST, Harsh Prateek Bora wrote: On 5/26/24 17:56, Nicholas Piggin wrote: The chip_pir chip class method allows the pl

Re: [RFC PATCH 05/10] ppc/pnv: Extend chip_pir class method to TIR as well

2024-05-29 Thread Nicholas Piggin
On Wed May 29, 2024 at 4:30 PM AEST, Cédric Le Goater wrote: > On 5/29/24 02:24, Nicholas Piggin wrote: > > On Tue May 28, 2024 at 6:32 PM AEST, Harsh Prateek Bora wrote: > >> > >> > >> On 5/26/24 17:56, Nicholas Piggin wrote: > >>> The chip_pir chip class method allows the platform to set the PIR

Re: [RFC PATCH 07/10] target/ppc: Add helpers to check for SMT sibling threads

2024-05-29 Thread Nicholas Piggin
On Wed May 29, 2024 at 4:34 PM AEST, Cédric Le Goater wrote: > On 5/26/24 14:26, Nicholas Piggin wrote: > > Add helpers for TCG code to determine if there are SMT siblings > > sharing per-core and per-lpar registers. This simplifies the > > callers and makes SMT register topology simpler to modify

Re: [PATCH 2/5] qtest: use cpu interface in qtest_clock_warp

2024-05-29 Thread Paolo Bonzini
On Fri, May 17, 2024 at 12:21 AM Pierrick Bouvier wrote: > > From: Alex Bennée > > This generalises the qtest_clock_warp code to use the AccelOps > handlers for updating its own sense of time. This will make the next > patch which moves the warp code closer to pure code motion. > > From: Alex Ben

Re: [PATCH 1/5] sysemu: add set_virtual_time to accel ops

2024-05-29 Thread Paolo Bonzini
On Fri, May 17, 2024 at 12:21 AM Pierrick Bouvier wrote: > diff --git a/stubs/meson.build b/stubs/meson.build > index 3b9d42023cb..672213b7482 100644 > --- a/stubs/meson.build > +++ b/stubs/meson.build > @@ -3,6 +3,11 @@ > # below, so that it is clear who needs the stubbed functionality. > > stu

Re: [PATCH 3/3] semihosting: Restrict to TCG

2024-05-29 Thread Paolo Bonzini
On Wed, May 29, 2024 at 5:56 PM Philippe Mathieu-Daudé wrote: > It is pointless to build semihosting when TCG is not available. Why? I would have naively assumed that a suitable semihosting API could be implemented by KVM. The justification (and thus the commit message) needs to be different for

Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-29 Thread Michael S. Tsirkin
On Mon, May 27, 2024 at 08:01:26AM +0200, Thomas Huth wrote: > When running the update-linx-headers.sh script, it currently fails with: > > scripts/update-linux-headers.sh: line 73: > .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory > > The "include" folder is obviously

Re: [PATCH 0/3] semihosting: Restrict to TCG

2024-05-29 Thread Paolo Bonzini
On Wed, May 29, 2024 at 9:11 PM Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > It is pointless to build semihosting when TCG is not available. > > > > Philippe Mathieu-Daudé (3): > > target/mips: Restrict semihosting to TCG > > target/riscv: Restrict semihosting to TCG > > semi

Re: [PATCH v4 01/11] ppc: Add Power11 DD2.0 processor

2024-05-29 Thread Harsh Prateek Bora
Hi Aditya, On 5/28/24 12:35, Aditya Gupta wrote: Add CPU target code to add support for new Power11 Processor. Power11 core is same as Power10, hence reuse functions defined for Power10. Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhav

Re: [PATCH V12 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-29 Thread Harsh Prateek Bora
On 5/30/24 05:12, Salil Mehta wrote: KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-29 Thread Cord Amfmgm
On Tue, May 28, 2024 at 11:32 AM Peter Maydell wrote: > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell > wrote: > >> > >> On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: > >> > On Mon, May 20, 2024 at 12:05 PM Peter Maydell < > p

Re: [RESEND PATCH v2 0/5] target/riscv: Support RISC-V privilege 1.13 spec

2024-05-29 Thread Fea Wang
Hi Daniel, thank you for your help. I found that only the cover is without many maintainers. I used to send patches by git send-email --dry-run --to 'qemu-devel@nongnu.org, qemu-ri...@nongnu.org' --cc-cmd='scripts/get_maintainer.pl -i' patches/*. Do you have a better script for me? Thank you. Sin

RE: [PATCH 0/8] tests/unit/test-smp-sparse: Misc Cleanup and Add Module Test

2024-05-29 Thread Ma, Yongwei
On 2024/5/30 10:45, Yongwei Ma wrote: > Hi, > > Since the module support has landed in x86, and it's time to add the > module's -smp test cases to cover the relevant code path. > > This series adds the module tests to ensure that this new level does not > break the current topology information ca

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-29 Thread Jason Wang
On Wed, May 29, 2024 at 8:18 PM Halil Pasic wrote: > > On Tue, 28 May 2024 11:25:51 +0800 > Jason Wang wrote: > > > > 5) Based on the following, I would very much prefer a per device list of > > > features with the semantic "hey QEMU can do that feature without any > > > specialized vhost-device

[PATCH v2] tests/libqos: Add loongarch virt machine node

2024-05-29 Thread Bibo Mao
Add loongarch virt machine to the graph. It is a modified copy of the existing riscv virtmachine in riscv-virt-machine.c It contains a generic-pcihost controller, and an extra function loongarch_config_qpci_bus() to configure GPEX pci host controller information, such as ecam and pio_base addresse

Re: [PATCH v3 03/13] hw/riscv: add RISC-V IOMMU base emulation

2024-05-29 Thread Eric Cheng
On 5/24/2024 1:39 AM, Daniel Henrique Barboza wrote: From: Tomasz Jeznach The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at: https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf

Re: [PATCH] hw/net: prevent potential NULL dereference

2024-05-29 Thread David Gibson
On Wed, May 29, 2024 at 02:07:18PM +0300, Oleg Sviridov wrote: > Pointer, returned from function 'spapr_vio_find_by_reg', may be NULL and is > dereferenced immediately after. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Oleg Sviridov > --- > hw/net/s

[PATCH V12 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-05-29 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta Reviewed-by

[PATCH V12 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-29 Thread Salil Mehta via
Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Note: These are common functions exported to arch specific code. For example, for ARM this code is being referred in associated arch specific patch-set: Link: https://lore.kerne

[PATCH V12 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-29 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel

[PATCH V12 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-05-29 Thread Salil Mehta via
CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS ob

[PATCH V12 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-05-29 Thread Salil Mehta via
OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro CPU_SCAN_METHOD

[PATCH V12 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-29 Thread Salil Mehta via
ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU hot(un)pl

[PATCH V12 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-05-29 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Review

[PATCH V12 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-29 Thread Salil Mehta via
KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V12 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-05-29 Thread Salil Mehta via
Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change [Pat

Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-29 Thread Michael Roth
On Mon, May 27, 2024 at 08:01:26AM +0200, Thomas Huth wrote: > When running the update-linx-headers.sh script, it currently fails with: > > scripts/update-linux-headers.sh: line 73: > .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory > > The "include" folder is obviously

[PATCH] ui/gtk: Wait until the current guest frame is rendered before switching to RUN_STATE_SAVE_VM

2024-05-29 Thread dongwon . kim
From: Dongwon Make sure rendering of the current frame is finished before switching the run state to RUN_STATE_SAVE_VM by waiting for egl-sync object to be signaled. Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- ui/egl-helpers.c | 2 -- ui/gtk.c | 19 +

[PATCH v2] pci-bridge/xio3130_downstream: fix invalid link speed and link width

2024-05-29 Thread Nam Cao
Set link width to x1 and link speed to 2.5 Gb/s as specified by the datasheet. Without this, these fields in the link status register read zero, which is incorrect. This problem appeared since 3d67447fe7c2 ("pcie: Fill PCIESlot link fields to support higher speeds and widths"), which allows PCIe s

Re: [PATCH v2 3/6] hppa: Add support for an emulated TOC/NMI button.

2024-05-29 Thread Helge Deller
On 5/29/24 17:11, Philippe Mathieu-Daudé wrote: Hi Helge & Richard, Hi Philippe, Nevermind the missed review comments, I'm revisiting this patch while looking at building libtcg-hppa.so. Ok. On 1/2/22 00:56, Philippe Mathieu-Daudé wrote: On 31/1/22 22:35, Helge Deller wrote: Almost all

Re: [PATCH V1 19/26] physmem: preserve ram blocks for cpr

2024-05-29 Thread Peter Xu
On Wed, May 29, 2024 at 01:31:53PM -0400, Steven Sistare wrote: > On 5/28/2024 5:44 PM, Peter Xu wrote: > > On Mon, Apr 29, 2024 at 08:55:28AM -0700, Steve Sistare wrote: > > > Preserve fields of RAMBlocks that allocate their host memory during CPR so > > > the RAM allocation can be recovered. > >

Re: [PATCH V1 17/26] machine: memfd-alloc option

2024-05-29 Thread Peter Xu
On Wed, May 29, 2024 at 01:31:38PM -0400, Steven Sistare wrote: > > > diff --git a/system/memory.c b/system/memory.c > > > index 49f1cb2..ca04a0e 100644 > > > --- a/system/memory.c > > > +++ b/system/memory.c > > > @@ -1552,8 +1552,9 @@ bool memory_region_init_ram_nomigrate(MemoryRegion > > > *mr,

Re: [PATCH 0/3] semihosting: Restrict to TCG

2024-05-29 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > It is pointless to build semihosting when TCG is not available. > > Philippe Mathieu-Daudé (3): > target/mips: Restrict semihosting to TCG > target/riscv: Restrict semihosting to TCG > semihosting: Restrict to TCG Queued to semihosting/next, thanks. -- Al

Re: [PATCH 1/5] sysemu: add set_virtual_time to accel ops

2024-05-29 Thread Pierrick Bouvier
On 5/29/24 05:29, Philippe Mathieu-Daudé wrote: On 17/5/24 00:20, Pierrick Bouvier wrote: From: Alex Bennée We are about to remove direct calls to individual accelerators for this information and will need a central point for plugins to hook into time changes. From: Alex Bennée Signed-off-by

Re: [PULL 00/22] s390x, build-oss-fuzz and Clang -fsanitize=undefined fixes

2024-05-29 Thread Richard Henderson
On 5/29/24 03:54, Thomas Huth wrote: Hi Richard! The following changes since commit 79d7475f39f1b0f05fcb159f5cdcbf162340dc7e: Merge tag 'pull-block-jobs-2024-04-29-v2' ofhttps://gitlab.com/vsementsov/qemu into staging (2024-05-28 11:28:34 -0700) are available in the Git repository at:

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-29 Thread Peter Xu
On Wed, May 29, 2024 at 01:30:18PM -0400, Steven Sistare wrote: > How about a more general name for the type: > > migration/misc.h > typedef char (MigrationId)[256]; How about qemu/typedefs.h? Not sure whether it's applicable. Markus (in the loop) may have a better idea. Meanwhile, s/Migrat

Re: [RFC 0/6] scripts: Rewrite simpletrace printer in Rust

2024-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2024 at 10:10:00PM +0800, Zhao Liu wrote: > Hi Stefan and Mads, > > On Wed, May 29, 2024 at 11:33:42AM +0200, Mads Ynddal wrote: > > Date: Wed, 29 May 2024 11:33:42 +0200 > > From: Mads Ynddal > > Subject: Re: [RFC 0/6] scripts: Rewrite simpletrace printer in Rust > > X-Mailer: Ap

Re: [RFC 1/6] scripts/simpletrace-rust: Add the basic cargo framework

2024-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2024 at 10:30:13PM +0800, Zhao Liu wrote: > Hi Stefan, > > On Tue, May 28, 2024 at 10:14:01AM -0400, Stefan Hajnoczi wrote: > > Date: Tue, 28 May 2024 10:14:01 -0400 > > From: Stefan Hajnoczi > > Subject: Re: [RFC 1/6] scripts/simpletrace-rust: Add the basic cargo > > framework >

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-29 Thread Peter Xu
On Tue, May 28, 2024 at 11:09:49AM -0400, Steven Sistare wrote: > On 5/27/2024 2:16 PM, Peter Xu wrote: > > On Mon, Apr 29, 2024 at 08:55:14AM -0700, Steve Sistare wrote: > > > Provide the VMStateDescription precreate field to mark objects that must > > > be loaded on the incoming side before devic

Re: [PATCH] Use "void *" as parameter for functions that are used for aio_set_event_notifier()

2024-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2024 at 07:49:48PM +0200, Thomas Huth wrote: > aio_set_event_notifier() and aio_set_event_notifier_poll() in > util/aio-posix.c and util/aio-win32.c are casting function pointers of > functions that take an "EventNotifier *" pointer as parameter to function > pointers that take a "v

Re: [PATCH v2 2/4] MAINTAINERS: drop usb maintainership

2024-05-29 Thread Philippe Mathieu-Daudé
On 28/5/24 10:38, Gerd Hoffmann wrote: Remove myself from usb entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann Reviewed-by: Manos Pitsidianakis --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Thanks Gerd for

Re: [PATCH 07/10] tests/lcitool: bump to latest version

2024-05-29 Thread Alex Bennée
Thomas Huth writes: > On 29/05/2024 18.09, Alex Bennée wrote: >> We have to simultaneously update a few bits on our side as lcitool has >> already deprecated fedora-38, alpine-3.18 and centos-8-stream. However >> there is no change to the package list yet. >> Signed-off-by: Alex Bennée > > Have

Re: [PATCH 0/2] block/crypto: do not require number of threads upfront

2024-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2024 at 06:50:34PM +0200, Kevin Wolf wrote: > Am 27.05.2024 um 17:58 hat Stefan Hajnoczi geschrieben: > > The block layer does not know how many threads will perform I/O. It is > > possible > > to exceed the number of threads that is given to qcrypto_block_open() and > > this > >

[PATCH] Use "void *" as parameter for functions that are used for aio_set_event_notifier()

2024-05-29 Thread Thomas Huth
aio_set_event_notifier() and aio_set_event_notifier_poll() in util/aio-posix.c and util/aio-win32.c are casting function pointers of functions that take an "EventNotifier *" pointer as parameter to function pointers that take a "void *" pointer as parameter (i.e. the IOHandler type). When those fun

Re: [PATCH] accel: Restrict probe_access*() functions to TCG

2024-05-29 Thread Richard Henderson
On 5/29/24 08:59, Philippe Mathieu-Daudé wrote: This API is specific to TCG (already handled by hardware accelerators), so restrict it with #ifdef'ry. Remove unnecessary stubs. Signed-off-by: Philippe Mathieu-Daudé --- Based-on:<20240529155548.5878-1-phi...@linaro.org> --- include/exec/exec-al

Re: [PATCH 0/3] semihosting: Restrict to TCG

2024-05-29 Thread Richard Henderson
On 5/29/24 08:55, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (3): target/mips: Restrict semihosting to TCG target/riscv: Restrict semihosting to TCG semihosting: Restrict to TCG Reviewed-by: Richard Henderson r~

Re: [PATCH v2 03/67] target/arm: Reject incorrect operands to PLD, PLDW, PLI

2024-05-29 Thread Richard Henderson
On 5/29/24 06:32, Peter Maydell wrote: We do plenty of other treatments of UNPREDICTABLE as UNDEF (e.g. STREX). Why is this case any different? It just seems like a lot of effort to go to. Sometimes we UNDEF for UNPREDICTABLEs, but quite often we say "the behaviour we get for free is fine, so

[PATCH RISU] risugen/arm: Refine prefetch and memory hintspace patterns

2024-05-29 Thread Richard Henderson
Avoid prefetch patterns that are UNPREDICTABLE. Signed-off-by: Richard Henderson --- thumb.risu | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/thumb.risu b/thumb.risu index 357b791..6a05bf2 100644 --- a/thumb.risu +++ b/thumb.risu @@ -33,7 +33,20 @@ SMMUL T1

Re: [PATCH] tests/qtest/migrate-test: Add a postcopy memfile test

2024-05-29 Thread Fabiano Rosas
Peter Xu writes: > On Wed, May 29, 2024 at 09:54:30AM -0300, Fabiano Rosas wrote: >> Nicholas Piggin writes: >> >> > Postcopy requires userfaultfd support, which requires tmpfs if a memory >> > file is used. >> > >> > This adds back support for /dev/shm memory files, but adds preallocation >> >

Re: [PATCH V1 17/26] machine: memfd-alloc option

2024-05-29 Thread Steven Sistare via
On 5/28/2024 5:12 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:26AM -0700, Steve Sistare wrote: Allocate anonymous memory using memfd_create if the memfd-alloc machine option is set. Signed-off-by: Steve Sistare --- hw/core/machine.c | 22 ++ include/hw/boards.h |

Re: [PATCH V1 19/26] physmem: preserve ram blocks for cpr

2024-05-29 Thread Steven Sistare via
On 5/28/2024 5:44 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:28AM -0700, Steve Sistare wrote: Preserve fields of RAMBlocks that allocate their host memory during CPR so the RAM allocation can be recovered. This sentence itself did not explain much, IMHO. QEMU can share memory using fd

Re: [PATCH V2 0/3] improve -overcommit cpu-pm=on|off

2024-05-29 Thread Chen, Zide
On 5/29/2024 5:46 AM, Igor Mammedov wrote: > On Tue, 28 May 2024 11:16:59 -0700 > "Chen, Zide" wrote: > >> On 5/28/2024 2:23 AM, Igor Mammedov wrote: >>> On Fri, 24 May 2024 13:00:14 -0700 >>> Zide Chen wrote: >>> Currently, if running "-overcommit cpu-pm=on" on hosts that don't

Re: [PATCH V1 08/26] migration: vmstate_info_void_ptr

2024-05-29 Thread Steven Sistare via
On 5/28/2024 2:21 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:10:16AM -0400, Steven Sistare wrote: On 5/27/2024 2:31 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:17AM -0700, Steve Sistare wrote: Define VMSTATE_VOID_PTR so the value of a pointer (but not its target) can be saved in the

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-29 Thread Steven Sistare via
On 5/28/2024 1:44 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:10:03AM -0400, Steven Sistare via wrote: On 5/27/2024 2:20 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: Define a type for the 256 byte id string to guarantee the same length is used and enfor

Re: [PATCH] qemu/bitops.h: Locate changed bits

2024-05-29 Thread Ho, Tong
Point taken, and I am withdrawing this patch. I will post a new implementation following the arbitrary-length array pattern in a later date, and only as part of a series including the consuming code. Thanks, Tong Ho From: Peter Maydell Sent: Wednesday, May 29, 2

Re: [PATCH 02/10] docs/devel: update references to centos to non-versioned container

2024-05-29 Thread Thomas Huth
On 29/05/2024 18.09, Alex Bennée wrote: From the website: "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." We have updated a few bits but there are still references that need fixing. Rather than bump I've replaced them with references to the Debia

Re: [PATCH 07/10] tests/lcitool: bump to latest version

2024-05-29 Thread Thomas Huth
On 29/05/2024 18.09, Alex Bennée wrote: We have to simultaneously update a few bits on our side as lcitool has already deprecated fedora-38, alpine-3.18 and centos-8-stream. However there is no change to the package list yet. Signed-off-by: Alex Bennée Have you tried a CI run with these chang

Re: [PATCH 0/2] block/crypto: do not require number of threads upfront

2024-05-29 Thread Kevin Wolf
Am 27.05.2024 um 17:58 hat Stefan Hajnoczi geschrieben: > The block layer does not know how many threads will perform I/O. It is > possible > to exceed the number of threads that is given to qcrypto_block_open() and this > can trigger an assertion failure in qcrypto_block_pop_cipher(). > > This p

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Peter Xu
Lei, On Wed, May 29, 2024 at 02:43:46AM +, Gonglei (Arei) wrote: > For rdma programming, the current mainstream implementation is to use > rdma_cm to establish a connection, and then use verbs to transmit data. > rdma_cm and ibverbs create two FDs respectively. The two FDs have > different res

[PATCH 05/26] vfio: add vfio_prepare_device()

2024-05-29 Thread John Levon
From: John Levon Commonize some initialization code shared by the legacy and iommufd vfio implementations (and later by vfio-user). Signed-off-by: John Levon --- hw/vfio/common.c | 19 +++ hw/vfio/container.c | 14 +- hw/vfio/iommufd.c

[PATCH 20/26] vfio-user: proxy container connect/disconnect

2024-05-29 Thread John Levon
From: Jagannathan Raman Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/container.c | 4 ++- hw/vfio/user-container.c | 52 --- hw/vfio/user-protocol.h | 2

[PATCH 06/26] vfio: add region cache

2024-05-29 Thread John Levon
From: Jagannathan Raman cache VFIO_DEVICE_GET_REGION_INFO results to reduce memory alloc/free cycles and as prep work for vfio-user Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/ccw.c | 5 --

[PATCH 21/26] vfio-user: dma map/unmap operations

2024-05-29 Thread John Levon
Implement DMA map/unmap for the vfio-user container. Add ability to do async operations during memory transactions. Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John Levon --- hw/vfio/trace-events | 4 ++ hw/vfio/user-contai

[PATCH 16/26] vfio-user: region read/write

2024-05-29 Thread John Levon
From: Jagannathan Raman Add support for posted writes on remote devices Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/helpers.c | 20 -- hw/vfio/pci.c | 5 +- hw/vfio/trace

[PATCH 22/26] vfio-user: no-mmap DMA support

2024-05-29 Thread John Levon
From: Jagannathan Raman Force remote process to use DMA r/w messages instead of directly mapping guest memory. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/user-container.c | 2 +- hw/vfio/user-pci.c

[PATCH 02/26] vfio/container: pass listener_begin/commit callbacks

2024-05-29 Thread John Levon
The vfio-user container will later need to hook into these callbacks; set up vfio to use them, and optionally pass them through to the container. Signed-off-by: John Levon --- hw/vfio/common.c | 22 ++ include/hw/vfio/vfio-container-base.h | 2 ++ 2 file

[PATCH 01/26] vfio/container: pass MemoryRegion to DMA operations

2024-05-29 Thread John Levon
From: Jagannathan Raman Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later. Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John Levon --- hw/vfio/common.c

[PATCH 23/26] vfio-user: dma read/write operations

2024-05-29 Thread John Levon
From: Jagannathan Raman Messages from server to client that perform device DMA. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/user-pci.c | 110 hw/vfio/user-prot

[PATCH 19/26] vfio-user: forward msix BAR accesses to server

2024-05-29 Thread John Levon
From: Jagannathan Raman Server holds device current device pending state Use irq masking commands in socket case Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/helpers.c | 26 +++ hw/vfio/

[PATCH 24/26] vfio-user: pci reset

2024-05-29 Thread John Levon
From: Jagannathan Raman Message to tell the server to reset the device. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/user-pci.c | 15 +++ hw/vfio/user.c | 12 hw/vfio/user.h

[PATCH 09/26] vfio-user: introduce vfio-user protocol specification

2024-05-29 Thread John Levon
From: Thanos Makatos This patch introduces the vfio-user protocol specification (formerly known as VFIO-over-socket), which is designed to allow devices to be emulated outside QEMU, in a separate process. vfio-user reuses the existing VFIO defines, structs and concepts. It has been earlier discu

[PATCH 17/26] vfio-user: pci_user_realize PCI setup

2024-05-29 Thread John Levon
From: Jagannathan Raman PCI BARs read from remote device PCI config reads/writes sent to remote server Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/pci.c | 249 ++---

[PATCH 18/26] vfio-user: get and set IRQs

2024-05-29 Thread John Levon
From: Jagannathan Raman Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/pci.c | 3 +- hw/vfio/trace-events| 2 + hw/vfio/user-protocol.h | 25 +++ hw/vfio/user.c | 140 ++

[PATCH 26/26] vfio-user: add coalesced posted writes

2024-05-29 Thread John Levon
From: Jagannathan Raman Add new message to send multiple writes to server. Prevents the outgoing queue from overflowing when a long latency operation is followed by a series of posted writes. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-of

[PATCH 08/26] vfio: add device IO ops vector

2024-05-29 Thread John Levon
From: Jagannathan Raman Used for communication with VFIO driver (prep work for vfio-user, which will communicate over a socket) Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/ap.c | 2 +- h

[PATCH 10/26] vfio-user: add vfio-user class and container

2024-05-29 Thread John Levon
From: Jagannathan Raman Add a new class for vfio-user with its class and instance constructors and destructors, and its pci ops. Introduce VFIOUserContainer for handling container operations for such classes. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannatha

[PATCH 14/26] vfio-user: get device info

2024-05-29 Thread John Levon
From: Jagannathan Raman Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/trace-events | 1 + hw/vfio/user-container.c | 10 +- hw/vfio/user-protocol.h | 12 hw/vfio/user.c |

[PATCH 07/26] vfio: add VFIO base abstract class

2024-05-29 Thread John Levon
From: Jagannathan Raman Add an abstract base class both the kernel driver and user socket implementations can use to share code. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/pci.c | 108

[PATCH 25/26] vfio-user: add 'x-msg-timeout' option that specifies msg wait times

2024-05-29 Thread John Levon
From: Jagannathan Raman Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/user-pci.c | 4 hw/vfio/user.c | 7 --- hw/vfio/user.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --gi

[PATCH 15/26] vfio-user: get region info

2024-05-29 Thread John Levon
From: Jagannathan Raman Add per-region FD to support mmap() of remote device regions Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/ap.c | 2 ++ hw/vfio/ccw.c | 2 ++ hw/vfi

[PATCH 12/26] vfio-user: define socket receive functions

2024-05-29 Thread John Levon
From: Jagannathan Raman Add infrastructure needed to receive incoming messages Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/trace-events| 5 + hw/vfio/user-pci.c | 11 ++ hw/vfio/user-protocol.h

[PATCH 11/26] vfio-user: connect vfio proxy to remote server

2024-05-29 Thread John Levon
From: Jagannathan Raman add user.c & user.h files for vfio-user code add proxy struct to handle comms with remote server Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/meson.build | 2 +- hw/vfio/

[PATCH 03/26] vfio/container: support VFIO_DMA_UNMAP_FLAG_ALL

2024-05-29 Thread John Levon
From: John Levon Some containers can directly implement unmapping all regions; add a new flag to support this. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John Levon --- hw/vfio/common.c | 24 +++

[PATCH 13/26] vfio-user: define socket send functions

2024-05-29 Thread John Levon
From: Jagannathan Raman Also negotiate protocol version with remote server Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John Levon --- hw/vfio/trace-events| 2 + hw/vfio/user-pci.c | 18 +- hw/vfio/user-protocol.h |

[PATCH 04/26] vfio: add vfio_attach_device_by_iommu_type()

2024-05-29 Thread John Levon
From: John Levon Allow attachment by explicitly passing a TYPE_VFIO_IOMMU_* string; vfio-user will use this later. Signed-off-by: John Levon --- hw/vfio/common.c | 25 ++--- include/hw/vfio/vfio-common.h | 3 +++ 2 files changed, 21 insertions(+), 7 deletions(

[RFC v6 00/26] vfio-user client

2024-05-29 Thread John Levon
Hello, This is the 6th revision of the vfio-user client implementation. First of all, thank you for your time reviewing the previous versions. The vfio-user framework consists of 3 parts: 1) The VFIO user protocol specification. 2) A client - the VFIO device in QEMU that encapsulates VFIO mess

Re: [PATCH] target/mips: Remove unused 'hw/misc/mips_itu.h' header

2024-05-29 Thread Jiaxun Yang
在2024年5月29日五月 下午4:52,Philippe Mathieu-Daudé写道: > Since commit e1152f8166 ("target/mips: Remove helpers accessing > SAAR registers") this header is not needed. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang > --- > target/mips/tcg/sysemu/cp0_helper.c | 1 - > 1 file chang

Re: [RFC PATCH] cpus: split qemu_init_vcpu and delay vCPU thread creation

2024-05-29 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 29/5/24 17:22, Alex Bennée wrote: >> This ensures we don't start the thread until cpu_common_realizefn has >> finished. This ensures that plugins will always run >> qemu_plugin_vcpu_init__async first before any other states. It doesn't >> totally e

[PATCH 00/10] testing/next: purging centos and more lcitool

2024-05-29 Thread Alex Bennée
There are a few more bits referencing centos8 in the tree which needed cleaning up. After this we can remove the dedicated runner from the gitlab registration. If we want to keep a dedicated Centos runner then we can add back the bits needed to set it up. I plan to generate the PR on Friday. Chan

[PATCH 03/10] tests/vm: update centos.aarch64 image to 9

2024-05-29 Thread Alex Bennée
As Centos Stream 8 goes out of support we need to update. To do this powertools is replaced by crb and we don't over specify the python3 we want. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20240521125314.1255403-4-alex.ben...@linaro.org> ---

[PATCH 01/10] ci: remove centos-steam-8 customer runner

2024-05-29 Thread Alex Bennée
This broke since eef0bae3a7 (migration: Remove block migration) but even after that was addressed it still fails to complete. As it will shortly be EOL lets to remove the runner definition and the related ansible setup bits. We still have centos9 docker images build and test. Reviewed-by: Richard

  1   2   3   >