[Stable-7.2.10 48/54] gitlab: force allow use of pip in Cirrus jobs

2024-03-02 Thread Michael Tokarev
From: Daniel P. Berrangé Python is transitioning to a world where you're not allowed to use 'pip install' outside of a virutal env by default. The rationale is to stop use of pip clashing with distro provided python packages, which creates a major headache on distro upgrades. All our CI environm

[Stable-7.2.10 v3 00/54] Patch Round-up for stable 7.2.10, freeze on 2024-03-02 (frozen)

2024-03-02 Thread Michael Tokarev
The following patches are queued for QEMU stable v7.2.10: https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: https://wiki.qemu.org/Planning/7.2 The changes which are staging for inclusion, with the original commi

[Stable-7.2.10 51/54] test-vmstate: fix bad GTree usage, use-after-free

2024-03-02 Thread Michael Tokarev
From: Eric Auger According to g_tree_foreach() documentation: "The tree may not be modified while iterating over it (you can't add/remove items)." compare_trees()/diff_tree() fail to respect this rule. Historically GLib2 used a slice allocator for the GTree APIs which did not immediately release

[Stable-7.2.10 49/54] hw/usb/bus.c: PCAP adding 0xA in Windows version

2024-03-02 Thread Michael Tokarev
From: Benjamin David Lunt Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show an example, when using

[Stable-7.2.10 52/54] tests/qtest/display-vga-test: Add proper checks if a device is available

2024-03-02 Thread Michael Tokarev
From: Thomas Huth display-vga-test currently tries to guess the usable VGA devices according to the target architecture that is used for the test. This of course does not work if QEMU has been built with the "--without-default-devices" configure switch. To fix this, use the qtest_has_device() fun

[Stable-7.2.10 54/54] target/i386: the sgx_epc_get_section stub is reachable

2024-03-02 Thread Michael Tokarev
From: Paolo Bonzini The sgx_epc_get_section stub is reachable from cpu_x86_cpuid. It should not assert, instead it should just return true just like the "real" sgx_epc_get_section does when SGX is disabled. Reported-by: Vladimír Beneš Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Me

[Stable-7.2.10 50/54] tests/unit/test-util-sockets: Remove temporary file after test

2024-03-02 Thread Michael Tokarev
From: Thomas Huth test-util-sockets leaves the temporary socket files around in the temporary files folder. Let's better remove them at the end of the testing. Fixes: 4d3a329af5 ("tests/util-sockets: add abstract unix socket cases") Message-ID: <20240226082728.249753-1-th...@redhat.com> Reviewed

[Stable-7.2.10 53/54] tests/unit/test-blockjob: Disable complete_in_standby test

2024-03-02 Thread Michael Tokarev
From: Peter Maydell The blockjob/complete_in_standby test is flaky and fails intermittently in CI: 172/621 qemu:unit / test-blockjob ERROR 0.26s killed by signal 6 SIGABRT 11:03:46 MALLOC_PERTURB_=176 G_TEST_SRCDIR=/Users/pm215/src/qemu-for-merges/tests/unit G_TEST_BUILDDI

Re: [PATCH 3/3] target/hppa: Fix assemble_12a insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson Tested-by: Helge Deller --- target/hppa/insns.decode | 27 --- target/hppa/translate.c | 17 + 2 files changed, 33 insertions(+), 11 deletions(

Re: [PATCH 2/3] target/hppa: Fix assemble_11a insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 07:52, Helge Deller wrote: On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson ---   target/hppa/insns.decode |  7 ---   target/hppa/translate.c  | 23 +--   2 files changed, 21 insertions(+), 9 deletions(-) di

Re: [PATCH 2/3] target/hppa: Fix assemble_11a insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 7 --- target/hppa/translate.c | 23 +-- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/target/hppa/insns.decode b/

Re: [PATCH 1/3] target/hppa: Fix assemble_16 insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 15 +-- target/hppa/translate.c | 21 + 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/target/hppa/insns.dec

[PULL 2/5] target/hppa: Restore unwind_breg before calculating ior

2024-03-02 Thread deller
From: Helge Deller When calculating the IOR for the exception handlers, the current unwind_breg value is needed on 64-bit hppa machines. Restore that value by calling cpu_restore_state() earlier, which in turn calls hppa_restore_state_to_opc() which restores the unwind_breg for the current instru

[PULL 3/5] pc-bios/meson: Add hppa-firmware64.img blob

2024-03-02 Thread deller
From: Helge Deller Add the missing 64-bit hppa firmware blob so that it gets installed. Signed-off-by: Helge Deller Fixes: 7c0dfcf9395e ("target/hppa: Update SeaBIOS-hppa to version 16") Reviewed-by: Richard Henderson --- pc-bios/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a

[PULL 0/5] Hppa latest patches

2024-03-02 Thread deller
From: Helge Deller The following changes since commit e1007b6bab5cf97705bf4f2aaec1f607787355b8: Merge tag 'pull-request-2024-03-01' of https://gitlab.com/thuth/qemu into staging (2024-03-01 10:14:32 +) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git ta

[PULL 4/5] pc-bios/README: Add information about hppa-firmware

2024-03-02 Thread deller
From: Helge Deller Signed-off-by: Helge Deller Reviewed-by: Richard Henderson --- pc-bios/README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pc-bios/README b/pc-bios/README index b8a0210d24..7ffb2f43a4 100644 --- a/pc-bios/README +++ b/pc-bios/README @@ -75,3 +75,9 @@ initiali

[PULL 5/5] roms/hppa: Add build rules for hppa-firmware

2024-03-02 Thread deller
From: Helge Deller Signed-off-by: Helge Deller Suggested-by: Michael Tokarev Reviewed-by: Richard Henderson --- roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 67f709ba2d..8e5d8d26a9 100644 --- a/roms/Makefile +++ b/roms/Makefile @@

[PULL 1/5] target: hppa: Fix unaligned double word accesses for hppa64

2024-03-02 Thread deller
From: Guenter Roeck Unaligned 64-bit accesses were found in Linux to clobber carry bits, resulting in bad results if an arithmetic operation involving a carry bit was executed after an unaligned 64-bit operation. hppa 2.0 defines additional carry bits in PSW register bits 32..39. When restoring

Re: [PATCH 1/5] target/hppa: Fix unaligned double word accesses for hppa64

2024-03-02 Thread Helge Deller
On 3/3/24 03:10, Richard Henderson wrote: On 3/2/24 12:35, del...@kernel.org wrote: From: Guenter Roeck Unaligned 64-bit accesses were found in Linux to clobber carry bits, resulting in bad results if an arithmetic operation involving a carry bit was executed after an unaligned 64-bit operatio

Re: [PATCH 5/5] roms/hppa: Add build rules for hppa-firmware

2024-03-02 Thread Richard Henderson
On 3/2/24 12:35, del...@kernel.org wrote: From: Helge Deller Signed-off-by: Helge Deller Suggested-by: Michael Tokarev --- roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 4/5] pc-bios/README: Add information about hppa-firmware

2024-03-02 Thread Richard Henderson
On 3/2/24 12:35, del...@kernel.org wrote: From: Helge Deller Signed-off-by: Helge Deller --- pc-bios/README | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 3/5] pc-bios/meson: Add hppa-firmware64.img blob

2024-03-02 Thread Richard Henderson
On 3/2/24 12:35, del...@kernel.org wrote: From: Helge Deller Add the missing 64-bit hppa firmware blob so that it gets installed. Signed-off-by: Helge Deller Fixes: 7c0dfcf9395e ("target/hppa: Update SeaBIOS-hppa to version 16") --- pc-bios/meson.build | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH 2/5] target/hppa: Restore unwind_breg before calculating ior

2024-03-02 Thread Richard Henderson
On 3/2/24 12:35, del...@kernel.org wrote: From: Helge Deller When calculating the IOR for the exception handlers, the current unwind_breg value is needed on 64-bit hppa machines. Restore that value by calling cpu_restore_state() earlier, which in turn calls hppa_restore_state_to_opc() which rest

[PATCH 2/3] target/hppa: Fix assemble_11a insns for wide mode

2024-03-02 Thread Richard Henderson
Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 7 --- target/hppa/translate.c | 23 +-- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 0d9f8159ec..9c6f

[PATCH 0/3] target/hppa: Fix some wide mode displacements

2024-03-02 Thread Richard Henderson
As reported by Sven Schnelle, fixed via decodetree functions. r~ Richard Henderson (3): target/hppa: Fix assemble_16 insns for wide mode target/hppa: Fix assemble_11a insns for wide mode target/hppa: Fix assemble_12a insns for wide mode target/hppa/insns.decode | 49 +++---

[PATCH 3/3] target/hppa: Fix assemble_12a insns for wide mode

2024-03-02 Thread Richard Henderson
Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 27 --- target/hppa/translate.c | 17 + 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 9

[PATCH 1/3] target/hppa: Fix assemble_16 insns for wide mode

2024-03-02 Thread Richard Henderson
Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 15 +-- target/hppa/translate.c | 21 + 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index f5a3f02fd1

Re: [PATCH 1/5] target/hppa: Fix unaligned double word accesses for hppa64

2024-03-02 Thread Richard Henderson
On 3/2/24 12:35, del...@kernel.org wrote: From: Guenter Roeck Unaligned 64-bit accesses were found in Linux to clobber carry bits, resulting in bad results if an arithmetic operation involving a carry bit was executed after an unaligned 64-bit operation. hppa 2.0 defines additional carry bits

Re: [PATCH RFC] hppa: assemble_16() in wide mode

2024-03-02 Thread Richard Henderson
On 3/2/24 07:21, Sven Schnelle wrote: Hi Richard, while looking into a HPPA tcg issue i noticed that the current tcg code doesn't do the special wide mode handling described in the Parisc 2.0 specification, Chapter E -> assemble_16(). In wide mode, assemble_16() adds two more bits to the immedia

Re: lsi53c895a assert with AmigaOS

2024-03-02 Thread BALATON Zoltan
On Sun, 3 Mar 2024, Sven Schnelle wrote: BALATON Zoltan writes: AmigaOS4 also has a driver for this card so I've tried to test it but it trips an assert. Does anybody have an idea why and how it could be fixed? Sven's recent patches don't seem to have an effect on this, it still happens shortl

Re: lsi53c895a assert with AmigaOS

2024-03-02 Thread Sven Schnelle
BALATON Zoltan writes: > AmigaOS4 also has a driver for this card so I've tried to test it but > it trips an assert. Does anybody have an idea why and how it could be > fixed? Sven's recent patches don't seem to have an effect on this, it > still happens shortly after it tries to access the SCSI

lsi53c895a assert with AmigaOS

2024-03-02 Thread BALATON Zoltan
Hello, AmigaOS4 also has a driver for this card so I've tried to test it but it trips an assert. Does anybody have an idea why and how it could be fixed? Sven's recent patches don't seem to have an effect on this, it still happens shortly after it tries to access the SCSI device with those pa

Re: [PATCH] hw/scsi/lsi53c895a: stop script on phase mismatch

2024-03-02 Thread Helge Deller
On 3/2/24 22:44, Sven Schnelle wrote: Netbsd isn't happy with qemu lsi53c895a emulation: cd0(esiop0:0:2:0): command with tag id 0 reset esiop0: autoconfiguration error: phase mismatch without command esiop0: autoconfiguration error: unhandled scsi interrupt, sist=0x80 sstat1=0x0 DSA=0x23a64b1 D

[PATCH] hw/scsi/lsi53c895a: Fix typo in comment

2024-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index d607a5f9fb..4f784be749 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -225,7 +225,7 @@ struct LSIState {

[PATCH 0/5] HPPA64 updates

2024-03-02 Thread deller
From: Helge Deller Some fixes for the hppa64 target. Add references to SeaBIOS-hppa and hppa-firmware into pc-bios/README file and add rom make targets. Patches 2-5 need review. Guenter Roeck (1): target/hppa: Fix unaligned double word accesses for hppa64 Helge Deller (4): target/hppa: Rest

[PATCH 5/5] roms/hppa: Add build rules for hppa-firmware

2024-03-02 Thread deller
From: Helge Deller Signed-off-by: Helge Deller Suggested-by: Michael Tokarev --- roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 67f709ba2d..8e5d8d26a9 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -68,6 +68,7 @@ default help:

[PATCH 4/5] pc-bios/README: Add information about hppa-firmware

2024-03-02 Thread deller
From: Helge Deller Signed-off-by: Helge Deller --- pc-bios/README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pc-bios/README b/pc-bios/README index b8a0210d24..6ffc46006e 100644 --- a/pc-bios/README +++ b/pc-bios/README @@ -75,3 +75,9 @@ initialize and run boot images stored in

[PATCH 3/5] pc-bios/meson: Add hppa-firmware64.img blob

2024-03-02 Thread deller
From: Helge Deller Add the missing 64-bit hppa firmware blob so that it gets installed. Signed-off-by: Helge Deller Fixes: 7c0dfcf9395e ("target/hppa: Update SeaBIOS-hppa to version 16") --- pc-bios/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/pc-bios/meson.build b/pc-bios/m

[PATCH 1/5] target/hppa: Fix unaligned double word accesses for hppa64

2024-03-02 Thread deller
From: Guenter Roeck Unaligned 64-bit accesses were found in Linux to clobber carry bits, resulting in bad results if an arithmetic operation involving a carry bit was executed after an unaligned 64-bit operation. hppa 2.0 defines additional carry bits in PSW register bits 32..39. When restoring

[PATCH 2/5] target/hppa: Restore unwind_breg before calculating ior

2024-03-02 Thread deller
From: Helge Deller When calculating the IOR for the exception handlers, the current unwind_breg value is needed on 64-bit hppa machines. Restore that value by calling cpu_restore_state() earlier, which in turn calls hppa_restore_state_to_opc() which restores the unwind_breg for the current instru

[PATCH] hw/scsi/lsi53c895a: stop script on phase mismatch

2024-03-02 Thread Sven Schnelle
Netbsd isn't happy with qemu lsi53c895a emulation: cd0(esiop0:0:2:0): command with tag id 0 reset esiop0: autoconfiguration error: phase mismatch without command esiop0: autoconfiguration error: unhandled scsi interrupt, sist=0x80 sstat1=0x0 DSA=0x23a64b1 DSP=0x50 This is because lsi_bad_phase()

[PATCH] target/hppa: add assemble_16()

2024-03-02 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- target/hppa/insns.decode | 99 target/hppa/translate.c | 22 + 2 files changed, 72 insertions(+), 49 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index f5a3f02fd1..8f17e18cd0 10064

[PATCH RFC] hppa: assemble_16() in wide mode

2024-03-02 Thread Sven Schnelle
Hi Richard, while looking into a HPPA tcg issue i noticed that the current tcg code doesn't do the special wide mode handling described in the Parisc 2.0 specification, Chapter E -> assemble_16(). In wide mode, assemble_16() adds two more bits to the immediate value/displacement of certain instruc

Re: [RFC 6/8] virtio-ccw: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-02 Thread Thomas Huth
On 01/03/2024 14.43, Jonah Palmer wrote: Prevent ioeventfd from being enabled/disabled when a virtio-ccw device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to the ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left

Re: [RFC 5/8] virtio-ccw: Handle extra notification data

2024-03-02 Thread Thomas Huth
On 01/03/2024 14.43, Jonah Palmer wrote: Add support to virtio-ccw devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-ccw device when this feature is enabled

Re: rutabaga 0.1.3

2024-03-02 Thread Alyssa Ross
Hi Gurchetan, > >> > Would this be a suitable commit for the 0.1.3 release of rutabaga? > >> > > >> > https://chromium.googlesource.com/crosvm/crosvm/+/5dfd74a0680d317c6edf44138def886f47cb1c7c > >> > > >> > The gfxstream/AEMU commits would remain unchanged. > >> > >> That combination works for me.

Re: [PATCH 3/5] hw/isa: Embed TYPE_PORT92 in south bridges used in PC machines

2024-03-02 Thread BALATON Zoltan
On Sat, 2 Mar 2024, Bernhard Beschow wrote: Am 28. Februar 2024 13:02:55 UTC schrieb BALATON Zoltan : On Wed, 28 Feb 2024, BALATON Zoltan wrote: On Tue, 27 Feb 2024, Bernhard Beschow wrote: Am 27. Februar 2024 21:54:19 UTC schrieb BALATON Zoltan : On Tue, 27 Feb 2024, Bernhard Beschow wrote:

Re: [PATCH 3/5] hw/isa: Embed TYPE_PORT92 in south bridges used in PC machines

2024-03-02 Thread Bernhard Beschow
Am 28. Februar 2024 13:02:55 UTC schrieb BALATON Zoltan : >On Wed, 28 Feb 2024, BALATON Zoltan wrote: >> On Tue, 27 Feb 2024, Bernhard Beschow wrote: >>> Am 27. Februar 2024 21:54:19 UTC schrieb BALATON Zoltan >>> : On Tue, 27 Feb 2024, Bernhard Beschow wrote: > Am 21. Februar 2024 11:

Re: [PATCH 7/8] target/arm: Implement FEAT_ECV CNTPOFF_EL2 handling

2024-03-02 Thread Peter Maydell
On Fri, 1 Mar 2024 at 21:54, Richard Henderson wrote: > > On 3/1/24 08:32, Peter Maydell wrote: > > +static uint64_t gt_phys_raw_cnt_offset(CPUARMState *env) > > +{ > > +if ((env->cp15.scr_el3 & SCR_ECVEN) && > > +FIELD_EX64(env->cp15.cnthctl_el2, CNTHCTL, ECV) && > > +arm_is_e

Re: [PATCH 4/4] hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument

2024-03-02 Thread Bernhard Beschow
Am 1. März 2024 18:59:36 UTC schrieb "Philippe Mathieu-Daudé" : >The "isapc" machine only provides an ISA bus, not a PCI one, >and doesn't instanciate any i440FX south bridge. >Its machine class defines PCMachineClass::pci_enabled = false, >and pc_init1() only uses the pci_type argument when pc