Re: [PATCH v2] qdev: Report an error for machine without HotplugHandler

2023-12-19 Thread Markus Armbruster
Akihiko Odaki writes: > On 2023/12/18 23:02, Markus Armbruster wrote: >> Akihiko Odaki writes: >> >>> On 2023/12/11 15:51, Markus Armbruster wrote: Akihiko Odaki writes: > The HotplugHandler of the machine will be used when the parent bus does > not exist, but the machine may

Re: [PATCH v2 1/2] qdev: add IOThreadVirtQueueMappingList property type

2023-12-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 19.12.2023 um 16:13 hat Stefan Hajnoczi geschrieben: >> On Sat, Oct 14, 2023 at 09:35:14AM +0200, Markus Armbruster wrote: >> > Stefan Hajnoczi writes: >> > > +## >> > > +# @IOThreadVirtQueueMappings: >> > > +# >> > > +# IOThreadVirtQueueMapping list. This struct is not a

Re: TCP/telnet serial port not working in QEMU 8.1.3

2023-12-19 Thread Michael Tokarev
20.12.2023 01:44, Dave Blanchard : I just "upgraded" from QEMU 6.1.0 to 8.1.3 only to find that the -serial telnet/tcp option is no longer working. The following message is printed, and there's a 'connection refused' with the telnet program. Nmap shows no ports open. qemu-system-x86_64: -seria

Re: [PATCH for 9.0 07/12] vdpa: set backend capabilities at vhost_vdpa_init

2023-12-19 Thread Eugenio Perez Martin
On Wed, Dec 20, 2023 at 5:34 AM Jason Wang wrote: > > On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > > > The backend does not reset them until the vdpa file descriptor is closed > > so there is no harm in doing it only once. > > > > This allows the destination of a live migration to pre

Re: [PATCH for 9.0 08/12] vdpa: add vhost_vdpa_load_setup

2023-12-19 Thread Eugenio Perez Martin
On Wed, Dec 20, 2023 at 6:22 AM Jason Wang wrote: > > On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > > > Callers can use this function to setup the incoming migration thread. > > > > This thread is able to map the guest memory while the migration is > > ongoing, without blocking QMP or

Re: [PATCH 1/1] docs/system/riscv: document acpi parameter of virt machine

2023-12-19 Thread Sunil V L
On Tue, Dec 19, 2023 at 03:38:29PM +0100, Heinrich Schuchardt wrote: > Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI > table generation. Add it to the documentation. > > Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") > Signed-off-by: Heinrich Schuchard

Re: [PATCH for 9.0 08/12] vdpa: add vhost_vdpa_load_setup

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > Callers can use this function to setup the incoming migration thread. > > This thread is able to map the guest memory while the migration is > ongoing, without blocking QMP or other important tasks. While this > allows the destination QEMU n

Re: [PATCH] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK

2023-12-19 Thread Richard Henderson
On 12/20/23 02:04, Ruihan Li wrote: Hi all, On Mon, Dec 11, 2023 at 03:01:48AM +0800, Ruihan Li wrote: When emulated with QEMU, interrupts will never come in the following loop. However, if the NOP instruction is uncommented, interrupts will fire as normal. loop: cli

Re: [PATCH for 9.0 07/12] vdpa: set backend capabilities at vhost_vdpa_init

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > The backend does not reset them until the vdpa file descriptor is closed > so there is no harm in doing it only once. > > This allows the destination of a live migration to premap memory in > batches, using VHOST_BACKEND_F_IOTLB_BATCH. > > S

Re: [PATCH for 9.0 05/12] vdpa: factor out stop path of vhost_vdpa_dev_start

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > This makes easier to build an error path in next patches. No functional > change. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > hw/virtio/vhost-vdpa.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deleti

Re: [PATCH for 9.0 04/12] vdpa: extract out _dma_end_batch from _listener_commit

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > So we can call out vhost_vdpa_dma_end_batch out of the listener > callbacks. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > hw/virtio/vhost-vdpa.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-)

Re: [PATCH for 9.0 03/12] vdpa: merge _begin_batch into _batch_begin_once

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > There was only one call. This way we can make the begin and end of the > batch symmetrical. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks

Re: [PATCH for 9.0 02/12] vdpa: make batch_begin_once early return

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > Prefer early return so it is easier to merge > vhost_vdpa_listener_begin_batch here and make iotlb baches begin and end > symmetrical. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > hw/virtio/vhost-vdpa.c | 7

Re: [PATCH for 9.0 01/12] vdpa: do not set virtio status bits if unneeded

2023-12-19 Thread Jason Wang
On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > Next commits will set DRIVER and ACKNOWLEDGE flags repeatedly in the > case of a migration destination. Let's save ioctls with this. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > hw/virtio/vhost-vdpa.c | 4

Re: [PATCH] target/i386: Fix physical address truncation when PAE is enabled

2023-12-19 Thread Richard Henderson
On 12/18/23 23:56, Michael Brown wrote: The address translation logic in get_physical_address() will currently truncate physical addresses to 32 bits unless long mode is enabled. This is incorrect when using physical address extensions (PAE) outside of long mode, with the result that a 32-bit ope

[PATCH v2 3/9] target/loongarch: Supplement vcpu env initial when vcpu reset

2023-12-19 Thread Tianrui Zhao
Supplement vcpu env initial when vcpu reset, including init vcpu CSR_CPUID,CSR_TID to cpu->cpu_index. The two regs will be used in kvm_get/set_csr_ioctl. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- target/loongarch/cpu.c | 2 ++ target/loongarch/cpu.h | 2 +- 2 files changed, 3 i

[PATCH v2 1/9] linux-headers: Synchronize linux headers from linux v6.7.0-rc6

2023-12-19 Thread Tianrui Zhao
Use the scripts/update-linux-headers.sh to synchronize linux headers from linux v6.7.0-rc6. We mainly want to add the loongarch linux headers and then add the loongarch kvm support based on it. Signed-off-by: Tianrui Zhao --- include/standard-headers/drm/drm_fourcc.h | 2 + include/standar

[PATCH v2 5/9] target/loongarch: Implement kvm_arch_init function

2023-12-19 Thread Tianrui Zhao
Implement the kvm_arch_init of loongarch, in the function, the KVM_CAP_MP_STATE cap is checked by kvm ioctl. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li Reviewed-by: Richard Henderson --- target/loongarch/kvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/loongarch/kvm

[PATCH v2 7/9] target/loongarch: Implement kvm_arch_handle_exit

2023-12-19 Thread Tianrui Zhao
Implement kvm_arch_handle_exit for loongarch. In this function, the KVM_EXIT_LOONGARCH_IOCSR is handled, we read or write the iocsr address space by the addr, length and is_write argument in kvm_run. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li Reviewed-by: Richard Henderson --- targ

[PATCH v2 0/9] Add loongarch kvm accel support

2023-12-19 Thread Tianrui Zhao
The linux headers in this patch synchronized from linux kernel v6.7.0-rc6, and the loongarch kvm part of this patch series based on the header files. And the linux kernel has added the loongarch kvm support in master branch. This series add loongarch kvm support, mainly implement some interfaces u

[PATCH v2 4/9] target/loongarch: Implement kvm get/set registers

2023-12-19 Thread Tianrui Zhao
Implement kvm_arch_get/set_registers interfaces, many regs can be get/set in the function, such as core regs, csr regs, fpu regs, mp state, etc. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- meson.build | 1 + target/loongarch/cpu.c| 3 + target/loonga

[PATCH v2 9/9] target/loongarch: Add loongarch kvm into meson build

2023-12-19 Thread Tianrui Zhao
Add kvm.c into meson.build to compile it when kvm is configed. Meanwhile in meson.build, we set the kvm_targets to loongarch64-softmmu when the cpu is loongarch. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li Reviewed-by: Richard Henderson --- meson.build | 2 ++ targe

[PATCH v2 2/9] target/loongarch: Define some kvm_arch interfaces

2023-12-19 Thread Tianrui Zhao
Define some functions in target/loongarch/kvm.c, such as kvm_arch_put_registers, kvm_arch_get_registers and kvm_arch_handle_exit, etc. which are needed by kvm/kvm-all.c. Now the most functions has no content and they will be implemented in the next patches. Signed-off-by: Tianrui Zhao Signed-off-

[PATCH v2 8/9] target/loongarch: Implement set vcpu intr for kvm

2023-12-19 Thread Tianrui Zhao
Implement loongarch kvm set vcpu interrupt interface, when a irq is set in vcpu, we use the KVM_INTERRUPT ioctl to set intr into kvm. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- target/loongarch/cpu.c | 18 +- target/loongarch/kvm.c | 15 ++

[PATCH v2 6/9] target/loongarch: Implement kvm_arch_init_vcpu

2023-12-19 Thread Tianrui Zhao
Implement kvm_arch_init_vcpu interface for loongarch, in this function, we register VM change state handler. And when VM state changes to running, the counter value should be put into kvm to keep consistent with kvm, and when state change to stop, counter value should be refreshed from kvm. Signed

Re: [PATCH] ppc/spapr: Fix ubsan warning with unaligned pointer access

2023-12-19 Thread Richard Henderson
On 12/16/23 16:14, Daniel Hoffman wrote: Found while running QTest with UBsan. Unaligned pointers appear to be valid, so moving the read to an explicit memcpy to an intermediate. --- hw/ppc/vof.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/vof.c b/hw/ppc/vof.

Re: [PATCH 0/2] support unaligned access for some xHCI registers

2023-12-19 Thread Tomoyuki Hirose
On Tue, Dec 19, 2023 at 8:26 PM Peter Maydell wrote: > > On Tue, 19 Dec 2023 at 04:49, Tomoyuki Hirose > wrote: > > > > I would be grateful if you would any comments on my patch. > > It's on my todo list, but at this point I'm afraid I'm > not going to be able to get to it before I break for > th

TCP/telnet serial port not working in QEMU 8.1.3

2023-12-19 Thread Dave Blanchard
I just "upgraded" from QEMU 6.1.0 to 8.1.3 only to find that the -serial telnet/tcp option is no longer working. The following message is printed, and there's a 'connection refused' with the telnet program. Nmap shows no ports open. qemu-system-x86_64: -serial telnet:127.0.0.1:1800,server=on:

Re: [PATCH 11/12] next-cube.c: replace sysmem with get_system_memory() in next_cube_init()

2023-12-19 Thread Mark Cave-Ayland
On 16/12/2023 21:31, BALATON Zoltan wrote: On Sat, 16 Dec 2023, Thomas Huth wrote: Am Fri, 15 Dec 2023 20:00:08 + schrieb Mark Cave-Ayland : Removing the intermediate variable helps simplify the code in next_cube_init(). Signed-off-by: Mark Cave-Ayland ---  hw/m68k/next-cube.c | 14

Re: [PATCH 11/12] next-cube.c: replace sysmem with get_system_memory() in next_cube_init()

2023-12-19 Thread Mark Cave-Ayland
On 16/12/2023 20:20, Thomas Huth wrote: Am Fri, 15 Dec 2023 20:00:08 + schrieb Mark Cave-Ayland : Removing the intermediate variable helps simplify the code in next_cube_init(). Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 14 +++--- 1 file changed, 7 insertions(+

Re: [PATCH 09/12] next-cube.c: move static old_scr2 variable to NeXTPC

2023-12-19 Thread Mark Cave-Ayland
On 16/12/2023 20:18, Thomas Huth wrote: Am Fri, 15 Dec 2023 20:00:06 + schrieb Mark Cave-Ayland : Move the old_scr2 variable to NeXTPC so that the old SCR2 register state is stored along with the current SCR2 state. Since the SCR2 register is 32-bits wide, convert old_scr2 to uint32_t and

Re: [PATCH 08/12] next-cube.c: move LED logic to new next_scr2_led_update() function

2023-12-19 Thread Mark Cave-Ayland
On 16/12/2023 20:13, Thomas Huth wrote: Am Fri, 15 Dec 2023 20:00:05 + schrieb Mark Cave-Ayland : Ensure that the LED status is updated by calling next_scr2_led_update() whenever the SC2 register is written. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 22 +

[PATCH v9 08/10] hw/net: GMAC Rx Implementation

2023-12-19 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP N

[PATCH v9 06/10] tests/qtest: Creating qtest for GMAC Module

2023-12-19 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest/npcm_gmac-test.c | 209 ++

[PATCH v9 07/10] include/hw/net: General GMAC Implementation

2023-12-19 Thread Nabih Estefan
From: Nabih Estefan Diaz Implemented Classes and Masks for GMAC Descriptors - Implemeted classes for GMAC Receive and Transmit Descriptors - Implemented Masks for said descriptors - General GMAC Register handling - GMAC IRQ Handling Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting ---

[PATCH v9 10/10] tests/qtest: Adding PCS Module test to GMAC Qtest

2023-12-19 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff --git a/tests/qtest/npcm_gmac-test.c b/tests/qtest/npc

[PATCH v9 03/10] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2023-12-19 Thread Nabih Estefan
From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.

[PATCH v9 04/10] hw/net: Add NPCMXXX GMAC device

2023-12-19 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver [Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmm

[PATCH v9 09/10] hw/net: GMAC Tx Implementation

2023-12-19 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Signed-off-by: Nabih Estefan

[PATCH v9 02/10] hw/arm: Add PCI mailbox module to Nuvoton SoC

2023-12-19 Thread Nabih Estefan
From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 2 ++ include/hw/arm/npcm7xx.h| 1 + 3 files changed, 5 insertions(+) di

[PATCH v9 05/10] hw/arm: Add GMAC devices to NPCM7XX SoC

2023-12-19 Thread Nabih Estefan
From: Hao Wu Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.

[PATCH v9 01/10] hw/misc: Add Nuvoton's PCI Mailbox Module

2023-12-19 Thread Nabih Estefan
From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication wit

[PATCH v9 00/10] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-19 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v8] Suggestions and Fixes from Peter Maydell (peter.mayd...@linaro.org), also cleaned up changes so nothing is deleted in a later patch that was added in an earlier patch. Patch count decresed by 1 because this cleanup led to one of the patches being irrele

Re: [PATCH v2 04/14] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-12-19 Thread Stefan Hajnoczi
The following hack makes the test pass but there are larger safety issues that I'll need to look at on Wednesday: diff --git a/nbd/server.c b/nbd/server.c index 895cf0a752..cf4b7d5c6d 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -1617,7 +1617,7 @@ static void nbd_drained_begin(void *opaque)

Re: Qemu resets terminal to crazy defaults

2023-12-19 Thread Warner Losh
On Tue, Dec 19, 2023, 1:55 PM Peter Maydell wrote: > On Tue, 19 Dec 2023 at 19:40, Fabiano Rosas wrote: > > > > Dave Blanchard writes: > > > > > Hello all, can you please help me to understand what Qemu is doing > here? > > > > > > When connecting to the guest for example using a serial/tcp/tel

Re: Qemu resets terminal to crazy defaults

2023-12-19 Thread Peter Maydell
On Tue, 19 Dec 2023 at 19:40, Fabiano Rosas wrote: > > Dave Blanchard writes: > > > Hello all, can you please help me to understand what Qemu is doing here? > > > > When connecting to the guest for example using a serial/tcp/telnet link, > > some kind of code is being immediately transmitted ove

Re: [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices

2023-12-19 Thread Peter Maydell
On Tue, 19 Dec 2023 at 19:15, Samuel Tardieu wrote: > > > Peter Maydell writes: > > >> Any idea to why patchew fails to apply thoses patches? The mbox > >> at > >> > >> applies cleanly on master AFAICS. > > > > This is because y

Re: [PATCH v7] ui/cocoa: Use NSWindow's ability to resize

2023-12-19 Thread Marek Glogowski
Hi For me, the problem does not occur if you use the maximum screen resolution available. For me it is 1680x1050 - everything works fine. When I change the screen preference to a smaller screen resolution than my maximum (1440x900,1024x768 ...) the mouse starts to malfunction. The mouse pointer

Re: [PATCH v2 06/14] block: remove AioContext locking

2023-12-19 Thread Stefan Hajnoczi
On Tue, 19 Dec 2023 at 10:59, Kevin Wolf wrote: > > Am 05.12.2023 um 19:20 hat Stefan Hajnoczi geschrieben: > > This is the big patch that removes > > aio_context_acquire()/aio_context_release() from the block layer and > > affected block layer users. > > > > There isn't a clean way to split this

Re: Qemu resets terminal to crazy defaults

2023-12-19 Thread Warner Losh
On Tue, Dec 19, 2023, 12:20 PM Dave Blanchard wrote: > Hello all, can you please help me to understand what Qemu is doing here? > > When connecting to the guest for example using a serial/tcp/telnet link, > some kind of code is being immediately transmitted over the link which > screws up my Xter

Re: Qemu resets terminal to crazy defaults

2023-12-19 Thread Fabiano Rosas
Dave Blanchard writes: > Hello all, can you please help me to understand what Qemu is doing here? > > When connecting to the guest for example using a serial/tcp/telnet link, some > kind of code is being immediately transmitted over the link which screws up > my Xterm terminal settings, includ

Re: [PATCH v2 12/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2023-12-19 Thread Bernhard Beschow
Am 19. Dezember 2023 00:26:15 UTC schrieb BALATON Zoltan : >On Mon, 18 Dec 2023, Bernhard Beschow wrote: >> The VIA south bridges are able to relocate and toggle (enable or disable) >> their >> SuperI/O functions. So far this is hardcoded such that all functions are >> always >> enabled and ar

[PULL 14/43] target/arm/kvm: Merge kvm64.c into kvm.c

2023-12-19 Thread Peter Maydell
From: Richard Henderson Since kvm32.c was removed, there is no need to keep them separate. This will allow more symbols to be unexported. Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMM: retain copyright line

[PULL 19/43] target/arm/kvm: Unexport kvm_{get,put}_vcpu_events

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 20 target/arm/kvm.c | 20 ++-- 2 files cha

[PULL 22/43] hw/intc/arm_gicv3: Include missing 'qemu/error-report.h' header

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé kvm_arm_its_reset_hold() calls warn_report(), itself declared in "qemu/error-report.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan Message-id: 20231123183518.64569-2-phi...@linaro.org Signed-off-by: Peter Maydell

[PULL 39/43] target/arm: Restrict TCG specific helpers

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20231130142519.28417-2-phi...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.c| 55 -- target/arm/tcg/op_helper.c | 55 +

[PULL 38/43] target/arm: Don't implement *32_EL2 registers when EL1 is AArch64 only

2023-12-19 Thread Peter Maydell
The system registers DBGVCR32_EL2, FPEXC32_EL2, DACR32_EL2 and IFSR32_EL2 are present only to allow an AArch64 EL2 or EL3 to read and write the contents of an AArch32-only system register. The architecture requires that they are present only when EL1 can be AArch32, but we implement them unconditi

Re: [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices

2023-12-19 Thread Samuel Tardieu
Peter Maydell writes: Any idea to why patchew fails to apply thoses patches? The mbox at applies cleanly on master AFAICS. This is because you put a Based-on: tag in the cover letter. Based-on: means "please apply this ot

[PULL 18/43] target/arm/kvm: Init cap_has_inject_serror_esr in kvm_arch_init

2023-12-19 Thread Peter Maydell
From: Richard Henderson There is no need to do this in kvm_arch_init_vcpu per vcpu. Inline kvm_arm_init_serror_injection rather than keep separate. Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Pe

[PULL 27/43] target/arm/kvm: Have kvm_arm_set_device_attr take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 16/43] target/arm/kvm: Unexport kvm_arm_vcpu_finalize

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 14 -- target/arm/kvm.c | 14 +- 2 files changed, 13 ins

[PULL 28/43] target/arm/kvm: Have kvm_arm_pvtime_init take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

Qemu resets terminal to crazy defaults

2023-12-19 Thread Dave Blanchard
Hello all, can you please help me to understand what Qemu is doing here? When connecting to the guest for example using a serial/tcp/telnet link, some kind of code is being immediately transmitted over the link which screws up my Xterm terminal settings, including changing the text cursor shape

[PULL 32/43] target/arm/kvm: Have kvm_arm_vcpu_finalize take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 13/43] target/arm/kvm: Move kvm_arm_reg_syncs_via_cpreg_list and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [PMM: merged two duplicate comments, as suggested by Gavin] Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 10 -- target/ar

[PULL 37/43] target/arm/kvm: Have kvm_arm_hw_debug_active take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 12/43] target/arm/kvm: Move kvm_arm_cpreg_level and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 9 - target/arm/kvm.c | 22 ++ target/arm/kvm64.c

[PULL 43/43] fsl-imx: add simple RTC emulation for i.MX6 and i.MX7 boards

2023-12-19 Thread Peter Maydell
From: Nikita Ostrenkov Signed-off-by: Nikita Ostrenkov Message-id: 20231216133408.2884-1-n.ostren...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/hw/misc/imx7_snvs.h | 7 ++- hw/misc/imx7_snvs.c | 93 ++--- hw/misc/trac

[PULL 07/43] target/arm/kvm: Move kvm_arm_handle_debug and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 9 -- target/arm/kvm.c | 77 t

[PULL 10/43] target/arm/kvm: Move kvm_arm_get_host_cpu_features and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 22 target/arm/kvm.c | 265 +++ ta

[PULL 36/43] target/arm/kvm: Have kvm_arm_handle_debug take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 30/43] target/arm/kvm: Have kvm_arm_pmu_set_irq take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 20/43] target/arm/kvm: Unexport and tidy kvm_arm_sync_mpstate_to_{kvm, qemu}

2023-12-19 Thread Peter Maydell
From: Richard Henderson Drop fprintfs and actually use the return values in the callers. This is OK to do since commit 7191f24c7fcf which added the error-check to the generic accel/kvm functions that eventually call into these ones. Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Revi

[PULL 29/43] target/arm/kvm: Have kvm_arm_pmu_init take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 34/43] target/arm/kvm: Have kvm_arm_verify_ext_dabt_pending take a ARMCPU arg

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 04/43] target/arm/kvm: Move kvm_arm_verify_ext_dabt_pending and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 10 target/arm/kvm.c | 57

[PULL 17/43] target/arm/kvm: Unexport kvm_arm_init_cpreg_list

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 12 target/arm/kvm.c | 10 -- 2 files changed, 8 insertions

[PULL 42/43] target/arm/helper: Propagate MDCR_EL2.HPMN into PMCR_EL0.N

2023-12-19 Thread Peter Maydell
From: Jean-Philippe Brucker MDCR_EL2.HPMN allows an hypervisor to limit the number of PMU counters available to EL1 and EL0 (to keep the others to itself). QEMU already implements this split correctly, except for PMCR_EL0.N reads: the number of counters read by EL1 or EL0 should be the one config

[PULL 15/43] target/arm/kvm: Unexport kvm_arm_vcpu_init

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 12 target/arm/kvm.c | 12 +++- 2 files changed, 11 inserti

[PULL 01/43] accel/kvm: Make kvm_has_guest_debug static

2023-12-19 Thread Peter Maydell
From: Richard Henderson This variable is not used or declared outside kvm-all.c. Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- accel/kvm/kvm-all.c | 2 +- 1 file changed, 1 ins

[PULL 06/43] target/arm/kvm: Move kvm_arm_hw_debug_active and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 8 target/arm/kvm.c | 11 +++ target/arm/kvm64.c | 5 -

[PULL 11/43] target/arm/kvm: Use a switch for kvm_arm_cpreg_level

2023-12-19 Thread Peter Maydell
From: Richard Henderson Use a switch instead of a linear search through data. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm64.c | 32 +--- 1 file changed, 9 i

[PULL 09/43] target/arm/kvm: Inline kvm_arm_steal_time_supported

2023-12-19 Thread Peter Maydell
From: Richard Henderson This function is only used once, and is quite simple. Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 13 - target/arm/

[PULL 33/43] target/arm/kvm: Have kvm_arm_[get|put]_virtual_time take ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 25/43] target/arm/kvm: Have kvm_arm_sve_set_vls take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 26/43] target/arm/kvm: Have kvm_arm_sve_get_vls take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 08/43] target/arm/kvm: Unexport kvm_arm_{get, put}_virtual_time

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 16 target/arm/kvm.c | 16 ++-- 2 files changed, 14

[PULL 41/43] target/arm/tcg: Including missing 'exec/exec-all.h' header

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé translate_insn() ends up calling probe_access_full(), itself declared in "exec/exec-all.h": TranslatorOps::translate_insn -> aarch64_tr_translate_insn() -> is_guarded_page() -> probe_access_full() Signed-off-by: Philippe Mathieu-Daudé Reviewed-b

[PULL 23/43] target/arm/kvm: Remove unused includes

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Both MemoryRegion and Error types are forward declared in "qemu/typedefs.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan Message-id: 20231123183518.64569-3-phi...@linaro.org Signed-off-by: Peter Maydell --- target

[PULL 05/43] target/arm/kvm: Move kvm_arm_copy_hw_debug_data and unexport

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 10 -- target/arm/kvm.c | 24 target/arm/kvm64.

[PULL 00/43] target-arm queue

2023-12-19 Thread Peter Maydell
n the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20231219 for you to fetch changes up to 6f9c3aaa34e937d8deaab44671e7562e4027436b: fsl-imx: add simple RTC emulation for i.MX6 and i.MX7 boards (2023-12-19 18:03:32

[PULL 02/43] target/arm: kvm64: remove a redundant KVM_CAP_SET_GUEST_DEBUG probe

2023-12-19 Thread Peter Maydell
From: Chao Du The KVM_CAP_SET_GUEST_DEBUG is probed during kvm_init(). gdbserver will fail to start if the CAP is not supported. So no need to make another probe here, like other targets. Signed-off-by: Chao Du Reviewed-by: Richard Henderson Message-Id: <20231025070726.22689-1-duc...@eswincomp

[PULL 40/43] target/arm: Restrict DC CVAP & DC CVADP instructions to TCG accel

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Hardware accelerators handle that in *hardware*. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20231130142519.28417-3-phi...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.c | 5 + 1 file changed, 5 insertions

[PULL 21/43] target/arm/kvm: Unexport kvm_arm_vm_state_change

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 2 -- target/arm/kvm.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)

[PULL 24/43] target/arm/kvm: Have kvm_arm_add_vcpu_properties take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 31/43] target/arm/kvm: Have kvm_arm_vcpu_init take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 03/43] target/arm/kvm: Merge kvm_arm_init_debug into kvm_arch_init

2023-12-19 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- target/arm/kvm_arm.h | 8 target/arm/kvm.c | 8 +++- target/arm/kvm64.c | 12 -

[PULL 35/43] target/arm/kvm: Have kvm_arm_handle_dabt_nisv take a ARMCPU argument

2023-12-19 Thread Peter Maydell
From: Philippe Mathieu-Daudé Unify the "kvm_arm.h" API: All functions related to ARM vCPUs take a ARMCPU* argument. Use the CPU() QOM cast macro When calling the generic vCPU API from "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan

[PULL 03/47] vfio/container: Switch to dma_map|unmap API

2023-12-19 Thread Cédric Le Goater
From: Eric Auger No functional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 4 --- include/hw/vfio/vfio-contai

[PULL 44/47] vfio/ccw: Move VFIODevice initializations in vfio_ccw_instance_init

2023-12-19 Thread Cédric Le Goater
From: Zhenzhong Duan Some of the VFIODevice initializations is in vfio_ccw_realize, move all of them in vfio_ccw_instance_init. No functional change intended. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Farman Tested-by:

  1   2   3   >