Re: [PATCH v2 6/7] gitlab: build the correct microblaze target

2023-12-03 Thread Thomas Huth
On 01/12/2023 10.36, Alex Bennée wrote: We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.

Re: [PATCH 1/3] hw/virtio: check owner for removing objects

2023-12-03 Thread Marc-André Lureau
On Tue, Nov 7, 2023 at 1:37 PM Albert Esteve wrote: > > Shared objects lack spoofing protection. > For VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE messages > received by the vhost-user interface, any backend was > allowed to remove entries from the shared table just > by knowing the UUID. Only the own

Re: [PATCH v3 07/70] physmem: Relax the alignment check of host_startaddr in ram_block_discard_range()

2023-12-03 Thread Xiaoyao Li
On 12/4/2023 3:35 PM, Xiaoyao Li wrote: On 11/20/2023 5:56 PM, David Hildenbrand wrote: On 16.11.23 03:56, Xiaoyao Li wrote: On 11/16/2023 2:20 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Commit d3a5038c461 ("exec: ram_block_discard_range") introduced ram_block_discard_r

Re: [PATCH for 8.2] hw/audio/virtio-sound: mark the device as unmigratable

2023-12-03 Thread Volker Rümelin
Am 04.12.23 um 08:28 schrieb Volker Rümelin: > The virtio-sound device is currently not migratable. QEMU crashes > on the source machine at some point during the migration with a > segmentation fault. > > Even with this bug fixed, the virtio-sound device doesn't migrate > the state of the audio st

Re: [PATCH v3 08/70] physmem: replace function name with __func__ in ram_block_discard_range()

2023-12-03 Thread Xiaoyao Li
On 11/16/2023 2:21 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Use __func__ to avoid hard-coded function name. Signed-off-by: Xiaoyao Li --- That can be queued independently. Will you queue it for 9.0? for someone else? Do I need to send it separately? Reviewed-by:

Re: [PATCH v3 07/70] physmem: Relax the alignment check of host_startaddr in ram_block_discard_range()

2023-12-03 Thread Xiaoyao Li
On 11/20/2023 5:56 PM, David Hildenbrand wrote: On 16.11.23 03:56, Xiaoyao Li wrote: On 11/16/2023 2:20 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Commit d3a5038c461 ("exec: ram_block_discard_range") introduced ram_block_discard_range() which grabs some code from ram_dis

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-12-03 Thread Marc-André Lureau
Hi On Tue, Nov 28, 2023 at 2:52 PM Marc-André Lureau wrote: > > Hi > > On Mon, Nov 27, 2023 at 2:52 PM Fiona Ebner wrote: > > > > Am 27.11.23 um 10:15 schrieb Marc-André Lureau: > > > > > > It seems like a bug in tigervnc then. For some reason, the compressed > > > data doesn't trigger Z_STREAM_

[PATCH for 8.2] hw/audio/virtio-sound: mark the device as unmigratable

2023-12-03 Thread Volker Rümelin
The virtio-sound device is currently not migratable. QEMU crashes on the source machine at some point during the migration with a segmentation fault. Even with this bug fixed, the virtio-sound device doesn't migrate the state of the audio streams. For example, running streams leave the device on t

RE: [PATCH v2 3/4] configure: add qpl option

2023-12-03 Thread Liu, Yuan1
> -Original Message- > From: Fabiano Rosas > Sent: Saturday, December 2, 2023 1:45 AM > To: Liu, Yuan1 ; quint...@redhat.com; > pet...@redhat.com; leob...@redhat.com > Cc: qemu-devel@nongnu.org; Liu, Yuan1 ; Zou, Nanhai > > Subject: Re: [PATCH v2 3/4] configure: add qpl option > > Yuan L

Re: [PATCH v3 05/70] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

2023-12-03 Thread Xiaoyao Li
On 11/18/2023 4:50 AM, Isaku Yamahata wrote: On Wed, Nov 15, 2023 at 02:14:14AM -0500, Xiaoyao Li wrote: From: Chao Peng Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that backend'ed both by hva-based shared memo

Re: [PATCH-for-9.0 24/25] hw/nvram: Simplify memory_region_init_rom_device() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, errp; @@ - memory_region_init_rom_device(mr, owner, arg3, arg4, arg5, arg6, &errp); if ( - errp + !memory_region_init_rom_

Re: [PATCH-for-9.0 25/25] hw/pci-host/raven: Propagate error in raven_realize()

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: When an Error** reference is available, it is better to propagate local errors, rather then using generic ones, which might terminate the whole QEMU process. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/raven.c | 6 -- 1 file chan

Re: [PATCH-for-9.0 23/25] hw/misc: Simplify memory_region_init_ram_from_fd() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, arg7, errp; @@ - memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp); if ( - errp + !memory_re

Re: [PATCH-for-9.0 21/25] hw/arm: Simplify memory_region_init_rom() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_rom(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_rom(mr, owner, arg3, arg4, &errp)

Re: [PATCH-for-9.0 22/25] hw/sparc: Simplify memory_region_init_ram_nomigrate() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_ram_nomigrate(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_ram_nomigrate(mr, owner,

Re: [PATCH-for-9.0 20/25] hw: Simplify memory_region_init_ram() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_ram(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_ram(mr, owner, arg3, arg4, &errp)

Re: [PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- backends/hostmem.c | 22 +++--- hw/virtio/virtio-mem.c | 6 ++ 2 files changed, 9 insertions(+), 19 deletions(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 18/25] util/oslib: Have qemu_prealloc_mem() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/osd

Re: [PATCH-for-9.0 17/25] backends: Reduce variable scope in host_memory_backend_memory_complete

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Reduce the &local_err variable use and remove the 'out:' label. Signed-off-by: Philippe Mathieu-Daudé --- backends/hostmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 16/25] backends: Have HostMemoryBackendClass::alloc() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/h

Re: [PATCH-for-9.0 15/25] backends: Simplify host_memory_backend_memory_complete()

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Return early if bc->alloc is NULL. De-indent the if() ladder. Note, this avoids a pointless call to error_propagate() with errp=NULL at the 'out:' label. Change trivial when reviewed with 'git-diff --ignore-all-space'. Signed-off-by: Philippe Ma

Re: [PATCH-for-9.0 14/25] backends: Use g_autofree in HostMemoryBackendClass::alloc() handlers

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: In preparation of having HostMemoryBackendClass::alloc() handlers return a boolean, have them use g_autofree. Signed-off-by: Philippe Mathieu-Daudé --- backends/hostmem-epc.c | 3 +-- backends/hostmem-file.c | 3 +-- backends/hostmem-memfd

Re: [PATCH-for-9.0 13/25] memory: Have memory_region_init_ram_from_fd() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 12/25] memory: Have memory_region_init_ram_from_file() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 11/25] memory: Have memory_region_init_resizeable_ram() return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 10/25] memory: Have memory_region_init_rom_device() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 09/25] memory: Simplify memory_region_init_rom_device_nomigrate() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, errp; @@ - memory_region_init_rom_device_nomigrate(mr, owner, arg3, arg4, arg5, arg6, &errp); if ( - errp + !memory_regio

Re: [PATCH-for-9.0 08/25] memory: Have memory_region_init_rom_device_nomigrate() return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 07/25] memory: Have memory_region_init_rom() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/m

Re: [PATCH-for-9.0 06/25] memory: Have memory_region_init_ram() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, arg7, errp; @@ - memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp); if ( - errp + !memory_re

Re: [PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate() calls

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_rom_nomigrate(mr, owner,

Re: [PATCH-for-9.0 03/25] memory: Have memory_region_init_rom_nomigrate() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/m

Re: [PATCH-for-9.0 02/25] memory: Have memory_region_init_ram_nomigrate() handler return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 01/25] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean

2023-12-03 Thread Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/m

Re: [PATCH-for-9.0 2/2] target/arm/kvm: Use generic kvm_supports_guest_debug()

2023-12-03 Thread Gavin Shan
On 12/2/23 00:32, Philippe Mathieu-Daudé wrote: Do not open-code the generic kvm_supports_guest_debug(). Signed-off-by: Philippe Mathieu-Daudé --- target/arm/kvm64.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 1/2] accel/kvm: Expose kvm_supports_guest_debug() prototype

2023-12-03 Thread Gavin Shan
On 12/2/23 00:32, Philippe Mathieu-Daudé wrote: kvm_supports_guest_debug() should be accessible by KVM implementations. Signed-off-by: Philippe Mathieu-Daudé --- accel/kvm/kvm-cpus.h | 1 - include/sysemu/kvm.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gavin Shan

Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-12-03 Thread Davidlohr Bueso
On Thu, 30 Nov 2023, Jonathan Cameron wrote: If you mean generally harden the code we haven't fixed up for big endian systems then fair enough - that indeed needs doing. Yes, that was a braino, sorry for the confusion. Tricky to be sure we got it all right though unless we have a big endian

Re: [PATCH for-8.2] target/riscv/kvm: fix shadowing in kvm_riscv_(get|put)_regs_csr

2023-12-03 Thread Alistair Francis
On Mon, Dec 4, 2023 at 3:00 AM Philippe Mathieu-Daudé wrote: > > On 23/11/23 11:23, Philippe Mathieu-Daudé wrote: > > On 23/11/23 11:13, Daniel Henrique Barboza wrote: > >> KVM_RISCV_GET_CSR() and KVM_RISCV_SET_CSR() use an 'int ret' variable > >> that is used to do an early 'return' if ret > 0. B

Re: [PATCH] migration/dirtyrate: Remove an extra parameter

2023-12-03 Thread Yong Huang
On Mon, Dec 4, 2023 at 9:23 AM Wafer wrote: > vcpu_dirty_stat_collect() has an unused parameter so remove it. > > Signed-off-by: Wafer > --- > migration/dirtyrate.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c > in

Re: [PULL 0/6] riscv-to-apply queue

2023-12-03 Thread Alistair Francis
On Sun, Nov 26, 2023 at 7:08 AM Michael Tokarev wrote: > > 22.11.2023 08:37, Alistair Francis wrote: > ..> > > Fourth RISC-V PR for 8.2 > > > > This is a few bug fixes for the 8.2 release > > > > * Add Zicboz block size to hwprobe >

[PATCH] migration/dirtyrate: Remove an extra parameter

2023-12-03 Thread Wafer
vcpu_dirty_stat_collect() has an unused parameter so remove it. Signed-off-by: Wafer --- migration/dirtyrate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 036ac017fc..62d86b8be2 100644 --- a/migration/dirtyrate.c

[PATCH v9 6/9] hw/arm/virt: Check CPU type in machine_run_board_init()

2023-12-03 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do the check by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/arm/virt.c | 62 +++

[PATCH v9 3/9] machine: Improve is_cpu_type_supported()

2023-12-03 Thread Gavin Shan
It's no sense to check the CPU type when mc->valid_cpu_types[0] is NULL, which is a program error. Raise an assert on this. A precise hint for the error message is given when mc->valid_cpu_types[0] is the only valid entry. Besides, enumeration on mc->valid_cpu_types[0] when we have mutiple valid e

[PATCH v9 4/9] machine: Print CPU model name instead of CPU type

2023-12-03 Thread Gavin Shan
The names of supported CPU models instead of CPU types should be printed when the user specified CPU type isn't supported, to be consistent with the output from '-cpu ?'. Correct the error messages to print CPU model names instead of CPU type names. Signed-off-by: Gavin Shan Reviewed-by: Philipp

[PATCH v9 7/9] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init()

2023-12-03 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Leif Lindholm Reviewed-by: Richard Henderson --- hw/arm/sbsa-ref.c | 36 ++

[PATCH v9 9/9] hw/riscv/shakti_c: Check CPU type in machine_run_board_init()

2023-12-03 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé --- hw/riscv/shakti_c.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-)

[PATCH v9 2/9] machine: Introduce helper is_cpu_type_supported()

2023-12-03 Thread Gavin Shan
The logic, to check if the specified CPU type is supported in machine_run_board_init(), is independent enough. Factor it out into helper is_cpu_type_supported(). machine_run_board_init() looks a bit clean with this. Since we're here, @machine_class is renamed to @mc to avoid multiple line spanning

[PATCH v9 8/9] hw/arm: Check CPU type in machine_run_board_init()

2023-12-03 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/bananapi_m2u.c | 12 ++-- hw/arm/cubiebo

[PATCH v9 5/9] hw/arm/virt: Hide host CPU model for tcg

2023-12-03 Thread Gavin Shan
The 'host' CPU model isn't available until KVM or HVF is enabled. For example, the following error messages are seen when the guest is started with option '-cpu cortex-a8' on tcg after the next commit is applied to check the CPU type in machine_run_board_init(). ERROR:../hw/core/machine.c:1423:i

[PATCH v9 0/9] Unified CPU type check

2023-12-03 Thread Gavin Shan
This series bases on Phil's repository because the prepatory commits have been queued to the branch. https://gitlab.com/philmd/qemu.git (branch: cpus-next) There are two places where the user specified CPU type is checked to see if it's supported or allowed by the board: machine_run_board_init(

[PATCH v9 1/9] machine: Use error handling when CPU type is checked

2023-12-03 Thread Gavin Shan
Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. The principle is violated by machine_run_board_init() because it calls error_report(), error_printf(), and exit(1) when the machine doesn't support the reque

[PATCH v3 20/45] Implement BCM2838 thermal sensor

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 27 ++-- hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_thermal.c| 98 hw/misc/meson.build | 3 +- include/hw/arm/bcm2838_peripherals.h | 2 + in

[PATCH v3 26/45] Add GENET register structs. Part 4

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 37 ++ 1 file changed, 37 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 1bd004785a..94c2f3ebca 100644 --- a/include/hw/net/bcm2838_genet.h +++ b/

[PATCH v3 06/45] Add BCM2838 GPIO stub

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 4 +- hw/gpio/bcm2838_gpio.c | 152 +++ hw/gpio/meson.build | 5 +- include/hw/arm/bcm2838_peripherals.h | 2 - include/hw/gpio/bcm2838_gpio.h | 40 +++

[PATCH v3 21/45] Add clock_isp stub

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 6 ++ include/hw/arm/bcm2838_peripherals.h | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c index e9c6d47ba6..65a659c15c 100644 --- a/hw/arm/bcm2838_perip

[PATCH v3 09/45] Add GPIO and SD to BCM2838 periph

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 140 +++ include/hw/arm/bcm2838_peripherals.h | 9 ++ 2 files changed, 149 insertions(+) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c index 06110c724f..c147b6e453 10064

[PATCH v3 23/45] Add GENET register structs. Part 1

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 37 include/hw/net/bcm2838_genet.h | 77 +- 2 files changed, 113 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 4420486e00..0d98d1

[PATCH v3 32/45] Enable BCM2838 GENET controller

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 16 hw/arm/raspi4b.c | 17 - include/hw/arm/bcm2838_peripherals.h | 2 ++ 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/arm/bcm2838_peripherals.c b

[PATCH v3 35/45] Add mailbox test stub

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/arm/bcm2838_peripherals.h | 2 + tests/qtest/bcm2838-mailbox.c| 71 tests/qtest/bcm2838-mailbox.h| 46 ++ tests/qtest/meson.build | 1 + 4 files changed, 120 insertions(+) cr

[PATCH v3 42/45] Add mailbox property tests. Part 3

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 213 ++- 1 file changed, 212 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index 5322c563a0..1b4a2ed9cb 100644 --- a/

[PATCH v3 27/45] Add GENET register access macros

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 76 ++ 1 file changed, 76 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 94c2f3ebca..e7a76cda81 100644 --- a/include/hw/net/bcm2838_genet.h +++ b/

[PATCH v3 39/45] Add mailbox tests tags. Part 3

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 78 +++ 1 file changed, 78 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 49668668da..2b140a5d32 100644 --- a/tests/qtest/bcm2838-mailbox.h +++ b/tes

[PATCH v3 18/45] Add RNG200 RNG and RBG

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2838_rng200.c | 292 +-- include/hw/misc/bcm2838_rng200.h | 10 +- 2 files changed, 275 insertions(+), 27 deletions(-) diff --git a/hw/misc/bcm2838_rng200.c b/hw/misc/bcm2838_rng200.c index 8f64e6a20f..f91ea0754c

[PATCH v3 28/45] Implement GENET register ops

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 189 +++-- include/hw/net/bcm2838_genet.h | 2 + 2 files changed, 182 insertions(+), 9 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index be899b68f8..56ff6a6f39 100644 -

[PATCH v3 29/45] Implement GENET MDIO

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 126 - include/hw/net/bcm2838_genet.h | 3 +- 2 files changed, 126 insertions(+), 3 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 56ff6a6f39..1fae3ecbc2 100644

[PATCH v3 10/45] Add BCM2838 checkpoint support

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c index c147b6e453..196fb890a2 100644 --- a/hw/arm/bcm2838_peripherals.c +++ b/hw/arm/bcm2838_peripherals.c

[PATCH v3 36/45] Add mailbox test constants

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 139 ++ 1 file changed, 139 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 1d02ca9c2c..8acc4bd2ff 100644 --- a/tests/qtest/bcm2838-mailbox.h +++ b/te

[PATCH v3 01/45] Split out common part of BCM283X classes

2023-12-03 Thread Sergey Kambalin
Pre setup for BCM2838 introduction Signed-off-by: Sergey Kambalin --- hw/arm/bcm2836.c | 102 ++- hw/arm/raspi.c | 2 +- include/hw/arm/bcm2836.h | 26 +- 3 files changed, 83 insertions(+), 47 deletions(-) diff --git a/hw/arm/bcm2

[PATCH v3 41/45] Add mailbox property tests. Part 2

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 196 ++- 1 file changed, 195 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index 80746dbb95..5322c563a0 100644 --- a/

[PATCH v3 38/45] Add mailbox tests tags. Part 2

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 152 ++ 1 file changed, 152 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 04472fe23d..49668668da 100644 --- a/tests/qtest/bcm2838-mailbox.h +++ b/te

[PATCH v3 04/45] Introduce BCM2838 SoC

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 100 +++ hw/arm/bcm2838_peripherals.c | 72 +++ hw/arm/meson.build | 2 + include/hw/arm/bcm2838.h | 29 include/hw/arm/bcm2838_peri

[PATCH v3 17/45] Add RNG200 skeleton

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2838_rng200.c | 152 +++ hw/misc/meson.build | 1 + hw/misc/trace-events | 9 ++ include/hw/misc/bcm2838_rng200.h | 51 +++ 4 files changed, 213 insertions(+) create mode 10064

[PATCH v3 00/45] Raspberry Pi 4B machine

2023-12-03 Thread Sergey Kambalin
Introducing Raspberry Pi 4B model. It contains new BCM2838 SoC, PCIE subsystem, RNG200, Thermal sensor and Genet network controller. It can work with recent linux kernels 6.x.x. Two avocado tests was added to check that. Unit tests has been made as read/write operations via mailbox properties. G

[PATCH v3 30/45] Implement GENET TX path

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 221 - include/hw/net/bcm2838_genet.h | 17 +++ 2 files changed, 237 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 1fae3ecbc2..4c9b39a3ca 100644

[PATCH v3 44/45] Append added properties to mailbox test

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index 1b4a2ed9cb..3a2e7f9194 100644 --- a/te

[PATCH v3 40/45] Add mailbox property tests. Part 1

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.c| 34 ++-- tests/qtest/bcm2838-mailbox.h| 18 +- tests/qtest/bcm2838-mbox-property-test.c | 206 +++ tests/qtest/meson.build | 2 +- 4 files changed, 220 insertions(+),

[PATCH v3 45/45] Add RPi4B to paspi4.rst

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- docs/system/arm/raspi.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/system/arm/raspi.rst b/docs/system/arm/raspi.rst index 922fe375a6..db9e0949ef 100644 --- a/docs/system/arm/raspi.rst +++ b/docs/system/arm/raspi.rst @@

[PATCH v3 19/45] Get rid of RNG200 timer

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 14 + hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_rng200.c | 78 include/hw/arm/bcm2838_peripherals.h | 2 + include/hw/misc/bcm2838_rng200.h | 4 +- 5 fil

[PATCH v3 12/45] Temporarily disable unimplemented rpi4b devices

2023-12-03 Thread Sergey Kambalin
This commit adds RPi4B device tree modifications: - disable pcie, rng200, thermal sensor and genet devices (they're going to be re-enabled in the following commits) - create additional memory region in device tree if RAM amount exceeds VC base address. Signed-off-by: Sergey Kambalin --- hw/a

[PATCH v3 34/45] Add Rpi4b boot tests

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/avocado/boot_linux_console.py | 92 + 1 file changed, 92 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 6eab515718..62aac02bbb 100644 --- a/tests/avocado/boot_linux_c

[PATCH v3 02/45] Split out common part of peripherals

2023-12-03 Thread Sergey Kambalin
Pre-setup for BCM2838 introduction Signed-off-by: Sergey Kambalin --- hw/arm/bcm2835_peripherals.c | 198 +++ hw/arm/bcm2836.c | 24 ++-- include/hw/arm/bcm2835_peripherals.h | 29 +++- include/hw/arm/bcm2836.h | 3 +- 4 files c

[PATCH v3 03/45] Split out raspi machine common part

2023-12-03 Thread Sergey Kambalin
Pre-setup for raspberry pi 4 introduction Signed-off-by: Sergey Kambalin --- hw/arm/raspi.c | 112 ++-- include/hw/arm/raspi_platform.h | 21 ++ 2 files changed, 85 insertions(+), 48 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c inde

[PATCH v3 13/45] Add memory region for BCM2837 RPiVid ASB

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 3 +++ include/hw/arm/bcm2838_peripherals.h | 3 ++- include/hw/arm/raspi_platform.h | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c inde

[PATCH v3 14/45] Add BCM2838 PCIE Root Complex

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 74 +++ hw/arm/meson.build| 5 ++- hw/arm/trace-events | 4 ++ include/hw/arm/bcm2838_pcie.h | 53 + 4 files changed, 135 insertions(+), 1 deletion(-)

[PATCH v3 37/45] Add mailbox tests tags. Part 1

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 195 +- 1 file changed, 190 insertions(+), 5 deletions(-) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 8acc4bd2ff..04472fe23d 100644 --- a/tests/qtest/bcm2838-ma

[PATCH v3 15/45] Add BCM2838 PCIE host

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 216 +- include/hw/arm/bcm2838_pcie.h | 22 2 files changed, 236 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2838_pcie.c b/hw/arm/bcm2838_pcie.c index 3b4373c6a6..75146d6c2e 100644 -

[PATCH v3 08/45] Connect SD controller to BCM2838 GPIO

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/gpio/bcm2838_gpio.c | 59 +++--- include/hw/gpio/bcm2838_gpio.h | 5 +++ 2 files changed, 60 insertions(+), 4 deletions(-) diff --git a/hw/gpio/bcm2838_gpio.c b/hw/gpio/bcm2838_gpio.c index 51eb55b00a..f166ce7959 100644 -

[PATCH v3 22/45] Add GENET stub

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2838_thermal.c | 2 +- hw/net/bcm2838_genet.c | 99 ++ hw/net/meson.build | 2 + hw/net/trace-events| 16 ++ include/hw/net/bcm2838_genet.h | 40 ++ 5 files changed

[PATCH v3 07/45] Implement BCM2838 GPIO functionality

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/gpio/bcm2838_gpio.c | 192 - 1 file changed, 189 insertions(+), 3 deletions(-) diff --git a/hw/gpio/bcm2838_gpio.c b/hw/gpio/bcm2838_gpio.c index 15b66cb559..51eb55b00a 100644 --- a/hw/gpio/bcm2838_gpio.c +++ b/hw/gpio

[PATCH v3 25/45] Add GENET register structs. Part 3

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 88 ++ include/hw/net/bcm2838_genet.h | 88 ++ 2 files changed, 176 insertions(+) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 9a99f34c4a..be8

[PATCH v3 33/45] Connect RNG200, PCIE and GENET to GIC

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 19 +++ include/hw/arm/bcm2838_peripherals.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/hw/arm/bcm2838.c b/hw/arm/bcm2838.c index 89cd9d5d8c..83f84b22ad 100644 --- a/hw/arm/bcm2838.c +++ b/hw/a

[PATCH v3 31/45] Implement GENET RX path

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 265 - include/hw/net/bcm2838_genet.h | 1 + 2 files changed, 265 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 4c9b39a3ca..61c1981e10 100644 --

[PATCH v3 43/45] Add missed BCM2835 properties

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2835_property.c | 47 include/hw/arm/raspberrypi-fw-defs.h | 12 ++- 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c index ff55a4e2cd..df

[PATCH v3 24/45] Add GENET register structs. Part 2

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 89 ++ include/hw/net/bcm2838_genet.h | 89 ++ 2 files changed, 178 insertions(+) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 0d98d1b30e..9a9

[PATCH v3 16/45] Enable BCM2838 PCIE

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c| 3 +++ hw/arm/bcm2838_peripherals.c | 26 ++ hw/arm/meson.build | 7 --- hw/arm/raspi4b.c | 1 - include/hw/arm/bcm2838_peripherals.h | 3 +++ 5

[PATCH v3 11/45] Introduce Raspberry PI 4 machine

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2835_peripherals.c| 20 +++-- hw/arm/bcm2836.c| 2 + hw/arm/bcm2838.c| 2 + hw/arm/meson.build | 2 +- hw/arm/raspi.c | 28 - hw/arm/raspi4b.c| 72

[PATCH v3 05/45] Add GIC-400 to BCM2838 SoC

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 167 +++ hw/arm/trace-events | 2 + include/hw/arm/bcm2838.h | 2 + include/hw/arm/bcm2838_peripherals.h | 39 +++ 4 files changed, 210 insertions(+) diff --git

[PATCH v3 16/45] Enable BCM2838 PCIE

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c| 3 +++ hw/arm/bcm2838_peripherals.c | 26 ++ hw/arm/meson.build | 7 --- hw/arm/raspi4b.c | 1 - include/hw/arm/bcm2838_peripherals.h | 3 +++ 5

[PATCH v3 32/45] Enable BCM2838 GENET controller

2023-12-03 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 16 hw/arm/raspi4b.c | 17 - include/hw/arm/bcm2838_peripherals.h | 2 ++ 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/arm/bcm2838_peripherals.c b

  1   2   3   >