Re: [PATCH-for-8.2? v2 4/4] hw/arm/stm32f100: Report error when incorrect CPU is used

2023-11-19 Thread Gavin Shan
On 11/17/23 17:17, Philippe Mathieu-Daudé wrote: The 'stm32vldiscovery' machine ignores the CPU type requested by the command line. This might confuse users, since the following will create a machine with a Cortex-M3 CPU: $ qemu-system-aarch64 -M stm32vldiscovery -cpu neoverse-n1 Set the Mac

Re: [PATCH-for-8.2? v2 3/4] hw/arm/stm32f205: Report error when incorrect CPU is used

2023-11-19 Thread Gavin Shan
On 11/17/23 17:17, Philippe Mathieu-Daudé wrote: The 'netduino2' machine ignores the CPU type requested by the command line. This might confuse users, since the following will create a machine with a Cortex-M3 CPU: $ qemu-system-arm -M netduino2 -cpu cortex-a9 Set the MachineClass::valid_cpu

Re: [PATCH-for-8.2? v2 2/4] hw/arm/stm32f405: Report error when incorrect CPU is used

2023-11-19 Thread Gavin Shan
On 11/17/23 17:17, Philippe Mathieu-Daudé wrote: Both 'netduinoplus2' and 'olimex-stm32-h405' machines ignore the CPU type requested by the command line. This might confuse users, since the following will create a machine with a Cortex-M4 CPU: $ qemu-system-aarch64 -M netduinoplus2 -cpu corte

[PATCH 1/1] tcg/loongarch64: Fix tcg_out_mov() Aborted

2023-11-19 Thread Song Gao
On LoongArch host, we got an Aborted from tcg_out_mov(). qemu-x86_64 configure with '--enable-debug'. > (gdb) b /home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc:312 > Breakpoint 1 at 0x2576f0: file > /home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc, line 312. > (gdb) run hello

Re: [PATCH] audio: Free consumed default audio devices

2023-11-19 Thread Marc-André Lureau
Hi On Sun, Nov 19, 2023 at 12:40 PM Akihiko Odaki wrote: > > Failed default audio devices were removed from the list but not freed, > and that made LeakSanitizer sad. Free default audio devices as they are > consumed. > > Signed-off-by: Akihiko Odaki > --- > audio/audio.c | 4 +++- > 1 file cha

Re: [PATCH v3 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-19 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 06:37, Leo Yan wrote: This patch derives vhost-user-input from vhost-user-base class, so make the input stub as a simpler boilerplate wrapper. With the refactoring, vhost-user-input adds the property 'chardev', this leads to conflict with the vhost-user-input-pci adds the sa

Re: [PATCH v3 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-19 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 06:37, Leo Yan wrote: vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change.

[PATCH v3 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-19 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan Reviewed-by: Marc-André Lureau --- hw/virtio/vhost-u

[PATCH v3 2/4] docs/system: Add vhost-user-input documentation

2023-11-19 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- MAINTAINERS | 1 + docs/system/device-emulation.rst | 1 + docs/system/devices/vhost-user-input.rst | 45 docs/system/devices/vhost-user.rst | 4 +

[PATCH v3 0/4] virtio: Refactor vhost input stub

2023-11-19 Thread Leo Yan
This series is to refactor vhost stub vhost-user-input. Since vhost input stub requires set_config() callback for communication event configurations between the backend and the guest, patch 01 is a preparison for support set_config() callback in vhost-user-base. The patch 02 is to add documentati

[PATCH v3 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-19 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan --- MAINTAINERS

[PATCH v3 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-19 Thread Leo Yan
This patch derives vhost-user-input from vhost-user-base class, so make the input stub as a simpler boilerplate wrapper. With the refactoring, vhost-user-input adds the property 'chardev', this leads to conflict with the vhost-user-input-pci adds the same property. To resolve the error, remove the

RE: [PATCH v6 09/21] vfio/iommufd: Enable pci hot reset through iommufd cdev interface

2023-11-19 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Sent: Friday, November 17, 2023 9:54 PM >Subject: Re: [PATCH v6 09/21] vfio/iommufd: Enable pci hot reset through >iommufd cdev interface > > > >On 11/14/23 11:09, Zhenzhong Duan wrote: >> Add a new callback iommufd_cdev_pci_hot_reset to do iommufd

RE: [PATCH] docs/devel: Add VFIO iommufd backend documentation

2023-11-19 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Friday, November 17, 2023 10:28 PM >To: Duan, Zhenzhong ; qemu-devel@nongnu.org >Cc: alex.william...@redhat.com; j...@nvidia.com; nicol...@nvidia.com; >joao.m.mart...@oracle.com; eric.au...@redhat.com; pet...@redhat.com; >jasow...@redhat

[PATCH v3] migration: free 'saddr' since be no longer used

2023-11-19 Thread Zongmin Zhou
Since socket_parse() will allocate memory for 'saddr',and its value will pass to 'addr' that allocated by migrate_uri_parse(), then 'saddr' will no longer used,need to free. But due to 'saddr->u' is shallow copying the contents of the union, the members of this union containing allocated strings,an

RE: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

2023-11-19 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Friday, November 17, 2023 9:56 PM >Subject: Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object > >On 11/17/23 14:29, Eric Auger wrote: >> Hi Cédric, >> >> On 11/17/23 12:39, Duan, Zhenzhong wrote: >>> Hi Cédric, >>>

Re: [PATCH v3] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Dan Hoffman
As far as I can tell, yes. Any optimization level above O0 does not have this issue (on this version of Clang, at least) On Sun, Nov 19, 2023 at 4:54 PM Philippe Mathieu-Daudé wrote: > Hi, > > On 19/11/23 21:31, Daniel Hoffman wrote: > > `kvm_enabled()` is compiled down to `0` and short-circuit

[PATCH v6 6/8] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init()

2023-11-19 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Leif Lindholm Reviewed-by: Richard Henderson --- v6: Move valid_cpu_types[] to

[PATCH v6 4/8] hw/arm/virt: Hide host CPU model for tcg

2023-11-19 Thread Gavin Shan
The 'host' CPU model isn't available until KVM or HVF is enabled. For example, the following error messages are seen when the guest is started with option '-cpu cortex-a8' on tcg after the next commit is applied to check the CPU type in machine_run_board_init(). ERROR:../hw/core/machine.c:1423:i

[PATCH v6 3/8] machine: Print CPU model name instead of CPU type

2023-11-19 Thread Gavin Shan
The names of supported CPU models instead of CPU types should be printed when the user specified CPU type isn't supported, to be consistent with the output from '-cpu ?'. Correct the error messages to print CPU model names instead of CPU type names. Signed-off-by: Gavin Shan --- hw/core/machine

[PATCH v6 7/8] hw/arm: Check CPU type in machine_run_board_init()

2023-11-19 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Richard Henderson --- v6: To have unified valid_cpu_types[] and move it to board's class_init() function

[PATCH v6 8/8] hw/riscv/shakti_c: Check CPU type in machine_run_board_init()

2023-11-19 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé --- v6: Move valid_cpu_types[] to shakti_c_machine_class_init() (Phil) --- hw/riscv/shakti_

[PATCH v6 5/8] hw/arm/virt: Check CPU type in machine_run_board_init()

2023-11-19 Thread Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do the check by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v6: Move valid_cpu_types[] to virt_machine_class_in

[PATCH v6 1/8] machine: Use error handling when CPU type is checked

2023-11-19 Thread Gavin Shan
QEMU will be terminated if the specified CPU type isn't supported in machine_run_board_init(). The list of supported CPU type names is tracked by mc->valid_cpu_types. The error handling can be used to propagate error messages, to be consistent how the errors are handled for other situations in the

[PATCH v6 0/8] Unified CPU type check

2023-11-19 Thread Gavin Shan
This series bases on Phil's repository because the prepatory commits have been queued to the branch. https://gitlab.com/philmd/qemu.git (branch: cpus-next) There are two places where the user specified CPU type is checked to see if it's supported or allowed by the board: machine_run_board_init(

[PATCH v6 2/8] machine: Introduce helper is_cpu_type_supported()

2023-11-19 Thread Gavin Shan
The logic, to check if the specified CPU type is supported in machine_run_board_init(), is independent enough. Factor it out into helper is_cpu_type_supported(). machine_run_board_init() looks a bit clean with this. Since we're here, @machine_class is renamed to @mc to avoid multiple line spanning

Re: [PATCH v3] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Philippe Mathieu-Daudé
Hi, On 19/11/23 21:31, Daniel Hoffman wrote: `kvm_enabled()` is compiled down to `0` and short-circuit logic is used to remove references to undefined symbols at the compile stage. Some build configurations with some compilers don't attempt to simplify this logic down in some cases (the pattern

[PATCH-for-8.2 v2 2/2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping RX FIFO

2023-11-19 Thread Philippe Mathieu-Daudé
Per https://docs.xilinx.com/r/en-US/ug1085-zynq-ultrascale-trm/Message-Format Message Format The same message format is used for RXFIFO, TXFIFO, and TXHPB. Each message includes four words (16 bytes). Software must read and write all four words regardless of the actual number of data by

[PATCH-for-8.2 v2 1/2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping TX FIFOs

2023-11-19 Thread Philippe Mathieu-Daudé
Per https://docs.xilinx.com/r/en-US/ug1085-zynq-ultrascale-trm/Message-Format Message Format The same message format is used for RXFIFO, TXFIFO, and TXHPB. Each message includes four words (16 bytes). Software must read and write all four words regardless of the actual number of data by

[PATCH-for-8.2 v2 0/2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping FIFOs

2023-11-19 Thread Philippe Mathieu-Daudé
Fix a pair of fuzzed bugs. Patch #1 is reviewed, #2 is new. Tested with the CAN tests from 'make check-qtest-aarch64'. Regards, Phil. Philippe Mathieu-Daudé (2): hw/net/can/xlnx-zynqmp: Avoid underflow while popping TX FIFOs hw/net/can/xlnx-zynqmp: Avoid underflow while popping RX FIFO h

Re: [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-19 Thread BALATON Zoltan
On Sun, 19 Nov 2023, BALATON Zoltan wrote: On Thu, 16 Nov 2023, Mark Cave-Ayland wrote: This series adds a simple implementation of legacy/native mode switching for PCI IDE controllers and updates the via-ide device to use it. The approach I take here is to add a new pci_ide_update_mode() func

Re: [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-19 Thread BALATON Zoltan
On Thu, 16 Nov 2023, Mark Cave-Ayland wrote: This series adds a simple implementation of legacy/native mode switching for PCI IDE controllers and updates the via-ide device to use it. The approach I take here is to add a new pci_ide_update_mode() function which handles management of the PCI BAR

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Dan Hoffman
Submitted a v3 with the minimum reproducible build configuration On Sun, Nov 19, 2023 at 2:25 PM Michael S. Tsirkin wrote: > > On Sun, Nov 19, 2023 at 02:19:25PM -0600, Dan Hoffman wrote: > > Clang 16.0.6 > > > > I can re-submit with the compiler and version if that helps. > > Worth mentioning th

[PATCH v3] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Daniel Hoffman
`kvm_enabled()` is compiled down to `0` and short-circuit logic is used to remove references to undefined symbols at the compile stage. Some build configurations with some compilers don't attempt to simplify this logic down in some cases (the pattern appears to be that the literal false must be the

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Michael S. Tsirkin
On Sun, Nov 19, 2023 at 02:19:25PM -0600, Dan Hoffman wrote: > Clang 16.0.6 > > I can re-submit with the compiler and version if that helps. Worth mentioning this and the flags used I think. > On Sun, Nov 19, 2023 at 2:02 PM Michael S. Tsirkin wrote: > > > > On Sun, Nov 19, 2023 at 11:03:54AM -

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Dan Hoffman
Clang 16.0.6 I can re-submit with the compiler and version if that helps. On Sun, Nov 19, 2023 at 2:02 PM Michael S. Tsirkin wrote: > > On Sun, Nov 19, 2023 at 11:03:54AM -0600, Dan Hoffman wrote: > > On Sun, Nov 19, 2023 at 1:23 AM Michael S. Tsirkin wrote: > > > > > > On Sat, Nov 18, 2023 at

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Michael S. Tsirkin
On Sun, Nov 19, 2023 at 11:03:54AM -0600, Dan Hoffman wrote: > On Sun, Nov 19, 2023 at 1:23 AM Michael S. Tsirkin wrote: > > > > On Sat, Nov 18, 2023 at 10:25:31AM -0800, Daniel Hoffman wrote: > > > `kvm_enabled()` is compiled down to `0` and short-circuit logic is > > > used to remmove references

[PATCH v2] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Daniel Hoffman
`kvm_enabled()` is compiled down to `0` and short-circuit logic is used to remmove references to undefined symbols at the compile stage. Some build configurations with some compilers don't attempt to simplify this logic down in some cases (the pattern appears to be that the literal false must be th

[PULL 0/1] target/xtensa fixes for v8.2

2023-11-19 Thread Max Filippov
The following changes since commit 9c673a41eefc50f1cb2fe3c083e7de842c7d276a: Update version for v8.2.0-rc0 release (2023-11-14 12:35:47 -0500) are available in the Git repository at: https://github.com/OSLL/qemu-xtensa.git tags/20231119-xtensa-1 for you to fetch changes up to

Re: [PULL] target/xtensa fixes for v8.2

2023-11-19 Thread Max Filippov
com/OSLL/qemu-xtensa.git tags/20231119-xtensa > > for you to fetch changes up to 79cc6538fba73b3c071d76d912486e96540df98f: > > linux-user: xtensa: fix signal delivery in FDPIC (2023-11-19 10:38:07 -0800) > > &

[PULL] target/xtensa fixes for v8.2

2023-11-19 Thread Max Filippov
The following changes since commit b411438aa4ecaf4bbde90e20283e5899fec10f58: target/xtensa: Use tcg_gen_sextract_i32 (2023-10-21 19:17:28 -0700) are available in the Git repository at: https://github.com/OSLL/qemu-xtensa.git tags/20231119-xtensa for you to fetch changes up to

[Stable-7.2.7 v2 00/62] Patch Round-up for stable 7.2.7, frozen on 2023-11-19

2023-11-19 Thread Michael Tokarev
The following patches are queued for QEMU stable v7.2.7: https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 Patch freeze is 2023-11-19 (frozen), and the release is planned for 2023-11-21: https://wiki.qemu.org/Planning/7.2 Please respond here or CC qemu-sta...@nongnu.org on any addi

[Stable-8.1.3 54/59] tracetool: avoid invalid escape in Python string

2023-11-19 Thread Michael Tokarev
From: Marc-André Lureau This is an error in Python 3.12; fix it by using a raw string literal. Cc: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Message-ID: <20231108105649.60453-1-marcandre.lur...@redhat.com> (cherry picked from commit

[Stable-7.2.7 62/62] target/tricore: Rename tricore_feature

2023-11-19 Thread Michael Tokarev
From: Bastian Koppelmann this name is used by capstone and will lead to a build failure of QEMU, when capstone is enabled. So we rename it to tricore_has_feature(), to match has_feature() in translate.c. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1774 Signed-off-by: Bastian Koppelma

[Stable-8.1.3 v2 00/59] Patch Round-up for stable 8.1.3, frozen on 2023-11-19

2023-11-19 Thread Michael Tokarev
The following patches are queued for QEMU stable v8.1.3: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.1 Patch freeze is 2023-11-19 (frozen), and the release is planned for 2023-11-21: https://wiki.qemu.org/Planning/8.1 Please respond here or CC qemu-sta...@nongnu.org on any addi

[Stable-7.2.7 61/62] tracetool: avoid invalid escape in Python string

2023-11-19 Thread Michael Tokarev
From: Marc-André Lureau This is an error in Python 3.12; fix it by using a raw string literal. Cc: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Message-ID: <20231108105649.60453-1-marcandre.lur...@redhat.com> (cherry picked from commit

[Stable-8.1.3 59/59] hw/mips: LOONGSON3V depends on UNIMP device

2023-11-19 Thread Michael Tokarev
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Cc: qemu-sta...@nongnu.org Fixes: c76b409fef ("hw/mips: Add Loongson-3 machine support") Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20231107140615.3034763-1-marcandre.lur...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé (cherry

[Stable-8.1.3 55/59] target/riscv/kvm: improve 'init_multiext_cfg' error msg

2023-11-19 Thread Michael Tokarev
From: Daniel Henrique Barboza Our error message is returning the value of 'ret', which will be always -1 in case of error, and will not be that useful: qemu-system-riscv64: Unable to read ISA_EXT KVM register ssaia, error -1 Improve the error message by outputting 'errno' instead of 'ret'. Use

[Stable-8.1.3 58/59] target/arm: HVC at EL3 should go to EL3, not EL2

2023-11-19 Thread Michael Tokarev
From: Peter Maydell AArch64 permits code at EL3 to use the HVC instruction; however the exception we take should go to EL3, not down to EL2 (see the pseudocode AArch64.CallHypervisor()). Fix the target EL. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias M

[Stable-8.1.3 56/59] target/riscv/kvm: support KVM_GET_REG_LIST

2023-11-19 Thread Michael Tokarev
From: Daniel Henrique Barboza KVM for RISC-V started supporting KVM_GET_REG_LIST in Linux 6.6. It consists of a KVM ioctl() that retrieves a list of all available regs for get_one_reg/set_one_reg. Regs that aren't present in the list aren't supported in the host. This simplifies our lives when i

[Stable-8.1.3 57/59] s390x/pci: only limit DMA aperture if vfio DMA limit reported

2023-11-19 Thread Michael Tokarev
From: Matthew Rosato If the host kernel lacks vfio DMA limit reporting, do not attempt to shrink the guest DMA aperture. Fixes: df202e3ff3 ("s390x/pci: shrink DMA aperture to be bound by vfio DMA limit") Signed-off-by: Matthew Rosato Message-ID: <20231110175108.465851-3-mjros...@linux.ibm.com>

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-19 Thread Dan Hoffman
On Sun, Nov 19, 2023 at 1:23 AM Michael S. Tsirkin wrote: > > On Sat, Nov 18, 2023 at 10:25:31AM -0800, Daniel Hoffman wrote: > > `kvm_enabled()` is compiled down to `0` and short-circuit logic is > > used to remmove references to undefined symbols at the compile stage. > > Some build configuratio

[PATCH v4 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-19 Thread ankita
From: Ankit Agrawal ACPI spec provides a scheme to associate "Generic Initiators" [1] (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with integrated compute or DMA engines GPUs) with Proximity Domains. This is achieved using Generic Initiator Affinity Structure in SRAT. Du

[PATCH v4 1/2] qom: new object to associate device to numa node

2023-11-19 Thread ankita
From: Ankit Agrawal NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows partitioning of the GPU device resources (including device memory) into several (upto 8) isolated instances. Each of the partitioned memory needs a dedicated NUMA node to operate. The partitions are not fi

[PATCH v4 0/2] acpi: report numa nodes for device memory using GI

2023-11-19 Thread ankita
From: Ankit Agrawal There are upcoming devices which allow CPU to cache coherently access their memory. It is sensible to expose such memory as NUMA nodes separate from the sysmem node to the OS. The ACPI spec provides a scheme in SRAT called Generic Initiator Affinity Structure [1] to allow an a

[PATCH] configure: Make only once with pseudo-"in source tree" builds

2023-11-19 Thread Akihiko Odaki
Pseudo-"in source tree" build used to run make in the build directory as many times as goals. Worse, although .NOTPARALLEL is specified, it does not work for patterns, and run make in parallel, which can break things. Add a new rule "build", and let it call make. The pattern rule only needs to spe

[PATCH] audio: Free consumed default audio devices

2023-11-19 Thread Akihiko Odaki
Failed default audio devices were removed from the list but not freed, and that made LeakSanitizer sad. Free default audio devices as they are consumed. Signed-off-by: Akihiko Odaki --- audio/audio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/aud