Re: [PATCH v2 1/5] hw/display/virtio-gpu-virgl: virtio_gpu_gl -> virtio_gpu_virgl

2023-04-29 Thread Akihiko Odaki
On 2023/04/29 1:48, Gurchetan Singh wrote: From: Gurchetan Singh The virtio-gpu GL device has a heavy dependence on virgl. Acknowledge this by naming functions accurately. Signed-off-by: Gurchetan Singh Reviewed-by: Philippe Mathieu-Daudé --- v1: - (Philippe) virtio_gpu_virglrenderer_reset

Re: [PATCH v3 1/2] igb: RX descriptors handling cleanup

2023-04-29 Thread Akihiko Odaki
On 2023/04/28 21:51, Tomasz Dzieciol/VIM Integration (NC) /SRPOL/Engineer/Samsung Electronics wrote: Please don't ignore comments in reviews, and if you have a question with them or you don't agree with them, please write so in a reply. You don't have to post a new version quickly so take time

Re: [PULL 00/21] Migration 20230428 patches

2023-04-29 Thread Richard Henderson
nd cleanup decompression in migration.c (2023-04-28 20:54:53 +0200) Migration Pull request (20230429 vintage) Hi In this series: - compression code cleanup (lukas) nice, nice, nice. - drop useless parameters from migration_tls* (jua

Re: [PULL 00/17] Block patches

2023-04-29 Thread Richard Henderson
On 4/28/23 13:39, Stefan Hajnoczi wrote: The following changes since commit 05d50ba2d4668d43a835c5a502efdec9b92646e6: Merge tag 'migration-20230427-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-28 08:35:06 +0100) are available in the Git repository at: htt

Re: [PATCH v6 2/3] hw/sd/sdhci: Support big endian SD host controller interfaces

2023-04-29 Thread Guenter Roeck
On Sat, Apr 29, 2023 at 01:46:26PM -0700, Guenter Roeck wrote: > Hi, > > On Tue, Nov 01, 2022 at 11:29:33PM +0100, Philippe Mathieu-Daudé wrote: > > Some SDHCI IP can be synthetized in various endianness: > > https://github.com/u-boot/u-boot/blob/v2021.04/doc/README.fsl-esdhc > > > > - CONFIG_SY

Re: [PATCH v6 2/3] hw/sd/sdhci: Support big endian SD host controller interfaces

2023-04-29 Thread Guenter Roeck
Hi, On Tue, Nov 01, 2022 at 11:29:33PM +0100, Philippe Mathieu-Daudé wrote: > Some SDHCI IP can be synthetized in various endianness: > https://github.com/u-boot/u-boot/blob/v2021.04/doc/README.fsl-esdhc > > - CONFIG_SYS_FSL_ESDHC_BE > >ESDHC IP is in big-endian mode. Accessing ESDHC regist

Re: [PULL 00/21] Migration 20230428 patches

2023-04-29 Thread Lukas Straub
up to 05ecac612ec6a4bdb358e68554b4406ac2c8e25a: > > > >migration: Initialize and cleanup decompression in migration.c > > (2023-04-28 20:54:53 +0200) > > > > > > Migration Pull request (20230429

RE: [PATCH v2 0/9] Hexagon (target/hexagon) New architecture support

2023-04-29 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, April 28, 2023 4:45 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > > Subject: Re: [PATCH v2 0/9] Hexagon (target/hexagon) New arc

RE: [PATCH v2] target/hexagon: fix = vs. == mishap

2023-04-29 Thread Taylor Simpson
> -Original Message- > From: Peter Maydell > Sent: Saturday, April 29, 2023 4:27 AM > To: Taylor Simpson > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; > richard.hender...@linaro.org; phi...@linaro.org; a...@rev.ng; > a...@rev.ng; Brian Cain ; Matheus Bernardino (QUIC) > > Subject:

RE: [PATCH v2] target/hexagon: fix = vs. == mishap

2023-04-29 Thread Taylor Simpson
> -Original Message- > From: Paolo Bonzini > Sent: Saturday, April 29, 2023 7:24 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; phi...@linaro.org; a...@rev.ng; > a...@rev.ng; Brian Cain ; Matheus Bernardino (QUIC) > > Subject: Re: [PATCH v2] target/h

Re: [PULL 00/21] Migration 20230428 patches

2023-04-29 Thread Richard Henderson
4:53 +0200) Migration Pull request (20230429 vintage) Hi In this series: - compression code cleanup (lukas) nice, nice, nice. - drop useless parameters from migration_tls* (juan) - first part of remove QEMUFileHooks series (juan) Pl

Re: [PATCH v4 3/3] Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2023-04-29 Thread Maciej S. Szmigiero
On 29.04.2023 00:59, Philippe Mathieu-Daudé wrote: On 27/4/23 11:08, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and inserting pieces of extra RAM into it on demand fro

VNC clipboard support

2023-04-29 Thread octavef...@outlook.fr
Hello, I'm trying to use the copy/paste with VNC. I'm launching qemu with: $ qemu-system-x86_64 -hda debiandisk.img vnc :1 I'm using tightvncviewer which has support for copy/paste. I try to copy text between guest and host. It doesn't work. Neither from host to guest or guest to host. As fa

Re: [PATCH] tests/9p: fix potential leak in v9fs_rreaddir()

2023-04-29 Thread Christian Schoenebeck
On Saturday, April 29, 2023 2:04:30 PM CEST Greg Kurz wrote: > Hi Christian ! Hi there, it's been a while! :) > On Sat, 29 Apr 2023 11:25:33 +0200 > Christian Schoenebeck wrote: > > > Free allocated directory entries in v9fs_rreaddir() if argument > > `entries` was passed as NULL, to avoid a me

Re: [PATCH v3 06/57] tcg/i386: Generalize multi-part load overlap test

2023-04-29 Thread Philippe Mathieu-Daudé
On 24/4/23 07:40, Richard Henderson wrote: Test for both base and index; use datahi as a temporary, overwritten by the final load. Always perform the loads in ascending order, so that any (user-only) fault sees the correct address. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.i

Re: [PATCH v3] meson: Pass -j option to sphinx

2023-04-29 Thread Paolo Bonzini
On 4/28/23 17:01, Fabiano Rosas wrote: Also make sure our plugins support parallelism and report it properly to sphinx. Particularly, implement the merge_domaindata method in DBusDomain that is used to merge in data from other subprocesses. before: $ time make man html ... [1/2] Generat

Re: [PATCH v3 54/57] tcg/ppc: Remove unused constraints A, B, C, D

2023-04-29 Thread Philippe Mathieu-Daudé
On 24/4/23 07:41, Richard Henderson wrote: These constraints have not been used for quite some time. Fixes: 77b73de67632 ("Use rem/div[u]_i32 drop div[u]2_i32") Reviewed-by: Daniel Henrique Barboza Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target-con-str.h | 4 1 file changed, 4

Re: [PATCH v3 0/2] accel/tcg/tcg-accel-ops-rr: ensure fairness with icount

2023-04-29 Thread Philippe Mathieu-Daudé
On 29/4/23 11:28, Richard Henderson wrote: On 4/27/23 03:09, Jamie Iles wrote: From: Jamie Iles The round-robin scheduler will iterate over the CPU list with an assigned budget until the next timer expiry and may exit early because of a TB exit.  This is fine under normal operation but with ic

Re: [PATCH v2] target/hexagon: fix = vs. == mishap

2023-04-29 Thread Paolo Bonzini
On 4/28/23 22:44, Taylor Simpson wrote: From: Paolo Bonzini Changes in v2 Fix yyassert's for sign and zero extends Coverity reports a parameter that is "set but never used". This is caused by an assignment operator being used instead of equality. Co-authored-by: Taylor Simpson Tha

[PULL v2 00/16] Misc patches for 2023-04-29

2023-04-29 Thread Paolo Bonzini
The following changes since commit 05d50ba2d4668d43a835c5a502efdec9b92646e6: Merge tag 'migration-20230427-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-28 08:35:06 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-ups

[PULL 10/17] target/i386: Add support for PREFETCHIT0/1 in CPUID enumeration

2023-04-29 Thread Paolo Bonzini
From: Jiaxi Chen Latest Intel platform Granite Rapids has introduced a new instruction - PREFETCHIT0/1, which moves code to memory (cache) closer to the processor depending on specific hints. The bit definition: CPUID.(EAX=7,ECX=1):EDX[bit 14] Add CPUID definition for PREFETCHIT0/1. Signed-off

[PULL 11/17] Fix libvhost-user.c compilation.

2023-04-29 Thread Paolo Bonzini
From: David 'Digit' Turner The source file uses VIRTIO_F_VERSION_1 which is not defined by on Debian 10. The system-provided which does not include the macro definition is included through , so fix the issue by including the standard-headers version before that. Signed-off-by: David 'Digit' T

[PULL 06/17] target/i386: Add support for AMX-FP16 in CPUID enumeration

2023-04-29 Thread Paolo Bonzini
From: Jiaxi Chen Latest Intel platform Granite Rapids has introduced a new instruction - AMX-FP16, which performs dot-products of two FP16 tiles and accumulates the results into a packed single precision tile. AMX-FP16 adds FP16 capability and allows a FP16 GPU trained model to run faster without

[PULL 05/17] target/i386: Add support for CMPCCXADD in CPUID enumeration

2023-04-29 Thread Paolo Bonzini
From: Jiaxi Chen CMPccXADD is a new set of instructions in the latest Intel platform Sierra Forest. This new instruction set includes a semaphore operation that can compare and add the operands if condition is met, which can improve database performance. The bit definition: CPUID.(EAX=7,ECX=1):E

[PULL 09/17] target/i386: Add support for AVX-NE-CONVERT in CPUID enumeration

2023-04-29 Thread Paolo Bonzini
From: Jiaxi Chen AVX-NE-CONVERT is a new set of instructions which can convert low precision floating point like BF16/FP16 to high precision floating point FP32, as well as convert FP32 elements to BF16. This instruction allows the platform to have improved AI capabilities and better compatibilit

[PULL 17/17] cpus-common: stop using mb_set/mb_read

2023-04-29 Thread Paolo Bonzini
Use a store-release at the end of the work item, and a load-acquire when waiting for the item to be completed. This is the standard message passing pattern and is both enough and clearer than mb_read/mb_set. Signed-off-by: Paolo Bonzini --- cpus-common.c | 4 ++-- 1 file changed, 2 insertions(+

[PULL 13/17] Update linux headers to v6.3rc5

2023-04-29 Thread Paolo Bonzini
From: David 'Digit' Turner commit 7e364e56293bb98cae1b55fd835f5991c4e96e7d Signed-off-by: David 'Digit' Turner Message-Id: <20230405172109.3081788-4-di...@google.com> Signed-off-by: Paolo Bonzini --- include/standard-headers/drm/drm_fourcc.h| 12 ++ include/standard-headers/linux/ethtool

[PULL 15/17] target/hexagon: fix = vs. == mishap

2023-04-29 Thread Paolo Bonzini
Coverity reports a parameter that is "set but never used". This is caused by an assignment operator being used instead of equality. Cc: Taylor Simpson Signed-off-by: Paolo Bonzini --- target/hexagon/idef-parser/parser-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 14/17] tests: vhost-user-test: release mutex on protocol violation

2023-04-29 Thread Paolo Bonzini
chr_read() is printing an error message and returning with s->data_mutex taken. This can potentially cause a hang. Reported by Coverity. Signed-off-by: Paolo Bonzini --- tests/qtest/vhost-user-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-te

[PULL 12/17] update-linux-headers.sh: Add missing kernel headers.

2023-04-29 Thread Paolo Bonzini
From: David 'Digit' Turner Add , used by hw/display/virtio-gpu-udmabuf.c Add , used by qga/commands-posix.c Add used by kvm-all.c, which requires the _BITUL() macro definition to be available. Without these, QEMU will not compile on Debian 10 systems. Signed-off-by: David 'Digit' Turner Messa

[PULL 16/17] async: Suppress GCC13 false positive in aio_bh_poll()

2023-04-29 Thread Paolo Bonzini
From: Cédric Le Goater GCC13 reports an error : ../util/async.c: In function ‘aio_bh_poll’: include/qemu/queue.h:303:22: error: storing the address of local variable ‘slice’ in ‘*ctx.bh_slice_list.sqh_last’ [-Werror=dangling-pointer=] 303 | (head)->sqh_last = &(elm)->field.sqe_next;

[PULL 04/17] i386/cpu: Update how the EBX register of CPUID 0x8000001F is set

2023-04-29 Thread Paolo Bonzini
From: Tom Lendacky Update the setting of CPUID 0x801F EBX to clearly document the ranges associated with fields being set. Fixes: 6cb8f2a663 ("cpu/i386: populate CPUID 0x8000_001F when SEV is active") Signed-off-by: Tom Lendacky Reviewed-by: Dr. David Alan Gilbert Message-Id: <5822fd7d02b

[PULL 03/17] i386/sev: Update checks and information related to reduced-phys-bits

2023-04-29 Thread Paolo Bonzini
From: Tom Lendacky The value of the reduced-phys-bits parameter is propogated to the CPUID information exposed to the guest. Update the current validation check to account for the size of the CPUID field (6-bits), ensuring the value is in the range of 1 to 63. Maintain backward compatibility, to

[PULL 07/17] target/i386: Add support for AVX-IFMA in CPUID enumeration

2023-04-29 Thread Paolo Bonzini
From: Jiaxi Chen AVX-IFMA is a new instruction in the latest Intel platform Sierra Forest. This instruction packed multiplies unsigned 52-bit integers and adds the low/high 52-bit products to Qword Accumulators. The bit definition: CPUID.(EAX=7,ECX=1):EAX[bit 23] Add CPUID definition for AVX-IF

[PULL 00/17] Misc patches for 2023-04-29

2023-04-29 Thread Paolo Bonzini
The following changes since commit 05d50ba2d4668d43a835c5a502efdec9b92646e6: Merge tag 'migration-20230427-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-28 08:35:06 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-ups

[PULL 02/17] qemu-options.hx: Update the reduced-phys-bits documentation

2023-04-29 Thread Paolo Bonzini
From: Tom Lendacky A guest only ever experiences, at most, 1 bit of reduced physical addressing. Update the documentation to reflect this as well as change the example value on the reduced-phys-bits option. Fixes: a9b4942f48 ("target/i386: add Secure Encrypted Virtualization (SEV) object") Sign

[PULL 08/17] target/i386: Add support for AVX-VNNI-INT8 in CPUID enumeration

2023-04-29 Thread Paolo Bonzini
From: Jiaxi Chen AVX-VNNI-INT8 is a new set of instructions in the latest Intel platform Sierra Forest, aims for the platform to have superior AI capabilities. This instruction multiplies the individual bytes of two unsigned or unsigned source operands, then adds and accumulates the results into

[PULL 01/17] qapi, i386/sev: Change the reduced-phys-bits value from 5 to 1

2023-04-29 Thread Paolo Bonzini
From: Tom Lendacky A guest only ever experiences, at most, 1 bit of reduced physical addressing. Change the query-sev-capabilities json comment to use 1. Fixes: 31dd67f684 ("sev/i386: qmp: add query-sev-capabilities command") Signed-off-by: Tom Lendacky Reviewed-by: Dr. David Alan Gilbert Mess

Re: [PATCH] hw/remote: Fix vfu_cfg trace offset format

2023-04-29 Thread Philippe Mathieu-Daudé
On 26/4/23 11:35, Mattias Nissler wrote: The printed offset value is prefixed with 0x, but was actually printed in decimal. To spare others the confusion, adjust the format specifier to hexadecimal. Signed-off-by: Mattias Nissler --- hw/remote/trace-events | 4 ++-- 1 file changed, 2 inserti

Re: [PATCH 1/9] hw/ide/ahci: remove stray backslash

2023-04-29 Thread Philippe Mathieu-Daudé
On 28/4/23 15:21, Niklas Cassel wrote: From: Niklas Cassel This backslash obviously does not belong here, so remove it. Signed-off-by: Niklas Cassel --- hw/ide/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/nvram: Avoid unnecessary Xilinx eFuse backstore write

2023-04-29 Thread Philippe Mathieu-Daudé
On 26/4/23 23:16, Tong Ho wrote: Add a check in the bit-set operation to write the backstore only if the affected bit is 0 before. With this in place, there will be no need for callers to do the checking in order to avoid unnecessary writes. Signed-off-by: Tong Ho --- hw/nvram/xlnx-efuse.c |

Re: [PATCH 06/21] Hexagon (target/hexagon) Remove log_reg_write from op_helper.[ch]

2023-04-29 Thread Philippe Mathieu-Daudé
On 26/4/23 02:41, Taylor Simpson wrote: With the overrides added in prior commits, this function is not used Remove references in macros.h Signed-off-by: Taylor Simpson --- target/hexagon/macros.h| 14 -- target/hexagon/op_helper.h | 4 target/hexagon/op_helper.c | 17

Re: [PATCH v3 1/2] cpu: expose qemu_cpu_list_lock for lock-guard use

2023-04-29 Thread Philippe Mathieu-Daudé
On 27/4/23 04:09, Jamie Iles wrote: Expose qemu_cpu_list_lock globally so that we can use WITH_QEMU_LOCK_GUARD and QEMU_LOCK_GUARD to simplify a few code paths now and in future. Signed-off-by: Jamie Iles --- cpus-common.c | 2 +- include/exec/cpu-common.h | 1 + linux-user/el

Re: [PATCH] tests/9p: fix potential leak in v9fs_rreaddir()

2023-04-29 Thread Greg Kurz
Hi Christian ! On Sat, 29 Apr 2023 11:25:33 +0200 Christian Schoenebeck wrote: > Free allocated directory entries in v9fs_rreaddir() if argument > `entries` was passed as NULL, to avoid a memory leak. It is > explicitly allowed by design for `entries` to be NULL. [1] > > [1] https://lore.kernel

[PATCH] tests/9p: fix potential leak in v9fs_rreaddir()

2023-04-29 Thread Christian Schoenebeck
Free allocated directory entries in v9fs_rreaddir() if argument `entries` was passed as NULL, to avoid a memory leak. It is explicitly allowed by design for `entries` to be NULL. [1] [1] https://lore.kernel.org/all/1690923.g4PEXVpXuU@silver Reported-by: Coverity (CID 1487558) Signed-off-by: Chris

Re: [PATCH] test-aio-multithread: do not use mb_read/mb_set for simple flags

2023-04-29 Thread Richard Henderson
On 4/28/23 12:12, Paolo Bonzini wrote: The remaining use of mb_read/mb_set is just to force a thread to exit eventually. It does not order two memory accesses and therefore can be just read/set. Signed-off-by: Paolo Bonzini --- tests/unit/test-aio-multithread.c | 12 ++-- 1 file chan

Re: [PATCH] rcu: remove qatomic_mb_set, expand comments

2023-04-29 Thread Richard Henderson
On 4/28/23 11:50, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- include/qemu/rcu.h | 5 - util/rcu.c | 24 +++- 2 files changed, 15 insertions(+), 14 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 0/2] accel/tcg/tcg-accel-ops-rr: ensure fairness with icount

2023-04-29 Thread Richard Henderson
On 4/27/23 03:09, Jamie Iles wrote: From: Jamie Iles The round-robin scheduler will iterate over the CPU list with an assigned budget until the next timer expiry and may exit early because of a TB exit. This is fine under normal operation but with icount enabled and SMP it is possible for a CP

Re: [PATCH v2] target/hexagon: fix = vs. == mishap

2023-04-29 Thread Peter Maydell
On Fri, 28 Apr 2023 at 21:45, Taylor Simpson wrote: > > From: Paolo Bonzini > > Changes in v2 > Fix yyassert's for sign and zero extends > > Coverity reports a parameter that is "set but never used". This is caused > by an assignment operator being used instead of equality. The commit

Re: [PATCH v3 2/4] target/riscv: Reuse tb->flags.FS

2023-04-29 Thread Weiwei Li
On 2023/4/29 16:54, Richard Henderson wrote: On 4/28/23 17:52, Mayuresh Chitale wrote: When misa.F is 0 tb->flags.FS field is unused and can be used to save the current state of smstateen0.FCSR check which is needed by the floating point translation routines. Signed-off-by: Mayuresh Chitale

Re: [PULL 00/17] QAPI patches patches for 2023-04-28

2023-04-29 Thread Richard Henderson
On 4/28/23 11:28, Markus Armbruster wrote: The following changes since commit cc5ee50fff9dbac0aac32cd892a7163c7babcca1: Merge tag 'pull-testing-docs-270423-1' ofhttps://gitlab.com/stsquad/qemu into staging (2023-04-27 16:46:17 +0100) are available in the Git repository at: https://repo

Re: [PATCH v3 2/4] target/riscv: Reuse tb->flags.FS

2023-04-29 Thread Richard Henderson
On 4/28/23 17:52, Mayuresh Chitale wrote: When misa.F is 0 tb->flags.FS field is unused and can be used to save the current state of smstateen0.FCSR check which is needed by the floating point translation routines. Signed-off-by: Mayuresh Chitale --- target/riscv/cpu_helper.c | 9 +