Re: [RFC PATCH v1 0/2] vhost-vdpa: cache Virtio states

2023-04-21 Thread Shao-Chien Chiang
Hi, I found a problem about cache. If there are several devices operating the same backend device, the cache might be inconsistent. I think we could handle this by checking if a device is the first device, but I'm not sure it will be feasible. Is there any better approach to this problem? Than

Re: [PATCH 30/40] igb: Implement igb-specific oversize check

2023-04-21 Thread Akihiko Odaki
On 2023/04/16 20:22, Sriram Yagnaraman wrote: -Original Message- From: Akihiko Odaki Sent: Friday, 14 April 2023 13:37 Cc: Sriram Yagnaraman ; Jason Wang ; Dmitry Fleytman ; Michael S. Tsirkin ; Alex Bennée ; Philippe Mathieu-Daudé ; Thomas Huth ; Wainer dos Santos Moschetta ; Beraldo

Re: [PULL 00/20] Migration 20230420 patches

2023-04-21 Thread Richard Henderson
On 4/20/23 14:17, Juan Quintela wrote: The following changes since commit 2d82c32b2ceaca3dc3da5e36e10976f34bfcb598: Open 8.1 development tree (2023-04-20 10:05:25 +0100) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20230420-pull-reque

Re: [PULL 0/7] Merge tpm 2023/04/20 v1

2023-04-21 Thread Richard Henderson
On 4/20/23 13:32, Stefan Berger wrote: Hello! This series provides TPM I2C device model support along with test cases. Regards, Stefan The following changes since commit 2d82c32b2ceaca3dc3da5e36e10976f34bfcb598: Open 8.1 development tree (2023-04-20 10:05:25 +0100) are available in

[PATCH 1/2] tests/tcg/multiarch: Make the system memory test work on big-endian

2023-04-21 Thread Ilya Leoshkevich
Make sure values are stored in memory as little-endian regardless of the host endianness. Signed-off-by: Ilya Leoshkevich --- tests/tcg/multiarch/system/memory.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiar

[PATCH 2/2] tests/tcg/s390x: Enable the multiarch system tests

2023-04-21 Thread Ilya Leoshkevich
Multiarch tests are written in C and need support for printing characters. Instead of implementing the runtime from scratch, just reuse the pc-bios/s390-ccw one. Run tests with -nographic in order to enable SCLP (enable this for the existing tests as well, since it does not hurt). Use the default

[PATCH 0/2] tests/tcg/s390x: Enable the multiarch system tests

2023-04-21 Thread Ilya Leoshkevich
Hi, I noticed that Alex added "undefine MULTIARCH_TESTS" to tests/tcg/s390x/Makefile.softmmu-target in the plugin patch, and thought that it may better to just enable them, which this series does. Patch 1 fixes an endianness issue in the memory test. Patch 2 enables the multiarch system test. Th

Re: [RFC PATCH 00/13] gfxstream + rutabaga_gfx: a surprising delight or startling epiphany?

2023-04-21 Thread Gurchetan Singh
On Fri, Apr 21, 2023 at 9:02 AM Stefan Hajnoczi wrote: > > On Thu, 20 Apr 2023 at 21:13, Gurchetan Singh > wrote: > > > > From: Gurchetan Singh > > > > Rationale: > > > > - gfxstream [a] is good for the Android Emulator/upstream QEMU > > alignment > > - Wayland passhthrough [b] via the cross-d

Re: [RFC PATCH 13/13] HACK: schedule fence return on main AIO context

2023-04-21 Thread Gurchetan Singh
On Fri, Apr 21, 2023 at 9:00 AM Stefan Hajnoczi wrote: > > On Thu, 20 Apr 2023 at 21:13, Gurchetan Singh > wrote: > > > > gfxstream and both cross-domain (and even newer versions > > virglrenderer: see VIRGL_RENDERER_ASYNC_FENCE_CB) like to signal > > fence completion on threads ("callback thread

Re: [PATCH v2 17/54] tcg: Introduce tcg_out_xchg

2023-04-21 Thread Philippe Mathieu-Daudé
On 22/4/23 01:05, Philippe Mathieu-Daudé wrote: On 11/4/23 03:04, Richard Henderson wrote: We will want a backend interface for register swapping. This is only properly defined for x86; all others get a stub version that always indicates failure. Signed-off-by: Richard Henderson ---   tcg/tcg.

Re: [PATCH v2 17/54] tcg: Introduce tcg_out_xchg

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will want a backend interface for register swapping. This is only properly defined for x86; all others get a stub version that always indicates failure. Signed-off-by: Richard Henderson --- tcg/tcg.c| 2 ++ tcg/aarch64/tcg

Re: [PATCH v2 16/54] tcg: Introduce tcg_out_movext

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: This is common code in most qemu_{ld,st} slow paths, extending the input value for the store helper data argument or extending the return value from the load helper. Signed-off-by: Richard Henderson --- tcg/tcg.c| 63 +

Re: [PATCH v2 15/54] tcg: Split out tcg_out_extrl_i64_i32

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for type truncation. For those backends that did not enable TCG_TARGET_HAS_extrl_i64_i32, use tcg_out_mov. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c

Re: [PATCH v2 13/54] tcg: Split out tcg_out_extu_i32_i64

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for type extension with zero. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 4 tcg/aarch64/tcg-target.c.inc | 10 ++ tcg/arm/tc

Re: [PATCH v4 11/11] Signed-off-by: Karim Taha

2023-04-21 Thread Warner Losh
Oh, I see you've uploaded an improved version of the patches, with the fixes I'd recommended. I'll queue that series instead. Warner On Fri, Apr 21, 2023 at 10:58 AM Karim Taha wrote: > From: Warner Losh > > Add the dispatching code of bind(2),connect(2), accpet(2), getpeername(2). > > Add the

Re: [PATCH v2 09/54] tcg: Split out tcg_out_exts_i32_i64

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for type extension with sign. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 4 tcg/aarch64/tcg-target.c.inc | 9 ++--- tcg/arm/tcg-t

Re: [PATCH v3 01/11] Signed-off-by: Karim Taha

2023-04-21 Thread Warner Losh
On Fri, Apr 21, 2023 at 10:42 AM Karim Taha wrote: > From: Warner Losh > > Intialize guest_base in bsd-user/main.c. > > Allow guest_base to be initialized on 64-bit hosts, the initial value is > used by g2h_untagged function defined in include/exec/cpu_ldst.h > > Signed-off-by: Karim Taha > Th

Re: [PATCH v2 07/54] tcg: Split out tcg_out_ext32s

2023-04-21 Thread Philippe Mathieu-Daudé
On 22/4/23 00:38, Philippe Mathieu-Daudé wrote: On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 32-bit sign-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson ---   tcg/tcg.c    |  4   tcg/aar

Re: [PATCH 01/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
It was sent with git-publish, what do you mean by pointing to a branch? On Fri, Apr 21, 2023 at 7:22 PM Alex Bennée wrote: > > Karim Taha writes: > > > On Fri, Apr 21, 2023 at 9:17 AM Daniel P. Berrangé > wrote: > > > > On Fri, Apr 21, 2023 at 07:22:45AM +0200, Karim Taha wrote: > > > From:

Re: [PATCH v2 08/54] tcg: Split out tcg_out_ext32u

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 32-bit zero-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 4 tcg/aarch64/tcg-target.c.inc | 9 +++-- tcg/ar

Re: [PATCH v2 07/54] tcg: Split out tcg_out_ext32s

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 32-bit sign-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 4 tcg/aarch64/tcg-target.c.inc | 9 +++-- tcg/ar

Re: [PATCH v2 31/54] tcg: Move TCGLabelQemuLdst to tcg.c

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: This will shortly be used by sparc64 without also using TCG_TARGET_NEED_LDST_LABELS. Is that in this series? Signed-off-by: Richard Henderson --- tcg/tcg.c | 13 + tcg/tcg-ldst.c.inc | 14 -- 2 files changed, 13

Re: [PATCH v2 30/54] tcg/sparc64: Pass TCGType to tcg_out_qemu_{ld,st}

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We need to set this in TCGLabelQemuLdst, so plumb this all the way through from tcg_out_op. Signed-off-by: Richard Henderson --- tcg/sparc64/tcg-target.c.inc | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Philip

Re: [PATCH v2 29/54] tcg/sparc64: Drop is_64 test from tcg_out_qemu_ld data return

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: In tcg_canonicalize_memop, we remove MO_SIGN from MO_32 operations with TCG_TYPE_I32. Thus this is never set. We already have an identical test just above which does not include is_64 Signed-off-by: Richard Henderson --- tcg/sparc64/tcg-target.c.in

Re: [PATCH v2 19/54] tcg: Clear TCGLabelQemuLdst on allocation

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/tcg-ldst.c.inc | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 21/54] tcg/aarch64: Rationalize args to tcg_out_qemu_{ld, st}

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: Mark the argument registers const, because they must be passed to add_qemu_ldst_label unmodified. Rename the 'ext' parameter 'data_type' to make the use clearer; pass it to tcg_out_qemu_st as well to even out the interfaces. Rename the 'otype' local 'a

Re: [PATCH v2 5/6] tests/qtest: massively speed up migration-tet

2023-04-21 Thread Juan Quintela
Daniel P. Berrangé wrote: > The migration test cases that actually exercise live migration want to > ensure there is a minimum of two iterations of pre-copy, in order to > exercise the dirty tracking code. > > Historically we've queried the migration status, looking for the > 'dirty-sync-count' va

Re: [PATCH v2 26/54] tcg/s390x: Pass TCGType to tcg_out_qemu_{ld,st}

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We need to set this in TCGLabelQemuLdst, so plumb this all the way through from tcg_out_op. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) @@ -1916,7

Re: [PATCH v2 01/54] tcg: Replace if + tcg_abort with tcg_debug_assert

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 +--- tcg/i386/tcg-target.c.inc | 8 +++- 2 files changed, 4 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 06/54] tcg: Split out tcg_out_ext16u

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 16-bit zero-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 5 + tcg/aarch64/tcg-target.c.inc | 13 - t

Re: [PATCH v2 05/54] tcg: Split out tcg_out_ext16s

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 16-bit sign-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 7 +++ tcg/aarch64/tcg-target.c.inc | 13 -

Re: [PATCH v2 04/54] tcg: Split out tcg_out_ext8u

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 8-bit zero-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 5 + tcg/aarch64/tcg-target.c.inc | 11 +++ tcg/

Re: [PATCH v2 03/54] tcg: Split out tcg_out_ext8s

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: We will need a backend interface for performing 8-bit sign-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 21 - tcg/aarch64/tcg-target.c.inc | 11 ++

Re: [PATCH v2 02/54] tcg: Replace tcg_abort with g_assert_not_reached

2023-04-21 Thread Philippe Mathieu-Daudé
On 11/4/23 03:04, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg.h| 6 -- target/i386/tcg/translate.c | 20 ++-- target/s390x/tcg/translate.c | 4 ++-- tcg/optimize.c | 10 -- tcg/tcg.c

Re: [PATCH v2 4/6] tests/qtest: make more migration pre-copy scenarios run non-live

2023-04-21 Thread Juan Quintela
Daniel P. Berrangé wrote: > There are 27 pre-copy live migration scenarios being tested. In all of > these we force non-convergance and run for one iteration, then let it > converge and wait for completion during the second (or following) > iterations. At 3 mbps bandwidth limit the first iteration

Re: [PATCH 06/42] tcg: Split out tcg_out_ext16u

2023-04-21 Thread Philippe Mathieu-Daudé
On 8/4/23 04:42, Richard Henderson wrote: We will need a backend interface for performing 16-bit zero-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 5 + tcg/aarch64/tcg-target.c.inc | 13 - tc

Re: [PATCH v2 3/6] tests/qtest: capture RESUME events during migration

2023-04-21 Thread Juan Quintela
Daniel P. Berrangé wrote: > When running migration tests we monitor for a STOP event so we can skip > redundant waits. This will be needed for the RESUME event too shortly. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela i.e. it is better that what we have now. But > diff -

Re: [PATCH v2 2/6] tests/qtests: remove migration test iterations config

2023-04-21 Thread Juan Quintela
Daniel P. Berrangé wrote: > The 'unsigned int interations' config for migration is somewhat > overkill. Most tests don't set it, and a value of '0' is treated > as equivalent to '1'. The only test that does set it, xbzrle, > used a value of '2'. > > This setting, however, only relates to the migra

Re: [PATCH 05/42] tcg: Split out tcg_out_ext16s

2023-04-21 Thread Philippe Mathieu-Daudé
On 8/4/23 04:42, Richard Henderson wrote: We will need a backend interface for performing 16-bit sign-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 7 +++ tcg/aarch64/tcg-target.c.inc | 13 -

Re: [PATCH v2 1/6] tests/qtest: replace qmp_discard_response with qtest_qmp_assert_success

2023-04-21 Thread Juan Quintela
Daniel P. Berrangé wrote: > The qmp_discard_response method simply ignores the result of the QMP > command, merely unref'ing the object. This is a bad idea for tests > as it leaves no trace if the QMP command unexpectedly failed. The > qtest_qmp_assert_success method will validate that the QMP com

Re: [PATCH 04/42] tcg: Split out tcg_out_ext8u

2023-04-21 Thread Philippe Mathieu-Daudé
On 8/4/23 04:42, Richard Henderson wrote: We will need a backend interface for performing 8-bit zero-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 5 + tcg/aarch64/tcg-target.c.inc | 11 +++ tcg/a

[PATCH v3 0/3] ACPI: i386: bump MADT to revision 5

2023-04-21 Thread Eric DeVolder
The following Linux kernel change broke CPU hotplug for MADT revision less than 5. e2869bd7af60 ("x86/acpi/boot: Do not register processors that cannot be onlined for x2APIC") Discussion on this topic can be located here: https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devol...

[PATCH v3 1/3] ACPI: bios-tables-test.c step 2 (allowed-diff entries)

2023-04-21 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this change sets-up bios-tables-test-allowed-diff.h to exclude the imminent changes to the APIC tables, per step 2. Signed-off-by: Eric DeVolder --- tests/qtest/bios-tables-test-allowed-diff.h | 4 1 file changed, 4 insertions(+)

[PATCH v3 2/3] ACPI: i386: bump MADT to revision 5

2023-04-21 Thread Eric DeVolder
Currently i386 QEMU generates MADT revision 3, and reports MADT revision 1. ACPI 6.3 introduces MADT revision 5. For MADT revision 4, that introduces ARM GIC structures, which do not apply to i386. For MADT revision 5, the Local APIC flags introduces the Online Capable bitfield. Making MADT gene

[PATCH v3 3/3] ACPI: bios-tables-test.c step 5 (updated expected table binaries)

2023-04-21 Thread Eric DeVolder
Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6. For the cpuhp test case, it is started with: -smp 2,cores=3,sockets=2,maxcpus=6 So two of six CPUs are present, leaving 4 hot-pluggable CPUs. This is what the disassembly diff below shows (two entries with Enabled=1 and

Re: [PATCH 03/42] tcg: Split out tcg_out_ext8s

2023-04-21 Thread Philippe Mathieu-Daudé
On 8/4/23 04:42, Richard Henderson wrote: We will need a backend interface for performing 8-bit sign-extend. Use it in tcg_reg_alloc_op in the meantime. Signed-off-by: Richard Henderson --- tcg/tcg.c| 21 - tcg/aarch64/tcg-target.c.inc | 11 +++

Re: [PATCH] hw/riscv: virt: Enable booting M-mode or S-mode FW from pflash0

2023-04-21 Thread Philippe Mathieu-Daudé
On 21/4/23 18:48, Andrea Bolognani wrote: On Fri, Apr 21, 2023 at 04:36:15PM +0200, Heinrich Schuchardt wrote: On 4/21/23 06:33, Sunil V L wrote: Currently, virt machine supports two pflash instances each with 32MB size. However, the first pflash is always assumed to contain M-mode firmware and

Re: [PULL 00/20] Block patches

2023-04-21 Thread Richard Henderson
On 4/20/23 13:09, Stefan Hajnoczi wrote: The following changes since commit c1eb2ddf0f8075faddc5f7c3d39feae3e8e9d6b4: Update version for v8.0.0 release (2023-04-19 17:27:13 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for yo

Re: [PATCH v10 06/11] target/arm: move cpu_tcg to tcg/cpu32.c

2023-04-21 Thread Philippe Mathieu-Daudé
On 12/4/23 14:18, Fabiano Rosas wrote: From: Claudio Fontana move the module containing cpu models definitions for 32bit TCG-only CPUs to tcg/ and rename it for clarity. Signed-off-by: Claudio Fontana Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Acked-by: Thomas Huth --- h

Re: [PATCH] target/riscv: Fix PMU node property for virt machine

2023-04-21 Thread Conor Dooley
On Fri, Apr 21, 2023 at 09:14:37PM +0800, Yu Chien Peter Lin wrote: > The length of fdt_event_ctr_map[20] will add 5 dummy cells in > "riscv,event-to-mhpmcounters" property, so directly initialize > the array without an explicit size. > > This patch also fixes the typo of PMU cache operation resul

Re: [PATCH v10 04/11] target/arm: Do not expose all -cpu max features to qtests

2023-04-21 Thread Philippe Mathieu-Daudé
On 12/4/23 14:18, Fabiano Rosas wrote: We're about to move the TCG-only -cpu max configuration code under CONFIG_TCG. To be able to do that we need to make sure the qtests still have some cpu configured even when no other accelerator is available. Delineate now what is used with TCG-only and wha

Re: [PATCH v10 03/11] target/arm: Extract TCG -cpu max code into a function

2023-04-21 Thread Philippe Mathieu-Daudé
On 12/4/23 14:18, Fabiano Rosas wrote: Introduce aarch64_max_tcg_initfn that contains the TCG-only part of -cpu max configuration. We'll need that to be able to restrict this code to a TCG-only config in the next patches. Signed-off-by: Fabiano Rosas --- target/arm/cpu64.c | 32 ++

Re: [PATCH v10 02/11] target/arm: Remove dead code from cpu_max_set_sve_max_vq

2023-04-21 Thread Philippe Mathieu-Daudé
On 12/4/23 14:18, Fabiano Rosas wrote: The sve-max-vq property has been removed from the -cpu max used with KVM, so code under kvm_enabled in cpu_max_set_sve_max_vq is not reachable. Fixes: 0baa21be49 ("target/arm: Make KVM -cpu max exactly like -cpu host") Signed-off-by: Fabiano Rosas --- ta

Re: [PATCH v4 5/6] hw/cxl: Add poison injection via the mailbox.

2023-04-21 Thread Jonathan Cameron via
On Tue, 14 Mar 2023 07:27:52 +0100 Philippe Mathieu-Daudé wrote: > On 3/3/23 16:09, Jonathan Cameron wrote: > > Very simple implementation to allow testing of corresponding > > kernel code. Note that for now we track each 64 byte section > > independently. Whilst a valid implementation choice, i

Re: [PULL 00/23] First batch of testing and misc patches for 8.1

2023-04-21 Thread Richard Henderson
On 4/20/23 11:11, Thomas Huth wrote: Hi! The following changes since commit c1eb2ddf0f8075faddc5f7c3d39feae3e8e9d6b4: Update version for v8.0.0 release (2023-04-19 17:27:13 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023-04-20 f

Re: [PATCH 1/2] tests/migration: Make precopy fast

2023-04-21 Thread Daniel P . Berrangé
On Tue, Apr 18, 2023 at 02:20:27PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Apr 12, 2023 at 04:20:00PM +0200, Juan Quintela wrote: > >> Otherwise we do the 1st migration iteration at a too slow speed. > >> > >> Signed-off-by: Juan Quintela > >> --- > >> tests/qtest/mi

Re: [PATCH 01/11] Signed-off-by: Karim Taha

2023-04-21 Thread Alex Bennée
Karim Taha writes: > On Fri, Apr 21, 2023 at 9:17 AM Daniel P. Berrangé > wrote: > > On Fri, Apr 21, 2023 at 07:22:45AM +0200, Karim Taha wrote: > > From: Warner Losh > > > > Allow guest_base to be initialized on 64-bit hosts, the initial value is > used by g2h_untagged function > def

Re: [PATCH 2/2] tests/qtest: make more migration pre-copy scenarios run non-live

2023-04-21 Thread Daniel P . Berrangé
On Tue, Apr 18, 2023 at 04:52:32PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > There are 27 pre-copy live migration scenarios being tested. In all of > > these we force non-convergance and run for one iteration, then let it > > converge and wait for completion during the second

[PATCH v2 4/6] tests/qtest: make more migration pre-copy scenarios run non-live

2023-04-21 Thread Daniel P . Berrangé
There are 27 pre-copy live migration scenarios being tested. In all of these we force non-convergance and run for one iteration, then let it converge and wait for completion during the second (or following) iterations. At 3 mbps bandwidth limit the first iteration takes a very long time (~30 second

[PATCH v2 3/6] tests/qtest: capture RESUME events during migration

2023-04-21 Thread Daniel P . Berrangé
When running migration tests we monitor for a STOP event so we can skip redundant waits. This will be needed for the RESUME event too shortly. Signed-off-by: Daniel P. Berrangé --- tests/qtest/migration-helpers.c | 12 +--- tests/qtest/migration-helpers.h | 1 + tests/qtest/migration-te

[PATCH v2 1/6] tests/qtest: replace qmp_discard_response with qtest_qmp_assert_success

2023-04-21 Thread Daniel P . Berrangé
The qmp_discard_response method simply ignores the result of the QMP command, merely unref'ing the object. This is a bad idea for tests as it leaves no trace if the QMP command unexpectedly failed. The qtest_qmp_assert_success method will validate that the QMP command returned without error, and if

[PATCH v2 5/6] tests/qtest: massively speed up migration-tet

2023-04-21 Thread Daniel P . Berrangé
The migration test cases that actually exercise live migration want to ensure there is a minimum of two iterations of pre-copy, in order to exercise the dirty tracking code. Historically we've queried the migration status, looking for the 'dirty-sync-count' value to increment to track iterations.

[PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-21 Thread Daniel P . Berrangé
From: Juan Quintela Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 63bd8a1893..9ed178aa03 100644 --- a/tests/qtest/migrat

[PATCH v2 2/6] tests/qtests: remove migration test iterations config

2023-04-21 Thread Daniel P . Berrangé
The 'unsigned int interations' config for migration is somewhat overkill. Most tests don't set it, and a value of '0' is treated as equivalent to '1'. The only test that does set it, xbzrle, used a value of '2'. This setting, however, only relates to the migration iterations that take place prior

[PATCH v2 0/6] tests/qtest: make migration-test massively faster

2023-04-21 Thread Daniel P . Berrangé
This makes migration-test faster by observing that most of the pre-copy tests don't need to be doing a live migration. They get sufficient code coverage with the guest CPUs paused. On my machine this cuts the overall execution time of migration-test by 50% from 15 minutes, down to 8 minutes, witho

Re: [PATCH v11 00/14] TCG code quality tracking

2023-04-21 Thread Alex Bennée
Fei Wu writes: > This patch series were done by Vanderson and Alex originally in 2019, I > (Fei Wu) rebased them on latest upstream from: > https://github.com/stsquad/qemu/tree/tcg/tbstats-and-perf-v10 > and send out this review per Alex's request, I will continue to address > any future re

[PATCH v4 10/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son getpeername(2) syscall. Add the getpeername(2) syscall to bsd-user/bsd-socket.h. Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 28 1 file changed, 28 insertions(+) diff --git a/bsd-user/bsd-socket.h b/bsd-user/b

[PATCH v4 08/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son connect(2) syscall. Add the connect(2) syscall to bsd-user/bsd-socket.h. Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 21 + 1 file changed, 21 insertions(+) diff --git a/bsd-user/bsd-socket.h b/bsd-user/bsd-socket.h ind

[PATCH v4 09/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son accept(2) syscall. Add the accept(2) syscall to bsd-user/bsd-socket.h. Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 33 + 1 file changed, 33 insertions(+) diff --git a/bsd-user/bsd-socket.h b/bsd-user/bsd-so

[PATCH v4 11/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Warner Losh Add the dispatching code of bind(2),connect(2), accpet(2), getpeername(2). Add the bind(2), connect(2), accept(2), getpeername(2) syscalls case statements to freebsd_syscall function defined in bsd-user/freebsd/os-syscall.c Signed-off-by: Warner Losh Signed-off-by: Karim Taha

[PATCH v4 07/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son The implementation of bind(2) syscall and socket related syscalls. Add bsd-user/bsd-socket.h, which contains the implementation of bind(2), and the socket related system call shims. Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 61 ++

[PATCH] kvm: Merge kvm_check_extension() and kvm_vm_check_extension()

2023-04-21 Thread Jean-Philippe Brucker
The KVM_CHECK_EXTENSION ioctl can be issued either on the global fd (/dev/kvm), or on the VM fd obtained with KVM_CREATE_VM. For most extensions, KVM returns the same value with either method, but for some of them it can refine the returned value depending on the VM type. The KVM documentation [1]

[PATCH v4 02/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son Add the socket conversion related flags and structs. Add the relevant definitions of struct target_sockaddr and struct target_ip_mreq and the related flags, to be used in bsd-user/bsd-socket.c for the socket conversion functions: target_to_host_sockaddr, host_to_target_sockaddr,

[PATCH v4 04/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son Declaration of the socket conversion functions. Add bsd-user/qemu-bsd.h, required by bsd-user/bsd-socket.h, contains forward declarations of the socket conversion functions defined in bsd-user/bsd-socket.c. Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/qe

[PATCH v4 06/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
Build bsd-user/bsd-socket.c. Add bsd-user/bsd-socket.c to meson.build. Signed-off-by: Karim Taha --- bsd-user/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/meson.build b/bsd-user/meson.build index 5243122fc5..f648bd3554 100644 --- a/bsd-user/meson.build +++ b/bsd-user

[PATCH v4 03/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Sean Bruno Target cmsghdr struct and flags. Add the cmsghdr struct and alignment flags. Co-authored-by: Kyle Evans Signed-off-by: Sean Bruno Signed-off-by: Kyle Evans Signed-off-by: Karim Taha --- bsd-user/syscall_defs.h | 38 ++ 1 file changed, 38

[PATCH v4 01/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Warner Losh Intialize guest_base in bsd-user/main.c. Allow guest_base to be initialized on 64-bit hosts, the initial value is used by g2h_untagged function defined in include/exec/cpu_ldst.h Signed-off-by: Warner Losh Signed-off-by: Karim Taha --- bsd-user/main.c | 16 +++-

[PATCH v4 05/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son Definitions of the socket conversion functions. Add bsd-user/bsd-socket.c, which contains the actual definitions of the socket conversion functions. Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-socket.c | 108 ++

[PATCH v4 00/11] Contribution task implementations, for the 'FreeBSD user emulation improvements' project.

2023-04-21 Thread Karim Taha
Upstream the implementations of bind(2), connect(2), accept(2) and getpeername(2) system calls from the blitz branch of the bsd-user fork hosted at https://github.com/qemu-bsd-user/qemu-bsd-user/tree/blitz. Karim Taha (1): Signed-off-by: Karim Taha Sean Bruno (1): Signed-off-by: Karim Taha

Re: [PATCH 01/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
On Fri, Apr 21, 2023 at 9:17 AM Daniel P. Berrangé wrote: > On Fri, Apr 21, 2023 at 07:22:45AM +0200, Karim Taha wrote: > > From: Warner Losh > > > > Allow guest_base to be initialized on 64-bit hosts, the initial value is > used by g2h_untagged function defined in include/exec/cpu_ldst.h > > Th

[PULL v2 00/10] Hexagon queue

2023-04-21 Thread Taylor Simpson
The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12: Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into staging (2023-03-22 17:58:12 +) are available in the Git repository at: https://github.com/quic/qemu tags/pull-hex-20230421

[PULL v2 07/10] Hexagon (target/hexagon) Updates to USR should use get_result_gpr

2023-04-21 Thread Taylor Simpson
Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Message-Id: <20230405164211.30015-3-tsimp...@quicinc.com> --- target/hexagon/gen_tcg.h| 4 +- target/hexagon/genptr.h | 10 ++--- target/hexagon/macros.h | 8 target/hexa

[PULL v2 08/10] Hexagon (tests/tcg/hexagon) Move HVX test infra to header file

2023-04-21 Thread Taylor Simpson
This will facilitate adding additional tests in separate .c files Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230406174241.853296-1-tsimp...@quicinc.com> --- tests/tcg/hexagon/hvx_misc.h | 178 ++ tests/tcg/hexagon/hvx_misc.c

Re: [PATCH] hw/riscv: virt: Enable booting M-mode or S-mode FW from pflash0

2023-04-21 Thread Andrea Bolognani
On Fri, Apr 21, 2023 at 04:36:15PM +0200, Heinrich Schuchardt wrote: > On 4/21/23 06:33, Sunil V L wrote: > > Currently, virt machine supports two pflash instances each with > > 32MB size. However, the first pflash is always assumed to > > contain M-mode firmware and reset vector is set to this if

[RFC] hw/arm/virt: Provide DT binding generation for PCI eXpander Bridges

2023-04-21 Thread Jonathan Cameron via
This patch and the problem it is trying to resolve will form part of a talk I will be giving next week at Linaro Connect. https://sched.co/1K85p So in the spirit of giving people almost no warning... Plus being able to say the discussion has kicked off here is the simplest solution I could come up

[PULL v2 10/10] Hexagon (target/hexagon) Add overrides for cache/sync/barrier instructions

2023-04-21 Thread Taylor Simpson
Most of these are not modelled in QEMU, so save the overhead of calling a helper. The only exception is dczeroa. It assigns to hex_dczero_addr, which is handled during packet commit. Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <20230410202402.2856852-1-tsimp...@qui

[PULL v2 09/10] Hexagon (target/hexagon) Remove unused slot variable in helpers

2023-04-21 Thread Taylor Simpson
The slot variable in helpers was only passed to log_reg_write function where the argument is unused. - Remove declaration from generated helper functions - Remove slot argument from log_reg_write Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <20230407204521.357244-1-ts

[PULL v2 06/10] Hexagon (target/hexagon) Add overrides for count trailing zeros/ones

2023-04-21 Thread Taylor Simpson
The following instructions are overriden S2_ct0Count trailing zeros S2_ct1Count trailing ones S2_ct0p Count trailing zeros (register pair) S2_ct1p Count trailing ones (register pair) These instructions are not handled by idef-parser becau

[PULL v2 02/10] Use f-strings in python scripts

2023-04-21 Thread Taylor Simpson
From: Marco Liebel Replace python 2 format string with f-strings Signed-off-by: Marco Liebel Signed-off-by: Taylor Simpson Reviewed-by: Taylor Simpson Tested-by: Taylor Simpson Message-Id: <20230320092533.2859433-2-quic_mlie...@quicinc.com> --- target/hexagon/gen_analyze_funcs.py | 115

[PULL v2 01/10] Hexagon (translate.c): avoid redundant PC updates on COF

2023-04-21 Thread Taylor Simpson
From: Matheus Tavares Bernardino When there is a conditional change of flow or an endloop instruction, we preload HEX_REG_PC with ctx->next_PC at gen_start_packet(). Nonetheless, we still generate TCG code to do this update again at gen_goto_tb() when the condition for the COF is not met, thus pr

[PULL v2 04/10] Hexagon (target/hexagon) Remove redundant/unused macros

2023-04-21 Thread Taylor Simpson
Remove the following macros (remnants of the old generator design) READ_REG READ_PREG WRITE_RREG WRITE_PREG Modify macros that rely on the above The following are unused READ_IREG fGET_FIELD fSET_FIELD fREAD_P3 fREAD_NPC fWRITE_LC0 fWRITE_LC1 Signed-off

[PULL v2 05/10] Hexagon (target/hexagon) Merge arguments to probe_pkt_scalar_hvx_stores

2023-04-21 Thread Taylor Simpson
Reducing the number of arguments reduces the overhead of the helper call Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230405164211.30015-2-tsimp...@quicinc.com> --- target/hexagon/helper.h| 4 ++-- target/hexagon/translate.h | 1 + target/hexagon/op_hel

[PATCH v3 09/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son accept(2) syscall. Add the accept(2) syscall to bsd-user/bsd-socket.h. Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 33 + 1 file changed, 33 insertions(+) diff --git a/bsd-user/bsd-socket.h b/bsd-user/bsd-socket.h index f191f22d63..f7

[PATCH v3 02/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son Add the socket conversion related flags and structs. Add the relevant definitions of struct target_sockaddr and struct target_ip_mreq and the related flags, to be used in bsd-user/bsd-socket.c for the socket conversion functions: target_to_host_sockaddr, host_to_target_sockaddr,

[PATCH v3 04/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son Declaration of the socket conversion functions. Add bsd-user/qemu-bsd.h, required by bsd-user/bsd-socket.h, contains forward declarations of the socket conversion functions defined in bsd-user/bsd-socket.c. Signed-off-by: Karim Taha --- bsd-user/qemu-bsd.h | 36 +

[PATCH v3 07/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son The implementation of bind(2) syscall and socket related syscalls. Add bsd-user/bsd-socket.h, which contains the implementation of bind(2), and the socket related system call shims. Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 61 +

[PATCH v3 05/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son Definitions of the socket conversion functions. Add bsd-user/bsd-socket.c, which contains the actual definitions of the socket conversion functions. Signed-off-by: Karim Taha --- bsd-user/bsd-socket.c | 108 ++ 1 file changed, 108 inser

[PATCH v3 10/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son getpeername(2) syscall. Add the getpeername(2) syscall to bsd-user/bsd-socket.h. Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 28 1 file changed, 28 insertions(+) diff --git a/bsd-user/bsd-socket.h b/bsd-user/bsd-socket.h index f74826673

[PATCH v3 11/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Warner Losh Add the dispatching code of bind(2),connect(2), accpet(2), getpeername(2). Add the bind(2), connect(2), accept(2), getpeername(2) syscalls case statements to freebsd_syscall function defined in bsd-user/freebsd/os-syscall.c Signed-off-by: Karim Taha --- bsd-user/freebsd/os-s

[PATCH v3 08/11] Signed-off-by: Karim Taha

2023-04-21 Thread Karim Taha
From: Stacey Son connect(2) syscall. Add the connect(2) syscall to bsd-user/bsd-socket.h. Signed-off-by: Karim Taha --- bsd-user/bsd-socket.h | 21 + 1 file changed, 21 insertions(+) diff --git a/bsd-user/bsd-socket.h b/bsd-user/bsd-socket.h index 7da4cf11a0..f191f22d63 1

  1   2   3   4   >