Hello,
I have incorporated review comments from Stefan and Cedric. Please
review.
This drop adds support for the TPM devices attached to the I2C bus. It
only supports the TPM2 protocol. You need to run it with the external
TPM emulator like swtpm. I have tested it with swtpm.
I have refered to t
This is a documentation change for I2C TPM device support.
Qemu already supports devices attached to ISA and sysbus.
This drop adds support for the I2C bus attached TPM devices.
Signed-off-by: Ninad Palsule
---
V2:
Incorporated Stephen's review comments
- Added example in the document.
---
V4
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices. I2C model only supports
TPM2 protocol.
This commit includes changes for the common code.
- Added I2C emulation model. Logic was added in the model to temporarily
cache the data
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices.
This commit includes changes for the common code.
- Added support for the new checksum registers which are required for
the I2C support. The checksum calculation is handled in t
Eric Blake wrote:
> On Fri, Mar 24, 2023 at 02:41:20PM -0500, Eric Blake wrote:
> > On Fri, Mar 24, 2023 at 11:47:20AM +0100, Florian Westphal wrote:
> > > qemu-nbd doesn't set TCP_NODELAY on the tcp socket.
>
> Replying to myself, WHY aren't we setting TCP_NODELAY on the socket?
If the applicat
Add a KCS module for NPCM7xx SoC. This module implements the IPMI
responder interface and is responsible to communicate with an external
host via the KCS channels in an NPCM7xx SoC.
Note that we cannot directly use ipmi_kcs.c since the communication
direction is the opposite. For example, in READ_
This patch refactors ipmi_bmc_extern.c and takes out the parts that can
be used both ipmi_bmc_extern.c and bmc_host_extern.c to a common file
ipmi_extern.c.
Now we have a connection called IPMIExtern which handles the connection,
and IPMIBmcExtern that handles core-side emulation specific stuff.
This patch refactors the IPMI interface so that it can be used by both
the BMC side and core-side simulation.
Detail changes:
(1) Split IPMIInterface into IPMIInterfaceHost (for host side
simulation) and IPMIInterfaceClient (for BMC side simulation).
(2) rename handle_rsp -> handle_msg so the
The IPMI external host device works for Baseband Management Controller
(BMC) emulations. It works as a representation of a host class that
connects to a given BMC. It can connect to a real host hardware or a
emulated or simulated host device. In particular it can connect to a
host QEMU instance wi
From: Havard Skinnemoen
The IPMI document is expanded with a proposal to emulate BMC-side IPMI
devices. This allows a QEMU instance running server software to interact
with a different QEMU instance running BMC firmware, which should
closely model how a real server system works.
Signed-off-by: H
This patch set is follow-up to our BMC side IPMI
code that was sent our 18 months ago. It addresses
Corey's comments.
Baseboard Management Controllers (BMCs) are special
processors that monitors state of a computer, often
used in data center servers. They often communicate
via IPMI. As a result, i
From: Havard Skinnemoen
This document is an attempt to briefly document the existing IPMI
emulation support on the main processor. It provides the necessary
background for the BMC-side IPMI emulation proposed by the next patch.
Signed-off-by: Havard Skinnemoen
Signed-off-by: Hao Wu
---
docs/s
From: Havard Skinnemoen
This allows use to add block diagrams in documentations,
such as the block diagram in docs/specs/impi.rst.
Signed-off-by: Havard Skinnemoen
Signed-off-by: Hao Wu
---
docs/conf.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/conf.py b/do
On Fri, Mar 24, 2023 at 02:41:20PM -0500, Eric Blake wrote:
> On Fri, Mar 24, 2023 at 11:47:20AM +0100, Florian Westphal wrote:
> > qemu-nbd doesn't set TCP_NODELAY on the tcp socket.
Replying to myself, WHY aren't we setting TCP_NODELAY on the socket?
>
> And surprisingly, qemu IS using corking
On Fri, 24 Mar 2023, David Woodhouse wrote:
> On Fri, 2023-03-24 at 13:53 +0100, Remi Duraffort wrote:
> > Le ven. 24 mars 2023 à 12:02, Alex Bennée a écrit :
> > > version: 1
> > > name: Xen Guest Kernels
> > > description: Build Xen Test Kernels
> > > jobs:
> > > - builds:
> > >
On Fri, Mar 24, 2023 at 07:20:17PM +0100, Florian Westphal wrote:
> Kevin Wolf wrote:
> > Am 24.03.2023 um 11:47 hat Florian Westphal geschrieben:
> > > +qio_channel_set_cork(client->ioc, true);
> > > +
> > > if (ret < 0) {
> > > /* It wasn't -EIO, so, according to nbd_co_receive
On 3/24/23 09:43, Stefan Berger wrote:
On 3/24/23 04:24, Cédric Le Goater wrote:
Hello Ninad,
+
+/*
+ * Convert little endian byte stream into local formated
+ * unsigned integer
+ */
+static inline uint32_t tpm_i2c_le_bytes_to_uint(TPMStateI2C *i2cst)
+{
+ uint32_t data = 0;
+ in
On Fri, Mar 24, 2023 at 11:47:20AM +0100, Florian Westphal wrote:
> qemu-nbd doesn't set TCP_NODELAY on the tcp socket.
>
> Kernel waits for more data and avoids transmission of small packets.
> Without TLS this is barely noticeable, but with TLS this really shows.
>
> Booting a VM via qemu-nbd o
On Fri, 24 Mar 2023 18:56:06 +0100
Thomas Huth wrote:
> On 24/03/2023 18.45, Claudio Imbrenda wrote:
> > The recently introduced -async-teardown commandline option was not
> > wired up properly and did not show up in the output of the QMP command
> > query-command-line-options. This means that li
I would like to review and be informed on changes to igb device
Signed-off-by: Sriram Yagnaraman
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9b56ccdd92..a9ed6143f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2252,6 +2252,7 @@ F: tests/qt
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 41 -
1 file changed, 36 insertions(+), 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 753f17b40c..38aa4596b1 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -921,1
IGB uses RXDW ICR bit to indicate that rx descriptor has been written
back. This is the same as RXT0 bit in older HW.
Signed-off-by: Sriram Yagnaraman
---
hw/net/e1000x_regs.h | 4
hw/net/igb_core.c| 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/net/e1000x_regs.
RSS for VFs is only enabled if VMOLR[n].RSSE is set.
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 38aa4596b1..fd61c6c550 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/i
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF
is reset.
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 38 ++
hw/net/igb_regs.h | 3 +++
hw/net/trace-events | 2 ++
3 files changed, 31 insertions(+), 12 deletions(-)
d
Please note that loopback counters for VM to VM traffic is not
implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC.
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/hw/net/igb_core.c b/hw
Add support for stripping/inserting VLAN for VFs.
Had to move CSUM calculation back into the for loop, since packet data
is pulled inside the loop based on strip VLAN decision for every VF.
net_rx_pkt_fix_l4_csum should be extended to accept a buffer instead for
igb. Work for a future patch.
Sig
Also introduce:
- Checks for RXDCTL/TXDCTL queue enable bits
- IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7)
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 38 +++---
hw/net/igb_core.h | 1 +
hw/net/igb_regs.h | 3 +++
3 files changed, 35 insertions(+), 7
Based-on: <20230324095434.44973-1-akihiko.od...@daynix.com>
([PATCH for 8.0 0/4] igb fixes for 8.0)
Now that Akhiko's patchset for introducing igb device is merged, I have
rebased my changes on master. The changes proposed here adds support
for
- Correct PF/VF reset handling
- Introduce ICR_RXD
Hi,
We're seeing failures running s390x migration kvm-unit-tests tests with TCG.
Some initial findings:
What seems to be happening is that after migration a control block header
accessed by the test code is all zeros which causes an unexpected exception.
I did a bisection which points to c8df4a7a
Hello Cedric,
On 3/24/23 3:24 AM, Cédric Le Goater wrote:
Hello Ninad,
On 3/24/23 04:02, Ninad Palsule wrote:
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices. I2C model only supports
TPM2 protocol.
This commit includes chan
Kevin Wolf wrote:
> Am 24.03.2023 um 11:47 hat Florian Westphal geschrieben:
> > +qio_channel_set_cork(client->ioc, true);
> > +
> > if (ret < 0) {
> > /* It wasn't -EIO, so, according to nbd_co_receive_request()
> > * semantics, we should return the error to the client
Hi Stefan,
On 3/24/23 9:19 AM, Stefan Berger wrote:
On 3/23/23 23:02, Ninad Palsule wrote:
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices. I2C model only supports
TPM2 protocol.
This commit includes changes for the common
On 3/24/23 05:38, Weiwei Li wrote:
Fix formats for multi-lines comments.
Add spaces around single line comments(after "/*" and before "*/").
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/arch_dump.c| 3 +-
target/riscv/cpu.c | 2
On 3/24/23 05:38, Weiwei Li wrote:
Remove redundant parentheses in get_physical_address.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 3/24/23 05:38, Weiwei Li wrote:
In current implementation, riscv_cpu_set_virt_enabled is only called when
RVH is enabled.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 4
1 file changed, 4 deletions(-)
Perhaps assert, or assert under CONFIG_DE
On 3/24/23 05:38, Weiwei Li wrote:
Since env->virt.VIRT_ONOFF is initialized as false, and will not be set
to true when RVH is disabled, so we can just return this bit(false) when
RVH is not disabled.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 4 ---
On 3/24/23 05:38, Weiwei Li wrote:
Check on riscv_cpu_virt_enabled contains the check on RVH.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/op_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On 3/24/23 05:38, Weiwei Li wrote:
The assignment is done under the condition riscv_cpu_virt_enabled()=true.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
Juan Quintela writes:
> Daniel P. Berrangé wrote:
>> On Tue, Feb 14, 2023 at 05:07:38PM +0100, Juan Quintela wrote:
>>> Hi
>>>
>>> I want to enter a discussion about changing the default of the style
>>> guide.
>>>
>>> There are several reasons for that:
>>> - they exist since C99 (i.e. all
On 3/23/23 22:41, Fei Wu wrote:
@@ -762,7 +764,7 @@ static int get_physical_address(CPURISCVState *env, hwaddr
*physical,
* (riscv_cpu_do_interrupt) is correct */
MemTxResult res;
MemTxAttrs attrs = MEMTXATTRS_UNSPECIFIED;
-int mode = mmu_idx & TB_FLAGS_PRIV_MMU_MASK;
+
On 24/03/2023 18.45, Claudio Imbrenda wrote:
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by correctly wirin
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by adding a new -t
Juan Quintela writes:
> Thomas Huth wrote:
>> On 23/03/2023 19.31, Juan Quintela wrote:
>>> Daniel P. Berrangé wrote:
The TAP protocol version line must be the first thing printed on
stdout. The migration test failed that requirement in certain
scenarios:
# Skippin
Daniel P. Berrangé wrote:
> On Tue, Feb 14, 2023 at 05:07:38PM +0100, Juan Quintela wrote:
>> Hi
>>
>> I want to enter a discussion about changing the default of the style
>> guide.
>>
>> There are several reasons for that:
>> - they exist since C99 (i.e. all supported compilers support them)
>>
We don't update these often but if your the sort of person who enjoys
debating and tuning project policies you could now add yourself as a
reviewer here so you don't miss the next debate over tabs vs spaces
;-)
Who's with me?
Signed-off-by: Alex Bennée
Cc: Thomas Huth
Cc: Daniel P. Berrangé
Cc
On Fri, 24 Mar 2023 at 12:05, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > On Thu, 23 Mar 2023 at 14:48, Markus Armbruster wrote:
> >>
> >> The QAPI schema doc comment language provides special syntax for command
> >> and event arguments, struct and union members, alternate branches,
Thomas Huth wrote:
> On 23/03/2023 19.31, Juan Quintela wrote:
>> Daniel P. Berrangé wrote:
>>> The TAP protocol version line must be the first thing printed on
>>> stdout. The migration test failed that requirement in certain
>>> scenarios:
>>>
>>># Skipping test: Userfault not available (bu
Am 24.03.2023 um 11:47 hat Florian Westphal geschrieben:
> qemu-nbd doesn't set TCP_NODELAY on the tcp socket.
>
> Kernel waits for more data and avoids transmission of small packets.
> Without TLS this is barely noticeable, but with TLS this really shows.
>
> Booting a VM via qemu-nbd on localho
Remi Duraffort writes:
> Hello Alex,
>
> Le ven. 24 mars 2023 à 12:02, Alex Bennée a écrit :
>
> Hi guys,
>
> I've been working with David on adding testing for the new KVM Xen guest
> functionality and had a couple of questions. His original test is based
> on fedora and is fairly compreh
On 3/24/23 07:30, LIU Zhiwei wrote:
Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a
normal way.
It will make it hard to change the tb flags layout. And even worse, if we
want to keep tb flags for a same extension togather without a hole.
Signed-off-by: LIU Zhiwei
Review
On 3/24/23 07:30, LIU Zhiwei wrote:
Once we mistook the vstart directly from the env->vstart. As env->vstart is not
a constant, we should record it in the tb flags if we want to use
it in translation.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
Reviewed-by: Weiwei Li
---
target/ri
On 3/24/23 07:30, LIU Zhiwei wrote:
The pointer masking is the only extension that directly use status.
The vector or float extension uses the status in an indirect way.
Replace the pointer masking extension special status fields with
the general status.
Signed-off-by: LIU Zhiwei
---
v1->v2:
Mo
On 3/24/23 07:30, LIU Zhiwei wrote:
Virt enabled state is not a constant. So we should put it into tb flags.
Thus we can use it like a constant condition at translation phase.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
Reviewed-by: Weiwei Li
---
target/riscv/cpu.h| 2 ++
On 3/22/23 3:33 AM, Jonathan Cameron wrote:
The hardware clearing the commit bit is not spec compliant.
Clearing of committed bit when commit is cleared is not specifically
stated in the CXL spec, but is the expected (and simplest) permitted
behaviour so use that for QEMU emulation.
Signed-of
On 3/23/23 22:59, LIU Zhiwei wrote:
Once we mistook the vstart directly from the env->vstart. As env->vstart is not
a constant, we should record it in the tb flags if we want to use
it in translation.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.h
On 3/23/23 22:59, LIU Zhiwei wrote:
Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a normal
way.
It will make us change the tb flags layout difficult. And even worse, if we
want to keep tb flags for a same extension togather without a hole.
Signed-off-by: LIU Zhiwei
Re
On 3/23/23 22:59, LIU Zhiwei wrote:
Virt enabled state is not a constant. So we should put it into tb flags.
Thus we can use it like a constant condition at translation phase.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.h| 2 ++
target/riscv/cpu_help
MCL(Maximum Copy Length) in the Identify Namespace data structure limits
the number of LBAs to be copied inside of the controller. We've not
checked it at all, so added the check with returning the proper error
status.
Signed-off-by: Minwoo Im
Reviewed-by: Klaus Jensen
---
hw/nvme/ctrl.c | 24
Kernel needs to access user mode memory e.g. during syscalls, the window
is usually opened up for a very limited time through MSTATUS.SUM, the
overhead is too much if tlb_flush() gets called for every SUM change.
This patch creates a separate MMU index for S+SUM, so that it's not
necessary to flus
On 2023/3/23 06:19, Daniel Henrique Barboza wrote:
The 'G' bit in misa_ext is a virtual extension that enables a set of
extensions (i, m, a, f, d, icsr and ifencei). We're already have code to
handle it but no bit definition. Add it.
Add RVG to set_misa() in rv64_thead_c906_cpu_init() and remo
From: David Woodhouse
Exercise guests with a few different modes for interrupt delivery. In
particular we want to cover:
• Xen event channel delivery via GSI to the I/O APIC
• Xen event channel delivery via GSI to the i8259 PIC
• MSIs routed to PIRQ event channels
• GSIs routed to PIRQ event
When I boot a ubuntu image, QEMU output a "Bad icount read" message and exit.
The reason is that when execute helper_mret or helper_sret, it will
cause a call to icount_get_raw_locked (), which needs set can_do_io flag
on cpustate.
Thus we setting this flag when execute these two instructions.
Si
From: David Woodhouse
As the Xen backend operations were abstracted out into a function table to
allow for internally emulated Xen support, we missed the xen_init_pv()
code path which also needs to install the operations for the true Xen
libraries. Add the missing call to setup_xen_backend_ops().
On the blogs page, long lines under a tag will make the left column
overlap the sidebar. Fix it in the CSS.
Signed-off-by: Paolo Bonzini
---
_includes/assets.html| 2 +-
assets/css/skel-noscript.css | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/_includes/assets.h
Hi guys,
I've been working with David on adding testing for the new KVM Xen guest
functionality and had a couple of questions. His original test is based
on fedora and is fairly comprehensive:
https://git.infradead.org/users/dwmw2/qemu.git/commitdiff/48f78f9bb860dca446e20d6ed8db3aa9d857505f
b
On Wed, 22 Mar 2023 16:21:26 +
Fan Ni wrote:
> On Wed, Mar 22, 2023 at 10:33:00AM +, Jonathan Cameron wrote:
> > The hardware clearing the commit bit is not spec compliant.
> > Clearing of committed bit when commit is cleared is not specifically
> > stated in the CXL spec, but is the expe
On 23/03/2023 19.31, Juan Quintela wrote:
Daniel P. Berrangé wrote:
The TAP protocol version line must be the first thing printed on
stdout. The migration test failed that requirement in certain
scenarios:
# Skipping test: Userfault not available (builtdtime)
TAP version 13
# random s
In current implementation, riscv_cpu_set_virt_enabled is only called when
RVH is enabled.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 4
1 file changed, 4 deletions(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 62fd2c
Remove redundant parentheses in get_physical_address.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 3862e7b677..de2d4a8c1d 100644
This patchset tries to simplify the RVH related check and fix some code style
problems, such as problems for indentation, multi-line comments and lines with
over 80 characters.
The port is available here:
https://github.com/plctlab/plct-qemu/tree/plct-cleanup-upstream
Weiwei Li (8):
target/ri
On 2023/3/23 06:20, Daniel Henrique Barboza wrote:
Similar to what we did with riscv_cpu_validate_misa_ext(), let's read
all MISA bits from a misa_ext val instead of reading from the cpu->cfg
object.
This will allow write_misa() to use riscv_cpu_validate_extensions().
Signed-off-by: Daniel He
On 2023/3/24 13:59, LIU Zhiwei wrote:
Virt enabled state is not a constant. So we should put it into tb flags.
Thus we can use it like a constant condition at translation phase.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
---
Reviewed-by: Weiwei Li
Weiwei L
target/riscv/c
Nicholas Piggin writes:
> This optional behavior was removed from the ISA in v3.0, see
> Summary of Changes preface:
>
> Data Storage Interrupt Status Register for Alignment Interrupt:
> Simplifies the Alignment interrupt by remov- ing the Data Storage
> Interrupt Status Register (DSISR) fr
Taking account of the new zone append write operation for zoned devices,
BLOCK_ACCT_ZONE_APPEND enum is introduced as other I/O request type (read,
write, flush).
Signed-off-by: Sam Li
---
block/qapi-sysemu.c| 11 ++
block/qapi.c | 18 ++
hw/block/virtio-blk.c
On Thu, Mar 16, 2023 at 07:14:47AM +0800, Dmitry Osipenko wrote:
> On 3/13/23 18:55, Huang Rui wrote:
> > On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote:
> >> On 3/12/23 12:22, Huang Rui wrote:
> >>> From: Antonio Caggiano
> >>>
> >>> Request Venus when initializing VirGL.
> >>>
>
On 3/24/23 04:24, Cédric Le Goater wrote:
Hello Ninad,
+
+/*
+ * Convert little endian byte stream into local formated
+ * unsigned integer
+ */
+static inline uint32_t tpm_i2c_le_bytes_to_uint(TPMStateI2C *i2cst)
+{
+ uint32_t data = 0;
+ int i;
+
+ assert(i2cst->offset <= 5
On 23/3/23 20:00, Daniel P. Berrangé wrote:
On Tue, Feb 14, 2023 at 05:07:38PM +0100, Juan Quintela wrote:
Hi
I want to enter a discussion about changing the default of the style
guide.
There are several reasons for that:
- they exist since C99 (i.e. all supported compilers support them)
- the
From: Yeqi Fu
Bring the block files in line with the QEMU coding style, with spaces
for indentation. This patch partially resolves the issue 371.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371
Signed-off-by: Yeqi Fu
Message-Id: <20230315043229.62100-1-fufuyqqq...@gmail.com>
Reviewe
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
hw/block/trace-events | 7 +++
hw/block/virtio-blk.c | 12
2 files changed, 19 insertions(+)
diff --git a/hw/block/trace-events b/hw/block/trace-events
index 2c45a62bd5..34be8b9135 100644
--- a/hw/block/trace-events
+++ b/
On 2023/3/23 06:20, Daniel Henrique Barboza wrote:
write_misa() must use as much common logic as possible. We want to open
code just the bits that are exclusive to the CSR write operation and TCG
internals.
Rewrite write_misa() to work as follows:
- mask the write using misa_ext_mask to avoid
On 3/23/23 23:02, Ninad Palsule wrote:
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices.
This commit includes changes for the common code.
- Added support for the new checksum registers which are required for
the I2C supp
igb used to specify the PF as DMA requester when reading Tx packets.
This made Tx requests from VFs to be performed on the address space of
the PF, defeating the purpose of SR-IOV. Add some logic to change the
requester depending on the queue, which can be assigned to a VF.
Fixes: 3a977deebe ("Int
On Thu, Mar 23, 2023 at 4:41 PM Cindy Lu wrote:
>
> On Thu, Mar 23, 2023 at 11:47 AM Jason Wang wrote:
> >
> > On Tue, Mar 21, 2023 at 10:24 PM Cindy Lu wrote:
> > >
> > > 1. The vIOMMU support will make vDPA can work in IOMMU mode. This
> > > will fix security issues while using the no-IOMMU mo
huang...@chinatelecom.cn writes:
> From: Hyman Huang(黄勇)
>
> Introduce migration dirty-limit capability, which can
> be turned on before live migration and limit dirty
> page rate durty live migration.
>
> Introduce migrate_dirty_limit function to help check
> if dirty-limit capability enabled du
Ping again, to make sure this series not be forgotten. :)
Please review the last three commit if you are free.
Thanks,
Yong
在 2023/3/1 23:53, Hyman Huang 写道:
Ping ?
在 2023/2/17 0:18, huang...@chinatelecom.cn 写道:
From: Hyman Huang(黄勇)
v4:
1. Polish the docs and update the release version
On 3/23/23 23:32, Ninad Palsule wrote:
On 3/23/23 3:37 AM, Cédric Le Goater wrote:
On 3/23/23 04:01, Ninad Palsule wrote:
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices. I2C model only supports
TPM2 protocol.
This commit i
On 2023/3/23 06:19, Daniel Henrique Barboza wrote:
We can set all RVG related extensions during realize time, before
validate_set_extensions() itself. Put it in a separated function so the
validate function already uses the updated state.
Note that we're setting both cfg->ext_N and env->misa_e
Hi Nick,
> powerpc ifetch endianness depends on MSR[LE] so it has to byteswap
> after cpu_ldl_code(). This corrects DSISR bits in alignment
> interrupts when running in little endian mode.
>
Just a thought, we have these tests that perhaps could have caught
this: https://github.com/legoater/pnv-
Virt enabled state is not a constant. So we should put it into tb flags.
Thus we can use it like a constant condition at translation phase.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.h| 2 ++
target/riscv/cpu_helper.c | 2 ++
target/riscv/translate.c
Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a normal
way.
It will make us change the tb flags layout difficult. And even worse, if we
want to keep tb flags for a same extension togather without a hole.
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.h
The pointer masking is the only extension that directly use status.
The vector or float extension uses the status in an indirect way.
Replace the pointer masking extension special status fields with
the general status.
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.c | 2 +-
target/riscv/
Putting zoned/non-zoned BlockDrivers on top of each other is not
allowed.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
---
block.c | 19 +++
block/file-posix.c | 12 +
On 3/23/23 23:02, Ninad Palsule wrote:
Qemu already supports devices attached to ISA and sysbus. This drop adds
support for the I2C bus attached TPM devices. I2C model only supports
TPM2 protocol.
This commit includes changes for the common code.
- Added I2C emulation model. Logic was added i
Check on riscv_cpu_virt_enabled contains the check on RVH.
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/op_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c
index 84ee018f7d..1eecae9547 10
From: Cédric Le Goater
GCC13 reports an error:
../target/ppc/excp_helper.c:2625:6: error: conflicting types for
‘helper_pminsn’ due to enum/integer mismatch; have ‘void(CPUPPCState *,
powerpc_pm_insn_t)’ {aka ‘void(struct CPUArchState *, powerpc_pm_insn_t)’}
[-Werror=enum-int-mismatch]
2625
This series have several fixes igb for 8.0 release.
Akihiko Odaki (4):
igb: Save more Tx states
igb: Fix DMA requester specification for Tx packet
hw/net/net_tx_pkt: Ignore ECN bit
hw/net/net_tx_pkt: Align l3_hdr
hw/net/e1000e_core.c | 6 ++---
hw/net/igb.c | 26
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
---
include/block/block-common.h | 43
1 file changed, 43 insertions(+)
diff --git a/include/block/block-common.h b/in
Once we mistook the vstart directly from the env->vstart. As env->vstart is not
a constant, we should record it in the tb flags if we want to use
it in translation.
Reported-by: Richard Henderson
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.h | 21 +++--
t
Use scripts/update-linux-headers.sh to update headers to 6.3-rc1.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Dmitry Fomichev
---
include/standard-headers/drm/drm_fourcc.h| 12 +++
include/standard-headers/linux/ethtool.h | 48 -
include/standard-headers/l
1 - 100 of 183 matches
Mail list logo
