From: Volker Rümelin
Refactoring the code in audio_run_out() avoids code duplication
in the next patch. There's no functional change.
Signed-off-by: Volker Rümelin
Reviewed-by: Marc-André Lureau
Message-Id: <20220923183640.8314-1-vr_q...@t-online.de>
Signed-off-by: Gerd Hoffmann
---
audio/au
The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with
FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made
SGX enclave only supported SSE and x87 feature(xfrm=0x3).
Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features")
Signed-off-by: Yang Zhong
-
Avoid calling riscv_itrigger_enabled() when calculate the tbflags.
As the itrigger enable status can only be changed when write
tdata1, migration load or itrigger fire, update env->itrigger_enabled
at these places.
Signed-off-by: LIU Zhiwei
---
target/riscv/cpu.h| 1 +
target/riscv/cpu_
The max count in itrigger can be 0x3FFF, which will cause a no trivial
translation and execution overload.
When icount is enabled, QEMU provides API that can fetch guest
instruction number. Thus, we can set an timer for itrigger with
the count as deadline.
Only when timer expires or priviledge mo
Christian Schoenebeck writes:
> On Mittwoch, 12. Oktober 2022 14:28:23 CEST Nikita Ivanov wrote:
>> Rename macro name to more transparent one and refactor
>> it to expression.
>>
>> Signed-off-by: Nikita Ivanov
[...]
>> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
>> index b1c161c
When QEMU is not in icount mode, execute instruction one by one. The
tdata1 can be read directly.
When QEMU is in icount mode, use a timer to simulate the itrigger. The
tdata1 may be not right because of lazy update of count in tdata1. Thus,
We should pack the adjusted count into tdata1 before rea
When icount is not enabled, there is no API in QEMU that can get the
guest instruction number.
Translate the guest code in a way that each TB only has one instruction.
After executing the instruction, decrease the count by 1 until it reaches 0
where the itrigger fires.
Note that only when privile
icount trigger set an instruction count. After one instruction retired,
the count will be decreased by 1. If the count decreased to 0, the icount
trigger will fire.
icount trigger is needed by single step ptrace system call and the native
GDB.
In this patch set, change the translation when icount
On Wed, Oct 12, 2022 at 09:59:04AM +, Huang, Kai wrote:
> On Wed, 2022-10-12 at 04:26 -0400, Yang Zhong wrote:
> > The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with
> > FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):ECX, which made SGX
>
On 10/10/22 11:33, Sam Li wrote:
> A zone append command is a write operation that specifies the first
> logical block of a zone as the write position. When writing to a zoned
> block device using zone append, the byte offset of writes is pointing
> to the write pointer of that zone. Upon completio
The register definitions in tests/qtest/libqos/e1000e.c had names
different from hw/net/e1000_regs.h, which made it hard to understand
what test codes corresponds to the implementation. Use
hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove
these duplications.
E1000E_CTRL_EXT_TXLSFLOW
On 10/13/22 14:33, Sam Li wrote:
> Damien Le Moal 于2022年10月13日周四 12:41写道：
>>
>> On 10/10/22 11:21, Sam Li wrote:
>>> Add a new zoned_host_device BlockDriver. The zoned_host_device option
>>> accepts only zoned host block devices. By adding zone management
>>> operations in this new BlockDriver, us
Damien Le Moal 于2022年10月13日周四 13:45写道：
>
> On 10/13/22 14:33, Sam Li wrote:
> > Damien Le Moal 于2022年10月13日周四 12:41写道：
> >>
> >> On 10/10/22 11:21, Sam Li wrote:
> >>> Add a new zoned_host_device BlockDriver. The zoned_host_device option
> >>> accepts only zoned host block devices. By adding zone
On Thu, Sep 29, 2022 at 7:55 PM Markus Armbruster wrote:
>
> Akihiko Odaki writes:
>
> > On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote:
> >>
> >> Akihiko Odaki writes:
> >>
> >> > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster
> >> > wrote:
> >> >>
> >> >> Akihiko Odaki writes:
>
Damien Le Moal 于2022年10月13日周四 12:41写道：
>
> On 10/10/22 11:21, Sam Li wrote:
> > Add a new zoned_host_device BlockDriver. The zoned_host_device option
> > accepts only zoned host block devices. By adding zone management
> > operations in this new BlockDriver, users can use the new block
> > layer A
On 10/10/22 11:33, Sam Li wrote:
> Since Linux doesn't have a user API to issue zone append operations to
> zoned devices from user space, the file-posix driver is modified to add
> zone append emulation using regular writes. To do this, the file-posix
> driver tracks the wp location of all zones o
On Mon, Oct 10, 2022 at 11:01 AM Warner Losh wrote:
>
>
> On Mon, Oct 10, 2022 at 1:13 AM Thomas Huth wrote:
>
>> On 10/10/2022 08.18, Dennis Clarke wrote:
>> >
>> > On FreeBSD 14.0 CURRENT amd64 everything seems to go swimmingly until :
>> >
>> > [5679/6848] Compiling C object
>> libqemu-arm-bs
Thomas Huth writes:
> On 12/10/2022 17.38, Markus Armbruster wrote:
>> When you try to set qtest property "log" while the qtest object is
>> active, the error message blames "insufficient permission":
>>
>> $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio
>> -chardev socket
在 2022/10/12 13:59, Si-Wei Liu 写道:
On 10/11/2022 8:09 PM, Jason Wang wrote:
On Tue, Oct 11, 2022 at 1:18 AM Si-Wei Liu wrote:
On 10/8/2022 10:43 PM, Jason Wang wrote:
On Sat, Oct 8, 2022 at 5:04 PM Si-Wei Liu wrote:
Similar to other vhost backends, vhostfd can be passed to vhost-vdpa
ba
On 10/10/22 11:21, Sam Li wrote:
> Add the documentation about the zoned device support to virtio-blk
> emulation.
>
> Signed-off-by: Sam Li
> Reviewed-by: Stefan Hajnoczi
> ---
> docs/devel/zoned-storage.rst | 40 ++
> docs/system/qemu-block-drivers.rst.inc |
On 10/10/22 11:21, Sam Li wrote:
> Add a new zoned_host_device BlockDriver. The zoned_host_device option
> accepts only zoned host block devices. By adding zone management
> operations in this new BlockDriver, users can use the new block
> layer APIs including Report Zone and four zone management o
Similar to the ARM64, LoongArch has PC-relative instructions such as
PCADDU18I. These instructions can be used to support direct jump for
LoongArch. Additionally, if instruction "B offset" can cover the target
address(target is within ±128MB range), a single "B offset" plus a nop
will be used by "t
On Wed, Oct 12, 2022 at 10:15:28AM -0400, Stefan Hajnoczi wrote:
> On Thu, 6 Oct 2022 at 06:14, Richard W.M. Jones wrote:
> >
> > On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote:
> > > qemu-nbd doesn't use io_uring to handle the backend IO,
> >
> > Would this be fixed by your (not
On 2022/10/12 19:34, WANG Xuerui wrote:
Hi,
Thanks for the improvement! Some room for improvement though...
On 2022/10/12 17:13, Qi Hu wrote:
Similar to the ARM64, LoongArch has PC-relative instructions such as
PCADDU18I. These instructions can be used to support direct jump for
LoongArch. A
On 2022/10/12 17:41, WANG Xuerui wrote:
Hi,
On 2022/10/12 17:13, Qi Hu wrote:
Signed-off-by: Qi Hu
---
tcg/loongarch64/tcg-target.c.inc | 9 +
tcg/loongarch64/tcg-target.h | 4 ++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/tcg/loongarch64/tcg-target.c.i
Hi Jonathan,
As we agreed, I am moving our discussion into public mailing list.
So, I would like to contribute to QEMU emulation of CXL memory support. And I
would like to see a TODO list. I hope this list could be useful not only for
me. As far as I can see, we can summarize:
1) Moving toward
The Octeon specific BBIT instruction incorrectly computes
the branch offset. The 16 bit value is not sign extended.
Signed-off-by: Christopher Wrogg
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1251
---
target/mips/tcg/octeon_translate.c | 5 -
1 file changed, 4 insertions(+), 1 d
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Wed, 12 Oct 2022 at 17:00, Michael S. Tsirkin wrote:
>
> On Wed, Oct 12, 2022 at 04:04:31PM -0400, Stefan Hajnoczi wrote:
> > On Mon, 10 Oct 2022 at 13:46, Michael S. Tsirkin wrote:
> > >
> > > The following changes since commit
> > > f1d33f55c47dfdaf8daacd618588ad3ae4c452d1:
> > >
> > > Me
On Wed, Oct 12, 2022 at 04:04:31PM -0400, Stefan Hajnoczi wrote:
> On Mon, 10 Oct 2022 at 13:46, Michael S. Tsirkin wrote:
> >
> > The following changes since commit f1d33f55c47dfdaf8daacd618588ad3ae4c452d1:
> >
> > Merge tag 'pull-testing-gdbstub-plugins-gitdm-061022-3' of
> > https://github.c
On Mon, 10 Oct 2022 at 13:46, Michael S. Tsirkin wrote:
>
> The following changes since commit f1d33f55c47dfdaf8daacd618588ad3ae4c452d1:
>
> Merge tag 'pull-testing-gdbstub-plugins-gitdm-061022-3' of
> https://github.com/stsquad/qemu into staging (2022-10-06 07:11:56 -0400)
>
> are available in
Hi Everyone,
Hope everyone is doing great. I have seen some live migration issues with
qemu-4.2 when using multiFD. Signature of issue is something like this.
2022-10-01T09:57:53.972864Z qemu-kvm: failed to receive packet via multifd
channel 0: multifd: received packet magic 5145564d expected 11
On 12.10.22 20:27, Thomas Huth wrote:
The element size is encoded in the M3 field, not in the M4
field.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1248
Fixes: be6324c6b734 ("s390x/tcg: Implement VECTOR ISOLATE STRING")
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
---
On 12.10.22 17:37, Markus Armbruster wrote:
When you try to set a property that has no setter, the error message
blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio
QEMU 7.1.50 monitor - type 'help' for more information
(qemu) qom-set
On 12.10.22 20:27, Thomas Huth wrote:
This test can be used to verify that the change in the previous
commit is indeed fixing the problem with the M3 vs. M4 field
mixup.
Signed-off-by: Thomas Huth
---
Reviewed-by: David Hildenbrand
--
Thanks,
David / dhildenb
On 12.10.22 20:27, Thomas Huth wrote:
This is common practice, see the Makefile.target in the aarch64
folder for example.
Suggested-by: Alex Bennée
Signed-off-by: Thomas Huth
---
tests/tcg/s390x/Makefile.target | 27 +--
1 file changed, 17 insertions(+), 10 deletions
On 12.10.22 20:05, Thomas Huth wrote:
On 12/10/2022 17.38, Markus Armbruster wrote:
When you try to set qtest property "log" while the qtest object is
active, the error message blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chardev
soc
Note: This is my first patch that someone else wrote that I'm trying to
accept
and land as the bsd-user maintainer unrelated to the other upstreaming work.
Please be let me know if I'm doing something wrong. I'll queue it to this
month's
bsd-user pull request (which likely will only include this pa
From: Muhammad Moinur Rahman
Some versions of FreeBSD now require sys/param.h for machine/pmap.h on
x86. Include them here to meet that requirement. It does no harm on
older versions, so there's no need to #ifdef it.
Signed-off-by: Muhammad Moinur Rahman
Reviewed-by:John Baldwin
Signed-of
This is common practice, see the Makefile.target in the aarch64
folder for example.
Suggested-by: Alex Bennée
Signed-off-by: Thomas Huth
---
tests/tcg/s390x/Makefile.target | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/tests/tcg/s390x/Makefile
This test can be used to verify that the change in the previous
commit is indeed fixing the problem with the M3 vs. M4 field
mixup.
Signed-off-by: Thomas Huth
---
tests/tcg/s390x/vistr.c | 45 +
tests/tcg/s390x/Makefile.target | 4 +++
2 files changed, 49
The element size is encoded in the M3 field, not in the M4
field.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1248
Fixes: be6324c6b734 ("s390x/tcg: Implement VECTOR ISOLATE STRING")
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
---
target/s390x/tcg/translate_vx.c.inc | 2
The existing code allocates a subtable for SLBIS entries, uses a
local variable to avoid a g_autofree footgun, and the cleanup code
causes heap corruption.
Rather than allocate a table, explicitly allocate each individual entry
and make the sub-table size static.
Signed-off-by: Gregory Price
---
1) Improve tests/tcg/s390x/Makefile.target to look for -march flags only once
2) Fix a problem with the vistr instruction
3) Add a test for the vistr instruction
Thomas Huth (3):
tests/tcg/s390x: Test compiler flags only once, not every time
target/s390x: Fix emulation of the VISTR instruction
Makes the size of the allocated cdat table static (6 entries),
flattens the code, and reduces the number of exit conditions
Signed-off-by: Gregory Price
---
hw/mem/cxl_type3.c | 52 --
1 file changed, 22 insertions(+), 30 deletions(-)
diff --git a/hw/
For style - pulling these validations ahead flattens the code.
Signed-off-by: Gregory Price
---
hw/mem/cxl_type3.c | 193 ++---
1 file changed, 96 insertions(+), 97 deletions(-)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 94bc439d89..43b2b9
Included in this response is a recommended patch set on top of this
patch that resolves a number of issues, including style and a heap
corruption bug.
The purpose of this patch set is to refactor the CDAT initialization
code to support future patch sets that will introduce multi-region
support in
The CDAT can contain multiple entries for multiple memory regions, this
will allow us to re-use the initialization code when volatile memory
region support is added.
Signed-off-by: Gregory Price
---
hw/mem/cxl_type3.c | 137 -
1 file changed, 72 insert
This fixes checkpatch errors in the prior commit.
Signed-off-by: Gregory Price
---
hw/mem/cxl_type3.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 3fa5d70662..94bc439d89 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/
On Tue, Oct 11, 2022 at 06:41:52PM -0400, Peter Xu wrote:
> NOTE: mark patchset RFC because "make check" will easily fail; but I didn't
> yet dig into why as I'm not familiar with the code paths that triggers, it
> can be bugs hidden or something I missed. So RFC to just have some thoughts.
I jus
On 12/10/2022 17.38, Markus Armbruster wrote:
When you try to set qtest property "log" while the qtest object is
active, the error message blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chardev
socket,id=chrqt0,path=qtest.socket,server=o
On Wed, Oct 12, 2022 at 05:43:53PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > Don't take the bitmap mutex when sending pages, or when being throttled by
> > migration_rate_limit() (which is a bit tricky to call it here in ram code,
> > but seems still helpful).
In theory the virtio-iommu-pci could be plugged anywhere in the PCIe
topology and as long as the dt/acpi info are properly built this should
work. However at the moment we fail to do that because the
virtio-iommu-pci BDF is not computed at plug time and in that case
vms->virtio_iommu_bdf gets an in
Add some basic examples for the definition of cpu topology
in s390x.
Signed-off-by: Pierre Morel
---
docs/system/s390x/cpu_topology.rst | 80 ++
1 file changed, 80 insertions(+)
create mode 100644 docs/system/s390x/cpu_topology.rst
diff --git a/docs/system/s390x/cpu
* Peter Xu (pet...@redhat.com) wrote:
> Don't take the bitmap mutex when sending pages, or when being throttled by
> migration_rate_limit() (which is a bit tricky to call it here in ram code,
> but seems still helpful).
>
> It prepares for the possibility of concurrently sending pages in >1 thread
The S390 CPU topology accepts the smp.threads argument while
in reality it does not effectively allow multthreading.
Let's keep this behavior for machines older than 7.3 and
refuse to use threads in newer machines until multithreading
is really proposed to the guest by the machine.
Signed-off-by:
During a subsystem reset the Topology-Change-Report is cleared
by the machine.
Let's ask KVM to clear the Modified Topology Change Report (MTCR)
bit of the SCA in the case of a subsystem reset.
Signed-off-by: Pierre Morel
Reviewed-by: Nico Boehr
Reviewed-by: Janis Schoetterl-Glausch
---
targe
When the host supports the CPU topology facility, the PTF
instruction with function code 2 is interpreted by the SIE,
provided that the userland hypervizor activates the interpretation
by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extension.
The PTF instructions with function code 0 and 1 are interce
The KVM capability, KVM_CAP_S390_CPU_TOPOLOGY is used to
activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and
the topology facility for the guest in the case the topology
is available in QEMU and in KVM.
Signed-off-by: Pierre Morel
---
target/s390x/kvm/kvm.c | 16
1 file ch
The migration can only take place if both source and destination
of the migration both use or both do not use the CPU topology
facility.
We indicate a change in topology during migration postload for the
case the topology changed between source and destination.
Signed-off-by: Pierre Morel
---
i
The guest can use the STSI instruction to get a buffer filled
with the CPU topology description.
Let us implement the STSI instruction for the basis CPU topology
level, level 2.
Signed-off-by: Pierre Morel
---
include/hw/s390x/cpu-topology.h | 3 +
target/s390x/cpu.h | 48 ++
S390 CPU topology is only allowed for s390-virtio-ccw-7.3 and
newer S390 machines.
We keep the possibility to disable the topology on these newer
machines with the property topology-disable.
Signed-off-by: Pierre Morel
---
include/hw/boards.h| 3 ++
include/hw/s390x/cpu-topology
Hi!
Execuse me, my fault. Overlooked TFR occurrences in second patch. I will
correct it.
ср, 12 окт. 2022 г., 18:43 Christian Schoenebeck :
> On Mittwoch, 12. Oktober 2022 17:17:46 CEST Bin Meng wrote:
> > Hi,
> >
> > On Wed, Oct 12, 2022 at 8:32 PM Nikita Ivanov
> wrote:
> > > There is a define
Hi,
The implementation of the CPU Topology in QEMU has been drastically
modified since the last patch series and the number of LOCs has been
greatly reduced.
1) Unnecessary objects have been removed, only a single S390Topology
object is created to support migration and reset.
2) The introduct
In the S390x CPU topology the core_id specifies the CPU address
and the position of the core withing the topology.
Let's build the topology based on the core_id.
s390x/cpu topology: core_id sets s390x CPU topology
In the S390x CPU topology the core_id specifies the CPU address
and the position of
* Peter Xu (pet...@redhat.com) wrote:
> Any call to ram_find_and_save_block() needs to take the bitmap mutex. We
> used to not take it for most of ram_save_complete() because we thought
> we're the only one left using the bitmap, but it's not true after the
> preempt full patchset applied, since t
From: Marc-André Lureau
The initial implementation was changing the pipe state created by GLib
to PIPE_NOWAIT, but it turns out it doesn't work (read/write returns an
error). Since reading may return less than the requested amount, it
seems to be non-blocking already. However, the IO operation ma
From: Marc-André Lureau
With a pipe or other reasons, read/write may return less than the
requested bytes. This happens with the test-io-channel-command test on
Windows. glib spawn code uses a binary pipe of 4096 bytes, and the first
read returns that much (although more are requested), for some
On Mittwoch, 12. Oktober 2022 14:28:23 CEST Nikita Ivanov wrote:
> Rename macro name to more transparent one and refactor
> it to expression.
>
> Signed-off-by: Nikita Ivanov
> ---
> chardev/char-fd.c| 2 +-
> chardev/char-pipe.c | 8 +---
> include/qemu/osdep.h | 8 +++-
> net/tap-
From: Marc-André Lureau
According to msdn documentation and Linux man pages, send() should try
to send as much as possible in blocking mode, while recv() may return
earlier with a smaller available amount, we should try to continue
send/recv from there.
Signed-off-by: Marc-André Lureau
Reviewed
This code contains heap corruption on free, and I think should be
refactored to pre-allocate all the entries we're interested in putting
into the table. This would flatten the code and simplify the error
handling steps.
Also, should we consider making a union with all the possible entries to
make
From: Marc-André Lureau
The following changes since commit ab44ea1059242ff2dbbde44e94468f6c6e5f87be:
Merge tag 'pull-testing-gdbstub-plugins-gitdm-111022-1' of
https://github.com/stsquad/qemu into staging (2022-10-11 15:31:27 -0400)
are available in the Git repository at:
https://gitlab.c
From: Marc-André Lureau
The /io/channel/command/echo tests run the reader side and the writer
side with the same underlying command channel. Setting the blocking mode
of the fd/handles while the other end is already reading/writing may
create issues (deadlock in win32 when earlier attempt of this
From: Marc-André Lureau
This has been tested under msys2 & windows 11. I haven't tried to make
it work with other environments yet, but that should be enough to
validate the channel-command implementation anyway.
Here are the changes:
- drop tests/ from fifo/pipe path, to avoid directory issues
From: Marc-André Lureau
Simplify qio_channel_command_new_spawn() with GSpawn API. This will
allow to build for WIN32 in the following patches.
As pointed out by Daniel Berrangé: there is a change in semantics here
too. The current code only touches stdin/stdout/stderr. Any other FDs
which do NOT
From: Marc-André Lureau
As described in:
https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread-name-in-native-code?view=vs-2022
SetThreadDescription() is available since Windows 10, version 1607 and
in some versions only by "Run Time Dynamic Linking". Its declaration is
not
On 10/12/22 14:11, Alex Bennée wrote:
Hi,
This is an attempt to improve our processes documentation by:
- adding an explicit section on maintainers
- reducing the up-front verbiage in patch submission
- emphasising the importance to respectful reviews
I'm sure the language could be impro
virtio-blk's dataplane BH completion batching mechanism is not enabled
by default and the performance results are mixed. If you develop a
different mechanism from scratch I think there's a good chance it
would work better :).
This looks like a queuing theory problem to me. It should be possible
to
On 10/12/22 14:11, Alex Bennée wrote:
+QEMU welcomes contributions to fix bugs, add functionality or improve
+the documentation. However, we get a lot of patches, and so we have
+some guidelines about submitting patches. If you follow these, you'll
While we're at it, "about submitting them".
P
On Mittwoch, 12. Oktober 2022 17:17:46 CEST Bin Meng wrote:
> Hi,
>
> On Wed, Oct 12, 2022 at 8:32 PM Nikita Ivanov wrote:
> > There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which
> > handles the same while loop.
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415
> >
> >
When you try to set a property that has no setter, the error message
blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio
QEMU 7.1.50 monitor - type 'help' for more information
(qemu) qom-set /machine type q35
Error: Insufficient permis
When you try to set virtio-rng property "filename" after the backend
has been completed with user_creatable_complete(), the error message
blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -object
rng-random,id=rng0 -device virtio-rng,id=vrng0,r
Markus Armbruster (4):
qom: Improve error messages when property has no getter or setter
backends: Improve error messages when property can no longer be set
qtest: Improve error messages when property can not be set right now
qerror: QERR_PERMISSION_DENIED is no longer used, drop
include/
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qerror.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index 596fce0c54..87ca83b155 100644
--- a/include/qapi/qmp/qerror.h
+++ b/include/qapi/qmp/qerror.h
@@ -50,9 +50,6 @@
#define
When you try to set qtest property "log" while the qtest object is
active, the error message blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chardev
socket,id=chrqt0,path=qtest.socket,server=on,wait=off -object
qtest,id=qt0,chardev=chrqt0,l
On 10/12/2022 10:39 PM, Klaus Jensen wrote:
I have been meaning to pick it up, but I got side-tracked. The polling
performance drop needs to be address as we discussed offline.
But the v4 looks pretty good and I can pick that up without the polling
support for now.
I've been using the v4 witho
Paolo Bonzini writes:
> On 10/12/22 14:17, Alex Bennée wrote:
>>> Container-based cross compilers have some issues which were overlooked
>>> when they were only used for TCG tests, but are more visible since
>>> firmware builds try to use them:
>> We seem to have dropped our gating somewhere. P
Hi,
On Wed, Oct 12, 2022 at 8:32 PM Nikita Ivanov wrote:
>
> There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which
> handles the same while loop.
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415
>
> Signed-off-by: Nikita Ivanov
> ---
> block/file-posix.c| 37 +
Hi
On Wed, Oct 12, 2022 at 4:32 PM Nikita Ivanov
wrote:
> There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which
> handles the same while loop.
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415
>
> Signed-off-by: Nikita Ivanov
>
Reviewed-by: Marc-André Lureau
> ---
>
On Thu, Oct 06, 2022 at 03:36:57PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This has been tested under msys2 & windows 11. I haven't tried to make
> it work with other environments yet, but that should be enough to
> validate the channel-command implementation anywa
On Thu, Oct 06, 2022 at 03:36:53PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> According to msdn documentation and Linux man pages, send() should try
> to send as much as possible in blocking mode, while recv() may return
> earlier with a smaller available amount, we s
On Wed, Oct 12, 2022 at 01:11:49PM +0100, Alex Bennée wrote:
> We don't currently have a clear place in the documentation to describe
> the rolls and responsibilities of a maintainer. Lets create one so we
s/roll/role/ in the commit description and the patch.
> can. I've moved a few small bits ou
On Wed, Oct 12, 2022 at 01:11:51PM +0100, Alex Bennée wrote:
> The bullet points are quite long and contain process tips. Move those
> bits of the bullet to the relevant sections and link to them. Use a
> table for nicer formatting of the checklist.
>
> Signed-off-by: Alex Bennée
> ---
> docs/de
On Wed, Oct 12, 2022 at 01:11:48PM +0100, Alex Bennée wrote:
> Hi,
>
> This is an attempt to improve our processes documentation by:
>
> - adding an explicit section on maintainers
> - reducing the up-front verbiage in patch submission
> - emphasising the importance to respectful reviews
>
>
On Okt 12 10:28, Stefan Hajnoczi wrote:
> On Fri, 26 Aug 2022 at 07:18, Jinhao Fan wrote:
> >
> > This patch series adds support for using a seperate iothread for NVMe
> > IO emulation, which brings the potential of applying polling. The
> > first two patches implements support for irqfd, which so
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
From: Bin Meng
At present the codes uses sigaction() to install signal handler with
a flag SA_RESETHAND. Such usage can be covered by the signal() API
that is a simplified interface to the general sigaction() facility.
Update to use signal() to install the signal handler, as it is
available on W
test-image-locking leaves some temporary files around - clean
them up. While we're at it, test-image-locking is a unit test,
so it should not use "qtest.*" for temporary file names. Give
them better names instead, so that it clear where the temporary
files come from.
Message-Id: <20221012085932.79
1 - 100 of 185 matches
Mail list logo
