Re: [PATCH 15/23] i386: Destructive vector helpers for AVX

2022-08-26 Thread Paolo Bonzini
Il sab 27 ago 2022, 01:46 Richard Henderson ha scritto: > +#define PACK_WIDTH (4 << SHIFT) > > Incorrect for AVX, it was correct with the ifdef in v1. > Perhaps just (SHIFT ? 8 : 4)? > That's intentional, the AVX patches change it to an #ifndef that AVX overrides. For now the purpose of the seri

Re: [PATCH v1 24/25] tests/docker: remove the Debian base images

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: We no longer use these in any of our images. Clean-up the remaining comments and documentation that reference them and remove from the build. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 2 +- .gitlab-ci.d/container-core.y

Re: [PATCH v1 22/25] tests/docker: update and flatten debian-toolchain

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not need anything from the base image to build the toolchain. This is used to build both the nios and microblaze toolchains. Signed-off-by: Alex Bennée ---

Re: [PATCH v1 23/25] tests/docker: remove FROM qemu/ support from docker.py

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a Dockerfile. Signed-off-by: Alex Bennée --- tests

Re: [PATCH v1 21/25] tests/docker: update and flatten debian-hexagon-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not need anything from the base image to build the toolchain. You apparently need some stuff from the base image since you're adding gcc, make and some other

Re: [PATCH v1 20/25] tests/docker: update and flatten debian-loongarch-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. In this case it is a binary distribution of the toolchain anyway. Sign

Re: [PATCH v1 19/25] tests/docker: update and flatten debian-amd64-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Now lcitool has support for building a x86_64 cross image we can use it for this. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include | 1 - .../dockerfiles/debian-amd64

Re: [PATCH v1 11/25] tests/docker: remove amd64 qemu/debian10 dependency

2022-08-26 Thread Thomas Huth
On 26/08/2022 23.47, Alex Bennée wrote: Thomas Huth writes: On 26/08/2022 19.21, Alex Bennée wrote: We missed removing this dependency when we flattened the build. Fixes 9e19fd7d4a (tests/docker: update debian-amd64 with lcitool) Signed-off-by: Alex Bennée --- tests/docker/Makefile.inclu

Re: [PATCH 23/23] i386: AVX+AES helpers prep

2022-08-26 Thread Richard Henderson
On 8/26/22 16:12, Paolo Bonzini wrote: From: Paul Brook Make the AES vector helpers AVX ready No functional changes to existing helpers Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-22-p...@nowt.org> Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 49 +

Re: [PATCH 15/23] i386: Destructive vector helpers for AVX

2022-08-26 Thread Richard Henderson
On 8/26/22 16:11, Paolo Bonzini wrote: From: Paul Brook These helpers need to take special care to avoid overwriting source values before the wole result has been calculated. Currently they use a dummy Reg typed variable to store the result then assign the whole register. This will cause 128 b

Re: [PATCH 07/23] i386: check SSE table flags instead of hardcoding opcodes

2022-08-26 Thread Richard Henderson
On 8/26/22 16:11, Paolo Bonzini wrote: Put more flags to work to avoid hardcoding lists of opcodes. The op7 case for SSE_OPF_CMP is included for homogeneity and because AVX needs it, but it is never used by SSE or MMX. Extracted from a patch by Paul Brook. Signed-off-by: Paolo Bonzini --- ta

[PATCH 21/23] i386: Rewrite blendv helpers

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Rewrite the blendv helpers so that they can easily be extended to support the AVX encodings, which make all 4 arguments explicit. No functional changes to the existing helpers Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-20-p...@nowt.org> Reviewed-by: Richard

Re: [PATCH 01/23] i386: do not use MOVL to move data between SSE registers

2022-08-26 Thread Richard Henderson
On 8/26/22 16:11, Paolo Bonzini wrote: Write down explicitly the load/store sequence. Extracted from a patch by Paul Brook. Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH 22/23] i386: AVX pclmulqdq prep

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Make the pclmulqdq helper AVX ready Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-21-p...@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 29 ++--- 1 file changed, 22 insertions(+), 7 d

[PATCH 18/23] i386: Dot product AVX helper prep

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Make the dpps and dppd helpers AVX-ready I can't see any obvious reason why dppd shouldn't work on 256 bit ymm registers, but both AMD and Intel agree that it's xmm only. Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-17-p...@nowt.org> Reviewed-by: Richard Hende

Re: [PATCH 10/23] i386: do not cast gen_helper_* function pointers

2022-08-26 Thread Richard Henderson
On 8/26/22 16:11, Paolo Bonzini wrote: Use a union to store the various possible kinds of function pointers, and access the correct one based on the flags. SSEOpHelper_table6 and SSEOpHelper_table7 right now only have one case, but this would change with AVX's 3- and 4-argument operations. Use

[PATCH 17/23] i386: reimplement AVX comparison helpers

2022-08-26 Thread Paolo Bonzini
From: Paul Brook AVX includes an additional set of comparison predicates, some of which our softfloat implementation does not expose as separate functions. Rewrite the helpers in terms of floatN_compare for future extensibility. Signed-off-by: Paul Brook Reviewed-by: Richard Henderson Message-

[PATCH 15/23] i386: Destructive vector helpers for AVX

2022-08-26 Thread Paolo Bonzini
From: Paul Brook These helpers need to take special care to avoid overwriting source values before the wole result has been calculated. Currently they use a dummy Reg typed variable to store the result then assign the whole register. This will cause 128 bit operations to corrupt the upper half o

Re: [PATCH 08/23] i386: isolate MMX code more

2022-08-26 Thread Richard Henderson
On 8/26/22 16:11, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 52 +++-- 1 file changed, 33 insertions(+), 19 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 849c40b685..f174b1d98

[PATCH 16/23] i386: Floating point arithmetic helper AVX prep

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Prepare the "easy" floating point vector helpers for AVX No functional changes to existing helpers. Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-16-p...@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 138 ++

[PATCH 13/23] i386: Rewrite simple integer vector helpers

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Rewrite the "simple" vector integer helpers in preperation for AVX support. While the current code is able to use the same prototype for unary (a = F(b)) and binary (a = F(b, c)) operations, future changes will cause them to diverge. No functional changes to existing helpers S

[PATCH 19/23] i386: Destructive FP helpers for AVX

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Perpare the horizontal atithmetic vector helpers for AVX These currently use a dummy Reg typed variable to store the result then assign the whole register. This will cause 128 bit operations to corrupt the upper half of the register, so replace it with explicit temporaries and e

Re: [PATCH 02/23] i386: formatting fixes

2022-08-26 Thread Richard Henderson
On 8/26/22 16:11, Paolo Bonzini wrote: Extracted from a patch by Paul Brook. Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH 20/23] i386: Misc AVX helper prep

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Fixup various vector helpers that either trivially exten to 256 bit, or don't have 256 bit variants. No functional changes to existing helpers Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-19-p...@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo B

[PATCH 14/23] i386: Misc integer AVX helper prep

2022-08-26 Thread Paolo Bonzini
From: Paul Brook More preparatory work for AVX support in various integer vector helpers No functional changes to existing helpers. Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-13-p...@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops

[PATCH 09/23] i386: Add size suffix to vector FP helpers

2022-08-26 Thread Paolo Bonzini
For AVX we're going to need both 128 bit (xmm) and 256 bit (ymm) variants of floating point helpers. Add the register type suffix to the existing *PS and *PD helpers (SS and SD variants are only valid on 128 bit vectors) No functional changes. Signed-off-by: Paul Brook Message-Id: <2022042422020

[PATCH 10/23] i386: do not cast gen_helper_* function pointers

2022-08-26 Thread Paolo Bonzini
Use a union to store the various possible kinds of function pointers, and access the correct one based on the flags. SSEOpHelper_table6 and SSEOpHelper_table7 right now only have one case, but this would change with AVX's 3- and 4-argument operations. Use unions there too, to keep the code more s

[PATCH 12/23] i386: Rewrite vector shift helper

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Rewrite the vector shift helpers in preperation for AVX support (3 operand form and 256 bit vectors). For now keep the existing two operand interface. No functional changes to existing helpers. Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-11-p...@nowt.org> Re

[PATCH 01/23] i386: do not use MOVL to move data between SSE registers

2022-08-26 Thread Paolo Bonzini
Write down explicitly the load/store sequence. Extracted from a patch by Paul Brook . Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index b7972f0ff5

[PATCH 23/23] i386: AVX+AES helpers prep

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Make the AES vector helpers AVX ready No functional changes to existing helpers Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-22-p...@nowt.org> Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 49 +++ 1 file cha

[PATCH 06/23] i386: Move 3DNOW decoder

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Handle 3DNOW instructions early to avoid complicating the MMX/SSE logic. Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-25-p...@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 30 +

[PATCH 11/23] i386: Add CHECK_NO_VEX

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Reject invalid VEX encodings on MMX instructions. Signed-off-by: Paul Brook Reviewed-by: Richard Henderson Message-Id: <20220424220204.2493824-7-p...@nowt.org> Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 26 ++ 1 file changed, 26 in

[PATCH 07/23] i386: check SSE table flags instead of hardcoding opcodes

2022-08-26 Thread Paolo Bonzini
Put more flags to work to avoid hardcoding lists of opcodes. The op7 case for SSE_OPF_CMP is included for homogeneity and because AVX needs it, but it is never used by SSE or MMX. Extracted from a patch by Paul Brook . Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 75 +

[PATCH 03/23] i386: Add ZMM_OFFSET macro

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Add a convenience macro to get the address of an xmm_regs element within CPUX86State. This was originally going to be the basis of an implementation that broke operations into 128 bit chunks. I scrapped that idea, so this is now a purely cosmetic change. But I think a worthwhile

[PATCH 05/23] i386: Rework sse_op_table6/7

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Add a flags field each row in sse_op_table6 and sse_op_table7. Initially this is only used as a replacement for the magic SSE41_SPECIAL pointer. The other flags are mostly relevant for the AVX implementation but can be applied to SSE as well. Signed-off-by: Paul Brook Message

[PATCH 08/23] i386: isolate MMX code more

2022-08-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 52 +++-- 1 file changed, 33 insertions(+), 19 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 849c40b685..f174b1d986 100644 --- a/target/i386/tcg/translate.c

[PATCH 04/23] i386: Rework sse_op_table1

2022-08-26 Thread Paolo Bonzini
From: Paul Brook Add a flags field each row in sse_op_table1. Initially this is only used as a replacement for the magic SSE_SPECIAL and SSE_DUMMY pointers, the other flags are mostly relevant for the AVX implementation but can be applied to SSE as well. Signed-off-by: Paul Brook Message-Id: <

[PATCH v2 00/23] target/i386: make most SSE helpers generic in the vector size

2022-08-26 Thread Paolo Bonzini
This is the first half of Paul's series from last April, reorganized to have no occurrence of YMM_ONLY or SHIFT == 2---meaning it can be committed without much fuss, even without a plan for the implementation of AVX decoding. In most cases this is done by using loops that apply the same code for a

[PATCH 02/23] i386: formatting fixes

2022-08-26 Thread Paolo Bonzini
Extracted from a patch by Paul Brook . Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 3237c1d8f9..25a2539d59 100644 --- a/target/i386/tcg/trans

Re: [PATCH v1 11/25] tests/docker: remove amd64 qemu/debian10 dependency

2022-08-26 Thread Alex Bennée
Thomas Huth writes: > On 26/08/2022 19.21, Alex Bennée wrote: >> We missed removing this dependency when we flattened the build. >> Fixes 9e19fd7d4a (tests/docker: update debian-amd64 with lcitool) >> Signed-off-by: Alex Bennée >> --- >> tests/docker/Makefile.include | 1 - >> 1 file change

[PATCH 2/3] target/avr: Only execute one interrupt at a time

2022-08-26 Thread Richard Henderson
We cannot deliver two interrupts simultaneously; the first interrupt handler must execute first. Signed-off-by: Richard Henderson --- target/avr/helper.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index 9614ccf3e4..34f1c

[PATCH 1/3] target/avr: Call avr_cpu_do_interrupt directly

2022-08-26 Thread Richard Henderson
There is no need to go through cc->tcg_ops when we know what value that must have. Signed-off-by: Richard Henderson --- target/avr/helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index 82284f8997..9614ccf3e4 100644 --- a

[PATCH 3/3] target/avr: Disable interrupts when env->skip set

2022-08-26 Thread Richard Henderson
This bit is not saved across interrupts, so we must delay delivering the interrupt until the skip has been processed. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1118 Signed-off-by: Richard Henderson --- target/avr/helper.c| 9 + target/avr/translate.c | 26 +

[PATCH 0/3] target/avr: Fix skips vs interrupts

2022-08-26 Thread Richard Henderson
Fixes https://gitlab.com/qemu-project/qemu/-/issues/1118 r~ Richard Henderson (3): target/avr: Call avr_cpu_do_interrupt directly target/avr: Only execute one interrupt at a time target/avr: Disable interrupts when env->skip set target/avr/helper.c| 23 ++- target/

Re: [PATCH v1 16/25] tests/docker: flatten debian-riscv64-test-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. You know that the debian11 base image is also just the bare minimum (in contrast to the debian10 image that added quite a b

Re: [PATCH v1 15/25] Deprecate 32 bit big-endian MIPS

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: It's becoming harder to maintain a cross-compiler to test this host architecture as the old stable Debian 10 ("Buster") moved into LTS which supports fewer architectures. For now: - mark it's deprecation in the docs - downgrade the containers to buil

Re: [PATCH for-7.2 v4 06/21] hw/ppc: set machine->fdt in sam460ex_load_device_tree()

2022-08-26 Thread Daniel Henrique Barboza
On 8/26/22 15:56, BALATON Zoltan wrote: On Fri, 26 Aug 2022, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' and 'info fdt' HMP commands for the sam460ex machine. This only works when booting with -kernel not when the firmware is used which creates its own DT. (The sa

Re: [PATCH v1 14/25] gitlab-ci: update aarch32/aarch64 custom runner jobs

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: The custom runner is now using 22.04 so we can drop our hacks to deal with broken libssh and glusterfs. The provisioning scripts will be updated in a separate commit. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 4 +--

Re: [PATCH v1 11/25] tests/docker: remove amd64 qemu/debian10 dependency

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: We missed removing this dependency when we flattened the build. Fixes 9e19fd7d4a (tests/docker: update debian-amd64 with lcitool) Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/dock

Re: [PATCH v1 10/25] tests/docker: remove tricore qemu/debian10 dependency

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: We missed removing this dependency when we flattened the build. Fixes: 39ce923732 (gitlab: enable a very minimal build with the tricore container) Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include

Re: [PATCH 01/18] i386: Rework sse_op_table1

2022-08-26 Thread Paolo Bonzini
Il ven 26 ago 2022, 01:39 Richard Henderson ha scritto: > On 8/25/22 15:13, Paolo Bonzini wrote: > > @@ -3112,6 +3165,7 @@ static void gen_sse(CPUX86State *env, DisasContext > *s, int b, > > { > > int b1, op1_offset, op2_offset, is_xmm, val; > > int modrm, mod, rm, reg; > > +str

Re: [PATCH v1 09/25] tests/docker: flatten debian-powerpc-test-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Fair point. I wonder whether the image also loads faster this way? Anyway: Reviewed-by: Thomas Huth

Re: [PATCH] KVM: dirty ring: add missing memory barrier

2022-08-26 Thread Paolo Bonzini
Yikes no, the patch is obviously bogus. Paolo Il ven 26 ago 2022, 17:59 Philippe Mathieu-Daudé ha scritto: > Hi Paolo, > > On Fri, Aug 26, 2022 at 1:17 PM Paolo Bonzini wrote: > >> The KVM_DIRTY_GFN_F_DIRTY flag ensures that the entry is valid. If >> the read of the fields are not ordered aft

Re: [PATCH v1 08/25] tests/docker: update and flatten debian-sparc64-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml

Re: [PATCH v1 07/25] tests/docker: update and flatten debian-sh4-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml

Re: [PATCH v1 06/25] tests/docker: update and flatten debian-mips64-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml

Re: [PATCH v1 05/25] tests/docker: update and flatten debian-m68k-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml

Re: [PATCH v1 04/25] tests/docker: update and flatten debian-hppa-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml

Re: [PATCH v1 03/25] tests/docker: update and flatten debian-alpha-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml

Re: [PATCH v1 02/25] tests/avocado: reduce the default timeout to 120s

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: We should be aiming to keep our tests under 2 minutes so lets reduce the default timeout to that. Tests that we know take longer should explicitly set a longer timeout. Signed-off-by: Alex Bennée --- tests/avocado/avocado_qemu/__init__.py | 2 +- 1 fil

[ANNOUNCE] QEMU 7.1.0-rc4 is now available

2022-08-26 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 7.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-7.1.0-rc4.tar.xz http://downlo

Re: [PATCH v1 01/25] tests/avocado: split the AST2x00Machine classes

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: The SDK tests take a lot longer to run and hence need a longer timeout. As they run well over the 60 second maximum for CI lets also disable them for CI as well. I suspect they also suffer from the inability to detect the login prompt due to no newlines be

Re: [PATCH for-7.2 v4 06/21] hw/ppc: set machine->fdt in sam460ex_load_device_tree()

2022-08-26 Thread BALATON Zoltan
On Fri, 26 Aug 2022, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' and 'info fdt' HMP commands for the sam460ex machine. This only works when booting with -kernel not when the firmware is used which creates its own DT. (The same is true for pegasos2 but there VOF is th

Re: [PATCH v1 18/25] tests/lcitool: bump to latest version

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: We need this to be able to cleanly build the x86 cross images. There are a few minor updates triggered by lcitool-refresh. Maybe mention that this will add "libslirp" to the freebsd vars - which will be helpful when we finally remove the slirp submodule

Re: [PATCH v1 17/25] tests/docker: update and flatten debian-all-test-cross

2022-08-26 Thread Thomas Huth
On 26/08/2022 19.21, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We also need to ensure we install clang as it is used for those builds as well. It would be nice to port this to lcitool but for now this will do. Signed-off-by: Alex

Re: [PATCH 27/51] tests/qtest: Use send/recv for socket communication

2022-08-26 Thread Thomas Huth
On 26/08/2022 16.59, Bin Meng wrote: On Thu, Aug 25, 2022 at 9:04 PM Thomas Huth wrote: On 24/08/2022 11.40, Bin Meng wrote: From: Xuzhou Cheng Socket communication in the libqtest and libqmp codes uses read() and write() which work on any file descriptor on *nix, and sockets in *nix are an

Re: [PATCH 2/2] tpm_emulator: Have swtpm relock storage upon migration fall-back

2022-08-26 Thread Stefan Berger
On 8/26/22 11:46, Stefan Berger wrote: Swtpm may release the lock once the last one of its state blobs has been migrated out. In case of VM migration failure QEMU now needs to notify swtpm that it should again take the lock, which it can otherwise only do once it has received the first TPM com

[PATCH v1 25/25] gitlab-ci: Only use one process in Windows jobs for compilation

2022-08-26 Thread Alex Bennée
From: Thomas Huth The Windows jobs are currently aborting at weird places - and there's the suspicion that it's due to memory constraints in the Windows containers. Let's switch to single-threaded compilation to decrease the pressure on the memory load, and to make the jobs more deterministic for

[PATCH v1 16/25] tests/docker: flatten debian-riscv64-test-cross

2022-08-26 Thread Alex Bennée
Flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include | 1 - .../dock

[PATCH v1 19/25] tests/docker: update and flatten debian-amd64-cross

2022-08-26 Thread Alex Bennée
Now lcitool has support for building a x86_64 cross image we can use it for this. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include | 1 - .../dockerfiles/debian-amd64-cross.docker | 178 -- t

[PATCH v1 23/25] tests/docker: remove FROM qemu/ support from docker.py

2022-08-26 Thread Alex Bennée
We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a Dockerfile. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 38 ++--

[PATCH v1 20/25] tests/docker: update and flatten debian-loongarch-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. In this case it is a binary distribution of the toolchain anyway. Signed-off-by: Alex Bennée --- tests/docker/

[PATCH v1 24/25] tests/docker: remove the Debian base images

2022-08-26 Thread Alex Bennée
We no longer use these in any of our images. Clean-up the remaining comments and documentation that reference them and remove from the build. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 2 +- .gitlab-ci.d/container-core.yml | 5 .gitlab-ci.d/containe

[PATCH v1 21/25] tests/docker: update and flatten debian-hexagon-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not need anything from the base image to build the toolchain. Signed-off-by: Alex Bennée --- .../docker/dockerfiles/debian-hexagon-cross.docker | 13 ++--- .../dockerfiles/debian-loongarch-c

[PATCH v1 22/25] tests/docker: update and flatten debian-toolchain

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not need anything from the base image to build the toolchain. This is used to build both the nios and microblaze toolchains. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include

Re: New feature shout outs for KVM Forum QEMU Status Report

2022-08-26 Thread Paolo Bonzini
- almost all compilation tests moved to Meson - this leaves configure to do compiler detection and prepare the dependencies (submodules, in the future python venv) - compiler detection for tests/tcg and firmware moved to configure, enabling cross compilation of firmware - -audio as a replaceme

[PATCH v1 15/25] Deprecate 32 bit big-endian MIPS

2022-08-26 Thread Alex Bennée
It's becoming harder to maintain a cross-compiler to test this host architecture as the old stable Debian 10 ("Buster") moved into LTS which supports fewer architectures. For now: - mark it's deprecation in the docs - downgrade the containers to build TCG tests only - drop the cross builds f

[PATCH v1 18/25] tests/lcitool: bump to latest version

2022-08-26 Thread Alex Bennée
We need this to be able to cleanly build the x86 cross images. There are a few minor updates triggered by lcitool-refresh. Signed-off-by: Alex Bennée --- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- tests/docker/dockerfiles/opensuse-

[PATCH v1 11/25] tests/docker: remove amd64 qemu/debian10 dependency

2022-08-26 Thread Alex Bennée
We missed removing this dependency when we flattened the build. Fixes 9e19fd7d4a (tests/docker: update debian-amd64 with lcitool) Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.

[PATCH v1 17/25] tests/docker: update and flatten debian-all-test-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We also need to ensure we install clang as it is used for those builds as well. It would be nice to port this to lcitool but for now this will do. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross

[PATCH v1 09/25] tests/docker: flatten debian-powerpc-test-cross

2022-08-26 Thread Alex Bennée
Flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include| 1 - .../dockerfi

[PATCH v1 12/25] tests/vm: Remove obsolete Fedora VM test

2022-08-26 Thread Alex Bennée
From: Thomas Huth It's still based on Fedora 30 - which is not supported anymore by QEMU since years. Seems like nobody is using (and refreshing) this, and it's easier to test this via a container anyway, so let's remove this now. Signed-off-by: Thomas Huth Message-Id: <20220822175317.190551-1-

[PATCH v1 10/25] tests/docker: remove tricore qemu/debian10 dependency

2022-08-26 Thread Alex Bennée
We missed removing this dependency when we flattened the build. Fixes: 39ce923732 (gitlab: enable a very minimal build with the tricore container) Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include| 1 - 2 files changed, 2 deletions(-) diff

[PATCH v1 14/25] gitlab-ci: update aarch32/aarch64 custom runner jobs

2022-08-26 Thread Alex Bennée
The custom runner is now using 22.04 so we can drop our hacks to deal with broken libssh and glusterfs. The provisioning scripts will be updated in a separate commit. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 4 +-- ...4-aarch32.yml => ubuntu-22.04-aarch32.y

[PATCH v1 08/25] tests/docker: update and flatten debian-sparc64-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makef

[PATCH v1 13/25] gitlab-ci/custom-runners: Disable -static-pie for ubuntu-20.04-aarch64

2022-08-26 Thread Alex Bennée
From: Richard Henderson The project has reached the magic size at which we see /usr/aarch64-linux-gnu/lib/libc.a(init-first.o): in function `__libc_init_first': (.text+0x10): relocation truncated to fit: R_AARCH64_LD64_GOTPAGE_LO15 against \ symbol `__environ' defined in .bss section in /usr/a

[PATCH v1 05/25] tests/docker: update and flatten debian-m68k-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile

[PATCH v1 06/25] tests/docker: update and flatten debian-mips64-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml| 1 - tests/docker/Makefi

[PATCH v1 04/25] tests/docker: update and flatten debian-hppa-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile

[PATCH v1 07/25] tests/docker: update and flatten debian-sh4-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.

[PATCH v1 01/25] tests/avocado: split the AST2x00Machine classes

2022-08-26 Thread Alex Bennée
The SDK tests take a lot longer to run and hence need a longer timeout. As they run well over the 60 second maximum for CI lets also disable them for CI as well. I suspect they also suffer from the inability to detect the login prompt due to no newlines being processed. Signed-off-by: Alex Bennée

[PATCH v1 02/25] tests/avocado: reduce the default timeout to 120s

2022-08-26 Thread Alex Bennée
We should be aiming to keep our tests under 2 minutes so lets reduce the default timeout to that. Tests that we know take longer should explicitly set a longer timeout. Signed-off-by: Alex Bennée --- tests/avocado/avocado_qemu/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH 01/13] linux-user: Add missing signals in strace output

2022-08-26 Thread Helge Deller
* Richard Henderson : > On 8/26/22 07:18, Helge Deller wrote: > > +if (arg < _NSIG) > > +signal_name = target_signal_to_host_signal_table[arg]; > (1) static const char * const > (2) target_signal_name -- there's no "host" about this. > Oh, and _NSIG is a host thing. Leave the array a

[PATCH v1 03/25] tests/docker: update and flatten debian-alpha-cross

2022-08-26 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefil

[PATCH v1 for 7.2 00/25] testing updates and mips deprecation

2022-08-26 Thread Alex Bennée
Hi, This is the first testing series for 7.2 once the tree opens. Along with the usual small collection of tweaks and fixes I also finish the effort to remove our internally layered Dockerfiles. This is a first step to removing the dependency on docker.py totally and hopefully improving the cachin

New feature shout outs for KVM Forum QEMU Status Report

2022-08-26 Thread Alex Bennée
Hi Maintainers, Are there any features that got added in the last year (since KVM Forum 2021) that you think deserve more recognition? If so please reply to this thread (or privately to me if you want) and let me know what feature landed and why it is so cool. The reward could well be a bullet po

Re: [PATCH 18/18] i386: AVX+AES helpers prep

2022-08-26 Thread Richard Henderson
On 8/25/22 15:14, Paolo Bonzini wrote: +for (i = 0 ; i < 2 << SHIFT ; i++) { + int j = i & 3; +d->L(i) = rk.L(i) ^ bswap32(AES_Td0[st.B(AES_ishifts[4 * j + 0])] ^ It that a tab? Seem to be several of them. Otherwise, Reviewed-by: Richard Henderson r~

[PATCH v8 7/7] docs/zoned-storage: add zoned device documentation

2022-08-26 Thread Sam Li
Add the documentation about the zoned device support to virtio-blk emulation. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- docs/devel/zoned-storage.rst | 41 ++ docs/system/qemu-block-drivers.rst.inc | 6 2 files changed, 47 insertions(+) creat

Re: [PATCH] tpm_crb: Avoid backend startup just before shutdown under Xen

2022-08-26 Thread Stefan Berger
On 8/26/22 12:15, Ross Lagerwall wrote: From: Stefan Berger Sent: Friday, August 26, 2022 4:20 PM To: Ross Lagerwall ; Stefan Berger Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] tpm_crb: Avoid backend startup just before shutdown under Xen On 8/26/22 10:38, Ross Lagerwall wrote: Whe

[PATCH v8 6/7] qemu-iotests: test new zone operations

2022-08-26 Thread Sam Li
We have added new block layer APIs of zoned block devices. Test it with: Create a null_blk device, run each zone operation on it and see whether reporting right zone information. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/tests/zoned.out | 53 ++ t

  1   2   3   4   >