Re: [PATCH v8 11/12] vdpa: Add virtio-net mac address via CVQ at start

2022-08-10 Thread Eugenio Perez Martin
On Wed, Aug 10, 2022 at 7:09 AM Jason Wang wrote: > > On Wed, Aug 10, 2022 at 1:40 AM Eugenio Pérez wrote: > > > > This is needed so the destination vdpa device see the same state a the > > guest set in the source. > > > > Signed-off-by: Eugenio Pérez > > --- > > v8: > > * Delete unneeded copy f

Re: [PATCH v8 00/12] NIC vhost-vdpa state restore via Shadow CVQ

2022-08-10 Thread Eugenio Perez Martin
On Tue, Aug 9, 2022 at 7:43 PM Eugenio Pérez wrote: > > CVQ of net vhost-vdpa devices can be intercepted since the addition of x-svq. > The virtio-net device model is updated. The migration was blocked because > although the state can be megrated between VMM it was not possible to restore > on the

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-10 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > This is just moving qapi-gen.py and related subdir to qemu-common, to >> > ease review and proceed step by step. The fol

Re: [PATCH 1/2] hw/arm/virt: Improve address assignment for highmem IO regions

2022-08-10 Thread Gavin Shan
Hi Marc, On 8/8/22 7:17 PM, Marc Zyngier wrote: On Wed, 03 Aug 2022 14:02:04 +0100, Gavin Shan wrote: On 8/3/22 5:01 PM, Marc Zyngier wrote: On Wed, 03 Aug 2022 04:01:04 +0100, Gavin Shan wrote: On 8/2/22 7:41 PM, Eric Auger wrote: On 8/2/22 08:45, Gavin Shan wrote: There are 3 highmem IO

Re: [PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-10 Thread David Gibson
On Wed, Aug 10, 2022 at 04:40:18PM -0300, Daniel Henrique Barboza wrote: > > > On 8/8/22 01:36, David Gibson wrote: > > On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote: > > > To support printing string properties in 'info fdt' we need to determine > > > whether a void data

Re: [PATCH v3 2/4] target/s390x: Make translator stop before the end of a page

2022-08-10 Thread Richard Henderson
On 8/8/22 10:10, Ilya Leoshkevich wrote: Right now translator stops right *after* the end of a page, which breaks reporting of fault locations when the last instruction of a multi-insn translation block crosses a page boundary. Signed-off-by: Ilya Leoshkevich --- include/exec/translator.h

Re: [BUG] cxl can not create region

2022-08-10 Thread Bobo WL
On Tue, Aug 9, 2022 at 11:17 PM Dan Williams wrote: > > Bobo WL wrote: > > Hi Dan, > > > > Thanks for your reply! > > > > On Mon, Aug 8, 2022 at 11:58 PM Dan Williams > > wrote: > > > > > > What is the output of: > > > > > > cxl list -MDTu -d decoder0.0 > > > > > > ...? It might be the case

[PATCH v1 5/6] hw/loongarch: Add hotplug handler for machine

2022-08-10 Thread Xiaojuan Yang
Add hotplug handler for LoongArch virt machine and now only support the dynamic sysbus device. Signed-off-by: Xiaojuan Yang --- hw/loongarch/virt.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 3976e8a058..a3

[PATCH v1 4/6] hw/loongarch: Add platform bus support

2022-08-10 Thread Xiaojuan Yang
Add platform bus support and add the bus information such as address, size, irq number to FDT table. Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig| 1 + hw/loongarch/virt.c | 33 + include/hw/loongarch/virt.h | 1 + include/hw/pci-host/ls

[PATCH v1 1/6] hw/loongarch: Remove vga device when loongarch init

2022-08-10 Thread Xiaojuan Yang
Remove the vga device when loongarch machine init and we will support other display device in the future. Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig | 1 - hw/loongarch/virt.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig index a99

[PATCH v1 0/6] Add funtions for LoongArch virt machine

2022-08-10 Thread Xiaojuan Yang
This series add some new functions such as fw_cfg dma, platform bus, hotplug handler for LoongArch virt machine, And remove the default vga display device, using ramfb to replace it. Changes for v1: 1. Remove default vga device. 2. Support fw_cfg dma function. 3. Add interrupt information to FDT t

[PATCH v1 3/6] hw/loongarch: Add interrupt information to FDT table

2022-08-10 Thread Xiaojuan Yang
Add interrupt information to FDT table, such as interrupt controller info, compatiable info, etc. Signed-off-by: Xiaojuan Yang --- hw/loongarch/virt.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 4f833a2044..56

[PATCH v1 6/6] hw/loongarch: Add RAMFB to dynamic_sysbus_devices list

2022-08-10 Thread Xiaojuan Yang
Add RAMFB device to dynamic_sysbus_devices list so that it can be hotpluged to the machine. Signed-off-by: Xiaojuan Yang --- hw/loongarch/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index a3dd35d579..1e1dc699ef 100644 --- a/hw/loongarch/

[PATCH v1 2/6] hw/loongarch: Support fw_cfg dma function

2022-08-10 Thread Xiaojuan Yang
Support fw_cfg dma function for LoongArch virt machine. Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig | 1 + hw/loongarch/fw_cfg.c | 3 ++- hw/loongarch/virt.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig index 73c5

Re: [PATCH 2/3] hw/ssi: fixup coverity issue

2022-08-10 Thread Bin Meng
On Thu, Aug 11, 2022 at 8:58 AM Wilfred Mallawa wrote: > > From: Wilfred Mallawa > > This patch addresses the coverity issues specified in [1], > as suggested, `FIELD_DP32()`/`FIELD_EX32()` macros have been > implemented to clean up the code. > > Additionally, the `EVENT_ENABLE` register is corre

[PATCH 3/3] hw/ssi: fixup/add rw1c functionality

2022-08-10 Thread Wilfred Mallawa
From: Wilfred Mallawa This patch adds the `rw1c` functionality to the respective registers. The status fields are cleared when the respective field is set. Signed-off-by: Wilfred Mallawa --- hw/ssi/ibex_spi_host.c | 36 +++--- include/hw/ssi/ibex_spi_host.h

[PATCH 1/3] hw/ssi: fixup typos in ibex_spi_host

2022-08-10 Thread Wilfred Mallawa
From: Wilfred Mallawa This patch fixes up minor typos in ibex_spi_host Signed-off-by: Wilfred Mallawa --- hw/ssi/ibex_spi_host.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ssi/ibex_spi_host.c b/hw/ssi/ibex_spi_host.c index d14580b409..601041d719 100644 --- a/h

[PATCH 2/3] hw/ssi: fixup coverity issue

2022-08-10 Thread Wilfred Mallawa
From: Wilfred Mallawa This patch addresses the coverity issues specified in [1], as suggested, `FIELD_DP32()`/`FIELD_EX32()` macros have been implemented to clean up the code. Additionally, the `EVENT_ENABLE` register is correctly updated to addr of `0x34`. [1] https://www.mail-archive.com/qemu

Re: [PATCH v9 3/3] target/riscv: Add vstimecmp support

2022-08-10 Thread Weiwei Li
在 2022/8/11 上午2:45, Atish Patra 写道: vstimecmp CSR allows the guest OS or to program the next guest timer interrupt directly. Thus, hypervisor no longer need to inject the timer interrupt to the guest if vstimecmp is used. This was ratified as a part of the Sstc extension. Reviewed-by: Alistair

Missing dll

2022-08-10 Thread Peter Butler
In x64 win10 I today I d/l QEMU into new directory. Then navigated to that dir and… qemu-system-aarch64 -boot d -cdrom f:\Downloads\debian-11.4.0-arm64-netinst.iso -m 2048 Error message:…libncursesw6.dll not found… Please help Thank you

Re: [PATCH v4 5/6] hw/mips: use qemu_fdt_setprop_strings()

2022-08-10 Thread Alistair Francis
On Wed, Aug 10, 2022 at 4:58 AM Ben Dooks wrote: > > Change to using qemu_fdt_setprop_strings() helper in hw/mips. > > Signed-off-by: Ben Dooks > Reviewed-by: Peter Maydell Reviewed-by: Alistair Francis Alistair > --- > hw/mips/boston.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 del

[ANNOUNCE] QEMU 7.1.0-rc2 is now available

2022-08-10 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 7.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-7.1.0-rc2.tar.xz http://downlo

Re: [PATCH v4 3/6] hw/riscv: use qemu_fdt_setprop_strings() for string arrays

2022-08-10 Thread Alistair Francis
On Wed, Aug 10, 2022 at 4:58 AM Ben Dooks wrote: > > Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. > > Signed-off-by: Ben Dooks Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/sifive_u.c | 18 +- > hw/riscv/spike.c| 7 ++- > hw/riscv/v

Re: [PATCH v4 4/6] hw/core: use qemu_fdt_setprop_strings()

2022-08-10 Thread Alistair Francis
On Wed, Aug 10, 2022 at 5:13 AM Ben Dooks wrote: > > Change to using the qemu_fdt_setprop_strings() helper in > hw/core code. > > Signed-off-by: Ben Dooks Reviewed-by: Alistair Francis Alistair > --- > hw/core/guest-loader.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(

Re: [PATCH v4 2/6] hw/core: don't check return on qemu_fdt_setprop_string_array()

2022-08-10 Thread Alistair Francis
On Wed, Aug 10, 2022 at 5:08 AM Ben Dooks wrote: > > The qemu_fdt_setprop_string_array() does not return error codes and > will call exit() if any of the fdt calls fails (and should print an > error with the node being altered). This is done to prepare for the > change for qemu_fdt_setprop_strings

Re: [PATCH v4 18/24] ppc/ppc405: QOM'ify MAL

2022-08-10 Thread BALATON Zoltan
On Tue, 9 Aug 2022, Cédric Le Goater wrote: The Memory Access Layer (MAL) controller is currently modeled as a DCR device with 4 IRQs. Also drop the ppc4xx_mal_init() helper and adapt the sam460ex machine. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h

Re: [PATCH v3] pc: hide linuxboot RNG seed behind a machine property

2022-08-10 Thread Michael S. Tsirkin
On Wed, Aug 10, 2022 at 09:25:05PM +0200, Paolo Bonzini wrote: > > > Il mer 10 ago 2022, 19:06 Michael S. Tsirkin ha scritto: > > > @@ -1387,6 +1405,7 @@ static void x86_machine_initfn(Object *obj) > >      x86ms->acpi = ON_OFF_AUTO_AUTO; > >      x86ms->pit = ON_OFF_AUTO_AUTO; >

Re: [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED

2022-08-10 Thread Richard Henderson
On 8/10/22 13:32, Vitaly Buka wrote: Sorry, I only noticed today that it's not submitted. Version is not critical for us, as we build from masters anyway. Richard, do you know a reason to consider this critical? On Wed, 10 Aug 2022 at 13:04, Peter Maydell > wrote

Re: [PATCH v3 3/4] target/i386: Make translator stop before the end of a page

2022-08-10 Thread Richard Henderson
On 8/8/22 10:10, Ilya Leoshkevich wrote: Right now translator stops right *after* the end of a page, which breaks reporting of fault locations when the last instruction of a multi-insn translation block crosses a page boundary. An implementation, like the one arm and s390x have, would require an

Re: [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED

2022-08-10 Thread Vitaly Buka
Sorry, I only noticed today that it's not submitted. Version is not critical for us, as we build from masters anyway. Richard, do you know a reason to consider this critical? On Wed, 10 Aug 2022 at 13:04, Peter Maydell wrote: > On Wed, 10 Aug 2022 at 21:00, Vitaly Buka wrote: > > > > How can we

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-10 Thread Murilo Opsfelder Araújo
Hi, Claudio. On 8/9/22 03:40, Claudio Imbrenda wrote: This patch adds support for asynchronously tearing down a VM on Linux. When qemu terminates, either naturally or because of a fatal signal, the VM is torn down. If the VM is huge, it can take a considerable amount of time for it to be cleane

Re: [PATCH v3 1/4] accel/tcg: Invalidate translations when clearing PAGE_EXEC

2022-08-10 Thread Richard Henderson
On 8/8/22 10:10, Ilya Leoshkevich wrote: After mprotect(addr, PROT_NONE), addr can still be executed if there are cached translations. Drop them. Signed-off-by: Ilya Leoshkevich --- accel/tcg/translate-all.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v3 2/4] target/s390x: Make translator stop before the end of a page

2022-08-10 Thread Richard Henderson
On 8/8/22 10:10, Ilya Leoshkevich wrote: Right now translator stops right*after* the end of a page, which breaks reporting of fault locations when the last instruction of a multi-insn translation block crosses a page boundary. Signed-off-by: Ilya Leoshkevich --- include/exec/translator.h|

Re: [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED

2022-08-10 Thread Peter Maydell
On Wed, 10 Aug 2022 at 21:00, Vitaly Buka wrote: > > How can we land this one? Pinging it a week ago rather than now would have been a good start :-( I think it got missed because you didn't cc the linux-user maintainer. Is this a critical fix for 7.1 or can we let it slip to 7.2 ? thanks -- PM

Re: [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED

2022-08-10 Thread Vitaly Buka
How can we land this one?

Re: [PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-10 Thread Daniel Henrique Barboza
On 8/8/22 01:36, David Gibson wrote: On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote: To support printing string properties in 'info fdt' we need to determine whether a void data might contain a string. Oh... sorry, obviously I hadn't read these later patches when I

Re: [PATCH for-7.2 v2 09/20] hw/ppc: set machine->fdt in pnv_reset()

2022-08-10 Thread Daniel Henrique Barboza
On 8/8/22 04:13, Cédric Le Goater wrote: On 8/8/22 08:47, Cédric Le Goater wrote: On 8/5/22 11:39, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' and 'info fdt' HMP commands for all powernv machines. I might have missed some emails but dumpdtb is already suppported :

Re: [PATCH v3] pc: hide linuxboot RNG seed behind a machine property

2022-08-10 Thread Paolo Bonzini
Il mer 10 ago 2022, 19:06 Michael S. Tsirkin ha scritto: > > @@ -1387,6 +1405,7 @@ static void x86_machine_initfn(Object *obj) > > x86ms->acpi = ON_OFF_AUTO_AUTO; > > x86ms->pit = ON_OFF_AUTO_AUTO; > > x86ms->pic = ON_OFF_AUTO_AUTO; > > +x86ms->linuxboot_randomness = ON_OFF_AUT

Re: [PULL 0/1] Linux user for 7.1 patches

2022-08-10 Thread Richard Henderson
-7.1-pull-request for you to fetch changes up to 3cd3df2a9584e6f753bb62a0028bd67124ab5532: linux-user: fix compat with glibc >= 2.36 sys/mount.h (2022-08-10 18:37:46 +0200) Pull request linux-user 20220810 fix compat with gl

RE: AST2600 support in QEMU

2022-08-10 Thread Shivi Fotedar
Cedric, Joel Thanks so much for the pointers. This definitely helps. We will get back to you with any further questions once we have looked them over. -Original Message- From: Cédric Le Goater Sent: Tuesday, August 9, 2022 10:50 PM To: Joel Stanley ; Shivi Fotedar ; Peter Delevoryas

[PATCH v3 1/4] hw/riscv: virt: fix uart node name

2022-08-10 Thread Conor Dooley
From: Conor Dooley "uart" is not a node name that complies with the dt-schema. Change the node name to "serial" to ix warnings seen during dt-validate on a dtbdump of the virt machine such as: /stuff/qemu/qemu.dtb: uart@1000: $nodename:0: 'uart@1000' does not match '^serial(@.*)?$'

Re: [PATCH 22/62] target/arm: Add secure parameter to get_phys_addr_pmsav8

2022-08-10 Thread Alex Bennée
Richard Henderson writes: > On 8/10/22 06:16, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Remove the use of regime_is_secure from get_phys_addr_pmsav8. >>> Since we already had a local variable named secure, use that. >>> >>> Signed-off-by: Richard Henderson >>> --- >>> target/a

[PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs

2022-08-10 Thread Conor Dooley
From: Conor Dooley The device trees produced automatically for the virt and spike machines fail dt-validate on several grounds. Some of these need to be fixed in the linux kernel's dt-bindings, but others are caused by bugs in QEMU. I mostly opted for what appeared to be the smallest change that

[PATCH v3 3/4] hw/riscv: virt: fix syscon subnode paths

2022-08-10 Thread Conor Dooley
From: Conor Dooley The reset and poweroff features of the syscon were originally added to top level, which is a valid path for a syscon subnode. Subsequently a reorganisation was carried out while implementing NUMA in which the subnodes were moved into the /soc node. As /soc is a "simple-bus", th

[PATCH v3 2/4] hw/riscv: virt: fix the plic's address cells

2022-08-10 Thread Conor Dooley
From: Conor Dooley When optional AIA PLIC support was added the to the virt machine, the address cells property was removed leading the issues with dt-validate on a dump from the virt machine: /stuff/qemu/qemu.dtb: plic@c00: '#address-cells' is a required property From schema: /stuff

[PATCH v9 0/3] Implement Sstc extension

2022-08-10 Thread Atish Patra
This series implements Sstc extension[1] which was ratified recently. The first patch is a prepartory patches while PATCH 2 adds stimecmp support while PATCH 3 adds vstimecmp support. This series is based on on top of upstream commit (faee5441a038). The series can also be found at https://github.

[PATCH v3 4/4] hw/core: fix platform bus node name

2022-08-10 Thread Conor Dooley
From: Conor Dooley "platform" is not a valid name for a bus node in dt-schema, so warnings can be see in dt-validate on a dump of the riscv virt dtb: /stuff/qemu/qemu.dtb: platform@400: $nodename:0: 'platform@400' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?

[PATCH v9 2/3] target/riscv: Add stimecmp support

2022-08-10 Thread Atish Patra
stimecmp allows the supervisor mode to update stimecmp CSR directly to program the next timer interrupt. This CSR is part of the Sstc extension which was ratified recently. Reviewed-by: Alistair Francis Signed-off-by: Atish Patra --- target/riscv/cpu.c | 9 target/riscv/cpu.h

[RFC 8/8] vdpa: Conditionally expose _F_LOG in vhost_net devices

2022-08-10 Thread Eugenio Pérez
Vhost-vdpa networking devices need to met a few conditions to be migratable. If SVQ is not enabled from the beginnig, to suspend the device to retrieve the vq state is the first requirement. However, qemu also needs to be able to intercept SVQ from the beginning. To be able to do so, the vdpa devi

[PATCH v9 1/3] hw/intc: Move mtimer/mtimecmp to aclint

2022-08-10 Thread Atish Patra
Historically, The mtime/mtimecmp has been part of the CPU because they are per hart entities. However, they actually belong to aclint which is a MMIO device. Move them to the ACLINT device. This also emulates the real hardware more closely. Reviewed-by: Anup Patel Reviewed-by: Alistair Francis

[RFC 6/8] vdpa: Negotiate _F_SUSPEND feature

2022-08-10 Thread Eugenio Pérez
This is needed for qemu to know it can suspend the device to retrieve its status and enable SVQ with it, so all the process is transparent to the guest. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-v

[PATCH v9 3/3] target/riscv: Add vstimecmp support

2022-08-10 Thread Atish Patra
vstimecmp CSR allows the guest OS or to program the next guest timer interrupt directly. Thus, hypervisor no longer need to inject the timer interrupt to the guest if vstimecmp is used. This was ratified as a part of the Sstc extension. Reviewed-by: Alistair Francis Signed-off-by: Atish Patra --

[RFC 1/8] [NOTMERGE] Update linux headers

2022-08-10 Thread Eugenio Pérez
Add _F_SUSPEND and suspend ioctl. TODO: This is still not merged in Linux upstream, so it may change. --- include/standard-headers/linux/vhost_types.h | 3 +++ linux-headers/linux/vhost.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/include/standard-headers/linux/vhost

[RFC 3/8] vhost: expose memory listener priority

2022-08-10 Thread Eugenio Pérez
We need to perform changes to vhost_vdpa devices before the memory listener inform them about the migration. Otherwise, it will reach them with no SVQ enabled and it cannot be guaranteed that it will be enabled afterwards. Expose the vhost memory listener priority so we can assign a lower one to n

[RFC 7/8] vdpa: Add feature_log member to vhost_vdpa

2022-08-10 Thread Eugenio Pérez
This way device's vhost_vdpa can make the choice about exposing or not the _F_LOG feature. At the moment is always false. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 1 + hw/virtio/vhost-vdpa.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/i

[RFC 2/8] vdpa: Extract get_backend_features from vhost_vdpa_get_as_num

2022-08-10 Thread Eugenio Pérez
The series reuses it to check for SUSPEND feature bit. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 11241ebac4..85b10799bd 100644 --- a/net/vhost-vdpa.c +++ b/net/v

[RFC 0/8] Dinamycally switch to vhost shadow virtqueues at vdpa net migration

2022-08-10 Thread Eugenio Pérez
It's possible to migrate vdpa net devices if they are shadowed from the start. But to always shadow the dataplane is effectively break its host passthrough, so its not convenient in vDPA scenarios. This series enables dynamically switching to shadow mode only at migration time. This allow full dat

[RFC 4/8] vdpa: Add log_enabled to VhostVDPAState

2022-08-10 Thread Eugenio Pérez
This enables VhostVDPAState to track the logging of the memory. It cannot be merged with s->always_svq because always_svq is immutable from the moment the device is parsed, and log_enabled must be enabled or disabled depending on the log state. Apart from that, they will affect the same to vhost

[RFC 5/8] vdpa: Add vdpa memory listener

2022-08-10 Thread Eugenio Pérez
This enable net/vdpa to restart the full device when a migration is started or stopped. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 87 1 file changed, 87 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index a035c89c34..4c

Re: [PATCH v4 19/24] ppc/ppc405: QOM'ify FPGA

2022-08-10 Thread BALATON Zoltan
On Wed, 10 Aug 2022, Daniel Henrique Barboza wrote: On 8/9/22 14:37, BALATON Zoltan wrote: On Tue, 9 Aug 2022, Cédric Le Goater wrote: Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 55 +- 1 file changed

Re: [PATCH v4 19/24] ppc/ppc405: QOM'ify FPGA

2022-08-10 Thread Daniel Henrique Barboza
On 8/9/22 14:37, BALATON Zoltan wrote: On Tue, 9 Aug 2022, Cédric Le Goater wrote: Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 55 +- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/

[PATCH v3] pc: hide linuxboot RNG seed behind a machine property

2022-08-10 Thread Paolo Bonzini
OVMF does not support Linux setup_data and it is not clear how to fix this, so disable the support for the random number seed for the 7.1 release. Using a property allows shipping the code even if it is disabled by default. The property name has "x-" prepended because the implementation might cha

Re: [PATCH v3] pc: hide linuxboot RNG seed behind a machine property

2022-08-10 Thread Michael S. Tsirkin
On Wed, Aug 10, 2022 at 06:59:42PM +0200, Paolo Bonzini wrote: > OVMF does not support Linux setup_data and it is not clear how to > fix this, so disable the support for the random number seed for the > 7.1 release. Using a property allows shipping the code even if it is > disabled by default. Th

[PULL 1/1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-10 Thread Laurent Vivier
From: Daniel P. Berrangé The latest glibc 2.36 has extended sys/mount.h so that it defines the FSCONFIG_* enum constants. These are historically defined in linux/mount.h, and thus if you include both headers the compiler complains: In file included from /usr/include/linux/fs.h:19,

[PULL 0/1] Linux user for 7.1 patches

2022-08-10 Thread Laurent Vivier
up to 3cd3df2a9584e6f753bb62a0028bd67124ab5532: linux-user: fix compat with glibc >= 2.36 sys/mount.h (2022-08-10 18:37:46 +0200) Pull request linux-user 20220810 fix compat with glibc >= 2.36 sys/m

Re: [PATCH v6 24/24] target/arm: Define neoverse-n1

2022-08-10 Thread Peter Maydell
On Wed, 10 Aug 2022 at 14:14, Zenghui Yu wrote: > The r4p1 TRM says that the Neoverse N1 core supports SPE (the value > of ID_AA64DFR0.PMSVer is 0b0001) but do we really support SPE > emulation in QEMU? > > The guest immediately received an unexpected exception (with EC==0, > at EFI stage) when I

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-10 Thread Laurent Vivier
Le 02/08/2022 à 18:41, Daniel P. Berrangé a écrit : The latest glibc 2.36 has extended sys/mount.h so that it defines the FSCONFIG_* enum constants. These are historically defined in linux/mount.h, and thus if you include both headers the compiler complains: In file included from /usr/include/li

Re: [PATCH v2 1/2] util/main-loop: Fix maximum number of wait objects for win32

2022-08-10 Thread Marc-André Lureau
On Wed, Aug 10, 2022 at 7:20 PM Bin Meng wrote: > On Wed, Aug 10, 2022 at 1:06 AM Marc-André Lureau > wrote: > > > > Hi > > > > On Tue, Aug 9, 2022 at 8:43 PM Bin Meng wrote: > >> > >> From: Bin Meng > >> > >> The maximum number of wait objects for win32 should be > >> MAXIMUM_WAIT_OBJECTS, no

Re: [PATCH 0/8] migration: introduce dirtylimit capability

2022-08-10 Thread Hyman
Ping. How about this series? hoping to get comments if anyone has played with it. Thanks ! Hyman 在 2022/7/23 15:49, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) Abstract This series added a new migration capability called "dirtylimit". It can be enabled when dirty ring

Re: [PATCH 22/62] target/arm: Add secure parameter to get_phys_addr_pmsav8

2022-08-10 Thread Richard Henderson
On 8/10/22 06:16, Alex Bennée wrote: Richard Henderson writes: Remove the use of regime_is_secure from get_phys_addr_pmsav8. Since we already had a local variable named secure, use that. Signed-off-by: Richard Henderson --- target/arm/ptw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 d

Re: [PATCH v2 1/2] util/main-loop: Fix maximum number of wait objects for win32

2022-08-10 Thread Bin Meng
On Wed, Aug 10, 2022 at 1:06 AM Marc-André Lureau wrote: > > Hi > > On Tue, Aug 9, 2022 at 8:43 PM Bin Meng wrote: >> >> From: Bin Meng >> >> The maximum number of wait objects for win32 should be >> MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. >> >> Fix the logic in qemu_add_wait_object(

Re: Shared memory between host and guest

2022-08-10 Thread Alex Bennée
"Lu, Jingdong" writes: > Hi experts, > > > > I have some basic questions regarding shared memory between host and guest > based on QEMU/KVM: > > > > 1, Can host and guest share the same block of physical memory? Ivshmem? Is it > continuous physical memory? > > > > 2, More specifically,

Re: [PATCH RFC v1 2/2] i386: reorder kvm_put_sregs2() and kvm_put_nested_state() when vCPU is reset

2022-08-10 Thread Vitaly Kuznetsov
Maxim Levitsky writes: > On Wed, 2022-08-10 at 16:00 +0200, Vitaly Kuznetsov wrote: >> Setting nested state upon migration needs to happen after kvm_put_sregs2() >> to e.g. have EFER.SVME set. This, however, doesn't work for vCPU reset: >> when vCPU is in VMX root operation, certain CR bits are l

Re: [PATCH RFC v1 1/2] i386: reset KVM nested state upon CPU reset

2022-08-10 Thread Maxim Levitsky
On Wed, 2022-08-10 at 16:00 +0200, Vitaly Kuznetsov wrote: > Make sure env->nested_state is cleaned up when a vCPU is reset, it may > be stale after an incoming migration, kvm_arch_put_registers() may > end up failing or putting vCPU in a weird state. > > Signed-off-by: Vitaly Kuznetsov > --- >  

Re: [PATCH v4 08/24] ppc/ppc4xx: Introduce a DCR device model

2022-08-10 Thread BALATON Zoltan
On Wed, 10 Aug 2022, Cédric Le Goater wrote: On 8/10/22 15:28, BALATON Zoltan wrote: On Wed, 10 Aug 2022, Cédric Le Goater wrote: On 8/9/22 19:21, BALATON Zoltan wrote: On Tue, 9 Aug 2022, Cédric Le Goater wrote: The Device Control Registers (DCR) of on-SoC devices are accessed by software th

Re: [PATCH RFC v1 2/2] i386: reorder kvm_put_sregs2() and kvm_put_nested_state() when vCPU is reset

2022-08-10 Thread Maxim Levitsky
On Wed, 2022-08-10 at 16:00 +0200, Vitaly Kuznetsov wrote: > Setting nested state upon migration needs to happen after kvm_put_sregs2() > to e.g. have EFER.SVME set. This, however, doesn't work for vCPU reset: > when vCPU is in VMX root operation, certain CR bits are locked and > kvm_put_sregs2() m

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-10 Thread Stefan Berger
On 8/3/22 04:52, Cédric Le Goater wrote: On 8/3/22 04:32, Iris Chen wrote: From: Iris Chen +++ b/hw/tpm/tpm_tis_spi.c @@ -0,0 +1,311 @@ +#include "qemu/osdep.h" +#include "hw/qdev-properties.h" +#include "migration/vmstate.h" +#include "hw/acpi/tpm.h" +#include "tpm_prop.h" +#include "t

Re: [PATCH v7 03/14] mm: Introduce memfile_notifier

2022-08-10 Thread Sean Christopherson
+Will On Wed, Aug 10, 2022, David Hildenbrand wrote: > On 10.08.22 11:22, Chao Peng wrote: > > On Fri, Aug 05, 2022 at 03:22:58PM +0200, David Hildenbrand wrote: > >> On 06.07.22 10:20, Chao Peng wrote: > >>> This patch introduces memfile_notifier facility so existing memory file > >>> subsystems

[PATCH RFC v1 1/2] i386: reset KVM nested state upon CPU reset

2022-08-10 Thread Vitaly Kuznetsov
Make sure env->nested_state is cleaned up when a vCPU is reset, it may be stale after an incoming migration, kvm_arch_put_registers() may end up failing or putting vCPU in a weird state. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm/kvm.c | 37 +++-- 1 file

Re: [PATCH v4 08/24] ppc/ppc4xx: Introduce a DCR device model

2022-08-10 Thread Cédric Le Goater
On 8/10/22 15:28, BALATON Zoltan wrote: On Wed, 10 Aug 2022, Cédric Le Goater wrote: On 8/9/22 19:21, BALATON Zoltan wrote: On Tue, 9 Aug 2022, Cédric Le Goater wrote: The Device Control Registers (DCR) of on-SoC devices are accessed by software through the use of the mtdcr and mfdcr instructi

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-10 Thread Stefan Berger
On 8/3/22 04:52, Cédric Le Goater wrote: On 8/3/22 04:32, Iris Chen wrote: From: Iris Chen A commit log telling us about this new device would be good to have. Signed-off-by: Iris Chen ---   configs/devices/arm-softmmu/default.mak |   1 +   hw/arm/Kconfig  |   5 +

Re: [PATCH for-7.2 v3 09/11] ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecs

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: The function assumes that we're always dealing with a PNV9_CHIP() object. This is not the case when the pnv-phb device belongs to a powernv10 machine. Change pnv_phb4_get_pec() to be able to work with PNV10_CHIP() if necessary. Signed-off-by: Dan

Re: [PATCH] tests/unit: fix a -Wformat-trunction warning

2022-08-10 Thread Philippe Mathieu-Daudé via
On 10/8/22 14:24, Markus Armbruster wrote: Typo in subject, it's -Wformat-truncation marcandre.lur...@redhat.com writes: From: Marc-André Lureau ../tests/test-qobject-input-visitor.c: In function ‘test_visitor_in_list’: ../tests/test-qobject-input-visitor.c:454:49: warning: ‘%d’ directive ou

Re: [PATCH for-7.2 v3 08/11] ppc/pnv: enable user created pnv-phb powernv9

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: Enable pnv-phb user created devices for powernv9 now that we have everything in place. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci-host/pnv_phb.c | 2 +- hw/pci-host/pnv_phb4_pec.c |

Re: [PATCH v8 3/3] target/riscv: Add vstimecmp support

2022-08-10 Thread Weiwei Li
在 2022/8/10 下午1:45, Atish Kumar Patra 写道: On Tue, Aug 9, 2022 at 6:33 PM Weiwei Li > wrote: 在 2022/8/10 上午3:34, Atish Kumar Patra 写道: On Tue, Aug 9, 2022 at 12:01 AM Weiwei Li mailto:liwei...@iscas.ac.cn>> wrote: 在 2022/8/9 上午1:20, Atish Ku

Re: [PATCH for-7.2 v3 07/11] ppc/pnv: add PHB4 helpers for user created pnv-phb

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: The PHB4 backend relies on a link with the corresponding PEC element. This is trivial to do during machine_init() time for default devices, but not so much for user created ones. pnv_phb4_get_pec() is a small variation of the function that was rev

Re: [PATCH for-7.1] cutils: Add missing dyld(3) include on macOS

2022-08-10 Thread Philippe Mathieu-Daudé via
+Thomas On 10/8/22 00:20, Philippe Mathieu-Daudé wrote: Commit 06680b15b4 moved qemu_*_exec_dir() to cutils but forgot to move the macOS dyld(3) include, resulting in the following error (when building with Homebrew GCC on macOS Monterey 12.4): [313/1197] Compiling C object libqemuutil.a.p/u

Re: [PATCH for-7.2 v3 10/11] ppc/pnv: user creatable pnv-phb for powernv10

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: Given that powernv9 and powernv10 uses the same pnv-phb backend, the logic to allow user created pnv-phbs for powernv10 is already in place. Let's flip the switch. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks,

[PATCH RFC v1 2/2] i386: reorder kvm_put_sregs2() and kvm_put_nested_state() when vCPU is reset

2022-08-10 Thread Vitaly Kuznetsov
Setting nested state upon migration needs to happen after kvm_put_sregs2() to e.g. have EFER.SVME set. This, however, doesn't work for vCPU reset: when vCPU is in VMX root operation, certain CR bits are locked and kvm_put_sregs2() may fail. As nested state is fully cleaned up upon vCPU reset (kvm_a

Re: Using QEMU for VRChat

2022-08-10 Thread Daniel P . Berrangé
On Wed, Aug 10, 2022 at 01:06:59PM +0200, danko babro wrote: > Dear QEMU dev team, > Recently a game called VRChat got a security update, implementing Easy Anti > Cheat into their game (pretty much spyware that logs everything happening > on the users PC) which made me want to install their game on

Re: [PATCH for-7.2 v3 06/11] ppc/pnv: enable user created pnv-phb for powernv8

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: The bulk of the work was already done by previous patches. Use defaults_enabled() to determine whether we need to create the default devices or not. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb.c | 9 +++-- hw/ppc/pnv.c

Re: [PATCH v2 2/3] softmmu/physmem: Remove the ifdef __linux__ around the pagesize functions

2022-08-10 Thread Claudio Imbrenda
On Wed, 10 Aug 2022 14:57:19 +0200 Thomas Huth wrote: > Now that host_memory_backend_pagesize() is not depending on the hugetlb > memory path handling anymore, we can also remove the #ifdef and the > TOCTTOU comment from the calling functions - the code should now work > equally well on all host

[PATCH RFC v1 0/2] i386: KVM: Fix 'system_reset' failures when vCPU is in VMX root operation

2022-08-10 Thread Vitaly Kuznetsov
It was discovered that Windows 11 with WSL2 (Hyper-V) enabled guests fail to reboot when QEMU's 'system_reset' command is issued. The problem appears to be that KVM_SET_SREGS2 fails because zeroed CR4 register value doesn't pass vmx_is_valid_cr4() check in KVM as certain bits can't be zero while in

Re: [PATCH v4 08/24] ppc/ppc4xx: Introduce a DCR device model

2022-08-10 Thread BALATON Zoltan
On Wed, 10 Aug 2022, Cédric Le Goater wrote: On 8/9/22 19:21, BALATON Zoltan wrote: On Tue, 9 Aug 2022, Cédric Le Goater wrote: The Device Control Registers (DCR) of on-SoC devices are accessed by software through the use of the mtdcr and mfdcr instructions. These are converted in transactions

Re: [PATCH for-7.2 v3 06/11] ppc/pnv: enable user created pnv-phb for powernv8

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: The bulk of the work was already done by previous patches. Use defaults_enabled() to determine whether we need to create the default devices or not. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks, C. --- hw/

Re: [PATCH v2 1/3] backends/hostmem: Fix support of memory-backend-memfd in qemu_maxrampagesize()

2022-08-10 Thread Claudio Imbrenda
On Wed, 10 Aug 2022 14:57:18 +0200 Thomas Huth wrote: > It is currently not possible yet to use "memory-backend-memfd" on s390x > with hugepages enabled. This problem is caused by qemu_maxrampagesize() > not taking memory-backend-memfd objects into account yet, so the code > in s390_memory_init()

Re: [PATCH for-7.2 v3 05/11] ppc/pnv: turn chip8->phbs[] into a PnvPHB* array

2022-08-10 Thread Cédric Le Goater
On 8/10/22 12:05, Daniel Henrique Barboza wrote: When enabling user created PHBs (a change reverted by commit 9c10d86fee) we were handling PHBs created by default versus by the user in different manners. The only difference between these PHBs is that one will have a valid phb3->chip that is assig

Re: [PATCH 29/62] target/arm: Add is_secure parameter to v7m_read_half_insn

2022-08-10 Thread Alex Bennée
Richard Henderson writes: > Remove the use of regime_is_secure from v7m_read_half_insn. > As it happens, both callers pass true, but that is a detail > of v7m_handle_execute_nsc we need not expose to the callee. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 27/62] target/arm: Add is_secure parameter to get_phys_addr_pmsav5

2022-08-10 Thread Alex Bennée
Richard Henderson writes: > Remove the use of regime_is_secure from get_phys_addr_pmsav5. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 0/3] Fix hugepages with memfd on s390x and clean up related code

2022-08-10 Thread Claudio Imbrenda
On Wed, 10 Aug 2022 14:57:17 +0200 Thomas Huth wrote: > The first patch fixes the problem that hugepages cannot be used via > the "memory-backend-memfd" object on s390x. The second and third patch > are some clean-ups that can be done after generalizing the code in the > first patch. thanks for

  1   2   >